[Bug 7184] Optionally exclude subpages from Special:Allpages and Special:Prefixindex
https://bugzilla.wikimedia.org/show_bug.cgi?id=7184 Waldir changed: What|Removed |Added CC||wal...@email.com -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 7184] Optionally exclude subpages from Special:Allpages and Special:Prefixindex
https://bugzilla.wikimedia.org/show_bug.cgi?id=7184 --- Comment #11 from duplicate...@googlemail.com 2012-08-06 20:27:47 UTC --- *** Bug 30964 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 7184] Optionally exclude subpages from Special:Allpages and Special:Prefixindex
https://bugzilla.wikimedia.org/show_bug.cgi?id=7184 --- Comment #10 from Max Semenik 2012-03-30 17:20:55 UTC --- page_is_subpage is quite pointless just for such small feature, but page_parent could be interesting for many uses. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 7184] Optionally exclude subpages from Special:Allpages and Special:Prefixindex
https://bugzilla.wikimedia.org/show_bug.cgi?id=7184 --- Comment #9 from Chad H. 2012-03-30 13:00:34 UTC --- (In reply to comment #7) > So , instead of changing the query , I could put if($hideSubPages) to prevent > subpages from being displayed on the page, but i thought that would be too > inefficient . That would make the UI confusing if you're expecting 50 results per page but you only seem to get 30. At the risk of opening a huge can of worms, how about introducing a page_is_subpage or page_parent field? Easily indexable. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 7184] Optionally exclude subpages from Special:Allpages and Special:Prefixindex
https://bugzilla.wikimedia.org/show_bug.cgi?id=7184 --- Comment #8 from akshay chugh 2012-03-30 12:58:02 UTC --- (In reply to comment #4) > Just 2 quick points: > > * Should it take into consideration which namespaces actually support > subpages? > For example on en.wikipedia.org the main article space does not have subpages > enabled because articles like [[I/O]] naturally contain a slash but are not > subpages. So this should check for [[mw:Manual:$wgNamespacesWithSubpages]] > > * I doubt %/% queries are using an index, which means they can't run on any > major site. Yes, i would rewrite the patch to take $wgNamespaceWithSubpages into account. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 7184] Optionally exclude subpages from Special:Allpages and Special:Prefixindex
https://bugzilla.wikimedia.org/show_bug.cgi?id=7184
akshay chugh changed:
What|Removed |Added
CC||chughaksha...@gmail.com
--- Comment #7 from akshay chugh 2012-03-30 12:55:28
UTC ---
(In reply to comment #5)
> A few points:
>
> > 'prefixhidesub' => 'Hide Sub Pages'
> Message key inconsistent with other messages on that special page, messages
> should use sentence case and consistent terminology ("subpages", not "sub
> pages").
>
> Spacing is not compliant with our coding style.
>
> Queries LIKE '%/%' are indeed impossible to be indexed, so a schema change
> would be required for this feature to work.
So , instead of changing the query , I could put if($hideSubPages) to prevent
subpages from being displayed on the page, but i thought that would be too
inefficient .
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 7184] Optionally exclude subpages from Special:Allpages and Special:Prefixindex
https://bugzilla.wikimedia.org/show_bug.cgi?id=7184 Sumana Harihareswara changed: What|Removed |Added Keywords||patch, reviewed CC||suma...@panix.com --- Comment #6 from Sumana Harihareswara 2012-03-30 04:45:48 UTC --- Marking patch reviewed. Akshay, can you revise your patch to respond to Max's and Krinkle's feedback? Thanks. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 7184] Optionally exclude subpages from Special:Allpages and Special:Prefixindex
https://bugzilla.wikimedia.org/show_bug.cgi?id=7184
Max Semenik changed:
What|Removed |Added
CC||maxsem.w...@gmail.com
--- Comment #5 from Max Semenik 2012-03-29 21:16:34 UTC
---
A few points:
> 'prefixhidesub' => 'Hide Sub Pages'
Message key inconsistent with other messages on that special page, messages
should use sentence case and consistent terminology ("subpages", not "sub
pages").
Spacing is not compliant with our coding style.
Queries LIKE '%/%' are indeed impossible to be indexed, so a schema change
would be required for this feature to work.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 7184] Optionally exclude subpages from Special:Allpages and Special:Prefixindex
https://bugzilla.wikimedia.org/show_bug.cgi?id=7184 Krinkle changed: What|Removed |Added CC||krinklem...@gmail.com --- Comment #4 from Krinkle 2012-03-29 11:12:11 UTC --- Just 2 quick points: * Should it take into consideration which namespaces actually support subpages? For example on en.wikipedia.org the main article space does not have subpages enabled because articles like [[I/O]] naturally contain a slash but are not subpages. So this should check for [[mw:Manual:$wgNamespacesWithSubpages]] * I doubt %/% queries are using an index, which means they can't run on any major site. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 7184] Optionally exclude subpages from Special:Allpages and Special:Prefixindex
https://bugzilla.wikimedia.org/show_bug.cgi?id=7184
--- Comment #3 from akshay chugh 2012-03-29 10:05:45
UTC ---
Created attachment 10348
--> https://bugzilla.wikimedia.org/attachment.cgi?id=10348
It provides a checkbox to filter out the sub pages.
The changes made are :-
In SpecialAllPages.php
1. $hideSubPages = $req->getBool('hideSub',false) - to get the value of
checkbox
2. change in SQL query
one more WHERE condition is added
'page_title NOT'.$dbr->buildLike($dbr->anyString(),'/',$dbr->anyString())
The same set of changes are made for SpecialPrefixIndex.php
In MessagesEn.php
'prefixhidesub' => 'Hide Sub Pages'
I havent added messages in other languages.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 7184] Optionally exclude subpages from Special:Allpages and Special:Prefixindex
https://bugzilla.wikimedia.org/show_bug.cgi?id=7184 akshay chugh changed: What|Removed |Added CC||subfa...@gmail.com --- Comment #2 from akshay chugh 2012-03-29 09:43:12 UTC --- *** Bug 29073 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
