[Bug 73556] PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571

2014-11-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=73556

--- Comment #2 from Krinkle krinklem...@gmail.com ---
@Nemo: Can you help get a test case? By getting a stack trace we'll narrow down
whehter this is from a file module, wiki module or other generated script. And
by getting the argument we'll identify the script in question.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 73556] PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571

2014-11-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=73556

James Forrester jforres...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jforres...@wikimedia.org
   Assignee|wikibugs-l@lists.wikimedia. |roan.katt...@gmail.com
   |org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 73556] PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571

2014-11-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=73556

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
Version|unspecified |1.25-git

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 73556] PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571

2014-11-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=73556

--- Comment #1 from Krinkle krinklem...@gmail.com ---
Excerpt:

  class JavaScriptMinifier {
  public static function minify( $s, $statementsOnOwnLine = false,
$maxLineLength = 1000 ) {
// ..

$out = '';
$pos = 0;
$length = strlen( $s );
$lineLength = 0;
$last = ';';
while( $pos  $length ) {
  // ..

  $out .= $token;
  $lineLength += $end - $pos;
  $last = $s[$end - 1];
  $pos = $end;


The while loop manipulates $end to reflect where we are in the code. In some
cases it advanced artificially based on changes or assumptions it made. I guess
it must be off in some cases.

Does this one happen often on translatewiki? Can you produce a stack trace (so
that we know whether it's triggered by ResourceLoaderFileModule, WikiModule,
something else, etc. And ideally also an excerpt of $s (e.g. the first 20
characters) which will probably identify what the input script was.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 73556] PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571

2014-11-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=73556

Bartosz DziewoƄski matma@gmail.com changed:

   What|Removed |Added

 CC|matma@gmail.com |roan.katt...@gmail.com
  Component|JavaScript  |ResourceLoader

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l