[Bug 73672] Have vagrant provision run composer install

2014-11-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=73672

--- Comment #1 from Tisza Gergő gti...@wikimedia.org ---
Also, maybe vagrant provision should run composer self-update?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 73672] Have vagrant provision run composer install

2014-11-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=73672

Tisza Gergő gti...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Tisza Gergő gti...@wikimedia.org ---
 composer install does not touch already installed libraries, so no code gets 
 updated without the user's consent, it just the ones which have been added to 
 mediawiki/composer.json, and have not been installed at all yet

Actually that's not true (yeah, yeah, I should test before I file). Install
does not do anything at all if there is a lock file, and update has no option
to only touch completely missing packages, so there does not seem to be a way
to say add missing packages but don't touch existing ones. Probably not a
good idea anyway as it would result in inconsistent versions of the vendor
packages.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 73672] Have vagrant provision run composer install

2014-11-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=73672

Bryan Davis bda...@wikimedia.org changed:

   What|Removed |Added

 CC||bda...@wikimedia.org

--- Comment #3 from Bryan Davis bda...@wikimedia.org ---
(In reply to Tisza Gergő from comment #2)
  composer install does not touch already installed libraries, so no code 
  gets 
  updated without the user's consent, it just the ones which have been added 
  to 
  mediawiki/composer.json, and have not been installed at all yet
 
 Actually that's not true (yeah, yeah, I should test before I file). Install
 does not do anything at all if there is a lock file, and update has no
 option to only touch completely missing packages, so there does not seem to
 be a way to say add missing packages but don't touch existing ones.
 Probably not a good idea anyway as it would result in inconsistent versions
 of the vendor packages.

`vagrant git-update` takes care of this sort of thing by calling `composer
update --no-interaction --optimize-autoloader` after the gut pulls but before
running update.php.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l