[Maniphest] [Commented On] T170: Arc linting checks tailored to MediaWiki QA criteria
Mattflaschen added a comment. See https://secure.phabricator.com/book/phabricator/article/arcanist_lint_unit/ . Also, we can check that PHP docs generate without errors too. TASK DETAIL https://phabricator.wikimedia.org/T170 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: Mattflaschen Cc: Aklapper, Qgil, ori, bd808, scfc, faidon, RobLa-WMF, Mattflaschen, wikibugs-l ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Maniphest] [Commented On] T170: Arc linting checks tailored to MediaWiki QA criteria
Mattflaschen added a comment. It should basically be anything that currently runs on Jenkins for the project (on various projects, we have all of these running on Jenkins, though not every project has all), but can run locally. * Unit tests (PHPUnit and QUnit) - ArcanistUnitTestEngine * Browser tests (Cucumber) - ArcanistUnitTestEngine * JSLint, jscs (code style), `php -l` - ArcanistLintEngine * jsduck (checking that documentation can be generated without errors) - ArcanistLintEngine TASK DETAIL https://phabricator.wikimedia.org/T170 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: Mattflaschen Cc: Aklapper, Qgil, ori, bd808, scfc, faidon, RobLa-WMF, Mattflaschen, wikibugs-l ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Maniphest] [Commented On] T170: Arc linting checks tailored to MediaWiki QA criteria
Qgil added a comment. Ooops, I had forgotten about this one. TASK DETAIL https://phabricator.wikimedia.org/T170 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: Qgil Cc: Aklapper, Qgil, ori, bd808, scfc, faidon, RobLa-WMF, Mattflaschen, wikibugs-l ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l