[Maniphest] [Commented On] T607: Check easily who has signed Legalpad documents by their Wikimedia username
Jalexander added a comment.
>>! In T607#14817, @Qgil wrote:
> @Jalexander, @LuisV_WMF and I have agreed that {T783} goes first.
Aye, just to clarify for later though: The list is probably still a blocker for
us to roll out though (the 1000+ people coming in at the start are just too
much for us to search individually for their usernames, I need the list).
TASK DETAIL
https://phabricator.wikimedia.org/T607
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
.
To: Jalexander
Cc: wikibugs-l, Qgil, Jalexander, mmodell, chasemp, Revi, LuisV_WMF
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Maniphest] [Commented On] T607: Check easily who has signed Legalpad documents by their Wikimedia username
mmodell added a comment.
Here's what the mediawiki user field looks like in advanced search on my local
test phabricator:
{F219}
TASK DETAIL
https://phabricator.wikimedia.org/T607
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
.
To: mmodell
Cc: wikibugs-l, Qgil, Jalexander, mmodell, chasemp
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Maniphest] [Commented On] T607: Check easily who has signed Legalpad documents by their Wikimedia username
Qgil added a comment. Thank you all for your thoughts and the illustrative patch. I spoke with @Jalexander a few hours ago, and we exchanged impressions about our respective top priorities. The further comments here are very helpful. A summary that hopefully all we can agree on: * The Legalpad project is objectively urgent: there is an ongoing community process that needs it, and a board decision to fix this problem. However, due to several circumstances its push has been delayed, and now it is the Phabricator team who requests to wait a bit. We are in the middle of a Bugzilla and a RT migration that require all our focus and more, this is a declared WMF Engineering top priority, and the only sane approach is to put this task aside until we have completed Bugzilla-Migration. We are still hoping to finish by the end of this month, although we haven't committed to a specific date yet. * Today we can say that it is technically possible to provide the list with the details needed (say, for each entry Wikimedia username - Real name - Phabricator username - email). We just don't have the time right now to discuss and agree its details, but it looks like it shouldn't be rocket science. Patching upstream's Legalpad would be a short term solution creating a short term problem of maintenance. Since the use case is so unique for Wikimedia, it is unlikely that upstream will be interested in merging such patch, that we would need to maintain locally forever. Therefore, the best approach is an extension. * We can also talk about other features like inclusion in advanced search or triggering email notifications when a new users signs a legalpad (a feature that I could not find today via Herald or email preferences) but, again, not before the Bugzilla migration has been completed. Nobody wanted to arrive to this date without a Legalpad in full use, but this is where we got somehow. The Phabricator team requests the LCA team to wait just a few more weeks. TASK DETAIL https://phabricator.wikimedia.org/T607 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: Qgil Cc: wikibugs-l, Qgil, Jalexander, mmodell, chasemp ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Maniphest] [Commented On] T607: Check easily who has signed Legalpad documents by their Wikimedia username
Jalexander added a comment.
>>! In T607#10082, @chasemp wrote:
> @Jalexander, really I think you have explained yourself well, but their has
> been a meager amount of time on our side to address it and translate into the
> best possible technical terms. I'm genuinely sorry that has sucked. I think
> the last few comments here have been good. In my mind, saying the solution
> is a certain identifier in the list is a skip-to-the-end conclusion, but in
> restating the problem as "we need to know who signed a certain legalpad" I
> hope it can be handled in more flexible and still amendable ways. Really my
> fear is delivering something we aren't prepared to sustain.
>
I understand, to be honest my frustration is more from being under the
impression things were happening (after I felt like I had narrowed down to MVP
from the rest of the things I thought very important) and them not being. At
least some of that is, clearly, me not realizing when the conversation went in
another direction and, possibly, the tool itself not really being ready for
prime time at the scale we were hoping for (especially with the language issues
it and phabricator have) especially some frustration most of my other
preferences for the tool dying a death somewhere along the road here or
upstream (some understandably, some less so in my mind, but it doesn't really
matter why in the end). I clearly made too many assumptions about what was
being done. If I had understood the realities earlier on I likely would have
created a custom tool or just used email but that's water under the bridge for
now.
> @mmodell, Could we do something as simple as a url that is just a list of
> signee's by wiki name as an extension? Not even bothering with UI fanciness.
> I'm not trying to be ignorant but for me the need isn't wiki names in
> //the// list, it's a list of wiki names with signatures. Which we may better
> serve in another context.
>
On our side this would likely work for the initial use case ('discovery') but
while the real name/email are not generally required we do need to get to them
when necessary. For that we would need to have some way to at least cross
reference the two lists and get the other information. That could take multiple
forms of course (The search function you talked about earlier, having one of
the 'normal' fields in the list as well etc).
TASK DETAIL
https://phabricator.wikimedia.org/T607
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
.
To: Jalexander
Cc: wikibugs-l, Qgil, Jalexander, mmodell, chasemp
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Maniphest] [Commented On] T607: Check easily who has signed Legalpad documents by their Wikimedia username
chasemp added a comment. @Jalexander, really I think you have explained yourself well, but their has been a meager amount of time on our side to address it and translate into the best possible technical terms. I'm genuinely sorry that has sucked. I think the last few comments here have been good. In my mind, saying the solution is a certain identifier in the list is a skip-to-the-end conclusion, but in restating the problem as "we need to know who signed a certain legalpad" I hope it can be handled in more flexible and still amendable ways. Really my fear is delivering something we aren't prepared to sustain. @mmodell, Could we do something as simple as a url that is just a list of signee's by wiki name as an extension? Not even bothering with UI fanciness. I'm not trying to be ignorant but for me the need isn't wiki names in //the// list, it's a list of wiki names with signatures. Which we may better serve in another context. On the separate app, maybe take a look at how the burndown chat was built? https://phabricator.wikimedia.org/T153 https://github.com/bluehawk/phabricator-sprint That's some pretty advanced stuff all done in a way that is really thoughtful. I'm really not trying to be the grinch on this. TASK DETAIL https://phabricator.wikimedia.org/T607 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: chasemp Cc: wikibugs-l, Qgil, Jalexander, mmodell, chasemp ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Maniphest] [Commented On] T607: Check easily who has signed Legalpad documents by their Wikimedia username
mmodell added a comment. @chasemp @qgil When @jalexander says he's explained it a few times in previous tasks and meetings, he's referring to T258 and it's been pretty clear that they want specifically to have the wiki username in the list, just like this task is requesting. @chasemp: I'm willing to prototype implementing this as a separate phabricator application so that we don't have to merge upstream changes to patched code. Would that be an agreeable solution? It would still likely require a small amount of patching but hopefully no more than a single line of code somewhere. TASK DETAIL https://phabricator.wikimedia.org/T607 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: mmodell Cc: wikibugs-l, Qgil, Jalexander, mmodell, chasemp ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Maniphest] [Commented On] T607: Check easily who has signed Legalpad documents by their Wikimedia username
Jalexander added a comment. >>! In T607#10078, @mmodell wrote: > One thing I can do, at least it doesn't look very difficult at first glance, > is to enable 'advanced search' on the wiki username field. That would not > involve any hacks or long term maintenance issues, at least in the sense that > it would be isolated to an extension instead of patching the phabricator > core. It would also nicely solve the problem of finding a specific wiki user > and confirming that they signed document X. > > The 'discovery' use case that @chasemp mentioned would be better served by > the patch that I pasted above, but as @chasemp said, it would be better if we > can find a way to serve that use case without hacking the core. One solution > might be to just clone the user search code and make a separate > controller+view that does the same thing. Although this would be duplicating > the code it would avoid dealing with merge conflicts when upstream changes > touch the code we would be modifying.. Great, that gives me a bit of a better understanding of the question. While some of the on going (future) work would certainly be 'verify if he's signed' in the end what you are calling discovery is, indeed, the most important. At the start we have almost 900 users who will have to sign (because they already have advanced rights) in relatively short order. We need to see as they are coming in so that they can stop being bothered about it and so that we know when there may be issues. Searching for each individual user would become cumbersome and complicated. This is why my expectation has always been seeing it on the list of signatures itself (it is, indeed, the only thing we really 'need' to see on the list of signatures. We need to store their real name and email but I don't need access to it on a regular basis and I could care less about their Phabricator username. On the on going basis the discovery mode (or automated emails about new signatures... though we really don't want that for the first couple months) is also likely to be the most common method just because it makes it easiest to see when there has been a chance and allow us to do the required actions so that they can get the rights they were selected for by the community. TASK DETAIL https://phabricator.wikimedia.org/T607 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: Jalexander Cc: wikibugs-l, Qgil, Jalexander, mmodell, chasemp ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Maniphest] [Commented On] T607: Check easily who has signed Legalpad documents by their Wikimedia username
mmodell added a comment. One thing I can do, at least it doesn't look very difficult at first glance, is to enable 'advanced search' on the wiki username field. That would not involve any hacks or long term maintenance issues, at least in the sense that it would be isolated to an extension instead of patching the phabricator core. It would also nicely solve the problem of finding a specific wiki user and confirming that they signed document X. The 'discovery' use case that @chasemp mentioned would be better served by the patch that I pasted above, but as @chasemp said, it would be better if we can find a way to serve that use case without hacking the core. One solution might be to just clone the user search code and make a separate controller+view that does the same thing. Although this would be duplicating the code it would avoid dealing with merge conflicts when upstream changes touch the code we would be modifying.. TASK DETAIL https://phabricator.wikimedia.org/T607 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: mmodell Cc: wikibugs-l, Qgil, Jalexander, mmodell, chasemp ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Maniphest] [Commented On] T607: Check easily who has signed Legalpad documents by their Wikimedia username
Jalexander added a comment. Could you expand on what you don't understand about the use cases and what, in your opinion, the UI compromises could be? To be honest I feel like I've explained it a few times in both the previous task(s) and in past meetings and so I want to ensure that I don't just repeat something that you found confusing or difficult to quantify. TASK DETAIL https://phabricator.wikimedia.org/T607 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: Jalexander Cc: wikibugs-l, Qgil, Jalexander, mmodell, chasemp ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Maniphest] [Commented On] T607: Check easily who has signed Legalpad documents by their Wikimedia username
mmodell added a comment. I did this before. It's an ugly hack and I'd rather not maintain it but it isn't hard to do: https://gerrit.wikimedia.org/r/#/c/147723/ TASK DETAIL https://phabricator.wikimedia.org/T607 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: mmodell Cc: wikibugs-l, Qgil, Jalexander, mmodell ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
