[Wikidata-bugs] [Maniphest] T365506: diff-incompatible seems to always show in German on Wikidata
Reedy added a comment. I also have a strange feeling this may be a dupe, and I wouldn't be surprised if I filed the older task too... TASK DETAIL https://phabricator.wikimedia.org/T365506 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Umherirrender, Aklapper, Reedy, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, MaryMunyoki, Prufkick, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Dringsim, Nandana, lucamauri, Lahi, Gq86, Af420, GoranSMilovanovic, QZanden, srishakatux, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, KartikMistry, Mbch331, jhsoby, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T364681: Issues with translatable pages on Wikidata due to revision id overflow
Reedy added a comment. I'm not sure what help having numbers under the headings are, especially when two of them are the number 2... And all three only contain one line each TASK DETAIL https://phabricator.wikimedia.org/T364681 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: abi_, Reedy Cc: Lucas_Werkmeister_WMDE, Reedy, Zabe, Ameisenigel, Nikerabbit, Pppery, Aklapper, Tacsipacsi, GLima-WMF, Danny_Benjafield_WMDE, Dominika_Naumiuk, S8321414, Wangombe, Astuthiodit_1, Susie413113, karapayneWMDE, Invadibot, H0bby, PallaviPatke, maantietaja, Tiputini, Rileych, ItamarWMDE, Akuckartz, Dringsim, 50019062, darthmon_wmde, Rosalie_WMDE, abi_, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Soum213, Taiwania_Justo, shinjiman, Scott_WUaS, Wong128hk, Luke081515, Verdy_p, Wikidata-bugs, Base, aude, Arrbee, santhosh, KartikMistry, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T365506: diff-incompatible seems to always show in German on Wikidata
Reedy updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T365506 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Reedy, MaryMunyoki, Prufkick, ItamarWMDE, Akuckartz, lucamauri, Gq86, Af420, srishakatux, KimKelting, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, Gryllida, Shizhao, Arrbee, KartikMistry, jhsoby, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T365506: diff-incompatible seems to always show in German on Wikidata
Reedy added a project: MediaWiki-Page-diffs. TASK DETAIL https://phabricator.wikimedia.org/T365506 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Reedy, MaryMunyoki, Prufkick, ItamarWMDE, Akuckartz, lucamauri, Gq86, Af420, srishakatux, KimKelting, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, Gryllida, Shizhao, Arrbee, KartikMistry, jhsoby, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T365506: diff-incompatible seems to always show in German on Wikidata
Reedy created this task. Reedy added projects: MediaWiki-extensions-WikibaseRepository, MediaWiki-Internationalization, I18n. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Noticed when https://www.wikidata.org/w/index.php?title=Help:QuickStatements=2147483647=2154896250 > Die Inhaltsmodelle „Wikibase-Datenobjekt“ und „Wikitext“ können nicht verglichen werden. https://www.wikidata.org/w/index.php?title=Help:QuickStatements=2147483647=2154896250=qqx still shows it verbatim... https://www.wikidata.org/wiki/MediaWiki:Diff-incompatible https://www.wikidata.org/wiki/MediaWiki:Diff-incompatible/en https://www.wikidata.org/wiki/MediaWiki:Diff-incompatible/en-gb ^ All show in English... TASK DETAIL https://phabricator.wikimedia.org/T365506 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Reedy, MaryMunyoki, Prufkick, ItamarWMDE, Akuckartz, lucamauri, Gq86, Af420, srishakatux, KimKelting, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, Gryllida, Shizhao, Arrbee, KartikMistry, jhsoby, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T365445: Investigate potential signed int references to rev_id
Reedy added a project: Schema-change. TASK DETAIL https://phabricator.wikimedia.org/T365445 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: abi_, Tacsipacsi, Aklapper, Pppery, Nikerabbit, Ameisenigel, Zabe, Reedy, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, H0bby, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Dringsim, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Taiwania_Justo, Neuronton, shinjiman, Scott_WUaS, Luke081515, Wikidata-bugs, Base, aude, KartikMistry, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T364681: Issues with translatable pages on Wikidata due to revision id overflow
Reedy updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T364681 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: abi_, Reedy Cc: Reedy, Zabe, Ameisenigel, Nikerabbit, Pppery, Aklapper, Tacsipacsi, GLima-WMF, Danny_Benjafield_WMDE, Dominika_Naumiuk, S8321414, Wangombe, Astuthiodit_1, Susie413113, karapayneWMDE, Invadibot, H0bby, PallaviPatke, maantietaja, Tiputini, Rileych, ItamarWMDE, Akuckartz, Dringsim, 50019062, darthmon_wmde, Rosalie_WMDE, abi_, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Soum213, Taiwania_Justo, shinjiman, Scott_WUaS, Wong128hk, Luke081515, Verdy_p, Wikidata-bugs, Base, aude, Arrbee, santhosh, KartikMistry, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T364681: Issues with translatable pages on Wikidata due to revision id overflow
Reedy added a comment. MariaDB [wikidatawiki]> select distinct rt_type from revtag where rt_revision = 2147483647; +-+ | rt_type | +-+ | fuzzy | | tp:mark | | tp:tag | | tp:transver | +-+ 4 rows in set (0.002 sec) MariaDB [wikidatawiki]> select rt_type, count(rt_type) from revtag where rt_revision = 2147483647 group by rt_type; +-++ | rt_type | count(rt_type) | +-++ | fuzzy | 15 | | tp:mark | 1 | | tp:tag | 2 | | tp:transver | 1042 | +-++ 4 rows in set (0.002 sec) TASK DETAIL https://phabricator.wikimedia.org/T364681 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: abi_, Reedy Cc: Reedy, Zabe, Ameisenigel, Nikerabbit, Pppery, Aklapper, Tacsipacsi, GLima-WMF, Danny_Benjafield_WMDE, Dominika_Naumiuk, S8321414, Wangombe, Astuthiodit_1, Susie413113, karapayneWMDE, Invadibot, H0bby, PallaviPatke, maantietaja, Tiputini, Rileych, ItamarWMDE, Akuckartz, Dringsim, 50019062, darthmon_wmde, Rosalie_WMDE, abi_, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Soum213, Taiwania_Justo, shinjiman, Scott_WUaS, Wong128hk, Luke081515, Verdy_p, Wikidata-bugs, Base, aude, Arrbee, santhosh, KartikMistry, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T364681: Issues with translatable pages on Wikidata due to revision id overflow
Reedy added a comment. MariaDB [wikidatawiki]> select page_namespace, count(page_id) from page INNER JOIN revtag ON (page_id = rt_page) where rt_revision = 2147483647 group by page_namespace; +++ | page_namespace | count(page_id) | +++ | 4 | 2 | | 12 | 1 | | 1198 | 1010 | +++ 3 rows in set (0.029 sec) TASK DETAIL https://phabricator.wikimedia.org/T364681 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: abi_, Reedy Cc: Reedy, Zabe, Ameisenigel, Nikerabbit, Pppery, Aklapper, Tacsipacsi, GLima-WMF, Danny_Benjafield_WMDE, Dominika_Naumiuk, S8321414, Wangombe, Astuthiodit_1, Susie413113, karapayneWMDE, Invadibot, H0bby, PallaviPatke, maantietaja, Tiputini, Rileych, ItamarWMDE, Akuckartz, Dringsim, 50019062, darthmon_wmde, Rosalie_WMDE, abi_, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Soum213, Taiwania_Justo, shinjiman, Scott_WUaS, Wong128hk, Luke081515, Verdy_p, Wikidata-bugs, Base, aude, Arrbee, santhosh, KartikMistry, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T364681: Issues with translatable pages on Wikidata due to revision id overflow
Reedy added a comment. In T364681#9812609 <https://phabricator.wikimedia.org/T364681#9812609>, @Ameisenigel wrote: > Is this weird diff related to this issue: https://www.wikidata.org/wiki/Special:Diff/2147483647/2154896250?title=Q82991796 ? > It is a mixture of https://www.wikidata.org/wiki/Q82991796 and https://www.wikidata.org/wiki/Help:QuickStatements Yeah, with one of the revisions being 2147483647, and one of the pages being translateable... Seems almost certainly! TASK DETAIL https://phabricator.wikimedia.org/T364681 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: abi_, Reedy Cc: Reedy, Zabe, Ameisenigel, Nikerabbit, Pppery, Aklapper, Tacsipacsi, GLima-WMF, Danny_Benjafield_WMDE, Dominika_Naumiuk, S8321414, Wangombe, Astuthiodit_1, Susie413113, karapayneWMDE, Invadibot, H0bby, PallaviPatke, maantietaja, Tiputini, Rileych, ItamarWMDE, Akuckartz, Dringsim, 50019062, darthmon_wmde, Rosalie_WMDE, abi_, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Soum213, Taiwania_Justo, shinjiman, Scott_WUaS, Wong128hk, Luke081515, Verdy_p, Wikidata-bugs, Base, aude, Arrbee, santhosh, KartikMistry, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T364681: Issues with translatable pages on Wikidata due to revision id overflow
Reedy added a parent task: T63111: Convert primary key integers and references thereto from int to bigint (unsigned). TASK DETAIL https://phabricator.wikimedia.org/T364681 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, Zabe, Ameisenigel, Nikerabbit, Pppery, Aklapper, Tacsipacsi, GLima-WMF, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Dominika_Naumiuk, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, Wangombe, Astuthiodit_1, Susie413113, 786, Biggs657, karapayneWMDE, Invadibot, H0bby, PallaviPatke, maantietaja, Juan90264, Tiputini, Alter-paule, Beast1978, Rileych, ItamarWMDE, Un1tY, Akuckartz, Dringsim, 50019062, Hook696, darthmon_wmde, Rosalie_WMDE, abi_, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Soum213, Taiwania_Justo, Neuronton, shinjiman, Scott_WUaS, Wong128hk, Luke081515, Verdy_p, Wikidata-bugs, Base, aude, Arrbee, santhosh, KartikMistry, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T364681: Issues with translatable pages on Wikidata due to revision id overflow
Reedy added a comment. Needs a task creating for WMF prod for the schema change to be applied as per https://wikitech.wikimedia.org/wiki/Schema_changes TASK DETAIL https://phabricator.wikimedia.org/T364681 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, Zabe, Ameisenigel, Nikerabbit, Pppery, Aklapper, Tacsipacsi, GLima-WMF, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Dominika_Naumiuk, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, Wangombe, Astuthiodit_1, Susie413113, 786, Biggs657, karapayneWMDE, Invadibot, H0bby, PallaviPatke, maantietaja, Juan90264, Tiputini, Alter-paule, Beast1978, Rileych, ItamarWMDE, Un1tY, Akuckartz, Dringsim, 50019062, Hook696, darthmon_wmde, Rosalie_WMDE, abi_, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Soum213, Taiwania_Justo, Neuronton, shinjiman, Scott_WUaS, Wong128hk, Luke081515, Verdy_p, Wikidata-bugs, Base, aude, Arrbee, santhosh, KartikMistry, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T364681: Issues with translatable pages on Wikidata due to revision id overflow
Reedy added a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T364681 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Ameisenigel, Nikerabbit, Pppery, Aklapper, Tacsipacsi, GLima-WMF, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Dominika_Naumiuk, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, Wangombe, Astuthiodit_1, Susie413113, 786, Biggs657, karapayneWMDE, Invadibot, H0bby, PallaviPatke, maantietaja, Juan90264, Tiputini, Alter-paule, Beast1978, Rileych, ItamarWMDE, Un1tY, Akuckartz, Dringsim, 50019062, Hook696, darthmon_wmde, Rosalie_WMDE, abi_, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Soum213, Taiwania_Justo, Neuronton, shinjiman, Scott_WUaS, Wong128hk, Luke081515, Verdy_p, Wikidata-bugs, Base, aude, Arrbee, santhosh, KartikMistry, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T365277: Copy and paste qualifier
Reedy created this task. Reedy added a project: Wikidata-Gadgets. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Similar to `DuplicateReferences`, being able to copy (one or more) qualifiers from a value onto values on the same/other items. Useful for propagating specific key values. TASK DETAIL https://phabricator.wikimedia.org/T365277 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Reedy, hubaishan, Lectrician1, dachary, Wikidata-bugs, Ricordisamoa, Tacsipacsi, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T362084: shellbox-constraints returning 500 on preg_match error
Reedy added a comment. In T362084#9700057 <https://phabricator.wikimedia.org/T362084#9700057>, @Lucas_Werkmeister_WMDE wrote: >> Seemingly you can do "regex validation" in PHP by testing against `null`/`''`, and see if `preg_match` returns `false`. > > That’s an interesting idea… do you know if that’s safe to do even with possibly malicious patterns? (Which are the reason that we check constraints in shellbox in the first place.) Without digging into it... I'm not sure. In theory, it should be "just" compiling/validating the regex, and then it woudn't surprise me if for say null, it then short circuits and doesn't actually execute said regex if it is valid (presumably it fails before running it, if the regex is invalid). An empty string feels different, as you could be using a regex to check for some string length (sure, there's better ways...). If that works, that'd be pretty useful. I obviously don't think we should be trying to invent our own regex validator/checker (which could be an alternative solution)! Are these "invalid regexes"/`preg_match` errors surfaced to users/editors at all? Or do they end up being silent failures behind the scenes? TASK DETAIL https://phabricator.wikimedia.org/T362084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Lucas_Werkmeister_WMDE, Reedy, akosiaris, Clement_Goubert, JMeybohm, Aklapper, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Kappakayala, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Arnoldokoth, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, wkandek, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, darthmon_wmde, Eihel, Rosalie_WMDE, Kent7301, joker88john, CucyNoiD, Nandana, jijiki, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, Esc3300, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Verdy_p, abian, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Legoktm ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T362084: shellbox-constraints returning 500 on preg_match error
Reedy added a comment.
The tests fail as we'd expect/hope:
20:14:29 There were 2 errors:
20:14:29
20:14:29 1)
WikibaseQuality\ConstraintReport\Tests\Checker\FormatChecker\FormatCheckerTest::testT362084
with data set #0 ('(people|institutions|sources)...-9]\d*', 'people/509522')
20:14:29 preg_match(): Unknown modifier '['
20:14:29
20:14:29
/workspace/src/extensions/WikibaseQualityConstraints/tests/phpunit/Checker/FormatChecker/FormatCheckerTest.php:396
20:14:29
/workspace/src/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Checker/FormatChecker.php:199
20:14:29
/workspace/src/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Checker/FormatChecker.php:181
20:14:29
/workspace/src/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Checker/FormatChecker.php:139
20:14:29
/workspace/src/extensions/WikibaseQualityConstraints/tests/phpunit/Checker/FormatChecker/FormatCheckerTest.php:117
20:14:29 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
Logs generated by test
Show Details
20:14:29
20:14:29 2)
WikibaseQuality\ConstraintReport\Tests\Checker\FormatChecker\FormatCheckerTest::testT362084
with data set #1 ('[0-9A-Za-z\-\/\(\) ]*', '1990 SH2')
20:14:29 preg_match(): Unknown modifier '\'
20:14:29
20:14:29
/workspace/src/extensions/WikibaseQualityConstraints/tests/phpunit/Checker/FormatChecker/FormatCheckerTest.php:396
20:14:29
/workspace/src/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Checker/FormatChecker.php:199
20:14:29
/workspace/src/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Checker/FormatChecker.php:181
20:14:29
/workspace/src/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Checker/FormatChecker.php:139
20:14:29
/workspace/src/extensions/WikibaseQualityConstraints/tests/phpunit/Checker/FormatChecker/FormatCheckerTest.php:117
20:14:29 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
Logs generated by test
Show Details
20:14:29
20:14:29 ERRORS!
20:14:29 Tests: 24625, Assertions: 73774, Errors: 2, Skipped: 133.
The regex escaping is done in:
$pattern = '/^(?:' . str_replace( '/', '\/', $format ) . ')$/u';
Input: `(people|institutions|sources)\/[1-9]\d*`
Output: `/^(?:(people|institutions|sources)\\/[1-9]\d*)$/u`
Expected Output: `/^(?:(people|institutions|sources)\/[1-9]\d*)$/`
Input: `[0-9A-Za-z\-\/\(\) ]*`
Output: `/^(?:[0-9A-Za-z\-\\/\(\) ]*)$/u`
Expected Output: `/^(?:[0-9A-Za-z\-\/\(\) ]*)$/u`
The string replace is replacing (escaping) whether the `/` is already escaped
or not...
I don't know whether the values from Wikidata should be escaped or not...
https://www.wikidata.org/wiki/Q21502404 and
https://www.wikidata.org/wiki/Property:P1793 helpfully don't mention, beyond:
> When using on property constraints, ensure syntax is a PCRE
Either that should be enforced in software, or when we do the
`str_replace()`, only do it if we need to... Or remove any escaping that is
there to begin with, and then undo... But this feels similarly error prone.
Still. Better error handling is really needed anyway..
TASK DETAIL
https://phabricator.wikimedia.org/T362084
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Reedy
Cc: Reedy, akosiaris, Clement_Goubert, JMeybohm, Aklapper,
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Kappakayala, Adamm71,
S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Arnoldokoth,
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, wkandek,
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, darthmon_wmde,
Eihel, Rosalie_WMDE, Kent7301, joker88john, CucyNoiD, Nandana, jijiki,
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan,
Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, KimKelting, Esc3300,
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton,
Scott_WUaS, Verdy_p, abian, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331,
Jay8g, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T362084: shellbox-constraints returning 500 on preg_match error
Reedy added a comment. ^ Sticking those two into a test... Lets see what happens TASK DETAIL https://phabricator.wikimedia.org/T362084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, akosiaris, Clement_Goubert, JMeybohm, Aklapper, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Kappakayala, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Arnoldokoth, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, wkandek, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, darthmon_wmde, Eihel, Rosalie_WMDE, Kent7301, joker88john, CucyNoiD, Nandana, jijiki, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, KimKelting, Esc3300, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Verdy_p, abian, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Legoktm ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T362084: shellbox-constraints returning 500 on preg_match error
Reedy added a comment. The other is the text on https://www.wikidata.org/wiki/Q6739335, leading to https://www.wikidata.org/wiki/Property:P490, which has a regex on the wikipage as `[0-9A-Za-z\-\/\(\) ]*` which becomes `"/^(?:[0-9A-Za-z\\-/\\(\\) ]*)$/u"` https://www.wikidata.org/w/index.php?title=Property:P490=history Similarly not recently changed... TASK DETAIL https://phabricator.wikimedia.org/T362084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, akosiaris, Clement_Goubert, JMeybohm, Aklapper, Danny_Benjafield_WMDE, Kappakayala, S8321414, Astuthiodit_1, Arnoldokoth, karapayneWMDE, Invadibot, maantietaja, wkandek, ItamarWMDE, Akuckartz, darthmon_wmde, Eihel, Rosalie_WMDE, Nandana, jijiki, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, KimKelting, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Verdy_p, abian, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Legoktm ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T362084: shellbox-constraints returning 500 on preg_match error
Reedy added a comment. https://www.wikidata.org/wiki/Property:P5504 is `"/^(?:(people|institutions|sources)/[1-9]\\d*)$/u"` but it hasn't been changed recently - https://www.wikidata.org/w/index.php?title=Property:P5504=history TASK DETAIL https://phabricator.wikimedia.org/T362084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, akosiaris, Clement_Goubert, JMeybohm, Aklapper, Danny_Benjafield_WMDE, Kappakayala, S8321414, Astuthiodit_1, Arnoldokoth, karapayneWMDE, Invadibot, maantietaja, wkandek, ItamarWMDE, Akuckartz, darthmon_wmde, Eihel, Rosalie_WMDE, Nandana, jijiki, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, KimKelting, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Verdy_p, abian, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Legoktm ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T362084: shellbox-constraints returning 500 on preg_match error
Reedy added a comment. As there's many parts to this... Seemingly you can do "regex validation" in PHP by testing against `null`/`''`, and see if `preg_match` returns `false`. I wonder if WDQC should be doing that before shelling out to shellbox, and display a nice user error somewhere along the line. Rather than using shellbox (or sparql?) to do regex validation... `CheckResult::STATUS_BAD_PARAMETERS` looks like it may work `"The constraint parameters are broken."`; as could a more specific error. Ref: https://stackoverflow.com/questions/4440626/how-can-i-validate-regex TASK DETAIL https://phabricator.wikimedia.org/T362084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, akosiaris, Clement_Goubert, JMeybohm, Aklapper, Danny_Benjafield_WMDE, Kappakayala, S8321414, Astuthiodit_1, Arnoldokoth, karapayneWMDE, Invadibot, maantietaja, wkandek, ItamarWMDE, Akuckartz, darthmon_wmde, Eihel, Rosalie_WMDE, Nandana, jijiki, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, KimKelting, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Verdy_p, abian, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Legoktm ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T362084: shellbox-constraints returning 500 on preg_match error
Reedy added a comment. Last edit to any of this code was rEBQCd7564ee12be3: Fix regex checking using preg_match() <https://phabricator.wikimedia.org/rEBQCd7564ee12be34c37a46eda47692077028a42e506> in August 2021... So depending on how long this has been going on, especially if it's recent, is probably due to wikidata edit(s) TASK DETAIL https://phabricator.wikimedia.org/T362084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, akosiaris, Clement_Goubert, JMeybohm, Aklapper, Danny_Benjafield_WMDE, Kappakayala, S8321414, Astuthiodit_1, Arnoldokoth, karapayneWMDE, Invadibot, maantietaja, wkandek, ItamarWMDE, Akuckartz, darthmon_wmde, Eihel, Rosalie_WMDE, Nandana, jijiki, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, KimKelting, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Verdy_p, abian, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Legoktm ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T362084: shellbox-constraints returning 500 on preg_match error
Reedy added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T362084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, akosiaris, Clement_Goubert, JMeybohm, Aklapper, Danny_Benjafield_WMDE, Kappakayala, S8321414, Astuthiodit_1, Arnoldokoth, karapayneWMDE, Invadibot, maantietaja, wkandek, ItamarWMDE, Akuckartz, darthmon_wmde, Eihel, Rosalie_WMDE, Nandana, jijiki, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, KimKelting, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Verdy_p, abian, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Legoktm ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T362084: shellbox-constraints returning 500 on preg_match error
Reedy added a project: wmde-wikidata-tech. TASK DETAIL https://phabricator.wikimedia.org/T362084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, akosiaris, Clement_Goubert, JMeybohm, Aklapper, Kappakayala, Arnoldokoth, wkandek, ItamarWMDE, darthmon_wmde, Eihel, Rosalie_WMDE, jijiki, Lucas_Werkmeister_WMDE, KimKelting, Esc3300, Agabi10, Verdy_p, abian, Wikidata-bugs, Jdforrester-WMF, Jay8g, Legoktm ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T362084: shellbox-constraints returning 500 on preg_match error
Reedy added projects: Wikibase-Quality-Constraints, Wikimedia-production-error.
Reedy added a comment.
Pretty sure these examples are from #wikibase-quality-constraints
<https://phabricator.wikimedia.org/tag/wikibase-quality-constraints/>:
private function runRegexCheckUsingShellbox( string $text, string
$format ): string {
if ( !$this->shellboxClientFactory->isEnabled(
'constraint-regex-checker' ) ) {
return CheckResult::STATUS_TODO;
}
try {
$pattern = '/^(?:' . str_replace( '/', '\/', $format )
. ')$/u';
$shellboxResponse =
$this->shellboxClientFactory->getClient( [
'timeout' => $this->config->get(
'WBQualityConstraintsSparqlMaxMillis' ) / 1000,
'service' => 'constraint-regex-checker',
] )->call(
'constraint-regex-checker',
'preg_match',
[ $pattern, $text ]
);
} catch ( ShellboxError $exception ) {
throw new ConstraintParameterException(
( new ViolationMessage(
'wbqc-violation-message-parameter-regex' ) )
->withInlineCode( $pattern,
Role::CONSTRAINT_PARAMETER_VALUE )
);
}
if ( $shellboxResponse ) {
return CheckResult::STATUS_COMPLIANCE;
} else {
return CheckResult::STATUS_VIOLATION;
}
}
Which probably suggests it's regexes on wikidata items editable on the wiki
TASK DETAIL
https://phabricator.wikimedia.org/T362084
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Reedy
Cc: Reedy, akosiaris, Clement_Goubert, JMeybohm, Aklapper, Kappakayala,
Arnoldokoth, wkandek, ItamarWMDE, darthmon_wmde, Eihel, Rosalie_WMDE, jijiki,
Lucas_Werkmeister_WMDE, KimKelting, Esc3300, Agabi10, Verdy_p, abian,
Wikidata-bugs, Jdforrester-WMF, Jay8g, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T360435: [LEX] Investigate Wikibase CI failures on REL1_39 branch
Reedy added a comment. This is blocking merges to Math... I see Arthur claimed this today, so should we expect a patch (whether fixing, or just skipping the tests) soon? :) TASK DETAIL https://phabricator.wikimedia.org/T360435 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Reedy Cc: Reedy, Lucas_Werkmeister_WMDE, Aklapper, ArthurTaylor, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T360435: [LEX] Investigate Wikibase CI failures on REL1_39 branch
Reedy added a project: ci-test-error. TASK DETAIL https://phabricator.wikimedia.org/T360435 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Reedy Cc: Reedy, Lucas_Werkmeister_WMDE, Aklapper, ArthurTaylor, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T360435: [LEX] Investigate Wikibase CI failures on REL1_39 branch
Reedy merged a task: T362088: Wikibase Lexeme test failures in 1.39. TASK DETAIL https://phabricator.wikimedia.org/T360435 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Reedy Cc: Reedy, Lucas_Werkmeister_WMDE, Aklapper, ArthurTaylor, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T360826: Wikibase blocks merges to GrowthExperiments
Reedy edited projects, added ci-test-error (WMF-deployed Build Failure); removed ci-test-error. TASK DETAIL https://phabricator.wikimedia.org/T360826 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Umherirrender, Jdforrester-WMF, Urbanecm_WMF, Aklapper, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, caldera, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, KimKelting, LawExplorer, Iniquity, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, geraki, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T360435: Investigate Wikibase CI failures on REL1_39 branch
Reedy added a project: MW-1.39-release. TASK DETAIL https://phabricator.wikimedia.org/T360435 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, ArthurTaylor, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T360194: Show ckbwiktionary link (in main namespace) while we are on other languages
Reedy added a project: MediaWiki-extensions-WikibaseClient. TASK DETAIL https://phabricator.wikimedia.org/T360194 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Aram, ItamarWMDE, Akuckartz, lucamauri, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T210304: Add Wikidata as a supported project
Reedy removed a project: OKR-Work. TASK DETAIL https://phabricator.wikimedia.org/T210304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Liuxinyu970226, Jarekt, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, Florian_COLLIN, maantietaja, Ganeshk, ItamarWMDE, Akuckartz, Aram, Nandana, Lahi, Gq86, Shaded0, GoranSMilovanovic, SwiftyPeep, QZanden, KimKelting, Brightgalrs, LawExplorer, JJMC89, Grind24, _jensen, rosalieper, Scott_WUaS, Magioladitis, Wikidata-bugs, aude, Dinoguy1000, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T125971: Make list based on Wikidata statement
Reedy removed a project: OKR-Work. TASK DETAIL https://phabricator.wikimedia.org/T125971 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Izno, StudiesWorld, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, Florian_COLLIN, maantietaja, Ganeshk, ItamarWMDE, Akuckartz, Aram, Nandana, Lahi, Gq86, Shaded0, GoranSMilovanovic, SwiftyPeep, QZanden, KimKelting, Brightgalrs, LawExplorer, JJMC89, Grind24, _jensen, rosalieper, Scott_WUaS, Magioladitis, Wikidata-bugs, aude, Dinoguy1000, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T360049: Consider integrating interlanguage links in Wikibase extension with language converter variants
Reedy renamed this task from "Consider integrate interlanguage links in Wikibase extension with language converter variants" to "Consider integrating interlanguage links in Wikibase extension with language converter variants". TASK DETAIL https://phabricator.wikimedia.org/T360049 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Winston_Sung, Danny_Benjafield_WMDE, Astuthiodit_1, MaryMunyoki, Prufkick, karapayneWMDE, Invadibot, Func, maantietaja, ItamarWMDE, Akuckartz, Hakimi97, VulpesVulpes825, Nandana, lucamauri, AbdellahSADIQUI, Lahi, Willy1018, Gq86, Af420, Biblbroks, GoranSMilovanovic, QZanden, srishakatux, KimKelting, LawExplorer, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, ssastry, Arrbee, KartikMistry, Mbch331, jhsoby, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase
Reedy added a comment. I think as long as the first party ones are fixed, that's the main thing. Tasks like T254650: Rename TitleBlacklist <https://phabricator.wikimedia.org/T254650> and T254649: Rename SpamBlacklist <https://phabricator.wikimedia.org/T254649> exist to fix those underlying issues, and as we normally would expect in our day to day development, when those tasks themselves are addressed, eventually there will be followup here, and in any other usages. Similar for documentation referring to how things are named in PHPUnit. It was more of a case for ease that all matches were just dumped to the bugs. If someone has double checked that no new instances (that again are first party, and can be fixed) have come in since this was filed, I think it's fine to close the task. TASK DETAIL https://phabricator.wikimedia.org/T277971 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Michael, JArguello-WMF, toan, Aklapper, Reedy, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Amire80, Lydia_Pintscher, siebrand, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353184: Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated
Reedy added a parent task: T314099: PHP 8.2: Dynamic property creation is deprecated. TASK DETAIL https://phabricator.wikimedia.org/T353184 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353161: Creation of dynamic property MediaWiki\Title\Title::$wikibasePushedDeleteToRepo is deprecated
Reedy added a parent task: T314099: PHP 8.2: Dynamic property creation is deprecated. TASK DETAIL https://phabricator.wikimedia.org/T353161 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Lucas_Werkmeister_WMDE, Umherirrender, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T296710: Investigate occasionally failing before each hooks for termbox
Reedy added a comment. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/976297/ https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php74-docker/69597/console 19:25:47 -- 19:25:47 [Chrome 90.0.4430.212 linux #0-7] Running: Chrome (v90.0.4430.212) on linux 19:25:47 [Chrome 90.0.4430.212 linux #0-7] Session ID: 094e389d-5e38-4aec-a073-5ba94e217b49 19:25:47 [Chrome 90.0.4430.212 linux #0-7] 19:25:47 [Chrome 90.0.4430.212 linux #0-7] » /view/lib/wikibase-termbox/tests/selenium/specs/LicenseOverlay.spec.js 19:25:47 [Chrome 90.0.4430.212 linux #0-7] Termbox: LicenseOverlay 19:25:47 [Chrome 90.0.4430.212 linux #0-7]? is shown when clicking publish 19:25:47 [Chrome 90.0.4430.212 linux #0-7]✖ "before each" hook for Termbox: LicenseOverlay 19:25:47 [Chrome 90.0.4430.212 linux #0-7]✖ "after each" hook for Termbox: LicenseOverlay 19:25:47 [Chrome 90.0.4430.212 linux #0-7] 19:25:47 [Chrome 90.0.4430.212 linux #0-7] 2 failing (3m 41.8s) 19:25:47 [Chrome 90.0.4430.212 linux #0-7] 19:25:47 [Chrome 90.0.4430.212 linux #0-7] 1) Termbox: LicenseOverlay "before each" hook for Termbox: LicenseOverlay 19:25:47 [Chrome 90.0.4430.212 linux #0-7] Timeout of 6ms exceeded. The execution in the test "Termbox: LicenseOverlay "before each" hook for "is shown when clicking publish"" took too long. Try to reduce the run time or increase your timeout for test specs (https://webdriver.io/docs/timeouts). (/workspace/src/extensions/Wikibase/view/lib/wikibase-termbox/tests/selenium/specs/LicenseOverlay.spec.js) 19:25:47 [Chrome 90.0.4430.212 linux #0-7] Error: Timeout of 6ms exceeded. The execution in the test "Termbox: LicenseOverlay "before each" hook for "is shown when clicking publish"" took too long. Try to reduce the run time or increase your timeout for test specs (https://webdriver.io/docs/timeouts). (/workspace/src/extensions/Wikibase/view/lib/wikibase-termbox/tests/selenium/specs/LicenseOverlay.spec.js) 19:25:47 [Chrome 90.0.4430.212 linux #0-7] at createTimeoutError (/workspace/src/extensions/Wikibase/node_modules/mocha/lib/errors.js:498:15) 19:25:47 [Chrome 90.0.4430.212 linux #0-7] at Hook.Runnable._timeoutError (/workspace/src/extensions/Wikibase/node_modules/mocha/lib/runnable.js:431:10) 19:25:47 [Chrome 90.0.4430.212 linux #0-7] at Timeout. (/workspace/src/extensions/Wikibase/node_modules/mocha/lib/runnable.js:246:24) 19:25:47 [Chrome 90.0.4430.212 linux #0-7] at listOnTimeout (node:internal/timers:559:17) 19:25:47 [Chrome 90.0.4430.212 linux #0-7] at processTimers (node:internal/timers:502:7) 19:25:47 [Chrome 90.0.4430.212 linux #0-7] 19:25:47 [Chrome 90.0.4430.212 linux #0-7] 2) Termbox: LicenseOverlay "after each" hook for Termbox: LicenseOverlay 19:25:47 [Chrome 90.0.4430.212 linux #0-7] Timeout of 6ms exceeded. The execution in the test "Termbox: LicenseOverlay "after each" hook for "is shown when clicking publish"" took too long. Try to reduce the run time or increase your timeout for test specs (https://webdriver.io/docs/timeouts). (/workspace/src/extensions/Wikibase/view/lib/wikibase-termbox/tests/selenium/specs/LicenseOverlay.spec.js) 19:25:47 [Chrome 90.0.4430.212 linux #0-7] Error: Timeout of 6ms exceeded. The execution in the test "Termbox: LicenseOverlay "after each" hook for "is shown when clicking publish"" took too long. Try to reduce the run time or increase your timeout for test specs (https://webdriver.io/docs/timeouts). (/workspace/src/extensions/Wikibase/view/lib/wikibase-termbox/tests/selenium/specs/LicenseOverlay.spec.js) 19:25:47 [Chrome 90.0.4430.212 linux #0-7] at createTimeoutError (/workspace/src/extensions/Wikibase/node_modules/mocha/lib/errors.js:498:15) 19:25:47 [Chrome 90.0.4430.212 linux #0-7] at Hook.Runnable._timeoutError (/workspace/src/extensions/Wikibase/node_modules/mocha/lib/runnable.js:431:10) 19:25:47 [Chrome 90.0.4430.212 linux #0-7] at Timeout. (/workspace/src/extensions/Wikibase/node_modules/mocha/lib/runnable.js:246:24) 19:25:47 [Chrome 90.0.4430.212 linux #0-7] at listOnTimeout (node:internal/timers:559:17) 19:25:47 [Chrome 90.0.4430.212 linux #0-7] at processTimers (node:internal/timers:502:7) 19:25:47 -- 19:25:47 [Chrome 90.0.4430.212 linux #0-7] Running: Chrome (v90.0.4430.212) on linux 19:25:47 [Chrome 90.0.4430.212 linux #0-7] Session ID: 4d2e7028-e32e-4501-9288-178a5117856c 19:25:47 [Chrome 90.0.4430.212 linux #0-7] 19:25:47 [Chrome 90.0.4430.212 linux #0-7] » /view/lib/wikibase-termbox/tests/selenium/specs/LicenseOverlay.spec.js
[Wikidata-bugs] [Maniphest] T340201: Use custom language code to find i18n XSS issues
Reedy added a comment. I'm curious how we can track issues found by this... Just xref this task in the description? TASK DETAIL https://phabricator.wikimedia.org/T340201 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Reedy Cc: Reedy, Bawolff, Daimona, Nikerabbit, Jdforrester-WMF, Fomafix, Lydia_Pintscher, sbassett, jhsoby, kostajh, matmarex, bd808, Michael, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Cleo_Lemoisson, Astuthiodit_1, karapayneWMDE, Invadibot, Dylsss, Devnull, maantietaja, ItamarWMDE, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wong128hk, Luke081515, Wikidata-bugs, aude, Grunny, csteipp, Mbch331, Jay8g, Krenair, Legoktm ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T344554: Get root wikibase_item for alias elements
Reedy added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T344554 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Pruna.ar, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T344270: Vector 2010 users cannot edit lexemes
Reedy renamed this task from "Vector 2010 users cannot edit lexems" to "Vector 2010 users cannot edit lexemes". Reedy added projects: MediaWiki-extensions-WikibaseRepository, Wikidata. Reedy updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T344270 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Ankry, Danny_Benjafield_WMDE, Astuthiodit_1, Susie413113, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T595: Set up a structured data vagrant role
Reedy closed subtask T596: Include templates into the multimedia vagrant role as Declined. TASK DETAIL https://phabricator.wikimedia.org/T595 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Gilles, Reedy Cc: Gilles, JanZerebecki, wikibugs-l-list, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, GFontenelle_WMF, FRomeo_WMF, Juan90264, Alter-paule, Beast1978, CBogen, Un1tY, Nintendofan885, Hook696, Kent7301, joker88john, CucyNoiD, JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Af420, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, Bsandipan, Tramullas, Acer, V4switch, Salgo60, Lewizho99, Maathavan, Silverfish, Neuronton, Susannaanas, Wong128hk, Fuzheado, Jane023, Wikidata-bugs, Base, matthiasmullie, Daniel_Mietchen, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T333758: Wikidata CentralAuth
Reedy added a comment. What browser are you using? Please always fill out the full bug report template. If it's Firefox, it's almost certainly T226797: SUL: Login state not propagated across domains in Safari and in Firefox with strict mode <https://phabricator.wikimedia.org/T226797>. TASK DETAIL https://phabricator.wikimedia.org/T333758 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, Bugreporter, Aklapper, Hari_Zalan, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T216601: Allow download of Wikidata query results in GPS-friendly format(s)
Reedy added a comment. Restricted Application added a project: User-ItamarWMDE. In T216601#8621290 <https://phabricator.wikimedia.org/T216601#8621290>, @ItamarWMDE wrote: > @reedy what tool did you use to create these diagrams, I'd be interested in it for dependency analysis in other projects as well. First result on google ;) https://npmgraph.js.org/ TASK DETAIL https://phabricator.wikimedia.org/T216601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, Arian_Bozorg, ItamarWMDE, valerio.bozzolan, Jklamo, Gehel, MPhamWMF, Lydia_Pintscher, JeanFred, Nemo_bis, Husky, Peb, Frettie, Geertivp, Salgo60, Pigsonthewing, Aklapper, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, AWesterinen, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, Ferenczy, sarhan.alaa, Samuditha24, IM3847, joker88john, CucyNoiD, Nandana, Namenlos314, kostajh, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Jayprakash12345, Chicocvenancio, MichaelSchoenitzer_WMDE, Mahir256, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, Jogi_don, _jensen, rosalieper, xSavitar, Neuronton, Scott_WUaS, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331, jayantanth, Rxy ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T216601: Allow download of Wikidata query results in GPS-friendly format(s)
Reedy added a comment. In T216601#8619272 <https://phabricator.wikimedia.org/T216601#8619272>, @Lydia_Pintscher wrote: > We looked into the existing patch more closely and it currently pulls in 4 new libraries that would all have to go through security review at the WMF. And then a lot more dependants... Just what the new packages bring in: F36852816: Screenshot 2023-02-15 at 22.47.55.png <https://phabricator.wikimedia.org/F36852816> Before: F36852814: Screenshot 2023-02-15 at 22.51.32.png <https://phabricator.wikimedia.org/F36852814> After: F36852815: Screenshot 2023-02-15 at 22.51.41.png <https://phabricator.wikimedia.org/F36852815> F36852813: wikidata_query_gui_0_1_4_dependencies.svg <https://phabricator.wikimedia.org/F36852813> F36852812: geojson_jsonld_togpx_tokml_wkx_dependencies.svg <https://phabricator.wikimedia.org/F36852812> F36852811: wikidata_query_gui_0_1_4_dependencies(1).svg <https://phabricator.wikimedia.org/F36852811> TASK DETAIL https://phabricator.wikimedia.org/T216601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, Arian_Bozorg, ItamarWMDE, valerio.bozzolan, Jklamo, Gehel, MPhamWMF, Lydia_Pintscher, JeanFred, Nemo_bis, Husky, Peb, Frettie, Geertivp, Salgo60, Pigsonthewing, Aklapper, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, AWesterinen, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, Ferenczy, sarhan.alaa, Samuditha24, IM3847, joker88john, CucyNoiD, Nandana, Namenlos314, kostajh, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Jayprakash12345, Chicocvenancio, MichaelSchoenitzer_WMDE, Mahir256, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, Jogi_don, _jensen, rosalieper, xSavitar, Neuronton, Scott_WUaS, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331, jayantanth, Rxy ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T321967: Enable Wikibase on Wikimedia Foundation Governance Wiki
Reedy added a comment. While it doesn't need a WMDE person/Wikidata developer to necessarily do the deploy, I wouldn't mind one of them weighing in on a few things. The `wbc_entity_usage` table from `client/sql/mysql/entity_usage.sql` needs creating on foundationwiki (that's easy; a script in #mediawiki-extensions-wikimediamaintenance <https://phabricator.wikimedia.org/tag/mediawiki-extensions-wikimediamaintenance/> helps there too), and it would look like the `sites` table is out of date and probably needs updating too (I think that should be trivial enough too; it's missing some rows vs say enwiki, but probably isn't a blocker). Both are basically things we do when creating a new wiki. I don't think Wikidata is aware that foundationwiki exists either (it is in the sites table); I'm guessing it should be classed under `Multilingual sites` (ala meta, mediawiki and commons) if we want to allow some cross linking too. Not sure if/where this needs doing, or whether your patch already accommodates for that, or whether something else is needed for that. Not sure offhand who is the best person in WMDE to poke for this, either for the help, or to find someone to help (ie some manager-y type) find someone to help. TASK DETAIL https://phabricator.wikimedia.org/T321967 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, Base, Jdforrester-WMF, Silvan_WMDE, Varnent, Aklapper, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, Yodas_henchman, 786, NguoiDungKhongDinhDanh, Biggs657, karapayneWMDE, Invadibot, Zabe, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, AKA_MBG, Kent7301, Dibya, joker88john, 94rain, CucyNoiD, Nandana, Tks4Fish, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, Kizule, LawExplorer, Lewizho99, Maathavan, Devwaker, Niklitov, _jensen, Urbanecm, rosalieper, Neuronton, JEumerus, Scott_WUaS, Ananthsubray, Superzerocool, Stanglavine, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Wikidata-bugs, Snowolf, aude, Dcljr, Matanya, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T325242: Dates with a precision of 10,000 years or more render with the same precision as year
Reedy added a project: MediaWiki-extensions-WikibaseRepository. TASK DETAIL https://phabricator.wikimedia.org/T325242 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, RPI2026F1, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T322467: Wikibase test failures on REL1_39
Reedy added projects: MW-1.38-release, MW-1.37-release, MW-1.35-release. Reedy reopened this task as "Open". Reedy added a comment. Any chance of a backport to #mw-1.35-release <https://phabricator.wikimedia.org/tag/mw-1.35-release/> please? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/820883 https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php74-noselenium-docker/27835/console The failures look to be identical TASK DETAIL https://phabricator.wikimedia.org/T322467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Reedy Cc: GreenReaper, Lucas_Werkmeister_WMDE, Aklapper, Reedy, Chutz, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Peteosx1x, ItamarWMDE, Mgagat, Akuckartz, Totolinototo3, Zanziii, RhinosF1, Sadisticturd, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, hashar ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T323472: Editing raw watchlist (when the watchlist is big) fails with an error
Reedy closed this task as a duplicate of T41510: Opening Special:EditWatchlist with a large watchlist hits server timeout (Create watchlist pager). TASK DETAIL https://phabricator.wikimedia.org/T323472 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Lydia_Pintscher, Aklapper, Mohammed_Sadat_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T322467: Wikibase test failures on REL1_39
Reedy added a comment. Should we just remove Wikibase (et al) from the Math dependancy tree on REL1_39? Or is there a trivial backport or two we can do to fix WikibaseRepository in REL1_39? TASK DETAIL https://phabricator.wikimedia.org/T322467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Reedy, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Peteosx1x, ItamarWMDE, Mgagat, Akuckartz, Totolinototo3, Zanziii, Sadisticturd, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, hashar ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T322467: Wikibase test failures on REL1_39
Reedy added a project: Continuous-Integration-Config. Reedy triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T322467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Reedy, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Peteosx1x, ItamarWMDE, Mgagat, Akuckartz, Totolinototo3, Zanziii, Sadisticturd, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, hashar ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T321967: Enable Wikibase on Wikimedia Foundation Governance Wiki
Reedy edited projects, added Wikidata; removed Wikibase and Wikidata Architecture Overview. Reedy added a comment. Restricted Application added a project: wdwb-tech. So it wants to be a Wikibase Client? TASK DETAIL https://phabricator.wikimedia.org/T321967 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, Base, Jdforrester-WMF, Silvan_WMDE, Varnent, Aklapper, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, Yodas_henchman, 786, NguoiDungKhongDinhDanh, Biggs657, karapayneWMDE, Invadibot, Zabe, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, AKA_MBG, Kent7301, Dibya, joker88john, 94rain, CucyNoiD, Nandana, Tks4Fish, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, QZanden, Kizule, LawExplorer, Lewizho99, Maathavan, Devwaker, Niklitov, _jensen, Urbanecm, rosalieper, Neuronton, JEumerus, Scott_WUaS, Ananthsubray, Superzerocool, Stanglavine, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Wikidata-bugs, Snowolf, aude, Dcljr, Matanya, Mbch331, Jay8g, Krenair, Lydia_Pintscher ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T300770: Special:UnconnectedPages for main namespace is slow (ca. 10 seconds)
Reedy changed the visibility from "Custom Policy" to "Public (No Login Required)". Reedy changed the edit policy from "Custom Policy" to "All Users". Restricted Application added a subscriber: Ericliu1912. TASK DETAIL https://phabricator.wikimedia.org/T300770 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, Reedy Cc: Ericliu1912, Reedy, Mike_Peel, Stang, hoo, tstarling, Ladsgroup, Manuel, Michael, Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, CDanis, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Bawolff, Mbch331, Legoktm, RhinosF1 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T320333: WikibaseLexeme PHPUnit 9 warnings
Reedy closed this task as "Resolved". Reedy claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T320333 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T319390: Phan fails on Wikibase REL1_39 branch: Call to method __construct from undeclared class \Elastica\Query\Exists
Reedy added a project: MW-1.39-release. TASK DETAIL https://phabricator.wikimedia.org/T319390 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, MPhamWMF, maantietaja, Wilmanbeno, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, jeremyb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T313564: Bump onoi/message-reporter in vendor.git to 1.4.2 for php 8 support
Reedy closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T313564 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdforrester-WMF, Reedy Cc: Jdforrester-WMF, JeroenDeDauw, Reedy, Aklapper, Bawolff, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Nikerabbit, MaxSem, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T315144: Wikidata description shows on Mobile only and not on Desktop on Wikipedia
Reedy edited projects, added Wikidata; removed Wikimedia-Site-requests. TASK DETAIL https://phabricator.wikimedia.org/T315144 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Ahmetyusufdev, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, LisafBia6531, Yodas_henchman, NguoiDungKhongDinhDanh, Zabe, Juan90264, CptViraj, AKA_MBG, Dibya, 94rain, Tks4Fish, Jayprakash12345, Kizule, Devwaker, Niklitov, Urbanecm, JEumerus, Ananthsubray, Superzerocool, Stanglavine, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Snowolf, Base, Dcljr, Matanya, Jay8g, Krenair ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T314859: Allow merging of two Items in the Wikibase REST API
Reedy renamed this task from "merging of two Items in the Wikibase REST API" to "Allow merging of two Items in the Wikibase REST API". TASK DETAIL https://phabricator.wikimedia.org/T314859 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T314436: Error in "item.can add a statement using the keyboard"
Reedy created this task.
Reedy added projects: MediaWiki-extensions-WikibaseRepository, Browser-Tests,
ci-test-error (WMF-deployed Build Failure).
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/819626/
https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/163933/console
21:26:46 [0-1] RUNNING in chrome - /repo/tests/selenium/specs/item.js
21:26:47 [0-1]
21:27:08 [0-1] Screenshot:
/workspace/log/can-add-a-statement-using-the-keyboard-2022-08-02T20-27-07-408Z.png
21:27:08 [0-1]
21:27:08 [0-1] Error in "item.can add a statement using the keyboard"
21:27:08 Error: element ("//ul[contains(@class,
"ui-suggester-list")][not(contains(@style,"display: none"))]//li") still not
displayed after 1ms
21:27:08 at ItemPage.selectFirstSuggestedEntityOnEntitySelector
(/workspace/src/extensions/Wikibase/node_modules/wdio-wikibase/pagesections/ComponentInteraction.js:42:66)
21:27:08 at Context.
(/workspace/src/extensions/Wikibase/repo/tests/selenium/specs/item.js:27:12)
21:27:08 [0-1]
21:27:12 [0-1] Screenshot:
/workspace/log/old-revisions-do-not-have-an-edit-link-2022-08-02T20-27-12-692Z.png
21:27:12 [0-1]
21:27:12 [0-1] FAILED in chrome - /repo/tests/selenium/specs/item.js
TASK DETAIL
https://phabricator.wikimedia.org/T314436
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Reedy
Cc: Aklapper, Reedy, ItamarWMDE, Akuckartz, DannyS712, lucamauri, Gq86,
Wikidata-bugs, zeljkofilipin, Jdforrester-WMF
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T313564: Bump onoi/message-reporter in vendor.git to 1.4.2 for php 8 support
Reedy added a comment. In T313564#8096444 <https://phabricator.wikimedia.org/T313564#8096444>, @Bawolff wrote: > Hmm, i know general practice is to require exact version in vendor.git, but I wonder if this is a case where it would be acceptable to `"1.4.2|1.4.1"` since both versions are essentially identical, and its just which version of php they are marked as supporting The "problem" with doing that becomes if/when someone runs composer using a different version of PHP to what was used last time, the version installed may change. 1.4.1 says `php: ^5.6.99|^7.0` 1.4.2 says `php: >=7.3` TASK DETAIL https://phabricator.wikimedia.org/T313564 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: JeroenDeDauw, Reedy, Aklapper, Bawolff, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Nikerabbit, Jdforrester-WMF, MaxSem, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T313042: Error in "item.can add a statement using the keyboard" Error: waitUntil condition timed out after 10000ms
Reedy updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T313042 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Lucas_Werkmeister_WMDE, Aklapper, Reedy, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T313042: Error in "item.can add a statement using the keyboard" Error: waitUntil condition timed out after 10000ms
Reedy added a comment. It went away with a recheck... TASK DETAIL https://phabricator.wikimedia.org/T313042 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Lucas_Werkmeister_WMDE, Aklapper, Reedy, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T313042: Error in "item.can add a statement using the keyboard" Error: waitUntil condition timed out after 10000ms
Reedy created this task. Reedy added projects: MediaWiki-extensions-WikibaseRepository, ci-test-error (WMF-deployed Build Failure), Browser-Tests. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Seen on a Translate patch 16:07:36 [0-1] Error in "item.can add a statement using the keyboard" 16:07:36 Error: waitUntil condition timed out after 1ms 16:07:36 at Context. (/workspace/src/extensions/Wikibase/repo/tests/selenium/specs/item.js:60:11) 16:07:36 [0-1] 16:07:40 [0-1] Screenshot: /workspace/log/old-revisions-do-not-have-an-edit-link-2022-07-14T15-07-40-067Z.png 16:07:40 [0-1] 16:07:40 [0-1] FAILED in chrome - /repo/tests/selenium/specs/item.js TASK DETAIL https://phabricator.wikimedia.org/T313042 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Reedy, ItamarWMDE, Akuckartz, DannyS712, lucamauri, Gq86, Wikidata-bugs, zeljkofilipin, Jdforrester-WMF ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T310421: Disable captcha in entity namespaces until T87854 is fixed
Reedy edited projects, added Wikimedia-Site-requests; removed ConfirmEdit (CAPTCHA extension), Wikibase (3rd party installations). Restricted Application added a project: wdwb-tech. TASK DETAIL https://phabricator.wikimedia.org/T310421 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: OlafJanssen, kerberizer, Addshore, AntonyScerri, So9q, Aklapper, Bugreporter, Astuthiodit_1, Yodas_henchman, NguoiDungKhongDinhDanh, karapayneWMDE, Invadibot, Zabe, maantietaja, Juan90264, ItamarWMDE, Akuckartz, CptViraj, AKA_MBG, Dibya, 94rain, Nandana, Tks4Fish, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, Kizule, LawExplorer, Devwaker, Niklitov, _jensen, Urbanecm, rosalieper, 4nn1l2, JEumerus, Scott_WUaS, Ananthsubray, Superzerocool, Stanglavine, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Wikidata-bugs, Snowolf, Base, aude, Dcljr, Matanya, Mbch331, Jay8g, Krenair, darthmon_wmde, Gboyers, Dinoguy1000, fbstj, Lydia_Pintscher, Florian, RhinosF1 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T306358: NewEntitySchemaTest::testNewSchemaIsNotCreatedWhenBlocked test failure
Reedy created this task. Reedy added projects: ci-test-error (WMF-deployed Build Failure), Wikidata, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Seen on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EntitySchema/+/781404 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ApiFeatureUsage/+/777460 https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/147085/console 05:52:36 1) EntitySchema\Tests\Integration\MediaWiki\Specials\NewEntitySchemaTest::testNewSchemaIsNotCreatedWhenBlocked 05:52:36 InvalidArgumentException: WikiPage constructed on a Title that cannot exist as a page: Special:NewEntitySchema 05:52:36 05:52:36 /workspace/src/includes/page/WikiPage.php:177 05:52:36 /workspace/src/includes/page/Article.php:141 05:52:36 /workspace/src/includes/page/Article.php:127 05:52:36 /workspace/src/includes/page/Article.php:179 05:52:36 /workspace/src/includes/Permissions/PermissionManager.php:815 05:52:36 /workspace/src/includes/Permissions/PermissionManager.php:478 05:52:36 /workspace/src/includes/Permissions/PermissionManager.php:323 05:52:36 /workspace/src/extensions/EntitySchema/src/MediaWiki/Specials/NewEntitySchema.php:241 05:52:36 /workspace/src/extensions/EntitySchema/src/MediaWiki/Specials/NewEntitySchema.php:47 05:52:36 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:115 05:52:36 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:44 05:52:36 /workspace/src/tests/phpunit/includes/specials/SpecialPageTestBase.php:78 05:52:36 /workspace/src/extensions/EntitySchema/tests/phpunit/integration/MediaWiki/Specials/NewEntitySchemaTest.php:87 05:52:36 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:467 TASK DETAIL https://phabricator.wikimedia.org/T306358 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Reedy, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T305313: Mark git repositories that are now a container within Wikibase.git as READONLY
Reedy renamed this task from "Mark git repositories that are now container within Wikibase.git as READONLy" to "Mark git repositories that are now a container within Wikibase.git as READONLY". TASK DETAIL https://phabricator.wikimedia.org/T305313 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Tarrow, JeroenDeDauw, WMDE-leszek, Addshore, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T297754: CVE-2022-28204: Whatlinkshere of heavily used properties in wikidata can be easily utilized as a DDoS vector
Reedy changed the visibility from "Custom Policy" to "Public (No Login Required)". Reedy changed the edit policy from "Custom Policy" to "All Users". TASK DETAIL https://phabricator.wikimedia.org/T297754 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Reedy Cc: gerritbot, Reedy, sbassett, Lydia_Pintscher, noarave, Rosalie_WMDE, Silvan_WMDE, Aklapper, Marostegui, LSobanski, Michael, Lucas_Werkmeister_WMDE, Addshore, Ladsgroup, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Devnull, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CDanis, DannyS712, CucyNoiD, Nandana, Gaboe420, Amorymeltzer, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Lsherwinforone, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, Sethakill, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Bawolff, Dinoguy1000, Mbch331, Jay8g, Legoktm, RhinosF1 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T304625: CI failing with IndexPager::buildQueryInfo error: 'wikidb.unittest_globaluser.gu_id' isn't in GROUP BY
Reedy merged a task: T304661: CI failing for extensions/Score. Reedy added a subscriber: Esanders. TASK DETAIL https://phabricator.wikimedia.org/T304625 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Esanders, Krinkle, Reedy, aaron, Majavah, DLynch, Zabe, Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, CptViraj, DannyS712, wildly_boy, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, Snowolf, aude, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T304646: "500 Internal Server Error" is returned in Wikimedia Commons Query Service
Reedy added a project: Wikidata-Query-Service. TASK DETAIL https://phabricator.wikimedia.org/T304646 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Rdrg109, MPhamWMF, CBogen, Namenlos314, Gq86, Lucas_Werkmeister_WMDE, EBjune, merbst, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T236938: Add monolingual language code "tok" (Toki Pona) to Wikidata
Reedy renamed this task from "Add monolingual language code "tok" (Toki Pona)" to "Add monolingual language code "tok" (Toki Pona) to Wikidata". TASK DETAIL https://phabricator.wikimedia.org/T236938 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: TheresNoTime, MZMcBride, Tommy_Kronkvist, LaPingvino, Tbodt, Robin_van_der_Vliet, Mbch331, jhsoby, Aklapper, blinry, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Nikki, Wikidata-bugs, aude ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T300306: [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release
Reedy updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T300306 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Daimona, Krinkle, Edtadros, Volker_E, Esanders, Aklapper, Tacsipacsi, Nikerabbit, Iniquity, Johan, PeterBowman, Amorymeltzer, Jdforrester-WMF, ovasileva, Trizek-WMF, Izno, Patafisik, Jdlrobson, Fernandobacasegua34, Astuthiodit_1, 786, fenpedia, Suran38, Biggs657, karapayneWMDE, toberto, bwang, Invadibot, Feldpauschhaylee2017, LaMagiaaa, Lalamarie69, Zabe, Asartea, Florian_COLLIN, R4356th, Bebiezaza, maantietaja, Wilmanbeno, Juan90264, Alter-paule, Beast1978, CBogen, GeneralNotability, Un1tY, FelixE2019, Akuckartz, Dzaky17, Hook696, CptViraj, darthmon_wmde, ST47, WDoranWMF, Majavah, Kent7301, Chambersjay, RhinosF1, EvanProdromou, joker88john, SD0001, 94rain, DannyS712, wildly_boy, CucyNoiD, Nandana, Chief_Mike, Tks4Fish, Tumz24, Gaboe420, Jony, CycloneIsaac, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Minilexikon, Bsandipan, Gboyers, GoranSMilovanovic, ihojose, Mahir256, QZanden, LawExplorer, Litanwei, spatton, Samuele2002, Lewizho99, JJMC89, Maathavan, SundanceRaphael, _jensen, Jseddon, rosalieper, Agabi10, AGK, XanonymusX, Neuronton, RuyP, JEumerus, gabriel-wmde, Scott_WUaS, mb, Cirdan, Pchelolo, DStrine, XenoRyet, Wong128hk, Luke081515, Nirmos, Bsadowski1, mys_721tx, I_JethroBT, Unapersona, Zache, alex-mashin, Niharika, Wikidata-bugs, Snowolf, Base, aude, AndyRussG, Ebe123, Nullzero, Pcoombe, Huji, Dinoguy1000, jeblad, jayvdb, MrStradivarius, RandomDSdevel, fbstj, Lydia_Pintscher, Florian, KartikMistry, Isarra, Billinghurst, Ladsgroup, Addshore, Jackmcbarn, Mbch331, Jay8g, Ltrlg, Glaisher, Krenair, jeremyb, Legoktm ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T303667: Wikispecies+ — sidebar — language links from >1 wikidata item
Reedy added projects: Wikidata, MediaWiki-extensions-WikibaseClient. TASK DETAIL https://phabricator.wikimedia.org/T303667 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Maculosae_tegmine_lyncis, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T303228: ⧼wikibase-validator-bad-prefix⧽ info message is not localised via translatewiki.
Reedy added a comment.
`ValidatorBuilders::getUrlValidator` seems to be the usage
if ( $prefix !== null ) {
// FIXME: It's currently not possible to allow both
http and https at this point.
$validators[] = $this->getPrefixValidator( $prefix,
'bad-prefix' );
}
TASK DETAIL
https://phabricator.wikimedia.org/T303228
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Reedy
Cc: Reedy, Xqt, Aklapper, Reception123, Joseph202, RhinosF1, karapayneWMDE,
Invadibot, maantietaja, Akuckartz, darthmon_wmde, MJL, Nandana, lucamauri,
Hispano76, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen,
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T303228: ⧼wikibase-validator-bad-prefix⧽ info message is not localised via translatewiki.
Reedy added projects: MediaWiki-extensions-WikibaseRepository, Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T303228 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Xqt, Aklapper, Reception123, Joseph202, RhinosF1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, darthmon_wmde, MJL, Nandana, lucamauri, Hispano76, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T303223: Seems the ⧼wikibase-validator-bad-prefix⧽ info message is not localised via translatewiki
Reedy closed this task as a duplicate of T303228: ⧼wikibase-validator-bad-prefix⧽ info message is not localised via translatewiki.. TASK DETAIL https://phabricator.wikimedia.org/T303223 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: RhinosF1, Joseph202, Xqt, Aklapper, Prufkick, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Addshore, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T302324: Refresh WikibaseLexeme readme file
Reedy added a project: Documentation. TASK DETAIL https://phabricator.wikimedia.org/T302324 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, ItamarWMDE, karapayneWMDE, Invadibot, maantietaja, Akuckartz, apaskulin, Nandana, Cpaulf30, Lahi, Gq86, GoranSMilovanovic, Ivana_Isadora, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T302172: Translation issue in German
Reedy added subscribers: LucasWerkmeister, Reedy.
Reedy added a comment.
https://translatewiki.net/w/i.php?title=Wikimedia%3AQuery-builder-find-all-items%2Fde=revision=10376795=9936645
It would look like @LucasWerkmeister fixed this. It was exported in
{8549565d7bf6758f46be620792aa0a9dba671b88}.
Just not deployed?
TASK DETAIL
https://phabricator.wikimedia.org/T302172
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Reedy
Cc: Reedy, LucasWerkmeister, Aklapper, ViggieJoe, Prufkick, karapayneWMDE,
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic,
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Srdjan, MuhammadShuaib,
LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Addshore,
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T301273: Wikibase submodule is linked to github, causing scap prep to fail
Reedy removed a parent task: T300198: 1.38.0-wmf.22 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T301273 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE, Reedy Cc: karapayneWMDE, Addshore, Michael, Lucas_Werkmeister_WMDE, ItamarWMDE, Reedy, Zabe, Ladsgroup, Majavah, Umherirrender, thcipriani, jeena, Aklapper, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T301249: Handle deprecation of Serializable interface in Wikibase
Reedy added a comment. In T301249#7693897 <https://phabricator.wikimedia.org/T301249#7693897>, @Lucas_Werkmeister_WMDE wrote: > …And I should learn to read the full task description, this one isn’t only about entity IDs. 臘 > > But from a quick look through them, it seems like the other affected classes also don’t have super complicated serialization methods. In fact the new magic method interface should be more easy to implement, since we can directly return arrays in some cases instead of wrapping them in JSON. Sounds pretty much like what I did for the couple of patches to numerous classes in MW Core. Make the new `__` methods handle the array version, keep the old non `__` prefixed versions with any special handling (turning to strings, or whatever else) and make them call the `__` versions https://gerrit.wikimedia.org/r/c/756964 https://gerrit.wikimedia.org/r/c/758800 And if the tests are about right, you should know whether your changes are correct ;D TASK DETAIL https://phabricator.wikimedia.org/T301249 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Lucas_Werkmeister_WMDE, Aklapper, Reedy, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Nikerabbit, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T301273: Wikibase submodule is linked to github, causing scap prep to fail
Reedy added a comment. Reverted out of .21 in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/760979 (as the code isn't used, this is the quickest way to cleanup) TASK DETAIL https://phabricator.wikimedia.org/T301273 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, Zabe, Ladsgroup, Majavah, Umherirrender, thcipriani, jeena, Aklapper, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T301249: Handle deprecation of Serializable interface in Wikibase
Reedy updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T301249 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Reedy, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Nikerabbit, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T301248: Handle deprecation of Serializable interface in WikibaseLexeme
Reedy updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T301248 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Nikerabbit, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T299312: Deprecated: CLASS implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for o
Reedy removed projects: wdwb-tech, Wikidata, Wikidata Lexicographical data, Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T299312 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, Krinkle, aaron, Aklapper, Majavah, Vali.matei, Nikerabbit, 786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T301249: Handle deprecation of Serializable interface in Wikibase
Reedy created this task. Reedy added projects: PHP 8.1 support, Wikidata, wdwb-tech. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T301249 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Reedy, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Nikerabbit, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T301248: Handle deprecation of Serializable interface in WikibaseLexeme
Reedy created this task. Reedy added projects: PHP 8.1 support, Wikidata Lexicographical data, Wikidata, wdwb-tech. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T301248 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Nikerabbit, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T299312: Deprecated: CLASS implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for o
Reedy removed a project: Structured-Data-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T299312 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, Krinkle, aaron, Aklapper, Majavah, 786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Nikerabbit, Addshore, Mbch331, toberto, CBogen ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T299312: Deprecated: CLASS implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for o
Reedy removed a project: WikibaseMediaInfo. TASK DETAIL https://phabricator.wikimedia.org/T299312 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, Krinkle, aaron, Aklapper, Majavah, 786, Suran38, Biggs657, toberto, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Nikerabbit, Addshore, Mbch331, Ricordisamoa ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T122096: [EPIC] Cleanup WikidataPageBanner architecture
Reedy updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T122096 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: gerritbot, Tgr, Aklapper, Jdlrobson, BeautifulBold, Suran38, Peteosx1x, NavinRizwi, darthmon_wmde, DannyS712, Izno, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T301093: Use of WikidataPageBanner::$wpbFunctionsClass is unhelpful
Reedy updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T301093 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Reedy, darthmon_wmde, DannyS712, Izno, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T301093: Use of WikidataPageBanner::$wpbFunctionsClass is unhelpful
Reedy updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T301093 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Reedy, darthmon_wmde, DannyS712, Izno, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T301093: Use of WikidataPageBanner::$wpbFunctionsClass is unhelpful
Reedy created this task. Reedy added projects: Wikidata-Page-Banner, Technical-Debt. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION The use of `WikidataPageBanner::$wpbFunctionsClass` as an abstraction layer is not a helpful way of representing the code. We don't have any type hints. The comments suggest it's partially for testing purposes... There has to be a better way of doing this /** * Singleton instance for helper class functions * This variable holds the class name for helper functions and is used to make calls to those * functions * Note that this variable is also used by tests to store a mock classname of helper functions * in it externally * @var string */ public static $wpbFunctionsClass = "WikidataPageBannerFunctions"; `` TASK DETAIL https://phabricator.wikimedia.org/T301093 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Reedy, darthmon_wmde, DannyS712, Izno, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T301084: WikibaseLexeme 1.36 selenium test failures
Reedy closed this task as "Resolved". Reedy added a comment. In T301084#7687186 <https://phabricator.wikimedia.org/T301084#7687186>, @Reedy wrote: > Basically a dupe of T290183: WikibaseLexeme Selenium tests fail when targeting wiki created by MediaWiki-Docker <https://phabricator.wikimedia.org/T290183>, but on #mw-1.36-release <https://phabricator.wikimedia.org/tag/mw-1.36-release/> Fixed by the fix in T277862: selenium-daily-beta-WikibaseLexeme broken since mid feb 2021 <https://phabricator.wikimedia.org/T277862> though https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/759957 TASK DETAIL https://phabricator.wikimedia.org/T301084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, Invadibot, maantietaja, Akuckartz, RhinosF1, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Raymond, zeljkofilipin, Jdforrester-WMF, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T301084: WikibaseLexeme 1.36 selenium test failures
Reedy added a comment. Basically a dupe of T290183: WikibaseLexeme Selenium tests fail when targeting wiki created by MediaWiki-Docker <https://phabricator.wikimedia.org/T290183>, but on #mw-1.36-release <https://phabricator.wikimedia.org/tag/mw-1.36-release/> TASK DETAIL https://phabricator.wikimedia.org/T301084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, Invadibot, maantietaja, Akuckartz, RhinosF1, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Raymond, zeljkofilipin, Jdforrester-WMF, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T299312: Deprecated: CLASS implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for o
Reedy added projects: WikibaseMediaInfo, Wikidata Lexicographical data,
Wikidata, wdwb-tech.
Reedy added a comment.
Restricted Application added a project: Structured-Data-Backlog.
Numerous instances in Wikibase and also WikibaseLexeme and WikibaseMediaInfo
Interface
Serializable
Usages in Project and Libraries (76 usages found)
/Users/reedy/Library/Application
Support/JetBrains/Toolbox/apps/PhpStorm/ch-0/221.3427.92/PhpStorm 2022.1
EAP.app/Contents/plugins/php/lib/php.jar (5 usages found)
stubs (5 usages found)
gmp (1 usage found)
gmp.php (1 usage found)
799 class GMP implements Serializable
SPL (4 usages found)
SPL.php (2 usages found)
1530 class ArrayObject implements IteratorAggregate,
ArrayAccess, Serializable, Countable
1833 class ArrayIterator implements SeekableIterator,
ArrayAccess, Serializable, Countable
SPL_c1.php (2 usages found)
1049 class SplDoublyLinkedList implements Iterator,
Countable, ArrayAccess, Serializable
2027 class SplObjectStorage implements Countable,
Iterator, Serializable, ArrayAccess
core (37 usages found)
includes (14 usages found)
language (5 usages found)
Message.php (5 usages found)
139 class Message implements MessageSpecifier,
Serializable {
253 * @see Serializable::serialize()
262 * @see Serializable::serialize()
285 * @see Serializable::unserialize()
294 * @see Serializable::unserialize()
libs (6 usages found)
rdbms (2 usages found)
database (2 usages found)
position (2 usages found)
DBPrimaryPos.php (2 usages found)
5 use Serializable;
15 interface DBPrimaryPos extends
Serializable {
GenericArrayObject.php (2 usages found)
180 * @see Serializable::serialize
207 * @see Serializable::unserialize
HashRing.php (1 usage found)
44 class HashRing implements Serializable {
MapCacheLRU.php (1 usage found)
36 class MapCacheLRU implements ExpirationAwareness,
Serializable {
site (3 usages found)
Site.php (3 usages found)
32 class Site implements Serializable {
667 * @see Serializable::serialize
692 * @see Serializable::unserialize
tests (1 usage found)
phpunit (1 usage found)
includes (1 usage found)
site (1 usage found)
SiteTest.php (1 usage found)
291 $this->assertInstanceOf(
Serializable::class, $site );
vendor (22 usages found)
doctrine (4 usages found)
instantiator (4 usages found)
src (4 usages found)
Doctrine (4 usages found)
Instantiator (4 usages found)
Instantiator.php (4 usages found)
11 use Serializable;
25 * the method {@see
\Serializable::unserialize()} when dealing with classes implementing
26 * the {@see \Serializable} interface.
108 is_subclass_of($className,
Serializable::class) ? self::SERIALIZATION_FORMAT_USE_UNSERIALIZER :
self::SERIALIZATION_FORMAT_AVOID_UNSERIALIZER,
phan (9 usages found)
phan (9 usages found)
src (9 usages found)
Phan (9 usages found)
Language (9 usages found)
FQSEN (2 usages found)
AbstractFQSEN.php (2 usages found)
10 use Serializable;
17 abstract class AbstractFQSEN
implements FQSEN, Serializable
EmptyUnionType.php (1 usage found)
1200 * @see \Serializable
FileRef.php (1 usage found)
13 class FileRef implements
\Serializable
NamespaceMapEntry.php (1 usage fo
[Wikidata-bugs] [Maniphest] T260735: Stop using is_resource()
Reedy removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T260735 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: tstarling, brion, Reedy, alex-mashin, Ricordisamoa, ssastry, TheDJ, Aklapper, MaxSem, G1964j, Zekwn, the0001, Invadibot, Zabe, Selby, AndreCstr, maantietaja, XeroS_SkalibuR, Akuckartz, DannyS712, Nandana, Mirahamira, lucamauri, Lahi, Gq86, Jontheil, Markhalsey, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, freephile, Wikidata-bugs, aude, Nikerabbit, Jdforrester-WMF, Addshore, Mbch331, Krenair, 786, Suran38, Biggs657, Lalamarie69, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T268864: WikibaseCirrusSearch uses Elastica's Match class
Reedy changed the status of subtask T271777: Bump rufin/elastica (and related libraries) to versions that support PHP 8.0 from Open to Stalled. TASK DETAIL https://phabricator.wikimedia.org/T268864 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Reedy, Invadibot, MPhamWMF, maantietaja, Wilmanbeno, CBogen, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, jayvdb, Nikerabbit, Jdforrester-WMF, Addshore, MaxSem, Mbch331, jeremyb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T268865: WikibaseLexemeCirrusSearch uses Elastica's Match class
Reedy changed the status of subtask T271777: Bump rufin/elastica (and related libraries) to versions that support PHP 8.0 from Open to Stalled. TASK DETAIL https://phabricator.wikimedia.org/T268865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Reedy, Invadibot, MPhamWMF, maantietaja, Wilmanbeno, CBogen, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, jayvdb, Nikerabbit, Jdforrester-WMF, Addshore, MaxSem, Mbch331, jeremyb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T296599: Create project tag for Schematree_recommender
Reedy added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T296599 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Michaelcochez, Invadibot, Devnull, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Danny_B, Luke081515, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T292110: Security Readiness Review For Improved Property Suggester/Recommender for Wikidata
Reedy added a comment. Thanks. I will note that advocating security bugs be published in public isn't the best. Especially when you refer to `(severe) security vulnerability`, and leaving it to peoples judgement. What counts as severe? Against what scale are we comparing? I would also generally advise on keeping issues on github open and then only using it for some stuff, while suggesting people file a bug here for other stuff. The barrier to entry to create an account here is a little higher, and is more work for people to report something. We can create a specific project on Phabricator for it if it's helpful for longer term maintenance and management. That's easily and trivially done. If this is to be deployed into Wikimedia production (I know, that's TBD and down the line), the canonical repo will need presumably moving to Gerrit, and therefore the issue tracker is not going to be GitHub. Also, for your instructions They need to create an account (via wikitech or Wikipedia et al), then find https://phabricator.wikimedia.org/maniphest/task/edit/form/75/ via the menu at the top... But using that form you can't add other projects initially, they have to save it, and then add them. This isn't obvious, but is done for specific reasons. It's also not clear where you want people to `Add Michaelcochez, Martaannaj and Wikidata to the issue`. We don't want #wikidata <https://phabricator.wikimedia.org/tag/wikidata/> adding as a subscriber, for example, which happens regularly (not specifically wikidata, but certainly adding random projects). It creates more work for people triaging bugs. And then "Security updates are only provided for the latest version of this project." - What's the latest version? There's no tags, no releases. So maybe you're meaning `HEAD` of the main branch? If it helps, and while it is intended and/or is deployed for Wikimedia purposes, reports could just be made to `secur...@wikimedia.org` like any other Wikimedia project. TASK DETAIL https://phabricator.wikimedia.org/T292110 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: sbassett, Michaelcochez, Martaannaj, Lydia_Pintscher, Addshore, WMDE-leszek, karapayneWMDE, Aklapper, Invadibot, Devnull, maantietaja, Akuckartz, Jcross, Dsharpe, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Bawolff, Mbch331, Legoktm ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T295396: Redirect deprecated Wikidata Analytics subdomains to the current subdomain
Reedy renamed this task from "Redirect depreciated Wikidata Analytics subdomains to the current subdomain " to "Redirect deprecated Wikidata Analytics subdomains to the current subdomain ". TASK DETAIL https://phabricator.wikimedia.org/T295396 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: GoranSMilovanovic, Aklapper, Manuel, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T292110: Security Readiness Review For Improved Property Suggester/Recommender for Wikidata
Reedy added a comment. And no sort of even basic linting done either... https://github.com/martaannaj/RecommenderServer/issues/5 filed for doing that as a GitHub Action https://github.com/martaannaj/RecommenderServer/issues/4 filed for running gosec as a GitHub Action too TASK DETAIL https://phabricator.wikimedia.org/T292110 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: sbassett, Michaelcochez, Martaannaj, Lydia_Pintscher, Addshore, WMDE-leszek, karapayneWMDE, Aklapper, Invadibot, Devnull, maantietaja, Akuckartz, Jcross, Dsharpe, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Bawolff, Mbch331, Legoktm ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
