[Wikidata-bugs] [Maniphest] [Reopened] T91376: Make ValueView qunit tests independent of focus.
adrianheine reopened this task as Open. TASK DETAIL https://phabricator.wikimedia.org/T91376 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: thiemowmde, GerardM, adrianheine, JanZerebecki, WMDE-Fisch, Snaterlicious, Tobi_WMDE_SW, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T88543: Browsertests for geo value input
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T88543 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-Fisch, adrianheine Cc: adrianheine, Lydia_Pintscher, Tobi_WMDE_SW, Wikidata-bugs, WMDE-Fisch, Aklapper, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Block] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit
adrianheine reopened blocking task T91376: Make ValueView qunit tests independent of focus. as Open. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Tobi_WMDE_SW, Snaterlicious, WMDE-Fisch, Wikidata-bugs, greg, Krinkle, hashar, JanZerebecki, adrianheine, Lydia_Pintscher, JohnLewis, hoo, aude, wikibugs-l ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T88795: Browsertests for badge-selector
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T88795 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-Fisch, adrianheine Cc: Aklapper, Tobi_WMDE_SW, WMDE-Fisch, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T74664: Smoke browsertests for statements on properties
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T74664 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-Fisch, adrianheine Cc: thiemowmde, Wikidata-bugs, Tobi_WMDE_SW, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T91376: Make ValueView qunit tests independent of focus.
adrianheine added a comment. We have a tag, but unfortunately the fix does not work for PhantomJS. https://github.com/wmde/ValueView/pull/165 does, though. TASK DETAIL https://phabricator.wikimedia.org/T91376 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: thiemowmde, GerardM, adrianheine, JanZerebecki, WMDE-Fisch, Snaterlicious, Tobi_WMDE_SW, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T91376: Make ValueView qunit tests independent of focus.
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T91376 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: thiemowmde, GerardM, adrianheine, JanZerebecki, WMDE-Fisch, Snaterlicious, Tobi_WMDE_SW, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T89243: Remove time conversion logic from JavaScript code
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T89243 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Snaterlicious, adrianheine Cc: Snaterlicious, thiemowmde, Tobi_WMDE_SW, Wikidata-bugs, Addshore, Aklapper, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T72710: StorageException in EditEntityActionTest::testActionForPage (edit-already-exists) and related failures
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T72710 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher, adrianheine Cc: gerritbot, Wikidata-bugs, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T88275: No language fallback applied for property labels on qualifiers and references in JS UI.
adrianheine added a comment. I realized that we probably can skip step 3. (and remove most of `wbUsedEntities` right now) since we don't re-render anything anymore :) I'll try that out. TASK DETAIL https://phabricator.wikimedia.org/T88275 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Liuxinyu970226, matej_suchanek, thiemowmde, Snaterlicious, adrianheine, Aklapper, daniel, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T55845: Browsertests for currently used datavalues (tracking)
adrianheine closed blocking task T88543: Browsertests for geo value input as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T55845 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: WMDE-Fisch, Wikidata-bugs, Tobi_WMDE_SW, Lydia_Pintscher, aude, Aklapper ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Lowered Priority] T88543: Browsertests for geo value input
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-03-11 workboard. adrianheine lowered the priority of this task from High to Normal. TASK DETAIL https://phabricator.wikimedia.org/T88543 WORKBOARD https://phabricator.wikimedia.org/project/board/1095/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-Fisch, adrianheine Cc: adrianheine, Lydia_Pintscher, Tobi_WMDE_SW, Wikidata-bugs, WMDE-Fisch, Aklapper, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T63601: DataTypes should pass jshint
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Invalid. adrianheine claimed this task. adrianheine added a comment. We don't use the DataTypes project on gerrit currently. TASK DETAIL https://phabricator.wikimedia.org/T63601 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, hashar, JeroenDeDauw, Lydia_Pintscher, aude, wikibugs-l ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T86182: Allow list of available languages to be configurable
adrianheine added a subscriber: adrianheine. adrianheine added a comment. What's currently missing is the actual configuration interface. I wrote a proposal regarding that in https://phabricator.wikimedia.org/T78007. I think, though, that for most current needs we could just hard-code our modifications to the ULS language list in Wikibase, since they are somewhat sensible defaults for other installations as well (i. e. not having `de-formal` as terms language, having `und` at monolingual text value language). TASK DETAIL https://phabricator.wikimedia.org/T86182 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, jeblad, thiemowmde, Tobi_WMDE_SW, jayvdb, JanZerebecki, Aklapper, Snipre, Lydia_Pintscher, daniel, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T88275: No language fallback applied for property labels on qualifiers and references in JS UI.
adrianheine added a comment. My proposal: 1. Move the existing formatting JS code into an EntityIdFormatter 2. Replace usage of the formatting code with usage of EntityIdFormatter 3. Add pre-formatted EntityIds to parser output (probably replacing most of `wbUsedEntities`) 4. Implement API-based EntityIdFormatter (using `wbformatvalue`) 5. Remove existing EntityId formatting code from JS TASK DETAIL https://phabricator.wikimedia.org/T88275 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Liuxinyu970226, matej_suchanek, thiemowmde, Snaterlicious, adrianheine, Aklapper, daniel, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T75875: Find a home for EntityChange and friends
adrianheine added a subscriber: adrianheine. adrianheine added a comment. See also https://phabricator.wikimedia.org/T75643. TASK DETAIL https://phabricator.wikimedia.org/T75875 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, daniel, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T75643: EntityChange in lib depends on EntityContent in repo
adrianheine added a blocked task: T75863: split wikibase.git. TASK DETAIL https://phabricator.wikimedia.org/T75643 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Wikidata-bugs, JanZerebecki, adrianheine, aude, daniel ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T76252: create AcceptLanguageSet that is usable in DataModel
adrianheine added a subscriber: adrianheine. adrianheine added a comment. I don't get this. What would it be used for? TASK DETAIL https://phabricator.wikimedia.org/T76252 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, JanZerebecki, aude, daniel ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T51024: Removal of de-formal from allowed language for labels
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Wikidata looks fine in de-formal. As for not allowing de-formal for labels, aliases and descriptions: Wikibase now internally supports specific language lists for them, so we could implement this. TASK DETAIL https://phabricator.wikimedia.org/T51024 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Nemo_bis, Merl, jayvdb, Denny, Lydia_Pintscher, JohnLewis, Fomafix, Wikidata-bugs, Gryllida, Shizhao, Arrbee, wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T47675: [statements-ui] Display red links for deleted Properties
adrianheine added a subscriber: adrianheine. adrianheine added a comment. This is the inverse to https://phabricator.wikimedia.org/T67533. TASK DETAIL https://phabricator.wikimedia.org/T47675 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, Abraham, Lydia_Pintscher, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T59665: editing data values using server-side parser/validation will disable save button until server responds
adrianheine added a comment. I don't think it's broken per se. In any case, supporting saving of unparsed values (i.e. ad-hoc parsing) is quite some new feature which would require a lot of work. TASK DETAIL https://phabricator.wikimedia.org/T59665 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: thiemowmde, Tobi_WMDE_SW, adrianheine, Snaterlicious, Lydia_Pintscher, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T75879: move wikibase parsers and validators into a separate repository
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Validators are only used in repo now and could be moved there. TASK DETAIL https://phabricator.wikimedia.org/T75879 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, daniel, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T44576: [statements-ui] Qunit tests for the creation and display of statements
adrianheine closed this task as Resolved. adrianheine claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T44576 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Wikidata-bugs, Abraham, thiemowmde, Tobi_WMDE_SW, Denny, adrianheine, Snaterlicious, Lydia_Pintscher, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T66995: WikibaseExceptionLocalizer has repo-specific code
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Is this still the case? TASK DETAIL https://phabricator.wikimedia.org/T66995 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T57961: the message that shows the number of sources for a statement seems to use PLURAL incorrectly
adrianheine added a comment. You're right, it's like this: `wikibase-ui-pendingquantitycounter-nonpending` and `wikibase-ui-pendingquantitycounter-pending` are basically called with $1: wikibase-propertyedittool-counter-entrieslabel, $2: n, $3: span title=wikibase-propertyedittool-counter-pending-tooltipwikibase-ui-pendingquantitycounter-pending-pendingsubpart/span and $1: wikibase-statementview-referencesheading-pendingcountersubject, $2: n, $3: span title=wikibase-statementview-referencesheading-pendingcountertooltipwikibase-ui-pendingquantitycounter-pending-pendingsubpart/span How would we best solve this? Is https://phabricator.wikimedia.org/T72838 a duplicate of this? TASK DETAIL https://phabricator.wikimedia.org/T57961 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, Amire80, Ricordisamoa, Lydia_Pintscher, aude, Gryllida, Shizhao, Arrbee ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T65308: Split EntityIdFormatter from EntityIdValueFormatter
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. Done in https://phabricator.wikimedia.org/rEWBAa79f1366a8bef7431854e30d89b7e4a312e0fa55. TASK DETAIL https://phabricator.wikimedia.org/T65308 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, GPHemsley, Tobi_WMDE_SW, aude, daniel ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T76866: Split validators from DataType class
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Possibly done with https://phabricator.wikimedia.org/rEWBA28c003dbba7ce80a750a1e8d7f96df993ebdf66d. What do you think, @daniel? TASK DETAIL https://phabricator.wikimedia.org/T76866 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Krenair, JanZerebecki, aude, Aklapper, daniel, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T74043: Remove class aliases from data-values/geo
adrianheine added subscribers: Aklapper, Lucie. adrianheine merged a task: T87748: remove class_alias usage. TASK DETAIL https://phabricator.wikimedia.org/T74043 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Lucie, Aklapper, Wikidata-bugs, Tobi_WMDE_SW, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Merged] T87748: remove class_alias usage
adrianheine closed this task as a duplicate of T74043: Remove class aliases from data-values/geo. TASK DETAIL https://phabricator.wikimedia.org/T87748 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Aklapper, Lucie, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T68486: Make EntityViewFactory
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. Done in https://phabricator.wikimedia.org/rEWBAf027aea0c5d75df239fa3c6dc7a5b899845043f6. TASK DETAIL https://phabricator.wikimedia.org/T68486 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, Lydia_Pintscher, daniel, JohnLewis, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T71671: False message: List of values is complete.
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. Please reopen if this happens again. TASK DETAIL https://phabricator.wikimedia.org/T71671 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, JAnD, aude, SJu, Ricordisamoa, Steenth, Lydia_Pintscher, JohnLewis ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T44433: Cleanup PID code in Utils
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. Done in https://phabricator.wikimedia.org/rEWBAacf54e9dd03a043494bab3c6f482a911092c8eee. TASK DETAIL https://phabricator.wikimedia.org/T44433 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, Denny, JeroenDeDauw, Lydia_Pintscher, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T75653: Implement new Wikibase Skin
adrianheine closed blocking task T75652: Research how we can maximize compatibility of a new Wikibase skin with Vector (and Monobook) as Invalid. TASK DETAIL https://phabricator.wikimedia.org/T75653 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Wikidata-bugs, matmarex, thiemowmde, Tobi_WMDE_SW, TrevorParscal, adrianheine, Snaterlicious, Aklapper, Jdlrobson, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T75652: Research how we can maximize compatibility of a new Wikibase skin with Vector (and Monobook)
adrianheine closed this task as Invalid. adrianheine claimed this task. adrianheine added a comment. Currently we are not planning to create a new Wikibase skin. TASK DETAIL https://phabricator.wikimedia.org/T75652 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Wikidata-bugs, thiemowmde, Tobi_WMDE_SW, adrianheine, Snaterlicious, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T49930: Allow accessing data from an item not connected to the current page - arbitrary access (tracking)
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T49930 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Eloquence, Reaper35, Pengo, Dr_Brains, jeremyb, RP88, -jem-, Wikidata-bugs, Rical, greg, Kersti, Abraham, JulesWinnfield-hu, Jasper, HenkvD, Addshore, mxn, He7d3r, Daniel_Mietchen, ValterVB, Filceolaire, Bennylin, jayvdb, Denny, Micru, aude, Qgil, matej_suchanek, Cwek, Aubrey, Ricordisamoa, Jarekt, MZMcBride, Aklapper, Hkjacksonhk, Ash_Crow, Mvolz, geraki, Yann, Multichill, Snipre, Liuxinyu970226, Florian, Pietrodn, Ainali, Chmarkine, Laddo, Lydia_Pintscher, MF-Warburg, Stryn, zhuyifei1999, Ltrlg, daniel, Danmichaelo, hoo, Whatamidoing-WMF ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T65528: Replace usage of SimpleSiteLink with Wikibase\DataModel\SiteLink
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. Couldn't find any `SimpleSiteLink` in Wikibase.git. TASK DETAIL https://phabricator.wikimedia.org/T65528 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Declined] T43813: Make a separate extension out of the template engine
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Declined. adrianheine claimed this task. adrianheine added a comment. Core now has its own template engine. We should rather switch to that one: https://phabricator.wikimedia.org/T78559 https://phabricator.wikimedia.org/T91067. TASK DETAIL https://phabricator.wikimedia.org/T43813 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, Tobi_WMDE_SW, Denny, Lydia_Pintscher, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T39459: Don't try to add labels in non-existing languages: restrict to Language::isKnownLanguageTag
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Due to language fallbacks, this looks pretty good now (https://www.wikidata.org/wiki/Q2?uselang=xyzzy), but it still asks you to enter label, description and aliases in xyzzy. `EntityViewFactory::newEntityTermsView` could be replaced with an EntityTermsViewFactory that got the `ContentLanguages` for terms passed in and gets a `LanguageFallbackChain`, yielding an `EntityTermsView` in the first actually supported language in the fallback chain. Or we could sanitize the language as early as possible, for example in `EntityParserOutputGeneratorFactory`. That would not fix this issue for languages which are allowed UI languages, but forbidden as content languages (de-formal for example). Maybe we should do both. TASK DETAIL https://phabricator.wikimedia.org/T39459 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, GPHemsley, siebrand, jeblad, Nemo_bis, SPQRobin, Tobi_WMDE_SW, He7d3r, Denny, matej_suchanek, Lydia_Pintscher, Nikerabbit, hoo, aude, Gryllida, Shizhao, Arrbee ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T57961: the message that shows the number of sources for a statement seems to use PLURAL incorrectly
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Invalid. adrianheine claimed this task. adrianheine added a comment. I don't think this is a code issue either, doesn't look like lego to me. TASK DETAIL https://phabricator.wikimedia.org/T57961 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, Amire80, Ricordisamoa, Lydia_Pintscher, aude, Gryllida, Shizhao, Arrbee ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T45024: Special pages should check permissions and read-only mode before showing a form
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Is that still the case? When doing https://gerrit.wikimedia.org/r/#/c/194532/, I got the feeling that the special pages would not show up without correct permissions. TASK DETAIL https://phabricator.wikimedia.org/T45024 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, AnjaJentzsch, Denny, Lydia_Pintscher, daniel, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T88589: Use of wgUserLanguage is deprecated. Use mw.config instead. in AnonymousI18n gadget
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T88589 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, aude, Aklapper, Wikidata-bugs, GWicke ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T75863: split wikibase.git
adrianheine added a blocking task: T75643: EntityChange in lib depends on EntityContent in repo. TASK DETAIL https://phabricator.wikimedia.org/T75863 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wikidata-bugs, adrianheine Cc: adrianheine, Wikidata-bugs, GPHemsley, Tobi_WMDE_SW, JeroenDeDauw, Lydia_Pintscher, daniel, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T65804: php class namespace errors
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. I suppose this is done since we removed all `class_alias` usages. TASK DETAIL https://phabricator.wikimedia.org/T65804 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, jayvdb, Lydia_Pintscher, JohnLewis, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T67432: PHP notice: Undefined Offset: 1
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. All our modules now support being but directly in `vendor/`. TASK DETAIL https://phabricator.wikimedia.org/T67432 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, JeroenDeDauw, Christopher, JohnLewis, aude, wikibugs-l ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T73100: wbformatvalue called twice when creating statement
adrianheine added a comment. @Snaterlicious Still the case? TASK DETAIL https://phabricator.wikimedia.org/T73100 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Wikidata-bugs, Bene, thiemowmde, adrianheine, Snaterlicious, Lydia_Pintscher, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T73271: Wikidata should use style guide
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T73271 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, Jaredzimmerman-WMF, Legoktm, Snaterlicious, Lydia_Pintscher, Ltrlg, Jdlrobson, JohnLewis, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T45295: Keyword 'use' inconsistency for php namespaces
adrianheine added subscribers: thiemowmde, adrianheine. adrianheine added a comment. I think we are moving towards `use`-ing them, but I'm not sure. @ThiemoWMDE? TASK DETAIL https://phabricator.wikimedia.org/T45295 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, thiemowmde, Wikidata-bugs, jayvdb, JeroenDeDauw, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T53660: Detect the edit state to adapt help messages to user errors
adrianheine added a subscriber: adrianheine. adrianheine added a comment. I think this is not Wikidata-specific. @Lydia_Pintscher? TASK DETAIL https://phabricator.wikimedia.org/T53660 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, Rical, Anomie, Denny, tstarling, Aklapper, Lydia_Pintscher, Jackmcbarn, hoo, vvv, aude, Dinoguy1000, MrStradivarius ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T87640: Wikidata edits do not update page watched icon
adrianheine added a subscriber: adrianheine. adrianheine added a comment. We have code in place that tries to do that, so apparently it's broken. TASK DETAIL https://phabricator.wikimedia.org/T87640 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, JanZerebecki, thiemowmde, daniel, aude, hoo, Lydia_Pintscher, Aklapper, DSGalaktos, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T55849: Migrate current selenium tests to cucumber
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Are there still unmigrated tests? TASK DETAIL https://phabricator.wikimedia.org/T55849 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, Tobi_WMDE_SW, Lydia_Pintscher, aude, Aklapper ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T70019: Use pre-fetched labels throughout EntityView
adrianheine closed blocking task T70020: Use EntityIdHtmlLinkFormatter for format properties in EntityView as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T70019 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Wikidata-bugs, Tobi_WMDE_SW, Lydia_Pintscher, daniel, wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T70020: Use EntityIdHtmlLinkFormatter for format properties in EntityView
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. Done in https://phabricator.wikimedia.org/rEWBAbaf7578c5e675a455a43f3afee3aa59d8fe4c81b TASK DETAIL https://phabricator.wikimedia.org/T70020 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, Lydia_Pintscher, daniel, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T69394: [Monolingual] Can not search for language names in my language
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. Done in https://github.com/wmde/ValueView/commit/dceacfc4aff1b794fa90045f738db838f93c88b8. TASK DETAIL https://phabricator.wikimedia.org/T69394 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, thiemowmde, Lydia_Pintscher, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T75360: save button not activated when changing order of statements
adrianheine closed this task as Invalid. adrianheine claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T75360 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Wikidata-bugs, thiemowmde, adrianheine, aude, Snaterlicious, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T60180: changes to ordering don't persist under certain condition
adrianheine closed this task as Invalid. adrianheine claimed this task. adrianheine added a comment. Moving is not supported anymore. TASK DETAIL https://phabricator.wikimedia.org/T60180 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Wikidata-bugs, thiemowmde, Tobi_WMDE_SW, jayvdb, adrianheine, aude, Snaterlicious, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T59665: editing data values using server-side parser/validation will disable save button until server responds
adrianheine added a comment. This has been the case for all datavalue types for a year. I suppose users adapted to it. Close? TASK DETAIL https://phabricator.wikimedia.org/T59665 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: thiemowmde, Tobi_WMDE_SW, adrianheine, Snaterlicious, Lydia_Pintscher, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T87370: Use ContentLanguages object for special pages JS
adrianheine changed the title from Use ContentLanguages object for special pages to Use ContentLanguages object for special pages JS. TASK DETAIL https://phabricator.wikimedia.org/T87370 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Lydia_Pintscher, adrianheine, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T87369: Use ContentLanguages object for terms JS
adrianheine changed the title from Use ContentLanguages object for terms to Use ContentLanguages object for terms JS. TASK DETAIL https://phabricator.wikimedia.org/T87369 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Lydia_Pintscher, Aklapper, adrianheine, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T85252: Edit buttons are getting cached, although their visibility depends on user rights
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T85252 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, adrianheine Cc: FriedhelmW, gerritbot, Tobi_WMDE_SW, aude, Aklapper, Lydia_Pintscher, daniel, JohnLewis, hoo, Wikidata-bugs, Jdouglas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T88950: Migrate all relevant Lua modules from mw.wikibase.getEntity to mw.wikibase.getEntityObject
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T88950 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucie, adrianheine Cc: Sjoerddebruin, gpaumier, Ricordisamoa, Lydia_Pintscher, aude, Aklapper, hoo, Wikidata-bugs, Jdouglas, GWicke ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T88441: investigate how language fallbacks can be done in entity search
adrianheine added a comment. Some questions: - Who/what (else) is using SearchEntities? - How will we build language fallback chains? Who will configure them? I think that's pretty important for deciding what the API looks like (bool vs list of languages) - Can we really get away with not touching the sorting? This would create an issue when an uninteresting item has a matching label/alias in a fallback language but not in the searched language. I can imagine something like searching for ›Billion‹ (German) and finding ›billion‹ (English). TASK DETAIL https://phabricator.wikimedia.org/T88441 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, adrianheine Cc: aude, daniel, Lydia_Pintscher, Snaterlicious, adrianheine, Aklapper, Wikidata-bugs, Jdouglas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T90756: Maintenance script to update a client wiki's subscriptions based on the usage tracking table.
adrianheine added a subscriber: adrianheine. adrianheine added a project: Patch-For-Review. adrianheine added a comment. https://gerrit.wikimedia.org/r/#/c/193815/ TASK DETAIL https://phabricator.wikimedia.org/T90756 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, adrianheine Cc: adrianheine, Aklapper, Tobi_WMDE_SW, daniel, aude, hoo, Wikidata-bugs, Jdouglas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T89698: API function wbsetqualifier blocks frontend
adrianheine added a comment. I think the current behavior is not too bad. The Wikibase JavaScript code found some value it cannot allow you to edit because the UI is not able to represent the current state. What's broken about this is that the UI is not able to handle non-standard calendar models, but that's more of a feature request than a bug. We might also think about how to make the JS code more fail-safe, so that at least the remainder of it is executed when it encounters such an error, but I find that to be a minor problem. This is just the kind of issue you get when your data model and API support more than your UI does. In that case, crashing is a much better choice of action than for example silently dropping or overwriting the non-supported value. TASK DETAIL https://phabricator.wikimedia.org/T89698 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde, adrianheine Cc: Lydia_Pintscher, hoo, aude, JanZerebecki, Addshore, adrianheine, thiemowmde, Snaterlicious, Balu, Aklapper, Wikidata-bugs, Jdouglas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T87579: investigate solutions for items with a large number of aliases
adrianheine added a comment. Other ideas: - Horizontal table with headers in the left column (below language, maybe right-aligned) - Horizontal table without the headers at all Why is the description between aliases and label? To me it seems like aliases and labels are of the same kind, just different weight. I can also imagine something like this: **Schöneweide** (//also known as `Schweineöde`, `Da bei der HTW`, `Berlin-Schöneweide` // ) Ein Stadtteil von Berlin Probably bad for editing, though. Collapsed and Scrollable is not nice for editing, too. TASK DETAIL https://phabricator.wikimedia.org/T87579 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Lydia_Pintscher, Snaterlicious, adrianheine, Tobi_WMDE_SW, thiemowmde, Wikidata-bugs, Aklapper, Jdouglas, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit
adrianheine added a comment. The failing ExpertExtender tests also need focus apparently. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Tobi_WMDE_SW, Snaterlicious, WMDE-Fisch, Wikidata-bugs, greg, Krinkle, hashar, JanZerebecki, adrianheine, Lydia_Pintscher, JohnLewis, hoo, Jdouglas, aude, wikibugs-l ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T90492: Make Wikibase Repo work with a custom File collection, not only Wikimedia Commons
adrianheine added a comment. I'd suggest to introduce an ExpertFactory replacing the currently used ExpertStore. Then we could control instantiation arguments for the experts and the ValueViewBuilder would get simpler. ContentLanguages could be passed through the ExpertFactory, too. Currently the ValueView has to know a lot about the experts. Too much for my taste. TASK DETAIL https://phabricator.wikimedia.org/T90492 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: despens, adrianheine Cc: Snaterlicious, adrianheine, Ricordisamoa, gerritbot, daniel, Aklapper, Wikidata-bugs, Jdouglas, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Raised Priority] T85799: mw-debug.log missing in Jenkins jobs (Failed to be created Permission denied)
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-03 workboard. adrianheine raised the priority of this task from Normal to Needs Triage. TASK DETAIL https://phabricator.wikimedia.org/T85799 WORKBOARD https://phabricator.wikimedia.org/project/board/1034/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, adrianheine Cc: gerritbot, JanZerebecki, Krinkle, hashar, adrianheine, Aklapper, Wikidata-bugs, Jdouglas, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Raised Priority] T87858: Adjust AuthorityControl Gadget to snakview name changes
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-03 workboard. adrianheine raised the priority of this task from High to Unbreak Now!. TASK DETAIL https://phabricator.wikimedia.org/T87858 WORKBOARD https://phabricator.wikimedia.org/project/board/1034/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude, adrianheine Cc: gerritbot, thiemowmde, hoo, aude, Lydia_Pintscher, adrianheine, Snaterlicious, Tobi_WMDE_SW, Aklapper, Wikidata-bugs, Jdouglas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Raised Priority] T85252: Edit buttons are getting cached, although their visibility depends on user rights
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-03 workboard. adrianheine raised the priority of this task from High to Needs Triage. TASK DETAIL https://phabricator.wikimedia.org/T85252 WORKBOARD https://phabricator.wikimedia.org/project/board/1034/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, adrianheine Cc: FriedhelmW, gerritbot, Tobi_WMDE_SW, aude, Aklapper, Lydia_Pintscher, daniel, JohnLewis, hoo, Wikidata-bugs, Jdouglas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit
adrianheine added a comment. Thank you, @Krinkle! TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Tobi_WMDE_SW, Snaterlicious, WMDE-Fisch, Wikidata-bugs, greg, Krinkle, hashar, JanZerebecki, adrianheine, Lydia_Pintscher, JohnLewis, hoo, Jdouglas, aude, wikibugs-l ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T91377: Make Wikibase qunit tests independent of focus
adrianheine created this task. adrianheine added subscribers: adrianheine, JanZerebecki, WMDE-Fisch, Snaterlicious, Tobi_WMDE_SW, Aklapper. adrianheine added projects: Continuous-Integration, Wikidata, § Wikidata-Sprint-2015-02-25. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T91377 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Aklapper, Tobi_WMDE_SW, Snaterlicious, WMDE-Fisch, JanZerebecki, adrianheine, Wikidata-bugs, Jdouglas, aude, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T91376: Make ValueView qunit tests independent of focus.
adrianheine created this task. adrianheine added subscribers: Tobi_WMDE_SW, Snaterlicious, WMDE-Fisch, JanZerebecki, adrianheine. adrianheine added projects: § Wikidata-Sprint-2015-02-25, Wikidata, Continuous-Integration. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T91376 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, JanZerebecki, WMDE-Fisch, Snaterlicious, Tobi_WMDE_SW, Aklapper, Wikidata-bugs, Jdouglas, aude, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T91385: Use MessageProvider for views in Wikibase
adrianheine created this task. adrianheine added a subscriber: adrianheine. adrianheine added a project: Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Currently, the MessageProvider is only used for the ValueView; it could and should be used for all the views in Wikibase, too, though, in order to reduce coupling with MediaWiki. TASK DETAIL https://phabricator.wikimedia.org/T91385 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Aklapper, Wikidata-bugs, Jdouglas, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Raised Priority] T91376: Make ValueView qunit tests independent of focus.
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-02-25 workboard. adrianheine raised the priority of this task from Normal to High. TASK DETAIL https://phabricator.wikimedia.org/T91376 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: GerardM, adrianheine, JanZerebecki, WMDE-Fisch, Snaterlicious, Tobi_WMDE_SW, Aklapper, Wikidata-bugs, Jdouglas, aude, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit
adrianheine moved this task to Doing on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T74184 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Tobi_WMDE_SW, Snaterlicious, WMDE-Fisch, Wikidata-bugs, greg, Krinkle, hashar, JanZerebecki, adrianheine, Lydia_Pintscher, JohnLewis, hoo, Jdouglas, aude, wikibugs-l ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T91377: Make Wikibase qunit tests independent of focus
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T91377 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Aklapper, Tobi_WMDE_SW, Snaterlicious, WMDE-Fisch, JanZerebecki, adrianheine, Wikidata-bugs, Jdouglas, aude, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T77982: Implement Unit Selector widget
adrianheine closed blocking task T77981: QuantityValueParser: Allow unit to be specified via options as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T77982 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Snipre, thiemowmde, Tobi_WMDE_SW, adrianheine, Snaterlicious, Aklapper, daniel, Wikidata-bugs, Jdouglas, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T77981: QuantityValueParser: Allow unit to be specified via options
adrianheine closed this task as Resolved. adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T77981 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, adrianheine Cc: adrianheine, Snipre, Tobi_WMDE_SW, Aklapper, daniel, Wikidata-bugs, Jdouglas, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T77977: Unit support (tracking)
adrianheine closed blocking task T77981: QuantityValueParser: Allow unit to be specified via options as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T77977 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: DSGalaktos, AmaryllisGardener, Liuxinyu970226, Aklapper, Snipre, daniel, Wikidata-bugs, Jdouglas, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T55845: Browsertests for currently used datavalues (tracking)
adrianheine closed blocking task T88545: Browsertests for URL value input as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T55845 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: WMDE-Fisch, Wikidata-bugs, Tobi_WMDE_SW, Lydia_Pintscher, Jdouglas, aude, Aklapper ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Lowered Priority] T88545: Browsertests for URL value input
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. adrianheine lowered the priority of this task from High to Normal. TASK DETAIL https://phabricator.wikimedia.org/T88545 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-Fisch, adrianheine Cc: adrianheine, Lydia_Pintscher, Tobi_WMDE_SW, Wikidata-bugs, WMDE-Fisch, Aklapper, Jdouglas, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit
adrianheine closed blocking task T91377: Make Wikibase qunit tests independent of focus as Invalid. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Tobi_WMDE_SW, Snaterlicious, WMDE-Fisch, Wikidata-bugs, greg, Krinkle, hashar, JanZerebecki, adrianheine, Lydia_Pintscher, JohnLewis, hoo, Jdouglas, aude, wikibugs-l ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T91377: Make Wikibase qunit tests independent of focus
adrianheine closed this task as Invalid. adrianheine claimed this task. adrianheine added a comment. They already are, it's just ValueView. TASK DETAIL https://phabricator.wikimedia.org/T91377 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Aklapper, Tobi_WMDE_SW, Snaterlicious, WMDE-Fisch, JanZerebecki, adrianheine, Wikidata-bugs, Jdouglas, aude, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T91376: Make ValueView qunit tests independent of focus.
adrianheine added a project: Patch-For-Review. adrianheine added a comment. https://github.com/wmde/ValueView/pull/161 TASK DETAIL https://phabricator.wikimedia.org/T91376 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: GerardM, adrianheine, JanZerebecki, WMDE-Fisch, Snaterlicious, Tobi_WMDE_SW, Aklapper, Wikidata-bugs, Jdouglas, aude, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit
adrianheine added a comment. AFAIK we are the only ones with focus tests. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Tobi_WMDE_SW, Snaterlicious, WMDE-Fisch, Wikidata-bugs, greg, Krinkle, hashar, JanZerebecki, adrianheine, Lydia_Pintscher, JohnLewis, hoo, Jdouglas, aude, wikibugs-l ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T90453: qunit test broken without explicitly setting $wgResourceLoaderMaxQueryLength
adrianheine added a comment. In https://phabricator.wikimedia.org/T90453#1073327, @Krinkle wrote: - The relevant software is incorrectly using the ResourceLoader module system. (E.g. using it as a complete class registry.) This has all kinds of scalability impacts and semantic fragileness to it that warrants addressing. Take an example after VisualEditor where class and file count is very high, but module count is low. I'd like to have a discussion about this resp. ask you some questions regarding that. I don't know where the right place for that would be, though. It is definitely too naive for ResourceLoader not have a limit by default. However I argue this limit should never be reached. If this limit is reached, we're talking about failure mode / error handling / graceful degradation, not normal modus operandi. Dropping to some failure mode seems quite arbitrary to me. I can't see any inherit reason for this to not just work as it does. Logging a warning is something different, that might make sense. TASK DETAIL https://phabricator.wikimedia.org/T90453 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, adrianheine Cc: adrianheine, Snaterlicious, hashar, Tobi_WMDE_SW, Krinkle, gerritbot, JanZerebecki, Aklapper, Wikidata-bugs, Jdouglas, aude, Jdforrester-WMF, jeremyb-phone, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit
adrianheine added a blocking task: T91377: Make Wikibase qunit tests independent of focus. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Tobi_WMDE_SW, Snaterlicious, WMDE-Fisch, Wikidata-bugs, greg, Krinkle, hashar, JanZerebecki, adrianheine, Lydia_Pintscher, JohnLewis, hoo, Jdouglas, aude, wikibugs-l ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T91377: Make Wikibase qunit tests independent of focus
adrianheine added a blocked task: T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit. TASK DETAIL https://phabricator.wikimedia.org/T91377 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Aklapper, Tobi_WMDE_SW, Snaterlicious, WMDE-Fisch, JanZerebecki, adrianheine, Wikidata-bugs, Jdouglas, aude, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T75496: Support new types of Entities in Wikibase Repository
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T75496 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, GPHemsley, thiemowmde, JeroenDeDauw, JanZerebecki, aude, Lydia_Pintscher, daniel, hoo, Jdouglas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T77985: Add mechanism for registering new entity types, to work with things like EntityViewFactory
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T77985 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JeroenDeDauw, adrianheine Cc: adrianheine, JeroenDeDauw, JanZerebecki, aude, Aklapper, daniel, Wikidata-bugs, Jdouglas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T76021: Create extension mechanism for Wikibase Repository
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T76021 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Wikidata-bugs, GPHemsley, thiemowmde, JeroenDeDauw, JanZerebecki, aude, Lydia_Pintscher, daniel, hoo, Jdouglas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit
adrianheine added subscribers: WMDE-Fisch, Snaterlicious, Tobi_WMDE_SW. adrianheine added a comment. The focusing tests fail. We should either try to detect if they could possibly pass and otherwise skip them or remove them altogether. @Tobi_WMDE_SW @snaterlicious @WMDE-Fisch What do you think – Do we need these tests? Aside from that, some ExpertExtender and entitytermsforlanguagesview tests fail, and various tests fail with »mw.WbTemplate: Wrong parameter type. Pass either String or jQuery.«. I don't get what happens there, but I guess reproducing the test job locally will help investigating that. Probably running `grunt qunit` is sufficient for reproducing the failures. I'll happily do that if nobody beats me to it. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Tobi_WMDE_SW, Snaterlicious, WMDE-Fisch, Wikidata-bugs, greg, Krinkle, hashar, JanZerebecki, adrianheine, Lydia_Pintscher, JohnLewis, hoo, Jdouglas, aude, wikibugs-l ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T87237: RFC: Possible redesign of the EntityTermsProvider interface
adrianheine added a comment. Following Thiemo's analysis, I think we don't gain much by artificially grouping the terms properties and items have. The fact that we are not able to come up with a sane name for this adds up to the feeling that this is arbitrary and does not really correspond to anything from the domain we try to model. Thus, I agree that we should phase out Fingerprint and EntityTerms in the data models. The view code can, imho, continue to use ›entity terms‹ as a term, as long as we all know that neither all entities have terms nor that all entities have these kinds of terms. TASK DETAIL https://phabricator.wikimedia.org/T87237 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Snaterlicious, adrianheine, Lydia_Pintscher, JeroenDeDauw, Aklapper, thiemowmde, Wikidata-bugs, Jdouglas, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T88441: investigate how language fallbacks can be done in entity search
adrianheine added a comment. @Lydia_Pintscher: If this is resolved, who reviewed it? TASK DETAIL https://phabricator.wikimedia.org/T88441 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, adrianheine Cc: aude, daniel, Lydia_Pintscher, Snaterlicious, adrianheine, Aklapper, Wikidata-bugs, Jdouglas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T90720: Introduce wikibase.view.ViewFactory
adrianheine added a comment. Why did you create a separate task for this? There already is a 1:1 relation for task and change here. TASK DETAIL https://phabricator.wikimedia.org/T90720 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Tobi_WMDE_SW, Aklapper, adrianheine, gerritbot, Lydia_Pintscher, Wikidata-bugs, Jdouglas, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T90268: BadMethodCallException from line 244 of EntityViewPlaceholderExpander.php
adrianheine claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T90268 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: gerritbot, adrianheine, thiemowmde, Snaterlicious, aude, Aklapper, Wikidata-bugs, Jdouglas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T90268: BadMethodCallException from line 244 of EntityViewPlaceholderExpander.php
adrianheine added a project: § Wikidata-Sprint-2015-02-03. TASK DETAIL https://phabricator.wikimedia.org/T90268 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: gerritbot, adrianheine, thiemowmde, Snaterlicious, aude, Aklapper, Wikidata-bugs, Jdouglas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T90459: wikidata qunit test on labs-vagrant have errors
adrianheine added a comment. [ef7b5d6d] Exception Caught: Non-daemonized mode is no longer supported. Please install the mediawiki/services/jobrunner service and update $wgJobTypeConf as needed. TASK DETAIL https://phabricator.wikimedia.org/T90459 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, JanZerebecki, Aklapper, Wikidata-bugs, Jdouglas, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T75604: create documentation of php data model
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T75604 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Snaterlicious, JeroenDeDauw, JanZerebecki, Lydia_Pintscher, daniel, Wikidata-bugs, Jdouglas, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T74907: move git repositories that are dependencies of wikidata to gerrit
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T74907 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Tobi_WMDE_SW, GPHemsley, Legoktm, JeroenDeDauw, JanZerebecki, aude, Glaisher, MZMcBride, Lydia_Pintscher, Dereckson, hoo, Wikidata-bugs, Jdouglas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs