[Wikidata-bugs] [Maniphest] T353683: Unable to find a file by filename while adding a Commons media file statement

[matthiasmullie]

matthiasmullie added a comment.


  In T353683#9444888 <https://phabricator.wikimedia.org/T353683#9444888>, 
@Cparle wrote:
  
  > Don't remember for sure, but it seems unlikely that we excluded it on 
purpose. @matthiasmullie do you remember? Shouldn't be a huge deal to add it 
anyway
  
  Same; I don't remember this having been excluded on purpose.

TASK DETAIL
  https://phabricator.wikimedia.org/T353683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, dcausse, Cparle, Bugreporter, Nikki, Aklapper, Davidshq, 
Danny_Benjafield_WMDE, gonzalez.actor, Astuthiodit_1, karapayneWMDE, toberto, 
Invadibot, maantietaja, Wilmanbeno, CBogen, ItamarWMDE, Nintendofan885, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, KimKelting, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, jayvdb, 
Mbch331, jeremyb
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T253280: Per-file control for some thumbnail generation parameters

[matthiasmullie]

matthiasmullie added a comment.


  There is not currently a way for other wikis to retrieve structured data 
(statements/captions) from Commons other than calling the Wikibase action APIs 
on commons.wikimedia.org.
  
  Yes, T325948: Provide an API for accessing alt text (and possibly other 
structured data) stored with MediaWiki file uploads 
<https://phabricator.wikimedia.org/T325948> & T325949: Allow access to (some) 
structured image metadata across wikis 
<https://phabricator.wikimedia.org/T325949> describe specific implementations 
similar to what'd be needed for T256959: Allow PDF's to be rendered at higher 
(or user specified DPI) <https://phabricator.wikimedia.org/T256959>. Solving 
any one of them would get you at least most of the way there for the others.
  
  They kind of boil down to:
  
  - Create some point of access for files' structured data in core; this thing 
invokes a hook
  - In another extension that is configured in a way that it's able to access 
that data on Commons, subscribe to that hook and fill it with the relevant data
- The obvious place is Extension:WikibaseMediaInfo, but that one is only 
enabled on Commons
  - WikibaseMediaInfo would have to be modified to run be able to run in 
some sort of client-only mode where it doesn't force its UI on NS_FILE pages 
and whatever else it may do that isn't desirable on other wikis
  
  Once the work to make structured data from Commons available on other wikis 
has been completed, the heavy lifting is probably done.
  From there on, the difference between those tasks is essentially picking data 
from another property.
  
  @Tgr does that match your view?
  
  Sidenote: all of these tasks thus far describe implementing some form of API 
that would allow any wiki to access a Commons file's structured data from code, 
but it would also unlock this data from content/wikitext in the form of Lua 
modules.

TASK DETAIL
  https://phabricator.wikimedia.org/T253280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Vlad.shapik, matthiasmullie
Cc: matthiasmullie, Antanana, Ladsgroup, Tgr, hnowlan, GFontenelle_WMF, 
AntiCompositeNumber, Aklapper, 26081981, Astuthiodit_1, karapayneWMDE, 
Invadibot, Lalamarie69, maantietaja, Y.ssk, FRomeo_WMF, Muchiri124, CBogen, 
ItamarWMDE, DAlangi_WMF, Nintendofan885, Akuckartz, WDoranWMF, EvanProdromou, 
Nandana, JKSTNK, jijiki, Jony, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, 
SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, 
Silverfish, _jensen, rosalieper, Agabi10, Taiwania_Justo, Scott_WUaS, Pchelolo, 
Susannaanas, Ixocactus, SBisson, Wong128hk, Fuzheado, Jane023, Wikidata-bugs, 
Base, aude, Daniel_Mietchen, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Raymond, Gilles, TheDJ, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T316516: Bump Wikimedia world's copies of jQuery from 3.6.0 to 3.6.1

[matthiasmullie]

matthiasmullie updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T316516

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Jdlrobson, Jdforrester-WMF, Jersione, PWaigi-WMF, Hellket777, LisafBia6531, 
Astuthiodit_1, JKieserman, DMartin-WMF, 786, Sgs, MaryMunyoki, Biggs657, 
karapayneWMDE, toberto, Invadibot, Aseleste, gengh, caldera, Nikolay_Komarov, 
GrounderUK, Universal_Omega, maantietaja, Juan90264, AndrewEells, Alter-paule, 
NavinRizwi, Beast1978, CBogen, ItamarWMDE, Un1tY, Nintendofan885, Akuckartz, 
Hook696, darthmon_wmde, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, 
Analytics.mediafiles, kostajh, Gaboe420, Hagarshilo, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Ramsey-WMF, mojoaxel, Bsandipan, GoranSMilovanovic, 
45Jayjay1969, Jayprakash12345, Nattes, Mahir256, QZanden, 
YULdigitalpreservation, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, 
rosalieper, xSavitar, Taiwania_Justo, Neuronton, Scott_WUaS, Izno, SBisson, 
Verdy_p, Wikidata-bugs, aude, geraki, Dinoguy1000, Gryllida, Ricordisamoa, 
Mbch331, Jay8g, ori
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T252443: Create dashboard to show growth of structured data on Commons over time

[matthiasmullie]

matthiasmullie added a comment.


  Question: the "SDC edits" tab mentions "only look[ing] at non-bot edits to 
files".
  MediaInfo submits all edits with a `bot: 1` flag via the API (code for 
statements 
<https://github.com/wikimedia/mediawiki-extensions-WikibaseMediaInfo/blob/master/resources/statements/StatementWidget.js#L485>,
 code for captions 
<https://github.com/wikimedia/mediawiki-extensions-WikibaseMediaInfo/blob/master/resources/filepage/CaptionsPanel.js#L538>)
 (the reason is simply "because that's how Wikidata does it 
<https://github.com/wikimedia/wikibase-javascript-api/blob/master/src/RepoApi.js#L696>")
  Does that mean that those edits (via the regular SDC UI) are not included in 
this data, or does that param have no impact on how a "bot edit" is determined?

TASK DETAIL
  https://phabricator.wikimedia.org/T252443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: cchen, matthiasmullie
Cc: matthiasmullie, kzimmerman, nettrom_WMF, GFontenelle_WMF, Abit, Ramsey-WMF, 
CBogen, Astuthiodit_1, EChetty, karapayneWMDE, toberto, ldelench_wmf, 
Invadibot, maantietaja, Y.ssk, FRomeo_WMF, Muchiri124, ItamarWMDE, 
Nintendofan885, Akuckartz, Nandana, JKSTNK, Lahi, Gq86, E1presidente, Cparle, 
SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, 
Silverfish, _jensen, rosalieper, 4nn1l2, Taiwania_Justo, Scott_WUaS, 
Susannaanas, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298700: [L] Remove coordinate location from Structured Data without putting the coordinates in the edit summary

[matthiasmullie]

matthiasmullie added a comment.


  1. The relevant part in this summary (that we want removed) comes from 
`Wikibase\Repo\ChangeOp\ChangeOpRemoveStatement::getSummaryArgs`; that one must 
be prevented from returning the summary args (or its direct caller, 
`Wikibase\Repo\ChangeOp\ChangeOpRemoveStatement::apply` prevented from using 
it; further relevant code lacks information about this data that would make 
this possible without becoming an unstable hack)
  
  Unfortunately, the path down there is rather long:
  
  - `WikibaseRepo.ServiceWiring.php` constructs 
`Wikibase\Repo\ChangeOp\ChangeOpFactoryProvider` (in 
`"WikibaseRepo.ChangeOpFactoryProvider"`)
  - `ChangeOpFactoryProvider` ends up creating and returning a new instance of 
`Wikibase\Repo\ChangeOp\StatementChangeOpFactory` (in 
`getStatementChangeOpFactory`), but uses a myriad of private properties in 
order to do so
  - `StatementChangeOpFactory` creates & returns a new 
`Wikibase\Repo\ChangeOp\ChangeOpRemoveStatement` instance (in 
`newRemoveStatementOp`)
  - Said `ChangeOpRemoveStatement` is the one where we could adjust the kind of 
data that it returns, but actually getting there would require extending from, 
and in some parts largely duplicating, 3 classes in between. It's also not 
inherently isolated to MediaInfo entities so would need additional checks to 
ensure things continue to work when both extensions run side by side.
  
  In short: while not entirely impossible to override that way, this would be a 
hacky job, and a significant maintenance burden for both projects.
  
  2. Before being stored, the data generated via above descriptions end up 
being processed in `Wikibase\Repo\SummaryFormatter::formatArg` (via 
`Wikibase\Repo\SummaryFormatter::formatAutoSummary`). It wouldn't be the ideal 
place to work with this, but it's a shorter chain of direct object creation, as 
we could "simply" override whatever end up being created in 
`WikibaseRepo.ServiceWiring.php`'s `"WikibaseRepo.SummaryFormatter"`, either 
directly in that class, or by passing it a custom `SnakFormatter` (of which we 
have no custom ATM, would probably also be "not trivial" to extend from 
Wikibase's default and produce a different result in (only) this case) that 
blanks out the data in this case. Still, that's a pretty massive 
initialization, and not really a class the lends itself well to being extended.
  
  3. Changing the summary on display is not an option; AFAICT, core doesn't 
offer a way to transform the summary beyond the "autocomment" part (the stuff 
that gets turned into the grey "Removed claim:" part)
  
  4. MediaWiki runs another hook (`onMultiContentSave`) pre-save that exposes 
the summary & allows it to be manipulated. At this point, we have only the 
formatted comment available without further context, but thanks to the 
autoformat summary & the coordinates format, we can quite reliably detect both 
the action (remove statement) and value (something that resembles a coordinate) 
and update it as needed (remove the coordinate). This is a little hacky, but 
it's very contained & has minimal risk (worst case is that the comment format 
changes at some point, at which point coordinates simply stop being removed 
from the comment, which is what we already have at this point). Given the 
challenges with other options, this is a good enough solution as far as I'm 
concerned.

TASK DETAIL
  https://phabricator.wikimedia.org/T298700

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, CBogen, Aklapper, AntiCompositeNumber, karapayneWMDE, 
toberto, Invadibot, maantietaja, Y.ssk, Muchiri124, Akuckartz, Nandana, Seddon, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
4nn1l2, Taiwania_Justo, Scott_WUaS, Ixocactus, Wong128hk, Abit, Wikidata-bugs, 
aude, El_Grafo, Dinoguy1000, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298700: [L] Remove coordinate location from Structured Data without putting the coordinates in the edit summary

[matthiasmullie]

matthiasmullie moved this task from Ready for Development to Doing on the 
Structured-Data-Backlog (Current Work) board.
matthiasmullie claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T298700

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4232/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, CBogen, Aklapper, AntiCompositeNumber, karapayneWMDE, 
toberto, Invadibot, maantietaja, Y.ssk, Muchiri124, Akuckartz, Nandana, Seddon, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
4nn1l2, Taiwania_Justo, Scott_WUaS, Ixocactus, Wong128hk, Abit, Wikidata-bugs, 
aude, El_Grafo, Dinoguy1000, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T300830: When adding a date literal HTML with a span is shown

[matthiasmullie]

matthiasmullie added a comment.


  This hardly seems like a train blocker to me?
  This doesn't impact security, performance, data integrity or substantially 
break anything in any way.
  This looks terrible & we should fix it asap, but all in all it's just a minor 
(non-breaking) issue in a highly specific feature.

TASK DETAIL
  https://phabricator.wikimedia.org/T300830

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Aklapper, Raymond, toberto, Invadibot, GFontenelle_WMF, 
maantietaja, FRomeo_WMF, CBogen, Nintendofan885, Akuckartz, Nandana, JKSTNK, 
Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, Anoop, SandraF_WMF, 
GoranSMilovanovic, Jayprakash12345, QZanden, Tramullas, Acer, LawExplorer, 
Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Wong128hk, 
Jane023, Wikidata-bugs, Base, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T230315: [XL] Create a way to see and add references to structured data on Commons (MediaInfo) statements

[matthiasmullie]

matthiasmullie added a comment.


  After above patch ends up deployed, support for references can be enabled by 
adding `?MediaInfoEnableReferences` to the uri.
  This will let us do some final tests on production before we switch it on for 
real.

TASK DETAIL
  https://phabricator.wikimedia.org/T230315

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Etonkovidova, MichellevL_WMNL, BeatEstermann, Lydia_Pintscher, Addshore, 
mwilliams, ChristianFerrer, Susannaanas, Cparle, CBogen, Alicia_Fagerving_WMSE, 
FRomeo_WMF, Fuzheado, GFontenelle_WMF, John_Cummings, Dominicbm, Husky, 
Spinster, JeanFred, Multichill, Jarekt, valerio.bozzolan, Aklapper, 
Bugreporter, 786, Suran38, Biggs657, toberto, Invadibot, Surya742, Lalamarie69, 
maantietaja, Juan90264, Mohammed_Sadat_WMDE, Jimfhahn, Alter-paule, 
Dr.uesenfieber, Beast1978, Un1tY, Nintendofan885, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, 
Seddon, Lahi, Gq86, Af420, SandraF_WMF, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, Mu301, _jensen, rosalieper, Bodhisattwa, 
Scott_WUaS, Izno, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T297066: Unable to add multiple statements at once in Structured Data on Commons

[matthiasmullie]

matthiasmullie closed this task as "Resolved".
matthiasmullie added a comment.


  I'll close this given that the author confirmed that their issue got 
resolved, and internal QA also flagged this in a separate ticket (T297171 
<https://phabricator.wikimedia.org/T297171>) that's still open.
  Thanks for flagging this!

TASK DETAIL
  https://phabricator.wikimedia.org/T297066

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: dancy, Aklapper, Cparle, matthiasmullie, LucasWerkmeister, toberto, 
Invadibot, GFontenelle_WMF, maantietaja, FRomeo_WMF, CBogen, Nintendofan885, 
Akuckartz, Nandana, JKSTNK, Seddon, Lahi, Gq86, E1presidente, Ramsey-WMF, 
Anoop, SandraF_WMF, GoranSMilovanovic, Jayprakash12345, QZanden, Tramullas, 
Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, 
Susannaanas, Wong128hk, Abit, Jane023, Wikidata-bugs, Base, aude, Ricordisamoa, 
Wesalius, Lydia_Pintscher, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T230315: [XL] Create a way to see and add references to structured data on Commons (MediaInfo) statements

[matthiasmullie]

matthiasmullie added a comment.


  In T230315#7551764 <https://phabricator.wikimedia.org/T230315#7551764>, 
@Etonkovidova wrote:
  
  > (2) [minor] The mockup (**step 2**) displays connecting lines between 
statements/qualifiers/references in** Edit mode**.  The current implementation 
doesn't have it.
  
  Correct.
  There connecting lines posed a bit of a problem: the varying use between 
qualifiers/references and read/edit could be confusing, and they'd be tough to 
implement.
  I discussed them with @mwilliams on Slack, we agreed to drop them, and 
settled on the implementation shown in the video in this comment: 
https://phabricator.wikimedia.org/T230315#7411888

TASK DETAIL
  https://phabricator.wikimedia.org/T230315

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Etonkovidova, MichellevL_WMNL, BeatEstermann, Lydia_Pintscher, Addshore, 
mwilliams, ChristianFerrer, Susannaanas, Cparle, CBogen, Alicia_Fagerving_WMSE, 
FRomeo_WMF, Fuzheado, GFontenelle_WMF, John_Cummings, Dominicbm, Husky, 
Spinster, JeanFred, Multichill, Jarekt, valerio.bozzolan, Aklapper, 
Bugreporter, 786, Suran38, Biggs657, toberto, Invadibot, Surya742, Lalamarie69, 
maantietaja, Juan90264, Mohammed_Sadat_WMDE, Jimfhahn, Alter-paule, 
Dr.uesenfieber, Beast1978, Un1tY, Nintendofan885, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, 
Seddon, Lahi, Gq86, Af420, SandraF_WMF, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, Mu301, _jensen, rosalieper, Bodhisattwa, 
Scott_WUaS, Izno, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T297066: Unable to add multiple statements at once in Structured Data on Commons

[matthiasmullie]

matthiasmullie claimed this task.
matthiasmullie edited projects, added Structured-Data-Backlog (Current Work); 
removed Structured-Data-Backlog.

TASK DETAIL
  https://phabricator.wikimedia.org/T297066

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Aklapper, Cparle, matthiasmullie, LucasWerkmeister, 786, Suran38, Biggs657, 
toberto, Invadibot, Lalamarie69, GFontenelle_WMF, maantietaja, FRomeo_WMF, 
Juan90264, Alter-paule, Beast1978, CBogen, Un1tY, Nintendofan885, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, JKSTNK, Gaboe420, 
Giuliamocci, Cpaulf30, Seddon, Lahi, Gq86, Af420, E1presidente, Ramsey-WMF, 
Anoop, SandraF_WMF, Bsandipan, GoranSMilovanovic, Jayprakash12345, QZanden, 
Tramullas, Acer, LawExplorer, Salgo60, Lewizho99, Maathavan, Silverfish, 
_jensen, rosalieper, Scott_WUaS, Susannaanas, Wong128hk, Abit, Jane023, 
Wikidata-bugs, Base, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T297066: Unable to add multiple statements at once in Structured Data on Commons

[matthiasmullie]

matthiasmullie added a comment.


  This appears to still be broken.
  I assume I introduced this regression here: 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/742188
  I'm reopening & will investigate - if anyone knows more about this and it 
should in fact be closed, please elaborate!

TASK DETAIL
  https://phabricator.wikimedia.org/T297066

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Aklapper, Cparle, matthiasmullie, LucasWerkmeister, toberto, Invadibot, 
GFontenelle_WMF, maantietaja, FRomeo_WMF, CBogen, Nintendofan885, Akuckartz, 
Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Anoop, SandraF_WMF, 
GoranSMilovanovic, Jayprakash12345, QZanden, Tramullas, Acer, LawExplorer, 
Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Wong128hk, 
Abit, Jane023, Wikidata-bugs, Base, aude, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T230315: [XL] Create a way to see and add references to structured data on Commons (MediaInfo) statements

[matthiasmullie]

matthiasmullie added a comment.


  This got stalled a bit because these additional UI elements & interaction 
revealed an issue with some of the code that renders all elements on the page 
(T296616 <https://phabricator.wikimedia.org/T296616>) - that has to be fixed 
before we roll out support for references. I think I have a working fix - it 
needs some more testing, but this is moving forward again.

TASK DETAIL
  https://phabricator.wikimedia.org/T230315

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: MichellevL_WMNL, BeatEstermann, Lydia_Pintscher, Addshore, mwilliams, 
ChristianFerrer, Susannaanas, Cparle, CBogen, Alicia_Fagerving_WMSE, 
FRomeo_WMF, Fuzheado, GFontenelle_WMF, John_Cummings, Dominicbm, Husky, 
Spinster, JeanFred, Multichill, Jarekt, valerio.bozzolan, Aklapper, 
Bugreporter, 786, Suran38, Biggs657, toberto, Invadibot, Surya742, Lalamarie69, 
maantietaja, Juan90264, Mohammed_Sadat_WMDE, Jimfhahn, Alter-paule, 
Dr.uesenfieber, Beast1978, Un1tY, Nintendofan885, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, 
Seddon, Lahi, Gq86, Af420, SandraF_WMF, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, Mu301, _jensen, rosalieper, Bodhisattwa, 
Scott_WUaS, Izno, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T296616: Rendering error

[matthiasmullie]

matthiasmullie claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T296616

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, toberto, Invadibot, Surya742, GFontenelle_WMF, maantietaja, 
FRomeo_WMF, Mohammed_Sadat_WMDE, Jimfhahn, Dr.uesenfieber, CBogen, 
Nintendofan885, Akuckartz, Nandana, JKSTNK, Seddon, Lahi, Gq86, SandraF_WMF, 
valerio.bozzolan, GoranSMilovanovic, QZanden, LawExplorer, Mu301, _jensen, 
rosalieper, Bodhisattwa, Scott_WUaS, Izno, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T296616: Rendering error

[matthiasmullie]

matthiasmullie created this task.
matthiasmullie added projects: StructuredDataOnCommons, Wikidata, 
Wikimedia-Hackathon-2021, Structured-Data-Backlog (Current Work), GLAM, 
Patch-For-Review.
Restricted Application removed a project: Patch-For-Review.

TASK DESCRIPTION
  The patch that introduces support for preferences revealed that under certain 
circumstances, rendering issue can occur: nodes start to duplicate, appear in 
the wrong positions, and lose event handlers.
  
  Steps to reproduce:
  
  - Check out 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/726883
  - //"if you have 2 separate references for a statement (not a single 
reference with 2 lines) and no qualifiers, then the "Add qualifier" button 
doesn't work"//
  
  More info: 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/726883/15#message-209a7bc2ea8fb168a00bb91f9c65643773f1726b

TASK DETAIL
  https://phabricator.wikimedia.org/T296616

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, toberto, Invadibot, Surya742, GFontenelle_WMF, maantietaja, 
FRomeo_WMF, Mohammed_Sadat_WMDE, Jimfhahn, Dr.uesenfieber, CBogen, 
Nintendofan885, Akuckartz, Nandana, JKSTNK, Seddon, Lahi, Gq86, SandraF_WMF, 
valerio.bozzolan, GoranSMilovanovic, QZanden, LawExplorer, Mu301, _jensen, 
rosalieper, Bodhisattwa, Scott_WUaS, Izno, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T230315: [XL] Create a way to see and add references to structured data on Commons (MediaInfo) statements

[matthiasmullie]

matthiasmullie added a comment.


  FYI concerning: "**//Note: This feature will be released behind a feature 
flag so that we can test thoroughly before release.//**"
  -> The feature flag will only toggle the "references" functionality. This 
work also affects how other areas look a bit (qualifiers): those changes will 
go through immediately, even if support for references has not yet been enabled.

TASK DETAIL
  https://phabricator.wikimedia.org/T230315

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: MichellevL_WMNL, BeatEstermann, Lydia_Pintscher, Addshore, mwilliams, 
ChristianFerrer, Susannaanas, Cparle, CBogen, Alicia_Fagerving_WMSE, 
FRomeo_WMF, Fuzheado, GFontenelle_WMF, John_Cummings, Dominicbm, Husky, 
Spinster, JeanFred, Multichill, Jarekt, valerio.bozzolan, Aklapper, 
Bugreporter, 786, Suran38, Biggs657, toberto, Invadibot, Surya742, Lalamarie69, 
maantietaja, Juan90264, Mohammed_Sadat_WMDE, Jimfhahn, Alter-paule, 
Dr.uesenfieber, Beast1978, Un1tY, Nintendofan885, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, 
Seddon, Lahi, Gq86, Af420, SandraF_WMF, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, Mu301, _jensen, rosalieper, Bodhisattwa, 
Scott_WUaS, Izno, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T230315: [XL] Create a way to see and add references to structured data on Commons (MediaInfo) statements

[matthiasmullie]

matthiasmullie added a comment.


  In T230315#7431909 <https://phabricator.wikimedia.org/T230315#7431909>, 
@GFontenelle_WMF wrote:
  
  > I was wondering if you could record another one using actual references.
  
  Here's a video with the original example - does that clear things up?
  
  F34713795: references2.mp4 <https://phabricator.wikimedia.org/F34713795>

TASK DETAIL
  https://phabricator.wikimedia.org/T230315

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: MichellevL_WMNL, BeatEstermann, Lydia_Pintscher, Addshore, mwilliams, 
ChristianFerrer, Susannaanas, Cparle, CBogen, Alicia_Fagerving_WMSE, 
FRomeo_WMF, Fuzheado, GFontenelle_WMF, John_Cummings, Dominicbm, Husky, 
Spinster, JeanFred, Multichill, Jarekt, valerio.bozzolan, Aklapper, 
Bugreporter, Suran38, Biggs657, toberto, Invadibot, Surya742, Lalamarie69, 
maantietaja, Juan90264, Mohammed_Sadat_WMDE, Jimfhahn, Alter-paule, 
Dr.uesenfieber, Beast1978, Un1tY, Nintendofan885, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, 
Seddon, Lahi, Gq86, Af420, SandraF_WMF, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, Mu301, _jensen, rosalieper, Bodhisattwa, 
Scott_WUaS, Izno, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T230315: [XL] Create a way to see and add references to structured data on Commons (MediaInfo) statements

[matthiasmullie]

matthiasmullie added a comment.


  In T230315#7411907 <https://phabricator.wikimedia.org/T230315#7411907>, 
@John_Cummings wrote:
  
  > how is this different to how Wikidata does it?
  
  Not really; they're pretty much the same across Wikidata & Commons, just a 
little different UX/UI to stay in line with what we already had for qualifiers.
  
  In T230315#7431909 <https://phabricator.wikimedia.org/T230315#7431909>, 
@GFontenelle_WMF wrote:
  
  > I was wondering if you could record another one using actual references.
  
  I'll try to put something together next week!

TASK DETAIL
  https://phabricator.wikimedia.org/T230315

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: MichellevL_WMNL, BeatEstermann, Lydia_Pintscher, Addshore, mwilliams, 
ChristianFerrer, Susannaanas, Cparle, CBogen, Alicia_Fagerving_WMSE, 
FRomeo_WMF, Fuzheado, GFontenelle_WMF, John_Cummings, Dominicbm, Husky, 
Spinster, JeanFred, Multichill, Jarekt, valerio.bozzolan, Aklapper, 
Bugreporter, Suran38, Biggs657, toberto, Invadibot, Surya742, Lalamarie69, 
maantietaja, Juan90264, Mohammed_Sadat_WMDE, Jimfhahn, Alter-paule, 
Dr.uesenfieber, Beast1978, Un1tY, Nintendofan885, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, 
Seddon, Lahi, Gq86, Af420, SandraF_WMF, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, Mu301, _jensen, rosalieper, Bodhisattwa, 
Scott_WUaS, Izno, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T230315: [XL] Create a way to see and add references to structured data on Commons (MediaInfo) statements

[matthiasmullie]

matthiasmullie added a comment.


  Implementation revealed a few additional questions around the design & 
interaction of the edit mode, for references and qualifiers.
  We've experimented with a few approaches, filled the gaps & landed on this:
  
  F34678804: references.m4v <https://phabricator.wikimedia.org/F34678804>
  
  TL;DR:
  
  - references & qualifiers will look the same (except that there can be 
multiple groups of references; qualifiers only 1)
  - they'll be grey "block" of snaks in edit mode
  - we're dropping the leading lines in edit mode
  
  LMK if there are unresolved issues with this implementation. Otherwise, this 
is what we'll move forward with.

TASK DETAIL
  https://phabricator.wikimedia.org/T230315

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: MichellevL_WMNL, BeatEstermann, Lydia_Pintscher, Addshore, mwilliams, 
ChristianFerrer, Susannaanas, Cparle, CBogen, Alicia_Fagerving_WMSE, 
FRomeo_WMF, Fuzheado, GFontenelle_WMF, John_Cummings, Dominicbm, Husky, 
Spinster, JeanFred, Multichill, Jarekt, valerio.bozzolan, Aklapper, 
Bugreporter, Suran38, Biggs657, toberto, Invadibot, Surya742, Lalamarie69, 
maantietaja, Juan90264, Mohammed_Sadat_WMDE, Jimfhahn, Alter-paule, 
Dr.uesenfieber, Beast1978, Un1tY, Nintendofan885, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, 
Seddon, Lahi, Gq86, Af420, SandraF_WMF, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, Mu301, _jensen, rosalieper, Bodhisattwa, 
Scott_WUaS, Izno, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T230315: [XL] Create a way to see and add references to structured data on Commons (MediaInfo) statements

[matthiasmullie]

matthiasmullie claimed this task.
matthiasmullie moved this task from Ready for Development to Doing on the 
Structured-Data-Backlog (Current Work) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T230315

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4232/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: MichellevL_WMNL, BeatEstermann, Lydia_Pintscher, Addshore, mwilliams, 
ChristianFerrer, Susannaanas, Cparle, CBogen, Alicia_Fagerving_WMSE, 
FRomeo_WMF, Fuzheado, GFontenelle_WMF, John_Cummings, Dominicbm, Husky, 
Spinster, JeanFred, Multichill, Jarekt, valerio.bozzolan, Aklapper, 
Bugreporter, toberto, Invadibot, Surya742, maantietaja, Mohammed_Sadat_WMDE, 
Jimfhahn, Dr.uesenfieber, Nintendofan885, Akuckartz, Nandana, JKSTNK, Seddon, 
Lahi, Gq86, SandraF_WMF, GoranSMilovanovic, QZanden, LawExplorer, Mu301, 
_jensen, rosalieper, Bodhisattwa, Scott_WUaS, Izno, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T282654: Add separate 'language' param to pageterms & entityterms prop, to allow to differentiate from uselang

[matthiasmullie]

matthiasmullie closed this task as "Resolved".
matthiasmullie claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T282654

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Addshore, Lydia_Pintscher, Lucas_Werkmeister_WMDE, matthiasmullie, 
Aklapper, toberto, Invadibot, maantietaja, CBogen, Akuckartz, Nandana, Seddon, 
Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T285969: Upload wizard structured data on Commons does not allow to enter values for statements

[matthiasmullie]

matthiasmullie closed this task as a duplicate of T285579: Add data 
step of Upload Wizard broken.

TASK DETAIL
  https://phabricator.wikimedia.org/T285969

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Geertivp, Aklapper, Invadibot, GFontenelle_WMF, maantietaja, FRomeo_WMF, 
CBogen, Nintendofan885, Akuckartz, Nandana, JKSTNK, Lahi, Gq86, E1presidente, 
Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, 
Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, 
Scott_WUaS, Susannaanas, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, 
Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T282654: Add separate 'language' param to pageterms & entityterms prop, to allow to differentiate from uselang

[matthiasmullie]

matthiasmullie added a comment.


  In T282654#7145306 <https://phabricator.wikimedia.org/T282654#7145306>, 
@Lucas_Werkmeister_WMDE wrote:
  
  > Worth noting that a language parameter was suggested, but rejected, when 
the API module was first introduced: see 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/611282/4#message-542a6727bc575318493568cade5bd18638daee82
 and reply.
  
  That looks to have been a very soft rejection, simply because there was no 
practical usecase.
  There is one now, however, so I hope we can reconsider this!
  
  > Also, we should quickly check if “language” or “lang” as a parameter name 
is more common in other API modules.
  
  In Wikibase: ModifyTerm, QuerySearchEntities, SearchEntities & SetAliases 
already have a "language" param. None use "lang", AFAICT.
  In core: ApiQueryAllMessages, ApiQueryLangBacklinks, ApiQueryLangLinks & 
ApiSetPageLanguage have a "lang" param. None use "language", AFAICT.
  I'd say consistency with other Wikibase APIs makes most sense here?

TASK DETAIL
  https://phabricator.wikimedia.org/T282654

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Esc3300, Addshore, Lydia_Pintscher, Lucas_Werkmeister_WMDE, matthiasmullie, 
Aklapper, Biggs657, toberto, Invadibot, Lalamarie69, maantietaja, Alter-paule, 
Beast1978, CBogen, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Seddon, Lahi, 
Gq86, Af420, Ramsey-WMF, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T274252: Let getLocationAgnosticMwApi accept API options

[matthiasmullie]

matthiasmullie removed projects: Wikidata-Campsite, Wikidata.
matthiasmullie added a comment.


  Removing Wikidata tags since this ticket is no longer relevant for them, nor 
does it require any action on their part.

TASK DETAIL
  https://phabricator.wikimedia.org/T274252

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Aklapper, Alter-paule, Beast1978, CBogen, Un1tY, Hook696, 
Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, 
Ramsey-WMF, Bsandipan, Lewizho99, Maathavan, Invadibot, maantietaja, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274252: Let getLocationAgnosticMwApi accept API options

[matthiasmullie]

matthiasmullie moved this task from Blocked to Code Review on the 
Structured-Data-Backlog (Current Work) board.
matthiasmullie added a comment.


  Moving a copy of this into MediaSearch extension. This way, we are no longer 
blocked by the `wikibase/javascript-api`'s release schedule (which hasn't had a 
release in almost a year), and can lose that dependency.

TASK DETAIL
  https://phabricator.wikimedia.org/T274252

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4232/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Aklapper, Invadibot, maantietaja, Alter-paule, Beast1978, 
CBogen, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273506: [M] Sporadic “TypeError: Return value of EntityContentFactory::getTitleForId() must be an instance of Title, null returned” for Special:EntityData on Commons

[matthiasmullie]

matthiasmullie added a comment.


  Patches LGTM, but I didn't +2 the one in Wikibase repo (so that WMDE can look 
it over & approve)
  If they prefer me to +2, LMK, would be happy to.

TASK DETAIL
  https://phabricator.wikimedia.org/T273506

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Umherirrender, MarkTraceur, CBogen, Cparle, WMDE-leszek, 
Addshore, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, 
GFontenelle_WMF, maantietaja, FRomeo_WMF, Muchiri124, Alter-paule, Beast1978, 
Un1tY, Nintendofan885, Akuckartz, Hook696, darthmon_wmde, Kent7301, 
joker88john, CucyNoiD, Nandana, JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, Lahi, 
Gq86, Af420, E1presidente, Ramsey-WMF, Anooprao, SandraF_WMF, Bsandipan, 
GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Lewizho99, 
Maathavan, Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, 
Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Verdy_p, Jane023, Wikidata-bugs, 
Base, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Raymond, Steinsplitter, Mbch331, Jay8g, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273506: [M] Sporadic “TypeError: Return value of EntityContentFactory::getTitleForId() must be an instance of Title, null returned” for Special:EntityData on Commons

[matthiasmullie]

matthiasmullie added a comment.


  I suspect the correct solution within `MediaInfoHandler::getTitleForId` would 
probable be to throw an `InvalidArgumentException` in case there's no title for 
the given id (`EntityHandler::getTitleForId` is documented to throw that 
exception `if $id refers to an entity of the wrong type.`)
  
  That, and whatever code path (`EntityDataUriManager::getDocTitle`?) currently 
ends up calling it with such invalid entity id should probably be be updated to 
catch that exception (or not allow triggering it in the first place) and handle 
it more gracefully (unless that exception is already being caught, but the 
`TypeError` prevents it from getting there)

TASK DETAIL
  https://phabricator.wikimedia.org/T273506

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Umherirrender, MarkTraceur, CBogen, Cparle, WMDE-leszek, 
Addshore, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Aklapper, GFontenelle_WMF, 
FRomeo_WMF, Muchiri124, ItamarWMDE, Nintendofan885, Akuckartz, darthmon_wmde, 
Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Anooprao, SandraF_WMF, 
GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, 
Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, 
Ixocactus, Wong128hk, Verdy_p, abian, Jane023, Wikidata-bugs, Base, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, 
Steinsplitter, Mbch331, Rxy, Jay8g, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274252: Let getLocationAgnosticMwApi accept API options

[matthiasmullie]

matthiasmullie reopened this task as "Open".
matthiasmullie added a comment.


  Actually - is there a timeline for releasing the next version of this repo?
  It looks like (except for this patch) nothing has happened in this repo for 
the past 8 months, so I'm worried it'll sit around for a long time.
  If there's no plan to release this soon, that's ok - in that case MediaSearch 
can simply reimplement something like `getLocationAgnosticMwApi`.

TASK DETAIL
  https://phabricator.wikimedia.org/T274252

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Aklapper, CBogen, Akuckartz, Nandana, Lahi, Gq86, 
Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274252: Let getLocationAgnosticMwApi accept API options

[matthiasmullie]

matthiasmullie closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T274252

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Aklapper, CBogen, Akuckartz, Nandana, Lahi, Gq86, 
Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264296: [M] WikibaseMediaInfo does not support editing monolingual text in languages not supported by MediaWiki

[matthiasmullie]

matthiasmullie moved this task from Ready for Development to Code Review on the 
Structured-Data-Backlog (Current Work) board.
matthiasmullie claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T264296

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4232/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Aklapper, Lucas_Werkmeister_WMDE, GFontenelle_WMF, FRomeo_WMF, Alter-paule, 
Beast1978, CBogen, Un1tY, Nintendofan885, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, Lahi, 
PDrouin-WMF, Gq86, Af420, E1presidente, Ramsey-WMF, Cparle, Anooprao, 
SandraF_WMF, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, Tramullas, Acer, 
LawExplorer, Salgo60, Lewizho99, Maathavan, Silverfish, _jensen, rosalieper, 
Scott_WUaS, Susannaanas, Nikki, Jane023, Wikidata-bugs, Base, matthiasmullie, 
aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274252: Let getLocationAgnosticMwApi accept API options

[matthiasmullie]

matthiasmullie moved this task from Incoming to Blocked on the 
Structured-Data-Backlog (Current Work) board.
matthiasmullie added a comment.


  Above patch should suffice, but needs someone with `wikibase/javascript-api` 
repo knowledge/access to CR.

TASK DETAIL
  https://phabricator.wikimedia.org/T274252

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4232/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Aklapper, GFontenelle_WMF, Alter-paule, Beast1978, CBogen, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274252: Let getLocationAgnosticMwApi accept API options

[matthiasmullie]

matthiasmullie created this task.
matthiasmullie added projects: Wikidata-Campsite, Structured-Data-Backlog 
(Current Work).
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  This would allow passing in additional options like `{ anonymous: true }`, 
which would tell ForeignApi (and centralauth's version thereof) to not perform 
the token requests, when they're not needed.

TASK DETAIL
  https://phabricator.wikimedia.org/T274252

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Aklapper, GFontenelle_WMF, CBogen, Akuckartz, Nandana, 
Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T271105: wbeditentity response does not contain lemma data

[matthiasmullie]

matthiasmullie added a comment.


  In T271105#6782179 <https://phabricator.wikimedia.org/T271105#6782179>, 
@CBogen wrote:
  
  > @Keegan and @matthiasmullie, do you have a sense of what this would break 
on our end and/or for the community? and @Keegan do you know of any policies 
that this change would fall under?
  
  The MediaInfo UI doesn't use wbeditentity (except for some test case), but it 
could break community tools/bots. I suspect it wouldn't be too hard to reach 
out to the relevant community members to get their tools updated, if per 
@Lucas_Werkmeister_WMDE's suggestion, both variants are included in the 
response for some time.

TASK DETAIL
  https://phabricator.wikimedia.org/T271105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, matthiasmullie
Cc: Keegan, matthiasmullie, MarkTraceur, CBogen, noarave, Lydia_Pintscher, 
Jakob_WMDE, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272508: PropertyInfoSnakUrlExpander: Bad value for parameter $snak->getDataValue(): must be a DataValues\StringValue

[matthiasmullie]

matthiasmullie claimed this task.
Restricted Application added a project: wdwb-tech-focus.

TASK DETAIL
  https://phabricator.wikimedia.org/T272508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: egardner, matthiasmullie, MarkTraceur, WMDE-leszek, RhinosF1, Ladsgroup, 
Aklapper, brennen, GFontenelle_WMF, Alter-paule, Beast1978, CBogen, Un1tY, 
Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, 
Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272508: PropertyInfoSnakUrlExpander: Bad value for parameter $snak->getDataValue(): must be a DataValues\StringValue

[matthiasmullie]

matthiasmullie added a comment.


  Under normal conditions, it is not possible to submit invalid values like the 
one encountered here.
  I suspect there must've been a federation configuration issue >1y ago where 
test-commons thought it was linked to production wikidata rather than 
testwikidata, thus allowing this invalid data.
  Either way, I have a patch that should handle these kind of issues (that 
don't usually seem possible in the first place) in a more graceful way, and 
allows for fixing the invalid data.

TASK DETAIL
  https://phabricator.wikimedia.org/T272508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: egardner, matthiasmullie, MarkTraceur, WMDE-leszek, RhinosF1, Ladsgroup, 
Aklapper, brennen, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Verdy_p, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272508: PropertyInfoSnakUrlExpander: Bad value for parameter $snak->getDataValue(): must be a DataValues\StringValue

[matthiasmullie]

matthiasmullie edited projects, added Structured-Data-Backlog (Current Work); 
removed Structured-Data-Backlog.

TASK DETAIL
  https://phabricator.wikimedia.org/T272508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: egardner, matthiasmullie, MarkTraceur, WMDE-leszek, RhinosF1, Ladsgroup, 
Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272508: PropertyInfoSnakUrlExpander: Bad value for parameter $snak->getDataValue(): must be a DataValues\StringValue

[matthiasmullie]

matthiasmullie added a comment.


  I think this error is unrelated to 1.36.0-wmf.27.
  The relevant code in WikibaseMediaInfo has not been touched in months, and it 
looks like the same is true for the calls to Wikidata code.
  
  As far as I can tell, it is a valid error, because the data for that page is 
in fact invalid (and has been for months - it was last touched way back in 
November 2019)
  The error should be obviously be handled in a much nicer way. Heck, it 
probably shouldn't even be possible to add this kind of faulty data (insofar it 
still is - we should check)
  We definitely need to fix something here, but I don't think it's related to, 
or a blocker for the train.
  
  ---
  
  More details:
  The structured data for that page: 
https://test-commons.wikimedia.org/wiki/Special:EntityData/M778.json
  Property P180 <https://phabricator.wikimedia.org/P180> is present, which is 
the "depicts" property on production wikidata. Not test wikidata, which this 
instance is using.
  And property P1419 <https://phabricator.wikimedia.org/P1419> ("shape" on 
production wikidata) is a nonsensical property of type "Point in time" in test 
wikidata (https://test.wikidata.org/wiki/Property:P1419), but it is here 
combined with an `"entity-type":"item"` value.
  It looks like a structured data was added based on production wikidata 
properties & entities, which now obviously fails to render because, well, that 
data makes no sense with testwikidata data.

TASK DETAIL
  https://phabricator.wikimedia.org/T272508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: egardner, matthiasmullie, MarkTraceur, WMDE-leszek, RhinosF1, Ladsgroup, 
Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257938: License type filter for media search

[matthiasmullie]

matthiasmullie added a comment.


  In T257938#6673206 <https://phabricator.wikimedia.org/T257938#6673206>, 
@matthiasmullie wrote:
  
  > In T257938#6645737 <https://phabricator.wikimedia.org/T257938#6645737>, 
@Multichill wrote:
  >
  >> I just noticed your patch. Not sure how well this scales. Maybe put it 
somewhere in MediaWiki namespace on Commons as json in the future so it can be 
maintained by interface admins?
  >
  > That is coming soon - it will be at 
https://commons.wikimedia.org/wiki/MediaWiki:Wikibasecirrus-license-mapping
  > That page won't be used until the override in existing code is gone (which 
I plan to deploy Thursday)
  > It's the same config that was previously in code, but with the fixes you 
suggested.
  
  It'll be another week (next Thu) - patch did not get merged in time.
  By then, UI should also be out & everything in this ticket is complete.

TASK DETAIL
  https://phabricator.wikimedia.org/T257938

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle, matthiasmullie
Cc: Cparle, Nathank2, Ramsey-WMF, kaldari, JeanFred, AnneT, dcausse, 
Multichill, EBernhardson, matthiasmullie, mwilliams, Aklapper, CBogen, 
Muchiri124, Alter-paule, Beast1978, Un1tY, Nintendofan885, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, JKSTNK, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, PDrouin-WMF, Gq86, Af420, E1presidente, Anooprao, SandraF_WMF, 
Bsandipan, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, 
Lewizho99, Maathavan, Silverfish, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Jane023, 
Wikidata-bugs, Base, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257938: License type filter for media search

[matthiasmullie]

matthiasmullie added a comment.


  In T257938#6645737 <https://phabricator.wikimedia.org/T257938#6645737>, 
@Multichill wrote:
  
  > I just noticed your patch. Not sure how well this scales. Maybe put it 
somewhere in MediaWiki namespace on Commons as json in the future so it can be 
maintained by interface admins?
  
  That is coming soon - it will be at 
https://commons.wikimedia.org/wiki/MediaWiki:Wikibasecirrus-license-mapping
  That page won't be used until the override in existing code is gone (which I 
plan to deploy Thursday)
  It's the same config that was previously in code, but with the fixes you 
suggested.

TASK DETAIL
  https://phabricator.wikimedia.org/T257938

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle, matthiasmullie
Cc: Cparle, Nathank2, Ramsey-WMF, kaldari, JeanFred, AnneT, dcausse, 
Multichill, EBernhardson, matthiasmullie, mwilliams, Aklapper, CBogen, 
Muchiri124, Alter-paule, Beast1978, Un1tY, Nintendofan885, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, JKSTNK, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, PDrouin-WMF, Gq86, Af420, E1presidente, Anooprao, SandraF_WMF, 
Bsandipan, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, 
Lewizho99, Maathavan, Silverfish, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Jane023, 
Wikidata-bugs, Base, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257938: License type filter for media search

[matthiasmullie]

matthiasmullie moved this task from Code Review to Ready for Development on the 
Structured-Data-Backlog (Current Work) board.
matthiasmullie added a comment.


  Moving back to "ready for development" for remaining work:
  
  - license mapping
  - UI

TASK DETAIL
  https://phabricator.wikimedia.org/T257938

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4232/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle, matthiasmullie
Cc: Ramsey-WMF, kaldari, JeanFred, AnneT, dcausse, Multichill, EBernhardson, 
matthiasmullie, mwilliams, Aklapper, CBogen, Alter-paule, Beast1978, Un1tY, 
Nintendofan885, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Af420, 
E1presidente, Cparle, Anooprao, SandraF_WMF, Bsandipan, GoranSMilovanovic, 
QZanden, Tramullas, Acer, LawExplorer, Salgo60, Lewizho99, Maathavan, 
Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, 
Susannaanas, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, 
Raymond, Steinsplitter, Mbch331, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257938: License type filter for media search

[matthiasmullie]

matthiasmullie added a comment.


  The code has been merged, but the complete mapping has not yet been compiled 
(AFAIK), so I guess that list will come in handy!

TASK DETAIL
  https://phabricator.wikimedia.org/T257938

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle, matthiasmullie
Cc: Ramsey-WMF, kaldari, JeanFred, AnneT, dcausse, Multichill, EBernhardson, 
matthiasmullie, mwilliams, Aklapper, CBogen, Alter-paule, Beast1978, Un1tY, 
Nintendofan885, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Af420, 
E1presidente, Cparle, Anooprao, SandraF_WMF, Bsandipan, GoranSMilovanovic, 
QZanden, Tramullas, Acer, LawExplorer, Salgo60, Lewizho99, Maathavan, 
Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, 
Susannaanas, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, 
Raymond, Steinsplitter, Mbch331, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T237991: Changes to Structured Data on Commons should trigger page refresh

[matthiasmullie]

matthiasmullie added a comment.


  Here's a simplified example:
  
  Add `{{Sandbox/Mmullie_(WMF)/CheckIfHasStatement}}` to a file (e.g. 
https://commons.wikimedia.org/wiki/File:2019-09-16-tenerife-icod.jpg)
  That will add a category (`[[Category:No statements]]`) if there are no 
statements (see Lua at 
https://commons.wikimedia.org/wiki/Module:Sandbox/Mmullie_(WMF)/my_module), or 
remove that category once there are.
  Now try editing that file (removing all statements, adding new one) and 
you'll find that the categorylinks aren't immediately updated - not until the 
page is (null-)edited once more.
  
  In T237991#6597542 <https://phabricator.wikimedia.org/T237991#6597542>, 
@Addshore wrote:
  
  > Trying to get a view of this ticket and the issue described in the 
description without much context and I'm finding it hard to follow.
  > Would someone be able to write out some more fleshed out steps? not just 
the order but also the content that is changing where, and what exactly is the 
expected outcome of this?
  
  These are usually categories that get created via a Lua script evaluating a 
condition.
  E.g. if a file has (or lacks) a certain statement, it'll add a certain 
category for tracking purposes.
  When a property is added/removed, this prompts the script to re-evaluate and 
update categories accordingly.
  What currently ends up happening is that these pages (where the Lua script 
ends up running and is supposed to update the categorylinks for) need another 
(null) edit to reflect the change - they're always one behind.
  
  What happened is that the process of storing a new revision used to parse the 
old page once more right before the data actually ends up being stored.
  Because the data is not yet in storage at that point, things are rendered 
under the pre-save conditions (with the *old* categorylinks)
  The render itself is not necessarily a problem, but anything related to 
rendering the page might end up caching bits, which will be based off of 
outdated information.
  Later on, post-save, categorylinks etc. are updated as well based off of 
(newly) rendered content, but parts of that content may have been filled in by 
incorrect data in cache, as a result of the earlier render.
  
  There already was a patch to get rid of core's pre-save render. It resolved 
the problem on my local machine, but not on Commons.
  There are pre-save hooks in this area as well, though, so I suspect that an 
extension hooks into the process and also triggers a render.
  (I need to look into this in more detail, but I suspect `PageContentSave` is 
the one, and it's deprecated, so the remaining problem might eventually end up 
going away automatically)
  
  To replicate this on a local setup, try subscribing to `PageContentSave` and 
call `$mainContent->getParserOutput();` - that causes the same behavior we see 
on prod.

TASK DETAIL
  https://phabricator.wikimedia.org/T237991

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Keegan, Cparle, Multichill, matthiasmullie, Ramsey-WMF, 
AntiCompositeNumber, Tgr, Addshore, Jarekt, Aklapper, CBogen, Akuckartz, 
Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Anooprao, SandraF_WMF, 
GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, 
Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, 
Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, aude, El_Grafo, 
Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T237991: Changes to Structured Data on Commons should trigger page refresh

[matthiasmullie]

matthiasmullie merged tasks: T245349: wbeditentity doesnt trigger page 
update on Wikimedia Commons, T251507: [Spike] Investigate page cache not being 
purged when SD edits are made.
matthiasmullie added subscribers: Multichill, Cparle, Keegan.

TASK DETAIL
  https://phabricator.wikimedia.org/T237991

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Keegan, Cparle, Multichill, matthiasmullie, Ramsey-WMF, 
AntiCompositeNumber, Tgr, Addshore, Jarekt, Aklapper, CBogen, Akuckartz, 
Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Anooprao, SandraF_WMF, 
GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, 
Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, 
Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, aude, El_Grafo, 
Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T237991: Changes to Structured Data on Commons should trigger page refresh

[matthiasmullie]

matthiasmullie added a comment.


  There are 4 tickets about what is likely the same thing - 1 Wikidata, 3 
Commons. Since we're looking track, I'll merge the other 2 Commons-specific 
tickets into this one.
  
  Current status was already being tracked in 1 of these other tickets, but 
I'll recap here:
  
  - the patch did resolve the problem on my less complex local setup
  - it does not, however, seem to have much of an effect in production
  - I suspect that an extension subscribes to a pre-save hook 
(`PageContentSave`?) and triggers a premature render (similar to what core used 
to do)
  - I don't know what extension
  - I don't know what layer ends up being cached (I suspect one of Wikibase's 
lookups)
  - even if we know what's caching it, it probably isn't possible to circumvent 
it in this particular instance
  
  So yeah, not currently fixed, will need significant additional debugging...

TASK DETAIL
  https://phabricator.wikimedia.org/T237991

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Ramsey-WMF, AntiCompositeNumber, Tgr, Addshore, Jarekt, 
Aklapper, CBogen, Akuckartz, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, 
E1presidente, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, 
Tramullas, Acer, LawExplorer, Salgo60, Silverfish, Poyekhali, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, 
Jane023, Wikidata-bugs, Base, aude, El_Grafo, Dinoguy1000, Ricordisamoa, 
Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, 
Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T216527: [Spike] How to deal with WB replacing their JS data model?

[matthiasmullie]

matthiasmullie closed subtask T218803: [Spike] investigate how much effort 
would be involved in wrapping wikibase datamodel in an Adapter as 
Declined.

TASK DETAIL
  https://phabricator.wikimedia.org/T216527

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: CBogen, egardner, Addshore, Cparle, Aklapper, Ramsey-WMF, gerritbot, Abit, 
matthiasmullie, Jdforrester-WMF, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T216527: [Spike] How to deal with WB replacing their JS data model?

[matthiasmullie]

matthiasmullie closed this task as "Declined".
matthiasmullie added a comment.


  Not worth pursuing ATM. Let’s figure this out and reconsider options if/when 
this becomes an actual issue in the future.

TASK DETAIL
  https://phabricator.wikimedia.org/T216527

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: CBogen, egardner, Addshore, Cparle, Aklapper, Ramsey-WMF, gerritbot, Abit, 
matthiasmullie, Jdforrester-WMF, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T204264: "Depicts crawling": Add displaying/editing statements to File page

[matthiasmullie]

matthiasmullie closed subtask T216527: [Spike] How to deal with WB replacing 
their JS data model? as Declined.
Restricted Application added a project: Structured-Data-Backlog.

TASK DETAIL
  https://phabricator.wikimedia.org/T204264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle, matthiasmullie
Cc: MarkTraceur, Abit, gerritbot, Jdforrester-WMF, Ramsey-WMF, Aklapper, 
Cparle, NavinRizwi, CBogen, Akuckartz, darthmon_wmde, Edtadros, DannyS712, 
Nandana, Lahi, PDrouin-WMF, Gq86, GoranSMilovanovic, QZanden, V4switch, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, 
matthiasmullie, aude, Dinoguy1000, Fabrice_Florin, Matanya, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256617: Make link to entity/concept URI visible in left side menu for all Commons files

[matthiasmullie]

matthiasmullie moved this task from Incoming to Code Review on the 
Structured-Data-Backlog (Current Work) board.
matthiasmullie claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T256617

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4232/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: CBogen, Jheald, Aklapper, FRomeo_WMF, Spinster, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, 
Nandana, JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, Lahi, PDrouin-WMF, Gq86, 
Af420, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, Bsandipan, 
GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Lewizho99, 
Maathavan, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Jane023, 
Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Fabrice_Florin, Raymond, JeanFred, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256617: Make link to entity/concept URI visible in left side menu for all Commons files

[matthiasmullie]

matthiasmullie edited projects, added Structured-Data-Backlog (Current Work); 
removed Structured-Data-Backlog.

TASK DETAIL
  https://phabricator.wikimedia.org/T256617

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: CBogen, Jheald, Aklapper, FRomeo_WMF, Spinster, Akuckartz, darthmon_wmde, 
Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, 
Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, 
LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, 
Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Fabrice_Florin, Raymond, JeanFred, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T173339: Categories tracking pages with wikidata links are not updated when items on Wikidata are modified

[matthiasmullie]

matthiasmullie added a comment.


  I believe that https://gerrit.wikimedia.org/r/602053 should fix this (and a 
couple of related issues), but it needs review. Anyone? :)

TASK DETAIL
  https://phabricator.wikimedia.org/T173339

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Cparle, Marsupium, Liuxinyu970226, Bawolff, daniel, aaron, 
Mike_Peel, zhuyifei1999, Lea_Lacroix_WMDE, Lydia_Pintscher, Yann, Agabi10, 
thiemowmde, Aklapper, Jarekt, PokestarFan, Alter-paule, Beast1978, CBogen, 
Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Ixocactus, 
Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Steinsplitter, Mbch331, 
Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Claimed] T256933: Alter the look of SDC GUI to hide input fields for properties which are not beeing edited

[matthiasmullie]

matthiasmullie claimed this task.
matthiasmullie edited projects, added Structured-Data-Backlog (Current Work); 
removed Structured-Data-Backlog.

TASK DETAIL
  https://phabricator.wikimedia.org/T256933

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: ChristianFerrer, Aklapper, Jarekt, Alter-paule, Beast1978, CBogen, Un1tY, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, JKSTNK, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Af420, E1presidente, 
Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, Bsandipan, GoranSMilovanovic, 
QZanden, Tramullas, Acer, LawExplorer, Salgo60, Lewizho99, Maathavan, 
Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Jane023, 
Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T255601: MediaInfo UI breaks when repoDatabase set to "testcommonswiki" instead of false

[matthiasmullie]

matthiasmullie closed this task as "Resolved".
matthiasmullie claimed this task.
matthiasmullie added a comment.


  I redeployed the config patch 
(https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/605645) and 
this issue no longer seems present, so closing the ticket.
  Please reopen if it does occur again so we can investigate more.

TASK DETAIL
  https://phabricator.wikimedia.org/T255601

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, WMDE-leszek, Cparle, Aklapper, Addshore, CBogen, 
darthmon_wmde, Nandana, JKSTNK, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unblock] T254315: entitysources: Directly create entitySources config for WMF production wikis

[matthiasmullie]

matthiasmullie closed subtask T255601: MediaInfo UI breaks when repoDatabase 
set to testcommonswiki instead of false as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T254315

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore, matthiasmullie
Cc: Addshore, Aklapper, WMDE-leszek, Alter-paule, Beast1978, CBogen, Un1tY, 
Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T249556: Structured Data interface does not work on IE11

[matthiasmullie]

matthiasmullie closed this task as "Resolved".
matthiasmullie added a comment.


  Things work & look fine now on my IE machine!

TASK DETAIL
  https://phabricator.wikimedia.org/T249556

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Etonkovidova, matthiasmullie, Ramsey-WMF, LucasWerkmeister, Nikki, 
Aklapper, CBogen, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, 
E1presidente, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, 
Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, 
Scott_WUaS, Susannaanas, Jane023, Wikidata-bugs, Base, aude, Ricordisamoa, 
Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T255601: MediaInfo UI breaks when repoDatabase set to "testcommonswiki" instead of false

[matthiasmullie]

matthiasmullie added a comment.


  I can't reproduce locally ATM.
  Where did you get those errors? Test runs? In browser? On every page view or 
when editing structured data?

TASK DETAIL
  https://phabricator.wikimedia.org/T255601

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, WMDE-leszek, Cparle, Aklapper, Addshore, CBogen, 
darthmon_wmde, Nandana, JKSTNK, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T244207: Revision 386521405 belongs to M43864745 instead of expected M79277318

[matthiasmullie]

matthiasmullie closed this task as "Resolved".
matthiasmullie added a comment.


  Tested in prod 
(https://commons.wikimedia.org/wiki/File:2019-09-18-tenerife-teide-trees.jpg & 
https://commons.wikimedia.org/wiki/File:2019-09-18-tenerife-teide-trees-mv.jpg) 
and seems to work.

TASK DETAIL
  https://phabricator.wikimedia.org/T244207

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: thiemowmde, Cparle, matthiasmullie, Aklapper, Addshore, Blissjay007, 
Oblanco79, Alter-paule, Beast1978, CBogen, Un1tY, Hook696, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Ixocactus, 
Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T249556: Structured Data interface does not work on IE11

[matthiasmullie]

matthiasmullie added a comment.


  It looks like all JS errors in IE have now been resolved.
  There's still display issues, but I've just submitted a patch that should 
also resolve those.

TASK DETAIL
  https://phabricator.wikimedia.org/T249556

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Etonkovidova, matthiasmullie, Ramsey-WMF, LucasWerkmeister, Nikki, 
Aklapper, Blissjay007, Oblanco79, Alter-paule, Beast1978, CBogen, Un1tY, 
Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, 
Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, JKSTNK, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, 
PDrouin-WMF, Gq86, Af420, E1presidente, Cparle, Darkminds3113, Anooprao, 
SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Salgo60, WSH1906, 
Lewizho99, Maathavan, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, 
Jane023, Wikidata-bugs, Base, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T238484: Entities returned by mw.wikibase.getEntity lua function differ based on language of the viewer

[matthiasmullie]

matthiasmullie added a comment.


  So, does anyone know whether this is a feature or a bug? This behavior 
appears to be intentional and not causing any trouble when testing whether or 
not languages match, in which case I believe we can close this ticket?

TASK DETAIL
  https://phabricator.wikimedia.org/T238484

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: WMDE-leszek, darthmon_wmde, nettrom_WMF, matthiasmullie, Marsupium, Jarekt, 
Aklapper, CBogen, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, 
Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, 
Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, 
Scott_WUaS, Susannaanas, Jane023, Wikidata-bugs, Base, aude, Ricordisamoa, 
Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Claimed] T249556: Structured Data interface does not work on IE11

[matthiasmullie]

matthiasmullie claimed this task.
matthiasmullie added a project: Structured-Data-Backlog (Current Work).

TASK DETAIL
  https://phabricator.wikimedia.org/T249556

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: LucasWerkmeister, Nikki, Aklapper, Oblanco79, Alter-paule, Beast1978, 
CBogen, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, 
Kent7301, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, JKSTNK, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, PDrouin-WMF, Gq86, Af420, E1presidente, Ramsey-WMF, Cparle, 
Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, 
Salgo60, WSH1906, Lewizho99, Maathavan, Silverfish, _jensen, rosalieper, 
Scott_WUaS, Susannaanas, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, 
Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Project Column] T238484: Entities returned by mw.wikibase.getEntity lua function differ based on language of the viewer

[matthiasmullie]

matthiasmullie moved this task from Ready for Estimation to Blocked on the 
Structured-Data-Backlog (Current Work) board.
matthiasmullie added a comment.


  Apologies it took awhile to get back to this! Unfortunately, this has not 
resolved itself over time :)
  
  This is not MediaInfo/Commons-specific, this also happens on Wikidata in a 
similar scenario. Easiest way to check: run below line on the Lua debug console 
(e.g. on https://www.wikidata.org/w/index.php?title=Module:Sandbox=edit) 
with your language set to anything other than English (`uselang` won't work, 
though - actually change your display language)
  `mw.logObject( mw.wikibase.getEntity( 'Q6267810' ) )`
  
  You'll find that the output includes this:
  
["labels"] = table#10 {
  metatable = table#11
  ["en"] = table#12 {
["language"] = "en",
["value"] = "Johnny Turbo",
  },
  ["pl"] = table#12 {
["language"] = "en",
["value"] = "Johnny Turbo",
  },
},
  
  There is a `pl` entry (or whatever non-English language you selected), even 
though the entity <https://www.wikidata.org/wiki/Q6267810> doesn't have a label 
in that language.
  
  This happens inside `ClientEntitySerializer:serialize()`: the original entity 
`$serialization` is just fine, but it looks like the fallback chain handling 
then adds the other (`pl` in this case) entry.
  Looking at the code, this is probably intentional behavior, and one could 
verify languages with the `language` key included for each label entry.
  I'm not 100% certain it should be like this, though - i.e. it also seems to 
affect `wbc_entity_usage` results (T238484#5738295 
<https://phabricator.wikimedia.org/T238484#5738295>).
  
  I'll defer to Wikidata team about what (if anything) should happen here.

TASK DETAIL
  https://phabricator.wikimedia.org/T238484

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4232/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: nettrom_WMF, matthiasmullie, Marsupium, Jarekt, Aklapper, CBogen, 
darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, 
Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, 
Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, 
Scott_WUaS, Susannaanas, Jane023, Wikidata-bugs, Base, aude, Ricordisamoa, 
Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Retitled] T238484: Entities returned by mw.wikibase.getEntity lua function differ based on language of the viewer

[matthiasmullie]

matthiasmullie renamed this task from "Structured Data on Commons entities 
returned by mw.wikibase.getEntity lua function differ based on language of the 
viewer" to "Entities returned by mw.wikibase.getEntity lua function differ 
based on language of the viewer".

TASK DETAIL
  https://phabricator.wikimedia.org/T238484

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: nettrom_WMF, matthiasmullie, Marsupium, Jarekt, Aklapper, CBogen, 
darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, 
Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, 
Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, 
Scott_WUaS, Susannaanas, Jane023, Wikidata-bugs, Base, aude, Ricordisamoa, 
Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T241338: Allow linking to specific statements in Structured data on Commons

[matthiasmullie]

matthiasmullie edited projects, added Structured-Data-Backlog (Current Work); 
removed Structured-Data-Backlog.

TASK DETAIL
  https://phabricator.wikimedia.org/T241338

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Tacsipacsi, Salgo60, Ramsey-WMF, Cparle, matthiasmullie, Multichill, 
dcausse, Jarekt, Aklapper, Alter-paule, Beast1978, CBogen, Un1tY, Hook696, 
Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, JKSTNK, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, 
Af420, E1presidente, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, 
Acer, LawExplorer, WSH1906, Lewizho99, Maathavan, Silverfish, Poyekhali, 
_jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, 
Wong128hk, Jane023, Wikidata-bugs, Base, aude, El_Grafo, Dinoguy1000, 
Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, 
Jdforrester-WMF, Steinsplitter, Mbch331, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Merged] T246918: Wrong element selected when choosing from search results

[matthiasmullie]

matthiasmullie merged a task: T247118: An attempt to add structure data on 
Commons results in a wrong item.
matthiasmullie added subscribers: Ymblanter, matthiasmullie, Jarekt, Cparle, 
Ramsey-WMF, TheDJ, Multichill.

TASK DETAIL
  https://phabricator.wikimedia.org/T246918

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Multichill, TheDJ, Ramsey-WMF, Cparle, Jarekt, matthiasmullie, Ymblanter, 
Aklapper, 1234qwer1234qwer4, CBogen, JKSTNK, Lahi, PDrouin-WMF, E1presidente, 
Anooprao, SandraF_WMF, Tramullas, Acer, Salgo60, Silverfish, Susannaanas, 
Jane023, Wikidata-bugs, Base, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Fabrice_Florin, Raymond, Steinsplitter
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247118: An attempt to add structure data on Commons results in a wrong item

[matthiasmullie]

matthiasmullie added a comment.


  Yes, this is the same as T246918 <https://phabricator.wikimedia.org/T246918> 
and should be fixed on next deployment (Wed)

TASK DETAIL
  https://phabricator.wikimedia.org/T247118

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Jarekt, matthiasmullie, Cparle, Ramsey-WMF, TheDJ, Multichill, Aklapper, 
Ymblanter, CBogen, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, 
E1presidente, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, 
Acer, LawExplorer, Salgo60, Silverfish, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Jane023, 
Wikidata-bugs, Base, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Fabrice_Florin, Raymond, Jdforrester-WMF, Steinsplitter, 
Mbch331, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T247118: An attempt to add structure data on Commons results in a wrong item

[matthiasmullie]

matthiasmullie closed this task as a duplicate of T246918: Wrong element 
selected when choosing from search results.

TASK DETAIL
  https://phabricator.wikimedia.org/T247118

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Jarekt, matthiasmullie, Cparle, Ramsey-WMF, TheDJ, Multichill, Aklapper, 
Ymblanter, CBogen, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, 
E1presidente, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, 
Acer, LawExplorer, Salgo60, Silverfish, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Jane023, 
Wikidata-bugs, Base, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Fabrice_Florin, Raymond, Jdforrester-WMF, Steinsplitter, 
Mbch331, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Claimed] T246918: Wrong element selected when choosing from search results

[matthiasmullie]

matthiasmullie claimed this task.
matthiasmullie edited projects, added Structured-Data-Backlog (Current Work); 
removed Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T246918

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Aklapper, 1234qwer1234qwer4, Beast1978, CBogen, Un1tY, Hook696, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, Meekrab2012, joker88john, CucyNoiD, NebulousIris, 
JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, PDrouin-WMF, Af420, E1presidente, Ramsey-WMF, Cparle, 
Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, Tramullas, Acer, Salgo60, WSH1906, Lewizho99, Maathavan, 
Silverfish, Susannaanas, Jane023, Wikidata-bugs, Base, matthiasmullie, 
Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, 
Steinsplitter, darthmon_wmde, Nandana, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T241338: Allow linking to specific statements in Structured data on Commons

[matthiasmullie]

matthiasmullie added a comment.


  Correct: we can't rely on default browser behaviour of scrolling to anchors, 
because the content is hidden.
  But we can implement a similar behavior on our own.
  
  @Jarekt would you want to link to the specific statement (i.e. 
`File:Something.jpg#M63$b81f5051-4288-a4d9-cc31-ba8b200b5e0e` - the statement's 
GUID), or just the property level (i.e. `File:Something.jpg#P180` or something 
similar)

TASK DETAIL
  https://phabricator.wikimedia.org/T241338

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Ramsey-WMF, Cparle, matthiasmullie, Multichill, dcausse, Jarekt, Aklapper, 
CBogen, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, 
Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, 
LawExplorer, Salgo60, Silverfish, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Jane023, 
Wikidata-bugs, Base, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Fabrice_Florin, Raymond, Jdforrester-WMF, Steinsplitter, 
Mbch331, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T239474: [M] Units support for quantity datatype

[matthiasmullie]

matthiasmullie added a comment.


  In T239474#5845899 <https://phabricator.wikimedia.org/T239474#5845899>, 
@Multichill wrote:
  
  > If we're building a new interface, can you make it a bit smarter so it 
actually suggests a relevant unit? If I'm adding things like height and width, 
I probably want something like cm (not Cameroon) and when I add heading I 
probably want degree. Now I just get everything .
  
  I like the idea, but it's going to be a bit of a pain to figure out how to 
best go about this (can't hardcode specific items into the code)
  Wikidata has a bazillion config vars to reference specific items, I guess we 
could go with something similar here.
  Either way, I filed T244856 <https://phabricator.wikimedia.org/T244856> - 
it's outside this task's scope :)

TASK DETAIL
  https://phabricator.wikimedia.org/T239474

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Jarekt, Addshore, Ramsey-WMF, Aklapper, egardner, PDrouin-WMF, Multichill, 
matthiasmullie, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Abit, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T239474: [M] Units support for quantity datatype

[matthiasmullie]

matthiasmullie added a comment.


  Design update: see F31552245 <https://phabricator.wikimedia.org/F31552245>

TASK DETAIL
  https://phabricator.wikimedia.org/T239474

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Jarekt, Addshore, Ramsey-WMF, Aklapper, egardner, PDrouin-WMF, Multichill, 
matthiasmullie, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Abit, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Claimed] T244207: Revision 386521405 belongs to M43864745 instead of expected M79277318

[matthiasmullie]

matthiasmullie claimed this task.
matthiasmullie added a comment.


  This is similar to T231276 <https://phabricator.wikimedia.org/T231276>.
  
  This basically happens when a page's history gets split 
(https://commons.wikimedia.org/wiki/Commons:History_merging_and_splitting#History_splitting)
  In this case: https://commons.wikimedia.org/?curid=79277318 & 
https://commons.wikimedia.org/?curid=43864745
  
  The original page (and its slots) gets deleted.
  It gets restored (along with the relevant slots) & moved somewhere in the 
middle of the history.
  The rest of history (along with the relevant slots) gets restored.
  And we now have 2 pages with MediaInfo slots pointing to 1 original source...

TASK DETAIL
  https://phabricator.wikimedia.org/T244207

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Aklapper, Addshore, darthmon_wmde, Nandana, Lahi, Gq86, 
Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, Ixocactus, Wong128hk, Wikidata-bugs, 
aude, El_Grafo, Dinoguy1000, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, 
Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T239474: [M] Units support for quantity datatype

[matthiasmullie]

matthiasmullie added a comment.


  Actual (backend) support for other entities has already been merged.
  Patch to bring support to the frontend is in code review.
  
  Here's what that'll look like - pretty much the exact same as Wikidata & 
support for time inputs.
  
  Empty:
  
  F31546127: Screenshot 2020-02-03 17.10.30.png 
<https://phabricator.wikimedia.org/F31546127>
  
  Once it receives input, the customization panel pops out:
  
  F31546129: Screenshot 2020-02-03 17.10.36.png 
<https://phabricator.wikimedia.org/F31546129>
  
  Where units can be searched:
  
  F31546131: Screenshot 2020-02-03 17.10.53.png 
<https://phabricator.wikimedia.org/F31546131>
  
  And are eventually rendered with units:
  
  F31546133: Screenshot 2020-02-03 17.11.01.png 
<https://phabricator.wikimedia.org/F31546133>
  
  ---
  
  And pretty much the exact same for qualifiers:
  
  F31546135: Screenshot 2020-02-03 17.11.19.png 
<https://phabricator.wikimedia.org/F31546135>

TASK DETAIL
  https://phabricator.wikimedia.org/T239474

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Jarekt, Addshore, Ramsey-WMF, Aklapper, egardner, PDrouin-WMF, Multichill, 
matthiasmullie, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, AramBakir, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Abit, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Claimed] T239474: [M] Units support for quantity datatype

[matthiasmullie]

matthiasmullie claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T239474

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Jarekt, Addshore, Ramsey-WMF, Aklapper, egardner, PDrouin-WMF, Multichill, 
matthiasmullie, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, AramBakir, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Abit, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unblock] T239163: Inform users about constraint violation

[matthiasmullie]

matthiasmullie closed subtask T239939: [S] Deploy WikibaseQualityConstraints to 
beta commons as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T239163

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Jheald, Lucas_Werkmeister_WMDE, WMDE-leszek, Aklapper, PDrouin-WMF, 
Multichill, egardner, darthmon_wmde, Nandana, Lahi, Gq86, Ramsey-WMF, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Abit, 
Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T239939: [S] Deploy WikibaseQualityConstraints to beta commons

[matthiasmullie]

matthiasmullie closed this task as "Resolved".
matthiasmullie added a comment.


  This is now on betacommons: 
https://commons.wikimedia.beta.wmflabs.org/wiki/Special:Version

TASK DETAIL
  https://phabricator.wikimedia.org/T239939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: egardner, Multichill, PDrouin-WMF, Aklapper, WMDE-leszek, Cparle, 
darthmon_wmde, Nandana, Lahi, Gq86, Ramsey-WMF, Lucas_Werkmeister_WMDE, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Abit, abian, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Claimed] T242331: Input field not cleared after selecting an entry

[matthiasmullie]

matthiasmullie claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T242331

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Aklapper, Raymond, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, 
E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, 
Jayprakash12345, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, 
_jensen, rosalieper, Scott_WUaS, Susannaanas, Wong128hk, Jane023, 
Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Fabrice_Florin, Jdforrester-WMF, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T237107: Extend mw.wikibase lua functions to allow accessing Structured Data on Commons items

[matthiasmullie]

matthiasmullie closed this task as "Resolved".
matthiasmullie added a comment.


  As far as I can tell, all (relevant) methods where a MediaInfo implementation 
was missing now work.
  
  And since it's now possible to resolve page titles to MediaInfo ids (with 
functional `mw.wikibase.getEntity()`, `mw.wikibase.getEntityUrl()`, 
`mw.wikibase.getEntityIdForCurrentPage()` and their `mw.wikibase.mediainfo.*` 
counterparts), we now also no longer need to use hacks like `"M" .. 
mw.title.getCurrentTitle().id` in Lua.
  
  I believe all work in this ticket is now complete.

TASK DETAIL
  https://phabricator.wikimedia.org/T237107

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Multichill, Addshore, matthiasmullie, Njardarlogar, Aklapper, Jarekt, 
darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, 
Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, 
Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, 
Scott_WUaS, Susannaanas, Jane023, Wikidata-bugs, Base, aude, Ricordisamoa, 
Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Jdforrester-WMF, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T237107: Extend mw.wikibase lua functions to allow accessing Structured Data on Commons items

[matthiasmullie]

matthiasmullie merged a task: T236691: Implement alternative `SiteLinkLookup` 
for MediaInfo entities.
matthiasmullie added subscribers: matthiasmullie, Addshore, Multichill.

TASK DETAIL
  https://phabricator.wikimedia.org/T237107

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Multichill, Addshore, matthiasmullie, Njardarlogar, Aklapper, Jarekt, 
darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, 
Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, 
Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, 
Scott_WUaS, Susannaanas, Jane023, Wikidata-bugs, Base, aude, Ricordisamoa, 
Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Jdforrester-WMF, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T239165: PHP Warning: count(): Parameter must be an array or an object that implements Countable in WikibaseMediaInfo

[matthiasmullie]

matthiasmullie closed this task as "Resolved".
matthiasmullie claimed this task.
matthiasmullie added a comment.


  No longer present in recent error logs.

TASK DETAIL
  https://phabricator.wikimedia.org/T239165

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Cparle, Aklapper, brennen, darthmon_wmde, Nandana, Lahi, 
Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Jdforrester-WMF, 
Mbch331, Rxy, Jay8g, Krenair, jeremyb
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T240563: broken Lua's mw.wikibase.entity:getSitelink function

[matthiasmullie]

matthiasmullie added a project: Structured-Data-Backlog (Current Work).
matthiasmullie closed this task as "Resolved".
matthiasmullie claimed this task.
matthiasmullie added a comment.


  Fix got deployed - I believe this is done, but please do re-open the ticket 
should you still discover issues!

TASK DETAIL
  https://phabricator.wikimedia.org/T240563

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Keegan, Multichill, Jarekt, Lucas_Werkmeister_WMDE, matthiasmullie, 
Aklapper, Lea_Lacroix_WMDE, Liuxinyu970226, Hook696, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, 
Nandana, NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

[matthiasmullie]

matthiasmullie added a comment.


  > Can we just keep `getSitelink` method, and make it return //nil// when 
applied to MediaInfo entities?
  
  Yes - bringing it back as a no-op (for now at least)
  
  > The difference between the two files is that the first one has SDC 
statements and labels and the second one does not. So it seems like only files 
with SDC statements are affected by this issue.
  
  Yes, it appears that as soon as a MediaInfo entity gets created, the code to 
delete `getSitelink` gets run and has the unfortunate side-effect from deleting 
it in the parent metatable as well...

TASK DETAIL
  https://phabricator.wikimedia.org/T240563

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Keegan, Multichill, Jarekt, Lucas_Werkmeister_WMDE, matthiasmullie, 
Aklapper, Lea_Lacroix_WMDE, Liuxinyu970226, Hook696, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, 
Nandana, NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, 
Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T240839: Make DataAccessSnakFormatterOutputFormatTest more robust

[matthiasmullie]

matthiasmullie created this task.
matthiasmullie added a project: Wikidata-Campsite.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  It appears that DataAccessSnakFormatterOutputFormatTest can fail in certain 
circumstances.
  When certain code is run before this test is, the tests suddenly start to 
fail.
  
  Apparently, even though a new 'reset' client 
(`WikibaseClient::getDefaultInstance( 'reset' )`) is constructed, it doesn't 
appear that the client is completely reset & some code still sticks around.
  The tests can be made to fail by adding this to `setUp`:
  

WikibaseClient::getDefaultInstance()->getDataAccessSnakFormatterFactory()->newWikitextSnakFormatter(
 Language::factory( 'en' ), new HashUsageAccumulator() );
  
  More details can be found on this patchset, in Lucas' notes on PS9: 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/556981/9

TASK DETAIL
  https://phabricator.wikimedia.org/T240839

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

[matthiasmullie]

matthiasmullie added a comment.


  I believe that whatever I ended up doing to remove the `getSitelink` method 
from MediaInfo entities, accidentally took it away from the parent class as 
well. Am looking into it!

TASK DETAIL
  https://phabricator.wikimedia.org/T240563

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Jarekt, Lucas_Werkmeister_WMDE, matthiasmullie, Aklapper, Lea_Lacroix_WMDE, 
Liuxinyu970226, darthmon_wmde, DannyS712, Nandana, JKSTNK, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

[matthiasmullie]

matthiasmullie added a comment.


  Yes, it looks like the removal of `getSitelink` for MediaInfo entities 
probably caused this.
  There's already a discussion about this on the module's talk page: 
https://commons.wikimedia.org/wiki/Module_talk:Wikidata_label#Lua_error_in_Module:Wikidata_label_at_line_24:_attempt_to_call_method_'getSitelink'_(a_nil_value).

TASK DETAIL
  https://phabricator.wikimedia.org/T240563

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Lucas_Werkmeister_WMDE, matthiasmullie, Aklapper, Lea_Lacroix_WMDE, 
Liuxinyu970226, darthmon_wmde, DannyS712, Nandana, JKSTNK, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T239565: Create reportupdater reports that execute SDC requests

[matthiasmullie]

matthiasmullie added a comment.


  No it shouldn’t count pages more than once.
  UNION omits duplicates (UNION ALL doesn’t), so no need to DISTINCT again.

TASK DETAIL
  https://phabricator.wikimedia.org/T239565

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Milimetric, matthiasmullie
Cc: Abit, Ramsey-WMF, kzimmerman, Addshore, matthiasmullie, gsingers, 
Mayakp.wiki, Ladsgroup, nettrom_WMF, Cparle, Nuria, Milimetric, mpopov, 
4748kitoko, darthmon_wmde, DannyS712, Nandana, JKSTNK, Akovalyov, Lahi, 
PDrouin-WMF, Gq86, E1presidente, Anooprao, SandraF_WMF, GoranSMilovanovic, 
QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, 
rosalieper, Scott_WUaS, Susannaanas, JAllemandou, Jane023, terrrydactyl, 
Wikidata-bugs, Base, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Fabrice_Florin, Raymond, Steinsplitter, Mbch331, jeremyb
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T239565: Create reportupdater reports that execute SDC requests

[matthiasmullie]

matthiasmullie added a comment.


  I'm not really sure what number we want to go with, but I can probably help 
clarify what kind of data is in which db tables (and what numbers derived from 
those actually mean)
  
  So, it seems we have 2 completely separate definitions of "structured data":
  
  1. MediaInfo entities created for file pages, with captions and/or statements
  2. Existing "entities" (Wikidata or MediaInfo) pulled in via Lua to enrich 
(file) pages (e.g. given that we know the artwork, we can pull in author 
information etc.)
  
  And possibly, since IMO both are a valid definition of "structured data":
  
  3. A combination of both: files with either a MediaInfo entity and/or other 
(Wikidata/MediaInfo) entities' information included via Lua
  
  **1. MediaInfo entities created for file pages, with captions and/or 
statements: 3 082 976**
  
  We can query for it by counting the amount of 'mediainfo' slots & excluding 
deleted pages & empty content:
  
SELECT COUNT(DISTINCT page_id)
# page excludes deleted pages (which are in archive)
FROM page
# joining on page_latest - we only care about most recent
INNER JOIN slots ON slot_revision_id = page_latest
# mediainfo slot must contain actual content
INNER JOIN content ON slot_content_id = content_id AND content_size > 122
INNER JOIN slot_roles ON role_id = slot_role_id AND role_name = 'mediainfo';
  
  //AFAICT, there is no easy way to break up stats about MediaInfo entities 
more (e.g. "how many have only captions", "how many have X number of 
statements", ...) - not with a simple query on the raw data anyway.
  The entity's actual data is in external store (just like any other wikitext 
page's content) in the form of a JSON blob (so would have to be deserialized)//
  
  **2. Existing "entities" (Wikidata or MediaInfo) pulled in via Lua to enrich 
file pages: 7 936 829**
  
  That data lives in `wbc_entity_usage`, which is a table much like 
`categorylinks` and `templatelinks`.
  It does not contain all existing entities (and their labels etc), it's just a 
place to store the relationship of entities and other pages these entities are 
used on (via Lua)
  See T231952#5717638 <https://phabricator.wikimedia.org/T231952#5717638> & 
Wikibase/Schema/wbc_entity_usage on mw.org 
<https://www.mediawiki.org/wiki/Wikibase/Schema/wbc_entity_usage> for more 
details on this table and what data is holds.
  
  Something like this should give us the total amount of file pages that are 
including Wikidata/MediaInfo data via Lua (overwhelming majority is Wikidata 
entities - it's not been possible to fetch MediaInfo entities via Lua until a 
month ago)
  
SELECT COUNT(DISTINCT page_id)
# page excludes deleted pages (which are in archive)
FROM page
INNER JOIN wbc_entity_usage ON eu_page_id = page_id
# only include file pages and non-sitelink usage
WHERE page_namespace = 6 AND eu_aspect != 'S';
  
  Note that we might want to exclude Wikibase sitelinks usage 
<https://www.wikidata.org/wiki/Help:Sitelinks> (recorded in this table with 
eu_aspect = 'S').
  While it's useful linking of data, I'm not these should be considered 
"structured data" usage.
  Anyway, their usage is negligible anyway: excluding those (`eu_aspect != 
'S'`) returns a result of **7 935 849** (or only 980 files that *only* have a 
wikidata sitelink)
  
  //It is somewhat possible to break down stats further (e.g. how many are 
including a label vs how many are including statements), but not in too much 
detail (e.g. `L` would be unreliable to figure out how much it's used 
in a particular language, because that language could also be covered by `L`//
  
  //FYI: there are about ~3M more (non-file) pages with structured data via 
Lua, mostly category pages.//
  
  **3. A combination of both: 10 440 129**
  
  This is pretty much just a combination of the above numbers, except that 
there is some overlap: entities could have MediaInfo entities as well as other 
data from Wikidata (and having MediaInfo entities is likely going to make it 
easier to fetch other related info, so I'd expect overlap to grow over time)
  Currently, there’s an overlap of (only) ~0.58M files (that have both an own 
MediaInfo entity, and existing Wikidata/MediaInfo usage via Lua)
  
  A simple union for both of the above queries should get us that data:
  
SELECT COUNT(*) FROM (
SELECT DISTINCT page_id
FROM page
INNER JOIN slots ON slot_revision_id = page_latest
INNER JOIN content ON slot_content_id = content_id AND content_size > 
122
INNER JOIN slot_roles ON role_id = slot_role_id AND role_name = 
'mediainfo'
UNION
SELECT DISTINCT page_id
FROM page
INNER JOIN wbc_entity_usage ON eu_page_id = page_id
WHERE page_namespace = 6
) AS t;

TASK DETAIL
  https://phabricator.wi

[Wikidata-bugs] [Maniphest] [Updated] T238878: Data about how many file pages on Commons contain at least one structured data element

[matthiasmullie]

matthiasmullie added a comment.


  > Ping @matthiasmullie to asses this info
  
  That is correct, except for 1 little detail:
  
  wbc_entity_usage will have some mediainfo entities, in cases where a file 
page uses another (or its own) mediainfo entity via Lua.
  wbc_entity_usage simply records relationships between pages and entities - 
that could be wikidata or mediainfo (theoretically even lexeme) entities (but 
by and large, it's currently wikidata entities being pulled in via Lua)
  
  T231952#5717638 <https://phabricator.wikimedia.org/T231952#5717638>

TASK DETAIL
  https://phabricator.wikimedia.org/T238878

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Milimetric, Cparle, nettrom_WMF, Ladsgroup, daniel, Mayakp.wiki, gsingers, 
matthiasmullie, Addshore, kzimmerman, mpopov, Ramsey-WMF, Abit, Nuria, 
4748kitoko, darthmon_wmde, DannyS712, Nandana, JKSTNK, Akovalyov, Lahi, 
PDrouin-WMF, Gq86, E1presidente, Anooprao, SandraF_WMF, GoranSMilovanovic, 
QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, 
rosalieper, Scott_WUaS, Susannaanas, JAllemandou, Jane023, terrrydactyl, 
Wikidata-bugs, Base, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Fabrice_Florin, Raymond, Steinsplitter, Mbch331, jeremyb
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208517: Should Wikibase add a property to the page response object that indicates the embedded entities?

[matthiasmullie]

matthiasmullie added a comment.


  Alternatively, this API endpoint already includes the entity id: 
https://commons.wikimedia.beta.wmflabs.org/w/api.php?action=wbgetentities=commonswiki=File:Redsq.png

TASK DETAIL
  https://phabricator.wikimedia.org/T208517

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Anomie, Abbe98, Aklapper, dbarratt, darthmon_wmde, 
WDoranWMF, DannyS712, Nandana, JKSTNK, Amorymeltzer, Lahi, PDrouin-WMF, Gq86, 
E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, 
QZanden, Tramullas, Acer, LawExplorer, Sethakill, Salgo60, Silverfish, dg711, 
_jensen, rosalieper, Scott_WUaS, Susannaanas, Jane023, Wikidata-bugs, Base, 
aude, jayvdb, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, 
Steinsplitter, Mbch331, Rxy, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T238484: Structured Data on Commons entities returned by mw.wikibase.getEntity lua function differ based on language of the viewer

[matthiasmullie]

matthiasmullie added a project: Structured-Data-Backlog (Current Work).

TASK DETAIL
  https://phabricator.wikimedia.org/T238484

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Marsupium, Jarekt, Aklapper, darthmon_wmde, DannyS712, 
Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, 
Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, 
LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, 
Jane023, Wikidata-bugs, Base, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T238484: Structured Data on Commons entities returned by mw.wikibase.getEntity lua function differ based on language of the viewer

[matthiasmullie]

matthiasmullie added a comment.


  I am able to reproduce this on Commons, but not with my local setup.
  There are a few other related patches coming up soon-ish, and I'll pick this 
back up once those are settled.

TASK DETAIL
  https://phabricator.wikimedia.org/T238484

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Marsupium, Jarekt, Aklapper, darthmon_wmde, DannyS712, 
Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, 
Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, 
LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, 
Jane023, Wikidata-bugs, Base, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T238878: Data about how many file pages on Commons contain at least one structured data element

[matthiasmullie]

matthiasmullie added a comment.


  > If you want to count //pages//, then you are only looking at the current 
revision, right? And the current revision of a page is by definition never 
deleted/suppressed. So no need to check rev_deleted.
  
  So page_latest can never point to a revdel'ed revision? Ok cool, had no idea 
- might as well skip that condition (and the entire join with revision table) 
then if it's already implicitly so:
  
SELECT COUNT(DISTINCT page_id)
# page excludes deleted pages (which are in archive)
FROM page
# joining on page_latest - we only care about most recent
INNER JOIN slots ON slot_revision_id = page_latest
# mediainfo slot must contain actual content
INNER JOIN content ON slot_content_id = content_id AND content_size > 122
INNER JOIN slot_roles ON role_id = slot_role_id AND role_name = 'mediainfo';
  
  
  
+-+
| COUNT(DISTINCT page_id) |
+-+
| 3045691 |
+-+
1 row in set (7 min 23.17 sec)

TASK DETAIL
  https://phabricator.wikimedia.org/T238878

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Milimetric, Cparle, nettrom_WMF, Ladsgroup, daniel, Mayakp.wiki, gsingers, 
matthiasmullie, Addshore, kzimmerman, mpopov, Ramsey-WMF, Abit, Nuria, 
4748kitoko, darthmon_wmde, DannyS712, Nandana, JKSTNK, Akovalyov, Lahi, 
PDrouin-WMF, Gq86, E1presidente, Anooprao, SandraF_WMF, GoranSMilovanovic, 
QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, 
rosalieper, Scott_WUaS, Susannaanas, JAllemandou, Jane023, terrrydactyl, 
Wikidata-bugs, Base, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Fabrice_Florin, Raymond, Steinsplitter, Mbch331, jeremyb
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T238878: Data about how many file pages on Commons contain at least one structured data element

[matthiasmullie]

matthiasmullie added a comment.


  @Milimetric it wasn't being used to omit deleted pages (see inline comments 
about archive table), but to **also** exclude those RevDel'ed revisions.
  I was thinking it made sense to exclude rev-deleted revisions: if a page only 
has (SDC) revisions that are partly restricted for most people, that we might 
not want to count those.
  But one could argue that we should include them, and I'm happy to exclude 
that condition from the query! (though the number is likely extremely low, too 
low to even matter)

TASK DETAIL
  https://phabricator.wikimedia.org/T238878

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Milimetric, Cparle, nettrom_WMF, Ladsgroup, daniel, Mayakp.wiki, gsingers, 
matthiasmullie, Addshore, kzimmerman, mpopov, Ramsey-WMF, Abit, Nuria, 
4748kitoko, darthmon_wmde, DannyS712, Nandana, JKSTNK, Akovalyov, Lahi, 
PDrouin-WMF, Gq86, E1presidente, Anooprao, SandraF_WMF, GoranSMilovanovic, 
QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, 
rosalieper, Scott_WUaS, Susannaanas, JAllemandou, Jane023, terrrydactyl, 
Wikidata-bugs, Base, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Fabrice_Florin, Raymond, Steinsplitter, Mbch331, jeremyb
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T238878: Data about how many file pages on Commons contain at least one structured data element

[matthiasmullie]

matthiasmullie added a comment.


  I don't really know much about how `mediawiki_history` gets populated, but 
`wbcreateclaim` & `wbeditentity` (in addition to `wbsetclaim`) could also be 
used to create (or edit) statements IIRC, so this last set of results is likely 
incomplete.
  
  And I believe `wbc_entity_usage` currently *only* gets populated with 
M-entities fetched via Lua - any page where the M-entity is not used, will not 
show up there (I believe - could be wrong). So that data too (in additional to 
containing other, non-MediaInfo related entities) is likely incomplete.
  
  I believe that this query (based on @addshore's, but more strict about 
including only latest revision, of pages that have not been archived) is quite 
accurate (takes an awful long time to complete though)
  Did I overlook anything here - any reason to believe this number is invalid?
  
SELECT COUNT(DISTINCT page_id)
# page excludes deleted pages (which are in archive)
FROM page
# joining on page_latest - we only care about most recent (not revdeleted) 
revision
INNER JOIN revision ON rev_id = page_latest AND rev_deleted = 0
INNER JOIN slots ON slot_revision_id = rev_id
# mediainfo slot must contain actual content
INNER JOIN content ON slot_content_id = content_id AND content_size > 122
INNER JOIN slot_roles ON role_id = slot_role_id AND role_name = 'mediainfo';
  
+-+
| COUNT(DISTINCT page_id) |
+-+
| 3004300 |
+-+
1 row in set (33 min 31.86 sec)
  
  Just passed 3M files!

TASK DETAIL
  https://phabricator.wikimedia.org/T238878

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: nettrom_WMF, Ladsgroup, daniel, Mayakp.wiki, gsingers, matthiasmullie, 
Addshore, kzimmerman, mpopov, Ramsey-WMF, Abit, Nuria, 4748kitoko, 
darthmon_wmde, DannyS712, Nandana, JKSTNK, Akovalyov, Lahi, PDrouin-WMF, Gq86, 
E1presidente, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, 
Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, 
Scott_WUaS, Susannaanas, JAllemandou, Jane023, terrrydactyl, Wikidata-bugs, 
Base, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, 
Steinsplitter, Mbch331, jeremyb
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T238878: Data about how many file pages on Commons contain at least one structured data element

[matthiasmullie]

matthiasmullie added a comment.


  As far as I can tell:
  @mpopov's queries (`wbc_entity_usage` based) include both MediaInfo items, 
along with Wikidata-items pulled in via Lua.
  @Addshore's queries are stricktly the amount of MediaInfo items.

TASK DETAIL
  https://phabricator.wikimedia.org/T238878

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Addshore, kzimmerman, mpopov, Ramsey-WMF, Abit, Nuria, 
4748kitoko, darthmon_wmde, DannyS712, Nandana, JKSTNK, Akovalyov, Lahi, 
PDrouin-WMF, Gq86, E1presidente, Cparle, Anooprao, SandraF_WMF, 
GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, 
_jensen, rosalieper, Scott_WUaS, Susannaanas, JAllemandou, Jane023, 
terrrydactyl, Wikidata-bugs, Base, aude, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, jeremyb
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T181062: Adapt QuickStatements2 to be able to work with structured data on Commons as well

[matthiasmullie]

matthiasmullie added a comment.


  In T181062#5683735 <https://phabricator.wikimedia.org/T181062#5683735>, 
@Spinster wrote:
  
  > Can my colleagues from the #structureddataoncommons 
<https://phabricator.wikimedia.org/tag/structureddataoncommons/> team do 
anything to make it easier to include filename-to-Mid conversion in 
QuickStatements?
  
  FYI, getting the correct M-id from a page title can also be done via an 
`action=wbgetentities` API call, like so: 
https://commons.wikimedia.org/w/api.php?action=wbgetentities=commonswiki=File:2018-07-05-budapest-buda-hill.jpg
  With above API call, you'll find that the id for 
`File:2018-07-05-budapest-buda-hill.jpg` on Commons is `M75908279`.

TASK DETAIL
  https://phabricator.wikimedia.org/T181062

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Magnus, matthiasmullie
Cc: matthiasmullie, Spinster, Multichill, Husky, Jheald, Ramsey-WMF, 
ChristianKl, Abit, Aklapper, SandraF_WMF, darthmon_wmde, Tore_Danielsson_WMSE, 
DannyS712, Nandana, JKSTNK, tramm, Lahi, PDrouin-WMF, Gq86, E1presidente, 
Cparle, Anooprao, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, 
Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Jane023, 
Wikidata-bugs, Base, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Fabrice_Florin, Raymond, JeanFred, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T226093: Capacity planning for Commons Structured Data

[matthiasmullie]

matthiasmullie added a comment.


  In T226093#5657414 <https://phabricator.wikimedia.org/T226093#5657414>, 
@Ramsey-WMF wrote:
  
  > Matthias will look into discrepancies between number of files with 
mediainfo slots vs. what's indexed in Cirrus.
  
  It looks like the difference is mostly revisions vs files.
  
  The 5.5+ number closely matches the amount of revisions with a mediainfo 
`slots` record:
  `SELECT COUNT(*) FROM slots WHERE slot_role_id = 2` = **6161688**
  That number includes all edits though (SDC edits as well as regular file page 
edits once the page got its first structured data)
  
  mediainfo slots grouped by page is more similar to the results we get from 
Cirrus:
  `SELECT COUNT(DISTINCT rev_page) FROM slots INNER JOIN revision ON 
slot_revision_id = rev_id WHERE slot_role_id = 2` = **2918327**
  (This number also includes pages that once had structured data, but which has 
since been deleted)

TASK DETAIL
  https://phabricator.wikimedia.org/T226093

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Ladsgroup, Abit, matthiasmullie, Marostegui, Mholloway, Addshore, 
Ramsey-WMF, jcrespo, Yann, MarkTraceur, ArielGlenn, Aklapper, darthmon_wmde, 
Legado_Shulgin, DannyS712, Nandana, JKSTNK, Davinaclare77, Qtn1293, 
Techguru.pc, Lahi, PDrouin-WMF, Gq86, E1presidente, Cparle, Anooprao, 
SandraF_WMF, GoranSMilovanovic, Lunewa, Th3d3v1ls, Hfbn0, QZanden, Tramullas, 
Acer, LawExplorer, Salgo60, Zppix, Silverfish, _jensen, rosalieper, Scott_WUaS, 
Susannaanas, Wong128hk, gnosygnu, Jane023, Wikidata-bugs, Base, aude, 
Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, faidon, 
Steinsplitter, Mbch331, Jay8g, fgiunchedi
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

[matthiasmullie]

matthiasmullie closed this task as "Resolved".
matthiasmullie added a comment.


  Currently being used in production: 
https://commons.wikimedia.org/w/index.php?title=File%3AJodrell_Bank_Mark_II_5.jpg=revision=371864746=149735587
  Closing this one - let's open other more specific tickets for additional work 
(T236691 <https://phabricator.wikimedia.org/T236691>, T236692 
<https://phabricator.wikimedia.org/T236692>) or issues once they arise.

TASK DETAIL
  https://phabricator.wikimedia.org/T223792

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Njardarlogar, jeblad, WMDE-leszek, Tpt, LucasWerkmeister, jleedev, 
MarkTraceur, Yann, Addshore, Smalyshev, Mholloway, matthiasmullie, Multichill, 
Marsupium, Keegan, Jheald, Mike_Peel, Cparle, Aklapper, Jarekt, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Edtadros, 
Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, JKSTNK, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, PDrouin-WMF, Gq86, Af420, E1presidente, Ramsey-WMF, Darkminds3113, 
Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Salgo60, 
WSH1906, Lewizho99, Maathavan, Silverfish, _jensen, rosalieper, Susannaanas, 
Jane023, Wikidata-bugs, Base, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Fabrice_Florin, Raymond, Jdforrester-WMF, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unblock] T212144: Allow access to MediaInfo from wikitext on Commons

[matthiasmullie]

matthiasmullie closed subtask T223792: Extend mw.wikibase.getEntity lua 
function to allow accessing Structured Data on Commons items as 
Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T212144

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: Jheald, Ramsey-WMF, Cparle, Jdforrester-WMF, Aklapper, darthmon_wmde, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T236370: Call to undefined method Wikibase\Lib\EntityTypeDefinitions::getPrefetchingTermLookupCallbacks()

[matthiasmullie]

matthiasmullie added a comment.


  Same as with T236372 <https://phabricator.wikimedia.org/T236372>, these 
happened at the exact time these changes were being scapped, and stopped 
immediately after: 
https://logstash.wikimedia.org/goto/cfd3017e60a6be127c9673fd9ff53536

TASK DETAIL
  https://phabricator.wikimedia.org/T236370

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: WMDE-leszek, matthiasmullie, Liuxinyu970226, Aklapper, LarsWirzenius, 
darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Jdforrester-WMF, 
Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T236372: Too few arguments to function Wikibase\DataAccess\SingleEntitySourceServices::__construct(), 9 passed in /extensions/Wikibase/repo/includes/Wikibase

[matthiasmullie]

matthiasmullie added a comment.


  These all happened at 11:10 UTC, when the change was being deployed. This 
stopped immediately after: 
https://logstash.wikimedia.org/goto/39611d534c6b97d76c367f4e4878ab15

TASK DETAIL
  https://phabricator.wikimedia.org/T236372

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: hashar, WMDE-leszek, matthiasmullie, Liuxinyu970226, #wikibase-datamodel, 
Aklapper, LarsWirzenius, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T236372: Too few arguments to function Wikibase\DataAccess\SingleEntitySourceServices::__construct(), 9 passed in /extensions/Wikibase/repo/includes/Wikibase

[matthiasmullie]

matthiasmullie added a comment.


  I'll doublecheck, but I think these only happened the minute the patches were 
being scapped, and then stopped.

TASK DETAIL
  https://phabricator.wikimedia.org/T236372

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: WMDE-leszek, matthiasmullie, Liuxinyu970226, #wikibase-datamodel, Aklapper, 
LarsWirzenius, Jdforrester-WMF, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs