[Wikidata-bugs] [Maniphest] T352019: Cache SkinAfterBottomScriptsHandler::createSchemaElement
pmiazga created this task. pmiazga added projects: Wikimedia-Performance-recommendation, MediaWiki-extensions-WikibaseClient. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Currently, article pages contain the JSON-LD <https://en.wikipedia.org/wiki/JSON-LD> linked data schema at the bottom of the article page. Calling this method triggers two DB queries to fetch the description of the entity and the first revision of the article. Building the `JSON-LD` schema takes around 5% of the request time for an article. (https://performance.wikimedia.org/excimer/profile/17c43b402fb432bb). We should look into caching the result of `TermLookup::getDescription` and `RevisionLookup::getFirstRevision` as there is no need to execute these every request. F41540388: image.png <https://phabricator.wikimedia.org/F41540388> TASK DETAIL https://phabricator.wikimedia.org/T352019 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: pmiazga Cc: pmiazga, Aklapper, ItamarWMDE, Akuckartz, lucamauri, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T324991: Make Wikibase not rely on the ResourceLoader target system
pmiazga added a comment.
> if ( ExtensionRegistry::getInstance()->isLoaded( 'MobileFrontend' ) ) {
> $mobileContext = MediaWikiServices::getInstance()->getService(
'MobileFrontend.Context' );
> $isMobileView = $mobileContext->shouldDisplayMobileView();
> if ( $isMobileView ) {
> $out->addModule( 'ext.foo.bar' );
> }
> }
One thing that I'm worried about is this approach will create a tight
coupling between any extension and MobileFrontend, and if for any reason we
need to change MobileFrontend API, then all places that call it would have to
be updated. I know it's a common case and plenty of extensions do it this way
(https://codesearch.wmcloud.org/search/?q=shouldDisplayMobileView===).
This is what we currently do but I think if we could improve this. Especially
now as it looks like that with removing the target system more and more things
will require this check.
I'm wondering whether this should be a responsibility of the `OutputPage`
class or MW Core in general. Therefore I'm thinking about a better approach
where communication happens between extensions and MW - not between extensions.
MW has a notion of things, but does not implement those - and extensions
provide capabilities. To check for the capability - you ask MW Core if it can
handle such a scenario (thus you can have multiple extensions providing
specific case - for instance, someone could provide their own MobileFrontend
implementation).
The mobile view is more a browser/device capability and maybe we could
provide some notion of Browser features/capabilities/(naming is hard) and let
the OutputPage be aware of context instead of depending on MobileFrontend
directly.
Another approach could be providing a Hook but I'm not sure if we want to
keep adding hooks.
@Jdlrobson what do you think? Is it something worth pursuing?
TASK DETAIL
https://phabricator.wikimedia.org/T324991
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: pmiazga
Cc: ItamarWMDE, Manuel, Lucas_Werkmeister_WMDE, StudiesWorld, Jdforrester-WMF,
Aklapper, Krinkle, Catrope, Legoktm, TrevorParscal, ori, Ricordisamoa, Krenair,
gerritbot, Florian, brion, Nikerabbit, Tgr, pmiazga, Ciencia_Al_Poder,
Tacsipacsi, JohanahoJ, Ltrlg, AntiCompositeNumber, Lens0021, kostajh,
Universal_Omega, Michael, Jdlrobson, Themindcoder, Adamm71, Jersione,
Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE,
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz,
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420,
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic,
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton,
Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331,
Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] [Updated] T226009: add link to Wikidata on Wikipedia mobile view
pmiazga added a project: Readers-Web-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T226009 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: pmiazga Cc: ovasileva, pmiazga, Aklapper, Esc3300, darthmon_wmde, Nandana, Lahi, Gq86, mojoaxel, GoranSMilovanovic, QZanden, LawExplorer, Winter, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T226285: Mobileview cache not cleared after wikidata edits
pmiazga added a project: Readers-Web-Backlog (Tracking). TASK DETAIL https://phabricator.wikimedia.org/T226285 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: pmiazga Cc: Addshore, Aklapper, NHarateh_WMF, darthmon_wmde, Nandana, Lahi, Gq86, mojoaxel, GoranSMilovanovic, QZanden, LawExplorer, Winter, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T226009: add link to Wikidata on Wikipedia mobile view
pmiazga added a comment. The T222630: Add wikidata item link to AMC overflow menu <https://phabricator.wikimedia.org/T222630> does exactly what this this ticket says - it adds a link to Wikidata item to new menu. The #advanced_mobile_contributions <https://phabricator.wikimedia.org/tag/advanced_mobile_contributions/> project is a feature set that will add more contributor features/capabilities to the mobile web experience. It's an opt-in feature, that will slightly modify the mobile web UI, and allow access to many tools (like adding Wikidata links). You can learn more about Advanced Contributions Mode on https://www.mediawiki.org/wiki/Reading/Web/Advanced_mobile_contributions TASK DETAIL https://phabricator.wikimedia.org/T226009 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: pmiazga Cc: pmiazga, Aklapper, Esc3300, darthmon_wmde, Nandana, Lahi, Gq86, mojoaxel, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Merged] T226009: add link to Wikidata on Wikipedia mobile view
pmiazga closed this task as a duplicate of T222630: Add wikidata item link to AMC overflow menu. TASK DETAIL https://phabricator.wikimedia.org/T226009 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: pmiazga Cc: pmiazga, Aklapper, Esc3300, darthmon_wmde, Nandana, Lahi, Gq86, mojoaxel, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T226009: add link to Wikidata on Wikipedia mobile view
pmiazga added a comment. This feature is available in "Advanced Mobile Contributions" mode, we're currently working on it. It's released only to couple wikis, not available on English Wikipedia yet. For more info please refer to T222630: Add wikidata item link to AMC overflow menu <https://phabricator.wikimedia.org/T222630>. TASK DETAIL https://phabricator.wikimedia.org/T226009 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: pmiazga Cc: pmiazga, Aklapper, Esc3300, darthmon_wmde, Nandana, Lahi, Gq86, mojoaxel, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T225529: Article tagline should be set by a hook, not by code highly coupled with Wikibase
pmiazga updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T225529 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: pmiazga Cc: pmiazga, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, mojoaxel, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Winter, _jensen, rosalieper, Izno, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T224545: UnexpectedValueException when looking at a Special:MobileDiff for an EntitySchema Revision
pmiazga added a project: Readers-Web-Backlog (Tracking). TASK DETAIL https://phabricator.wikimedia.org/T224545 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, pmiazga Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, E.S.A-Sheild, darthmon_wmde, Premeditated, pdehaye, alaa_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, mojoaxel, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, YULdigitalpreservation, LawExplorer, Winter, Salgo60, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, abian, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T209352: [Spike 2hrs] BetaCluster incorrectly points SameAS to production Wikidata
pmiazga removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T209352EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: pmiazgaCc: Stashbot, Lydia_Pintscher, phuedx, Lucas_Werkmeister_WMDE, gerritbot, Niedzielski, Aklapper, pmiazga, Nandana, Lahi, Gq86, GoranSMilovanovic, Chicocvenancio, QZanden, LawExplorer, Winter, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331, Krenair, CucyNoiD, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T209352: [Spike 2hrs] BetaCluster incorrectly points SameAS to production Wikidata
pmiazga closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T209352EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: pmiazgaCc: Stashbot, Lydia_Pintscher, phuedx, Lucas_Werkmeister_WMDE, gerritbot, Niedzielski, Aklapper, pmiazga, Nandana, Lahi, Gq86, GoranSMilovanovic, Chicocvenancio, QZanden, LawExplorer, Winter, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T209352: [Spike 2hrs] BetaCluster incorrectly points SameAS to production Wikidata
pmiazga added a comment. Everything works as expected.TASK DETAILhttps://phabricator.wikimedia.org/T209352EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: pmiazgaCc: Stashbot, Lydia_Pintscher, phuedx, Lucas_Werkmeister_WMDE, gerritbot, Niedzielski, Aklapper, pmiazga, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Chicocvenancio, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T209352: [Spike 2hrs] BetaCluster incorrectly points SameAS to production Wikidata
pmiazga added a comment. I'll be able to sign off this task once Beta Cluster gets out of the maintenance. Right now the cluster is in read-only mode.TASK DETAILhttps://phabricator.wikimedia.org/T209352EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: pmiazgaCc: Stashbot, Lydia_Pintscher, phuedx, Lucas_Werkmeister_WMDE, gerritbot, Niedzielski, Aklapper, pmiazga, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Chicocvenancio, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, D3r1ck01, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T209352: [Spike 2hrs] BetaCluster incorrectly points SameAS to production Wikidata
pmiazga added a comment. Code looks ok, tommorrow I'll merge the code to beta clusterTASK DETAILhttps://phabricator.wikimedia.org/T209352EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: pmiazgaCc: Lydia_Pintscher, phuedx, Lucas_Werkmeister_WMDE, gerritbot, Niedzielski, Aklapper, pmiazga, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Chicocvenancio, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, D3r1ck01, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T209352: [Spike 2hrs] BetaCluster incorrectly points SameAS to production Wikidata
pmiazga claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T209352EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: pmiazgaCc: Lydia_Pintscher, phuedx, Lucas_Werkmeister_WMDE, gerritbot, Niedzielski, Aklapper, pmiazga, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Chicocvenancio, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, D3r1ck01, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T209410: sameAs schema doesn't report dateModified if article has only one edit
pmiazga created this task.pmiazga added projects: Wikidata, Readers-Web-Backlog, SEO.Restricted Application added a subscriber: Aklapper. TASK DESCRIPTIONWhen you visit the page that has only one edit, the sameAs schema doesn't include dateModified, as the article wasn't modified (only created) Although the Google testing tools says that dateModified is recommended field but: it also says that the dateModified should be more recent than datePublished there is no mention what to do if there is no modification date (only creation date). Please, verify what to do in this scenario, and or add dateModified with same value as datePublished leave a note, that in this cases dateModified is not necessary TASK DETAILhttps://phabricator.wikimedia.org/T209410EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: pmiazgaCc: Sniedzielski, pmiazga, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, Chicocvenancio, QZanden, LawExplorer, Winter, D3r1ck01, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T198946: Add Schema property 'sameAs' pointing to Wikidata entries
pmiazga closed this task as "Resolved".pmiazga removed pmiazga as the assignee of this task.pmiazga updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[X] The meta tags are configurable by a config flag [X] The meta tags are disabled by default [X] When enabled, the meta tags appear in the HTML [X] If a page has no corresponding Wikidata entry, there is no metadata tag. [X] sameAs tag present without _javascript_TASK DETAILhttps://phabricator.wikimedia.org/T198946EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: pmiazgaCc: Tpt, Stashbot, Gilles, nray, Smalyshev, WMDE-leszek, Tarrow, BBlack, Addshore, Lydia_Pintscher, mpopov, pmiazga, Jdrewniak, gerritbot, Denny, ovasileva, Tbayer, CKoerner_WMF, Jdlrobson, Niedzielski, phuedx, dr0ptp4kt, Imarlier, cscott, Krenair, Aklapper, Deskana, Nandana, Lahi, Gq86, GoranSMilovanovic, Chicocvenancio, QZanden, LawExplorer, Winter, Vali.matei, D3r1ck01, Jonas, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T198946: Add Schema property 'sameAs' pointing to Wikidata entries
pmiazga added a comment. Tested on beta cluster, works as expected. I did smoke tests, the proper thorough testing will be tracked in T208772.TASK DETAILhttps://phabricator.wikimedia.org/T198946EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: pmiazgaCc: Tpt, Stashbot, Gilles, nray, Smalyshev, WMDE-leszek, Tarrow, BBlack, Addshore, Lydia_Pintscher, mpopov, pmiazga, Jdrewniak, gerritbot, Denny, ovasileva, Tbayer, CKoerner_WMF, Jdlrobson, Niedzielski, phuedx, dr0ptp4kt, Imarlier, cscott, Krenair, Aklapper, Deskana, Nandana, Lahi, Gq86, GoranSMilovanovic, Chicocvenancio, QZanden, LawExplorer, Winter, Vali.matei, D3r1ck01, Jonas, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T198946: Add Schema property 'sameAs' pointing to Wikidata entries
pmiazga removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T198946EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: pmiazgaCc: Tpt, Stashbot, Gilles, nray, Smalyshev, WMDE-leszek, Tarrow, BBlack, Addshore, Lydia_Pintscher, mpopov, pmiazga, Jdrewniak, gerritbot, Denny, ovasileva, Tbayer, CKoerner_WMF, Jdlrobson, Niedzielski, phuedx, dr0ptp4kt, Imarlier, cscott, Krenair, Aklapper, Deskana, Nandana, Lahi, Gq86, GoranSMilovanovic, Chicocvenancio, QZanden, LawExplorer, Winter, Vali.matei, D3r1ck01, Jonas, Wikidata-bugs, aude, Mbch331, CucyNoiD, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster
pmiazga added a comment. We decided to drop the hook usage anyway, if something goes wrong and mobile watchlist becomes unusable we are able to quickly bring back the old behavior by setting the MFWatchlistRunsChangesListSpecialPageQuery config option to true.TASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: pmiazgaCc: gerritbot, Krinkle, Jdforrester-WMF, pmiazga, Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, 45Jayjay1969, QZanden, EnricoCNC, LawExplorer, Winter, Taiwania_Justo, Trizek-WMF, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, Catrope, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster
pmiazga added a comment. Yeah, it may the problem as different things expect some fields to be present in the FormOptions, even we don't use it, we will have to define same set options as ChangesListSpecialPage, maybe we can re-use the ChangesListSpecialPage class (initialize it just to get the options), but honestly that is one big hack. Let me do a step back, my question is -> do we need to call that hook? /cc @JdlrobsonTASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: pmiazgaCc: gerritbot, Krinkle, Jdforrester-WMF, pmiazga, Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, CucyNoiD, Nandana, NebulousIris, kostajh, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 45Jayjay1969, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EnricoCNC, LawExplorer, Winter, Lewizho99, Maathavan, Taiwania_Justo, Trizek-WMF, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, Catrope, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster
pmiazga added a comment. It's caused by this change: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/463879/3/includes/specials/SpecialMobileWatchlist.phpTASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: pmiazgaCc: pmiazga, Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T204070: [Spike, 8hrs] Where should Schema property 'sameAs' live?
pmiazga added a comment. I think that creating a new extension just to inject one extra tag is a bit overkill. Adding it to MW core is also not the best solution as it throws too many responsibilities to the Core package. Adding to the Google Rich Cards can be an option, but then most probably we should rename the extension, as it will serve a bit more than Rich cards support. IMHO the most reasonable solution is to add sameAs support to the WikibaseClient, just hide it behind the config variable.TASK DETAILhttps://phabricator.wikimedia.org/T204070EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: nray, pmiazgaCc: pmiazga, Lydia_Pintscher, Addshore, Deskana, Aklapper, Krenair, cscott, Imarlier, dr0ptp4kt, phuedx, Niedzielski, CKoerner_WMF, Elitre, Tbayer, Jdlrobson, Nandana, Lahi, Gq86, GoranSMilovanovic, Chicocvenancio, QZanden, LawExplorer, Winter, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T194731: Show diffs for all slots [MCR]
pmiazga added a subscriber: Jdlrobson.pmiazga added a comment. I also did couple of tests before and I found that: MobileFrontend uses different DiffEngine (it's hardcoded), this is something you have to talk to Reading Web I also remember there is a work on a different engine that nicely shows when stuff is moved around (instead of just showing added/removed) it shows "moved" with an arrow that points to the new location (@Jdlrobson will know more) at least on my machine populateContentTablesthrows strange mysql errors: Wikimedia\Rdbms\DBTransactionError: Transaction round stage must be 'cursory' (not 'within-rollback') in /vagrant/mediawiki/includes/libs/rdbms/lbfactory/LBFactory.php on line 707 Wikimedia\Rdbms\DBTransactionStateError from line 1298 of /vagrant/mediawiki/includes/libs/rdbms/database/Database.php: Cannot execute query from Wikimedia\Rdbms\Database::ping while transaction status is ERROR. When creating a test revision: >>> $pu->setContent( 'slot', $c ); // 'slot' is the slot name, should be the same across revisions InvalidArgumentException with a message 'Only the main slot is presently supported I couldn't test the second slot as I cannot insert another slot (the error above) I checked some diffs, also diffs with no changes/removing/undeleting stuff - looked fine I didn't manage to do anything from Low priority,TASK DETAILhttps://phabricator.wikimedia.org/T194731EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, pmiazgaCc: Jdlrobson, pmiazga, Aklapper, gerritbot, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T152963: Increase in failures caused by Saucelabs
pmiazga added a comment. @zeljkofilipin any updates? Looks like some MobileFrontend extension tests still fail from time to time: https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-MobileFrontend/451/TASK DETAILhttps://phabricator.wikimedia.org/T152963EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: pmiazgaCc: pmiazga, Jdforrester-WMF, dduvall, Tgr, greg, Jdlrobson, Cmcmahon, hoo, Lydia_Pintscher, Jonas, Aleksey_WMDE, gerritbot, zeljkofilipin, thiemowmde, Aklapper, Tobi_WMDE_SW, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Liudvikas, Izno, Luke081515, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
