Re: [Wikidata] Primary sources tool "reject claim" broken?

[Sebastian Schaffert]

Hi Thomas and all,

there might be a caching issue here. That part of the code is here:
https://github.com/google/primarysources/blob/master/backend/service/SourcesToolBackend.cc#L115
and
it still seems right to me, but I'll check again.

I won't have much time in the next days though :( I'll give it one hour no,
maybe I discover something.

Cheers,

Sebastian

On Tue, May 31, 2016 at 9:17 AM Thomas Steiner  wrote:

> Hi Markus and Marco, all,
>
> Thanks for your support of and caring for the Primary Sources Tool.
> Please find my replies inline.
>
> > Dear ,
>
> I guess the core team still does, with the caveat explained by Denny
> in [1], the tl;dr is that we work on it on top of our regular jobs and
> that we are happy to hand it over to folks with more time on their
> hands.
>
> > The PS tool seems to break more and more. Besides the persisting issue
> with
> > duplicated claims being offered (even if they are already stored), there
> is
> > now also the issue that claims cannot be rejected. If I reject a claim,
> the
> > page reloads, but the suggestion still shows up after that.
>
> I checked both problems. It seems the writes from the front-end
> somehow do not make it to the back-end. I opened a random item Q632229
> and approved and rejected claims. The approval went through just fine
> [2].
>
> (i) However, I could reproduce the duplicate claims being shown, the
> reason is that the uniqueness comparison does not take references into
> account [3], a known @ToDo up for grabs.
> (ii) I could also in some cases reproduce the non-rejectable claims
> issue. I repeated disapproved statement 868483 [4], but if you query
> the back-end for incoming Freebase statements for Q632229, it keeps
> coming back as "unapproved" [5] (search for "868483").
>
> For (i), if someone wants to tackle this, happy to merge their Pull
> Request. For (ii), Sebastian, do you have a suspicion why this could
> be the case?
>
> Thanks,
> Tom
>
> --
> [1]
> https://lists.wikimedia.org/pipermail/wikidata/2016-February/008316.html
> [2]
> https://www.wikidata.org/w/index.php?title=Q632229=revision=341928371=316931253
> [3]
> https://github.com/google/primarysources/blob/master/frontend/freebase2wikidata.js#L805
> [4] https://tools.wmflabs.org/wikidata-primary-sources/statements/868483
> [5] https://tools.wmflabs.org/wikidata-primary-sources/entities/Q632229
>
> --
> Dr. Thomas Steiner, Employee (http://blog.tomayac.com,
> https://twitter.com/tomayac)
>
> Google Germany GmbH, ABC-Str. 19, 20354 Hamburg, Germany
> Managing Directors: Matthew Scott Sucherman, Paul Terence Manicle
> Registration office and registration number: Hamburg, HRB 86891
>
> -BEGIN PGP SIGNATURE-
> Version: GnuPG v2.0.29 (GNU/Linux)
>
>
> iFy0uwAntT0bE3xtRa5AfeCheCkthAtTh3reSabiGbl0ck0fjumBl3DCharaCTersAttH3b0ttom
> hTtPs://xKcd.cOm/1181/
> -END PGP SIGNATURE-
>
___
Wikidata mailing list
Wikidata@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata

Re: [Wikidata] Primary sources tool "reject claim" broken?

[Marco Fossati]

Sorry, I forgot to rename the "digest" subject, fixed now.

On 5/30/16 16:06, Marco Fossati wrote:

Hi Markus,

this is a known issue:
https://github.com/google/primarysources/issues/94

It seems to be related to the front-end: @Thomas, this and
https://github.com/google/primarysources/issues/107 are blocking the
usage of the tool.
Would it be possible for you to investigate them?
Cheers,

Marco

On 5/30/16 14:00, wikidata-requ...@lists.wikimedia.org wrote:

Date: Mon, 30 May 2016 10:19:32 +0200
From: Markus Kroetzsch<markus.kroetz...@tu-dresden.de>
To: "Discussion list for the Wikidata project."
<wikidata@lists.wikimedia.org>
Subject: [Wikidata] Primary sources tool "reject claim" broken?
Message-ID:<574bf794.1060...@tu-dresden.de>
Content-Type: text/plain; charset=utf-8; format=flowed

Dear ,

The PS tool seems to break more and more. Besides the persisting issue
with duplicated claims being offered (even if they are already stored),
there is now also the issue that claims cannot be rejected. If I reject
a claim, the page reloads, but the suggestion still shows up after that.

Cheers,

Markus

-- Markus Kroetzsch Faculty of Computer Science Technische Universität
Dresden +49 351 463 38486 http://korrekt.org/


___
Wikidata mailing list
Wikidata@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata