[Wikidata-bugs] [Maniphest] [Created] T156344: Property: namespace as content
Smalyshev created this task.Smalyshev added a project: Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTIONCurrently only main namespace (Items) on wikidata.org is configured as content namespace. I think it makes sense to add Property namespace at least to content index for CirrusSearch, and maybe to general content namespaces list too. Adding Property space to $wgCirrusSearchNamespaceMappings would allow it to be in the same index as items, thus allowing to search them together if necessary.TASK DETAILhttps://phabricator.wikimedia.org/T156344EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: EBernhardson, aude, dcausse, daniel, Aklapper, Smalyshev, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T125500: Index Wikidata labels and descriptions as separate fields in ElasticSearch
Smalyshev added a subtask: T155139: 'ContentHandlerForModelID' hook allows creating of handlers that aren't registered. TASK DETAILhttps://phabricator.wikimedia.org/T125500EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Jonas, gerritbot, JanZerebecki, daniel, thiemowmde, Tobi_WMDE_SW, Smalyshev, Aklapper, StudiesWorld, Deskana, aude, Ricordisamoa, hoo, Th3d3v1ls, Ramalepe, Liugev6, EBjune, Avner, Lewizho99, Maathavan, debt, Gehel, D3r1ck01, FloNight, Izno, Wikidata-bugs, jayvdb, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T156240: Stop writes on hash conflicts & log that they occour
daniel added a comment. @Bawolff well, right now, all the vandal has to do is go to the page and add [[nds:Bawolff sucks...GHHDCBTSfgjbftgdthn"]] to the page... Granted, the fix is a bit less obvious, but deleting a page is easy enough. Oh, btw... @Addshore do we have a way to prune the titles table, so we don't accumulate too much garbage there?... I don't see a good way, really.TASK DETAILhttps://phabricator.wikimedia.org/T156240EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, danielCc: Bawolff, Lydia_Pintscher, Aklapper, daniel, gerritbot, Addshore, D3r1ck01, Andrew-WMDE, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T156280: WikiBase assumes English doesn't have a variant
Smalyshev added a comment. Looked more into it, and looks like fallback chain is supposed to return language itself if it's specified as "language with variants"... So looks like maybe making it somehow conditional may work, but I couldn't figure out code fix for it.TASK DETAILhttps://phabricator.wikimedia.org/T156280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Smalyshev, Aklapper, cscott, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T156280: WikiBase assumes English doesn't have a variant
Smalyshev added a comment. It looks like what is happening is that "en" language is resolved to be it's own variant even if pig latin is not enabled. It's not exactly right, and I'm not sure it's Wikibase test's fault - I think actually Wikibase is not at fault here. It's the code that says "we have variants, but we don't actually have variants". So we should either not declare variants, or at least not declare "en" to be its own variant.TASK DETAILhttps://phabricator.wikimedia.org/T156280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Smalyshev, Aklapper, cscott, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T156240: Stop writes on hash conflicts & log that they occour
Bawolff added a comment. The scenario i was thinking of is someone uses gpus to brute force a conflict between a real title and the normalized version of a naughty string. So e.g. if "Dog" and "Bawolff sucks...GHHDCBTSfgjbftgdthn" collide after normalization (this is just a theoretical example, they dont actually collide), the vandal could create the page "Bawolff sucks...GHHDCBTSfgjbftgdthn" on an obscure language and now suddenly the en page for Dog has an interlanguage link to a maliciously titled page, and the users dont understand what happened.TASK DETAILhttps://phabricator.wikimedia.org/T156240EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, BawolffCc: Bawolff, Lydia_Pintscher, Aklapper, daniel, gerritbot, Addshore, D3r1ck01, Andrew-WMDE, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T149082: Security review for Cognate Extension
Addshore added a comment. In T149082#2970263, @Bawolff wrote: Oh. This makes sense to me now. When i was first looking at it I didnt realize it needed to do that The patch attached to T156239 reduces the db interaction. I'll have a follow up comment about the hashes / conflict situation tomorrow. Other than that I believe everything else already has patches up / merged patches.TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T102476: RFC: Requirements for change propagation
Herald added a project: Analytics. TASK DETAILhttps://phabricator.wikimedia.org/T102476EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MZMcBrideCc: MZMcBride, Mholloway, Liuxinyu970226, Scott_WUaS, Ottomata, Smalyshev, ArielGlenn, hoo, Addshore, RobLa-WMF, StudiesWorld, intracer, JanZerebecki, brion, Ltrlg, Anomie, Milimetric, mark, BBlack, aaron, daniel, Eevans, mobrovac, GWicke, D3r1ck01, Izno, Luke081515, JAllemandou, Hardikj, Wikidata-bugs, aude, jayvdb, fbstj, Mbch331, Jay8g, bd808, jeremyb, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T154993: Make help portal more prominent
Jonas added a project: Wikidata-Sprint. TASK DETAILhttps://phabricator.wikimedia.org/T154993EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: gerritbot, Jonas, Lydia_Pintscher, johl, Aklapper, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Avner, Lewizho99, Maathavan, debt, Gehel, D3r1ck01, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T154993: Make help portal more prominent
gerritbot added a comment. Change 334048 merged by jenkins-bot: Make help button a split button dropdown linking to help portal https://gerrit.wikimedia.org/r/334048TASK DETAILhttps://phabricator.wikimedia.org/T154993EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Jonas, Lydia_Pintscher, johl, Aklapper, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Avner, Lewizho99, Maathavan, debt, Gehel, D3r1ck01, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T125500: Index Wikidata labels and descriptions as separate fields in ElasticSearch
Smalyshev claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T125500EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Jonas, gerritbot, JanZerebecki, daniel, thiemowmde, Tobi_WMDE_SW, Smalyshev, Aklapper, StudiesWorld, Deskana, aude, Ricordisamoa, hoo, Th3d3v1ls, Ramalepe, Liugev6, EBjune, Avner, Lewizho99, Maathavan, debt, Gehel, D3r1ck01, FloNight, Izno, Wikidata-bugs, jayvdb, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T117520: Index Wikidata labels, aliases and descriptions as separate fields in ElasticSearch
Smalyshev claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T117520EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: hoo, Ricordisamoa, aude, Deskana, StudiesWorld, Aklapper, Smalyshev, EBjune, Avner, debt, Gehel, D3r1ck01, FloNight, Izno, Wikidata-bugs, jayvdb, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension
Bawolff added a comment. In T149082#2968137, @Addshore wrote: In T149082#2966632, @Bawolff wrote: I assume this is not using the LinkUpdates related hooks because it only wants to deal with new pages not edits (?) However it seems that this still triggers on all edits. Perhaps it should look at the EDIT_NEW flag in the onPageSaveComplete hook to avoid some unnecessary database interaction. Cognate needs to know when pages are edited to determine if the redirect state has changed: redirect -> regular page = needs to be added to the db regular page -> redirect = needs to be removed from the db If I had both the new and the last content then I would be able to check the redirect state of each and only act where needed here. I'll have a further look. Oh. This makes sense to me now. When i was first looking at it I didnt realize it needed to do thatTASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BawolffCc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag
gerritbot added a comment. Change 334169 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)): Simplified html assertion in SpecialGoToLinkedPageTest https://gerrit.wikimedia.org/r/334169TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDE, gerritbotCc: WMDE-leszek, hashar, thiemowmde, Aleksey_WMDE, JanZerebecki, Ricordisamoa, gerritbot, Aklapper, Wikidata-bugs, Bene, Tobi_WMDE_SW, JeroenDeDauw, adrianheine, Lydia_Pintscher, daniel, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag
gerritbot added a comment. Change 334165 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)): Refactoring SpecialModifyTermTestCase https://gerrit.wikimedia.org/r/334165TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDE, gerritbotCc: WMDE-leszek, hashar, thiemowmde, Aleksey_WMDE, JanZerebecki, Ricordisamoa, gerritbot, Aklapper, Wikidata-bugs, Bene, Tobi_WMDE_SW, JeroenDeDauw, adrianheine, Lydia_Pintscher, daniel, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T155828: Build item_quality form
Halfak added a comment. @Lydia_Pintscher, what do you think about the middle quality classes. Could we pick and choose criteria and make statements about what types of items belongs at which level? E.g. E: Anything that doesn't the D criteria D: A few useful statements and a description in at least one language C: At least one non-trivial statement is referenced. B: Aliases and description are translated into >= 5 languages A: All Showcase criteria met This is just an example. For English Wikipedia's 1.0 assessments they have descriptions that are a bit more subjective and make references to process and the level of coverage. Stub: The article is either a very short article or a rough collection of information that will need much work to become a meaningful article. It is usually very short; but, if the material is irrelevant or incomprehensible, an article of any length falls into this category. Although Stub-class articles are the lowest class of the normal classes, they are adequate enough to be an accepted article, though they do have risks of being dropped from being an article all together. Start: The article has a usable amount of good content but is weak in many areas. Quality of the prose may be distinctly unencyclopedic, and MoS compliance non-existent. The article should satisfy fundamental content policies, such as BLP. Frequently, the referencing is inadequate, although enough sources are usually provided to establish verifiability. No Start-Class article should be in any danger of being speedily deleted. C: The article cites more than one reliable source and is better developed in style, structure, and quality than Start-Class, but it fails one or more of the criteria for B-Class. It may have some gaps or missing elements; need editing for clarity, balance, or flow; or contain policy violations, such as bias or original research. Articles on fictional topics are likely to be marked as C-Class if they are written from an in-universe perspective. It is most likely that C-Class articles have a reasonable encyclopedic style. B: The article is suitably referenced, with inline citations. The article reasonably covers the topic, and does not contain obvious omissions or inaccuracies. The article has a defined structure. The article is reasonably well-written. The article contains supporting materials where appropriate. The article presents its content in an appropriately understandable way. GA: Well written: the prose is clear and concise, and the spelling and grammar are correct. Verifiable and it contains no original research. It contains no copyright violations nor plagiarism. Broad in its coverage: it addresses the main aspects of the topic. Neutral: it represents viewpoints fairly and without editorial bias, giving due weight to each. Stable: it does not change significantly from day to day. Images are relevant to the topic, and have suitable captions. FA: See https://en.wikipedia.org/wiki/Wikipedia:Featured_article_criteria TASK DETAILhttps://phabricator.wikimedia.org/T155828EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, HalfakCc: Lea_Lacroix_WMDE, samuwmde, Lydia_Pintscher, StudiesWorld, Aklapper, Ricordisamoa, Sumit, Glorian_Yapinus, Halfak, Glorian_WD, Ladsgroup, Avner, D3r1ck01, Izno, Wikidata-bugs, aude, He7d3r, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T73350: Fatal error: Call to a member function getOption() on a non-object (with beta features)
matej_suchanek removed subscribers: matej_suchanek, Wikidata-bugs.matej_suchanek added a project: TestMe.Herald added a subscriber: TerraCodes. TASK DETAILhttps://phabricator.wikimedia.org/T73350EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: TerraCodes, aude, Lydia_Pintscher, D3r1ck01, Izno, Luke081515, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T156280: WikiBase assumes English doesn't have a variant
cscott created this task.cscott added a project: MediaWiki-extensions-WikibaseClient.Herald added a subscriber: Aklapper.Herald added a project: Wikidata. TASK DESCRIPTIONSee gerrit failures for https://gerrit.wikimedia.org/r/72053 Wikibase makes the assumption that English won't have a variant assigned. That assumption isn't always correct.TASK DETAILhttps://phabricator.wikimedia.org/T156280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cscottCc: Aklapper, cscott, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T156239: Cognate - Make PageContentSaveComplete check for redirect state changes & only act when they (or page creation) happens
gerritbot added a comment. Change 334128 merged by jenkins-bot: Write to cognate db on fewer edits https://gerrit.wikimedia.org/r/334128TASK DETAILhttps://phabricator.wikimedia.org/T156239EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Lydia_Pintscher, Aklapper, daniel, gerritbot, Addshore, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T156220: Wikidata autocomplete breaks with URL ...?uselang=en-US
Mbch331 added a comment. I can confirm the issue using Firefox. I checked my browser console during the loading of the page and the attempt to add a statement and I don't get any error messages.TASK DETAILhttps://phabricator.wikimedia.org/T156220EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mbch331Cc: Mbch331, Lydia_Pintscher, daniel, Aklapper, Yurik, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T155828: Build item_quality form
Lydia_Pintscher added a comment. Yes people should in general follow the showcase item criteria. So A would be "meets all criteria" and E would be "meets none of the criteria"? In this case we should list the criteria and say that.TASK DETAILhttps://phabricator.wikimedia.org/T155828EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Lydia_PintscherCc: Lea_Lacroix_WMDE, samuwmde, Lydia_Pintscher, StudiesWorld, Aklapper, Ricordisamoa, Sumit, Glorian_Yapinus, Halfak, Glorian_WD, Ladsgroup, Avner, D3r1ck01, Izno, Wikidata-bugs, aude, He7d3r, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T156239: Cognate - Make PageContentSaveComplete check for redirect state changes & only act when they (or page creation) happens
gerritbot added a comment. Change 334128 had a related patch set uploaded (by Addshore): Write to cognate db on fewer edits https://gerrit.wikimedia.org/r/334128TASK DETAILhttps://phabricator.wikimedia.org/T156239EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Lydia_Pintscher, Aklapper, daniel, gerritbot, Addshore, D3r1ck01, Andrew-WMDE, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T156239: Cognate - Make PageContentSaveComplete check for redirect state changes & only act when they (or page creation) happens
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T156239EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Lydia_Pintscher, Aklapper, daniel, gerritbot, Addshore, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T152644: rack/setup/install wdqs2003
ops-monitoring-bot added a comment. Completed auto-reimage of hosts: ['wdqs2003.codfw.wmnet'] and were ALL successful.TASK DETAILhttps://phabricator.wikimedia.org/T152644EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Gehel, ops-monitoring-botCc: ops-monitoring-bot, gerritbot, Southparkfan, Smalyshev, Aklapper, Deskana, mark, emailbot, Papaul, Cmjohnson, RobH, Gehel, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Avner, Lewizho99, Zppix, Maathavan, debt, D3r1ck01, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T152644: rack/setup/install wdqs2003
ops-monitoring-bot added a comment. Script wmf_auto_reimage was launched by gehel on neodymium.eqiad.wmnet for hosts: ['wdqs2003.codfw.wmnet'] The log can be found in /var/log/wmf-auto-reimage/201701251326_gehel_20899.log.TASK DETAILhttps://phabricator.wikimedia.org/T152644EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Gehel, ops-monitoring-botCc: ops-monitoring-bot, gerritbot, Southparkfan, Smalyshev, Aklapper, Deskana, mark, emailbot, Papaul, Cmjohnson, RobH, Gehel, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Avner, Lewizho99, Zppix, Maathavan, debt, D3r1ck01, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T152644: rack/setup/install wdqs2003
gerritbot added a comment. Change 334056 merged by Gehel: wdqs - configure wdqs2003 (new node) https://gerrit.wikimedia.org/r/334056TASK DETAILhttps://phabricator.wikimedia.org/T152644EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Gehel, gerritbotCc: gerritbot, Southparkfan, Smalyshev, Aklapper, Deskana, mark, emailbot, Papaul, Cmjohnson, RobH, Gehel, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Avner, Lewizho99, Zppix, Maathavan, debt, D3r1ck01, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T152644: rack/setup/install wdqs2003
gerritbot added a comment. Change 334056 had a related patch set uploaded (by Gehel): wdqs - configure wdqs2003 (new node) https://gerrit.wikimedia.org/r/334056TASK DETAILhttps://phabricator.wikimedia.org/T152644EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Gehel, gerritbotCc: gerritbot, Southparkfan, Smalyshev, Aklapper, Deskana, mark, emailbot, Papaul, Cmjohnson, RobH, Gehel, Th3d3v1ls, EBjune, merbst, Avner, Zppix, debt, D3r1ck01, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T152644: rack/setup/install wdqs2003
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T152644EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Gehel, gerritbotCc: gerritbot, Southparkfan, Smalyshev, Aklapper, Deskana, mark, emailbot, Papaul, Cmjohnson, RobH, Gehel, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Avner, Lewizho99, Zppix, Maathavan, debt, D3r1ck01, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T156238: Use HTMLCacheUpdateJob in Cognate extension
gerritbot added a comment. Change 334055 had a related patch set uploaded (by Addshore): Use HTMLCacheUpdateJob internally https://gerrit.wikimedia.org/r/334055TASK DETAILhttps://phabricator.wikimedia.org/T156238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: gerritbot, Lydia_Pintscher, Aklapper, daniel, Addshore, D3r1ck01, Andrew-WMDE, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T156238: Use HTMLCacheUpdateJob in Cognate extension
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T156238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: gerritbot, Lydia_Pintscher, Aklapper, daniel, Addshore, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T156238: Use HTMLCacheUpdateJob in Cognate extension
Addshore added a comment. So, the usage of HTMLCacheUpdateJob would require the pageId, nsId and title dbkey of the title on the remote wiki to be known when constructed. The LocalJobSubmitJob is run on a single wiktionary and fires CacheUpdateJobs out to the other wikis. This means that we can not make a HTMLCacheUpdateJob directly within the LocalJobSubmitJob as we do not know the pageid of the page on the other wiki. Do a lookup of the pageid on the remote wiki within our LocalJobSubmitJob, this seems a bit ugly :/ Keep our CacheUpdateJob (maybe rename it) and make this submit another HTMLCacheUpdateJob. This means there is an extra job in the chain :/ CacheUpdateJob update the page_touched field? This doesn't solve what was mentioned in the review ticket regarding ease of forward compat with core caching Extend HTMLCacheUpdateJob and override the run method and constructor. This would allow us to pass in the title that we know and do the pageid lookup later in the job. Change HTMLCacheUpdateJob to be able to purge titles without requiring the pageid TASK DETAILhttps://phabricator.wikimedia.org/T156238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Lydia_Pintscher, Aklapper, daniel, Addshore, D3r1ck01, Andrew-WMDE, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T154993: Make help portal more prominent
gerritbot added a comment. Change 333581 abandoned by Jonas Kress (WMDE): Replace all links in help menu section with a link to the help portal Reason: Implemented a compromise https://gerrit.wikimedia.org/r/#/c/334048/ https://gerrit.wikimedia.org/r/333581TASK DETAILhttps://phabricator.wikimedia.org/T154993EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Jonas, Lydia_Pintscher, johl, Aklapper, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Avner, Lewizho99, Maathavan, debt, Gehel, D3r1ck01, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T154993: Make help portal more prominent
gerritbot added a comment. Change 334048 had a related patch set uploaded (by Jonas Kress (WMDE)): Make help button a split button dropdown linking to help portal https://gerrit.wikimedia.org/r/334048TASK DETAILhttps://phabricator.wikimedia.org/T154993EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Jonas, Lydia_Pintscher, johl, Aklapper, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Avner, Lewizho99, Maathavan, debt, Gehel, D3r1ck01, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension
gerritbot added a comment. Change 334041 merged by jenkins-bot: Switch to sha256 hash https://gerrit.wikimedia.org/r/334041TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension
gerritbot added a comment. Change 334032 merged by jenkins-bot: Add note about interwiki lang link assumption to README https://gerrit.wikimedia.org/r/334032TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension
gerritbot added a comment. Change 334033 merged by jenkins-bot: Adjust index on pages table https://gerrit.wikimedia.org/r/334033TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension
gerritbot added a comment. Change 334031 merged by jenkins-bot: populateCognatePages use mw db layer for IN query https://gerrit.wikimedia.org/r/334031TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T156241: Deploy Cognate extension to beta
Addshore added a subtask: T149082: Security review for Cognate Extension. TASK DETAILhttps://phabricator.wikimedia.org/T156241EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Lydia_Pintscher, Aklapper, Yair_rand, Meno25, Addshore, Urbanecm, D3r1ck01, Izno, Luke081515, Wikidata-bugs, aude, GPHemsley, Darkdadaah, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Block] T150182: Deploy Cognate extension to production
Addshore created subtask T156241: Deploy Cognate extension to beta. TASK DETAILhttps://phabricator.wikimedia.org/T150182EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Meno25, Yair_rand, Addshore, Aklapper, Lydia_Pintscher, Urbanecm, D3r1ck01, Izno, Luke081515, Wikidata-bugs, aude, GPHemsley, Darkdadaah, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T149082: Security review for Cognate Extension
Addshore added a parent task: T156241: Deploy Cognate extension to beta. TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T156241: Deploy Cognate extension to beta
Addshore created this task.Addshore added projects: Wikimedia-Extension-setup, Wikidata, Wiktionary, Cognate, User-Addshore. TASK DESCRIPTIONTASK DETAILhttps://phabricator.wikimedia.org/T156241EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Lydia_Pintscher, Aklapper, Yair_rand, Meno25, Addshore, Urbanecm, D3r1ck01, Izno, Luke081515, Wikidata-bugs, aude, GPHemsley, Darkdadaah, Mbch331, Jay8g, Krenair, MarcoAurelio___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T151976: [RFC] Do we want a namespaces setting in the InterwikiSorting extension to enable sorting for only some namespaces?
Addshore closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T151976EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: thiemowmde, gerritbot, Lydia_Pintscher, aude, Aklapper, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T156128: Do not use wgInterwikiSortingAlwaysSort in WikibaseClient
Addshore closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T156128EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, Addshore, Aklapper, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, Izno, Wikidata-bugs, aude, ArielGlenn, Mbch331, Jay8g, greg, mmodell___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T156240: Stop writes on hash conflicts & log that they occour
Addshore claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T156240EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Lydia_Pintscher, Aklapper, daniel, gerritbot, Addshore, D3r1ck01, Andrew-WMDE, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension
Addshore added a comment. Everything from the security review now either has a patch linked to this ticket or a subtask has been created. In response to the issue with hash conflicts, pages that create duplicate hashes will simply not be written to the database / ignored, thus it should not be an attack vector in terms of vandalism. I have created a sub task to confirm this, and add some logging when conflicts do happen (if they do) and add some extra testing in the area.TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T156240: Stop writes on hash conflicts & log that they occour
Addshore created this task.Addshore added projects: Cognate, Wikidata, User-Addshore, WMDE-QWERTY-Team-Board. TASK DESCRIPTIONTASK DETAILhttps://phabricator.wikimedia.org/T156240EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Lydia_Pintscher, Aklapper, daniel, gerritbot, Addshore, D3r1ck01, Andrew-WMDE, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Block] T149082: Security review for Cognate Extension
Addshore created subtask T156240: Stop writes on hash conflicts & log that they occour. TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Block] T149082: Security review for Cognate Extension
Addshore created subtask T156239: Cognate - Make PageContentSaveComplete check for redirect state changes & only act when they (or page creation) happens. TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T156239: Cognate - Make PageContentSaveComplete check for redirect state changes & only act when they (or page creation) happens
Addshore created this task.Addshore added projects: Cognate, Wikidata, User-Addshore, WMDE-QWERTY-Team-Board. TASK DESCRIPTIONTASK DETAILhttps://phabricator.wikimedia.org/T156239EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Lydia_Pintscher, Aklapper, daniel, gerritbot, Addshore, D3r1ck01, Andrew-WMDE, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T156238: Use HTMLCacheUpdateJob in Cognate extension
Addshore created this task.Addshore added projects: Cognate, Wikidata, User-Addshore, WMDE-QWERTY-Team-Board. TASK DESCRIPTIONTASK DETAILhttps://phabricator.wikimedia.org/T156238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Lydia_Pintscher, Aklapper, daniel, Addshore, D3r1ck01, Andrew-WMDE, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Block] T149082: Security review for Cognate Extension
Addshore created subtask T156238: Use HTMLCacheUpdateJob in Cognate extension. TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension
gerritbot added a comment. Change 334041 had a related patch set uploaded (by Addshore): Switch to sha256 hash https://gerrit.wikimedia.org/r/334041TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension
Addshore added a comment. In T149082#2966632, @Bawolff wrote: I assume this is not using the LinkUpdates related hooks because it only wants to deal with new pages not edits (?) However it seems that this still triggers on all edits. Perhaps it should look at the EDIT_NEW flag in the onPageSaveComplete hook to avoid some unnecessary database interaction. Cognate needs to know when pages are edited to determine if the redirect state has changed: redirect -> regular page = needs to be added to the db regular page -> redirect = needs to be removed from the db If I had both the new and the last content then I would be able to check the redirect state of each and only act where needed here. I'll have a further look.TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension
gerritbot added a comment. Change 334033 had a related patch set uploaded (by Addshore): Adjust index on pages table https://gerrit.wikimedia.org/r/334033TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension
gerritbot added a comment. Change 334032 had a related patch set uploaded (by Addshore): Add note about interwiki lang link assumption to README https://gerrit.wikimedia.org/r/334032TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T149082: Security review for Cognate Extension
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension
gerritbot added a comment. Change 334031 had a related patch set uploaded (by Addshore): populateCognatePages use mw db layer for IN query https://gerrit.wikimedia.org/r/334031TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
