[Wikidata-bugs] [Maniphest] [Commented On] T157919: WikibaseMediaInfoHooksTest::testOnImagePageAfterImageLinks failure

2017-02-12 Thread gerritbot
gerritbot added a comment.
Change 337350 had a related patch set uploaded (by Aude):
Call WikibaseEntityNamespaces hook earlier in setup [WIP]

https://gerrit.wikimedia.org/r/337350TASK DETAILhttps://phabricator.wikimedia.org/T157919EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, aude, Aklapper, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Ricordisamoa, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T157919: WikibaseMediaInfoHooksTest::testOnImagePageAfterImageLinks failure

2017-02-12 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T157919EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, aude, Aklapper, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Ricordisamoa, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T157919: WikibaseMediaInfoHooksTest::testOnImagePageAfterImageLinks failure

2017-02-12 Thread gerritbot
gerritbot added a comment.
Change 337349 had a related patch set uploaded (by Aude):
Use extension registration for namespaces

https://gerrit.wikimedia.org/r/337349TASK DETAILhttps://phabricator.wikimedia.org/T157919EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, aude, Aklapper, D3r1ck01, Izno, Wikidata-bugs, Ricordisamoa, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T157919: WikibaseMediaInfoHooksTest::testOnImagePageAfterImageLinks failure

2017-02-12 Thread aude
aude created this task.aude added projects: Wikidata, MediaWiki-extensions-WikibaseMediaInfo.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONHow entityNamespaces and namespace registration in Wikibase (especially, with WikibaseClient enabled) changed in https://gerrit.wikimedia.org/r/#/c/337255/

This causes registration of extra entity namespaces not to work correctly.

Presumably this also affects WikibaseLexeme.

One thing we could do to improve is to define the namespaces in extension registration, instead of onSetupAfterCache hook. We also need to call WikibaseEntityNamespaces hook earlier in setup.

10:08:22 There was 1 failure:
10:08:22 
10:08:22 1) Wikibase\MediaInfo\Tests\MediaWiki\WikibaseMediaInfoHooksTest::testOnImagePageAfterImageLinks
10:08:22 Failed asserting that 'M23" title=":M23">:M23' matches PCRE pattern "@M23.*>MediaInfo:M23@".
10:08:22 
10:08:22 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/WikibaseMediaInfoHooksTest.php:130
10:08:22 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/maintenance/doMaintenance.php:111
10:08:22TASK DETAILhttps://phabricator.wikimedia.org/T157919EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: audeCc: aude, Aklapper, D3r1ck01, Izno, Wikidata-bugs, Ricordisamoa, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T157811: Wikidata reference URIs have become too many to search with WDQS SPARQL

2017-02-12 Thread Smalyshev
Smalyshev added a comment.
I'm not sure what you mean by "proper indexing". If you ask to go through 2.3 millions of items, it's probably going to take time, and applying operations to it is probably not covered by index. I'm not sure maybe something can be done for prefix matches (just guessing), but for operations like "contains" I don't see any way around fetching each item and applying the operation to it.

One alternative for such queries can be using LDF endpoint: https://query.wikidata.org/bigdata/ldf?subject==http%3A%2F%2Fwww.wikidata.org%2Fprop%2Freference%2FP854=
and processing the matches client-side. LDF endpoint is fast, but requires the client to load a lot of data and process it.TASK DETAILhttps://phabricator.wikimedia.org/T157811EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Smalyshev, Aklapper, Jheald, EBjune, merbst, Avner, debt, Gehel, D3r1ck01, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T43103: initialization of the Language object is very heavy

2017-02-12 Thread Fomafix
Fomafix added a comment.
With https://gerrit.wikimedia.org/r/331208 it is suggested to introduce a new PHP class LanguageCode. This class can also take some of the code from the class Language. Maybe the class LanguageCode can be a lightweight part of the class Language with a better performance. Please have a look at this change and suggest what can done as next steps.TASK DETAILhttps://phabricator.wikimedia.org/T43103EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FomafixCc: Liuxinyu970226, Ltrlg, Elitre, Agabi10, adrianheine, gerritbot, Aklapper, Fomafix, Ricordisamoa, Jarekt, Purodha, Logicwiki, tstarling, bzimport, Wikidata-bugs, Amire80, siebrand, jeblad, SPQRobin, jayvdb, Denny, DanielFriesen, wikibugs-l-list, Nikerabbit, daniel, Th3d3v1ls, Ramalepe, Liugev6, Vali.matei, Lewizho99, Maathavan, MuhammadShuaib, Psychoslave, GWicke, Gryllida, Shizhao, Arrbee, KartikMistry, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T153439: Sunset of WDQ

2017-02-12 Thread Multichill
Multichill added a comment.

In T153439#3016412, @Magnus wrote:
OK, so I couldn't get it to work again easily. WDQ been broken for weeks now, and I had exactly one single person ask about it, but I could successfully upgrade them to SPARQL.

Maybe we could just officially retire WDQ now?


I agree. We've been gentle, people know that they should use sparql. Let's do the clean up. Would you agree to have http://wdq.wmflabs.org/ 301 -> https://query.wikidata.org/ ?

Can you do T153442 Magnus? I'll have a look at Pywikibot and do some clean up on Wikidata.TASK DETAILhttps://phabricator.wikimedia.org/T153439EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MultichillCc: Smalyshev, Lokal_Profil, Ricordisamoa, Lea_Lacroix_WMDE, yuvipanda, Multichill, Magnus, Aklapper, EBjune, Tbscho, merbst, Avner, debt, Gehel, D3r1ck01, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Gryllida, scfc, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T157363: Implement DispatchingEntityInfoBuilder for bulk queries across multiple repos.

2017-02-12 Thread gerritbot
gerritbot added a comment.
Change 337272 had a related patch set uploaded (by WMDE-leszek):
Provide EntityInfoBuilderFactory in EntityDataRetrievalServiceFactory

https://gerrit.wikimedia.org/r/337272TASK DETAILhttps://phabricator.wikimedia.org/T157363EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, gerritbotCc: gerritbot, WMDE-leszek, Lydia_Pintscher, Aklapper, daniel, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T157363: Implement DispatchingEntityInfoBuilder for bulk queries across multiple repos.

2017-02-12 Thread gerritbot
gerritbot added a comment.
Change 337271 had a related patch set uploaded (by WMDE-leszek):
Introduce DispatchingEntityInfoBuilderFactory

https://gerrit.wikimedia.org/r/337271TASK DETAILhttps://phabricator.wikimedia.org/T157363EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, gerritbotCc: gerritbot, WMDE-leszek, Lydia_Pintscher, Aklapper, daniel, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T157363: Implement DispatchingEntityInfoBuilder for bulk queries across multiple repos.

2017-02-12 Thread gerritbot
gerritbot added a comment.
Change 337270 had a related patch set uploaded (by WMDE-leszek):
Introduce DispatchingEntityInfoBuilder

https://gerrit.wikimedia.org/r/337270TASK DETAILhttps://phabricator.wikimedia.org/T157363EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, gerritbotCc: gerritbot, WMDE-leszek, Lydia_Pintscher, Aklapper, daniel, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T157363: Implement DispatchingEntityInfoBuilder for bulk queries across multiple repos.

2017-02-12 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T157363EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, gerritbotCc: gerritbot, WMDE-leszek, Lydia_Pintscher, Aklapper, daniel, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T103676: Wikidata changes in watchlist on client showed wrong links

2017-02-12 Thread Aschroet
Aschroet added a comment.
Just a statement: When making Wikidata as a central hub for data it should at least guaranteed that the observation of changes are properly displayed. That is why I would recommend to work on this issueTASK DETAILhttps://phabricator.wikimedia.org/T103676EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AschroetCc: Aschroet, Ricordisamoa, Lydia_Pintscher, Bene, matej_suchanek, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T157811: Wikidata reference URIs have become too many to search with WDQS SPARQL

2017-02-12 Thread Jheald
Jheald added a comment.
For comparison, in September 2015 there were 376,524 references using P:854, and a query to search them could complete in 3.7 seconds -- it was used as an example on the query optimisation page.  Such a query now times out.

It should be possible for such a search to be very efficient with proper indexing on the values of P:854.  But is such indexing being sidelined by the cast to string from URL type?  Would it make sense to hold URLs in both URL and string form, to make indexing more possible?TASK DETAILhttps://phabricator.wikimedia.org/T157811EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JhealdCc: Aklapper, Jheald, EBjune, merbst, Avner, debt, Gehel, D3r1ck01, Jonas, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs