[Wikidata-bugs] [Maniphest] [Updated] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred

2017-02-23 Thread gerritbot 
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, Krinkle, Th3d3v1ls, Ramalepe, Liugev6, enigmaeth, rohitt, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred

2017-02-23 Thread gerritbot 
gerritbot added a comment.
Change 323445 had a related patch set uploaded (by Krinkle):
Don't assume synchronous jQuery.Deferred in QUnit tests

https://gerrit.wikimedia.org/r/323445TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, Krinkle, enigmaeth, rohitt, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred

2017-02-23 Thread Krinkle 
Krinkle created this task.Krinkle added projects: _javascript_, Wikibase-DataModel-_javascript_, Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONDraft change with details at https://gerrit.wikimedia.org/r/323445/.

Each QUnit test should either return a Promise to QUnit.test (which QUnit will automatically wait for and also report a test failure if the Promise is rejected), or manually use assert.async() where needed.

Examples:

QUnit.test( 'example should pass', function ( assert ) {
  return something().then( function ( val ) {
assert.equals( val, 'expected' );
  } );
} );

QUnit.test( 'example should fail', function ( assert ) {
  var done = assert.async();
  something().fail( function ( val ) {
assert.equals( val, 'error message' );
  } ).always( done );
} );

This is in preparation for jQuery 3.0, where $.Deferred callbacks are processed asynchronously. https://jquery.com/upgrade-guide/3.0/

Failures can be seen at the pending core patch: https://gerrit.wikimedia.org/r/322812/.TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Krinkle, enigmaeth, rohitt, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T158912: Inject RemoveReferences dependencies

2017-02-23 Thread gerritbot 
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T158912EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, Aklapper, Ladsgroup, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158912: Inject RemoveReferences dependencies

2017-02-23 Thread gerritbot 
gerritbot added a comment.
Change 339553 had a related patch set uploaded (by Ladsgroup):
Inject RemoveReferences dependencies

https://gerrit.wikimedia.org/r/339553TASK DETAILhttps://phabricator.wikimedia.org/T158912EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, Aklapper, Ladsgroup, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Block] T158705: Inject dependencies in Wikibase API modules and special pages

2017-02-23 Thread Ladsgroup 
Ladsgroup created subtask T158912: Inject RemoveReferences dependencies.
TASK DETAILhttps://phabricator.wikimedia.org/T158705EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Aklapper, Ladsgroup, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T113573: [Bug] PHP and JS disagree about which languages I'm interested in

2017-02-23 Thread matej_suchanek 
matej_suchanek added a parent task: T124286: [Epic] Wikidata language support.
TASK DETAILhttps://phabricator.wikimedia.org/T113573EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: Jonas, thiemowmde, hoo, Bene, Aklapper, adrianheine, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T62097: no.wikisource language issue

2017-02-23 Thread matej_suchanek 
matej_suchanek added a parent task: T124286: [Epic] Wikidata language support.
TASK DETAILhttps://phabricator.wikimedia.org/T62097EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: jayvdb, Aklapper, Amire80, siebrand, JanZerebecki, aude, matej_suchanek, Ricordisamoa, Lydia_Pintscher, D3r1ck01, Samwilson, Izno, Wikidata-bugs, Shizhao, Billinghurst, Mbch331, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T124286: [Epic] Wikidata language support

2017-02-23 Thread matej_suchanek 
matej_suchanek added subtasks: T151269: Add English names for languages which don't yet have one, T121747: Serbian language does not appear for people from Serbia, T62097: no.wikisource language issue, T113573: [Bug] PHP and JS disagree about which languages I'm interested in, T134592: Allow setting the UI to a language other than English for anonymous users.
TASK DETAILhttps://phabricator.wikimedia.org/T124286EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: Liuxinyu970226, Ricordisamoa, adrianheine, Aklapper, D3r1ck01, MuhammadShuaib, Izno, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T121747: Serbian language does not appear for people from Serbia

2017-02-23 Thread matej_suchanek 
matej_suchanek added a parent task: T124286: [Epic] Wikidata language support.
TASK DETAILhttps://phabricator.wikimedia.org/T121747EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: adrianheine, Nikerabbit, Lydia_Pintscher, Nemo_bis, Aklapper, Nikola_Smolenski, StudiesWorld, D3r1ck01, MuhammadShuaib, Izno, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, santhosh, KartikMistry, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T158634: Apihelp-wbmergeitems-param-ignoreconflicts needs some polish

2017-02-23 Thread Lydia_Pintscher 
Lydia_Pintscher closed this task as "Resolved".Lydia_Pintscher claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T158634EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: gerritbot, Aklapper, Amire80, TerraCodes, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, Lewizho99, Maathavan, DatGuy, Abbe98, D3r1ck01, MuhammadShuaib, Izno, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T153896: Make a poll to identify the initial list of federated endpoints

2017-02-23 Thread Lydia_Pintscher 
Lydia_Pintscher closed this task as "Resolved".Lydia_Pintscher added a comment.
https://www.wikidata.org/wiki/Wikidata:SPARQL_federation_inputTASK DETAILhttps://phabricator.wikimedia.org/T153896EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lea_Lacroix_WMDE, Lydia_PintscherCc: Lydia_Pintscher, Tarrow, Lea_Lacroix_WMDE, Deskana, Ckoerner, Aklapper, Smalyshev, EBjune, merbst, Avner, debt, Gehel, D3r1ck01, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unblock] T153893: [EPIC] Support limited federation for WDQS

2017-02-23 Thread Lydia_Pintscher 
Lydia_Pintscher closed subtask T153896: Make a poll to identify the initial list of federated endpoints as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T153893EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, Lydia_PintscherCc: Harej, Tarrow, Aklapper, Smalyshev, EBjune, merbst, Avner, debt, Gehel, D3r1ck01, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T158849: Configure geo-shapes to be not enabled yet on Wikidata

2017-02-23 Thread aude 
aude edited the task description. (Show Details)
EDIT DETAILS...Also, we would want wikipedias to be able to handle geo-shapes soon as it is enabled, even though they don't get new code the same day as Wikidata. Best way is to have the code there one deployment cycle before enabling new data type.

See also: https://www.wikidata.org/wiki/Wikidata:Stable_Interface_PolicyTASK DETAILhttps://phabricator.wikimedia.org/T158849EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: audeCc: gerritbot, aude, Aklapper, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T158874: wdqs replication lagging behind on some nodes

2017-02-23 Thread Gehel 
Gehel created this task.Gehel added projects: Wikidata-Query-Service, Discovery-Search.Herald added a subscriber: Aklapper.Herald added projects: Wikidata, Discovery.
TASK DESCRIPTIONIn the last few days, we've have 3 instances of wdqs-updater lagging behind on some nodes (but not all). It looks like replication stopped for some time and then restarted and took some time to catch up.

The fact that not all nodes stopped at the same time indicates that the problem is internal to wdqs.TASK DETAILhttps://phabricator.wikimedia.org/T158874EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: GehelCc: Smalyshev, Gehel, Aklapper, EBjune, merbst, Avner, debt, D3r1ck01, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T158849: Configure geo-shapes to be not enabled yet on Wikidata

2017-02-23 Thread gerritbot 
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T158849EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, aude, Aklapper, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158866: Add documentation for geo-shape datatype on Special:ListDatatypes

2017-02-23 Thread gerritbot 
gerritbot added a comment.
Change 339437 had a related patch set uploaded (by Aude):
Add Special:ListDatatypes documentation for geo-shape data type

https://gerrit.wikimedia.org/r/339437TASK DETAILhttps://phabricator.wikimedia.org/T158866EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, aude, Aklapper, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T158866: Add documentation for geo-shape datatype on Special:ListDatatypes

2017-02-23 Thread gerritbot 
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T158866EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, aude, Aklapper, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T57549: [Story] Add a new datatype for geoshapes

2017-02-23 Thread aude 
aude added a subtask: T158866: Add documentation for geo-shape datatype on Special:ListDatatypes.
TASK DETAILhttps://phabricator.wikimedia.org/T57549EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, audeCc: Pasleim, LikeLifer, jmac, TheDJ, Jonas, Micru, gerritbot, mxn, Yurik, abian, Evad37, Abbe98, daniel, RolandUnger, Boshomi, Susannaanas, Christopher, Yair_rand, Kopiersperre, putnik, StudiesWorld, esbranson, DixonD, Aklapper, Sannita, Ricordisamoa, Cavila, Rits, Kolossos, El_Grafo, Wikidata-bugs, Tobias1984, aude, Rschen7754, Liuxinyu970226, Ainali, Lydia_Pintscher, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T158866: Add documentation for geo-shape datatype on Special:ListDatatypes

2017-02-23 Thread aude 
aude added a parent task: T57549: [Story] Add a new datatype for geoshapes.
TASK DETAILhttps://phabricator.wikimedia.org/T158866EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: audeCc: aude, Aklapper, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T158866: Add documentation for geo-shape datatype on Special:ListDatatypes

2017-02-23 Thread aude 
aude created this task.aude added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONWe need to add documentation for the geo-shape datatype on Special:ListDatatypes.

i18n messages need to be added that explain what the data type is:

https://www.wikidata.org/wiki/Special:ListDatatypesTASK DETAILhttps://phabricator.wikimedia.org/T158866EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: audeCc: aude, Aklapper, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T48248: [Story] Use HTMLForm in the special pages

2017-02-23 Thread gerritbot 
gerritbot added a comment.
Change 339432 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fixups to OOUI conversion of SpecialModifyEntity and subclasses

https://gerrit.wikimedia.org/r/339432TASK DETAILhttps://phabricator.wikimedia.org/T48248EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ricordisamoa, gerritbotCc: Liuxinyu970226, LikeLifer, matej_suchanek, Sjoerddebruin, gerritbot, Ricordisamoa, Aklapper, Wikidata-bugs, Bene, jeblad, thiemowmde, JanZerebecki, Lydia_Pintscher, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, Jan_Dittrich, Lewizho99, Maathavan, SamanthaNguyen, Iniquity, JGirault, D3r1ck01, Volker_E, Izno, Psychoslave, aude, TheDJ, Ladsgroup, Mbch331, Jay8g, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Claimed] T148184: Suggest new statements at the top of the page

2017-02-23 Thread Kiailandi 
Kiailandi claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T148184EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KiailandiCc: Kiailandi, Hjfocs, Glorian_Yapinus, Aklapper, dachary, D3r1ck01, Izno, Wikidata-bugs, aude, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158674: Fatal error: Call to undefined function Wikibase\Client\Tests\RecentChanges\both() - on jenkins

2017-02-23 Thread gerritbot 
gerritbot added a comment.
Change 339051 abandoned by Hashar:
Capture composer.lock after mw-fetch-composer-dev

Reason:
The script knows about LOG_DIR , so I will archive the files directly from it in https://gerrit.wikimedia.org/r/#/c/339202/

https://gerrit.wikimedia.org/r/339051TASK DETAILhttps://phabricator.wikimedia.org/T158674EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, hashar, Addshore, Aleksey_WMDE, aude, Aklapper, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T158430: [Spike] Use suggested properties to get signal for completeness

2017-02-23 Thread Halfak 
Halfak edited projects, added Revision-Scoring-As-A-Service; removed Revision-Scoring-As-A-Service-Backlog.
TASK DETAILhttps://phabricator.wikimedia.org/T158430EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Glorian_WD, HalfakCc: Sjoerddebruin, Ladsgroup, Glorian_Yapinus, Sumit, Ricordisamoa, Aklapper, StudiesWorld, Lydia_Pintscher, samuwmde, Glorian_WD, Halfak, Avner, JJMC89, D3r1ck01, Izno, Wikidata-bugs, aude, He7d3r, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T111231: [Story] Take Hovercards out of beta features on Wikidata

2017-02-23 Thread Ricordisamoa 
Ricordisamoa added a subscriber: Jdlrobson.Ricordisamoa added a comment.

In T111231#3048738, @Liuxinyu970226 wrote:
Can someone tell me what happened today? It's now always "Looks like there isn't a preview for this page" on any item links


https://www.wikidata.org/wiki/MediaWiki_talk:Gadget-PopupsFix.js @JdlrobsonTASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: RicordisamoaCc: Jdlrobson, Liuxinyu970226, Ckoerner, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, Winter, D3r1ck01, Izno, Wikidata-bugs, aude, Shizhao, Se4598, Jdforrester-WMF, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T158025: Support ORES for propagated Wikidata edits

2017-02-23 Thread Halfak 
Halfak edited projects, added Revision-Scoring-As-A-Service; removed Revision-Scoring-As-A-Service-Backlog.
TASK DETAILhttps://phabricator.wikimedia.org/T158025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HalfakCc: jmatazzoni, Aklapper, Mattflaschen-WMF, Avner, JJMC89, D3r1ck01, Izno, Wikidata-bugs, aude, Catrope, He7d3r, Ladsgroup, Mbch331, tarlocesilion, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158674: Fatal error: Call to undefined function Wikibase\Client\Tests\RecentChanges\both() - on jenkins

2017-02-23 Thread hashar 
hashar added a comment.
So I don't think the PHP namespace lookup works for static methods. Eg both() would not end up being resolved as \HamCrest\Matchers::both().  A lame test case:

A namespaced class definition:


namespace namespaced {
class StaticClass {
public static function hello() {
return "Hello";
}
}
}

Script using it:


use namespaced\StaticClass;

spl_autoload_register( function () { 
include 'namespaced.php';
} );

print "namespaced\StaticClass::hello():\n";
print ">>> " . namespaced\StaticClass::hello() . "\n";  // works
print "hello():\n";
print ">>> " . hello() . "\n";  // Call to undefined function hello() 

Output with PHP 5.6.29:

$ php exec.php
namespaced\StaticClass::hello():
>>> Hello
hello():
PHP Fatal error:  Call to undefined function hello() in /tmp/exec.php on line 11
PHP Stack trace:
PHP   1. {main}() /tmp/exec.php:0

Fatal error: Call to undefined function hello() in /tmp/exec.php on line 11

Call Stack:
0.0002 231576   1. {main}() /tmp/exec.php:0

That might why Hamcrest has a Hamcrest\Util::registerGlobalFunctions();: which include a file defining a set of global functions which in turns invoke the static method using the full canonical path. Extracted from the file:

vendor/hamcrest/hamcrest-php/hamcrest/Hamcrest.php
if (!function_exists('both')) {
function both(\Hamcrest\Matcher $matcher)
{
return \Hamcrest\Core\CombinableMatcher::both($matcher);
}
}

So potentially in our tests, we can explicitly register the global functions using:

\Hamcrest\Util::registerGlobalFunctions();:

And can then use both().

Which works around the following PHP code that fails to lookup up the both() static method:

use Hamcrest\Matchers;
both();  // failsTASK DETAILhttps://phabricator.wikimedia.org/T158674EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: gerritbot, hashar, Addshore, Aleksey_WMDE, aude, Aklapper, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T158674: Fatal error: Call to undefined function Wikibase\Client\Tests\RecentChanges\both() - on jenkins

2017-02-23 Thread hashar 
hashar edited the task description. (Show Details)
EDIT DETAILS...===

One has to explicitly register them with `Hamcrest\Util::registerGlobalFunctions();`:
```


#use Hamcrest\Matchers;
lang=php

Hamcrest\Util::registerGlobalFunctions();
class BlaTest extends MediaWikiTestCase {

function testHamcrest() {
assertThat();
#\Hamcrest\Matchers::both();
both();
}

}...TASK DETAILhttps://phabricator.wikimedia.org/T158674EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: gerritbot, hashar, Addshore, Aleksey_WMDE, aude, Aklapper, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T158674: Fatal error: Call to undefined function Wikibase\Client\Tests\RecentChanges\both() - on jenkins

2017-02-23 Thread hashar 
hashar edited the task description. (Show Details)
EDIT DETAILS...```

Case that works


Instead of trying to lookup the static method via namespace, if we refer to the canonical class path it seems to work:
```
lang=php

class CanonicalPathTest extends MediaWikiTestCase {

function testHamcrest() {
\Hamcrest\Matchers::both();
}
}
```

Global functions
===
```


#use Hamcrest\Matchers;

Hamcrest\Util::registerGlobalFunctions();
class BlaTest extends MediaWikiTestCase {

function testHamcrest() {
assertThat();
#\Hamcrest\Matchers::both();
both();
}

}
```

Other findings...TASK DETAILhttps://phabricator.wikimedia.org/T158674EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: gerritbot, hashar, Addshore, Aleksey_WMDE, aude, Aklapper, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T157050: selenium-Wikibase Jenkins job fails with MediawikiApi::ApiError for 7 days in a row

2017-02-23 Thread zeljkofilipin 
zeljkofilipin closed this task as "Resolved".zeljkofilipin claimed this task.zeljkofilipin added a comment.
The problem is resolved. Please reopen if needed.TASK DETAILhttps://phabricator.wikimedia.org/T157050EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: WMDE-leszek, Aleksey_WMDE, gerritbot, Jonas, thiemowmde, daniel, Addshore, Lydia_Pintscher, aude, hoo, Tobi_WMDE_SW, Aklapper, zeljkofilipin, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T158674: Fatal error: Call to undefined function Wikibase\Client\Tests\RecentChanges\both() - on jenkins

2017-02-23 Thread hashar 
hashar edited the task description. (Show Details)
EDIT DETAILS...use Hamcrest\Matchers;...TASK DETAILhttps://phabricator.wikimedia.org/T158674EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: gerritbot, hashar, Addshore, Aleksey_WMDE, aude, Aklapper, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T158674: Fatal error: Call to undefined function Wikibase\Client\Tests\RecentChanges\both() - on jenkins

2017-02-23 Thread hashar 
hashar edited the task description. (Show Details)
EDIT DETAILS...```


Other findings
==

vendor/composer/autoload_files.php refers to `$vendorDir . '/mediawiki/at-ease/src/Functions.php'`.  That is because at-ease composer.json has:
```
lang=json
"autoload": {
"files": [
"src/Functions.php"
]
}
```TASK DETAILhttps://phabricator.wikimedia.org/T158674EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: gerritbot, hashar, Addshore, Aleksey_WMDE, aude, Aklapper, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unblock] T158705: Inject dependencies in Wikibase API modules and special pages

2017-02-23 Thread WMDE-leszek 
WMDE-leszek closed subtask T158790: Inject SetClaim dependencies as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T158705EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, WMDE-leszekCc: Aklapper, Ladsgroup, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T158674: Fatal error: Call to undefined function Wikibase\Client\Tests\RecentChanges\both() - on jenkins

2017-02-23 Thread hashar 
hashar edited the task description. (Show Details)
EDIT DETAILS...vendor/composer/autoload_files.php and or composer.lock might end up missing them though :(


Reproduction
=

mediawiki/core
mediawiki/vendor cloned in the `vendor` subdirectory
integration/jenkins

The CI script mw-composer-fetch-dev.sh grabs the list of packages from require-dev and then require them in the `vendor` subdirectory.

The dev dependencies:
```
(cd vendor; ~/projects/integration/jenkins/tools/composer-dev-args.js ~/projects/mediawiki/core/composer.json)
/Users/amusso/projects/mediawiki/core/vendor
composer/spdx-licenses=1.1.4
jakub-onderka/php-parallel-lint=0.9.2
justinrainbow/json-schema=~3.0
mediawiki/mediawiki-codesniffer=0.7.2
jetbrains/phpstorm-stubs=dev-master#1b9906084d6635456fcf3f3a01f0d7d5b99a578a
monolog/monolog=~1.18.2
nikic/php-parser=2.1.0
nmred/kafka-php=0.1.5
phpunit/phpunit=4.8.31
wikimedia/avro=1.7.7
hamcrest/hamcrest-php=^2.0
wmde/hamcrest-html-matchers=^0.1.0
```

For each we invoke `composer require --dev --ansi --no-progress --prefer-dist -v` . The result is available as  https://gerrit.wikimedia.org/r/339404

Then `(cd vendor && composer dump-autoload --optimize)` which apparently is a noop.


Given a dummy test file:
```
lang=php, name=tests/phpunit/BlaTest.php


use Hamcrest\Matcher;

class BlaTest extends MediaWikiTestCase {

function testHamcrest() {
both();
}

}
```

That fails to load one of Hamcrest function:
```
$ php tests/phpunit/phpunit.php tests/phpunit/BlaTest.php
PHPUnit 4.8.31 by Sebastian Bergmann and contributors.

PHP Fatal error:  Call to undefined function both() in /Users/amusso/projects/mediawiki/core/tests/phpunit/BlaTest.php on line 8
```


TASK DETAILhttps://phabricator.wikimedia.org/T158674EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: gerritbot, hashar, Addshore, Aleksey_WMDE, aude, Aklapper, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T154601: Grafana: "wikidata-datamodel-terms" doesn't update anymore

2017-02-23 Thread Addshore 
Addshore removed a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T154601EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, Addshore, Sjoerddebruin, Aklapper, D3r1ck01, Andrew-WMDE, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T141080: Wikidata items with two coordinates do not show up in geosearch

2017-02-23 Thread JeanFred 
JeanFred added a comment.
Looks like there are potentially 24.408 such items on Wikidata − although some of that would have a preferred qualifier. Would someone with better SPARQL-fu would be able to do the counts with that in mind?TASK DETAILhttps://phabricator.wikimedia.org/T141080EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JeanFredCc: JeanFred, Braveheart, edwardbetts, Sjoerddebruin, Aklapper, simon04, D3r1ck01, Izno, Wikidata-bugs, aude, MaxSem, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T158851: Add a direct link to the editing interface of Wikidata

2017-02-23 Thread Strainu 
Strainu created this task.Strainu added a project: Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONIt would be useful, for the users of [[Module:EditAtWikidata]], to have a way to link directly to the wikidata editor. Given a Q and a P, it should redirect to the interface allowing the user to add a new property (if P does not exist yet) or to add a new value for P (if it exists).TASK DETAILhttps://phabricator.wikimedia.org/T158851EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: StrainuCc: Aklapper, Strainu, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T158849: Configure geo-shapes to be not enabled yet on Wikidata

2017-02-23 Thread aude 
aude created this task.aude added a project: Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONWe will need a time period, after some announcement, for people to test the new geo-shapes data type (e.g. on test.wikidata) and for people to adapt their tools (e.g. pywikibot, wikidata toolkit).

Also, we would want wikipedias to be able to handle geo-shapes soon as it is enabled, even though they don't get new code the same day as Wikidata. Best way is to have the code there one deployment cycle before enabling new data type.TASK DETAILhttps://phabricator.wikimedia.org/T158849EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: audeCc: aude, Aklapper, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T158847: Use of EntityRevisionLookup (and other services) from client in the repo may be problematic

2017-02-23 Thread aude 
aude created this task.aude added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONSeems we are now using some services from the client in the repo, due to how the factories and stuff are instantiated.

For EntityRevisionLookup, we have this (with ForbiddenSerializer used in EntityContentDataCodec):

I think the serializer in EntityContentDataCodec might be there to support the old internal serialization format (which exists for entities not edited for a long time, or for old revisions and might be needed for dump generation) and think we still need it.

I am concerned that whatever it does might (silently or in subtle ways) break and that we should be careful about using client services in the repo.

	'EntityRevisionLookup' => function(
		RepositoryServiceContainer $services,
		WikibaseClient $client
	) {
		$codec = new EntityContentDataCodec(
			$services->getEntityIdParser(),
			new ForbiddenSerializer( 'Entity serialization is not supported on the client!' ),
			$services->getEntityDeserializer(),
			$client->getSettings()->getSetting( 'maxSerializedEntitySize' ) * 1024
		);

		/** @var WikiPageEntityMetaDataAccessor $metaDataAccessor */
		$metaDataAccessor = $services->getService( 'WikiPageEntityMetaDataAccessor' );

		return new WikiPageEntityRevisionLookup(
			$codec,
			$metaDataAccessor,
			$services->getDatabaseName()
		);
	},TASK DETAILhttps://phabricator.wikimedia.org/T158847EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: audeCc: aude, Aklapper, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T158842: Update wording re associated Wikidata item following move

2017-02-23 Thread Billinghurst 
Billinghurst created this task.Billinghurst added a project: Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONAt English Wikisource when a page is moved part of the message is

You should also update **the associated Wikidata item** to maintain language links on moved page.

(component in asterisks is a link to WD item)

and this component is added by the system.  With how the system has been updated, when moves are undertaken there is the update taking place at Wikidata under the account of the person undertaking the move.

Can the text be updated to better reflect today's reality?  I was thinking something like ...

Your move should now be **updated in the Wikidata item** language link, we ask that you confirm this has occurred.

Thanks for your consideration.TASK DETAILhttps://phabricator.wikimedia.org/T158842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BillinghurstCc: Aklapper, Billinghurst, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T157466: See meta name="description" on article placeholders

2017-02-23 Thread hoo 
hoo added a comment.
Relevant research (for humans only, though): https://arxiv.org/pdf/1702.06235.pdfTASK DETAILhttps://phabricator.wikimedia.org/T157466EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: Aklapper, Lydia_Pintscher, Lucie, daniel, hoo, D3r1ck01, Izno, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T69434: [Task] Make Hovercards work on Wikidata item links

2017-02-23 Thread Trizek-WMF 
Trizek-WMF added a comment.
New feedback from a user, confused by Hovercards behavior.TASK DETAILhttps://phabricator.wikimedia.org/T69434EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Bene, Trizek-WMFCc: Trizek-WMF, Jdlrobson, Bdjwiki, gerritbot, pizzzacat, Quiddity, Raymond, Bene, Ricordisamoa, SamB, Aklapper, Se4598, JanZerebecki, Wikidata-bugs, Jdforrester-WMF, Vibhabamba, Liuxinyu970226, Lydia_Pintscher, hoo, JakeTheDeveloper, Winter, D3r1ck01, Izno, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T154288: Factor ChangeOps instantiation logic out of Api\EditEntity

2017-02-23 Thread gerritbot 
gerritbot added a comment.
Change 334148 had a related patch set uploaded (by WMDE-leszek):
Add ChangeOpDeserializer for properties

https://gerrit.wikimedia.org/r/334148TASK DETAILhttps://phabricator.wikimedia.org/T154288EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: Ricordisamoa, gerritbot, daniel, Ladsgroup, Addshore, Aklapper, Jakob_WMDE, WMDE-leszek, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158790: Inject SetClaim dependencies

2017-02-23 Thread gerritbot 
gerritbot added a comment.
Change 339232 merged by jenkins-bot:
Inject SetClaim dependencies

https://gerrit.wikimedia.org/r/339232TASK DETAILhttps://phabricator.wikimedia.org/T158790EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, Aklapper, Ladsgroup, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs