[Wikidata-bugs] [Maniphest] [Closed] T149945: Use something better than FingerprintHolder for Lexeme

2017-02-26 Thread thiemowmde
thiemowmde closed this task as "Resolved".thiemowmde moved this task from Review to Done on the Wikidata-Sprint board.thiemowmde triaged this task as "Normal" priority.thiemowmde edited projects, added Lexicographical data; removed Patch-For-Review.Herald added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T149945WORKBOARDhttps://phabricator.wikimedia.org/project/board/2351/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, thiemowmdeCc: thiemowmde, gerritbot, daniel, Aklapper, Ladsgroup, D3r1ck01, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-26 Thread thiemowmde
thiemowmde added a comment.
I just checked again (as I already did dozens of times in the pasts months) and found that the biggest remaining issues are:


https://gerrit.wikimedia.org/r/337849 not merged after almost 2 weeks.
EntityRetrievingTermLookup still binds against FingerprintProvider instead of individual Labels/Descriptions/AliasesProvider.
TASK DETAILhttps://phabricator.wikimedia.org/T134735EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Aleksey_WMDE, Addshore, Ricordisamoa, gerritbot, Jonas, Tobi_WMDE_SW, hoo, daniel, Lydia_Pintscher, aude, JanZerebecki, adrianheine, Bene, Aklapper, thiemowmde, Zppix, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-26 Thread thiemowmde
thiemowmde edited the task description. (Show Details)
EDIT DETAILSThis is an issue mostly in tests, but also in some production code, e.g. search handler hooks, history actions and so on. Code gets an Entity(Document) and calls `getFingerprint` without checking if the entity supports this.

#patch-for-review:
* [x] https://gerrit.wikimedia.org/r/287580
* [x] https://gerrit.wikimedia.org/r/290461
* [x] https://gerrit.wikimedia.org/r/290900
* [x] https://gerrit.wikimedia.org/r/335463
* [x] https://gerrit.wikimedia.org/r/335464
* [x] https://gerrit.wikimedia.org/r/335614
* [x] https://gerrit.wikimedia.org/r/335615
* [x] https://gerrit.wikimedia.org/r/335617
* [ ] https://gerrit.wikimedia.org/r/337849
* [x] https://gerrit.wikimedia.org/r/339912TASK DETAILhttps://phabricator.wikimedia.org/T134735EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Aleksey_WMDE, Addshore, Ricordisamoa, gerritbot, Jonas, Tobi_WMDE_SW, hoo, daniel, Lydia_Pintscher, aude, JanZerebecki, adrianheine, Bene, Aklapper, thiemowmde, Zppix, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T149945: Use something better than FingerprintHolder for Lexeme

2017-02-26 Thread gerritbot
gerritbot added a comment.
Change 339912 merged by jenkins-bot:
Remove Fingerprint from the backend

https://gerrit.wikimedia.org/r/339912TASK DETAILhttps://phabricator.wikimedia.org/T149945EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: thiemowmde, gerritbot, daniel, Aklapper, Ladsgroup, D3r1ck01, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-26 Thread gerritbot
gerritbot added a comment.
Change 339912 merged by jenkins-bot:
Remove Fingerprint from the backend

https://gerrit.wikimedia.org/r/339912TASK DETAILhttps://phabricator.wikimedia.org/T134735EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, gerritbotCc: Aleksey_WMDE, Addshore, Ricordisamoa, gerritbot, Jonas, Tobi_WMDE_SW, hoo, daniel, Lydia_Pintscher, aude, JanZerebecki, adrianheine, Bene, Aklapper, thiemowmde, Zppix, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T132937: There should be a maintenance script to add sites to the sites table

2017-02-26 Thread thiemowmde
thiemowmde edited projects, added Wikidata-Sprint, Wikidata; removed Patch-For-Review.thiemowmde triaged this task as "Normal" priority.thiemowmde closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T132937EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Florian, thiemowmdeCc: thiemowmde, hoo, aude, gerritbot, Aklapper, Florian, D3r1ck01, Izno, Wikidata-bugs, Mbch331, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T132937: There should be a maintenance script to add sites to the sites table

2017-02-26 Thread gerritbot
gerritbot added a comment.
Change 284005 merged by jenkins-bot:
Add maintenance script to add sites to sites table

https://gerrit.wikimedia.org/r/284005TASK DETAILhttps://phabricator.wikimedia.org/T132937EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Florian, gerritbotCc: thiemowmde, hoo, aude, gerritbot, Aklapper, Florian, D3r1ck01, Izno, Wikidata-bugs, Mbch331, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T132937: There should be a maintenance script to add sites to the sites table

2017-02-26 Thread ReleaseTaggerBot
ReleaseTaggerBot added projects: MW-1.29-release-notes, WMF-deploy-2017-02-28_(1.29.0-wmf.14).
TASK DETAILhttps://phabricator.wikimedia.org/T132937EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Florian, ReleaseTaggerBotCc: thiemowmde, hoo, aude, gerritbot, Aklapper, Florian, D3r1ck01, Izno, Wikidata-bugs, Mbch331, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T132937: There should be a maintenance script to add sites to the sites table

2017-02-26 Thread Florian
Florian added a comment.
Thanks @thiemowmde for merging! I updated the documentation on: https://www.mediawiki.org/w/index.php?title=Manual:Sites_table&diff=2409116&oldid=2334627

However, we probably should think about adding the functionality to update a site using this maintenance script, too :)TASK DETAILhttps://phabricator.wikimedia.org/T132937EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FlorianCc: thiemowmde, hoo, aude, gerritbot, Aklapper, Florian, D3r1ck01, Izno, Wikidata-bugs, Mbch331, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T90435: [Epic] Wikidata watchlist improvements (client)

2017-02-26 Thread matej_suchanek
matej_suchanek added a subtask: T117738: [Task] Add a mechanism to build interwiki wikitext links across sister projects.
TASK DETAILhttps://phabricator.wikimedia.org/T90435EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: Aschroet, IKhitron, Esh77, TomT0m, Oliv0, abian, Daniel_Mietchen, Soisyc_Croisic, H4stings, Ricordisamoa, matej_suchanek, MGChecker, Sitic, JanZerebecki, Conny, Snaterlicious, Liuxinyu970226, Quiddity, Rschen7754, Ainali, MisterSynergy, Lydia_Pintscher, Aklapper, daniel, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T117738: [Task] Add a mechanism to build interwiki wikitext links across sister projects

2017-02-26 Thread matej_suchanek
matej_suchanek added a parent task: T90435: [Epic] Wikidata watchlist improvements (client).
TASK DETAILhttps://phabricator.wikimedia.org/T117738EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: aude, Aklapper, D3r1ck01, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T157774: A label and an alias should never be the same in the same language and item in Wikidata

2017-02-26 Thread abian
abian added a parent task: T76230: [Epic] data quality and trust.
TASK DETAILhttps://phabricator.wikimedia.org/T157774EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: abianCc: Izno, abian, Aklapper, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T76230: [Epic] data quality and trust

2017-02-26 Thread abian
abian added a subtask: T157774: A label and an alias should never be the same in the same language and item in Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T76230EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: abianCc: Aschroet, abian, Aklapper, Ricordisamoa, Elitre, Liuxinyu970226, Lydia_Pintscher, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T76231: [Story] nudge editors to add a reference when adding a new claim

2017-02-26 Thread FleetAdmiral
FleetAdmiral added a comment.
Hey! Can i take this up?TASK DETAILhttps://phabricator.wikimedia.org/T76231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FleetAdmiralCc: FleetAdmiral, Yair_rand, Aklapper, thiemowmde, adrianheine, Snaterlicious, Liuxinyu970226, Lydia_Pintscher, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T150183: Deploy InterwikiSorting extension to production

2017-02-26 Thread Addshore
Addshore added a comment.
@Lydia_Pintscher @Lea_Lacroix_WMDE  I guess this does still need announcement then?TASK DETAILhttps://phabricator.wikimedia.org/T150183EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: aude, Lea_Lacroix_WMDE, Stashbot, gerritbot, Ladsgroup, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Zppix, Maathavan, Urbanecm, D3r1ck01, Andrew-WMDE, Izno, Luke081515, Wikidata-bugs, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T159106: Show P31 in the Wikidata search results

2017-02-26 Thread Yurik
Yurik created this task.Yurik added a project: Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONI think the most useful piece of information when searching is P31. Please consider showing it in the search results.TASK DETAILhttps://phabricator.wikimedia.org/T159106EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: YurikCc: Aklapper, Yurik, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T159106: Show P31 in the Wikidata search results

2017-02-26 Thread Yurik
Yurik edited the task description. (Show Details)
EDIT DETAILSI think the most useful piece of information when searching is P 31. Please consider showing it in the search results.TASK DETAILhttps://phabricator.wikimedia.org/T159106EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: YurikCc: Aklapper, Yurik, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs