[Wikidata-bugs] [Maniphest] [Commented On] T163551: Huge number of duplicate rows in wb_terms

2017-09-16 Thread Ladsgroup
Ladsgroup added a comment.
There are two problems right now, 1- We have duplicate rows:

mysql:wikiadmin@db1087 [wikidatawiki]> select * from wb_terms where term_full_entity_id = 'Q134092' and term_language = 'en';
+-++-+--+---+-+-+-+-+
| term_row_id | term_entity_id | term_full_entity_id | term_entity_type | term_language | term_type   | term_text   | term_search_key | term_weight |
+-++-+--+---+-+-+-+-+
|   617069321 | 134092 | Q134092 | item | en| description | Nepalese and Indian cuisine originated in Nepal | nepalese and indian cuisine originated in nepal |   0.034 |
|   617069322 | 134092 | Q134092 | item | en| description | Nepalese and Indian cuisine originated in Nepal | nepalese and indian cuisine originated in nepal |   0.034 |
|   159448432 | 134092 | Q134092 | item | en| label   | Momo| momo|   0 |
+-++-+--+---+-+-+-+-+
3 rows in set (0.00 sec)

2- The API surfaces all of them. I think both parts needs to be fixed but the second one probably requires another phab card.TASK DETAILhttps://phabricator.wikimedia.org/T163551EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, LadsgroupCc: Lydia_Pintscher, Krinkle, Ladsgroup, gerritbot, daniel, Smalyshev, jcrespo, aude, Aklapper, hoo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T163551: Huge number of duplicate rows in wb_terms

2017-09-16 Thread Krinkle
Krinkle added a comment.

In T163551#3612317, @Lydia_Pintscher wrote:
That's definitely not how it should be. There should only ever be one description for a given item and language. Is this also caused by the duplicate rows?


I'm not sure. I was gonna file a new task, but found this existing task instead. I suppose the end-result of duplicate values return via the API could be caused by a different bug as well, it looks like this bug would also cause it. And while a potential fix was provided for new submissions, I don't see any record of existing items having been fixed.TASK DETAILhttps://phabricator.wikimedia.org/T163551EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, KrinkleCc: Lydia_Pintscher, Krinkle, Ladsgroup, gerritbot, daniel, Smalyshev, jcrespo, aude, Aklapper, hoo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T169858: Add support for “instance or subclass of” relation

2017-09-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- P​1422 “Sandrart.net person ID”: some “persons” are groups that, in Wikidata, are represented by a class item.
- P​306 “operating system” (value type constraint): an operating system, like Linux or Windows (yes, I know, OS ≠ kernel, shut up), or the special value “cross-platform”. “cross-platform” isn’t an instance of anything, but it is at least an “indirect” subclass of itself (path length 0), so the relation “instance of or subclass of” would permit that value, which the current relation “instance of” doesn’t.

There’s already an item for this relation (Q30208840), and apparently some constraints are already using it. But I don’t know if this feature is high priority.TASK DETAILhttps://phabricator.wikimedia.org/T169858EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: PKM, Bugreporter, Jheald, MisterSynergy, Lydia_Pintscher, Marsupium, Esc3300, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Agabi10, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T176062: Support Creator namespace in Commons link constraint

2017-09-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-Constraints.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONIt looks like the Commons link constraint type doesn’t support the Creator namespace. Example statement: https://www.wikidata.org/wiki/Q468214#P1472, with the value “Ludolf Bakhuizen” and the namespace “Creator” on the constraint. I suspect this might be because we use a TitleParser configured on wikidatawiki, where there’s no Creator namespace. But perhaps it works if we have the TitleParser parse commons:Creator:Ludolf Bakhuizen instead of just Creator:Ludolf Bakhuizen?TASK DETAILhttps://phabricator.wikimedia.org/T176062EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Agabi10, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T173594: Add support for “separators” parameter of “single value” constraint type

2017-09-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- ~~The description (“they [the values?] have different values for this property”) sounds like it’s talking about statements, but this parameter is/was also used on non-entity properties like “NKCR AUT ID” (external identifier) and “official website” (URL). Strings and URLs can’t have statements, so how does this work? Qualifiers?~~ Qualifiers.
- What happens if one value has a ~~statement~~ qualifier for the separating property and one doesn’t?...- What happens if values have multiple ~~statements~~ qualifiers for the separating properties~~, possibly with different ranks~~?
- ~~Are deprecated statements of the separating property generally ignored?~~ (no such thing as deprecated qualifiers)
- Should this also extend to the “multi value” constraint (e. g. must have multiple values with different values~~values~~ qualifiers for the separating property)?TASK DETAILhttps://phabricator.wikimedia.org/T173594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Esc3300, Ivan_A_Krestinin, Aklapper, GoranSMilovanovic, QZanden, Agabi10, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T163551: Huge number of duplicate rows in wb_terms

2017-09-16 Thread Lydia_Pintscher
Lydia_Pintscher added a comment.
That's definitely not how it should be. There should only ever be one description for a given item and language. Is this also caused by the duplicate rows?TASK DETAILhttps://phabricator.wikimedia.org/T163551EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, Lydia_PintscherCc: Lydia_Pintscher, Krinkle, Ladsgroup, gerritbot, daniel, Smalyshev, jcrespo, aude, Aklapper, hoo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T163551: Huge number of duplicate rows in wb_terms

2017-09-16 Thread Krinkle
Krinkle added a comment.
When editing a page in VisualEditor, I sometimes notice that the description (from Wikidata's pageterms API) is duplicated. I results in the following rendering:

F9586347: Screen Shot 2017-09-16 at 20.51.29.png

The joining by a single comma also looks odd, but is possibly a bug in VisualEditor (depending on whether or not this value is meant to be an array or not, if meant to be a string, then the silent conversion to string is to be expected).

Underlying query: https://en.wikipedia.org/w/api.php?action="">

{
"query": {
"pages": {
"1351345": {
"pageid": 1351345,
"ns": 0,
"title": "Momo (food)",

"terms": {
"description": [
"Nepalese and Indian cuisine originated in Nepal",
"Nepalese and Indian cuisine originated in Nepal"
]
}

"contentmodel": "wikitext",
"pagelanguage": "en",
"pagelanguagehtmlcode": "en",
"pagelanguagedir": "ltr",
"touched": "2017-09-12T13:36:49Z",
"lastrevid": 800270184,
"length": 8406,
"thumbnail": {
"source": "https://upload.wikimedia.org/wikipedia/commons/thumb/a/a1/Momo_nepal.jpg/80px-Momo_nepal.jpg",
"width": 80,
"height": 58
},
"pageimage": "Momo_nepal.jpg"
}
}
},
"batchcomplete": ""
}TASK DETAILhttps://phabricator.wikimedia.org/T163551EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, KrinkleCc: Krinkle, Ladsgroup, gerritbot, daniel, Smalyshev, jcrespo, aude, Aklapper, hoo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T168765: Create Wikiversity Hindi

2017-09-16 Thread gerritbot
gerritbot added a comment.
Change 378406 abandoned by Zoranzoki21:
Revert of commit 021795da50cc81427a538b156cb22a7911b935b6.

Reason:
Sorry.. I will abandon this patch/change.

https://gerrit.wikimedia.org/r/378406TASK DETAILhttps://phabricator.wikimedia.org/T168765EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Reedy, gerritbotCc: chasemp, Marostegui, Krenair, Koavf, Dzahn, Anooprao, Stashbot, Reedy, YmKavishwar, Crochet.david, gerritbot, PokestarFan, gh87, Ebe123, Lsanabria, Sfic, Urbanecm, StevenJ81, SPQRobin, Rschen7754, Mahir256, Dereckson, Jayprakash12345, Dcljr, Aklapper, JunaidHafeez, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, Zoranzoki21, Lewizho99, Zppix, Maathavan, DatGuy, Devwaker, JEumerus, Tulsi_Bhagat, Izno, Luke081515, JAllemandou, biplabanand, Wikidata-bugs, Snowolf, aude, Nemo_bis, faidon, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, fgiunchedi, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T168765: Create Wikiversity Hindi

2017-09-16 Thread gerritbot
gerritbot added a comment.
Change 378406 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[analytics/refinery@master] Revert "Add hiwikiversity"

https://gerrit.wikimedia.org/r/378406TASK DETAILhttps://phabricator.wikimedia.org/T168765EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Reedy, gerritbotCc: chasemp, Marostegui, Krenair, Koavf, Dzahn, Anooprao, Stashbot, Reedy, YmKavishwar, Crochet.david, gerritbot, PokestarFan, gh87, Ebe123, Lsanabria, Sfic, Urbanecm, StevenJ81, SPQRobin, Rschen7754, Mahir256, Dereckson, Jayprakash12345, Dcljr, Aklapper, JunaidHafeez, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, Zoranzoki21, Lewizho99, Zppix, Maathavan, DatGuy, Devwaker, JEumerus, Tulsi_Bhagat, Izno, Luke081515, JAllemandou, biplabanand, Wikidata-bugs, Snowolf, aude, Nemo_bis, faidon, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, fgiunchedi, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T151717: Usage tracking: record which statement group is used

2017-09-16 Thread eranroz
eranroz added a comment.
I suggest to deploy it ( https://gerrit.wikimedia.org/r/#/c/375544/ ) in  SWAT window on Monday/Tuesday (Morning SWAT):
https://wikitech.wikimedia.org/wiki/Deployments#Monday.2C.C2.A0September.C2.A018TASK DETAILhttps://phabricator.wikimedia.org/T151717EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Bawolff, eranroz, Ottomata, PokestarFan, Ladsgroup, Stashbot, gerritbot, Halfak, jcrespo, TomT0m, Hall1467, hoo, zhuyifei1999, Eloquence, Lydia_Pintscher, Sannita, Ainali, Liuxinyu970226, MZMcBride, Ricordisamoa, Micru, jayvdb, Daniel_Mietchen, Tobi_WMDE_SW, Legoktm, Abraham, Wikidata-bugs, liangent, jeremyb, aude, Bianjiang, Aklapper, DixonD, daniel, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Marostegui, Lewizho99, Minhnv-2809, Maathavan, Izno, Luke081515, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T151717: Usage tracking: record which statement group is used

2017-09-16 Thread Lydia_Pintscher
Lydia_Pintscher added a comment.
@hoo Do you have an estimate when you'll be able to do the deployment on elwiki? People are asking for this quite a bit now.TASK DETAILhttps://phabricator.wikimedia.org/T151717EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Bawolff, eranroz, Ottomata, PokestarFan, Ladsgroup, Stashbot, gerritbot, Halfak, jcrespo, TomT0m, Hall1467, hoo, zhuyifei1999, Eloquence, Lydia_Pintscher, Sannita, Ainali, Liuxinyu970226, MZMcBride, Ricordisamoa, Micru, jayvdb, Daniel_Mietchen, Tobi_WMDE_SW, Legoktm, Abraham, Wikidata-bugs, liangent, jeremyb, aude, Bianjiang, Aklapper, DixonD, daniel, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Marostegui, Lewizho99, Minhnv-2809, Maathavan, Izno, Luke081515, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs