[Wikidata-bugs] [Maniphest] [Commented On] T164653: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS
Legoktm added a comment. I tried enabling Squiz.WhiteSpace.FunctionSpacing but it did not play well with global functions (probably needs an upstream bug report).TASK DETAILhttps://phabricator.wikimedia.org/T164653EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: gerritbot, Ricordisamoa, Addshore, Aleksey_WMDE, thiemowmde, Legoktm, Aklapper, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Lethexie, Maathavan, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164653: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS
gerritbot added a comment. Change 398679 had a related patch set uploaded (by Legoktm; owner: Legoktm): [mediawiki/tools/codesniffer@master] Require that an explicit visiblity is set on methods and properties https://gerrit.wikimedia.org/r/398679TASK DETAILhttps://phabricator.wikimedia.org/T164653EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ricordisamoa, Addshore, Aleksey_WMDE, thiemowmde, Legoktm, Aklapper, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Lethexie, Maathavan, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164653: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS
gerritbot added a comment. Change 398678 had a related patch set uploaded (by Legoktm; owner: Legoktm): [mediawiki/tools/codesniffer@master] Check function definitions for the same variable name https://gerrit.wikimedia.org/r/398678TASK DETAILhttps://phabricator.wikimedia.org/T164653EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ricordisamoa, Addshore, Aleksey_WMDE, thiemowmde, Legoktm, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, Lethexie, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T164653: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T164653EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ricordisamoa, Addshore, Aleksey_WMDE, thiemowmde, Legoktm, Aklapper, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Lethexie, Maathavan, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Reassigned] T183020: Investigate the possibility to release Wikidata queries
Smalyshev reassigned this task from Smalyshev to leila. TASK DETAILhttps://phabricator.wikimedia.org/T183020EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: leila, SmalyshevCc: mkroetzsch, Smalyshev, DarTar, leila, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, Avner, Wikidata-bugs, aude, Capt_Swing, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183020: Investigate the possibility to release Wikidata queries
mkroetzsch added a comment. I agree with Stas: regular data releases are desirable, but need further thought. The task is easier for our current case since we already know what is in the data. For a regular process, one has to be very careful to monitor potential future issues. By releasing historic data, we avoid exploits that could be theoretically possible based on detailed knowledge of the methodology. Regarding external IDs, one could whitelist unproblematic IDs that can be preserved, and obfuscate others. I agree that authority control IDs might identify humans, since they scope over so many things that are tied to particular humans (books, authors, etc.) that one could have a hypothetical situation where the interest in a particular item would already suggest who asked the query. I don't think something similar is even theoretically plausible for other IDs (e.g., for proteins or stars). Even for book ids, the lack of user traces makes it very hard to exploit this data further (the certainty you get from a single query being asked can hardly be high, and a query that helps you to guess who asked it will often not be interesting in its own right -- most likely you would want to know what else the identified person has asked). Anyway, we could restrict the "numerical strings are ok" rule to whitelisted properties for our current release. The main reason we have it at all are things like BlazeGraph's "radius" service parameter that have to be a number but are given as a string (I think the gas service might have similar cases). There is a general limitation to potential exploits of SPARQL logs for breaching someone's privacy. If you don't control the software that formulated the query, then you can only connect queries to people if you already knew that only this person would ask this query. But then you learn very little by observing the query! On the other hand, if you control the software, then it would usually be easy to gather user data more directly, without needing the detour across some SPARQL logs released months later. One exception that might be relevant in the future is the use of SPARQL from Lua built-ins or MediaWiki tags on Wikipedia pages, which could in theory expose some page traffic. This is not relevant for our historic logs, and it would be hard to fully exploit due to parser caches and crawler-based hits, but it might become a theoretical issue nonetheless. To avoid it, one could either filter all Wikipedia servers from the logs, or use a separate SPARQL service for such requests (as discussed in Berlin), whose logs would not be released. Considering our current dataset, it seems that even the obfuscation of strings is more than one would have to do, but in the future one might indeed have to add external URLs if they become more common in queries.TASK DETAILhttps://phabricator.wikimedia.org/T183020EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, mkroetzschCc: mkroetzsch, Smalyshev, DarTar, leila, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, Avner, Wikidata-bugs, aude, Capt_Swing, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T183020: Investigate the possibility to release Wikidata queries
Smalyshev added a comment. I've reviewed the proposal and it looks good to me. In fact, it aligns with my thinking about how we should make data from SPARQL logs available (see T143819: Data request for logs from SparQL interface at query.wikidata.org), though I think we should eventually find a way to provide such data sets on regular basis. I'll add more of my thinking on the subject to T143819, but so far I think it's fine. One further thing to consider (probably not for current data set but for applying it to further applications) is that data can be not only strings, but also numeric values and URIs. And in the future - e.g. for #structured-data-commons project - we could have URIs that identify particular users (e.g. as author of the content in Commons). Also, right now (though probably not in data set in question) we produce both string and URI for external ID. While in most cases I can think of external ID is not PII - after all, it's an ID specifically invented to be a public identifier - it could potentially reveal some information, such as people looking for a particular book. So if we want to apply the same process for future data sets, we need to be aware of it and think about solutions.TASK DETAILhttps://phabricator.wikimedia.org/T183020EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: mkroetzsch, Smalyshev, DarTar, leila, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, Avner, Wikidata-bugs, aude, Capt_Swing, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T144875: When entering sitelink edit mode, focus is not in the site input box
aude added a comment. this still happens :/ I thought this worked at some pointTASK DETAILhttps://phabricator.wikimedia.org/T144875EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: audeCc: Nikki, aude, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T113468: [Task] Use compact representation of diffs in EntityChange.
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)); removed MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)). TASK DETAILhttps://phabricator.wikimedia.org/T113468EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, ReleaseTaggerBotCc: Stashbot, Lucas_Werkmeister_WMDE, Ladsgroup, Addshore, Lydia_Pintscher, thiemowmde, PokestarFan, hoo, gerritbot, aude, Aklapper, daniel, Lahi, Gq86, GoranSMilovanovic, QZanden, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T113468: [Task] Use compact representation of diffs in EntityChange.
gerritbot added a comment. Change 394044 merged by Ladsgroup: [mediawiki/extensions/Wikibase@master] Avoid using EntityDiffChangedAspectsFactory like a static constructor https://gerrit.wikimedia.org/r/394044TASK DETAILhttps://phabricator.wikimedia.org/T113468EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Stashbot, Lucas_Werkmeister_WMDE, Ladsgroup, Addshore, Lydia_Pintscher, thiemowmde, PokestarFan, hoo, gerritbot, aude, Aklapper, daniel, Lahi, Gq86, GoranSMilovanovic, QZanden, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T182137: Clean up backward compatibility of EntityDiffAspects in Wikibase
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)). TASK DETAILhttps://phabricator.wikimedia.org/T182137EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, ReleaseTaggerBotCc: gerritbot, Aklapper, Ladsgroup, Lahi, Gq86, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T182137: Clean up backward compatibility of EntityDiffAspects in Wikibase
gerritbot added a comment. Change 397798 merged by Ladsgroup: [mediawiki/extensions/Wikibase@master] Clean up all backward compatibilities for EntityCompactDiff https://gerrit.wikimedia.org/r/397798TASK DETAILhttps://phabricator.wikimedia.org/T182137EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, Aklapper, Ladsgroup, Lahi, Gq86, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T168626: Check constraints before saving statements
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...(I think this feature has been planned, at least as a “nice to have for the future”, for some time – I remember it came up when the API was added – but as far as I can tell we didn’t have a task for it before.) On a more technical level, this means adding support for passing JSON snippets (for snaks, statements, of even full entities?) instead of entity or claim IDs into `wbcheckconstraints` (or a new API module?), which could also be used externally, e. g. before a large data import. (For instance, the [HarvestTemplates tool](https://tools.wmflabs.org/pltools/harvesttemplates/) already includes a partial [implementation of constraint checks](https://github.com/Pascalco/harvesttemplates/blob/86b38d29262b1705c96439247ae536d6e35ffc42/main.js#L400-L553), and aborts imports which fail some constraints.)TASK DETAILhttps://phabricator.wikimedia.org/T168626EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Hjfocs, Jonas, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T183020: Investigate the possibility to release Wikidata queries
Smalyshev claimed this task.Smalyshev added a project: User-Smalyshev. TASK DETAILhttps://phabricator.wikimedia.org/T183020EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: mkroetzsch, Smalyshev, DarTar, leila, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, Avner, Wikidata-bugs, aude, Capt_Swing, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T183054: Wikidata autocomplete search does not truncate trailing spaces
Smalyshev added a parent task: T46529: Wikidata search problems (tracking). TASK DETAILhttps://phabricator.wikimedia.org/T183054EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Aklapper, Smalyshev, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T46529: Wikidata search problems (tracking)
Smalyshev added a subtask: T183054: Wikidata autocomplete search does not truncate trailing spaces. TASK DETAILhttps://phabricator.wikimedia.org/T46529EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Liuxinyu970226, PokestarFan, Smalyshev, Wikidata-bugs, Nemo_bis, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T183054: Wikidata autocomplete search does not truncate trailing spaces
Smalyshev created this task.Smalyshev added projects: Discovery-Search, Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTIONWikidata autocomplete search does not truncate trailing spaces, so that "John Smith " does not find the same things as "John Smith".TASK DETAILhttps://phabricator.wikimedia.org/T183054EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Aklapper, Smalyshev, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T179815: Enable searching by author name string
Smalyshev added a project: Discovery-Search. TASK DETAILhttps://phabricator.wikimedia.org/T179815EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Smalyshev, Lydia_Pintscher, Lea_Lacroix_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T183053: New Wikidata appear in search with a delay
Smalyshev added a project: Discovery-Search. TASK DETAILhttps://phabricator.wikimedia.org/T183053EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: EBernhardson, dcausse, Aklapper, Smalyshev, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, Avner, Gehel, FloNight, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T183053: New Wikidata appear in search with a delay
Smalyshev updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONThere are [[ URhttps://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Lag_till_new_item_can_be_selected | complaints from the users ]] that newly created Wikidata items appear with a delay in prefix search (and, consequently, all autocompletion boxes). The delay seems to be 10-15 seconds. TASK DETAILhttps://phabricator.wikimedia.org/T183053EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: EBernhardson, dcausse, Aklapper, Smalyshev, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, Avner, Gehel, FloNight, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T183053: New Wikidata appear in search with a delay
Smalyshev created this task.Smalyshev added projects: Wikidata, Discovery.Herald added a subscriber: Aklapper. TASK DESCRIPTIONThere are [[ URhttps://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Lag_till_new_item_can_be_selected | complaints from the users ]] that newly created Wikidata items appear with a delay in prefix search (and, consequently, all autocompletion boxes). The delay seems to be 10-15 seconds.TASK DETAILhttps://phabricator.wikimedia.org/T183053EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: EBernhardson, dcausse, Aklapper, Smalyshev, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, Avner, Gehel, FloNight, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T183053: New Wikidata appear in search with a delay
Smalyshev added a parent task: T46529: Wikidata search problems (tracking). TASK DETAILhttps://phabricator.wikimedia.org/T183053EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: EBernhardson, dcausse, Aklapper, Smalyshev, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, Avner, Gehel, FloNight, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T46529: Wikidata search problems (tracking)
Smalyshev added a subtask: T183053: New Wikidata appear in search with a delay. TASK DETAILhttps://phabricator.wikimedia.org/T46529EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Liuxinyu970226, PokestarFan, Smalyshev, Wikidata-bugs, Nemo_bis, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
