[Wikidata-bugs] [Maniphest] [Claimed] T187196: Disable Senses in the UI of the initial Lexeme page [S]

2018-02-22 Thread Ladsgroup 
Ladsgroup claimed this task.Ladsgroup added a project: Wikidata-Sprint-2018-02-14.Herald added a project: User-Ladsgroup.
TASK DETAILhttps://phabricator.wikimedia.org/T187196EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: gerritbot, Story, Lydia_Pintscher, Aklapper, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187196: Disable Senses in the UI of the initial Lexeme page [S]

2018-02-22 Thread gerritbot 
gerritbot added a comment.
Change 413624 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] Disable Senses, the softer way

https://gerrit.wikimedia.org/r/413624TASK DETAILhttps://phabricator.wikimedia.org/T187196EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Story, Lydia_Pintscher, Aklapper, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T188045: wdqs1004 broken

2018-02-22 Thread Dzahn 
Dzahn edited projects, added ops-eqiad; removed Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T188045EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DzahnCc: Cmjohnson, Papaul, gerritbot, elukey, Smalyshev, Aklapper, Dzahn, Davinaclare77, Qtn1293, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, merbst, LawExplorer, Avner, Zppix, Gehel, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Southparkfan, faidon, Mbch331, Jay8g, fgiunchedi, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Lordiis, Adik2382, Ramalepe, Liugev6, Lewizho99, Maathavan___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T183053: New Wikidata items appear in search with a delay

2018-02-22 Thread gerritbot 
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T183053EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Stashbot, debt, jhsoby, Lydia_Pintscher, EBernhardson, dcausse, Aklapper, Smalyshev, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Avner, Lewizho99, Maathavan, Gehel, FloNight, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T183053: New Wikidata items appear in search with a delay

2018-02-22 Thread gerritbot 
gerritbot added a comment.
Change 413492 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/CirrusSearch@master] Allow some wikis to instantly index newly created articles

https://gerrit.wikimedia.org/r/413492TASK DETAILhttps://phabricator.wikimedia.org/T183053EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Stashbot, debt, jhsoby, Lydia_Pintscher, EBernhardson, dcausse, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T188045: wdqs1004 broken

2018-02-22 Thread Dzahn 
Dzahn added a subscriber: Papaul.Dzahn added a comment.
@Papaul This server has been depooled.  Could you please run hardware diagnostics on it? You can do it anytime. Thanks!TASK DETAILhttps://phabricator.wikimedia.org/T188045EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DzahnCc: Papaul, gerritbot, elukey, Smalyshev, Aklapper, Dzahn, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Zppix, Maathavan, Gehel, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T188045: wdqs1004 broken

2018-02-22 Thread Dzahn 
Dzahn added a comment.
i ran puppet on all wdqs* via cumin after the merge and smalyshev confirmed the LDF server seems fine

https://query.wikidata.org/bigdata/ldfTASK DETAILhttps://phabricator.wikimedia.org/T188045EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DzahnCc: gerritbot, elukey, Smalyshev, Aklapper, Dzahn, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Zppix, Maathavan, Gehel, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T187196: Disable Senses in the UI of the initial Lexeme page [S]

2018-02-22 Thread gerritbot 
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T187196EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Story, Lydia_Pintscher, Aklapper, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187196: Disable Senses in the UI of the initial Lexeme page [S]

2018-02-22 Thread gerritbot 
gerritbot added a comment.
Change 413488 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] Disable Senses in UI, the hard way

https://gerrit.wikimedia.org/r/413488TASK DETAILhttps://phabricator.wikimedia.org/T187196EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Story, Lydia_Pintscher, Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T188045: wdqs1004 broken

2018-02-22 Thread gerritbot 
gerritbot added a comment.
Change 413485 merged by Dzahn:
[operations/puppet@production] wdqs: move LDF endpoint to wdqs1005 since wdqs1004 is having hardware issues

https://gerrit.wikimedia.org/r/413485TASK DETAILhttps://phabricator.wikimedia.org/T188045EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, elukey, Smalyshev, Aklapper, Dzahn, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Zppix, Maathavan, Gehel, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T188045: wdqs1004 broken

2018-02-22 Thread Dzahn 
Dzahn added a project: Wikidata-Query-Service.Herald added projects: Wikidata, Discovery.
TASK DETAILhttps://phabricator.wikimedia.org/T188045EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DzahnCc: gerritbot, elukey, Smalyshev, Aklapper, Dzahn, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Zppix, Maathavan, Gehel, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T186714: enable x-kill feature on Commons

2018-02-22 Thread Ladsgroup 
Ladsgroup edited projects, added Commons, Wikidata-Sprint-2018-02-14; removed Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T186714EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Stashbot, gerritbot, Mike_Peel, Aklapper, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Gabrielchihonglee, Steinsplitter, Mbch331, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T188046: Simple English localization gets date format from previous localization

2018-02-22 Thread Smalyshev 
Smalyshev created this task.Smalyshev added a project: Wikidata Query UI.Herald added a subscriber: Aklapper.
TASK DESCRIPTION
Switch localization to some language other than English, e.g. Hebrew
Run a query, e.g. Recent Events example
The dates are displayed in Hebrew, as it should be.
Switch to Simple English localization.
Run the same query
The dates are still in Hebrew, though the rest of the UI is fine.


Same happens with any other localization - if you switch UI to some language and then to Simple English, you get dates in the previous localization's format.TASK DETAILhttps://phabricator.wikimedia.org/T188046EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Aklapper, Smalyshev, Gq86, Lucas_Werkmeister_WMDE, EBjune, merbst, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T184000: Magic word on English WP to override display of Wikidata short description

2018-02-22 Thread Addshore 
Addshore added a comment.
@daniel pointed out to me that the pageterms api module was originally introduced for the apps etc to use.
For future, APIs have the ability to be marked as "internal" if they are only designed for internal use, this would allow us to make whatever changes we want to suit the needs of wikimedia products.
If this was the case already for pageterms I really wouldn't mind what changes would be made (although it would probably make more sense that the module have a better name, appterms or similar)


In T184000#3991404, @DannyH wrote:
@daniel & @Tgr -- sorry, I misspoke in my last comment. I talked to a couple more people and I understand it better now. :) We should do the second option and create a new mode of the API. I believe that means we won't have to notify Wikibase, so that should save some time.


Woo!


In T184000#3991482, @Tgr wrote:
So something like prop=description I suppose?

How would the other two implementations get exposed? A site configuration option?


So, prop=description sounds like the approach that would totally separate this from wikibase, which in my eyes is a good idea.
The choice of implementation could just be provided as another parameter to the api module, this could even be multivalue to allow fallbacks, for example:


prop=description&descsource=wikibase  - Description comes from wikibase directly.
prop=description&descsource=magicword - Description comes from magicword.
prop=description&descsource=magicword|wikibase - Description comes from the magic word with a fallback to wikibase.
TASK DETAILhttps://phabricator.wikimedia.org/T184000EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, AddshoreCc: TheDJ, Fjalapeno, Tbayer, MZMcBride, Alsee, bearND, Mike_Peel, Tgr, JKatzWMF, daniel, Bmueller, Addshore, Lydia_Pintscher, Samwilson, Aklapper, DannyH, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, JJMC89, B20180, Nakon, MusikAnimal, Niharika, Fhocutt, Wikidata-bugs, aude, Ricordisamoa, -jem-, Mbch331, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187717: Change the default date setting of Timeline View in the Wikidata Query Service

2018-02-22 Thread gerritbot 
gerritbot added a comment.
Change 412698 merged by jenkins-bot:
[wikidata/query/gui@master] Bring date formatting closer to Wikibase

https://gerrit.wikimedia.org/r/412698TASK DETAILhttps://phabricator.wikimedia.org/T187717EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Jonas, Lea_Lacroix_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T185984: Migrate WDQS code to use Instant to store timestamps

2018-02-22 Thread gerritbot 
gerritbot added a comment.
Change 411571 merged by jenkins-bot:
[wikidata/query/rdf@master] Replace usage of Date for timestamp with java.time.Instant

https://gerrit.wikimedia.org/r/411571TASK DETAILhttps://phabricator.wikimedia.org/T185984EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, Gehel, Smalyshev, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Maathavan, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T187766: Install / configure new WDQS servers

2018-02-22 Thread Smalyshev 
Smalyshev added a subtask: T182991: New WDQS clusters eqiad + codfw.
TASK DETAILhttps://phabricator.wikimedia.org/T187766EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Aklapper, Gehel, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, Jonas, FloNight, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T182991: New WDQS clusters eqiad + codfw

2018-02-22 Thread Smalyshev 
Smalyshev added a parent task: T187766: Install / configure new WDQS servers.
TASK DETAILhttps://phabricator.wikimedia.org/T182991EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: RobH, SmalyshevCc: Lucas_Werkmeister_WMDE, RobH, Gehel, EBjune, Davinaclare77, Qtn1293, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, merbst, LawExplorer, Avner, Zppix, Jonas, FloNight, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T187766: Install / configure new WDQS servers

2018-02-22 Thread Smalyshev 
Smalyshev added subtasks: Unknown Object (Task), Unknown Object (Task), T187800: rack/setup/install wdqs200[4-6].
TASK DETAILhttps://phabricator.wikimedia.org/T187766EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Aklapper, Gehel, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, Jonas, FloNight, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T187296: Increase kafka event retention to 14 or 21 days

2018-02-22 Thread fdans 
fdans edited projects, added Analytics-Kanban; removed Analytics.
TASK DETAILhttps://phabricator.wikimedia.org/T187296EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: fdansCc: elukey, Ottomata, Aklapper, Nuria, Ladsgroup, Pchelolo, JAllemandou, Smalyshev, Lahi, Gq86, Vacio, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, Gehel, Jonas, FloNight, Xmlizer, Nirmos, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T167787: [Spike 2hr] Investigate ability for page previews in wikidata to appear in user's preferred language

2018-02-22 Thread phuedx 
phuedx added a comment.
@ovasileva: I was going to be bold but I notice that the mocks in this task aren't on any other tasks (including T111231: Page previews for Wikidata). Could/should we refer to them there?TASK DETAILhttps://phabricator.wikimedia.org/T167787EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedxCc: PokestarFan, Jdlrobson, GWicke, mobrovac, Pchelolo, Jhernandez, Nirzar, Tbayer, Aklapper, Lydia_Pintscher, phuedx, ovasileva, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, Eevans, Hardikj, Wikidata-bugs, aude, Ricordisamoa, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Merged] T120520: [Story] make it easier to understand what Special:Nearby is

2018-02-22 Thread Jdlrobson 
Jdlrobson closed this task as a duplicate of T125820: Special:Nearby does not give correct feedback.
TASK DETAILhttps://phabricator.wikimedia.org/T120520EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: TerraCodes, aude, Jdlrobson, Nirzar, Mbch331, gerritbot, D3r1ck01, Aklapper, Lydia_Pintscher, Lahi, Gq86, mojoaxel, GoranSMilovanovic, QZanden, LawExplorer, Winter, Jdrewniak, JGirault, Wikidata-bugs___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T167787: [Spike 2hr] Investigate ability for page previews in wikidata to appear in user's preferred language

2018-02-22 Thread Jdlrobson 
Jdlrobson added a comment.
Agreed! Sounds like the same problem to me.TASK DETAILhttps://phabricator.wikimedia.org/T167787EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: PokestarFan, Jdlrobson, GWicke, mobrovac, Pchelolo, Jhernandez, Nirzar, Tbayer, Aklapper, Lydia_Pintscher, phuedx, ovasileva, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, Eevans, Hardikj, Wikidata-bugs, aude, Ricordisamoa, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T167787: [Spike 2hr] Investigate ability for page previews in wikidata to appear in user's preferred language

2018-02-22 Thread phuedx 
phuedx added a comment.
Can this be merged into T185139: Popups should respect user's language variant preferences, which seems more generic?TASK DETAILhttps://phabricator.wikimedia.org/T167787EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedxCc: PokestarFan, Jdlrobson, GWicke, mobrovac, Pchelolo, Jhernandez, Nirzar, Tbayer, Aklapper, Lydia_Pintscher, phuedx, ovasileva, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, Eevans, Hardikj, Wikidata-bugs, aude, Ricordisamoa, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T188002: Implement the properties service

2018-02-22 Thread Hjfocs 
Hjfocs updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION`/properties`endpoint, should output the ~~map between property labels and identifiers.~~ list of property identifiers- ~~call `https://www.wikidata.org/w/api.php?action="" to get the property label.~~ Not needed, already implemented in the front end through `getEntityLabel`.TASK DETAILhttps://phabricator.wikimedia.org/T188002EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HjfocsCc: Aklapper, Hjfocs, Lahi, Gq86, GoranSMilovanovic, Kiailandi, QZanden, dachary, LawExplorer, Wikidata-bugs, aude, Ricordisamoa, Sjoerddebruin, Tpt, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T188004: Implement the values service

2018-02-22 Thread Hjfocs 
Hjfocs updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION`/values`endpoint, should output the ~~map between entity labels and identifiers.~~ list of identifiers- ~~call `https://www.wikidata.org/w/api.php?action="" to get the property label.~~ Not needed, already implemented in the front end through `getEntityLabel`.TASK DETAILhttps://phabricator.wikimedia.org/T188004EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HjfocsCc: Aklapper, Hjfocs, Lahi, Gq86, GoranSMilovanovic, Kiailandi, QZanden, dachary, LawExplorer, Wikidata-bugs, aude, Ricordisamoa, Sjoerddebruin, Tpt, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T188011: [Task] Use PHPUnit 6 forward compatibility aliases in all Wikibase code bases

2018-02-22 Thread thiemowmde 
thiemowmde updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...If a code base requires it's own PHPUnit version (this is the case for all PHP components that are not MediaWiki extensions), the suggestion is to go for this dependency in composer.json:dependency in composer.json needs to be updated like this:
```lang=JSON
"phpunit/phpunit": "^4.8.35|^6",...TASK DETAILhttps://phabricator.wikimedia.org/T188011EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Jonas, Lucas_Werkmeister_WMDE, WMDE-leszek, Ladsgroup, thiemowmde, Aklapper, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, TerraCodes, MuhammadShuaib, SimmeD, Wikidata-bugs, aude, TheDJ, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T188011: [Task] Use PHPUnit 6 forward compatibility aliases in all Wikibase code bases

2018-02-22 Thread thiemowmde 
thiemowmde moved this task from incoming to ready to go on the Wikidata board.thiemowmde triaged this task as "Low" priority.thiemowmde added projects: Need-volunteer, Easy.thiemowmde added a comment.
I already uploaded https://gerrit.wikimedia.org/r/410795 and https://github.com/wmde/WikibaseDataModelSerialization/pull/244 as a first proof-of-concept, especially to see if the …|^6 idea works.TASK DETAILhttps://phabricator.wikimedia.org/T188011WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Jonas, Lucas_Werkmeister_WMDE, WMDE-leszek, Ladsgroup, thiemowmde, Aklapper, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, TerraCodes, MuhammadShuaib, SimmeD, Wikidata-bugs, aude, TheDJ, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T188011: [Task] Use PHPUnit 6 forward compatibility aliases in all Wikibase code bases

2018-02-22 Thread thiemowmde 
thiemowmde added a project: User-thiemowmde.
TASK DETAILhttps://phabricator.wikimedia.org/T188011EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Jonas, Lucas_Werkmeister_WMDE, WMDE-leszek, Ladsgroup, thiemowmde, Aklapper, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, TerraCodes, MuhammadShuaib, SimmeD, Wikidata-bugs, aude, TheDJ, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T188011: [Task] Use PHPUnit 6 forward compatibility aliases in all Wikibase code bases

2018-02-22 Thread thiemowmde 
thiemowmde created this task.thiemowmde added projects: Wikidata, DataValues, Technical-Debt.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONPHPUnit backported namespaced class names from PHPUnit 6 back to the older versions 4 and 5. We can start using these right now. This will make the later migration to PHPUnit 6 quite a lot easier, as the necessary patches will be much smaller.

In contrast to what the changelog states, PHPUnit 4.8.35 introduced these aliases:


PHPUnit_Framework_Assert → Assert
PHPUnit_Framework_BaseTestListener → BaseTestListener
PHPUnit_Framework_TestCase → TestCase
PHPUnit_Framework_TestListener → TestListener


In addition, PHPUnit 4.8.36 introduced these aliases:


PHPUnit_Framework_AssertionFailedError → AssertionFailedError
PHPUnit_Framework_Test → Test
PHPUnit_Framework_TestSuite → TestSuite


The suggestion is to not care about any of these, but exclusively focus on replacing PHPUnit_Framework_TestCase with TestCase. This is the vast majority of replacements we need to do (about 84% when I count appearances in my local codebase, with the next one being 7% of PHPUnit_Framework_MockObject_MockObject). Focusing on this one class will make reviewing patches easier. All the other updates can be done later when actually updating to PHPUnit 6.

The suggestion is to not replace … extends \PHPUnit_Framework_TestCase with … extends \PHPUnit\Framework\TestCase, but with … extends TestCase and an import in the use section above. This fits better to the code style the Wikidata team is used to, where full qualified class names are avoided.

If a code base requires it's own PHPUnit version (this is the case for all PHP components that are not MediaWiki extensions), the suggestion is to go for this dependency in composer.json:

"phpunit/phpunit": "^4.8.35|^6",

List of components that need an update:


TBD
TASK DETAILhttps://phabricator.wikimedia.org/T188011EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Jonas, Lucas_Werkmeister_WMDE, WMDE-leszek, Ladsgroup, thiemowmde, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187344: Add language codes for Arabic languages for use in labels, aliases and descriptions to Wikidata

2018-02-22 Thread Csisc 
Csisc added a comment.
@Baba_Tabita We will begin working on Tunisian, Algerian, Moroccan and Egyptian as they are already supported by ULS.TASK DETAILhttps://phabricator.wikimedia.org/T187344EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CsiscCc: thiemowmde, Arrbee, KartikMistry, Jsahleen, jhsoby, Petar.petkovic, santhosh, Mbch331, Bassem, Ibrahim.ID, Helmoony, FShbib, ASammour, Jar, Meno25, TerraCodes, Jay8g, Liuxinyu970226, Nikerabbit, Amire80, GerardM, satdeep_gill, millosh, Baba_Tabita, Aklapper, alanajjar, Csisc, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Soum213, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Luke081515, Wikidata-bugs, Snowolf, aude, Gryllida, Shizhao___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187344: Add language codes for Arabic languages for use in labels, aliases and descriptions to Wikidata

2018-02-22 Thread Csisc 
Csisc added a comment.
@Baba_Tabita That's clear. I will see what I can do.TASK DETAILhttps://phabricator.wikimedia.org/T187344EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CsiscCc: thiemowmde, Arrbee, KartikMistry, Jsahleen, jhsoby, Petar.petkovic, santhosh, Mbch331, Bassem, Ibrahim.ID, Helmoony, FShbib, ASammour, Jar, Meno25, TerraCodes, Jay8g, Liuxinyu970226, Nikerabbit, Amire80, GerardM, satdeep_gill, millosh, Baba_Tabita, Aklapper, alanajjar, Csisc, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Soum213, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Luke081515, Wikidata-bugs, Snowolf, aude, Gryllida, Shizhao___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187344: Add language codes for Arabic languages for use in labels, aliases and descriptions to Wikidata

2018-02-22 Thread Baba_Tabita 
Baba_Tabita added a comment.
As has been said, for use in labels and descriptions, a language has to be added to the ULS. Afaik, any language to be added to the ULS has to have a certain proportion of translations done at translatewiki.net - see https://translatewiki.net/wiki/FAQ#How_to_add_a_new_language
I wanted Rangi [lag] added to the ULS (once upon a time) and am still working on it. Without professional translators who know what they're doing, i.e. have the technical vocabulary, and are also native speakers of the target language, I don't see how this can happen.TASK DETAILhttps://phabricator.wikimedia.org/T187344EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Baba_TabitaCc: thiemowmde, Arrbee, KartikMistry, Jsahleen, jhsoby, Petar.petkovic, santhosh, Mbch331, Bassem, Ibrahim.ID, Helmoony, FShbib, ASammour, Jar, Meno25, TerraCodes, Jay8g, Liuxinyu970226, Nikerabbit, Amire80, GerardM, satdeep_gill, millosh, Baba_Tabita, Aklapper, alanajjar, Csisc, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Soum213, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Luke081515, Wikidata-bugs, Snowolf, aude, Gryllida, Shizhao___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T188004: Implement the values service

2018-02-22 Thread Hjfocs 
Hjfocs created this task.Hjfocs added projects: Wikidata, Wikidata-primary-sources.Herald added a subscriber: Aklapper.
TASK DESCRIPTION/valuesendpoint, should output the map between entity labels and identifiers.


Use a caching mechanism for efficient response times, since the map is heavy to compute on the fly;
call https://www.wikidata.org/w/api.php?action=""> to get the property label.
TASK DETAILhttps://phabricator.wikimedia.org/T188004EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HjfocsCc: Aklapper, Hjfocs, Lahi, Gq86, GoranSMilovanovic, Kiailandi, QZanden, dachary, LawExplorer, Wikidata-bugs, aude, Ricordisamoa, Sjoerddebruin, Tpt, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T188002: Implement the properties service

2018-02-22 Thread Hjfocs 
Hjfocs created this task.Hjfocs added projects: Wikidata, Wikidata-primary-sources.Herald added a subscriber: Aklapper.
TASK DESCRIPTION/propertiesendpoint, should output the map between property labels and identifiers.


Use a caching mechanism for efficient response times, since the map is heavy to compute on the fly;
call https://www.wikidata.org/w/api.php?action=""> to get the property label.
TASK DETAILhttps://phabricator.wikimedia.org/T188002EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HjfocsCc: Aklapper, Hjfocs, Lahi, Gq86, GoranSMilovanovic, Kiailandi, QZanden, dachary, LawExplorer, Wikidata-bugs, aude, Ricordisamoa, Sjoerddebruin, Tpt, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T178303: Fill SPARQL query template for the domain of interest in the primary sources filter

2018-02-22 Thread Hjfocs 
Hjfocs closed this task as "Resolved".Hjfocs moved this task from Doing to Done on the Wikidata-primary-sources board.
TASK DETAILhttps://phabricator.wikimedia.org/T178303WORKBOARDhttps://phabricator.wikimedia.org/project/board/2788/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HjfocsCc: Afnecors, Aklapper, Hjfocs, Lahi, Gq86, GoranSMilovanovic, Kiailandi, QZanden, dachary, LawExplorer, Wikidata-bugs, aude, Ricordisamoa, Sjoerddebruin, Tpt, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unblock] T176638: Implement Primary Sources filter

2018-02-22 Thread Hjfocs 
Hjfocs closed subtask T178303: Fill SPARQL query template for the domain of interest in the primary sources filter as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T176638EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Afnecors, HjfocsCc: Aklapper, Afnecors, Lahi, Gq86, GoranSMilovanovic, Kiailandi, QZanden, dachary, LawExplorer, Hjfocs, Wikidata-bugs, aude, Ricordisamoa, Sjoerddebruin, Tpt, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T185598: property-suggester-scripts master can't be installed on tool forge

2018-02-22 Thread gerritbot 
gerritbot added a comment.
Change 413260 merged by jenkins-bot:
[wikibase/property-suggester-scripts@master] Include analyzer.ini when installing the library

https://gerrit.wikimedia.org/r/413260TASK DETAILhttps://phabricator.wikimedia.org/T185598EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, Aklapper, hoo, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T174032: Make relevant API modules aware of MCR

2018-02-22 Thread Anomie 
Anomie added a comment.

In T174032#3992704, @daniel wrote:
So, let me re-phrase: the mechanism for combining output of multiple slots (whatever that mechanism may be) should be the same in EditPage, ApiParse, and prepareContentForEdit. Perhaps we want prepareContentForPreview? Something like that.


Yes, the mechanism should be the same. I don't know that "prepareContentForPreview" is a good name if we actually need a function to abstract it, though, particularly since we'd probably want to use much the same code path for actual page views when they're not already cached (the major difference being that previews will want to override the "current revision" of the page being previewed, and perhaps supply a speculative revid callback).TASK DETAILhttps://phabricator.wikimedia.org/T174032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: gerritbot, Aklapper, daniel, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, SandraF_WMF, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, Maathavan, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Anomie, Steinsplitter, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T174032: Make relevant API modules aware of MCR

2018-02-22 Thread daniel 
daniel added a comment.

In T174032#3990712, @Anomie wrote:
If the only change is that we get a content handler per slot and pass the slot role when creating each DifferenceEngine, that's fine, but it's still a change in the signature of ContentHandler::createDifferenceEngine() and DifferenceEngine::__construct().


Ah, you are right - as long as the DifferenceEngine calls getContent on the revision, it needs to know the slot. DifferenceEngine is a bit of a tangle, perhaps it should be split. But adding a constructor argument is the easiest approach for now.

And it should also be possible to specify multiple slots explicitly with text parameters.

It's needed for stuff like the "live preview" feature.

Ok, I see.

Yes - which is "whatever PreparedEdit::getCombinedParserOutput() returns".

ApiParse doesn't actually use WikiPage::prepareContentForEdit(). I don't think it even can, since ApiParse would need to pass in ParserOptions and that method is designed for preparing a ParserOutput for canonical options.

I note that EditPage previews don't use WikiPage::prepareContentForEdit() either, likely because that too wants to use ParserOptions specific to the user.

prepareContentForEdit() actually constructs two ParserOptions: user-specific options for PST, and canonical options for parsing.

But anyway, you are right: the user should see the per-user rendering of the page in preview, since that is what they see after the page has been saved.

So, let me re-phrase: the mechanism for combining output of multiple slots (whatever that mechanism may be) should be the same in EditPage, ApiParse, and prepareContentForEdit. Perhaps we want prepareContentForPreview? Something like that.TASK DETAILhttps://phabricator.wikimedia.org/T174032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc: gerritbot, Aklapper, daniel, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, SandraF_WMF, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, Maathavan, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Anomie, Steinsplitter, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T187876: Improve Graph Explorer on Query.Wikidata.org

2018-02-22 Thread srishakatux 
srishakatux added a comment.
Thanks a lot, @Jonas for willing to mentor this project in #gsoc2018!

A couple comments:


This task misses a few sections that are needed and would be helpful for potential candidates to get started: a brief description of the project, link to the code repository, list of a couple of microtasks, and some getting started instructions. For reference, you could check this project: T185036 (also showcased in GSoC this year).
It would be great if you could consider combining this and T187874 into a parent task.


Thanks again for willing to mentor this round! Looks like a great project for the program. If this is your first time mentoring a project in GSoC, you might want to take a look at the roles and responsibilities of a mentor here: https://www.mediawiki.org/wiki/Google_Summer_of_Code/Mentors.TASK DETAILhttps://phabricator.wikimedia.org/T187876EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: srishakatuxCc: srishakatux, Jonas, Aklapper, Gq86, Lucas_Werkmeister_WMDE, EBjune, merbst, D3r1ck01, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mvolz, Lydia_Pintscher___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs