[Wikidata-bugs] [Maniphest] [Updated] T189745: Index Lexemes and Forms

2018-03-19 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T189745EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, dcausse, Lydia_Pintscher, daniel, Aklapper, Smalyshev, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Avner, Lewizho99, Maathavan, Gehel, FloNight, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189745: Index Lexemes and Forms

2018-03-19 Thread gerritbot
gerritbot added a comment.
Change 420637 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/WikibaseLexeme@master] [WIP] Index Lexemes and Forms

https://gerrit.wikimedia.org/r/420637TASK DETAILhttps://phabricator.wikimedia.org/T189745EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, dcausse, Lydia_Pintscher, daniel, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, Cinemantique, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T189745: Index Lexemes and Forms

2018-03-19 Thread Smalyshev
Smalyshev added projects: User-Smalyshev, Discovery-Search (Current work).
TASK DETAILhttps://phabricator.wikimedia.org/T189745EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: dcausse, Lydia_Pintscher, daniel, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, Cinemantique, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T182271: Wikidata fulltext search should handle search syntax properly

2018-03-19 Thread Smalyshev
Smalyshev closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T182271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Abit, gerritbot, Lydia_Pintscher, Aklapper, dcausse, EBernhardson, daniel, debt, Smalyshev, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Avner, Lewizho99, Maathavan, Gehel, FloNight, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T185589: Repeating blank node ids in Wikidata entity RDF dumps

2018-03-19 Thread Smalyshev
Smalyshev added a subscriber: thiemowmde.Smalyshev added a comment.
Next step I guess would be to create v1.0.7 for purtle and update version in Wikibase. I don't own the packagist module so I assume it's either @daniel or @thiemowmde.TASK DETAILhttps://phabricator.wikimedia.org/T185589EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: thiemowmde, gerritbot, Smalyshev, Aklapper, mkroetzsch, Lucie, Lucas_Werkmeister_WMDE, daniel, hoo, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T185589: Repeating blank node ids in Wikidata entity RDF dumps

2018-03-19 Thread gerritbot
gerritbot added a comment.
Change 420636 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[purtle@master] Update release notes

https://gerrit.wikimedia.org/r/420636TASK DETAILhttps://phabricator.wikimedia.org/T185589EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: thiemowmde, gerritbot, Smalyshev, Aklapper, mkroetzsch, Lucie, Lucas_Werkmeister_WMDE, daniel, hoo, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unblock] T178851: Use label & description index for fulltext search

2018-03-19 Thread Smalyshev
Smalyshev closed subtask T182271: Wikidata fulltext search should handle search syntax properly as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T178851EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Abit, Realworldobject, debt, gerritbot, daniel, EBernhardson, dcausse, Aklapper, Smalyshev, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Avner, Lewizho99, Maathavan, Gehel, FloNight, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T155043: "Don't initialize MWServices super early" causes test failure on .7

2018-03-19 Thread Krinkle
Krinkle closed this task as "Resolved".Krinkle added a project: Wikimedia-log-errors (Jenkins Failure).Krinkle claimed this task.Krinkle added a comment.
Seems resolved. Re-open if it pops back.TASK DETAILhttps://phabricator.wikimedia.org/T155043EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, Reedy, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Merged] T189329: jquery.wikibase.edittoolbar and other qunit tests are flaky

2018-03-19 Thread Krinkle
Krinkle added a subscriber: Tgr.Krinkle merged a task: T186286: Wikibase selenium test is flaky.
TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Smalyshev, Jdlrobson, hoo, Mbch331, Jonas, TerraCodes, Liuxinyu970226, Niharika, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T186286: Wikibase selenium test is flaky

2018-03-19 Thread Krinkle
Krinkle added a project: Wikimedia-log-errors (Jenkins Failure).
TASK DETAILhttps://phabricator.wikimedia.org/T186286EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Tgr, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T186286: Wikibase selenium test is flaky

2018-03-19 Thread Krinkle
Krinkle closed this task as a duplicate of T189329: jquery.wikibase.edittoolbar and other qunit tests are flaky.
TASK DETAILhttps://phabricator.wikimedia.org/T186286EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Tgr, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T190121: Empty statement box is shown when only statement is deprecated

2018-03-19 Thread hoo
hoo created this task.hoo added projects: ArticlePlaceholder, Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONFor example on https://bn.wikipedia.org/wiki/%E0%A6%AC%E0%A6%BF%E0%A6%B6%E0%A7%87%E0%A6%B7:AboutTopic/Q53 the "OSM tag or key" statement box is empty, as the statement is deprecated on Wikidata.

F15892062: image.png

In this case, the statement box should not appear at all.TASK DETAILhttps://phabricator.wikimedia.org/T190121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: Lucie, Lydia_Pintscher, Aklapper, hoo, Lahi, Gq86, GoranSMilovanovic, QZanden, cmadeo, LawExplorer, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T189329: jquery.wikibase.edittoolbar and other qunit tests are flaky

2018-03-19 Thread Krinkle
Krinkle added a project: Wikimedia-log-errors (Jenkins Failure).
TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: hashar, gerritbot, Reedy, Krinkle, dcausse, Smalyshev, Jdlrobson, hoo, Mbch331, Jonas, TerraCodes, Liuxinyu970226, Niharika, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T185589: Repeating blank node ids in Wikidata entity RDF dumps

2018-03-19 Thread gerritbot
gerritbot added a comment.
Change 413288 merged by jenkins-bot:
[purtle@master] Add ability to set bnode labeler to writer & factory

https://gerrit.wikimedia.org/r/413288TASK DETAILhttps://phabricator.wikimedia.org/T185589EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Smalyshev, Aklapper, mkroetzsch, Lucie, Lucas_Werkmeister_WMDE, daniel, hoo, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T177550: Only dump up entities in a certain page_id range in each maintenance script run (days: 1)

2018-03-19 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T177550EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lucas_Werkmeister_WMDE, gerritbot, Lydia_Pintscher, daniel, ArielGlenn, Aklapper, hoo, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T177550: Only dump up entities in a certain page_id range in each maintenance script run (days: 1)

2018-03-19 Thread gerritbot
gerritbot added a comment.
Change 420629 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] DumpEntities: Allow dumping a specific range of page ids

https://gerrit.wikimedia.org/r/420629TASK DETAILhttps://phabricator.wikimedia.org/T177550EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lucas_Werkmeister_WMDE, gerritbot, Lydia_Pintscher, daniel, ArielGlenn, Aklapper, hoo, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T184000: Magic word on English WP to override display of Wikidata short description

2018-03-19 Thread Tgr
Tgr added a comment.
This is now in testwiki (also beta enwiki) and seems to be working well. Just from testing some large API queries, it seems on par with pageterms on performance (both are fairly fast even for thousands of pages). I think it could go to enwiki later this week, but I won't be around. Anyone willing to shepherd https://gerrit.wikimedia.org/r/420227 through SWAT? Otherwise, I can do it next Tuesday.


Display the override in the page information.


Oops, forgot to do that. Not a blocker, I'll add it later.


In T184000#4059476, @Lydia_Pintscher wrote:
@Tgr Are you going to tackle T173144 as well so the remaining descriptions are still being tracked and changes show up in the watchlist?


I'll make an attempt at adding auto-tracking for pages which do not have a manual description (next week, maybe); nothing as generic as the hook proposed in T173144 though.TASK DETAILhttps://phabricator.wikimedia.org/T184000EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TgrCc: Stashbot, WMDE-leszek, Elitre, gerritbot, TheDJ, Fjalapeno, Tbayer, MZMcBride, Alsee, bearND, Mike_Peel, Tgr, JKatzWMF, daniel, Bmueller, Addshore, Lydia_Pintscher, Samwilson, Aklapper, DannyH, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, B20180, Nakon, MusikAnimal, Niharika, Fhocutt, Wikidata-bugs, aude, Ricordisamoa, -jem-, Mbch331, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T184000: Magic word on English WP to override display of Wikidata short description

2018-03-19 Thread gerritbot
gerritbot added a comment.
Change 418843 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable Wikidata description override on testwiki

https://gerrit.wikimedia.org/r/418843TASK DETAILhttps://phabricator.wikimedia.org/T184000EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, gerritbotCc: Stashbot, WMDE-leszek, Elitre, gerritbot, TheDJ, Fjalapeno, Tbayer, MZMcBride, Alsee, bearND, Mike_Peel, Tgr, JKatzWMF, daniel, Bmueller, Addshore, Lydia_Pintscher, Samwilson, Aklapper, DannyH, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, B20180, Nakon, MusikAnimal, Niharika, Fhocutt, Wikidata-bugs, aude, Ricordisamoa, -jem-, Mbch331, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T183020: Investigate the possibility to release Wikidata queries

2018-03-19 Thread leila
leila added a comment.
I did one pass and left a couple of comments at https://meta.wikimedia.org/wiki/User_talk:Markus_Kr%C3%B6tzsch/Wikidata_queriesTASK DETAILhttps://phabricator.wikimedia.org/T183020EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: leilaCc: mkroetzsch, Smalyshev, DarTar, leila, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Avner, Wikidata-bugs, aude, Capt_Swing, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T174038: Implement MCR page update interface

2018-03-19 Thread gerritbot
gerritbot added a comment.
Change 406388 abandoned by Daniel Kinzler:
[MCR] Prepare PreparedEdit for MCR

Reason:
merged this into If610c68f4912e89af616cdcac1d35a1be3946afa

https://gerrit.wikimedia.org/r/406388TASK DETAILhttps://phabricator.wikimedia.org/T174038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, daniel, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, SandraF_WMF, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, Maathavan, Agabi10, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Anomie, Steinsplitter, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T189538: Reduce complexity of Wikibase JS module registration

2018-03-19 Thread Krinkle
Krinkle moved this task from Inbox to Radar on the Performance-Team board.Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.
TASK DETAILhttps://phabricator.wikimedia.org/T189538WORKBOARDhttps://phabricator.wikimedia.org/project/board/1212/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Lydia_Pintscher, gerritbot, thiemowmde, WMDE-leszek, Addshore, Aklapper, Krinkle, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T182271: Wikidata fulltext search should handle search syntax properly

2018-03-19 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)).
TASK DETAILhttps://phabricator.wikimedia.org/T182271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, ReleaseTaggerBotCc: Abit, gerritbot, Lydia_Pintscher, Aklapper, dcausse, EBernhardson, daniel, debt, Smalyshev, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Avner, Lewizho99, Maathavan, Gehel, FloNight, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T190033: Should lemmas of a lexeme, and representations of a form be only allowed to defined one per language/variant code?

2018-03-19 Thread daniel
daniel added a comment.
My 2c, just for the record:

I disagree with the decision, but I don't think it's particularly bad. It means we (and client libraries) can't re-use code that was written for lemmas (e.g. lemmans and representations can't be represented as a JSON object, but will have to be a list). That's inconvenient.

To address the arguments given in the description:


should some possible statements be a decisive factor on how to model form representations?


The need for the ability to apply different statements should be, yes.


are we certain there will always be a statement that make the distinction clear?


This is not necessary.


should the modelling always force users to find the distinction that would either lead to creating a language variant code, or to modelling as separate forms?
with lemmas in mind, statements couldn't be used as a tool to distinguish different variants, i.e. different variant codes would be required. Should users be forced to always provide those different variant codes?


I think this is a useful requirement, yes - though this should not be done by hand. Variant codes such as de-x-wikidata-Q2031873 should be composed using an item selector.

I see how this can be annoying to users, and in some cases difficult. However, I fear that not requiring this may lead to people adding lemmas and representations using very different spelling or even in different scripts all with the same code, giving no indication of which should be used when. We then need ranks for lemmas and representations, which would complicate the model quite a bit.

In any case, please not that this is a modification of the abstract model. The specification needs to be changed to accommodate it, not just the internal data structures.TASK DETAILhttps://phabricator.wikimedia.org/T190033EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, danielCc: Lydia_Pintscher, WMDE-leszek, Aklapper, daniel, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T190066: Expose all slots to the search interface

2018-03-19 Thread EBernhardson
EBernhardson added a comment.

At least for cirrus, it pretty much needs to be one document if we want any kind of interaction between fields of multiple content types.



I think, again only wrt cirrus, this is going to depend heavily on how those fields get into the queries issued.  The current method with a variety of hard coded field names really pushes for the ability to overwrite, such as work on file media info which will overwrite opening_text field on file pages.  The two will have to be figured out in parallel i suppose.
TASK DETAILhttps://phabricator.wikimedia.org/T190066EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: EBernhardsonCc: EBernhardson, dcausse, Aklapper, -jem-, Lokal_Profil, Smalyshev, TomT0m, Liuxinyu970226, Agabi10, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, SandraF_WMF, GoranSMilovanovic, QZanden, EBjune, Tramullas, Acer, LawExplorer, Avner, Gehel, FloNight, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, jayvdb, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T190066: Expose all slots to the search interface

2018-03-19 Thread daniel
daniel added a comment.

In T190066#4062068, @Smalyshev wrote:

If the answer is one document, how to reconcile slots with potential intersections? I.e., if both slots want to put something in opening_text, what happens? Etc.



For now, I'd blindly concatenate. That's the baseline. 
We have to answer similar questions for a lot of things, including the generation of the HTML the user will see. I plan an RFC about that question.TASK DETAILhttps://phabricator.wikimedia.org/T190066EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: EBernhardson, dcausse, Aklapper, -jem-, Lokal_Profil, Smalyshev, TomT0m, Liuxinyu970226, Agabi10, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, SandraF_WMF, GoranSMilovanovic, QZanden, EBjune, Tramullas, Acer, LawExplorer, Avner, Gehel, FloNight, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, jayvdb, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T187198: Disable Senses in the API for the initial version of the WikibaseLexeme extension

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- wbremoveclaims
... TODO: more?Possible also:
- wbgetentities
- wbgetclaims

Should use the existing LexemeEnableSenses feature toggleTASK DETAILhttps://phabricator.wikimedia.org/T187198EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Story, Lydia_Pintscher, Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T190033: Should lemmas of a lexeme, and representations of a form be only allowed to defined one per language/variant code?

2018-03-19 Thread WMDE-leszek
WMDE-leszek added a comment.
Decision: change the internal data structure to something that does not make the assumption on the one-per-language code element. See T190057 and T190060 for relevant tasks.
@Lydia_Pintscher: For any user-facing changes (i.e. what behaviour UI should have if having a multiple lemmas per language code was not allowed), it could either be specified in those two tasks respectively, or separate tickets could be open to be fixed later.TASK DETAILhttps://phabricator.wikimedia.org/T190033EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Lydia_Pintscher, WMDE-leszek, Aklapper, daniel, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T190033: Should lemmas of a lexeme, and representations of a form be only allowed to defined one per language/variant code?

2018-03-19 Thread WMDE-leszek
WMDE-leszek closed this task as "Resolved".WMDE-leszek claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T190033EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Lydia_Pintscher, WMDE-leszek, Aklapper, daniel, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T190066: Expose all slots to the search interface

2018-03-19 Thread Smalyshev
Smalyshev added subscribers: dcausse, EBernhardson.Smalyshev added a project: CirrusSearch.Smalyshev added a comment.Herald added a project: Discovery.
Two big questions here are:


One document or multiple documents? (I think the trend is for now for one document)
If the answer is one document, how to reconcile slots with potential intersections? I.e., if both slots want to put something in opening_text, what happens? Etc.
TASK DETAILhttps://phabricator.wikimedia.org/T190066EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: EBernhardson, dcausse, Aklapper, -jem-, Lokal_Profil, Smalyshev, TomT0m, Liuxinyu970226, Agabi10, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, SandraF_WMF, GoranSMilovanovic, QZanden, EBjune, Tramullas, Acer, LawExplorer, Avner, Gehel, FloNight, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, jayvdb, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T182271: Wikidata fulltext search should handle search syntax properly

2018-03-19 Thread gerritbot
gerritbot added a comment.
Change 395894 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Redirect queries with advanced syntax to the old search

https://gerrit.wikimedia.org/r/395894TASK DETAILhttps://phabricator.wikimedia.org/T182271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, gerritbotCc: Abit, gerritbot, Lydia_Pintscher, Aklapper, dcausse, EBernhardson, daniel, debt, Smalyshev, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Avner, Lewizho99, Maathavan, Gehel, FloNight, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189762: selenium test for Wikibase is unstable

2018-03-19 Thread Smalyshev
Smalyshev added a comment.
Seems to be still happening. See: https://integration.wikimedia.org/ci/job/mwext-mw-selenium-composer-jessie/9226/consoleTASK DETAILhttps://phabricator.wikimedia.org/T189762EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: zeljkofilipin, Legoktm, Aklapper, Smalyshev, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Liudvikas, Luke081515, thcipriani, Wikidata-bugs, aude, Mbch331, Jay8g, hashar, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189593: (De)serialize CheckResults in CachingResultsBuilder

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.
Oh, and we need a place where we actually do the conversion of CheckResults to arrays and store them all in the giant result structure, since ResultsSource doesn’t do that anymore. (This is also the step where ViolationMessages are rendered.) Is that a CheckResultsRenderer?TASK DETAILhttps://phabricator.wikimedia.org/T189593EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189593: (De)serialize CheckResults in CachingResultsBuilder

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.
I suppose it could be just a ResultsSource. Very generic, but matches ResultsBuilder. CheckingResultsSource and CachingResultsSource don’t sound too bad to me.TASK DETAILhttps://phabricator.wikimedia.org/T189593EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189593: (De)serialize CheckResults in CachingResultsBuilder

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.
Perhaps a CheckResultsSource? But that doesn’t really yield any good names for the implementation (a CheckingCheckResultsSource?).TASK DETAILhttps://phabricator.wikimedia.org/T189593EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T188551: Facilitate conversation on Commons about the future of file titles

2018-03-19 Thread Keegan
Keegan edited projects, added Community-Liaisons (Apr-Jun-2018); removed Community-Liaisons (Jan-Mar-2018).
TASK DETAILhttps://phabricator.wikimedia.org/T188551EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KeeganCc: Aklapper, Keegan, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, Ivana_Isadora, QZanden, Tramullas, Acer, V4switch, LawExplorer, Jseddon, FloNight, Trizek-WMF, Susannaanas, Wong128hk, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Bawolff, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331, Elitre, Qgil___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T186237: Document liaison communication strategy for Structured Data on Commons

2018-03-19 Thread Keegan
Keegan closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T186237EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KeeganCc: Aklapper, Keegan, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, Ivana_Isadora, QZanden, Tramullas, Acer, LawExplorer, Jseddon, FloNight, Trizek-WMF, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Elitre, Qgil___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unblock] T182672: [Epic] Facilitate community conversations and feedback about prototypes and designs for Structured Data on Wikimedia Commons

2018-03-19 Thread Keegan
Keegan closed subtask T186237: Document liaison communication strategy for Structured Data on Commons as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T182672EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KeeganCc: Keegan, Ramsey-WMF, Abit, SandraF_WMF, Aklapper, Lahi, PDrouin-WMF, Gq86, E1presidente, Cparle, GoranSMilovanovic, Ivana_Isadora, QZanden, Tramullas, Acer, LawExplorer, Jseddon, FloNight, Trizek-WMF, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Elitre, Qgil___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T189593: (De)serialize CheckResults in CachingResultsBuilder

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task.Lucas_Werkmeister_WMDE moved this task from Tasks to In Progress on the Wikidata-Ministry-Of-Magic board.
TASK DETAILhttps://phabricator.wikimedia.org/T189593WORKBOARDhttps://phabricator.wikimedia.org/project/board/3273/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189593: (De)serialize CheckResults in CachingResultsBuilder

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.
So what do we have instead?


CachedCheckResults: wrapper around CheckResult[] + Metadata. (Note: since the results may be filtered, the overall metadata may be more than the merge of the individual CheckResult metadatas!)
something which takes the same parameters as ResultsBuilder::getResults (entity IDs, claim IDs, constraint IDs, statuses), but returns CachedCheckResults instead of a CachedCheckConstraintsResponse. I don’t have a good name for this yet… it does even less than ResultsBuilder did (at least the implementation that doesn’t do caching). A ResultsGatherer, perhaps? But CachingResultsGatherer doesn’t really make too much sense.
TASK DETAILhttps://phabricator.wikimedia.org/T189593EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T190066: Expose all slots to the search interface

2018-03-19 Thread daniel
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Epic, Structured-Data-Commons, Multi-Content-Revisions, Discovery-Search.
TASK DESCRIPTIONSearch engines such as Cirrus should examine the content of all slots when updating the search index.TASK DETAILhttps://phabricator.wikimedia.org/T190066EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, -jem-, Lokal_Profil, Smalyshev, TomT0m, Liuxinyu970226, Agabi10, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, EBjune, Tramullas, Acer, LawExplorer, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T174038: Implement MCR page update interface

2018-03-19 Thread daniel
daniel added a subtask: T190063: Tracking dependencies for multiple Content objects per page (MCR).
TASK DETAILhttps://phabricator.wikimedia.org/T174038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Aklapper, daniel, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, SandraF_WMF, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, Maathavan, Agabi10, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Anomie, Steinsplitter, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T190057: Allow to store multiple lemmas using the same language code

2018-03-19 Thread WMDE-leszek
WMDE-leszek triaged this task as "High" priority.WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...For the existing data stored in the database of the demo system, and possible other development instances, the conversion of the data could be provided by adding the needed functionality to LexemeSerializationUpdater (if found necessary).

Pointers:
- StorageLexemeSerializer is the service generating the structure stored in the database
- ExternaLexemeSerializer is the service generating the structure exposed externall, e.g. by get entities API action, or Special:EntityData page (JSON format)TASK DETAILhttps://phabricator.wikimedia.org/T190057EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T190060: Allow to store multiple form representations using the same language code

2018-03-19 Thread WMDE-leszek
WMDE-leszek triaged this task as "High" priority.WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...For the existing data stored in the database of the demo system, and possible other development instances, the conversion of the data could be provided by adding the needed functionality to LexemeSerializationUpdater (if found necessary).

Pointers:
- FormSerializer is the service generating the structure stored in the database, and also used e.g. by get entities API actionTASK DETAILhttps://phabricator.wikimedia.org/T190060EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T190060: Allow to store multiple form representations using the same language code

2018-03-19 Thread WMDE-leszek
WMDE-leszek created this task.WMDE-leszek added projects: Wikidata, Lexicographical data.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONTODO: define the behaviour in the UI

Note that as of 2018-03-19, the data structure used for internal storage of the lexeme data is assuming there only a single form representation for a given language code.

For the existing data stored in the database of the demo system, and possible other development instances, the conversion of the data could be provided by adding the needed functionality to LexemeSerializationUpdater (if found necessary)TASK DETAILhttps://phabricator.wikimedia.org/T190060EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T184745: Handle config variables of lexeme in production before the first release

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...Variables to set:
- TODO: the one above check the name and value- $wgWBClientSettings['disabledAccessEntityTypes'] = [ 'lexeme', 'form', 'sense' ];
- language code property: name: `$wgLexemeLanguageCodePropertyId` value: "P219" (?)- $wgWBRepoSettings['disabledRdfExportEntityTypes'] = ['lexeme', 'form', 'sense' ];
- - language code property: name: `$wgLexemeEnableSenses: falseLanguageCodePropertyId` value: "P219" (?)
- more?- $wgLexemeEnableSenses: falseTASK DETAILhttps://phabricator.wikimedia.org/T184745EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: daniel, Aklapper, Lydia_Pintscher, Lea_Lacroix_WMDE, PokestarFan, Ladsgroup, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T184745: Handle config variables of lexeme in production before the first release

2018-03-19 Thread Jakob_WMDE
Jakob_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- language code property: TODO: name andname: `$wgLexemeLanguageCodePropertyId` value: "P219" (?)
- LexemeEnableSenses: false...TASK DETAILhttps://phabricator.wikimedia.org/T184745EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: daniel, Aklapper, Lydia_Pintscher, Lea_Lacroix_WMDE, PokestarFan, Ladsgroup, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T190057: Allow to store multiple lemmas using the same language code

2018-03-19 Thread WMDE-leszek
WMDE-leszek created this task.WMDE-leszek added projects: Lexicographical data, Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONTODO: define the behaviour in the UI

Note that as of 2018-03-19, the data structure used for internal storage of the lexeme data is assuming there only a single lemma for a given language code.

For the existing data stored in the database of the demo system, and possible other development instances, the conversion of the data could be provided by adding the needed functionality to LexemeSerializationUpdater (if found necessary)TASK DETAILhttps://phabricator.wikimedia.org/T190057WORKBOARDhttps://phabricator.wikimedia.org/project/board/2292/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189593: (De)serialize CheckResults in CachingResultsBuilder

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.
Hm, we don’t need a hybrid phase, but this is still a big change – and it pretty much invalidates the current interface of CachedCheckConstraintsResponse and ResultsBuilder, so perhaps it would be better to build up a new interface with new implementations in several commits, and then remove the old implementations afterwards, so it’s not in one huge, monolithic commit.TASK DETAILhttps://phabricator.wikimedia.org/T189593EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T185549: "Limit" button is not translated

2018-03-19 Thread gerritbot
gerritbot added a comment.
Change 420363 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Extract generation of i18n spans into function

https://gerrit.wikimedia.org/r/420363TASK DETAILhttps://phabricator.wikimedia.org/T185549EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Rammanojpotla, Amire80, Aklapper, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, Srdjan_m, Jonas, Xmlizer, MuhammadShuaib, LNDDYL, Psychoslave, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Gryllida, Shizhao, Lydia_Pintscher, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T189538: Reduce complexity of Wikibase JS module registration

2018-03-19 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)).
TASK DETAILhttps://phabricator.wikimedia.org/T189538EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ReleaseTaggerBotCc: Lydia_Pintscher, gerritbot, thiemowmde, WMDE-leszek, Addshore, Aklapper, Krinkle, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T184745: Handle config variables of lexeme in production before the first release

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- TODO: the one above check the name and value
- language code property: TODO: name and value
- LexemeEnableSenses: false...TASK DETAILhttps://phabricator.wikimedia.org/T184745EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: daniel, Aklapper, Lydia_Pintscher, Lea_Lacroix_WMDE, PokestarFan, Ladsgroup, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T184745: Handle config variables of lexeme in production before the first release

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... - {T182660}

Variables to set:
- TODO: the one above check the name and value
- LexemeEnableSenses: false
- more?TASK DETAILhttps://phabricator.wikimedia.org/T184745EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: daniel, Aklapper, Lydia_Pintscher, Lea_Lacroix_WMDE, PokestarFan, Ladsgroup, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189875: Migrate “exception” check results to ViolationMessage

2018-03-19 Thread gerritbot
gerritbot added a comment.
Change 420356 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for constraint exceptions

https://gerrit.wikimedia.org/r/420356TASK DETAILhttps://phabricator.wikimedia.org/T189875EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Aklapper, gerritbot, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T189875: Migrate “exception” check results to ViolationMessage

2018-03-19 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T189875EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Aklapper, gerritbot, Lucas_Werkmeister_WMDE, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T165579: New data type to allow linking to Forms

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...**And** I put an ID of the form in the value fieldd
**Then** the entered ID is shown in the suggester
**ThenAnd** I see the save button enabled ...**And** The representation to the reference frod form is displayed 
**And** The representation links to the section ion the Lexeme page ...TASK DETAILhttps://phabricator.wikimedia.org/T165579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Aleksey_WMDE, PokestarFan, Jonas, WMDE-leszek, thiemowmde, Aklapper, Lydia_Pintscher, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T189875: Migrate “exception” check results to ViolationMessage

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from Tasks to In Progress on the Wikidata-Ministry-Of-Magic board.Lucas_Werkmeister_WMDE added a comment.
How much effort is it to rename a message?

translatewiki:FAQ#Is it possible to rename message keys? says I should just do the rename and not worry about anything else… which sounds almost too good to be true ;) but I guess I’ll upload a patch and see what reviewers say.TASK DETAILhttps://phabricator.wikimedia.org/T189875WORKBOARDhttps://phabricator.wikimedia.org/project/board/3273/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, gerritbot, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T165579: New data type to allow linking to Forms

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...**And** The edit is recorded in the edit history. TODO: specify summary
TASK DETAILhttps://phabricator.wikimedia.org/T165579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Aleksey_WMDE, PokestarFan, Jonas, WMDE-leszek, thiemowmde, Aklapper, Lydia_Pintscher, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T165579: New data type to allow linking to Forms

2018-03-19 Thread RazShuty
RazShuty updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...**When** I save a new statement with a data type form...TASK DETAILhttps://phabricator.wikimedia.org/T165579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: RazShutyCc: Aleksey_WMDE, PokestarFan, Jonas, WMDE-leszek, thiemowmde, Aklapper, Lydia_Pintscher, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T165579: New data type to allow linking to Forms

2018-03-19 Thread RazShuty
RazShuty updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* {T175030}

**//`BDD Happy Path:`//**

**Given** I am on the Lexeme Page
**When** I make a new statement 
**And** I put an ID in the value field
**Then** I see the save button enabled 
**And** The value border is now green for approval
**And** I can save

**Given** I am on the Lexeme Page
**When** I save a new statement with a data type form
**Then** A new statement appears 
**And** The representation to the reference from is displayed 
**And** The representation links to the section in the Lexeme page 
**And** The edit is recorded in the edit history 
TASK DETAILhttps://phabricator.wikimedia.org/T165579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: RazShutyCc: Aleksey_WMDE, PokestarFan, Jonas, WMDE-leszek, thiemowmde, Aklapper, Lydia_Pintscher, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T188728: Replace claim with violation message in Special:ConstraintReport

2018-03-19 Thread Charlie_WMDE
Charlie_WMDE moved this task from Incoming to WMDE-Design-Workboard Doing on the WMDE-Design board.Charlie_WMDE edited projects, added WMDE-Design (WMDE-Design-Workboard Doing); removed WMDE-Design.
TASK DETAILhttps://phabricator.wikimedia.org/T188728WORKBOARDhttps://phabricator.wikimedia.org/project/board/1944/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Charlie_WMDECc: gerritbot, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper, Lucas_Werkmeister_WMDE, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, JGirault, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T189604: Create icon for “exception for constraint” status

2018-03-19 Thread Jan_Dittrich
Jan_Dittrich triaged this task as "Low" priority.Jan_Dittrich updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONStory: As a user I want that the same elements in the UI mean the same things. 

Suggestion: Since we’re going to show “exception” results on the `Special:ConstraintReport` special page, and all other statuses shown there have icons (see T188728), it would be nice to have an icon for the “exception” status as well. The description of exception is: “This entity is a known exception for this constraint and has been marked as such.”. 

CCing @Hanna_Petruschat_WMDE, who created the nice “violation” and “warning” icons we have today :)TASK DETAILhttps://phabricator.wikimedia.org/T189604EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jan_DittrichCc: Lucas_Werkmeister_WMDE, Hanna_Petruschat_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, JGirault, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T165579: New data type to allow linking to Forms

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* I can select the Form via an entity selector that shows me a derived label forby entering the ID of the referenced FormNeeds to be broken down into:
* Defining the data type (S)
* Adding a new statement link* Defining to a form (just by ID) via the UI (S)he data type
* Improv* Adding the selector with search + showa new statement linking a label (might be postponed)to a form (just by ID) via the UI
* {T175030}TASK DETAILhttps://phabricator.wikimedia.org/T165579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Aleksey_WMDE, PokestarFan, Jonas, WMDE-leszek, thiemowmde, Aklapper, Lydia_Pintscher, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T169333: Update license information on Wikidata to make Lexeme namespace CC-0

2018-03-19 Thread Addshore
Addshore added a comment.
This message is provided by the WikimediaMessages extension (apparently).

"wikidata-copyright": "All structured data from the main and property namespace is available under the https://creativecommons.org/publicdomain/zero/1.0/\" title=\"Definition of the Creative Commons CC0 License\">Creative Commons CC0 License;\ntext in the other namespaces is available under the https://creativecommons.org/licenses/by-sa/3.0/\" title=\"Definition of the Creative Commons Attribution-ShareAlike License\">Creative Commons Attribution-ShareAlike License;\nadditional terms may apply.\nSee https://wikimediafoundation.org/wiki/Terms_of_Use\" title=\"Wikimedia Foundation Terms of Use\">Terms of Use for details.",

We should update this in the extensionTASK DETAILhttps://phabricator.wikimedia.org/T169333EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Lea_Lacroix_WMDE, Lydia_Pintscher, Psychoslave, Liuxinyu970226, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T169333: Update license information on Wikidata to make Lexeme namespace CC-0

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...must be updated to include the lexeme namespace in the structured data / CC0 namespace list.

Update the XXX message in WikimediaMessages extensionTASK DETAILhttps://phabricator.wikimedia.org/T169333EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Addshore, Lea_Lacroix_WMDE, Lydia_Pintscher, Psychoslave, Liuxinyu970226, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T189777: Disable reading from term_search_key from wb_terms table in wikidata

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE renamed this task from "Enable reading from term_search_key from wb_terms table in wikidata" to "Disable reading from term_search_key from wb_terms table in wikidata".
TASK DETAILhttps://phabricator.wikimedia.org/T189777EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Jonas, Lucas_Werkmeister_WMDE, Aklapper, Lydia_Pintscher, gerritbot, Ladsgroup, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T187198: Disable Senses in the API for the initial version of the WikibaseLexeme extension

2018-03-19 Thread WMDE-leszek
WMDE-leszek renamed this task from "Disable Senses in the API for the initial version of the WikibaseLexeme extension [M]" to "Disable Senses in the API for the initial version of the WikibaseLexeme extension".
TASK DETAILhttps://phabricator.wikimedia.org/T187198EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Story, Lydia_Pintscher, Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T187198: Disable Senses in the API for the initial version of the WikibaseLexeme extension [M]

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION.. TODO: more?

Should use the existing LexemeEnableSenses feature toggle.

Acceptance criteria:...TASK DETAILhttps://phabricator.wikimedia.org/T187198EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Story, Lydia_Pintscher, Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T187198: Disable Senses in the API for the initial version of the WikibaseLexeme extension [M]

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONAPI actions should not handle any requests related to senses.

API actions involved:
- wbeditentity
- wbsetclaim
- wbremoveclaims
... TODO: more?

Acceptance criteria:...* If the API input contains senses, the API should generate an error message: TODO: specify the message (possibly referring the ticket about fixing the temporary limitation).TASK DETAILhttps://phabricator.wikimedia.org/T187198EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Story, Lydia_Pintscher, Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T189776: Disable reading from term_search_key from wb_terms table in beta cluster and testwikidata

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from In Progress to Needs Review on the Wikidata-Ministry-Of-Magic board.Lucas_Werkmeister_WMDE added a comment.
Meh, implemented the testwikidata part myself, so back to “needs review” we go :)TASK DETAILhttps://phabricator.wikimedia.org/T189776WORKBOARDhttps://phabricator.wikimedia.org/project/board/3273/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Lucas_Werkmeister_WMDECc: Jonas, Lucas_Werkmeister_WMDE, Aklapper, Lydia_Pintscher, gerritbot, Ladsgroup, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189776: Disable reading from term_search_key from wb_terms table in beta cluster and testwikidata

2018-03-19 Thread gerritbot
gerritbot added a comment.
Change 420336 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[operations/mediawiki-config@master] Disable reading wb_terms search fields on testwikidata

https://gerrit.wikimedia.org/r/420336TASK DETAILhttps://phabricator.wikimedia.org/T189776EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Jonas, Lucas_Werkmeister_WMDE, Aklapper, Lydia_Pintscher, gerritbot, Ladsgroup, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189538: Reduce complexity of Wikibase JS module registration

2018-03-19 Thread gerritbot
gerritbot added a comment.
Change 419489 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Inline WikibaseView resource files directly accessing global vars

https://gerrit.wikimedia.org/r/419489TASK DETAILhttps://phabricator.wikimedia.org/T189538EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lydia_Pintscher, gerritbot, thiemowmde, WMDE-leszek, Addshore, Aklapper, Krinkle, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T186726: Security review WikibaseLexeme extension

2018-03-19 Thread Bawolff
Bawolff closed this task as "Resolved".Bawolff added a comment.
Yep, you are good.TASK DETAILhttps://phabricator.wikimedia.org/T186726EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BawolffCc: Jakob_WMDE, Jonas, gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Ladsgroup, thiemowmde, Lydia_Pintscher, WMDE-leszek, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, dpatrick, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unblock] T168260: Deploy WikibaseLexeme extension on Wikimedia cluster

2018-03-19 Thread Bawolff
Bawolff closed subtask T186726: Security review WikibaseLexeme extension as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T168260EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BawolffCc: Addshore, Aklapper, daniel, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T189186: label not shown for grammatical feature in diff of a Form

2018-03-19 Thread Jakob_WMDE
Jakob_WMDE claimed this task.Jakob_WMDE moved this task from ToDo to Doing on the Wikidata-Turtles-18.03.14 board.
TASK DETAILhttps://phabricator.wikimedia.org/T189186WORKBOARDhttps://phabricator.wikimedia.org/project/board/3292/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: Addshore, Aklapper, Lydia_Pintscher, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T189842: Undefined index error in CachingResultsBuilder when checking constraints on empty entity

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...Not sure what the best solution for this will be… probably some kind of `NullContextCursor` (only entity ID, no statement etc.) that we can plug into the `NullResult` we already have from T178160?

#patch-for-review (two chains):
- quick fix:
  - [workaround](https://gerrit.wikimedia.org/r/420010)
- proper fix:
  - [refactoring](https://gerrit.wikimedia.org/r/420319)
  - [add `EntityContextCursor`](https://gerrit.wikimedia.org/r/420320)
  - [actual fix](https://gerrit.wikimedia.org/r/420321)TASK DETAILhttps://phabricator.wikimedia.org/T189842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Reedy, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189842: Undefined index error in CachingResultsBuilder when checking constraints on empty entity

2018-03-19 Thread gerritbot
gerritbot added a comment.
Change 420321 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Ensure that result is populated even for empty entities

https://gerrit.wikimedia.org/r/420321TASK DETAILhttps://phabricator.wikimedia.org/T189842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Reedy, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189842: Undefined index error in CachingResultsBuilder when checking constraints on empty entity

2018-03-19 Thread gerritbot
gerritbot added a comment.
Change 420319 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Replace NullResult’s Context with ContextCursor

https://gerrit.wikimedia.org/r/420319TASK DETAILhttps://phabricator.wikimedia.org/T189842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Reedy, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189842: Undefined index error in CachingResultsBuilder when checking constraints on empty entity

2018-03-19 Thread gerritbot
gerritbot added a comment.
Change 420320 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add EntityContextCursor

https://gerrit.wikimedia.org/r/420320TASK DETAILhttps://phabricator.wikimedia.org/T189842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Reedy, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T190039: CirrusSearch smoke selenium tests cause failures of mediawiki-core-qunit-selenium-jessie job for extensions

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...Our extension installs CirrusSearch as a part of the test environment, and apparently said job does not compute together with the way CirrusSearch structures its selenium tests, see the test failure: https://integration.wikimedia.org/ci/job/mediawiki-core-qunit-selenium-jessie/16892955/consoleTASK DETAILhttps://phabricator.wikimedia.org/T190039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Browser-Tests, zeljkofilipin, Addshore, hashar, WMDE-leszek, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, thcipriani, Wikidata-bugs, aude, Darkdadaah, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T190039: CirrusSearch smoke selenium tests cause failures of mediawiki-core-qunit-selenium-jessie job for extensions

2018-03-19 Thread hashar
hashar added subscribers: zeljkofilipin, Browser-Tests.hashar added a comment.
I guess @zeljkofilipin can look into it and offer some recommendation :]TASK DETAILhttps://phabricator.wikimedia.org/T190039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: Browser-Tests, zeljkofilipin, Addshore, hashar, WMDE-leszek, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, thcipriani, Wikidata-bugs, aude, Darkdadaah, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189842: Undefined index error in CachingResultsBuilder when checking constraints on empty entity

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.
This is already a violation of the wbcheckconstraints API, I think (consumers should probably be able to expect the entity ID and an empty claims array, at least)

Well, not quite… we actually work around this in CheckConstraints.php itself, so the API end-user never sees this :) but this fix belongs into the proper constraint checking machinery, not tacked onto it in the API wrapper like that, IMHO.TASK DETAILhttps://phabricator.wikimedia.org/T189842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Reedy, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T190039: CirrusSearch smoke selenium tests cause failures of mediawiki-core-qunit-selenium-jessie job for extensions

2018-03-19 Thread WMDE-leszek
WMDE-leszek created this task.WMDE-leszek added projects: Wikidata, Lexicographical data, Continuous-Integration-Infrastructure.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONBackground: discovered when adding a node selenium test to WikibaseLexeme extension.

In order to run node selenium tests of the extension, we've added mediawiki-core-qunit-selenium-jessie job to extension config template (see https://gerrit.wikimedia.org/r/#/c/419479/). I've assumed that this job runs all node selenium tests of MW core, and all installed extensions. This seemed like a reasonable thing to do as a part of tests of the extension.

Our extension installs CirrusSearch as a part of the test environment, and apparently said job does not compute together with the way CirrusSearch structures its selenium tests, see the test failure: https://integration.wikimedia.org/ci/job/mediawiki-core-qunit-selenium-jessie/16892/console.

Apparently CirrusSearch has its regular selenium tests in tests/integration, and runs them using the npm job. tests/selenium only contains smoke tests, which, according to README (https://phabricator.wikimedia.org/diffusion/ECIR/browse/master/tests/selenium/README.md), are run daily targeting beta enwiki. In other words, CirrusSearch does not even use mediawiki-core-qunit-selenium-jessie in their test pipeline. And no wonder those smoke tests fail when run targeting local wiki as part of our CI build.

So it could be that tests/selenium is not the place the extension should their "normal" selenium tests. We could have made a mistake in WikibaseLexeme, but it seemed other extensions, e.g. AdvancedSearch, or Popups have made it too.

What would be a reasonable and right thing to do here? We don't want to force CirrusSearch to change anything, clearly this structure makes sense for them. We'd prefer to use a tests/selenium as a directory to store our tests though, and also skipping CirrusSearch from the test environment is also not really an option.
Should we move our selenium tests to some other dir, not use mediawiki-core-qunit-selenium-jessie, and have them run using npm test, using something similar CirrusSearch does: https://phabricator.wikimedia.org/diffusion/ECIR/browse/master/Gruntfile.jsTASK DETAILhttps://phabricator.wikimedia.org/T190039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Addshore, hashar, WMDE-leszek, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, thcipriani, Wikidata-bugs, aude, Darkdadaah, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T189842: Undefined index error in CachingResultsBuilder when checking constraints on empty entity

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a project: Wikidata-Ministry-Of-Magic.
TASK DETAILhttps://phabricator.wikimedia.org/T189842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Reedy, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T189842: Undefined index error in CachingResultsBuilder when checking constraints on empty entity

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from Tasks to In Progress on the Wikidata-Ministry-Of-Magic board.Lucas_Werkmeister_WMDE claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T189842WORKBOARDhttps://phabricator.wikimedia.org/project/board/3273/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Reedy, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T178047: Investigate why wikidata abstracts dumps are so large

2018-03-19 Thread ArielGlenn
ArielGlenn added a comment.
Does anyone know where the schema for these xml files lives? I've grepped around in mw core and in the abstract extension repos and found nothing.TASK DETAILhttps://phabricator.wikimedia.org/T178047EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlennCc: gerritbot, hoo, ArielGlenn, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, gnosygnu, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T189143: "Grammatical features" string on a Form of a Lexeme is not translatable

2018-03-19 Thread Lydia_Pintscher
Lydia_Pintscher closed this task as "Resolved".Lydia_Pintscher added a comment.
\o/TASK DETAILhttps://phabricator.wikimedia.org/T189143EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, Lydia_PintscherCc: Pablo-WMDE, Jakob_WMDE, gerritbot, Aklapper, Lydia_Pintscher, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Darkdadaah, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189937: Allow to show linebreaks in results of wikidata query UI

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.
An alternative solution would be to wrap results optionally in a  element (e. g., if the string has a certain language code, like qqx-code), which would give you support not only for \n but also for \t. Do you think that would be useful? (Downside: it would be extremely hard to discover.)TASK DETAILhttps://phabricator.wikimedia.org/T189937EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, MichaelSchoenitzer, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189143: "Grammatical features" string on a Form of a Lexeme is not translatable

2018-03-19 Thread Jakob_WMDE
Jakob_WMDE added a comment.
@Lydia_Pintscher product review: https://wikidata-lexeme.wmflabs.org/index.php/Lexeme:L15?uselang=qqx previously hardcoded "Grammatical features" now says "(wikibaselexeme-form-grammatical-features)"TASK DETAILhttps://phabricator.wikimedia.org/T189143EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: Pablo-WMDE, Jakob_WMDE, gerritbot, Aklapper, Lydia_Pintscher, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Darkdadaah, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T173774: Create script to dump recently changed categories

2018-03-19 Thread Lea_WMDE
Lea_WMDE added a project: Advanced-Search.Herald added a project: TCB-Team.
TASK DETAILhttps://phabricator.wikimedia.org/T173774EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, Lea_WMDECc: Charlie_WMDE, Lea_WMDE, EBernhardson, ArielGlenn, gerritbot, Aklapper, daniel, Lydia_Pintscher, Smalyshev, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Maathavan, Gehel, Jonas, FloNight, Xmlizer, KasiaWMDE, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Svick, Manybubbles, jayvdb, Tobi_WMDE_SW, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189677: Set up the "Hello World" JS browser test

2018-03-19 Thread gerritbot
gerritbot added a comment.
Change 419479 merged by jenkins-bot:
[integration/config@master] Run node selenium tests as part of WikibaseLexeme CI build

https://gerrit.wikimedia.org/r/419479TASK DETAILhttps://phabricator.wikimedia.org/T189677EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, gerritbotCc: gerritbot, Aklapper, WMDE-leszek, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T190033: Should lemmas of a lexeme, and representations of a form be only allowed to defined one per language/variant code?

2018-03-19 Thread WMDE-leszek
WMDE-leszek created this task.WMDE-leszek added projects: Wikidata, Lexicographical data.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONCurrently users are only allowed to store a single lemma, or form representation for a given language/language variant code. In other words, I could have a lexeme with lemmas:


color, en-us,
colour, en-gb


but I couldn't have:


color, en
colour, en.


In latter case, I would either mean to use different language code for lemma variants, or change the way I model to have color and colour modelled as separate lexemes (with a single lemma variant each). Similar applies to form representations.

When doing the edit on the lexeme page, user is not informed on such limitation. The UI pretends that two lemmas/representations are defined with the same language code (as seen on screenshots below), but after reloading the page, and loading the data from the database user sees than only the latest entry for the language code is actually being stored.

F15879879: multiple-lemmas.png
F15879884: mutliple-representations.png

The question whether it should be possible to store multiple form representations and/or lemmas has been briefly discussed in the email conversation in 2017 (with the particular focus on form representations). Then @daniel concluded, referring to "lit" and "lighted" being two representations of the hypothetical form:

"lit" and "lighted" indeed have to be separate forms (with the same grammatical features set). The justification is that statements that apply to one may not apply to the other: rhymes-with, first known usage, region or time of use, example quotation, syllabification, pronunciation audio - even different spellings! All these would be different, so "lit" and "lighted" have to be separate forms.

Two representations leading to a different sets of statements, and thus to them being representation of two different forms has seemed a convincing argument for me at first. Then I am having seconds thoughts:


should some possible statements be a decisive factor on how to model form representations?
are we certain there will always be a statement that make the distinction clear?
should the modelling always force users to find the distinction that would either lead to creating a language variant code, or to modelling as separate forms?
with lemmas in mind, statements couldn't be used as a tool to distinguish different variants, i.e. different variant codes would be required. Should users be forced to always provide those different variant codes?


Question: Should users be only allowed to provide a single lemma, or single form representation with the given language variant code.

Note: the question how to handle this in the UI might be considered at some later point. As the way the lexeme data is currently stored in the database also assumes there is a single lemma or form representation for a given language code (i.e. they're stored as language => data maps). If this was to be changed, this would mean that the code reading from database would potentially need to handle the data stored in the old format too. If the change of the behaviour, and/or the interal storage format is likely, it might be worth doing it before the WikibaseLexeme is deployed in the production environment, so there is no need to deal with the legacy format.

Accidentally, getentities API uses the same structure for lemmas and form representations as used for internal storage. The current format could be observed there (example taken from https://wikidata-lexeme.wmflabs.org/api.php?action="">)

"L560": {
  ...
   "lemmas": {
   "en": {
   "language": "en",
   "value": "colour"
   }
   },
   ...
   "forms": [
   {
"id": "L560-F1",
"representations": {
"en-gb": {
"language": "en-gb",
 "value": "colour"
},
"en-us": {
"language": "en-us",
 "value": "color"
}
},
...
}
...
   ]
...
}TASK DETAILhttps://phabricator.wikimedia.org/T190033EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Lydia_Pintscher, WMDE-leszek, Aklapper, daniel, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T184173: WD Feature Evaluation Plans

2018-03-19 Thread Jan_Dittrich
Jan_Dittrich closed this task as "Invalid".Jan_Dittrich added a comment.
Yes, I think we should close it and open particular ones for each feature.TASK DETAILhttps://phabricator.wikimedia.org/T184173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: GoranSMilovanovic, Jan_DittrichCc: Addshore, Tobi_WMDE_SW, Jan_Dittrich, Lydia_Pintscher, GoranSMilovanovic, Aklapper, Lahi, Gq86, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189143: "Grammatical features" string on a Form of a Lexeme is not translatable

2018-03-19 Thread gerritbot
gerritbot added a comment.
Change 419444 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Make grammatical features translatable.

https://gerrit.wikimedia.org/r/419444TASK DETAILhttps://phabricator.wikimedia.org/T189143EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: Pablo-WMDE, Jakob_WMDE, gerritbot, Aklapper, Lydia_Pintscher, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Darkdadaah, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T190022: Separate the CirrusSearch/Elastic-specific code from Wikibase code base

2018-03-19 Thread WMDE-leszek
WMDE-leszek created this task.WMDE-leszek added a project: Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONIt does not seem desired to have knowledge on CirrusSearch/Elastic encoded in Wikibase. It definitely is valuable to allow Elastic/Cirrus-powered search in Wikibase, but Wikibase itself should not be depending on CirrusSearch, or Elastic in any way. Similarly, CirrusSearch extension should not know that Wikibase even exists, as one of its possible users, but still both CirrusSearch and Wikibase would enable a powerful application.

Having such separation would allow more efficient development of both Wikibase, and CirrusSearch. Having clear boundaries would also improve the work on Cirrus-powered searched for Wikibase/Wikidata, as in my opinion, it would provide the area within which this work can be done, without a need to adjust Wikibase and/or CirrusSearch for the need of this specific topic (I mean that both CirrusSearch and Wikibase do far more than just Cirrus-based search in Wikibase).

I suggest the following way to make the separation: the CirrusSearch/Elastcic-specific code would be moved to a separate extension (also meaning it would be moved to its dedicated code repository). This extension would be enabled on wikis that use Wikibase, and the Cirrus-based search (e.g. wikidata.org). The extension would be owned by WMF's Search Platform team.

In practice, the separation would mean:


moving code from the Wikibase\Repo\Search\Elastic namespace to the new extension
also moving the code handling Cirrus-specific hooks out of Wikibase
moving Cirrus-specific config files, and options out
abstracting the way different search engines could be used by Wikibase search API (e.g. turn the useCirrus option into some more generic hook that extension could use to override the engine used in search)
do not depend on/use FieldDefintions object in Wikibase's EntityHandlers etc. I have no immediate suggestion at hand yet, looking at this for brief two minutes I see several options to consider.


If looking at the code makes it easier for you to grasp the idea than reading prose, you might consider looking at https://gerrit.wikimedia.org/r/#/c/420037/ which is a very naive but fairly complete overview of what code in Wikibase would need to be moved or changed.

WMDE Engineering is fine with doing the separation work, but due to lack of Cirrus/Elastic-related expertise, we would prefer to not be responsible for the development and maintenance of the new extension, as argued above.

Thoughts @Smalyshev, @Lydia_Pintscher? Please feel free to add other people to the loop who you think would need to be part of this conversation.TASK DETAILhttps://phabricator.wikimedia.org/T190022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: thiemowmde, RazShuty, WMDE-leszek, Lydia_Pintscher, Aklapper, Smalyshev, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T185761: Make i18n keys in WikibaseLexeme consistent

2018-03-19 Thread WMDE-leszek
WMDE-leszek closed this task as "Resolved".WMDE-leszek added a comment.
It seems the migration has happened in https://gerrit.wikimedia.org/r/#/c/408921/. This in my eyes concludes the work on this task. Thanks all!TASK DETAILhttps://phabricator.wikimedia.org/T185761EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, WMDE-leszekCc: Nikerabbit, Raymond, Amire80, gerritbot, WMDE-leszek, Aklapper, Ladsgroup, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Darkdadaah, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T186726: Security review WikibaseLexeme extension

2018-03-19 Thread WMDE-leszek
WMDE-leszek added a comment.
Hi @Bawolff, it's me again. With https://gerrit.wikimedia.org/r/418715 would you be able to claim the security review was done?TASK DETAILhttps://phabricator.wikimedia.org/T186726EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Bawolff, WMDE-leszekCc: Jakob_WMDE, Jonas, gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Ladsgroup, thiemowmde, Lydia_Pintscher, WMDE-leszek, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, dpatrick, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs