date:20180409

[Wikidata-bugs] [Maniphest] [Created] T191872: Lexeme header widget should handle API errors

2018-04-09 Thread WMDE-leszek

WMDE-leszek created this task.WMDE-leszek added projects: Lexicographical data, Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONLexeme header makes calls to the API while saving changes made by the user. In case some error happens (e.g. invalid data has been provided), the API returns the error response. Currently, the widget silently ignores the errors. It switches to non-edit mode and looks like the changes have been saved. In fact, those changes have not been saved, as reloading the page proves. Not saving invalid data is good, but the widget should also not pretend all was OK to the user, and surface the API errors to the user.

Acceptance criteria:
When the API response contains the error, it is displayed to the user using the standard "error bubble".

Scenarios

GIVEN I am on the lexeme page
AND I edit the lexeme header
WHEN I remove all lemmas
AND I click the save button
THEN The error message TODO specify! is displayed

GIVEN I am on the lexeme page
AND I edit the lexeme header
WHEN I click the save button
AND On of API error occurs
THEN The error message TODO specify! is displayed

API errors:

...
unexpected error
TASK DETAILhttps://phabricator.wikimedia.org/T191872WORKBOARDhttps://phabricator.wikimedia.org/project/board/2292/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T191872: Lexeme header widget should handle API errors

2018-04-09 Thread WMDE-leszek

WMDE-leszek triaged this task as "High" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T191872EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Project Column] T189482: Enforce permission checks when deleting a Lexeme page

2018-04-09 Thread WMDE-leszek

WMDE-leszek moved this task from Peer Review to Test (Product Review) on the Wikidata-Turtles-18.03.28 board.WMDE-leszek added a comment.
@Lydia_Pintscher: This is ready to be tested at http://wikidata-lexeme.wmflabs.orgTASK DETAILhttps://phabricator.wikimedia.org/T189482WORKBOARDhttps://phabricator.wikimedia.org/project/board/3311/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, WMDE-leszekCc: gerritbot, Lydia_Pintscher, Aklapper, WMDE-leszek, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T191857: Make and document process for updating dist/ in GUI directory

2018-04-09 Thread Smalyshev

Smalyshev created this task.Smalyshev added a project: Wikidata Query UI.Herald added a subscriber: Aklapper.Herald added a project: Wikidata.
TASK DESCRIPTIONRight now we have dist/ directory in WDQS GUI repository. This directory contains some files for npm distribution, according to comments on https://gerrit.wikimedia.org/r/c/424472/. However, these files are not updated since 2016 and there is no documentation about their use or maintenance. We should:


 Create procedure for updating it (preferably grunt target, if not possible - documented sequence of steps)
 Document the purpose of files in in-repo files
 Document how to build and use them on Mediawiki or in other suitable place
TASK DETAILhttps://phabricator.wikimedia.org/T191857EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Jonas, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T188551: Facilitate conversation on Commons about the future of file titles

2018-04-09 Thread Keegan

Keegan closed this task as "Resolved".Keegan added a comment.
This does not seem to be a good idea (ref).

Step two: close this task.TASK DETAILhttps://phabricator.wikimedia.org/T188551EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KeeganCc: Aklapper, Keegan, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, Ivana_Isadora, QZanden, Tramullas, Acer, V4switch, LawExplorer, Jseddon, FloNight, Trizek-WMF, Susannaanas, Wong128hk, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331, Elitre, Qgil___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

90 matches

Mail list logo