date:20181220

gerritbot added a comment.
Change 479407 merged by Kaldari:
[operations/mediawiki-config@master] WikibaseClient: Enable Lua function usage tracking

https://gerrit.wikimedia.org/r/479407TASK DETAILhttps://phabricator.wikimedia.org/T191416EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: gerritbot, WMDE-leszek, GoranSMilovanovic, hoo, Aklapper, Lydia_Pintscher, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212138: Beta Cluster Commons searches on NS0 all fail (due to Wikibase federation?)

2018-12-20 Thread Smalyshev

Smalyshev added a comment.
"An error has occurred while searching" usually means not missing data in index (in that case search would just return nothing, usually) but some kind of error returned by Elastic. I'd check the debug logs - they usually have more information about what exactly Elastic is unhappy about.TASK DETAILhttps://phabricator.wikimedia.org/T212138EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Smalyshev, Cparle, Jdforrester-WMF, Aklapper, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, V4switch, LawExplorer, Silverfish, _jensen, D3r1ck01, Susannaanas, Wong128hk, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T206535: wikidata weekly dumps take too long to complete

2018-12-20 Thread ArielGlenn

ArielGlenn added a comment.
As you see I merged the change to the rdf shell script. The one running now is all nt, so we won't see the lbzip2 use until the next part of the cron job, the truthy nt ones. I double checked the output from the json files, and the md5sum of the gz and bz2 files are identical (used bzcat to decompress).TASK DETAILhttps://phabricator.wikimedia.org/T206535EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlennCc: gerritbot, hoo, Smalyshev, ArielGlenn, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, gnosygnu, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles.

gerritbot added a comment.
Change 481018 had a related patch set uploaded (by Reedy; owner: Daniel Kinzler):
[mediawiki/core@REL1_32] [MCR] Introduce SlotRoleHandler and SlotRoleRegistry

https://gerrit.wikimedia.org/r/481018TASK DETAILhttps://phabricator.wikimedia.org/T194046EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, gerritbotCc: CCicalese_WMF, gerritbot, Aklapper, daniel, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, Agabi10, D3r1ck01, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T206535: wikidata weekly dumps take too long to complete

gerritbot added a comment.
Change 480140 merged by ArielGlenn:
[operations/puppet@production] use lbzip2 in wikidata rdf weeklies

https://gerrit.wikimedia.org/r/480140TASK DETAILhttps://phabricator.wikimedia.org/T206535EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, hoo, Smalyshev, ArielGlenn, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, gnosygnu, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212189: New Service Request: Wikidata Termbox SSR

2018-12-20 Thread Milimetric

Milimetric added a comment.
Thanks @Jakob_WMDE, I think we're saying the same thing in slightly different terms, and it's because I'm not being precise. It's ok for the client and server to have different implementations, but you're saying the have the same capabilities, right? I was thinking that for the client to be able to render everything the server does, plus handle interactivity and other features in the future, its capabilities would have to be a superset of the server capabilities, right? So, there's no html that could only be rendered by the server, right? It seems that way, components and interface are all shared.

If so, great. If not, it feels important to understand what happens when the server's not there and the client doesn't have some of the server-specific functionality.

So then for me the main question remains around the request flow that everyone else is discussing. From @Addshore's response it sounds like you considered this option and decided against it:

the request to index.php is conditionally routed directly to the SSR service. In our world, the SSR service is there, so we configure it in Varnish, it returns html, and Vue takes over client-side. For other mediawiki installations, index.php knows to render a basic version of the html which pulls in the Vue.js modules. Once this loads in the browser, it renders the interface.

If this was rejected, I'm just curious, what were the expected problems? One potential optimization with that approach could be, if SSR is enabled, you send a smaller client-side module that doesn't include data-access which would only ever happen once, on page-load. So you could put that in a client-fallback folder or something, include it in the version served by index.php but exclude it from the version served by SSR.

(by the way, the build is nicely separated for client vs. server here https://github.com/wmde/wikibase-termbox/blob/faf3dcca602da9f2287e8be9acaa1023144b23d7/vue.config.js#L14, where webpack analyzes the code and includes only what's required by the particular environment it's building against)TASK DETAILhttps://phabricator.wikimedia.org/T212189EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MilimetricCc: akosiaris, Krinkle, Milimetric, daniel, mobrovac, Joe, Matthias_Geisler_WMDE, Jakob_WMDE, Pablo-WMDE, Aklapper, Lydia_Pintscher, Lea_WMDE, Addshore, WMDE-leszek, Legado_Shulgin, Nandana, thifranc, AndyTan, kostajh, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, _jensen, D3r1ck01, SBisson, Wong128hk, Eevans, Hardikj, Wikidata-bugs, aude, GWicke, jayvdb, fbstj, faidon, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, fgiunchedi, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T212427: No namespace configured for entity type `form`

2018-12-20 Thread greg

greg removed a parent task: T206663: 1.33.0-wmf.9 deployment blockers.
TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, gregCc: greg, Stashbot, Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, Pablo-WMDE, Jdforrester-WMF, daniel, WMDE-leszek, Cparle, Addshore, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212427: No namespace configured for entity type `form`

2018-12-20 Thread greg

greg added a comment.

In T212427#4838160, @Stashbot wrote:
Mentioned in SAL (#wikimedia-operations) [2018-12-20T16:51:55Z]  Synchronized php-1.33.0-wmf.9/extensions/Wikibase: SWAT: [[gerrit:480978|Revert "Fail hard if an entity namespace is not configured." (T212427)]] (duration: 01m 17s)


removing this as a blocker to the wmf.9 train then, leaving for the next train after holiday break.TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, gregCc: greg, Stashbot, Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, Pablo-WMDE, Jdforrester-WMF, daniel, WMDE-leszek, Cparle, Addshore, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212189: New Service Request: Wikidata Termbox SSR

2018-12-20 Thread Jakob_WMDE

Jakob_WMDE added a comment.

In T212189#4838123, @Milimetric wrote:
My question here was more, how can the client render everything it needs, when some of the logic, for example for data-access, is only in the src/server/data-access folder?  In other words, if the client functionality is a super-set of the server, I would expect only common and client folders, and the server to use logic out of the common folder.  I'm asking both for the termbox right now and plans for this service in the long-run.


I hope I understand the question correctly, but the idea is that e.g. src/server/data-access and src/client/data-access both implement client/server-specific functionality of the same data-access interfaces. CSR gets all its information from the window environment (e.g. mw.config, existing Wikibase JS services, etc), whereas the SSR requests the data from the API. The client functionality is not a super-set of the server. They share most of the code, and what they cannot share is hidden behind interfaces and implemented in src/client and src/server respectively.TASK DETAILhttps://phabricator.wikimedia.org/T212189EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: akosiaris, Krinkle, Milimetric, daniel, mobrovac, Joe, Matthias_Geisler_WMDE, Jakob_WMDE, Pablo-WMDE, Aklapper, Lydia_Pintscher, Lea_WMDE, Addshore, WMDE-leszek, Legado_Shulgin, Nandana, thifranc, AndyTan, kostajh, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, _jensen, D3r1ck01, SBisson, Wong128hk, Eevans, Hardikj, Wikidata-bugs, aude, GWicke, jayvdb, fbstj, faidon, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, fgiunchedi, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212427: No namespace configured for entity type `form`

2018-12-20 Thread Stashbot

Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-12-20T16:51:55Z]  Synchronized php-1.33.0-wmf.9/extensions/Wikibase: SWAT: [[gerrit:480978|Revert "Fail hard if an entity namespace is not configured." (T212427)]] (duration: 01m 17s)TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, StashbotCc: Stashbot, Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, Pablo-WMDE, Jdforrester-WMF, daniel, WMDE-leszek, Cparle, Addshore, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212427: No namespace configured for entity type `form`

2018-12-20 Thread Tarrow

Tarrow added a comment.

In T212427#4838130, @daniel wrote:
For the record, the revert should be temporary, on the deployment branch, not on master. This is exposing a problem in the calling code, which needs to be addressed. The revert is not a proper fix, just a stop-gap.


Cool. From IRC: @zeljkofilipin will deploy the backport, we will not merge the revert to master and releng will make sure they don't forget about it.

With my wikidata incident manager hat on I'll make sure we work on a proper fix ASAP (but obviously holidays might slow it down a bit)TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, Pablo-WMDE, Jdforrester-WMF, daniel, WMDE-leszek, Cparle, Addshore, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T212427: No namespace configured for entity type `form`

zeljkofilipin added a parent task: T20: 1.33.0-wmf.12 deployment blockers.
TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, zeljkofilipinCc: Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, Pablo-WMDE, Jdforrester-WMF, daniel, WMDE-leszek, Cparle, Addshore, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212427: No namespace configured for entity type `form`

daniel added a comment.
For the record, the revert should be temporary, on the deployment branch, not on master. This is exposing a problem in the calling code, which needs to be addressed. The revert is not a proper fix, just a stop-gap.TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, danielCc: Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, Pablo-WMDE, Jdforrester-WMF, daniel, WMDE-leszek, Cparle, Addshore, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212189: New Service Request: Wikidata Termbox SSR

2018-12-20 Thread Milimetric

Milimetric added a comment.

In T212189#4838090, @Addshore wrote:

In T212189#4835359, @Milimetric wrote:
Now, I started looking through the code and it looks like there's an effort to keep server and client logic as common as possible, with factories and interfaces and nice patterns, but there are still differences.  It looks like there's good reason for this, but how would the client be able to act as a fallback for the server as proposed?


This is an exceptional case and only works for user with JS enabled.
 "Client" here would be the client-side JS, served by Wikibase.
 In case there is no response from the SSR, the fallback would be CSR-only, i.e. it will only work for people with js enabled.
 This addresses the rare scenario that there is no working SSR configured (in installations run by 3rd parties now WMF) and still offers termbox features, but at the cost of not being accessible to users with JS disabled.


My question here was more, how can the client render everything it needs, when some of the logic, for example for data-access, is only in the src/server/data-access folder?  In other words, if the client functionality is a super-set of the server, I would expect only common and client folders, and the server to use logic out of the common folder.  I'm asking both for the termbox right now and plans for this service in the long-run.TASK DETAILhttps://phabricator.wikimedia.org/T212189EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MilimetricCc: akosiaris, Krinkle, Milimetric, daniel, mobrovac, Joe, Matthias_Geisler_WMDE, Jakob_WMDE, Pablo-WMDE, Aklapper, Lydia_Pintscher, Lea_WMDE, Addshore, WMDE-leszek, Legado_Shulgin, Nandana, thifranc, AndyTan, kostajh, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, _jensen, D3r1ck01, SBisson, Wong128hk, Eevans, Hardikj, Wikidata-bugs, aude, GWicke, jayvdb, fbstj, faidon, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, fgiunchedi, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T210744: Refactor our javascript to remove jquery usage with better vanilla alternatives

gerritbot added a comment.
Change 480987 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Suppress compatibility errors only in tests

https://gerrit.wikimedia.org/r/480987TASK DETAILhttps://phabricator.wikimedia.org/T210744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Aklapper, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Dixtosa, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T210744: Refactor our javascript to remove jquery usage with better vanilla alternatives

gerritbot added a comment.
Change 480986 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Renable and fix max-statements-per-line eslint rule

https://gerrit.wikimedia.org/r/480986TASK DETAILhttps://phabricator.wikimedia.org/T210744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Aklapper, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Dixtosa, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T210744: Refactor our javascript to remove jquery usage with better vanilla alternatives

gerritbot added a comment.
Change 480984 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Enable and fix "no jQuery each" eslint rule

https://gerrit.wikimedia.org/r/480984TASK DETAILhttps://phabricator.wikimedia.org/T210744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Aklapper, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Dixtosa, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T210744: Refactor our javascript to remove jquery usage with better vanilla alternatives

gerritbot added a comment.
Change 480983 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Enable and fix "no jQuery proxy" eslint rule

https://gerrit.wikimedia.org/r/480983TASK DETAILhttps://phabricator.wikimedia.org/T210744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Aklapper, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Dixtosa, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T210744: Refactor our javascript to remove jquery usage with better vanilla alternatives

gerritbot added a comment.
Change 480985 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Enable and fix "no jQuery inArray" eslint rule

https://gerrit.wikimedia.org/r/480985TASK DETAILhttps://phabricator.wikimedia.org/T210744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Aklapper, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Dixtosa, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T212189: New Service Request: Wikidata Termbox SSR

Addshore updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...{F27624864}87680}

Technologies: nodejs...Source code: https://github.com/wmde/wikibase-termbox, move to gerrit to happen latest in early Jan 2019.

**Load Details**

The initial responsibility of this service will be the rendering of the term box for wikidata items and properties for mobile web views.
Currently wikidata.org gets no more that 80k mobile web requests per day (including cached pages, and non item/property pages).
If we were to assume all of these requests were actually to item and property pages that were not cached this would result in this SSR service being hit 55 times per minute.
(In reality some of these page views are not to item or property pages, and some will be cached) so we are looking at no more than 1 call per second.TASK DETAILhttps://phabricator.wikimedia.org/T212189EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: akosiaris, Krinkle, Milimetric, daniel, mobrovac, Joe, Matthias_Geisler_WMDE, Jakob_WMDE, Pablo-WMDE, Aklapper, Lydia_Pintscher, Lea_WMDE, Addshore, WMDE-leszek, Legado_Shulgin, Nandana, thifranc, AndyTan, kostajh, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, _jensen, D3r1ck01, SBisson, Wong128hk, Eevans, Hardikj, Wikidata-bugs, aude, GWicke, jayvdb, fbstj, faidon, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, fgiunchedi, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212189: New Service Request: Wikidata Termbox SSR

Addshore added a comment.
There sure has been a fair amount of discussion on this ticket!

So I have created an updated interacting diagram showing off a few more details of the overall flow (and updated the description)
F27687680: Wikidata Termbox SSR Sequence-SSR.png

This highlights the various levels of caching.

Calls for entity data will be going via varnish, and Special:EntityData is cacheable
Other calls to the mw / wb api will not be varnish cached but will be cached and reused by the service itself, probably be a TTL of 1 minute.

Load Details (now included in the description)

The initial responsibility of this service will be the rendering of the term box for wikidata items and properties for mobile web views.
Currently wikidata.org gets no more that 80k mobile web requests per day (including cached pages, and non item/property pages).
If we were to assume all of these requests were actually to item and property pages that were not cached this would result in this SSR service being hit 55 times per minute.
(In reality some of these page views are not to item or property pages, and some will be cached) so we are looking at no more than 1 call per second.

Replies to specific points, with notes from @Jakob_WMDE & @Pablo-WMDE

In T212189#4833536, @daniel wrote:
Oh, I got that wrong - I thought the service would be public facing and called directly from the client! But apparently, itt's not, it would be hidden behind api.php. So, my first point, "we would not expose a new endpoint we would not expose a new endpoint", is invalid. Instead, it should read "We should not introduce a service that is called by MediaWiki, and itself calls MediaWiki."

The initial deployment will not even have a proxy to the service via api.php, it will be entirely internal.
No part of the SSR service is public facing.

In T212189#4835359, @Milimetric wrote:
As I understand it, in the proposed architecture, mediawiki sits in between the browser and node to prevent exposing another public endpoint for the node service. Is my understanding correct?

Yes.

Now, I started looking through the code and it looks like there's an effort to keep server and client logic as common as possible, with factories and interfaces and nice patterns, but there are still differences. It looks like there's good reason for this, but how would the client be able to act as a fallback for the server as proposed?

This is an exceptional case and only works for user with JS enabled.
"Client" here would be the client-side JS, served by Wikibase.
In case there is no response from the SSR, the fallback would be CSR-only, i.e. it will only work for people with js enabled.
This addresses the rare scenario that there is no working SSR configured (in installations run by 3rd parties now WMF) and still offers termbox features, but at the cost of not being accessible to users with JS disabled.

In T212189#4837833, @mobrovac wrote:
If index.php has all the data to render it, then that means that it can send it to the service directly without the need for the service to call MW back (now, whether the client will be used as a proxy is a different issue).

The "termbox" is more of an application than a template.
Only it knows which data it needs - actively "sending" data to it requires knowledge of which information is needed.
While seemingly trivial in the beginning this will, as the application grows, become a burden in maintenance - and potentially in performance if data data that has become obsolete is sent "just to be sure".

In T212189#4837867, @daniel wrote:
(Actually, this is an assumption, it may not be true. Currently, we do render the personalized term box on the server for logged in users, and merge it into the output by substituting a placeholder; I assume that the plan is to not do that, and drop support for a personalized term box for people without JS. But I did not confirm this assumption)

Personalized = user language on top, then "languages most likely to be spoken" by user. We still strive for this behavior.
Cacheability will have to be taken into account.TASK DETAILhttps://phabricator.wikimedia.org/T212189EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: akosiaris, Krinkle, Milimetric, daniel, mobrovac, Joe, Matthias_Geisler_WMDE, Jakob_WMDE, Pablo-WMDE, Aklapper, Lydia_Pintscher, Lea_WMDE, Addshore, WMDE-leszek, Legado_Shulgin, Nandana, thifranc, AndyTan, kostajh, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, _jensen, D3r1ck01, SBisson, Wong128hk, Eevans, Hardikj, Wikidata-bugs, aude, GWicke, jayvdb, fbstj, faidon, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, fgiunchedi, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T212138: Beta Cluster Commons searches on NS0 all fail (due to Wikibase federation?)

2018-12-20 Thread Ramsey-WMF

Ramsey-WMF added projects: SDC General, Multimedia-Team-Working-Board.Restricted Application added a project: Multimedia.
TASK DETAILhttps://phabricator.wikimedia.org/T212138EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ramsey-WMFCc: Cparle, Jdforrester-WMF, Aklapper, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, V4switch, LawExplorer, Silverfish, _jensen, D3r1ck01, Susannaanas, Wong128hk, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Claimed] T212427: No namespace configured for entity type `form`

2018-12-20 Thread Tarrow

Tarrow claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, Pablo-WMDE, Jdforrester-WMF, daniel, WMDE-leszek, Cparle, Addshore, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212427: No namespace configured for entity type `form`

2018-12-20 Thread Tarrow

Tarrow added a comment.
The plan is to revert 479419.

See: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/480978 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/480966TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, Pablo-WMDE, Jdforrester-WMF, daniel, WMDE-leszek, Cparle, Addshore, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T212427: No namespace configured for entity type `form`

zeljkofilipin added a project: Wikimedia-production-error.
TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, Pablo-WMDE, Jdforrester-WMF, daniel, WMDE-leszek, Cparle, Addshore, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T210744: Refactor our javascript to remove jquery usage with better vanilla alternatives

gerritbot added a comment.
Change 480975 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery trim" eslint rule

https://gerrit.wikimedia.org/r/480975TASK DETAILhttps://phabricator.wikimedia.org/T210744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Aklapper, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Dixtosa, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T210744: Refactor our javascript to remove jquery usage with better vanilla alternatives

gerritbot added a comment.
Change 480973 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Fix broken unregister widget method

https://gerrit.wikimedia.org/r/480973TASK DETAILhttps://phabricator.wikimedia.org/T210744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Aklapper, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Dixtosa, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T210744: Refactor our javascript to remove jquery usage with better vanilla alternatives

gerritbot added a comment.
Change 480976 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Renable and fix max-statements-per-line eslint rule

https://gerrit.wikimedia.org/r/480976TASK DETAILhttps://phabricator.wikimedia.org/T210744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Aklapper, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Dixtosa, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T210744: Refactor our javascript to remove jquery usage with better vanilla alternatives

gerritbot added a comment.
Change 480974 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery inArray" eslint rule

https://gerrit.wikimedia.org/r/480974TASK DETAILhttps://phabricator.wikimedia.org/T210744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Aklapper, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Dixtosa, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T210744: Refactor our javascript to remove jquery usage with better vanilla alternatives

gerritbot added a comment.
Change 480972 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery map" eslint rule

https://gerrit.wikimedia.org/r/480972TASK DETAILhttps://phabricator.wikimedia.org/T210744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Aklapper, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Dixtosa, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T210744: Refactor our javascript to remove jquery usage with better vanilla alternatives

gerritbot added a comment.
Change 480971 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery each" eslint rule

https://gerrit.wikimedia.org/r/480971TASK DETAILhttps://phabricator.wikimedia.org/T210744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Aklapper, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Dixtosa, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T210744: Refactor our javascript to remove jquery usage with better vanilla alternatives

gerritbot added a comment.
Change 480970 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery grep" eslint rule

https://gerrit.wikimedia.org/r/480970TASK DETAILhttps://phabricator.wikimedia.org/T210744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Aklapper, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Dixtosa, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T210744: Refactor our javascript to remove jquery usage with better vanilla alternatives

gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T210744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Aklapper, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Dixtosa, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T210744: Refactor our javascript to remove jquery usage with better vanilla alternatives

gerritbot added a comment.
Change 480969 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery isFunction" eslint rule

https://gerrit.wikimedia.org/r/480969TASK DETAILhttps://phabricator.wikimedia.org/T210744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Aklapper, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Dixtosa, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T210744: Refactor our javascript to remove jquery usage with better vanilla alternatives

gerritbot added a comment.
Change 480968 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery proxy" eslint rule

https://gerrit.wikimedia.org/r/480968TASK DETAILhttps://phabricator.wikimedia.org/T210744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Aklapper, Michael, Nandana, Mh-3110, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, enigmaeth, rohitt, LawExplorer, _jensen, D3r1ck01, Jonas, Dixtosa, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212427: No namespace configured for entity type `form`

2018-12-20 Thread Jakob_WMDE

Jakob_WMDE added a comment.
This is the stack trace I get locally by passing any form id into wbcheckconstraints:

PageTableEntityQueryBase.php:85, Wikibase\Lib\Store\Sql\EntityIdLocalPartPageTableEntityQuery->getQueryInfo()
PageTableEntityQueryBase.php:53, Wikibase\Lib\Store\Sql\EntityIdLocalPartPageTableEntityQuery->selectRows()
WikiPageEntityMetaDataLookup.php:336, Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup->selectLatestRevisionIdsMultiple()
WikiPageEntityMetaDataLookup.php:170, Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup->loadLatestRevisionIds()
CachingResultsSource.php:466, WikibaseQuality\ConstraintReport\Api\CachingResultsSource->getLatestRevisionIds()
CachingResultsSource.php:301, WikibaseQuality\ConstraintReport\Api\CachingResultsSource->storeResults()
CachingResultsSource.php:251, WikibaseQuality\ConstraintReport\Api\CachingResultsSource->getAndStoreResults()
CachingResultsSource.php:179, WikibaseQuality\ConstraintReport\Api\CachingResultsSource->getResults()
CheckConstraints.php:179, WikibaseQuality\ConstraintReport\Api\CheckConstraints->execute()
ApiMain.php:1595, ApiMain->executeAction()
ApiMain.php:531, ApiMain->executeActionWithErrorHandling()
ApiMain.php:502, ApiMain->execute()
api.php:87, {main}()TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, Pablo-WMDE, Jdforrester-WMF, daniel, WMDE-leszek, Cparle, Addshore, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212427: No namespace configured for entity type `form`

zeljkofilipin added a comment.
TLDR: because this is a new error, it's blocking the train. Since people are already on vacation or leaving soon, I need to know if it's fine to move the train forward with this, or not.TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, Pablo-WMDE, Jdforrester-WMF, daniel, WMDE-leszek, Cparle, Addshore, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T212427: No namespace configured for entity type `form`

zeljkofilipin updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION**TLDR: because this is a new error, it's blocking the train. Since people are already on vacation or leaving soon, I need to know if it's fine to move the train forward with this, or not.**

Noticed in [[ https://logstash.wikimedia.org/app/kibana#/dashboard/Fatal-Monitor | Fatal-Monitor ]]...TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, Pablo-WMDE, Jdforrester-WMF, daniel, WMDE-leszek, Cparle, Addshore, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212427: No namespace configured for entity type `form`

2018-12-20 Thread Pablo-WMDE

Pablo-WMDE added a comment.
Reproducible at https://www.wikidata.org/w/api.php?action=""> (assuming no harm done)TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, Pablo-WMDE, Jdforrester-WMF, daniel, WMDE-leszek, Cparle, Addshore, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T212427: No namespace configured for entity type `form`

daniel added subscribers: Pablo-WMDE, Lucas_Werkmeister_WMDE, Jakob_WMDE.daniel added a comment.
Pinging @Jakob_WMDE and @Pablo-WMDE, since the rest of the Wikidata team is already out for the holidays. Pinging @Lucas_Werkmeister_WMDE, since he probably knows most about wbcheckconstraints.

Quick assessment: my patch introduced the check that now throws an error. This would have failed silently before. So the error itself is not new. The problem is that forms are not "top level" entities. I'm not sure what the current approach is to resolving IDs of "sub-entities".TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Jakob_WMDE, Lucas_Werkmeister_WMDE, Pablo-WMDE, Jdforrester-WMF, daniel, WMDE-leszek, Cparle, Addshore, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T212427: No namespace configured for entity type `form`

zeljkofilipin added subscribers: Cparle, WMDE-leszek, daniel, Jdforrester-WMF.zeljkofilipin added a comment.
Pinging people mentioned in the commit: @daniel @Addshore @Jdforrester-WMF @WMDE-leszek @CparleTASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Jdforrester-WMF, daniel, WMDE-leszek, Cparle, Addshore, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212427: No namespace configured for entity type `form`

zeljkofilipin added a comment.
Only 479419 changed lib/includes/Store/Sql/PageTableEntityQueryBase.php.TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Addshore, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212427: No namespace configured for entity type `form`

zeljkofilipin added a comment.
Wikibase commits new in wmf.9: MediaWiki_1.33/wmf.9/Changelog#WikibaseTASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Addshore, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T212427: No namespace configured for entity type `form`

zeljkofilipin added a parent task: T206663: 1.33.0-wmf.9 deployment blockers.
TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T212427: No namespace configured for entity type `form`

zeljkofilipin triaged this task as "Unbreak Now!" priority.Restricted Application added subscribers: Liuxinyu970226, TerraCodes.
TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T212427: No namespace configured for entity type `form`

zeljkofilipin created this task.zeljkofilipin added projects: Wikidata, Wikidata-Campsite.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONNoticed in Fatal-Monitor

[XBulpgpAAK4AAK7YOp0D] /w/api.php?action=""   Wikibase\DataModel\Services\Lookup\EntityLookupException from line 88 of /srv/mediawiki/php-1.33.0-wmf.9/extensions/Wikibase/lib/includes/Store/Sql/PageTableEntityQueryBase.php: No namespace configured for entity type `form`TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212189: New Service Request: Wikidata Termbox SSR

daniel added a comment.
You first need to render the page on the server before you know whether the client supports JS/SW or not, so it will need to be rendered on the server irrespective of the client's capabilities in case where MW calls the service directly before handing out the page.

Yes, that is correct, my statement was imprecise: there is no need for server side rendering of the personalized term box. Only the general rendering with the default languages needs to be rendered on the server. This is also the version that is cacheable, intended to be included in the output of index.php.TASK DETAILhttps://phabricator.wikimedia.org/T212189EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: akosiaris, Krinkle, Milimetric, daniel, mobrovac, Joe, Matthias_Geisler_WMDE, Jakob_WMDE, Pablo-WMDE, Aklapper, Lydia_Pintscher, Lea_WMDE, Addshore, WMDE-leszek, Legado_Shulgin, Nandana, thifranc, AndyTan, kostajh, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, _jensen, D3r1ck01, SBisson, Wong128hk, Eevans, Hardikj, Wikidata-bugs, aude, GWicke, jayvdb, fbstj, faidon, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, fgiunchedi, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212189: New Service Request: Wikidata Termbox SSR

daniel added a comment.
When rendering the page, index.php knows the exact data that needs to be rendered already, correct?

I just had a brief chat with @Jakob_WMDE and @Pablo-WMDE about this. For the current use case ("term box"), this would be easy, but for the anticipated generalized use case ("render entire wikibase entity") this is non-trivial: the template doesn't just need the entity data itself, but also the labels of referenced items, data types of properties, localized names of units, etc. Only the JS code really knows what it needs, and even it does not have that knowledge in a central place.TASK DETAILhttps://phabricator.wikimedia.org/T212189EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: akosiaris, Krinkle, Milimetric, daniel, mobrovac, Joe, Matthias_Geisler_WMDE, Jakob_WMDE, Pablo-WMDE, Aklapper, Lydia_Pintscher, Lea_WMDE, Addshore, WMDE-leszek, Legado_Shulgin, Nandana, thifranc, AndyTan, kostajh, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, _jensen, D3r1ck01, SBisson, Wong128hk, Eevans, Hardikj, Wikidata-bugs, aude, GWicke, jayvdb, fbstj, faidon, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, fgiunchedi, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212189: New Service Request: Wikidata Termbox SSR

mobrovac added a comment.

In T212189#4837824, @daniel wrote:
That works, but defies the purpose. The idea is to present a default rendering to clients that don't have JS enabled (or no sufficiently current JS support). That rendering should be generated by the same vue.js code that does the rendering on the client.


But the same principle applies, regardless of whether the req is sent by the client or not. If index.php has all the data to render it, then that means that it can send it to the service directly without the need for the service to call MW back (now, whether the client will be used as a proxy is a different issue).

Clients that do have JS support will ask the API for different data (based on user language settings, for logged in users) and will re-render the term box based on that. No server side rendering required.

This confuses me. You first need to render the page on the server before you know whether the client supports JS/SW or not, so it will need to be rendered on the server irrespective of the client's capabilities in case where MW calls the service directly before handing out the page.TASK DETAILhttps://phabricator.wikimedia.org/T212189EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mobrovacCc: akosiaris, Krinkle, Milimetric, daniel, mobrovac, Joe, Matthias_Geisler_WMDE, Jakob_WMDE, Pablo-WMDE, Aklapper, Lydia_Pintscher, Lea_WMDE, Addshore, WMDE-leszek, Legado_Shulgin, Nandana, thifranc, AndyTan, kostajh, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, _jensen, D3r1ck01, SBisson, Wong128hk, Eevans, Hardikj, Wikidata-bugs, aude, GWicke, jayvdb, fbstj, faidon, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, fgiunchedi, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212189: New Service Request: Wikidata Termbox SSR

daniel added a comment.

In T212189#4837780, @mobrovac wrote:
When rendering the page, index.php knows the exact data that needs to be rendered already, correct? If so, it can send that to the client, and then based on whether JS/SW is available or not, the client either renders it or sends a request to the service which sits behind Varnish. Or am I missing something.


That works, but defies the purpose. The idea is to present a default rendering to clients that don't have JS enabled (or no sufficiently current JS support). That rendering should be generated by the same vue.js code that does the rendering on the client.

Clients that do have JS support will ask the API for different data (based on user language settings, for logged in users) and will re-render the term box based on that. No server side rendering required.TASK DETAILhttps://phabricator.wikimedia.org/T212189EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: akosiaris, Krinkle, Milimetric, daniel, mobrovac, Joe, Matthias_Geisler_WMDE, Jakob_WMDE, Pablo-WMDE, Aklapper, Lydia_Pintscher, Lea_WMDE, Addshore, WMDE-leszek, Legado_Shulgin, Nandana, thifranc, AndyTan, kostajh, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, _jensen, D3r1ck01, SBisson, Wong128hk, Eevans, Hardikj, Wikidata-bugs, aude, GWicke, jayvdb, fbstj, faidon, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, fgiunchedi, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212189: New Service Request: Wikidata Termbox SSR

mobrovac added a comment.

In T212189#4837768, @daniel wrote:
But for the case at hand, there might be a workaround: the PHP code that renders the (Wikibase Entity) page content already knows what data will be needed for the rendering. It can send it to the rendering service along with the request to render. The vue.js code would then need to have a "fake repo request" facility that would just use data that was passed in with the original request, and would fail (or at least warn) when trying to load any additional content by calling the actual MediaWiki API. I think that solution would still be fairly clean, and would perform better than calling back to the MediaWiki API all the time.


When rendering the page, index.php knows the exact data that needs to be rendered already, correct? If so, it can send that to the client, and then based on whether JS/SW is available or not, the client either renders it or sends a request to the service which sits behind Varnish. Or am I missing something.

Thinking further into the future, the dilemma could perhaps also be solved by separating MediaWiki's storage layout entirely from the application layer; this way PHP and JS code can use the same storage layer API for retrieving page content. But this is just a thought for the future - it woudl take a while, and I'm not even sure it's a good idea.

Somewhat OT for this task, but I would actually argue that the democratisation of the storage layer is a good thing, as it allows different entities to focus on wht they are supposed to achieve. Naturally, this implies the storage solution is scalable, secure, etc.TASK DETAILhttps://phabricator.wikimedia.org/T212189EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mobrovacCc: akosiaris, Krinkle, Milimetric, daniel, mobrovac, Joe, Matthias_Geisler_WMDE, Jakob_WMDE, Pablo-WMDE, Aklapper, Lydia_Pintscher, Lea_WMDE, Addshore, WMDE-leszek, Legado_Shulgin, Nandana, thifranc, AndyTan, kostajh, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, _jensen, D3r1ck01, SBisson, Wong128hk, Eevans, Hardikj, Wikidata-bugs, aude, GWicke, jayvdb, fbstj, faidon, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, fgiunchedi, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T212422: Request deletion should create {{Q|Q12345}} instead of {{Q|Q12345}} as the title of deletion requests

2018-12-20 Thread ChristianKl

ChristianKl created this task.ChristianKl added a project: Wikidata.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONCurrently, the titles of the deletion requests for items on Wikidata aren't human-readable. Having them human readable by using the template would make it easier to engage with the deletion requests.TASK DETAILhttps://phabricator.wikimedia.org/T212422EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ChristianKlCc: Aklapper, ChristianKl, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212189: New Service Request: Wikidata Termbox SSR

daniel added a comment.
@Milimetric wrote:

In the simplest case, this code would be almost identical client and server-side. No matter where it's running, nodejs or the browser, it would request data, receive it, and render it as html.

I think you are right, that does make sense; Then, the rendering service should sit between the client and MediaWiki, and not be called by MediaWiki. But that means it cannot be used for serving the default rendering of the page from index.php.

If we have these two requirements:


use vue.js based rendering when serving page content from index.php
the mechanism for accessing Wikibase content from vue.js based code should be the same on client and server


...then I see no way to avoid the "PHP calls JS calls PHP" issue in general.

But for the case at hand, there might be a workaround: the PHP code that renders the (Wikibase Entity) page content already knows what data will be needed for the rendering. It can send it to the rendering service along with the request to render. The vue.js code would then need to have a "fake repo request" facility that would just use data that was passed in with the original request, and would fail (or at least warn) when trying to load any additional content by calling the actual MediaWiki API. I think that solution would still be fairly clean, and would perform better than calling back to the MediaWiki API all the time.

Thinking further into the future, the dilemma could perhaps also be solved by separating MediaWiki's storage layout entirely from the application layer; this way PHP and JS code can use the same storage layer API for retrieving page content. But this is just a thought for the future - it woudl take a while, and I'm not even sure it's a good idea.TASK DETAILhttps://phabricator.wikimedia.org/T212189EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: akosiaris, Krinkle, Milimetric, daniel, mobrovac, Joe, Matthias_Geisler_WMDE, Jakob_WMDE, Pablo-WMDE, Aklapper, Lydia_Pintscher, Lea_WMDE, Addshore, WMDE-leszek, Legado_Shulgin, Nandana, thifranc, AndyTan, kostajh, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, _jensen, D3r1ck01, SBisson, Wong128hk, Eevans, Hardikj, Wikidata-bugs, aude, GWicke, jayvdb, fbstj, faidon, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, fgiunchedi, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T166042: Put Wikibase Statements (and possibly other parts of entities) into restbase

mobrovac added a project: Core Platform Team Backlog (Designing).
TASK DETAILhttps://phabricator.wikimedia.org/T166042EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mobrovacCc: thiemowmde, daniel, aude, Lydia_Pintscher, GWicke, Aklapper, hoo, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Eevans, mobrovac, Hardikj, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T212421: Move Wikibase Data Model JavaScript development from Differential to Gerrit

2018-12-20 Thread Aklapper

Aklapper created this task.Aklapper added projects: Phabricator, Wikibase-DataModel-_javascript_.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONSee parent task.

Filing this because of https://phabricator.wikimedia.org/D1125 , if move has already happened in the meantime or if I misinterpret, please correct. Thanks.TASK DETAILhttps://phabricator.wikimedia.org/T212421EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: Aklapper, Nandana, Majesticalreaper22, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Framawiki, JJMC89, _jensen, D3r1ck01, Luke081515, Wikidata-bugs, aude, Mvolz, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T193641: track number of editors from other Wikimedia projects who also edit on Wikidata over time

2018-12-20 Thread JAllemandou

JAllemandou added a comment.
Same exact problem as last month: job has run, but no data is present :(
More investigations needed, probably early next year.TASK DETAILhttps://phabricator.wikimedia.org/T193641EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JAllemandouCc: WMDE-leszek, Tbayer, Aklapper, GerritBot, JAllemandou, Jonas, RazShuty, Ladsgroup, Addshore, Lydia_Pintscher, CucyNoiD, Nandana, NebulousIris, Akovalyov, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T212189: New Service Request: Wikidata Termbox SSR

mobrovac edited projects, added Core Platform Team Backlog (Later); removed Core Platform Team Backlog (Next).
TASK DETAILhttps://phabricator.wikimedia.org/T212189EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mobrovacCc: akosiaris, Krinkle, Milimetric, daniel, mobrovac, Joe, Matthias_Geisler_WMDE, Jakob_WMDE, Pablo-WMDE, Aklapper, Lydia_Pintscher, Lea_WMDE, Addshore, WMDE-leszek, Legado_Shulgin, Nandana, thifranc, AndyTan, kostajh, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, _jensen, D3r1ck01, SBisson, Wong128hk, Eevans, Hardikj, Wikidata-bugs, aude, GWicke, jayvdb, fbstj, faidon, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, fgiunchedi, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T199096: Add support for wikidata summaries in the /page/summary/ endpoint

mobrovac added a project: Core Platform Team Backlog (Watching / External).
TASK DETAILhttps://phabricator.wikimedia.org/T199096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mobrovacCc: daniel, Mholloway, Pchelolo, Liuxinyu970226, Aklapper, ovasileva, bearND, Jdlrobson, Jhernandez, Lydia_Pintscher, Nirzar, Nandana, Kotchchanipa, Adrian1985, Abo00tamr, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, _jensen, D3r1ck01, Eevans, mobrovac, Hardikj, Wikidata-bugs, aude, Ricordisamoa, Jdforrester-WMF, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T149456: Wikidata description change doesn't trigger mobile-sections update

mobrovac added a project: Core Platform Team Backlog (Watching / External).
TASK DETAILhttps://phabricator.wikimedia.org/T149456EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pchelolo, mobrovacCc: PokestarFan, GWicke, Niedzielski, mobrovac, daniel, aude, hoo, Pchelolo, Aklapper, Dbrant, Mholloway, gerritbot, bearND, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Sharvaniharan, Darkminds3113, Bsandipan, Lordiis, schoenbaechler, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, cmadeo, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Eevans, Hardikj, Wikidata-bugs, Jdforrester-WMF, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T178445: flapping monitoring for recommendation_api on scb

mobrovac added a project: Core Platform Team Backlog (Watching / External).
TASK DETAILhttps://phabricator.wikimedia.org/T178445EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mobrovacCc: Joe, Volans, mobrovac, Smalyshev, Gehel, Stashbot, Aklapper, Dzahn, ET4Eva, Legado_Shulgin, Nandana, thifranc, AndyTan, Davinaclare77, Qtn1293, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, Chicocvenancio, Th3d3v1ls, Hfbn0, QZanden, EBjune, LawExplorer, Avner, Zppix, _jensen, D3r1ck01, FloNight, Wong128hk, Eevans, Hardikj, Wikidata-bugs, aude, Capt_Swing, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T200594: Add client identifier to requests sent from Kartotherian to WDQS

mobrovac added a project: Core Platform Team Backlog (Watching / External).
TASK DETAILhttps://phabricator.wikimedia.org/T200594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mholloway, mobrovacCc: Stashbot, mobrovac, MSantos, Gehel, Aklapper, MaxSem, Pnorman, Mholloway, Smalyshev, Nandana, Amatissart, Lahi, Gq86, Looniverse, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, Orienteerix, merbst, LawExplorer, _jensen, JGirault, D3r1ck01, Jonas, phabyogi, Xmlizer, Susannaanas, lxbarth, Eevans, jkroll, Planemad, Hardikj, Wikidata-bugs, Jdouglas, bearND, aude, Tobias1984, Manybubbles, Yurik, Jdforrester-WMF, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T105845: RFC: Page components / content widgets

mobrovac added a project: Core Platform Team Backlog (Watching / External).
TASK DETAILhttps://phabricator.wikimedia.org/T105845EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mobrovacCc: brion, leila, Reasno, SBisson, MZMcBride, Mholloway, RandomDSdevel, jmadler, Bianjiang, LikeLifer, MGChecker, -jem-, Daniel_Mietchen, StudiesWorld, Kelson, Jonas, daniel, Jhernandez, MrStradivarius, JanZerebecki, Quiddity, mobrovac, ssastry, Tgr, Ltrlg, Inez, cscott, TrevorParscal, Jdlrobson, GWicke, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Eevans, Jrf, Hardikj, Wikidata-bugs, aude, Dinoguy1000, Gryllida, Nikerabbit, Arlolra, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T192687: Better formatting in REST API results for wikidata

mobrovac added a project: Core Platform Team Backlog (Watching / External).
TASK DETAILhttps://phabricator.wikimedia.org/T192687EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mobrovacCc: cscott, Aklapper, HYanWong, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Eevans, Jrf, mobrovac, Hardikj, Wikidata-bugs, aude, GWicke, Dinoguy1000, ssastry, Arlolra, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Claimed] T210744: Refactor our javascript to remove jquery usage with better vanilla alternatives

2018-12-20 Thread Michael

Michael claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T210744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Aklapper, Michael, Nandana, Mh-3110, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, enigmaeth, rohitt, LawExplorer, _jensen, D3r1ck01, Jonas, Dixtosa, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T206328: Use StatementListProvidingEntity in NoCrossReferencingStatements

2018-12-20 Thread Pablo-WMDE

Pablo-WMDE closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T206328EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Addshore, Lucas_Werkmeister_WMDE, gerritbot, Aklapper, Pablo-WMDE, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T208924: PHP Fatal from querypage API: Argument passed to SpecialEntityUsage::__construct must implement EntityIdParser

Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Addshore closed this task as "Resolved".Addshore added a comment.
Not quite deployed to group2 yet, but this has already fixed group1 and will continue to roll out with the train.TASK DETAILhttps://phabricator.wikimedia.org/T208924WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, AddshoreCc: gerritbot, Lucas_Werkmeister_WMDE, Addshore, Anomie, Aklapper, Krinkle, revi, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Sethakill, Lewizho99, Maathavan, dg711, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T211119: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities via the API

Addshore closed this task as "Resolved".Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Addshore added a comment.
Everything listed in the task description has been doneTASK DETAILhttps://phabricator.wikimedia.org/T29WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, AddshoreCc: gerritbot, WMDE-leszek, Aklapper, abian, Addshore, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unblock] T211038: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities

Addshore closed subtask T29: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities via the API as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T211038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, AddshoreCc: abian, Aklapper, Addshore, WMDE-leszek, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T193641: track number of editors from other Wikimedia projects who also edit on Wikidata over time

Addshore added a comment.
I don't remember when this is set to run @JAllemandou , but I see no data for Nov yet?TASK DETAILhttps://phabricator.wikimedia.org/T193641EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JAllemandou, AddshoreCc: WMDE-leszek, Tbayer, Aklapper, GerritBot, JAllemandou, Jonas, RazShuty, Ladsgroup, Addshore, Lydia_Pintscher, CucyNoiD, Nandana, NebulousIris, Akovalyov, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wikidata-bugs, aude, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T201837: Use link formatter that uses cache instead of wb_terms for all wikidatawiki items

Addshore closed this task as "Resolved".Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
TASK DETAILhttps://phabricator.wikimedia.org/T201837WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Stashbot, gerritbot, Addshore, Aklapper, Aleksey_WMDE, WMDE-leszek, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unblock] T201831: Deploy item/property link formatter that uses cache instead of wb_terms DB table

Addshore closed subtask T201837: Use link formatter that uses cache instead of wb_terms for all wikidatawiki items as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T201831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, Addshore, Aleksey_WMDE, WMDE-leszek, Aklapper, Nickleh, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T209576: Remove BC for old entitytermsview cookies

Addshore closed this task as "Resolved".Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Addshore added a comment.
Nothing to really verify hereTASK DETAILhttps://phabricator.wikimedia.org/T209576WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, AddshoreCc: Addshore, gerritbot, Aklapper, Pablo-WMDE, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T209504: Perform more constraint type checks in PHP before falling back to SPARQL

Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Addshore closed this task as "Resolved".Addshore claimed this task.Addshore added a comment.Restricted Application added a project: User-Addshore.
F27685696: image.png

The change cn very clearly be seen


Increase in type checks being performed in PHP
Decrease in SPARQL type checks
Increase in median time for SPARQL query success (as the smaller ones are now being done in PHP)
TASK DETAILhttps://phabricator.wikimedia.org/T209504WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Stashbot, Agabi10, gerritbot, Michael, Lucas_Werkmeister_WMDE, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212201: The wiki files in the Wikibase doc folder should only use easilly parsed constructs

gerritbot added a comment.
Change 480803 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Wikibase: Cleanup usagetracking migration

https://gerrit.wikimedia.org/r/480803TASK DETAILhttps://phabricator.wikimedia.org/T212201EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, jeblad, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Ivana_Isadora, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, srodlund, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212201: The wiki files in the Wikibase doc folder should only use easilly parsed constructs

gerritbot added a comment.
Change 480801 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Wikibase: Cleanup usagetracking

https://gerrit.wikimedia.org/r/480801TASK DETAILhttps://phabricator.wikimedia.org/T212201EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, jeblad, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Ivana_Isadora, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, srodlund, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209504: Perform more constraint type checks in PHP before falling back to SPARQL

Addshore added a comment.

In T209504#4830822, @Michael wrote:
@Lucas_Werkmeister_WMDE Interestingly, and independently from today's deployment, https://www.wikidata.org/wiki/Special:ConstraintReport/Q41 is broken o.O


It looks like that might have just been a runtime issue and this page renders for me now.TASK DETAILhttps://phabricator.wikimedia.org/T209504EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Stashbot, Agabi10, gerritbot, Michael, Lucas_Werkmeister_WMDE, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Reassigned] T200011: `ERROR: Cannot find module '../../../../Wikibase/repo/tests/selenium` when running WikibaseLexeme-npm-browser-run-selenium-daily-node-6-docker Jenkins

Addshore reassigned this task from Greta_Doci_WMDE to Tarrow.Addshore added a subscriber: Greta_Doci_WMDE.
TASK DETAILhttps://phabricator.wikimedia.org/T200011EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, AddshoreCc: Greta_Doci_WMDE, gerritbot, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, zeljkofilipin, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207401: Alignment issue with Glosses

2018-12-20 Thread Greta_Doci_WMDE

Greta_Doci_WMDE added a comment.
If we want to go ahead with Lucas idea we should also increasing the width value up to 220px, so we would only have the longest language to be wrapped. 
F27683926: image.png

Otherwise if we leave it 'width: 100px' it will look like the pic below and its confusing.

F27684491: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T207401EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Greta_Doci_WMDECc: Jakob_WMDE, Lucas_Werkmeister_WMDE, Greta_Doci_WMDE, Michael, Lydia_Pintscher, Ladsgroup, Nikki, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T201930: Track entity page performance

Addshore added a comment.
The one remaining patch here is https://gerrit.wikimedia.org/r/#/c/474169/TASK DETAILhttps://phabricator.wikimedia.org/T201930EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Stashbot, Addshore, WMDE-leszek, gerritbot, Aklapper, Aleksey_WMDE, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T211015: Measure how often users click on more languages links

2018-12-20 Thread ReleaseTaggerBot

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.12; 2019-01-08).
TASK DETAILhttps://phabricator.wikimedia.org/T211015EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, ReleaseTaggerBotCc: Addshore, gerritbot, Lydia_Pintscher, D3r1ck01, Aklapper, WMDE-leszek, Lea_WMDE, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, Jonas, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212201: The wiki files in the Wikibase doc folder should only use easilly parsed constructs

gerritbot added a comment.
Change 480770 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Wikibase: Cleanup hooks PHP

https://gerrit.wikimedia.org/r/480770TASK DETAILhttps://phabricator.wikimedia.org/T212201EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, jeblad, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Ivana_Isadora, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, srodlund, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T211015: Measure how often users click on more languages links