[Wikidata-bugs] [Maniphest] [Commented On] T182849: Identify unhelpful file names on commons

2019-02-18 Thread chelsyx
chelsyx added a comment.
A first try using logistic regression: https://paws-public.wmflabs.org/paws-public/User:CXie_(WMF)/commons_file_names.ipynbTASK DETAILhttps://phabricator.wikimedia.org/T182849EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: chelsyxCc: diego, Base, Liuxinyu970226, thiemowmde, Aklapper, Abit, Ramsey-WMF, mpopov, chelsyx, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Silverfish, _jensen, Susannaanas, Jane023, Wikidata-bugs, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T215980: Move LDFServer fork repo to gerrit

2019-02-18 Thread Smalyshev
Smalyshev added a project: User-Smalyshev.
TASK DETAILhttps://phabricator.wikimedia.org/T215980EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Aklapper, Smalyshev, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T210044: Data corruption when loading RDF data into WDQS

2019-02-18 Thread Smalyshev
Smalyshev added a comment.
@Floatingpurr I have fixed some problematic data but still didn't find the root cause yet. Do you have some specific issues you think are related to this?TASK DETAILhttps://phabricator.wikimedia.org/T210044EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: MichaelSchoenitzer, doctaxon, Nikki, Lydia_Pintscher, hoo, Multichill, KaMan, Fnielsen, abian, Lea_Lacroix_WMDE, MisterSynergy, ValterVB, gerritbot, Graemebp, Gstupp, Tarrow, Jane023, EBjune, Floatingpurr, mhl20, Wikidata-Query-Service, Oravrattas, Lucas_Werkmeister_WMDE, Stashbot, Alexsdutton, Aklapper, Smalyshev, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, _jensen, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T215616: Improve interlingual links across wikis through Wikidata IDs

2019-02-18 Thread Tbayer
Tbayer updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONGiven that the page's Wikidata ID has been become //de facto // on of the main identifiers for Wikipedia pages, it is really useful to have ease access to that ID.  Currently, there are twohree ways to do this (please complete the list if you need more):... (2) through the sitelinks on Wikidata Json dumps. 

In both (3) using [[https://www.mediawiki.org/wiki/Manual:Page_props_table |page_props table]] for a specific wiki (its `wikibase_item` rows give the local page IDs corresponding to a Wikidata ID and vice versa, cf. T215616#4945911)

In the first two cases, the triplet is {WikidataId, wiki, Page_Title}, for example {Q298, enwiki, Chile}. Therefore, for any other information about that page, a join on page_title is needed.  Considering that page_titles might change, and also that joining by strings might create some problems depending on the language, having the page Id would be also useful. ...TASK DETAILhttps://phabricator.wikimedia.org/T215616EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TbayerCc: Isaac, Tbayer, jcrespo, EBernhardson, Halfak, Nuria, JAllemandou, diego, Nandana, Akovalyov, Banyek, AndyTan, Rayssa-, Lahi, Gq86, GoranSMilovanovic, QZanden, Marostegui, LawExplorer, Avner, Minhnv-2809, _jensen, Luke081515, Wikidata-bugs, aude, Capt_Swing, Dinoguy1000, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T204264: "Depicts crawling": Add displaying/editing statements to File page

2019-02-18 Thread matthiasmullie
matthiasmullie added a subtask: T216450: [Alpha/Labs] Have links on Wikidata Q and P items open in a new window/tab.
TASK DETAILhttps://phabricator.wikimedia.org/T204264EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Cparle, matthiasmullieCc: Abit, gerritbot, Jdforrester-WMF, Ramsey-WMF, Aklapper, Cparle, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, V4switch, LawExplorer, Lewizho99, Maathavan, _jensen, Wong128hk, Wikidata-bugs, matthiasmullie, aude, Fabrice_Florin, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T216423: Can't add qualifiers on items after clicking 'publish' and then going back to 'edit' mode

2019-02-18 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T216423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Jdforrester-WMF, Aklapper, Abit, Cparle, CucyNoiD, Nandana, NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, V4switch, LawExplorer, Lewizho99, Maathavan, Silverfish, _jensen, Susannaanas, Wong128hk, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T216423: Can't add qualifiers on items after clicking 'publish' and then going back to 'edit' mode

2019-02-18 Thread gerritbot
gerritbot added a comment.
Change 491287 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Detach button before it gets deleted

https://gerrit.wikimedia.org/r/491287TASK DETAILhttps://phabricator.wikimedia.org/T216423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Jdforrester-WMF, Aklapper, Abit, Cparle, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, V4switch, LawExplorer, Silverfish, _jensen, Susannaanas, Wong128hk, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T215967: Add keyword for filtering based on captions in specific language

2019-02-18 Thread Smalyshev
Smalyshev added a comment.
But here since we have multiple languages I feel that one may ask for a word in two different languages and prefer having a OR between the two

Yes, this is possible, but I wonder how frequent it would be that somebody needs a label in Russian or Portuguese? I can invent a scenario, but it would not be a typical use case.

We are not that far from supporting OR between keywords, that parser is ready we just need to write the query building code

Maybe then we should wait for then instead of inventing mini-language for each keyword? Keep it simple and let the query builder do the complex stuff.

I prefer to force the language because using the current language will produce queries that may be hard to share.

That's a good point for shareable queries, but many people - just as in regular search - are just interested in finding stuff for themselves, not sharing it. For them, forcing them to specify the language feels wrong. I think we should DWIM here and use the current language environment if the language is not specified.TASK DETAILhttps://phabricator.wikimedia.org/T215967EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: EBernhardson, SmalyshevCc: Smalyshev, dcausse, Nuria, Abit, Cparle, Ramsey-WMF, Aklapper, JKSTNK, Lahi, PDrouin-WMF, E1presidente, Anooprao, SandraF_WMF, EBjune, Tramullas, Acer, V4switch, Silverfish, Susannaanas, Wong128hk, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T216241: Make "make primary" work in read mode

2019-02-18 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T216241EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matthiasmullie, gerritbotCc: PDrouin-WMF, Cparle, Aklapper, Ramsey-WMF, Jdforrester-WMF, gerritbot, Abit, matthiasmullie, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, V4switch, LawExplorer, Lewizho99, Maathavan, _jensen, Wong128hk, Wikidata-bugs, aude, Fabrice_Florin, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T216241: Make "make primary" work in read mode

2019-02-18 Thread gerritbot
gerritbot added a comment.
Change 491298 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Toggle edit mode on primary, and make state changes impossible during submit

https://gerrit.wikimedia.org/r/491298TASK DETAILhttps://phabricator.wikimedia.org/T216241EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matthiasmullie, gerritbotCc: PDrouin-WMF, Cparle, Aklapper, Ramsey-WMF, Jdforrester-WMF, gerritbot, Abit, matthiasmullie, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, Wong128hk, Wikidata-bugs, aude, Fabrice_Florin, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T198557: Remove support for legacy pre-MCR schema

2019-02-18 Thread daniel
daniel added a comment.

In T198557#4961828, @BPirkle wrote:
I'm happy to, but it appears that I cannot edit or claim the task.


That's odd, there should not be any restrictions to that effect. @Aklapper can you have a look? Thanks!TASK DETAILhttps://phabricator.wikimedia.org/T198557EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: BPirkle, Fjalapeno, CCicalese_WMF, Aklapper, daniel, holger.knust, EvanProdromou, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, JJMC89, _jensen, Agabi10, MGChecker, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

2019-02-18 Thread daniel
daniel added a comment.

In T198341#4962428, @BPirkle wrote:
Task description refers to "RevisionStore::newRevisionRecordFromRow()".  Should that be "RevisionStore::newRevisionFromRow()"?


Yes, sorry about that. I'll fix the description.TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkle, danielCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, Agabi10, Wikidata-bugs, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T198341: Remove all references to the rev_text_id and ar_text_id fields

2019-02-18 Thread daniel
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONAny code that accesses  rev_text_id and ar_text_id fields is unable to make use of MCR. In order to enable for MCR support, all references to these fields have to be removed from the code. They should be replaced with RevisionStore::getQueryInfo(),  RevisionStore::newRevisionRecordFromRow(), and RevisionRecord::getContent()TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkle, danielCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, Agabi10, Wikidata-bugs, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T216241: Make "make primary" work in read mode

2019-02-18 Thread matthiasmullie
matthiasmullie claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T216241EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matthiasmullieCc: PDrouin-WMF, Cparle, Aklapper, Ramsey-WMF, Jdforrester-WMF, gerritbot, Abit, matthiasmullie, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, Wong128hk, Wikidata-bugs, aude, Fabrice_Florin, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

2019-02-18 Thread BPirkle
BPirkle added a comment.
Task description refers to "RevisionStore::newRevisionRecordFromRow()".  Should that be "RevisionStore::newRevisionFromRow()"?TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, Agabi10, Wikidata-bugs, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T216356: Allow access to the page's short description via the title object

2019-02-18 Thread Anomie
Anomie moved this task from Backlog to External on the MediaWiki-extensions-Scribunto board.Anomie added a comment.
Probably via mw.ext.wikibase mw.wikibase then, rather than mw.title.TASK DETAILhttps://phabricator.wikimedia.org/T216356WORKBOARDhttps://phabricator.wikimedia.org/project/board/558/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Anomie, Reedy, Gonnym, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, SundanceRaphael, _jensen, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Jackmcbarn, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T216252: Don't submit statements that haven't been altered

2019-02-18 Thread gerritbot
gerritbot added a comment.
Change 491288 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Don't update statements that have not changed

https://gerrit.wikimedia.org/r/491288TASK DETAILhttps://phabricator.wikimedia.org/T216252EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matthiasmullie, gerritbotCc: Cparle, Aklapper, Ramsey-WMF, Jdforrester-WMF, gerritbot, Abit, matthiasmullie, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, Wong128hk, Wikidata-bugs, aude, Fabrice_Florin, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T216252: Don't submit statements that haven't been altered

2019-02-18 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T216252EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matthiasmullie, gerritbotCc: Cparle, Aklapper, Ramsey-WMF, Jdforrester-WMF, gerritbot, Abit, matthiasmullie, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, V4switch, LawExplorer, Lewizho99, Maathavan, _jensen, Wong128hk, Wikidata-bugs, aude, Fabrice_Florin, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T216252: Don't submit statements that haven't been altered

2019-02-18 Thread matthiasmullie
matthiasmullie claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T216252EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matthiasmullieCc: Cparle, Aklapper, Ramsey-WMF, Jdforrester-WMF, gerritbot, Abit, matthiasmullie, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, Wong128hk, Wikidata-bugs, aude, Fabrice_Florin, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T216160: Update wikidata-entities dump generation to fixed day-of-month instead of fixed weekday

2019-02-18 Thread Nicolastorzec
Nicolastorzec added a comment.
Hi Ariel et al.,

I don't think switching data dump generation from a pattern like "every Monday" to a pattern like "on the 1st, 8th, 15th, 22nd of each month" would have any real impact on data consumers that follow best practices.

For example, the best practice that we (Yahoo / Verizon Media) and others follow is to check once a day if a new dataset has been made available, and download this new dataset if it differs from the previous one.

-NTASK DETAILhttps://phabricator.wikimedia.org/T216160EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NicolastorzecCc: Nicolastorzec, hoo, Smalyshev, Addshore, ArielGlenn, JAllemandou, Nandana, Akovalyov, Lahi, Gq86, GoranSMilovanovic, Lunewa, QZanden, LawExplorer, _jensen, gnosygnu, Wikidata-bugs, aude, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T208489: [Story] Create LilyPond datatype

2019-02-18 Thread alaa_wmde
alaa_wmde added a comment.
All current sub-tasks of this story are in peer-review now. Not sure if we will keep the story for later sub-tasks regarding the remained questions on this. Each one of them sound like a separate story to me.TASK DETAILhttps://phabricator.wikimedia.org/T208489EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alaa_wmdeCc: alaa_wmde, Lydia_Pintscher, Mahir256, mb, Lucas_Werkmeister_WMDE, Aklapper, Jc86035, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Jonas, Wikidata-bugs, aude, Ebe123, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T215286: Ensure Lilypond datatype diffing works

2019-02-18 Thread alaa_wmde
alaa_wmde moved this task from Doing to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.alaa_wmde added a comment.
sweat, moving to done then!TASK DETAILhttps://phabricator.wikimedia.org/T215286WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alaa_wmdeCc: Mahir256, Lydia_Pintscher, Aklapper, Addshore, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, mb, Jonas, Wikidata-bugs, aude, Ebe123, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T215286: Ensure Lilypond datatype diffing works

2019-02-18 Thread Mahir256
Mahir256 added a comment.
That looks great!TASK DETAILhttps://phabricator.wikimedia.org/T215286EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alaa_wmde, Mahir256Cc: Mahir256, Lydia_Pintscher, Aklapper, Addshore, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, mb, Jonas, Wikidata-bugs, aude, Ebe123, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T215286: Ensure Lilypond datatype diffing works

2019-02-18 Thread Lydia_Pintscher
Lydia_Pintscher added a comment.
Jep :)TASK DETAILhttps://phabricator.wikimedia.org/T215286EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alaa_wmde, Lydia_PintscherCc: Lydia_Pintscher, Aklapper, Addshore, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, mb, Jonas, Wikidata-bugs, aude, Ebe123, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T215286: Ensure Lilypond datatype diffing works

2019-02-18 Thread alaa_wmde
alaa_wmde added a comment.
Here's how it looks now
F28241108: image.png

With error version
F28241104: image.png
F28241118: image.png

It looks good enough to me. What do you think?TASK DETAILhttps://phabricator.wikimedia.org/T215286EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alaa_wmdeCc: Aklapper, Addshore, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, mb, Jonas, Wikidata-bugs, aude, Ebe123, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T216241: Make "make primary" work in read mode

2019-02-18 Thread PDrouin-WMF
PDrouin-WMF added a comment.
Yeah, the original concepts allowed for that, but I think your solution
works, Cormac (going into edit mode once the user changes the primary state
and clicking publish or cancel).TASK DETAILhttps://phabricator.wikimedia.org/T216241EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: PDrouin-WMFCc: PDrouin-WMF, Cparle, Aklapper, Ramsey-WMF, Jdforrester-WMF, gerritbot, Abit, matthiasmullie, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, Wong128hk, Wikidata-bugs, aude, Fabrice_Florin, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T212019: Whitespace not stripped around sense glosses

2019-02-18 Thread Lydia_Pintscher
Lydia_Pintscher closed this task as "Resolved".Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Lydia_Pintscher added a comment.
\o/TASK DETAILhttps://phabricator.wikimedia.org/T212019WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alaa_wmde, Lydia_PintscherCc: Lydia_Pintscher, Jakob_WMDE, gerritbot, LucasWerkmeister, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T215502: adjust spacing between Sense ID, bar and Gloss

2019-02-18 Thread Lydia_Pintscher
Lydia_Pintscher added a comment.
Fair enough. Sorry. And yes please <3TASK DETAILhttps://phabricator.wikimedia.org/T215502EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Arexnj, Lydia_PintscherCc: Addshore, gerritbot, Ladsgroup, Arexnj, Lydia_Pintscher, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T216423: Can't add qualifiers on items after clicking 'publish' and then going back to 'edit' mode

2019-02-18 Thread Cparle
Cparle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...3. Click 'edit' and then try and add a qualifier to any depicts tag - doesn't workTASK DETAILhttps://phabricator.wikimedia.org/T216423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CparleCc: Jdforrester-WMF, Aklapper, Abit, Cparle, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, V4switch, LawExplorer, Silverfish, _jensen, Susannaanas, Wong128hk, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T216423: Can't add qualifiers on items after clicking 'publish' and then going back to 'edit' mode

2019-02-18 Thread Cparle
Cparle created this task.Cparle added projects: SDC General, Multimedia.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONSteps to reproduce:


Add a depicts tag to a file
Publish
Click 'edit' and then try and add a qualifier to any tag - doesn't work
TASK DETAILhttps://phabricator.wikimedia.org/T216423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CparleCc: Jdforrester-WMF, Aklapper, Abit, Cparle, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, V4switch, LawExplorer, Silverfish, _jensen, Susannaanas, Wong128hk, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T216241: Make "make primary" work in read mode

2019-02-18 Thread Cparle
Cparle added a comment.
Hmm ... you sure? Everything else requires the user to press 'publish'. Don't you think it'd be a bit odd for 'make primary' to be different?

To me it'd make most sense for the form to go into 'edit' mode once the user changes the state of one of primary - and then they can click 'publish' or 'cancel'TASK DETAILhttps://phabricator.wikimedia.org/T216241EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CparleCc: PDrouin-WMF, Cparle, Aklapper, Ramsey-WMF, Jdforrester-WMF, gerritbot, Abit, matthiasmullie, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, Wong128hk, Wikidata-bugs, aude, Fabrice_Florin, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T215502: adjust spacing between Sense ID, bar and Gloss

2019-02-18 Thread Ladsgroup
Ladsgroup added a comment.

In T215502#4960183, @Lydia_Pintscher wrote:
Thanks! That's what it looks like for me as well. The language is still too close to the bar in your screenshots if you compare it to the space in Forms.


This wasn't covered by the patch or the acceptance criteria. Fixing it would not be hard but it should be clear. I can make a patch to fix it if you want it.TASK DETAILhttps://phabricator.wikimedia.org/T215502EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Arexnj, LadsgroupCc: Addshore, gerritbot, Ladsgroup, Arexnj, Lydia_Pintscher, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T215287: Return nice error messages from Score extension when Lilypond formatting fails

2019-02-18 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T215287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alaa_wmde, gerritbotCc: gerritbot, Greta_Doci_WMDE, Tacsipacsi, Aklapper, Addshore, Lydia_Pintscher, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, mb, Jonas, Wikidata-bugs, aude, Ebe123, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T215287: Return nice error messages from Score extension when Lilypond formatting fails

2019-02-18 Thread gerritbot
gerritbot added a comment.
Change 491261 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan):
[mediawiki/extensions/Score@master] beautify lilypond error message output

https://gerrit.wikimedia.org/r/491261TASK DETAILhttps://phabricator.wikimedia.org/T215287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alaa_wmde, gerritbotCc: gerritbot, Greta_Doci_WMDE, Tacsipacsi, Aklapper, Addshore, Lydia_Pintscher, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, mb, Jonas, Wikidata-bugs, aude, Ebe123, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T216160: Update wikidata-entities dump generation to fixed day-of-month instead of fixed weekday

2019-02-18 Thread fdans
fdans moved this task from Incoming to Radar on the Analytics board.
TASK DETAILhttps://phabricator.wikimedia.org/T216160WORKBOARDhttps://phabricator.wikimedia.org/project/board/11/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: fdansCc: hoo, Smalyshev, Addshore, ArielGlenn, JAllemandou, Nandana, Akovalyov, Lahi, Gq86, GoranSMilovanovic, Lunewa, QZanden, LawExplorer, _jensen, gnosygnu, Wikidata-bugs, aude, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T215616: Improve interlingual links across wikis through Wikidata IDs

2019-02-18 Thread JAllemandou
JAllemandou added a comment.
Hi @Isaac, I have generated some parquet data here /user/joal/wmf/data/wmf/wikidata/item_page_link/20190204  with the following query:

spark.sql("SET spark.sql.shuffle.partitions=128")
val wikidataParquetPath = "/user/joal/wmf/data/wmf/mediawiki/wikidata_parquet/20190204"
spark.read.parquet(wikidataParquetPath).createOrReplaceTempView("wikidata")

spark.sql("""

WITH namespaced_revisions AS (
  SELECT
wiki_db,
page_id,
page_title,
page_namespace,
CASE WHEN (LENGTH(namespace_localized_name) > 0)
  THEN CONCAT(namespace_localized_name, ':', page_title)
  ELSE page_title
END AS title_namespace_localized
  FROM (
SELECT
  wiki_db,
  page_id,
  page_title,
  page_namespace,
  row_number() OVER (PARTITION BY wiki_db, page_id ORDER BY start_timestamp DESC) as row_num
FROM wmf.mediawiki_page_history
WHERE snapshot = '2019-01'
  AND page_id IS NOT NULL AND page_id > 0
  AND page_title IS NOT NULL and LENGTH(page_title) > 0
  ) ph
INNER JOIN wmf_raw.mediawiki_project_namespace_map nsm
  ON (
ph.wiki_db = nsm.dbname
AND ph.page_namespace = nsm.namespace
AND nsm.snapshot = '2019-01'
  )
  WHERE row_num = 1
),

wikidata_sitelinks AS (
  SELECT
id as item_id,
EXPLODE(siteLinks) AS sitelink
  FROM wikidata
  WHERE size(siteLinks) > 0
)

SELECT
  item_id,
  wiki_db,
  page_id,
  page_title,
  page_namespace,
  title_namespace_localized
FROM wikidata_sitelinks ws
  INNER JOIN namespaced_revisions nsr
ON (
  ws.sitelink.site = nsr.wiki_db
  AND ws.sitelink.title = title_namespace_localized
)
""").repartition(16).write.parquet("/user/joal/wmf/data/wmf/wikidata/item_page_link/20190204")

@diego : I can generate similar data for by-revision, but before doing wanted to be sure we agree on the fact that it'll flag every historical revision associated to an item currently linked to a page. Is that what you're after ? Or more of the history of linkagebetween page and item ?
Thanks!TASK DETAILhttps://phabricator.wikimedia.org/T215616EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JAllemandouCc: Isaac, Tbayer, jcrespo, EBernhardson, Halfak, Nuria, JAllemandou, diego, Nandana, Akovalyov, Banyek, AndyTan, Rayssa-, Lahi, Gq86, GoranSMilovanovic, QZanden, Marostegui, LawExplorer, Avner, Minhnv-2809, _jensen, Luke081515, Wikidata-bugs, aude, Capt_Swing, Dinoguy1000, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T215286: Ensure Lilypond datatype diffing works

2019-02-18 Thread alaa_wmde
alaa_wmde claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T215286EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alaa_wmdeCc: Aklapper, Addshore, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, mb, Jonas, Wikidata-bugs, aude, Ebe123, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T178745: Highlight statement(s) when using "#P" in URL

2019-02-18 Thread Hanna_Petruschat_WMDE
Hanna_Petruschat_WMDE added a comment.
Thanks for following up on that @Ivanhercaz and giving input @abian.

I think going for highlights is the right direction. I would argue though changing the background color could have two disadvantages


We use blue as a background color for things being in edit mode. Even though you chose a different one, this might be confusing.
The difference between the grey and the light blue might not be accessible to everyone.


Therefor I propose to consider either Jan's suggestion to take advantage of browsers highlighting mechanism. 
Or, 
in case we want to have a highlight which remains, use a 2px blue border. We have blue as a highlight color in other places as well.

Find a screenshot of a mockup below.
F28240635: Screenshot 2019-02-18 at 17.20.03.pngTASK DETAILhttps://phabricator.wikimedia.org/T178745EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Hanna_Petruschat_WMDECc: jeblad, Ivanhercaz, Jd3main, abian, Hanna_Petruschat_WMDE, TerraCodes, Lydia_Pintscher, thiemowmde, Jan_Dittrich, Sjoerddebruin, Aklapper, Dinadineke, Nandana, Kieubinhtb, A.S.Kochergin, tabish.shaikh91, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, merbst, LawExplorer, _jensen, JGirault, MuhammadShuaib, SimmeD, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T198341: Remove all references to the rev_text_id and ar_text_id fields

2019-02-18 Thread BPirkle
BPirkle claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, Agabi10, Wikidata-bugs, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T198557: Remove support for legacy pre-MCR schema

2019-02-18 Thread BPirkle
BPirkle added a comment.
I was, however, able to claim T198341.  I'll start there.TASK DETAILhttps://phabricator.wikimedia.org/T198557EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: BPirkle, Fjalapeno, CCicalese_WMF, Aklapper, daniel, holger.knust, EvanProdromou, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, JJMC89, _jensen, Agabi10, MGChecker, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T198557: Remove support for legacy pre-MCR schema

2019-02-18 Thread BPirkle
BPirkle added a comment.
I'm happy to, but it appears that I cannot edit or claim the task.TASK DETAILhttps://phabricator.wikimedia.org/T198557EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: BPirkle, Fjalapeno, CCicalese_WMF, Aklapper, daniel, holger.knust, EvanProdromou, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, JJMC89, _jensen, Agabi10, MGChecker, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T214482: CC0 license message for structured data contributions

2019-02-18 Thread PDrouin-WMF
PDrouin-WMF closed this task as "Resolved".PDrouin-WMF added a comment.
Sounds good to me!TASK DETAILhttps://phabricator.wikimedia.org/T214482EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matthiasmullie, PDrouin-WMFCc: Jdforrester-WMF, Stashbot, gerritbot, matthiasmullie, Cparle, Ramsey-WMF, PDrouin-WMF, Aklapper, JKSTNK, Lahi, E1presidente, Anooprao, SandraF_WMF, Tramullas, Acer, V4switch, Silverfish, Susannaanas, Wong128hk, Jane023, Wikidata-bugs, Base, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T215514: Add a method for parsing of Schema data for diffing purposes

2019-02-18 Thread gerritbot
gerritbot added a comment.
Change 490624 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Add FullArraySchemaData to SchemaDispatcher

https://gerrit.wikimedia.org/r/490624TASK DETAILhttps://phabricator.wikimedia.org/T215514EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Aklapper, noarave, pdehaye, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, YULdigitalpreservation, LawExplorer, Lewizho99, Maathavan, _jensen, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T215287: Return nice error messages from Score extension when Lilypond formatting fails

2019-02-18 Thread alaa_wmde
alaa_wmde added a comment.
I came up with this so far.. it looks nicer and more concise (the code is the opposite  but will try to improve some stuff)
F28240197: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T215287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alaa_wmdeCc: Greta_Doci_WMDE, Tacsipacsi, Aklapper, Addshore, Lydia_Pintscher, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, mb, Jonas, Wikidata-bugs, aude, Ebe123, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T214692: Users may add so-called descriptions to MediaInfo entities

2019-02-18 Thread WMDE-leszek
WMDE-leszek added a comment.
I don't claim to understand all details on how MediaInfo is implemented, but if I understood the problem, and I were to "fix" it, I would see three steps:


Make Special:SetDescriptions and relevant API actions really only work with items and properties (unless already done in all places, description of this task suggests it might not be the case yet).
Adjust the code turning the PHP object into JSON object for storage, and the opposite when loading JSON object from the database, so it ignores anything which claims to be a description. E.g. skip "descriptions" key etc. This would prevent storing any "description" data even if it somehow made up to the storage layer, and also unexpected leaking of incorrect data should it be already stored in historical revisions etc.
Adjust the code turning the loaded the PHP object for JSON output, e.g. in API results. This code should be able to control what data is used for presentation, e.g. what "elements" of the MediaInfo object to display. This would prevent exposing any "descriptions" even if they for whatever reason ended up to be stored in the database.


Re points 2 and 3. It has seemed to be the case that "serialization/deserialization" in the storage layer, and "serialization/deserialization" in the presentation layer have been using the same logic, i.e. whatever was stored in DB was basically directly presented to the user. I would not consider this the best idea, and would suggest considering separating those two "serialization/deserialization" processes both conceptually, and also in terms of code.

I am not sure if this helps, should I be more specific (there have been quite exact class names being referred to in above comments etc), please request so.TASK DETAILhttps://phabricator.wikimedia.org/T214692EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jdforrester-WMF, WMDE-leszekCc: WMDE-leszek, gerritbot, daniel, Jdforrester-WMF, Ramsey-WMF, Aklapper, Bugreporter, CucyNoiD, Nandana, NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, V4switch, LawExplorer, Lewizho99, Maathavan, Silverfish, _jensen, Susannaanas, Wong128hk, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T215902: Investigate normalization of data stored in wb_terms table

2019-02-18 Thread Addshore
Addshore added a comment.

In T215902#4950468, @Marostegui wrote:

The insertion logic for terms is more complex than we currently have, deletion logic to be decided, do we even have to remove values from tables such as langstring and langstring type when an entity term is removed? probably not...


Why is that? (just trying to understand the logic)


"Why is that?", is that referring to insertion or deletion logic?

Well, with the wb_terms table, we are just adding a row for each term on an entity.
The normalization of course introduces more tables so for a single term entry 7 inserts may be needed (at least with the initial draft first introduced in this ticket)
Using a hashing approach for languages and term types of course brings this from 7 to 5.
The Mapping from page_id to entity ID could also be seen as not relating to the terms index specifically and could then be assumed to already be there.

For deletions the same applies, just deleting rows.
For the normalized version we will likely only remove entries from wb_entity_terms in real time, which has the potential to leave "dead data" in all of the other tables.
Initially this is not something that we will need to think about, but at some stage we might want to think about cleanup measures (could just be a maint script etc).


There is only likely to be duplication between aliases and labels in terms of string usage currently, descriptions and labels are less likely to have this space saving duplication
langstring has 310983369 rows, langstringtype has 313554459 rows. This might indicate slightly too much normalization here (at least for now) and we could remove the complexity by having a single langstring type table with id, lang_id, string_id, type_id


Why not combining strings langstring and langstringtype on the same table?
 Is that what you mean with: we could remove the complexity by having a single langstring type table with id, lang_id, string_id, type_id?
 Keep in mind that I could be saying nosenses! I don't have the full context of how all the logic behind wb_terms.

It looks like it will make sense to merge the langstring and langstringtype tables together, resulting in a single table that looks something like (below example also including the hashing of types and language codes rather than relating to another table):

id, stringId, langHashInt, stringTypeInt
1, 1, 421809, 511251
2, 3, 21424, 511251





Next steps


 Investigate what the queries would look like with this schema for reading in the various ways that we do, insertions and deletions.


Indeed, that is a key point. We'd need to check their query plans and all that beforehand?

Yes we should probably check the query plans before hand.
In theory all queries plans should be pretty straightforward for mysql to not mess up, and should also be the "most efficient".




 Would we be able to maintain a wb_terms view from this data for labs? Would we even want to do that?


What do you mean? Create a view to query all the new tables to produce the same results as we currently have with wb_terms?

Yes. This could be useful for an easier migration, but also we might want to leave this view around for a while for users of the wb_terms table on the labs db replicas.


 What would the migration look like?


I guess the easiest is to migrate things while writing to both and at some point once both set of tables are in sync switch the writes to the new tables only?

That would be the easiest IMO.
Something more complex could include creating a set of filled tables at a point in time (perhaps in alternate DC) then switching traffic, then running a maint script to catch the tables back up to reality, and then start reading from them (would likely be faster, but probably more active work?


In T215902#4950653, @Lucas_Werkmeister_WMDE wrote:
We could also turn term types and languages into short IDs via a hash function: as far as I’m aware, Wikibase only needs the string→ID direction (hash function), and if we need the ID→string direction (e. g. during manual investigation) we can hash all the known term types / language codes and look for the value we have.


Yup, removing these 2 tables would be possible with some simple hashing.
This would make the tables slightly harder for people to work with on the labsdb replicas however (something to consider).


In T215902#4950984, @Marostegui wrote:

In T215902#4950653, @Lucas_Werkmeister_WMDE wrote:
Do the DB servers have enough storage space for this?


The old ones certainly not (ie: the master or codfw) - we are discussing now how to proceed in regard to those old servers, but we are on early stages of this.

I should have been clearer though, my point was to, while you move stuff from one table to the other(s) you keep delete rows from wb_terms - we might need to optimize the table along the way to actually claim back all that disk space on the servers.


Deleting rows from wb_terms as we go could be possible, but in the perfect situation we 

[Wikidata-bugs] [Maniphest] [Edited] T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers

2019-02-18 Thread Krinkle
Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...** Removed 20 modules. – [1.33-wmf.17] , , , 
** Removed 3 modules. – [1.33-wmf.18] ...TASK DETAILhttps://phabricator.wikimedia.org/T203696EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: gerritbot, Addshore, Aklapper, Krinkle, Jdforrester-WMF, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers

2019-02-18 Thread gerritbot
gerritbot added a comment.
Change 491253 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Wikibase@master] Consolidate more view/resources modules (6)

https://gerrit.wikimedia.org/r/491253TASK DETAILhttps://phabricator.wikimedia.org/T203696EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Addshore, Aklapper, Krinkle, Jdforrester-WMF, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T209576: Remove BC for old entitytermsview cookies

2019-02-18 Thread gerritbot
gerritbot added a comment.
Change 491250 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] Collapsed termbox state: fix/simplify cookie

https://gerrit.wikimedia.org/r/491250TASK DETAILhttps://phabricator.wikimedia.org/T209576EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Addshore, gerritbot, Aklapper, Pablo-WMDE, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T215068: Access key not set for Wikibase undo summary

2019-02-18 Thread gerritbot
gerritbot added a comment.
Change 491243 had a related patch set uploaded (by Greta WMDE; owner: Greta Doçi):
[mediawiki/extensions/Wikibase@master] accessKey was added to EditEntityAction file. It only works when the K is capital even though the standard for accesskey is with lowercase

https://gerrit.wikimedia.org/r/491243TASK DETAILhttps://phabricator.wikimedia.org/T215068EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Greta_Doci_WMDE, gerritbotCc: gerritbot, Greta_Doci_WMDE, Tacsipacsi, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T215068: Access key not set for Wikibase undo summary

2019-02-18 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T215068EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Greta_Doci_WMDE, gerritbotCc: gerritbot, Greta_Doci_WMDE, Tacsipacsi, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T216356: Allow access to the page's short description via the title object

2019-02-18 Thread Reedy
Reedy added projects: Wikidata, MediaWiki-extensions-WikibaseClient.Reedy added a comment.
Ok, so it's a #wikidata thingTASK DETAILhttps://phabricator.wikimedia.org/T216356EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ReedyCc: Reedy, Gonnym, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, SundanceRaphael, _jensen, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Anomie, Jackmcbarn, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T215039: Let unregistered users know they can use a registered account

2019-02-18 Thread abian
abian added a comment.
This seems to be blocked by T216374.TASK DETAILhttps://phabricator.wikimedia.org/T215039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: abianCc: gerritbot, Ladsgroup, Lydia_Pintscher, Hanna_Petruschat_WMDE, Charlie_WMDE, abian, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, Jonas, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T216397: Make Special:ItemDisambiguation use SpecialDisabledPage instead of SpecialBlankPage

2019-02-18 Thread Reedy
Reedy renamed this task from "Make Special:ItemDisambiguation  use SpecialDisabledPage instead of SpecialBlankPage" to "Make Special:ItemDisambiguation use SpecialDisabledPage instead of SpecialBlankPage".
TASK DETAILhttps://phabricator.wikimedia.org/T216397EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ReedyCc: gerritbot, Addshore, Lydia_Pintscher, Esc3300, waldyrious, Aklapper, abian, Ladsgroup, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, Jonas, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T216397: Make Special:ItemDisambiguation use SpecialDisabledPage instead of SpecialBlankPage

2019-02-18 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T216397EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Addshore, Lydia_Pintscher, Esc3300, waldyrious, Aklapper, abian, Ladsgroup, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, Jonas, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T216397: Make Special:ItemDisambiguation use SpecialDisabledPage instead of SpecialBlankPage

2019-02-18 Thread Ladsgroup
Ladsgroup created this task.Ladsgroup triaged this task as "High" priority.Ladsgroup added projects: Wikidata, Wikidata-Campsite.
TASK DESCRIPTIONAfter T200185: Create a Special:DisabledSpecialPage to be used instead of Special:BlankPage is done, we can change the special page to give a better message to users.TASK DETAILhttps://phabricator.wikimedia.org/T216397EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Addshore, Lydia_Pintscher, Esc3300, waldyrious, Aklapper, abian, Ladsgroup, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Jonas, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T216397: Make Special:ItemDisambiguation use SpecialDisabledPage instead of SpecialBlankPage

2019-02-18 Thread gerritbot
gerritbot added a comment.
Change 491237 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/mediawiki-config@master] Change Special:ItemDisambiguation from blank special page to disabled page

https://gerrit.wikimedia.org/r/491237TASK DETAILhttps://phabricator.wikimedia.org/T216397EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Addshore, Lydia_Pintscher, Esc3300, waldyrious, Aklapper, abian, Ladsgroup, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Jonas, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T216265: Be able to filter Wikibase edits in Recent Changes on type of change

2019-02-18 Thread Addshore
Addshore added a comment.
A prototype of this could likely be pretty good just filtering on the edit summary used.
We could also look at using rc_params?TASK DETAILhttps://phabricator.wikimedia.org/T216265EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Aklapper, Jdforrester-WMF, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Iniquity, _jensen, Taiwania_Justo, SBisson, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T215967: Add keyword for filtering based on captions in specific language

2019-02-18 Thread dcausse
dcausse added a comment.
In general ORing a keyword is only meaning for keywords that match a code, it's rare when people ask us why can't I do intitle:foo OR intitle:bar. But here since we have multiple languages I feel that one may ask for a word in two languages different and prefer having a OR between the two. I think you are right that we should not push too much on the first iteration.
We are not that far from supporting OR between keywords, that parser is ready we just need to write the query building code. We are perhaps close enough that it preferable to stick with the simple syntax.

As for search @ in labels, one way will be to escape it with \@ but we can also be lenient and consume all @ that are not valid language suffixes.

If I sum-up (if @ is not appropriate because too widely used we can change it):


inlabel:foo@fr search foo fr with all its fallbacks
inlabel:foo: produces a warning
inlabel:foo@bar@fr: search foo@bar in with fr all its fallbacks
inlabel:foo\@bar@fr: search foo@bar in with fr all its fallbacks
inlabel:"foo bar@fr": search the phrase foo bar in with fr all its fallbacks, (feels a bit weird to have the suffix inside the double quotes)


I prefer to force the language because using the current language will produce queries that may be hard to share.

Impossible usecases (for the moment):


search foo in fr or en
search foo OR bar in fr
search only in strict fr excluding a variant/fallback
TASK DETAILhttps://phabricator.wikimedia.org/T215967EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: EBernhardson, dcausseCc: Smalyshev, dcausse, Nuria, Abit, Cparle, Ramsey-WMF, Aklapper, JKSTNK, Lahi, PDrouin-WMF, E1presidente, Anooprao, SandraF_WMF, EBjune, Tramullas, Acer, V4switch, Silverfish, Susannaanas, Wong128hk, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs