[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

[Ammarpad]

Ammarpad closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad
Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, CBogen, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Ramsey-WMF, Pablo-WMDE, 
GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T248457: Fully terminate use of Wikidata item descriptions as short article descriptions for English Wikipedia articles

[Mike_Peel]

Mike_Peel added a comment.


  Just to let you know that I've started at RfC about bot-syncing Wikidata and 
enwp descriptions at 
https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(proposals)#Synchronising_short_descriptions_and_Wikidata_descriptions

TASK DETAIL
  https://phabricator.wikimedia.org/T248457

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mike_Peel
Cc: eprodromou, Pigsonthewing, GhostInTheMachine, Iniquity, DannyH, ppelberg, 
MichaelMaggs, Dreamy_Jazz, Majavah, kaldari, Certes, Xeriphas1994, Mathglot, 
Bencemac, Galobtter, Tgr, Trialpears, Jonesey95, RexxS, QEDK, Pppery, 
Lydia_Pintscher, JJMC89, DannyS712, Aklapper, Alsee, Liuxinyu970226, Naike, 
Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T184000: Magic word on English WP to override display of Wikidata short description

[Mike_Peel]

Mike_Peel added a comment.


  Additional discussion at 
https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(proposals)#Synchronising_short_descriptions_and_Wikidata_descriptions

TASK DETAIL
  https://phabricator.wikimedia.org/T184000

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tgr, Mike_Peel
Cc: JeanFred, Bugreporter, DannyS712, Liuxinyu970226, Lofhi, MGChecker, 
Pbsouthwood, Deskana, Catrope, RexxS, Nikerabbit, Dbrant, Jdlrobson, Stashbot, 
WMDE-leszek, Elitre, gerritbot, TheDJ, Fjalapeno, Tbayer, MZMcBride, Alsee, 
bearND, Mike_Peel, Tgr, JKatzWMF, daniel, Bmueller, Addshore, Lydia_Pintscher, 
Samwilson, Aklapper, DannyH, Jgiannelos, Scardenasmolinar, Akuckartz, ifried, 
darthmon_wmde, HMonroy, Ddurigon, Mateo1977, Nandana, aezell, lucamauri, Lahi, 
Gq86, dmaza, GoranSMilovanovic, QZanden, Taquo, LawExplorer, catalandres, 
JJMC89, B20180, _jensen, rosalieper, Scott_WUaS, Karthik_sripal, SBisson, 
Nakon, MusikAnimal, Fhocutt, Wikidata-bugs, aude, Ricordisamoa, -jem-, 
Jdforrester-WMF, Mbch331, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T249654: Categorize different types of Wikidata re-use within Wikimedia projects

[Isaac]

Isaac added a comment.


  > Thank you for this analysis - really useful!
  
  Thanks! Glad to hear :)
  
  Additionally, I made some notes here about how these findings my inform 
patrolling of Wikidata transclusion (T246709#6367012 
) and am working on 
hopefully writing this up for the Wikidata Workshop.

TASK DETAIL
  https://phabricator.wikimedia.org/T249654

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Isaac
Cc: Akuckartz, calbon, Addshore, Lydia_Pintscher, Nuria, MGerlach, 
GoranSMilovanovic, Isaac, Liuxinyu970226, darthmon_wmde, Nandana, Abdeaitali, 
Lahi, Gq86, QZanden, LawExplorer, Avner, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Capt_Swing, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T246709: What proportion of a Wikipedia article's edit history might reasonably be changes via Wikidata transclusion?

[Isaac]

Isaac added a comment.


  The results reported in T249654#6352573 
 have some potential insight 
into how we think about supporting patrolling of Wikidata transclusion within 
Wikipedia articles so I wanted to record some of my initial thoughts here. We 
would want to talk with patrollers before actually thinking about implementing 
any of these and unfortunately I'm not actually working on this aspect of the 
project at the moment. However: the recent changes feed for a given article 
likely has many more Wikidata-related changes than are actually pertinent to an 
article from a patrolling standpoint. Some thoughts on reducing this noise:
  
  - Many entries to wbc_entity_usage are from transclusion that only generates 
tracking categories (e.g., Category:Coordinates on Wikidata 
) so arguably 
there should be a way to mark events on Recent Changes caused by these as 
tracking-only so patrollers could easily ignore them.
  - Many entries to wbc_entity_usage are from metadata templates like Authority 
Control and Taxonbar that are very valuable from a linked-data perspective but 
less from a reader's perspective and have a very low potential for harmful 
vandalism. Because the way both of these templates are written, they also 
trigger a general "statements" aspect usage, so any changes to statements on 
the Wikidata item would trigger an event on recent changes. This adds a bunch 
of noise to the Recent Changes feed from Wikidata where these templates are 
used. Additionally, in reality, changes to Wikidata identifiers that impact 
Authority Control and Taxonbar have a very low likelihood of being problematic 
from a reader's perspective because the external links that are generated via 
these templates go to well-curated repositories of information so the reader 
should quickly realize the link is incorrect and probably won't end up viewing 
offensive material. Ideally these templates would be rewritten to only trigger 
the specific properties they transclude, but in practice I could see that being 
difficult, inefficient, or causing the wbc_entity_usage table to become far too 
large to be practical (as each usage of Authority Control would trigger close 
to 100 rows, 1 for each property that can be transcluded 
). Instead, 
maybe wbc_entity_usage could be expanded to distinguish between general 
statements (C.S?) and identifiers (C.I?)? This would make filtering out changes 
to identifiers far easier and metadata templates then could still be recorded 
simply without causing every change to date of birth, occupation, etc. to also 
trigger a change. Unfortunately, I suspect this would require making 
non-trivial changes to the Lua modules and then convincing template coders to 
adapt the code.
  - Some entries to wbc_entity_usage go to generating external links that could 
more clearly generate harm if vandalized and probably do warrant focus from 
patrollers. For instance, Wikidata templates that generate links to Commons 
categories or external links to IMDb etc. could more clearly be abused to link 
to offensive material. Thankfully, given the specific nature of these 
templates, they generally are recorded with their specific property and so 
don't generate noise for patrollers. That said, a not insignificant amount of 
their usage (on enwiki) is only for tracking categories, so any changes that 
would distinguish between actual transclusion and tracking categories would 
serve to reduce noise for this.
  - Finally, infobox transclusion has probably the greatest potential for harm 
(e.g., falsifying someone's age or where they were born). This seems to be 
tracked pretty well for most infoboxes (the specific properties each get their 
own row and labels for each item that was actually transcluded) so I think it's 
more about reducing the noise from the above so that patrollers can more easily 
see these changes.

TASK DETAIL
  https://phabricator.wikimedia.org/T246709

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Isaac
Cc: hoo, Ladsgroup, Lydia_Pintscher, Addshore, Capt_Swing, Isaac, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T249039: Security Readiness Review For Wikidata Bridge

[sbassett]

sbassett added a comment.


  In T249039#6362819 , 
@darthmon_wmde wrote:
  
  > heads up: I am accepting the risk and we programmed the deploy to 
production.
  
  Great, thanks.
  
  > We have already fixed 
 some 
of the dev dependencies - by yesterday there were no high vulnerabilities, only 
low ones.
  
  Ok, great.
  
  > You mentioned that we need to commit to a risk plan to review the 
vulnerable dependencies e.g. in the next 30 days. From talking to the team the 
issue here is rather a continuous than a milestone, meaning that this is a 
moving target and we need a process to periodically check and fix the 
dependencies of our projects (To this aim we could really benefit from 
https://phabricator.wikimedia.org/T228527)
  >
  > With all this in mind, could you please specify the kind of commitment that 
you expect from me?
  
  The expectations the #security-team 
 would have would be:
  
  1. Accepting the risk resulting from this review would mean accepting 
accountability for any potential issue which might arise from this code being 
deployed upon Wikimedia hardware.  e.g. being fully accountable if, say, a 
vulnerability from a deployed npm package resulted in a security incident.
  2. Regarding the risk plan, what you've described seems reasonable.  Given 
the vast amount of upstream code used for wikidata-bridge and other projects, 
it's likely infeasible to get to a point any time soon where every 
vulnerability has been addressed and resolved.  Committing to constant 
vigilance of dependency vulnerabilities and working to remediate those via 
patches to upstream, upgrading to secure versions or using alternative packages 
are all acceptable solutions.  To help with this, it might make sense to set up 
automated jobs (outside of publicly-viewable jenkins CI jobs) to run tools like 
`npm audit`, `retirejs`, `outdated` and `snyk` against the code base, which 
would then inform developers of current statuses.

TASK DETAIL
  https://phabricator.wikimedia.org/T249039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: sbassett
Cc: WMDE-leszek, sbassett, Addshore, Michael, Lucas_Werkmeister_WMDE, 
Tonina_Zhelyazkova_WMDE, Pablo-WMDE, Lydia_Pintscher, Aklapper, darthmon_wmde, 
Akuckartz, Dsharpe, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Bawolff, 
Mbch331, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

[gerritbot]

gerritbot added a comment.


  Change 618785 **abandoned** by Michael Große:
  [mediawiki/core@master] Clean up test fake time singleton to fix Wikibase 
tests
  
  Reason:
  I5430f4dee02216b5d5f48c3b2810f111362f3c4e is the original patch and the one 
that should be merged.
  
  https://gerrit.wikimedia.org/r/618785

TASK DETAIL
  https://phabricator.wikimedia.org/T259785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Tarrow, Pablo-WMDE, Addshore, guergana.tzatchkova, 
Michael, toan, Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

[gerritbot]

gerritbot added a comment.


  Change 618742 had a related patch set uploaded (by Michael Große; owner: 
Michael Große):
  [mediawiki/core@master] Clean up test static fake time to fix Wikibase tests
  
  https://gerrit.wikimedia.org/r/618742

TASK DETAIL
  https://phabricator.wikimedia.org/T259785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Tarrow, Pablo-WMDE, Addshore, guergana.tzatchkova, 
Michael, toan, Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, Maintenance_bot
Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, CBogen, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Ramsey-WMF, Pablo-WMDE, 
GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan, Alter-paule, Beast1978, 
Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, 
Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

[ReleaseTaggerBot]

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.3; 
2020-08-04); removed MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, ReleaseTaggerBot
Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, 
Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, Pablo-WMDE, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

[brennen]

brennen removed a parent task: T257971: 1.36.0-wmf.3 deployment blockers.

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, brennen
Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, 
Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, Pablo-WMDE, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

[Stashbot]

Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2020-08-06T17:36:14Z] 
 Synchronized 
php-1.36.0-wmf.3/extensions/WikibaseMediaInfo/src/View/MediaInfoEntityTermsView.php:
 Backport: [[gerrit:618582|Fix array unpacking as argument list]] (T259745 
) (duration: 01m 07s)

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, Stashbot
Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, 
Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, Pablo-WMDE, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

[gerritbot]

gerritbot added a comment.


  Change 618582 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseMediaInfo@wmf/1.36.0-wmf.3] Fix array unpacking 
as argument list
  
  https://gerrit.wikimedia.org/r/618582

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, gerritbot
Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, 
Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, Pablo-WMDE, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259814: SqlChangeStoreTest::testSaveChange_insert fails due to EntityChange change (call to undefined method setMetadataFromRC())

[Ladsgroup]

Ladsgroup added a comment.


  In T259814#6366373 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > I’m tempted to say that `SqlChangeStore` and its test should completely 
move to the Repo.
  
  I think I suggested this too a while back but I don't know why we decided 
against that, probably the EntityChangeLookupTest?
  
  I would be happy with copying the logic of production to test to decouple 
them and I hope this production code is tested in another place (like 
EntityChangeTest?) I feel it's more of "mocking" the logic than leaving it 
untested.

TASK DETAIL
  https://phabricator.wikimedia.org/T259814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Tarrow, Ladsgroup, ItamarWMDE, WMDE-leszek, Aklapper, 
Lucas_Werkmeister_WMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259814: SqlChangeStoreTest::testSaveChange_insert fails due to EntityChange change (call to undefined method setMetadataFromRC())

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Hah, I wondered if the class had maybe been in Repo before, and in fact the 
very last commit to `SqlChangeStore` was Move SqlChangeStore from repo to lib 
 :D

TASK DETAIL
  https://phabricator.wikimedia.org/T259814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Tarrow, Ladsgroup, ItamarWMDE, WMDE-leszek, Aklapper, 
Lucas_Werkmeister_WMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259814: SqlChangeStoreTest::testSaveChange_insert fails due to EntityChange change (call to undefined method setMetadataFromRC())

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Upon closer inspection:
  
  - Both test methods skip themselves if Repo is not enabled.
  - The class under test, `SqlChangeStore`, hard-codes the `wb_changes` name, 
which only exists on Repo wikis.
  - `SqlChangeStore` is also not used at all from Client or DataAccess – the 
only such class in the `Wikibase\Lib\Store\Sql` namespace, if I’m not mistaken. 
(I didn’t check the `Terms` subnamespace, only classes directly in 
`Wikibase\Lib\Store\Sql`. As far as I can tell, all of them are used in Client 
and/or DataAccess, but `SqlChangeStore` is only used in Repo, and in one other 
Lib test.)
  
  I’m tempted to say that `SqlChangeStore` and its test should completely move 
to the Repo. However, in that case I’m not sure what to do with 
`EntityChangeLookupTest`, because the test uses `SqlChangeStore` to write 
changes to the `wb_changes` table (so that `EntityChangeLookup` can then read 
them back). Would it make sense to move `EntityChangeLookupTest` to Repo even 
though the class it tests stays in Lib?

TASK DETAIL
  https://phabricator.wikimedia.org/T259814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Tarrow, Ladsgroup, ItamarWMDE, WMDE-leszek, Aklapper, 
Lucas_Werkmeister_WMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).

TASK DETAIL
  https://phabricator.wikimedia.org/T259785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: Lucas_Werkmeister_WMDE, Tarrow, Pablo-WMDE, Addshore, guergana.tzatchkova, 
Michael, toan, Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

[Pablo-WMDE]

Pablo-WMDE added a comment.


  >> Error: Call to undefined method 
Wikibase\Lib\Changes\ItemChange::setMetadataFromRC()
  >
  > Tracked as T259814 .
  
  Thank you!

TASK DETAIL
  https://phabricator.wikimedia.org/T259785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Lucas_Werkmeister_WMDE, Tarrow, Pablo-WMDE, Addshore, guergana.tzatchkova, 
Michael, toan, Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259814: SqlChangeStoreTest::testSaveChange_insert fails due to EntityChange change (call to undefined method setMetadataFromRC())

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  This is a relatively simple fix:
  
diff --git a/lib/tests/phpunit/Store/Sql/SqlChangeStoreTest.php 
b/lib/tests/phpunit/Store/Sql/SqlChangeStoreTest.php
index 572379afaa..cca72807e1 100644
--- a/lib/tests/phpunit/Store/Sql/SqlChangeStoreTest.php
+++ b/lib/tests/phpunit/Store/Sql/SqlChangeStoreTest.php
@@ -15,6 +15,8 @@
 use Wikibase\Lib\Changes\ItemChange;
 use Wikibase\Lib\Store\Sql\SqlChangeStore;
 use Wikibase\Lib\WikibaseSettings;
+use Wikibase\Repo\Notifications\RepoEntityChange;
+use Wikibase\Repo\Notifications\RepoItemChange;
 
 /**
  * @covers \Wikibase\Lib\Store\Sql\SqlChangeStore
@@ -179,14 +181,15 @@ public function testSaveChange_update() {
 
 private function getEntityChangeFactory() {
 $changeClasses = [
-Item::ENTITY_TYPE => ItemChange::class,
+Item::ENTITY_TYPE => RepoItemChange::class,
 // Other types of entities will use EntityChange
 ];
 
 return new EntityChangeFactory(
 new EntityDiffer(),
 new ItemIdParser(),
-$changeClasses
+$changeClasses,
+RepoEntityChange::class
 );
 }
  
  However, that reintroduces a coupling from Lib to Repo, which I don’t think 
we want. I’m not sure how else to fix this.
  
  - We could more or less copy the code of `setMetadataFromRC()` into the test 
(specifically into `saveChangeInsertProvider()`), since it’s not a hugely 
complicated method. But is that a good idea, or does it mean that we’re no 
longer testing important code?
  - We could move the relevant parts of the test to Repo. But does this make 
sense as a Repo test?

TASK DETAIL
  https://phabricator.wikimedia.org/T259814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Tarrow, Ladsgroup, ItamarWMDE, WMDE-leszek, Aklapper, 
Lucas_Werkmeister_WMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  > Observation:
  >
  >> The data provider specified for 
Wikibase\Lib\Tests\Store\Sql\SqlChangeStoreTest::testSaveChange_insert is 
invalid.
  >> Error: Call to undefined method 
Wikibase\Lib\Changes\ItemChange::setMetadataFromRC()
  >> 
/workspace/src/extensions/Wikibase/lib/tests/phpunit/Store/Sql/SqlChangeStoreTest.php:58
  >
  > caught my eye but also happens in green runs.
  
  Tracked as T259814 .

TASK DETAIL
  https://phabricator.wikimedia.org/T259785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Tarrow, Pablo-WMDE, Addshore, guergana.tzatchkova, 
Michael, toan, Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

[gerritbot]

gerritbot added a comment.


  Change 618785 had a related patch set uploaded (by Michael Große; owner: 
Michael Große):
  [mediawiki/core@master] Clean up test fake time singleton to fix Wikibase 
tests
  
  https://gerrit.wikimedia.org/r/618785

TASK DETAIL
  https://phabricator.wikimedia.org/T259785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Tarrow, Pablo-WMDE, Addshore, guergana.tzatchkova, Michael, toan, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259814: SqlChangeStoreTest::testSaveChange_insert fails due to EntityChange change (call to undefined method setMetadataFromRC())

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase Extension Decoupling 
and Registration (Sprint 4).

TASK DESCRIPTION
  counterexample
1) Warning
The data provider specified for 
Wikibase\Lib\Tests\Store\Sql\SqlChangeStoreTest::testSaveChange_insert is 
invalid.
Error: Call to undefined method 
Wikibase\Lib\Changes\ItemChange::setMetadataFromRC()

/var/www/html/wiki1/extensions/Wikibase/lib/tests/phpunit/Store/Sql/SqlChangeStoreTest.php:58
/var/www/html/wiki1/maintenance/doMaintenance.php:107
  
  This happens because since If17c21e81d 
, `EntityChange` no longer has a 
`setMetadataFromRC()` method – that method is now in `RepoEntityChange` (and 
inherited in `RepoItemChange`), a Repo-only class.

TASK DETAIL
  https://phabricator.wikimedia.org/T259814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Tarrow, Ladsgroup, ItamarWMDE, WMDE-leszek, Aklapper, 
Lucas_Werkmeister_WMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256058: Extract PHP package/library for "changes" as a "subtree" from the Wikibase monorepo

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T258385: Remove repo only parts from 
EntityChange as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T256058

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Addshore, Lucas_Werkmeister_WMDE, Ladsgroup, ItamarWMDE, Tarrow, 
WMDE-leszek, Aklapper, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, _jensen, rosalieper, 
Agabi10, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, fbstj, 
Lydia_Pintscher, Mbch331, bd808, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

[gerritbot]

gerritbot added a comment.


  Change 618774 had a related patch set uploaded (by Michael Große; owner: 
Michael Große):
  [mediawiki/extensions/Wikibase@master] Reenable 
ArticleRevisionVisibilitySetHookHandlerTest
  
  https://gerrit.wikimedia.org/r/618774

TASK DETAIL
  https://phabricator.wikimedia.org/T259785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Tarrow, Pablo-WMDE, Addshore, guergana.tzatchkova, Michael, toan, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T258385: Remove repo only parts from EntityChange

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Verification to Done on the 
Wikibase Extension Decoupling and Registration (Sprint 4) board.
Lucas_Werkmeister_WMDE added a comment.


  This causes a test warning (T259814 
), but apart from that this seems to 
work, so I think we can close this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T258385

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4916/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow, Lucas_Werkmeister_WMDE
Cc: Aklapper, WMDE-leszek, ItamarWMDE, Ladsgroup, Lucas_Werkmeister_WMDE, 
Tarrow, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

[Pablo-WMDE]

Pablo-WMDE lowered the priority of this task from "Unbreak Now!" to "High".
Pablo-WMDE added a comment.


  Patch with disabled test is merged.

TASK DETAIL
  https://phabricator.wikimedia.org/T259785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Tarrow, Pablo-WMDE, Addshore, guergana.tzatchkova, Michael, toan, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

[gerritbot]

gerritbot added a comment.


  Change 618582 had a related patch set uploaded (by Brennen Bearnes; owner: 
Ammarpad):
  [mediawiki/extensions/WikibaseMediaInfo@wmf/1.36.0-wmf.3] Fix array unpacking 
as argument list
  
  https://gerrit.wikimedia.org/r/618582

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, gerritbot
Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, CBogen, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Ramsey-WMF, Pablo-WMDE, 
GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, gerritbot
Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, 
Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, Pablo-WMDE, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

[gerritbot]

gerritbot added a comment.


  Change 618772 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] temporarily disable 
ArticleRevisionVisibilitySetHookHandlerTest
  
  https://gerrit.wikimedia.org/r/618772

TASK DETAIL
  https://phabricator.wikimedia.org/T259785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Tarrow, Pablo-WMDE, Addshore, guergana.tzatchkova, Michael, toan, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259637: Gather information about the volume of queries on WCQS

[EBernhardson]

EBernhardson added a comment.


  It's hard to get this into superset because it doesn't live in the production 
network, the only access it has to get data to superset would be through our 
public endpoints. Off the top of my head, the only thing i can think of is 
submitting events to the public beacon endpoint like a browser would, not sure 
how workable that is.

TASK DETAIL
  https://phabricator.wikimedia.org/T259637

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: EBernhardson
Cc: EBernhardson, Aklapper, dcausse, CBogen, Akuckartz, darthmon_wmde, Nandana, 
Namenlos314, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, 
EBjune, merbst, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, 
jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T258396: Set up CI to run `git-filter-repo`

[Tarrow]

Tarrow added a comment.


  Quick summary of what I remember seeming to discuss the last two days as a 
team before I forget:
  
  - We'll start with a github action because it means we can move quicker and 
don't need to search for the resources for someone who can set up jenkins / 
zuul jobs for us
  - SSH was easier than github OAuth tokens and allows us to avoid needed a 
"machine account"
  - We used a docker action rather than python on the "host runner" because it 
allowed more customisation e.g. python and git version
  - We put the action under WMDE github org as it's not intrinsically tied to 
wikibase and could be used in other places
  - We put the actual extracted repo under Wikimedia because the code is 
derived from Wikibase.git
  - We (I) boldly made this repo
  - If we need to then the same docker container could probably be redeployed 
on jenkins/zuul

TASK DETAIL
  https://phabricator.wikimedia.org/T258396

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow
Cc: Lucas_Werkmeister_WMDE, Ladsgroup, Legoktm, Aklapper, Tarrow, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T258396: Set up CI to run `git-filter-repo`

[Tarrow]

Tarrow moved this task from Doing to Peer Review on the Wikibase Extension 
Decoupling and Registration (Sprint 4) board.
Tarrow added a comment.


  The action needs to be merged first: see 
https://github.com/wmde/git-filter-repo-docker-action/pull/1

TASK DETAIL
  https://phabricator.wikimedia.org/T258396

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4916/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow
Cc: Lucas_Werkmeister_WMDE, Ladsgroup, Legoktm, Aklapper, Tarrow, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

[Pablo-WMDE]

Pablo-WMDE added a comment.


  https://gerrit.wikimedia.org/r/618772 temporarily disables the tests to 
unblock unrelated work. We will keep full focus on the topic tomorrow.
  
  Observation:
  
  > The data provider specified for 
Wikibase\Lib\Tests\Store\Sql\SqlChangeStoreTest::testSaveChange_insert is 
invalid.
  > Error: Call to undefined method 
Wikibase\Lib\Changes\ItemChange::setMetadataFromRC()
  > 
/workspace/src/extensions/Wikibase/lib/tests/phpunit/Store/Sql/SqlChangeStoreTest.php:58
  
  caught my eye but also happens in green runs.

TASK DETAIL
  https://phabricator.wikimedia.org/T259785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Tarrow, Pablo-WMDE, Addshore, guergana.tzatchkova, Michael, toan, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T258396: Set up CI to run `git-filter-repo`

[gerritbot]

gerritbot added a comment.


  Change 618777 had a related patch set uploaded (by Tarrow; owner: Tarrow):
  [mediawiki/extensions/Wikibase@master] Add github action to publish changes 
library
  
  https://gerrit.wikimedia.org/r/618777

TASK DETAIL
  https://phabricator.wikimedia.org/T258396

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow, gerritbot
Cc: Lucas_Werkmeister_WMDE, Ladsgroup, Legoktm, Aklapper, Tarrow, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T258396: Set up CI to run `git-filter-repo`

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T258396

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow, gerritbot
Cc: Lucas_Werkmeister_WMDE, Ladsgroup, Legoktm, Aklapper, Tarrow, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259637: Gather information about the volume of queries on WCQS

[CBogen]

CBogen added a subscriber: EBernhardson.
CBogen added a comment.


  @EBernhardson any advice on whether we can push this data to Superset?

TASK DETAIL
  https://phabricator.wikimedia.org/T259637

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: CBogen
Cc: EBernhardson, Aklapper, dcausse, CBogen, Akuckartz, darthmon_wmde, Nandana, 
Namenlos314, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, 
EBjune, merbst, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, 
jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259637: Gather information about the volume of queries on WCQS

[dcausse]

dcausse added a comment.


  I think first we could generate a CSV file accessible from wcqs-beta-01. I'm 
not very familiar with dashboard tools like Superset so I don't know how to 
push the data there from wmcloud.

TASK DETAIL
  https://phabricator.wikimedia.org/T259637

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: dcausse
Cc: Aklapper, dcausse, CBogen, Akuckartz, darthmon_wmde, Nandana, Namenlos314, 
Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, jkroll, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

[gerritbot]

gerritbot added a comment.


  Change 618772 had a related patch set uploaded (by Pablo Grass (WMDE); owner: 
Pablo Grass (WMDE)):
  [mediawiki/extensions/Wikibase@master] temporarily disable 
ArticleRevisionVisibilitySetHookHandlerTest
  
  https://gerrit.wikimedia.org/r/618772

TASK DETAIL
  https://phabricator.wikimedia.org/T259785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Tarrow, Pablo-WMDE, Addshore, guergana.tzatchkova, Michael, toan, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229608: Support SDC URIs in WDQS URI schemes

[gerritbot]

gerritbot added a comment.


  Change 531024 **merged** by jenkins-bot:
  [wikidata/query/gui@master] Allow adding more prefixes to RdfNamespaces via 
custom config.
  
  https://gerrit.wikimedia.org/r/531024

TASK DETAIL
  https://phabricator.wikimedia.org/T229608

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev, gerritbot
Cc: Multichill, Aklapper, Smalyshev, Alter-paule, Beast1978, CBogen, Un1tY, 
Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, 
JKSTNK, Namenlos314, Gaboe420, Giuliamocci, Cpaulf30, Lahi, PDrouin-WMF, Gq86, 
Af420, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, Bsandipan, 
Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, Tramullas, Acer, 
merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, Silverfish, _jensen, 
rosalieper, Scott_WUaS, Cirdan, Jonas, Xmlizer, Susannaanas, Jane023, jkroll, 
Wikidata-bugs, Jdouglas, Base, matthiasmullie, aude, Tobias1984, Manybubbles, 
Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Tpt, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T258354: create new rate-limited bot group for Wikidata

[Bugreporter]

Bugreporter added a comment.


  When it is created and current bots moved to new group it would be a breaking 
change.

TASK DETAIL
  https://phabricator.wikimedia.org/T258354

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Bugreporter
Cc: pywikibot-bugs-list, Multichill, Rschen7754, Pasleim, matej_suchanek, 
tfmorris, Ladsgroup, Mike_Peel, Mohammed_Sadat_WMDE, Dipsacus_fullonum, 
Bugreporter, MisterSynergy, Lea_Lacroix_WMDE, Aklapper, Lydia_Pintscher, 
JohnsonLee01, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, 
Akuckartz, Zkhalido, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, 
joker88john, Viztor, CucyNoiD, Nandana, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, Tbscho, MayS, 
LawExplorer, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, _jensen, 
rosalieper, Altostratus, Avicennasis, Scott_WUaS, Jonas, mys_721tx, 
Wikidata-bugs, aude, jayvdb, Ricordisamoa, Masti, Alchimista, Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

[brennen]

brennen added a comment.


  Thanks all.

TASK DETAIL
  https://phabricator.wikimedia.org/T259744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: brennen
Cc: Lucas_Werkmeister_WMDE, thiemowmde, Agusbou2015, toan, Ladsgroup, Addshore, 
Pablo-WMDE, Michael, Catrope, Aklapper, brennen, Alter-paule, Beast1978, 
CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, Poyekhali, _jensen, rosalieper, Taiwania_Justo, 
Scott_WUaS, Jonas, Ixocactus, Wong128hk, alex-mashin, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, jayvdb, MrStradivarius, Lydia_Pintscher, Anomie, 
Jdforrester-WMF, Jackmcbarn, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

[Pablo-WMDE]

Pablo-WMDE added a comment.


  Had a quick chat with @toan - we are looking into this for a little longer 
(around 30mins) and will consider alternative steps to unblock CI should we not 
find a solution.

TASK DETAIL
  https://phabricator.wikimedia.org/T259785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Tarrow, Pablo-WMDE, Addshore, guergana.tzatchkova, Michael, toan, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T258354: create new rate-limited bot group for Wikidata

[Multichill]

Multichill added projects: Pywikibot-Wikidata, Pywikibot.
Restricted Application added a subscriber: pywikibot-bugs-list.

TASK DETAIL
  https://phabricator.wikimedia.org/T258354

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Multichill
Cc: pywikibot-bugs-list, Multichill, Rschen7754, Pasleim, matej_suchanek, 
tfmorris, Ladsgroup, Mike_Peel, Mohammed_Sadat_WMDE, Dipsacus_fullonum, 
Bugreporter, MisterSynergy, Lea_Lacroix_WMDE, Aklapper, Lydia_Pintscher, 
JohnsonLee01, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, 
Akuckartz, Zkhalido, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, 
joker88john, Viztor, CucyNoiD, Nandana, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, Tbscho, MayS, 
LawExplorer, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, _jensen, 
rosalieper, Altostratus, Avicennasis, Scott_WUaS, Jonas, mys_721tx, 
Wikidata-bugs, aude, jayvdb, Ricordisamoa, Masti, Alchimista, Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T258354: create new rate-limited bot group for Wikidata

[Multichill]

Multichill added a comment.


  I think the approach is wrong. Let's start with the first assumption. Nuke ( 
https://www.wikidata.org/wiki/Special:Nuke ) runs under your own account. Used 
it plenty of times. As an admin I have noratelimit so having noratelimit on a 
completely different group is not relevant. MassMessage is just an extension 
that runs in the background. It is a bot. It shouldn't go too fast and it 
shouldn't crash on ratelimits. Relevant historic bugs: T192690 
 and T184948 
 .
  
  Just add a sane (relatively high) ratelimit to the current bots group or keep 
it as is. The current proposed solution is to try to work around the problem.

TASK DETAIL
  https://phabricator.wikimedia.org/T258354

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Multichill
Cc: Multichill, Rschen7754, Pasleim, matej_suchanek, tfmorris, Ladsgroup, 
Mike_Peel, Mohammed_Sadat_WMDE, Dipsacus_fullonum, Bugreporter, MisterSynergy, 
Lea_Lacroix_WMDE, Aklapper, Lydia_Pintscher, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259801: Support multilingual formatter url on Wikidata

[Multichill]

Multichill created this task.
Multichill added projects: Wikidata, I18n.

TASK DESCRIPTION
  We currently use the formatter url property ( 
https://www.wikidata.org/wiki/Property:P1630 ) to take an identifier and make a 
url based on the identifier. For example on 
https://www.wikidata.org/wiki/Property:P650 the formatter url is 
https://rkd.nl/explore/artists/$1 . The property is used on 
https://www.wikidata.org/wiki/Q150679 (Anthony van Dyck) with contents "25230" 
which results in the url https://rkd.nl/explore/artists/25230 .
  
  Some websites offer their contents in multiple languages. In the example 
https://rkd.nl/nl/explore/artists/25230 gives Dutch and 
https://rkd.nl/en/explore/artists/25230 gives English. We currently already add 
formatter url's for these language specific urls', see 
https://www.wikidata.org/wiki/Property:P650 and https://w.wiki/Yuk returns 
1500+ hits.
  
  The interface should be showing the url in my language or otherwise fall back 
to the default formatter url. So if I browse  
https://www.wikidata.org/wiki/Q150679 (Anthony van Dyck)"
  
  - In Dutch, I should get https://rkd.nl/nl/explore/artists/25230
  - In English, I should get https://rkd.nl/en/explore/artists/25230
  - In German (or any other language), I should get 
https://rkd.nl/explore/artists/25230
  
  For bonus points (or can be forked in a new task). Have fallback for language 
variant to main language, so en-us/en-ca would fallback to "en" and would get 
https://rkd.nl/en/explore/artists/25230  . This probably makes things (much) 
more complicated so I'm happy if it's left out in the first version.

TASK DETAIL
  https://phabricator.wikimedia.org/T259801

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Multichill
Cc: Aklapper, Lea_Lacroix_WMDE, Lydia_Pintscher, Multichill, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, 
Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T254675: Rename WPBSkinBlacklist

[ovasileva]

ovasileva closed this task as "Resolved".
ovasileva added a comment.


  Looks good!

TASK DETAIL
  https://phabricator.wikimedia.org/T254675

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva
Cc: Edtadros, Peter.ovchyn, Ammarpad, Reedy, Aklapper, abi_, Amire80, 
Ladsgroup, Dinoguy1000, APerson, Isarra, MZMcBride, Krenair, Anomie, bd808, 
jeblad, Majavah, Izno, Peachey88, Jdlrobson, Amorymeltzer, Winter, 
Wikidata-bugs, Lydia_Pintscher, siebrand, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

[Tarrow]

Tarrow added subscribers: Pablo-WMDE, Tarrow.
Tarrow added a comment.


  Adding @Pablo-WMDE as this week's Incident Manager

TASK DETAIL
  https://phabricator.wikimedia.org/T259785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow
Cc: Tarrow, Pablo-WMDE, Addshore, guergana.tzatchkova, Michael, toan, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T255044: Many new metrics in Graphite for WDQS-Streaming-Updater-POC

[Zbyszko]

Zbyszko added a comment.


  We enabled metrics again, but removed heavily varying parts of the names, 
which should drastically reduce the number of newly created ones - once we use 
start with taskmanager.* and jobmanager.*

TASK DETAIL
  https://phabricator.wikimedia.org/T255044

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Zbyszko
Cc: Gehel, Ladsgroup, Addshore, dcausse, Aklapper, colewhite, CBogen, 
Akuckartz, darthmon_wmde, ET4Eva, Nandana, Namenlos314, Lahi, Gq86, 
Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, 
merbst, LawExplorer, Avner, _jensen, rosalieper, Scott_WUaS, Jonas, FloNight, 
Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T259785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Addshore, guergana.tzatchkova, Michael, toan, Aklapper, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

[gerritbot]

gerritbot added a comment.


  Change 618740 had a related patch set uploaded (by Tobias Andersson; owner: 
Tobias Andersson):
  [mediawiki/extensions/Wikibase@master] Test if this fixes CI
  
  https://gerrit.wikimedia.org/r/618740

TASK DETAIL
  https://phabricator.wikimedia.org/T259785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Addshore, guergana.tzatchkova, Michael, toan, Aklapper, Akuckartz, Iflorez, 
darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259793: Create integration test to prevent ⧼Lang⧽ from causing a fatal error

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  In T259793#6365502 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > Hm, even the scribunto-console API doesn’t reproduce the error (Wikidata 
shouldn’t have the fix for T259744  
yet):
  
  Well, Wikidata is on wmf.2, where the bug doesn’t exist yet 臘 I thought I 
should be able to reproduce it on Beta Wikidata, where the bug should be 
deployed but not the fix (because it’s only backported to wmf.3, not merged in 
master); but no luck:
  
$ curl https://wikidata.beta.wmflabs.org/w/api.php -d format=json -d 
formatversion=2 -d action=scribunto-console -d title=Module:Blank -d 
question="=mw.wikibase.getLabel('Q1')" -d uselang='⧼Lang⧽'; echo

{"type":"normal","print":"","return":"nil","session":635795326,"sessionSize":27,"sessionMaxSize":50,"sessionIsNew":""}

TASK DETAIL
  https://phabricator.wikimedia.org/T259793

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Addshore, Pablo-WMDE, Aklapper, Michael, Akuckartz, 
Iflorez, darthmon_wmde, alaa_wmde, Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, elukey, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259793: Create integration test to prevent ⧼Lang⧽ from causing a fatal error

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Hm, even the scribunto-console API doesn’t reproduce the error (Wikidata 
shouldn’t have the fix for T259744  
yet):
  
$ curl https://www.wikidata.org/w/api.php -d format=json -d formatversion=2 
-d action=scribunto-console -d title=Module:Blank -d 
question="=mw.wikibase.getLabel('Q1')"; echo

{"type":"normal","print":"","return":"universe","session":1126382394,"sessionSize":27,"sessionMaxSize":50,"sessionIsNew":""}
$ curl https://www.wikidata.org/w/api.php -d format=json -d formatversion=2 
-d action=scribunto-console -d title=Module:Blank -d 
question="=mw.wikibase.getLabel('Q1')" -d uselang='⧼Lang⧽'; echo

{"type":"normal","print":"","return":"nil","session":512380653,"sessionSize":27,"sessionMaxSize":50,"sessionIsNew":""}
  
  Note that the result is different, so the uselang parameter isn’t being 
ignored – but it doesn’t cause an exception, either.

TASK DETAIL
  https://phabricator.wikimedia.org/T259793

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Addshore, Pablo-WMDE, Aklapper, Michael, Akuckartz, 
Iflorez, darthmon_wmde, alaa_wmde, Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, elukey, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259793: Create integration test to prevent ⧼Lang⧽ from causing a fatal error

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  The thing that makes this a bit tricky is that a Lua call like 
`mw.wikibase.getLabel('Q1234', '⧼Lang⧽')` doesn’t produce the error, at least 
not in this case – the language has to come from the request context, I think.

TASK DETAIL
  https://phabricator.wikimedia.org/T259793

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Addshore, Pablo-WMDE, Aklapper, Michael, Akuckartz, 
Iflorez, darthmon_wmde, alaa_wmde, Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, elukey, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).

TASK DETAIL
  https://phabricator.wikimedia.org/T259744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: Lucas_Werkmeister_WMDE, thiemowmde, Agusbou2015, toan, Ladsgroup, Addshore, 
Pablo-WMDE, Michael, Catrope, Aklapper, brennen, Alter-paule, Beast1978, 
CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, Poyekhali, _jensen, rosalieper, Taiwania_Justo, 
Scott_WUaS, Jonas, Ixocactus, Wong128hk, alex-mashin, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, jayvdb, MrStradivarius, Lydia_Pintscher, Anomie, 
Jdforrester-WMF, Jackmcbarn, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE lowered the priority of this task from "Unbreak Now!" to 
"High".
Lucas_Werkmeister_WMDE added a comment.


  Removing as wmf.3 blocker since it’s fixed on that branch, and lowering 
priority for the same reason.

TASK DETAIL
  https://phabricator.wikimedia.org/T259744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, thiemowmde, Agusbou2015, toan, Ladsgroup, Addshore, 
Pablo-WMDE, Michael, Catrope, Aklapper, brennen, Alter-paule, Beast1978, 
CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, Poyekhali, _jensen, rosalieper, Taiwania_Justo, 
Scott_WUaS, Jonas, Ixocactus, Wong128hk, alex-mashin, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, jayvdb, MrStradivarius, Lydia_Pintscher, Anomie, 
Jdforrester-WMF, Jackmcbarn, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE removed a parent task: T257971: 1.36.0-wmf.3 deployment 
blockers.

TASK DETAIL
  https://phabricator.wikimedia.org/T259744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, thiemowmde, Agusbou2015, toan, Ladsgroup, Addshore, 
Pablo-WMDE, Michael, Catrope, Aklapper, brennen, Alter-paule, Beast1978, 
CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, Poyekhali, _jensen, rosalieper, Taiwania_Justo, 
Scott_WUaS, Jonas, Ixocactus, Wong128hk, alex-mashin, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, jayvdb, MrStradivarius, Lydia_Pintscher, Anomie, 
Jdforrester-WMF, Jackmcbarn, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259793: Create integration test to prevent ⧼Lang⧽ from causing a fatal error

[Michael]

Michael created this task.
Michael added projects: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), 
Sustainability (Incident Followup).
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  Follow-up to T259744: Argument 3 passed to 
CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type 
string, null given 
  
  Links like https://test.wikidata.org/wiki/Module_talk:T259744?uselang=⧼Lang⧽ 
with a content of `{{#invoke:T259744|getLabel|entity=Q11}}` have caused a fatal 
production error like T259744 . This 
was introduced in the context of T250930 
 and T259779 
/T259783 
 seem related.

TASK DETAIL
  https://phabricator.wikimedia.org/T259793

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Addshore, Pablo-WMDE, Aklapper, Michael, Akuckartz, Iflorez, darthmon_wmde, 
alaa_wmde, Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, elukey, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  This should be fixed on wmf.3 now, but not yet on master. Marking as wmf.4 
deployment blocker so we don’t forget about it.

TASK DETAIL
  https://phabricator.wikimedia.org/T259744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, thiemowmde, Agusbou2015, toan, Ladsgroup, Addshore, 
Pablo-WMDE, Michael, Catrope, Aklapper, brennen, Alter-paule, Beast1978, 
CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, Poyekhali, _jensen, rosalieper, Taiwania_Justo, 
Scott_WUaS, Jonas, Ixocactus, Wong128hk, alex-mashin, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, jayvdb, MrStradivarius, Lydia_Pintscher, Anomie, 
Jdforrester-WMF, Jackmcbarn, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a parent task: T257972: 1.36.0-wmf.4 deployment 
blockers.

TASK DETAIL
  https://phabricator.wikimedia.org/T259744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: thiemowmde, Agusbou2015, toan, Ladsgroup, Addshore, Pablo-WMDE, Michael, 
Catrope, Aklapper, brennen, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, SundanceRaphael, 
Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, 
Wong128hk, alex-mashin, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, jayvdb, 
MrStradivarius, Lydia_Pintscher, Anomie, Jdforrester-WMF, Jackmcbarn, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

[Stashbot]

Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2020-08-06T11:27:17Z] 
 Synchronized 
php-1.36.0-wmf.3/extensions/Wikibase/lib/: Backport: [[gerrit:618579|Fix 
CachingFallbackLabelDescriptionLookup failing in edge-cases (T259744 
)]] (duration: 01m 10s)

TASK DETAIL
  https://phabricator.wikimedia.org/T259744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stashbot
Cc: thiemowmde, Agusbou2015, toan, Ladsgroup, Addshore, Pablo-WMDE, Michael, 
Catrope, Aklapper, brennen, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, SundanceRaphael, 
Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, 
Wong128hk, alex-mashin, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, jayvdb, 
MrStradivarius, Lydia_Pintscher, Anomie, Jdforrester-WMF, Jackmcbarn, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

[gerritbot]

gerritbot added a comment.


  Change 618579 **merged** by Lucas Werkmeister (WMDE):
  [mediawiki/extensions/Wikibase@wmf/1.36.0-wmf.3] Fix 
CachingFallbackLabelDescriptionLookup failing in edge-cases
  
  https://gerrit.wikimedia.org/r/618579

TASK DETAIL
  https://phabricator.wikimedia.org/T259744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: thiemowmde, Agusbou2015, toan, Ladsgroup, Addshore, Pablo-WMDE, Michael, 
Catrope, Aklapper, brennen, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, SundanceRaphael, 
Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, 
Wong128hk, alex-mashin, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, jayvdb, 
MrStradivarius, Lydia_Pintscher, Anomie, Jdforrester-WMF, Jackmcbarn, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

[gerritbot]

gerritbot added a comment.


  Change 618579 had a related patch set uploaded (by Ladsgroup; owner: Thiemo 
Kreuz (WMDE)):
  [mediawiki/extensions/Wikibase@wmf/1.36.0-wmf.3] Fix 
CachingFallbackLabelDescriptionLookup failing in edge-cases
  
  https://gerrit.wikimedia.org/r/618579

TASK DETAIL
  https://phabricator.wikimedia.org/T259744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: thiemowmde, Agusbou2015, toan, Ladsgroup, Addshore, Pablo-WMDE, Michael, 
Catrope, Aklapper, brennen, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, SundanceRaphael, 
Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, 
Wong128hk, alex-mashin, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, jayvdb, 
MrStradivarius, Lydia_Pintscher, Anomie, Jdforrester-WMF, Jackmcbarn, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T239208: Lexemes: Grammatical form can render as `[object Object]`

[gerritbot]

gerritbot added a comment.


  Change 618729 had a related patch set uploaded (by Thiemo Kreuz (WMDE); 
owner: Thiemo Kreuz (WMDE)):
  [oojs/ui@master] Fix several broken code paths related to 
LabelElement#getLabel
  
  https://gerrit.wikimedia.org/r/618729

TASK DETAIL
  https://phabricator.wikimedia.org/T239208

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: thiemowmde, Nikki, DannyS712, Akuckartz, darthmon_wmde, Nandana, 
Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T239208: Lexemes: Grammatical form can render as `[object Object]`

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T239208

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: thiemowmde, Nikki, DannyS712, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Mringgaard, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

[Michael]

Michael triaged this task as "Unbreak Now!" priority.
Michael added a comment.


  This seems to be blocking the merging of the patch 618703 
 for 
the current UBN T259744  and maybe 
T259745 ., thus triaging this as 
//Unbreak Now!// as well.

TASK DETAIL
  https://phabricator.wikimedia.org/T259785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: guergana.tzatchkova, Michael, toan, Aklapper, Akuckartz, Iflorez, 
darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, RhinosF1
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259783: LanguageFallbackChain does not end in 'en'

[thiemowmde]

thiemowmde added a comment.


  I believe this caused both T259744 
 and T259745 
. I already created T259779 
 where I describe an idea that is a 
little different from "should always and in en". One of the two tickets might 
be a duplicate now.

TASK DETAIL
  https://phabricator.wikimedia.org/T259783

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: Addshore, thiemowmde, Lydia_Pintscher, Pablo-WMDE, Aklapper, Michael, 
Akuckartz, darthmon_wmde, Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, elukey, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256779: Create Button Component

[Pablo-WMDE]

Pablo-WMDE claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T256779

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Addshore, Sarai-WMDE, Aklapper, darthmon_wmde, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

[toan]

toan created this task.
toan added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  Steps to Reproduce:
  
  - upload a new patch
  
  https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/618703
  https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/578298
  
  shows the same errors.
  
  Actual Results:
  
11:10:21 There were 6 failures:
11:10:21 
11:10:21 1) 
Wikibase\Repo\Tests\Hooks\ArticleRevisionVisibilitySetHookHandlerTest::testHandle
 with data set "One job with one revision identifier dispatched" 
(array(array('[{"arrayFormatVersion":1,"ent...":24}]', 1)), array(12), 
array(array(1, 0)))
11:10:21 Failed asserting that 0 is identical to 2.
11:10:21 
11:10:21 
/workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Hooks/ArticleRevisionVisibilitySetHookHandlerTest.php:220
11:10:21 /workspace/src/maintenance/doMaintenance.php:107
11:10:21 
11:10:21 2) 
Wikibase\Repo\Tests\Hooks\ArticleRevisionVisibilitySetHookHandlerTest::testHandle
 with data set "One job with two revision identifiers dispatched" 
(array(array('[{"arrayFormatVersion":1,"ent...":25}]', 1)), array(12, 13), 
array(array(1, 0), array(1, 474)))
11:10:21 Failed asserting that 0 is identical to 2.
11:10:21 
11:10:21 
/workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Hooks/ArticleRevisionVisibilitySetHookHandlerTest.php:220
11:10:21 /workspace/src/maintenance/doMaintenance.php:107
11:10:21 
11:10:21 3) 
Wikibase\Repo\Tests\Hooks\ArticleRevisionVisibilitySetHookHandlerTest::testHandle
 with data set "Two jobs dispatched (different bit flags)" 
(array(array('[{"arrayFormatVersion":1,"ent...":24}]', 1), 
array('[{"arrayFormatVersion":1,"ent...":25}]', 6)), array(12, 13), 
array(array(1, 0), array(6, 2)))
11:10:21 Failed asserting that 0 is identical to 2.
11:10:21 
11:10:21 
/workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Hooks/ArticleRevisionVisibilitySetHookHandlerTest.php:220
11:10:21 /workspace/src/maintenance/doMaintenance.php:107
11:10:21 
11:10:21 4) 
Wikibase\Repo\Tests\Hooks\ArticleRevisionVisibilitySetHookHandlerTest::testHandle
 with data set "Two jobs dispatched (small batch size)" 
(array(array('[{"arrayFormatVersion":1,"ent...":25}]', 1), 
array('[{"arrayFormatVersion":1,"ent...":26}]', 1)), array(12, 13, 14), 
array(array(1, 0), array(1, 2), array(1, 99)), true, 2)
11:10:21 Failed asserting that 0 is identical to 2.
11:10:21 
11:10:21 
/workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Hooks/ArticleRevisionVisibilitySetHookHandlerTest.php:220
11:10:21 /workspace/src/maintenance/doMaintenance.php:107
11:10:21 
11:10:21 5) 
Wikibase\Repo\Tests\Hooks\ArticleRevisionVisibilitySetHookHandlerTest::testHandle
 with data set "Multiple jobs with multiple revisions dispatched" 
(array(array('[{"arrayFormatVersion":1,"ent...":26}]', 1), 
array('[{"arrayFormatVersion":1,"ent...":25}]', 6)), array(12, 13, 14), 
array(array(1, 0), array(6, 2), array(1, 99)))
11:10:21 Failed asserting that 0 is identical to 2.
11:10:21 
11:10:21 
/workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Hooks/ArticleRevisionVisibilitySetHookHandlerTest.php:220
11:10:21 /workspace/src/maintenance/doMaintenance.php:107
11:10:21 
11:10:21 6) 
Wikibase\Repo\Tests\Hooks\ArticleRevisionVisibilitySetHookHandlerTest::testHandle
 with data set "One job dispatched, some revisions discarded" 
(array(array('[{"arrayFormatVersion":1,"ent...":24}]', 1)), array(404, 12, 
408), array(array(1, 0), array(1, 0), array(1, 2)))
11:10:21 Failed asserting that 0 is identical to 2.
11:10:21 
11:10:21 
/workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Hooks/ArticleRevisionVisibilitySetHookHandlerTest.php:220
11:10:21 /workspace/src/maintenance/doMaintenance.php:107
11:10:21 
  
  Expected Results:
  
  CI should pass

TASK DETAIL
  https://phabricator.wikimedia.org/T259785

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan
Cc: guergana.tzatchkova, Michael, toan, Aklapper, Akuckartz, Iflorez, 
darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259783: LanguageFallbackChain does not end in 'en'

[Michael]

Michael added subscribers: Pablo-WMDE, Lydia_Pintscher, thiemowmde, Addshore.
Michael added a comment.


  Adding Pablo as the IM in charge for the ongoing incident, Lydia as the PM 
for Wikidata, Thiemo as the dev that provided the patch and Adam as the one in 
charge of tech tickets.

TASK DETAIL
  https://phabricator.wikimedia.org/T259783

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Addshore, thiemowmde, Lydia_Pintscher, Pablo-WMDE, Aklapper, Michael, 
Akuckartz, darthmon_wmde, Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, elukey, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259783: LanguageFallbackChain does not end in 'en'

[Michael]

Michael added a subscriber: Sustainability (Incident Followup).
Michael added a project: Wikidata-Campsite.
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T259783

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: PHID-PROJ-7rajvj64e4qk5o5t7j3a, Aklapper, Michael, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259783: LanguageFallbackChain does not end in 'en'

[Michael]

Michael removed a subscriber: Sustainability (Incident Followup).
Michael added a project: Sustainability (Incident Followup).

TASK DETAIL
  https://phabricator.wikimedia.org/T259783

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Akuckartz, darthmon_wmde, Nandana, jijiki, Klaas_Z4us_V, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, elukey, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, 
Jay8g, PHID-PROJ-7rajvj64e4qk5o5t7j3a
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259783: LanguageFallbackChain does not end in 'en'

[Michael]

Michael created this task.
Michael added a project: Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Todo

TASK DETAIL
  https://phabricator.wikimedia.org/T259783

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

[Pablo-WMDE]

Pablo-WMDE added a comment.


  We discussed this task during the #wikidata-campsite 
 daily and it will be 
addressed with high priority.
  
  There is a patch up already which has some red because of another problem 
(T258184 ) which is in the making as 
well.

TASK DETAIL
  https://phabricator.wikimedia.org/T259744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: thiemowmde, Agusbou2015, toan, Ladsgroup, Addshore, Pablo-WMDE, Michael, 
Catrope, Aklapper, brennen, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, SundanceRaphael, 
Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, 
Wong128hk, alex-mashin, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, jayvdb, 
MrStradivarius, Lydia_Pintscher, Anomie, Jdforrester-WMF, Jackmcbarn, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

[gerritbot]

gerritbot added a comment.


  Change 618703 had a related patch set uploaded (by Thiemo Kreuz (WMDE); 
owner: Thiemo Kreuz (WMDE)):
  [mediawiki/extensions/Wikibase@master] Fix 
CachingFallbackLabelDescriptionLookup failing in edge-cases
  
  https://gerrit.wikimedia.org/r/618703

TASK DETAIL
  https://phabricator.wikimedia.org/T259744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: thiemowmde, Agusbou2015, toan, Ladsgroup, Addshore, Pablo-WMDE, Michael, 
Catrope, Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, 
Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, SundanceRaphael, 
Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, 
Wong128hk, alex-mashin, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, jayvdb, 
MrStradivarius, Lydia_Pintscher, Anomie, Jdforrester-WMF, Jackmcbarn, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T259744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: thiemowmde, Agusbou2015, toan, Ladsgroup, Addshore, Pablo-WMDE, Michael, 
Catrope, Aklapper, brennen, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, SundanceRaphael, 
Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, 
Wong128hk, alex-mashin, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, jayvdb, 
MrStradivarius, Lydia_Pintscher, Anomie, Jdforrester-WMF, Jackmcbarn, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256875: The streaming updater should support page deletions

[dcausse]

dcausse added a comment.


  In T256875#6364443 , 
@Mstyles wrote:
  
  > What do we want to do if we get a PageDelete event for the same item 
multiple times? Right now we're not tracking deletes, so I'm assuming multiple 
deletes for the same item probably can't do that much harm.
  
  I still don't know the best way to track this, multiple deletes won't harm 
much indeed but what we should avoid is treating a late RevCreateEvent as a new 
item to import while in reality it's deleted.
  Ideally we want to clear the state when we see a deletion but this might not 
allow us to track this kind of situation. Another possibility is to tell the 
state that we have seen a DeletePage for revision X by storing -X in the state 
(basically using the sign as flag to indicate previous deletion). I think this 
will have to be decided while implementing multiple unit tests simulating the 
various scenario we might see.

TASK DETAIL
  https://phabricator.wikimedia.org/T256875

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mstyles, dcausse
Cc: Aklapper, dcausse, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Namenlos314, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259779: LanguageFallbackChainFactory returns empty fallback chain when it shouldn't

[thiemowmde]

thiemowmde added a comment.


  T259744#6364309  mentions 
the patch that changed the behavior of the factory. It's now possible that 
language chains can be empty when the interface language is not a valid term 
language. There are a few language codes that are intentionally excluded from 
being term languages, e.g. "en-simple".
  
  One possible fix is to make sure all these invalid term languages fall back 
to a valid one when FALLBACK_SELF (or FALLBACK_ALL) is specified. For example, 
"en-simple" falls back to "en". At the moment, this exclude-list is hard-coded 
in WikibaseContentLanguages 
.
 Fallbacks are available via core, e.g. the official fallback for "de-formal" 

 is "de".

TASK DETAIL
  https://phabricator.wikimedia.org/T259779

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: Aklapper, hoo, liangent, brennen, Ammarpad, Umherirrender, Michael, Cparle, 
thiemowmde, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Pablo-WMDE, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Ricordisamoa, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

[thiemowmde]

thiemowmde added a comment.


  This is actually the exact same root cause as in T259745 
: The language fallback chain in 
question is empty, and calling `$languageCode = $languageCodes[0]` on an empty 
array results in the language code being null.
  
  https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/608628 is 
indeed what caused this, specifically 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/608628/13/lib/includes/TermLanguageFallbackChain.php.
 I created T259779  to keep track of 
the common root cause.

TASK DETAIL
  https://phabricator.wikimedia.org/T259744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: thiemowmde, Agusbou2015, toan, Ladsgroup, Addshore, Pablo-WMDE, Michael, 
Catrope, Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, 
Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, SundanceRaphael, 
Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, 
Wong128hk, alex-mashin, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, jayvdb, 
MrStradivarius, Lydia_Pintscher, Anomie, Jdforrester-WMF, Jackmcbarn, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

[thiemowmde]

thiemowmde added subscribers: Umherirrender, thiemowmde.
thiemowmde added a comment.


  The problematic `...` was added in patch 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/538388
 (T224772 ) by @Umherirrender 10 
months ago. I think I understand why: I believe Phan gets confused by how the 
called `\OOUI\Tag::appendContent()` method is documented. The method accepts 
any number of `string`, `\OOUI\Tag`, or `\OOUI\HtmlSnippet` in whatever 
combination and order, either as an array or as a list of parameters. So the 
documentation would need to say something like 
`string|Tag|HtmlSnippet|(string|Tag|HtmlSnippet)[]`, but talks about a generic 
`array` instead.
  
  Note that while adding the `...` slightly changed the semantics (while an 
array can be empty, a list of parameters can not), this was not a mistake! 
According to the documentation of getLanguagesOrderedByFallbackChain() it can 
never return an empty array, so getCaptionsContent() can never be an empty 
array as well. I believe there is another bug that makes these methods return 
empty arrays. I created T259779: LanguageFallbackChainFactory returns empty 
fallback chain when it shouldn't  to 
keep track of this.

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, thiemowmde
Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, CBogen, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Ramsey-WMF, Pablo-WMDE, 
GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, Maintenance_bot
Cc: Agusbou2015, Catrope, Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, 
Nandana, Lahi, Gq86, Ramsey-WMF, Pablo-WMDE, GoranSMilovanovic, QZanden, 
LawExplorer, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, 
Ixocactus, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Ricordisamoa, 
Lydia_Pintscher, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, 
Keegan, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, 
CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, 
Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259779: LanguageFallbackChainFactory returns empty fallback chain when it shouldn't

[thiemowmde]

thiemowmde created this task.
thiemowmde added projects: WikibaseMediaInfo, Wikidata, 
Wikimedia-production-error.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  While working on a hot-fix for T259745: Uncaught ArgumentCountError: Too few 
arguments to function OOUI\Tag::appendContent(), 0 passed 
 I realized the 
#wikimedia-production-error 
 probably 
hints at //another// bug. This is the code that failed:
  
$layout->appendContent(
...$this->getCaptionsContent(
$entity->getLabels(),
$this->getLanguagesOrderedByFallbackChain( $entity )
)
);
  
  Since appendContent() requires at least one argument, it fails when 
getCaptionsContent() returns an empty array. But wait, how is this possible? 
getLanguagesOrderedByFallbackChain() is documented to return at least the 
interface language. So it should be impossible that getCaptionsContent() 
returns nothing. How can the interface language get lost?
  
  The LanguageFallbackChain in question is created in 
WikibaseMediaInfoHooks::createEmptyStructuredData() 

 with no $mode flag set, which means it should default to FALLBACK_ALL when 
LanguageFallbackChainFactory::newFromLanguage() 

 is called. That //should// always include the original language in the result 
– but the code path is not obvious.
  
  I guess the task is to find out what's going on here, under which 
circumstances this LanguageFallbackChain can be empty, or add tracking code for 
this edge-case and monitor this potential bug further.

TASK DETAIL
  https://phabricator.wikimedia.org/T259779

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: Aklapper, hoo, liangent, brennen, Ammarpad, Umherirrender, Michael, Cparle, 
thiemowmde, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Pablo-WMDE, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Ricordisamoa, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256875: The streaming updater should support page deletions

[gerritbot]

gerritbot added a comment.


  Change 618159 **merged** by jenkins-bot:
  [wikidata/query/rdf@master] Make Deserialization Schema generic
  
  https://gerrit.wikimedia.org/r/618159

TASK DETAIL
  https://phabricator.wikimedia.org/T256875

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mstyles, gerritbot
Cc: Aklapper, dcausse, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Namenlos314, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256875: The streaming updater should support page deletions

[gerritbot]

gerritbot added a comment.


  Change 617761 **merged** by jenkins-bot:
  [wikidata/query/rdf@master] Add page delete stream to incoming streams
  
  https://gerrit.wikimedia.org/r/617761

TASK DETAIL
  https://phabricator.wikimedia.org/T256875

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mstyles, gerritbot
Cc: Aklapper, dcausse, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Namenlos314, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, ReleaseTaggerBot
Cc: Agusbou2015, Catrope, Aklapper, brennen, Alter-paule, Beast1978, CBogen, 
Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, 
Ixocactus, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Ricordisamoa, 
Lydia_Pintscher, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, 
Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

[gerritbot]

gerritbot added a comment.


  Change 618643 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseMediaInfo@master] Fix array unpacking as 
argument list
  
  https://gerrit.wikimedia.org/r/618643

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, gerritbot
Cc: Agusbou2015, Catrope, Aklapper, brennen, Alter-paule, Beast1978, CBogen, 
Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, 
Ixocactus, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Ricordisamoa, 
Lydia_Pintscher, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, 
Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259778: Flaky unit test SystemOverloadFilterUnitTest.percentOfRequestsDroppedIsRoughlyCorrect

[dcausse]

dcausse created this task.
dcausse added a project: Wikidata-Query-Service.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  See several times in jenkins or locally:
  
19:45:36 [ERROR] Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time 
elapsed: 0.243 s <<< FAILURE! - in 
org.wikidata.query.rdf.blazegraph.throttling.SystemOverloadFilterUnitTest
19:45:36 [ERROR] 
org.wikidata.query.rdf.blazegraph.throttling.SystemOverloadFilterUnitTest.percentOfRequestsDroppedIsRoughlyCorrect
  Time elapsed: 0.167 s  <<< FAILURE!
19:45:36 org.mockito.exceptions.base.MockitoAssertionError: 
19:45:36 
19:45:36 Wanted at most 300 times but was 301
19:45:36at 
org.wikidata.query.rdf.blazegraph.throttling.SystemOverloadFilterUnitTest.percentOfRequestsDroppedIsRoughlyCorrect(SystemOverloadFilterUnitTest.java:87)
19:45:36

TASK DETAIL
  https://phabricator.wikimedia.org/T259778

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: dcausse
Cc: dcausse, Aklapper, CBogen, Akuckartz, darthmon_wmde, Nandana, Namenlos314, 
Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, jkroll, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs