[Wikidata-bugs] [Maniphest] T305359: Define and adjust behavior of pressing "enter" in Lookups

[Nikki]

Nikki added a comment.


  In T305359#7828969 , 
@Lydia_Pintscher wrote:
  
  > I just tested what is happening in selectors for Item values right now on 
Item pages: nothing in both cases.
  > @Erdinc_Ciftci_WMDE @Sarai-WMDE: Thoughts?
  >
  > I'd love to hear thoughts from @Nikki as well.
  
  I never got a notification for this, sorry. :(
  
  If I've understood the description correctly, how it behaves on item pages 
for you isn't how it behaves for me. When selecting an item as the value of a 
statement, the first enter selects a search result, the second submits the 
edit. If there's no results, the first enter can't select a search result, 
which means the state can't change, so then the second enter behaves the same 
as the first and still can't select a search result.
  
  In T305359#7837689 , 
@Erdinc_Ciftci_WMDE wrote:
  
  > In 1, Enter shouldn't do anything because the user can go to the next area 
by just using the 'tab'.,
  
  I don't follow the logic there. The normal behaviour of enter in a form is to 
activate or accept the currently selected element (e.g. activate a button; 
accept the currently highlighted option for  a `` or in the list of 
auto-complete suggestions for an `` and close the dropdown; open and 
close date or colour selectors), or to submit the form. What does that have to 
do with moving to the next field?

TASK DETAIL
  https://phabricator.wikimedia.org/T305359

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, Nikki
Cc: Lydia_Pintscher, Nikki, Erdinc_Ciftci_WMDE, Sarai-WMDE, Aklapper, Michael, 
Astuthiodit_1, STHart, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306334: WDQS Map view doesn't distinguish layers with same label but different Qids

[Jheald]

Jheald created this task.
Jheald added a project: Wikidata Query UI.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Example query (drainage basins of Scottish rivers): https://w.wiki/54oh
  
  Opening the layers control, and toggling "River Dee" causes two different 
river basins to flash, even though they have different Qids (Q964949 ; 
Q7337328) in the ?layer column.

TASK DETAIL
  https://phabricator.wikimedia.org/T306334

WORKBOARD
  https://phabricator.wikimedia.org/project/board/2901/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jheald
Cc: Aklapper, Jheald, MPhamWMF, CBogen, Namenlos314, Gq86, 
Lucas_Werkmeister_WMDE, Mahir256, EBjune, merbst, Salgo60, Jonas, Xmlizer, 
jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T199062: Strange behavior of wikidata query map visualization with layers

[Jheald]

Jheald added a comment.


  Yes: it seems that where there are multiple results with the same 
coordinates, in the same layer, only one is shown, the others are suppressed

TASK DETAIL
  https://phabricator.wikimedia.org/T199062

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jheald
Cc: Jheald, Aklapper, Zeroth, Astuthiodit_1, karapayneWMDE, Invadibot, 
MPhamWMF, maantietaja, CBogen, ItamarWMDE, Akuckartz, Nandana, Namenlos314, 
Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Mahir256, QZanden, 
EBjune, merbst, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, Jonas, 
Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T199062: Strange behavior of wikidata query map visualization with layers

[Jheald]

Jheald added a comment.


  Duplicate of T189423 

TASK DETAIL
  https://phabricator.wikimedia.org/T199062

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jheald
Cc: Jheald, Aklapper, Zeroth, Astuthiodit_1, karapayneWMDE, Invadibot, 
MPhamWMF, maantietaja, CBogen, ItamarWMDE, Akuckartz, Nandana, Namenlos314, 
Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Mahir256, QZanden, 
EBjune, merbst, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, Jonas, 
Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306334: WDQS Map view doesn't distinguish layers with same label but different Qids

[Maintenance_bot]

Maintenance_bot added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T306334

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Aklapper, Jheald, Astuthiodit_1, karapayneWMDE, Invadibot, MPhamWMF, 
maantietaja, CBogen, ItamarWMDE, Akuckartz, Nandana, Namenlos314, Lahi, Gq86, 
Lucas_Werkmeister_WMDE, GoranSMilovanovic, Mahir256, QZanden, EBjune, merbst, 
LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, jkroll, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306334: WDQS Map view doesn't distinguish layers with same label but different Qids

[Jheald]

Jheald updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T306334

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jheald
Cc: Aklapper, Jheald, Astuthiodit_1, karapayneWMDE, Invadibot, MPhamWMF, 
maantietaja, CBogen, ItamarWMDE, Akuckartz, Nandana, Namenlos314, Lahi, Gq86, 
Lucas_Werkmeister_WMDE, GoranSMilovanovic, Mahir256, QZanden, EBjune, merbst, 
LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, jkroll, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T301471: New Service Request SchemaTree

[akosiaris]

akosiaris added a comment.


  In T301471#7840496 , 
@Michaelcochez wrote:
  
  > I merged the pull request on github now.
  >
  > I do not have rights to push to the gerrit repository, it might just be my 
limited knowledge of how gerrit works.
  
  I 've added to you to the gerrit 
`wikidata-propertysuggester-RecommenderServer` group, you should have access 
now.
  
  > I will look into the helm chart/CI setup soon.
  >
  >> questions around the index file:
  >
  > This file is the serialization of the in-memory tree structure used for 
recommendation. The file is a compressed (gzipped) binary file.  For 
serialization we  use https://pkg.go.dev/encoding/gob . Given this, and the 
fact that changes in the tree structure can have a 'rippling effect', it is not 
possible (or at least extremely hard) to alter the file. This tree is a 
specifically crafted type of index, serving its data from an external database 
would be impossible/detrimental for performance as it would require //a lot// 
of roundtrips.
  
  Despite the allure, shipping around serialized memory objects has many 
drawbacks as an approach. Most obvious are the security ones and most languages 
indeed put wording in their respective frameworks to point that out. 
https://github.com/golang/go/issues/20221 has some hints. Python's pickle more 
or less points out the same. Really big hacks that have ex-filtrated tons of 
private data have happened because of "serialization" vulnerabilities (e.g. the 
equifax hack was reliant on an apache struts serialization vulnerability - 
https://nakedsecurity.sophos.com/2017/09/06/apache-struts-serialisation-vulnerability-what-you-need-to-know/)
  
  There's more drawbacks of course. For example, how do you do versioning of 
the dataset? It needs to always match the definitions of the Golang Struct that 
it contains. Even simple changes in field names, can cause unintended behavior. 
e.g. changing a field name means that data for it will silently be dropped when 
deserializing an older dataset and loading it into memory.
  
  Thus the dataset needs to be strongly coupled with the application (that is 
they need to be deployed in tandem), which is a bad pattern due to the size 
constraints I 've explained about above, not to mention the fact that gerrit 
currently won't allow you to even upload the file.
  
  > The index file is loaded into memory once when the process starts. It could 
be loaded from 'anywhere' and does not even have to reside on disk necessarily.
  
  That's the thing. It can't be loaded from 'anywhere' cause of the security 
issues and because of the strong coupling it has with the application itself.
  
  A final question, regarding the external database roundtrips note. Almost all 
datastores (either RDBMS ones or NoSQL ones) have the ability to batch results, 
obviating the need to multiple roundtrips. As a result e.g. many ORMs 
(Hibernate, Django, SQLAlchemy, Gorm) also support this (naming the 
functionality with various terms, but it's there). In fact, we 've seen this 
before and in most cases rewriting the queries to fetch hundreds or thousands 
of entities in 1 go instead of hundreds or thousands of queries was trivial.
  
  There are also other well known, proven and safer ways of shipping around 
serialized structured data, e.g. protocol buffers (aka protobufs[1]).
  
  Have any of the above been evaluated?
  
  [1] https://developers.google.com/protocol-buffers

TASK DETAIL
  https://phabricator.wikimedia.org/T301471

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: akosiaris
Cc: akosiaris, QChris, ItamarWMDE, Joe, Aklapper, Addshore, karapayneWMDE, 
Martaannaj, Michaelcochez, Astuthiodit_1, Arnoldokoth, Invadibot, maantietaja, 
wkandek, JMeybohm, Akuckartz, Nandana, jijiki, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Eevans, Hardikj, 
Wikidata-bugs, aude, Sjoerddebruin, Jdforrester-WMF, Mbch331, Jay8g, Dzahn
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T54321: the message diff-multi above comparison of several revisions has wrong directionality

[gerritbot]

gerritbot added a comment.


  Change 783848 had a related patch set uploaded (by Bking; author: Bking):
  
  [operations/puppet@production] Elastic: use major version only for 
'config_version'
  
  https://gerrit.wikimedia.org/r/783848

TASK DETAIL
  https://phabricator.wikimedia.org/T54321

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Amire80, gerritbot
Cc: Amire80, Denny, Nikerabbit, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Prufkick, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, Dinadineke, DannyS712, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, tabish.shaikh91, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Jayprakash12345, JakeTheDeveloper, QZanden, 
merbst, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, 
Gryllida, Shizhao, Arrbee, TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306054: Upgrade deployment-wdqs01 host to Buster

[Stashbot]

Stashbot added a comment.


  Mentioned in SAL (#wikimedia-releng) [2022-04-18T15:33:02Z]  
Shutting off deployment-wdqs01 from the Beta Cluster project per T306054 
; it's apparently unused, so this 
shouldn't break anything.

TASK DETAIL
  https://phabricator.wikimedia.org/T306054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stashbot
Cc: dcausse, Lucas_Werkmeister_WMDE, Mathew.onipe, Aklapper, Majavah, 
Peachey88, Jdforrester-WMF, Astuthiodit_1, karapayneWMDE, Invadibot, MPhamWMF, 
maantietaja, CBogen, ItamarWMDE, Akuckartz, CptViraj, DannyS712, Nandana, 
Namenlos314, Lahi, Gq86, Bsandipan, GoranSMilovanovic, QZanden, EBjune, merbst, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, jkroll, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Addshore, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303394: METRICS - Metrics for page use

[Lydia_Pintscher]

Lydia_Pintscher removed Lydia_Pintscher as the assignee of this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T303394

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lydia_Pintscher, Michael, Aklapper, karapayneWMDE, Astuthiodit_1, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305438: Define user testing for the new page

[Lydia_Pintscher]

Lydia_Pintscher reassigned this task from Lydia_Pintscher to Erdinc_Ciftci_WMDE.

TASK DETAIL
  https://phabricator.wikimedia.org/T305438

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Erdinc_Ciftci_WMDE, Lydia_Pintscher
Cc: Lydia_Pintscher, Erdinc_Ciftci_WMDE, Mattia_Capozzi_WMDE, karapayneWMDE, 
Aklapper, Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, 
_jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306358: NewEntitySchemaTest::testNewSchemaIsNotCreatedWhenBlocked test failure

[Reedy]

Reedy created this task.
Reedy added projects: ci-test-error (WMF-deployed Build Failure), Wikidata, 
Wikidata-Campsite.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Seen on 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EntitySchema/+/781404 and 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ApiFeatureUsage/+/777460
  
  
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/147085/console
  
05:52:36 1) 
EntitySchema\Tests\Integration\MediaWiki\Specials\NewEntitySchemaTest::testNewSchemaIsNotCreatedWhenBlocked
05:52:36 InvalidArgumentException: WikiPage constructed on a Title that 
cannot exist as a page: Special:NewEntitySchema
05:52:36 
05:52:36 /workspace/src/includes/page/WikiPage.php:177
05:52:36 /workspace/src/includes/page/Article.php:141
05:52:36 /workspace/src/includes/page/Article.php:127
05:52:36 /workspace/src/includes/page/Article.php:179
05:52:36 /workspace/src/includes/Permissions/PermissionManager.php:815
05:52:36 /workspace/src/includes/Permissions/PermissionManager.php:478
05:52:36 /workspace/src/includes/Permissions/PermissionManager.php:323
05:52:36 
/workspace/src/extensions/EntitySchema/src/MediaWiki/Specials/NewEntitySchema.php:241
05:52:36 
/workspace/src/extensions/EntitySchema/src/MediaWiki/Specials/NewEntitySchema.php:47
05:52:36 
/workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:115
05:52:36 
/workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:44
05:52:36 
/workspace/src/tests/phpunit/includes/specials/SpecialPageTestBase.php:78
05:52:36 
/workspace/src/extensions/EntitySchema/tests/phpunit/integration/MediaWiki/Specials/NewEntitySchemaTest.php:87
05:52:36 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:467

TASK DETAIL
  https://phabricator.wikimedia.org/T306358

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Reedy
Cc: Aklapper, Reedy, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org