[Wikidata-bugs] [Maniphest] T323568: Format calendar model in non-HTML output formats if needed

2022-11-24 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T323568

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: Lydia_Pintscher, Aklapper, Hjfocs, Lucas_Werkmeister_WMDE, ItamarWMDE, 
HasanAkgun_WMDE, jmkeil, noarave, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Adamm71, Jersione, Hellket777, LisafBia6531, 786, 
Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323568: Format calendar model in non-HTML output formats if needed

2022-11-24 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).

TASK DETAIL
  https://phabricator.wikimedia.org/T323568

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: Lydia_Pintscher, Aklapper, Hjfocs, Lucas_Werkmeister_WMDE, ItamarWMDE, 
HasanAkgun_WMDE, jmkeil, noarave, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323568: Format calendar model in non-HTML output formats if needed

2022-11-24 Thread gerritbot
gerritbot added a comment.


  Change 859587 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Introduce new showcalendar option for 
time formatters
  
  https://gerrit.wikimedia.org/r/859587

TASK DETAIL
  https://phabricator.wikimedia.org/T323568

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lydia_Pintscher, Aklapper, Hjfocs, Lucas_Werkmeister_WMDE, ItamarWMDE, 
HasanAkgun_WMDE, jmkeil, noarave, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323778: Wikibase doesn’t validate formatter options, can crash with different TypeErrors

2022-11-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, wdwb-tech.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  The `wbformatvalue` API has an `options` parameter that allows users to 
specify the `FormatterOptions` that will be used to format the value, as JSON. 
Several of Wikibase’s value formatters don’t really validate these options, so 
if an API user puts garbage in them, they can provoke various `TypeError`s, For 
example, `LatLongFormatter` has options to customize the strings used for 
N/E/S/W, °/'/", set the format to float/dms/dm/dd and determine the floating 
point precision, where to put spacing, whether to use -1° or 1° S, and what the 
separator between latitude and longitude is. (Don’t ask me why this class is so 
amazingly configurable.) By setting the “north” option to an int instead, we 
get a type error.
  

api.php?action=wbformatvalue=json=text%2Fplain=%7B%0A%20%20%22value%22%3A%20%7B%0A%20%20%20%20%22latitude%22%3A%2027.98805556%2C%0A%20%20%20%20%22longitude%22%3A%2086.92527778%2C%0A%20%20%20%20%22altitude%22%3A%20null%2C%0A%20%20%20%20%22precision%22%3A%200.00028%2C%0A%20%20%20%20%22globe%22%3A%20%22http%3A%2F%2Fwww.wikidata.org%2Fentity%2FQ2%22%0A%20%20%7D%2C%0A%20%20%22type%22%3A%20%22globecoordinate%22%0A%7D%0A=%7B%22north%22%3A%201%7D=2

datavalue={
  "value": {
"latitude": 27.98805556,
"longitude": 86.92527778,
"altitude": null,
"precision": 0.00028,
"globe": "http://www.wikidata.org/entity/Q2;
  },
  "type": "globecoordinate"
}

options={"north": 1}
  
  
  
  > Exception caught: 
DataValues\\Geo\\Formatters\\LatLongFormatter::makeDirectionalIfNeeded(): 
Argument #2 ($positiveSymbol) must be of type string, int given

TASK DETAIL
  https://phabricator.wikimedia.org/T323778

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323776: Add functionality to let Wikibase Lua code format dates with the calendar model automatically shown if needed.

2022-11-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Note that since T323568 , the 
plain text and wikitext formatters are capable of adding the calendar model, 
but don’t do it by default; it can be enabled by setting the `showcalendar` 
parser option to `'auto'`. But I’m not sure if adding the ability for Lua 
clients to pass arbitrary parser options into the “format”/“render” methods is 
the best way to solve this.
  
  (Also, this task probably needs some more polishing in general.)

TASK DETAIL
  https://phabricator.wikimedia.org/T323776

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, LennardHofmann, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323776: Add functionality to let Wikibase Lua code format dates with the calendar model automatically shown if needed.

2022-11-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, 
MediaWiki-extensions-WikibaseClient, Wikibase-Lua.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  When Wikibase formats time values as HTML, it automatically shows the 
calendar model if needed (depending on the precision, date, and what the 
automatically guessed calendar model would be for that date). However, 
formatting times as wikitext or plain text only formats the time value itself. 
Lua modules can add the calendar model “manually”, but Wikibase’s logic 
deciding when to show the calendar model or not isn’t accessible to them.
  
=mw.wikibase.formatValue({snaktype = 'value', property = 'P569', datatype = 
'time', datavalue = {type = 'time', value = {time = '+1879-03-14T00:00:00Z', 
timezone = 0, before = 0, after = 0, precision = 11, calendarmodel = 
'http://www.wikidata.org/entity/Q1985727' }}})
14 March 1879
=mw.wikibase.renderSnak({snaktype = 'value', property = 'P569', datatype = 
'time', datavalue = {type = 'time', value = {time = '+1879-03-14T00:00:00Z', 
timezone = 0, before = 0, after = 0, precision = 11, calendarmodel = 
'http://www.wikidata.org/entity/Q1985727' }}})
14 March 1879

TASK DETAIL
  https://phabricator.wikimedia.org/T323776

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, LennardHofmann, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323774: some `wdtn:` values have disappeared

2022-11-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Invalid".
Lucas_Werkmeister_WMDE added a comment.


  `wdtn:` for external identifiers is based on formatter URI for RDF resource 
(P1921) , not formatter URL 
(P1630) . LinkedIn organization 
ID  has no formatter URI for RDF 
defined.

TASK DETAIL
  https://phabricator.wikimedia.org/T323774

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, VladimirAlexiev, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323774: some `wdtn:` values have disappeared

2022-11-24 Thread VladimirAlexiev
VladimirAlexiev updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T323774

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: VladimirAlexiev
Cc: Aklapper, VladimirAlexiev, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T321571: Design request for new main page header image:

2022-11-24 Thread Sarai-WMDE
Sarai-WMDE added a comment.


  >> I'm not sure what the proper fix would be either, but strangely enough, 
just disabling the `auto` height applied to the image (which I guess is 
enforcing the original size and keeping the aspect ratio) seems to do the 
trick? I'm not sure if the level of specificity here might be problematic, but 
I don't see any other images affected by this change.
  >>
  >> F35817281: Nov-24-2022 12-00-53.gif 

  >
  > Yeah, I got this far as well, but I do not know how I can overwrite this 
behavior. I can add a height attribute to the image in question, but I cannot 
figure out which value it has to have. The problematic definition `.content a > 
img { height: auto !important; }` seems to come from the Minerva skin which I 
cannot modify.
  
  So strange that simply `100%` doesn't work. I found that the image's height 
improves a bit using the values `inherit` or `-webkit-fill-available` (the 
vendor prefix seems to be a must for Chrome). The same result is obtained 
adding `min-height:100%` to the existing CSS. They all seem good enough 
solutions.
  
  >> It's of course quite light in comparison to the previous version. Do you 
think the legibility of the content is compromised? (e.g. poor contrast, 
overlapping with image elements on the background). I like how we're now using 
the same color applied to the main navigation menu (just with some opacity to 
avoid disrupting the image): makes the page look quite balanced. But this is, 
of course, quite subjective.
  >
  > Legibility is fine, it's just … a very pale and partially transparent (as 
intended) tone. The contrast to the background is barely there, but it 
shouldn't really contrast the background anyways. Not sure how it looks on 
cheap or poorly calibrated displays.
  
  That last point concerns me too. I'll figure out how to validate this.
  
  >> Applying a rough margin bottom to the banner-container div in Minerva 
creates the right spacing:
  >>
  >> F35817332: Screenshot 2022-11-24 at 12.38.42.png 

  >
  > Okay I begin to really understand the problem. I always used the mobile 
main page while being logged in, with the very unpopular "Welcome, username!" 
message between the search bar and the hero image. Then there is indeed no 
problem.
  >
  > However, when browsing the main page while not logged in, it does look 
wrong indeed. I have thus added a 16px top margin to the main page hero image 
container for logged-out users of the Minerva skin only.
  
  Thanks again very much for the fix!

TASK DETAIL
  https://phabricator.wikimedia.org/T321571

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Mohammed_Sadat_WMDE, MisterSynergy, Sarai-WMDE, Lydia_Pintscher, 
Arian_Bozorg, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323774: some `wdtn:` values have disappeared

2022-11-24 Thread VladimirAlexiev
VladimirAlexiev created this task.
VladimirAlexiev added a project: Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  `wdtn:` values expand external-ids to full URLs (documented at 
https://www.mediawiki.org/wiki/Wikibase/Indexing/RDF_Dump_Format#Normalized_External_ID,
 and many issues here 
 discuss this 
feature).
  
  Eg for https://www.wikidata.org/entity/Q7095072.ttl:
  
ttl
PREFIX wdtn: 

wd:Q7095072 
wdt:P6366 "46831270" ; wdtn:P6366  
;
wdt:P646 "/m/026gcj6" ; wdtn:P646  ;
wdt:P4264 "ontotext-ad" ;
wdt:P2671 "/g/1ts_52mq" ; wdtn:P2671  ;
  
  P4264 has a valid `formatterUrl`, so why is this missing?
  
`ttl
wdtn:P4264 

TASK DETAIL
  https://phabricator.wikimedia.org/T323774

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: VladimirAlexiev
Cc: Aklapper, VladimirAlexiev, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323734: Move language-specific logos from Commons.css to logos.php at wikidatawiki

2022-11-24 Thread Stang
Stang added a comment.


  I have removed the override 
 in MediaWiki:Common.css

TASK DETAIL
  https://phabricator.wikimedia.org/T323734

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stang
Cc: Lucas_Werkmeister_WMDE, Aftabuzzaman, Aklapper, Stang, LisafBia6531, 
Astuthiodit_1, Yodas_henchman, NguoiDungKhongDinhDanh, karapayneWMDE, 
Invadibot, Zabe, maantietaja, Juan90264, ItamarWMDE, Akuckartz, CptViraj, 
AKA_MBG, Dibya, 94rain, Nandana, Tks4Fish, Lahi, Gq86, GoranSMilovanovic, 
Jayprakash12345, QZanden, Kizule, LawExplorer, Devwaker, Niklitov, _jensen, 
Urbanecm, rosalieper, JEumerus, Scott_WUaS, Ananthsubray, Superzerocool, 
Stanglavine, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Wikidata-bugs, 
Snowolf, Base, aude, Dcljr, Isarra, Matanya, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T210503: Wikidata Query UI code sample tests are disabled everywhere

2022-11-24 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T210503

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, AWesterinen, 
karapayneWMDE, Invadibot, MPhamWMF, maantietaja, CBogen, ItamarWMDE, Akuckartz, 
Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, EBjune, 
merbst, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, 
jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Lydia_Pintscher, Mbch331, Adamm71, Jersione, Hellket777, LisafBia6531, 786, 
Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T309938: Add Kartographer transformation to Code tab

2022-11-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  The Gerrit change implementing this was included in this query-gui build 
, so it 
should be deployed soon (within 30 minutes, I believe).

TASK DETAIL
  https://phabricator.wikimedia.org/T309938

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Aklapper, Ainali, Astuthiodit_1, 
AWesterinen, karapayneWMDE, Invadibot, MPhamWMF, maantietaja, CBogen, 
ItamarWMDE, Akuckartz, Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, rosalieper, 
Scott_WUaS, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, 
Manybubbles, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T210503: Wikidata Query UI code sample tests are disabled everywhere

2022-11-24 Thread gerritbot
gerritbot added a comment.


  Change 860585 **merged** by Lucas Werkmeister (WMDE):
  
  [wikidata/query/gui-deploy@production] Merging from 
6c4582fb6e6e5b5985c4e3ed0a6b088f1e1a99d1
  
  https://gerrit.wikimedia.org/r/860585

TASK DETAIL
  https://phabricator.wikimedia.org/T210503

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, AWesterinen, 786, Biggs657, karapayneWMDE, 
Invadibot, MPhamWMF, maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, 
Nandana, Namenlos314, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, EBjune, merbst, LawExplorer, 
Salgo60, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T210503: Wikidata Query UI code sample tests are disabled everywhere

2022-11-24 Thread gerritbot
gerritbot added a comment.


  Change 860585 had a related patch set uploaded (by WDQSGuiBuilder; author: 
WDQSGuiBuilder):
  
  [wikidata/query/gui-deploy@production] Merging from 
6c4582fb6e6e5b5985c4e3ed0a6b088f1e1a99d1
  
  https://gerrit.wikimedia.org/r/860585

TASK DETAIL
  https://phabricator.wikimedia.org/T210503

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, AWesterinen, 786, Biggs657, karapayneWMDE, 
Invadibot, MPhamWMF, maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, 
Nandana, Namenlos314, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, EBjune, merbst, LawExplorer, 
Salgo60, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T210503: Wikidata Query UI code sample tests are disabled everywhere

2022-11-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE added a comment.


  I think this is fixed now \o/

TASK DETAIL
  https://phabricator.wikimedia.org/T210503

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, AWesterinen, 786, Biggs657, karapayneWMDE, 
Invadibot, MPhamWMF, maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, 
Nandana, Namenlos314, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, EBjune, merbst, LawExplorer, 
Salgo60, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T210503: Wikidata Query UI code sample tests are disabled everywhere

2022-11-24 Thread gerritbot
gerritbot added a comment.


  Change 859091 **merged** by jenkins-bot:
  
  [wikidata/query/gui@master] Run code-examples tests using 
grunt-contrib-connect
  
  https://gerrit.wikimedia.org/r/859091

TASK DETAIL
  https://phabricator.wikimedia.org/T210503

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, AWesterinen, 786, Biggs657, karapayneWMDE, 
Invadibot, MPhamWMF, maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, 
Nandana, Namenlos314, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, EBjune, merbst, LawExplorer, 
Salgo60, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323734: Move language-specific logos from Commons.css to logos.php at wikidatawiki

2022-11-24 Thread Stashbot
Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2022-11-24T14:37:55Z]  
lucaswerkmeister-wmde@mwmaint1002:~$ printf 
'https://en.wikipedia.org/static/images/project-logos/wikidatawiki%s.png\n' '' 
'-1.5x' '-2x' | mwscript purgeList.php # T323734 


TASK DETAIL
  https://phabricator.wikimedia.org/T323734

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stang, Stashbot
Cc: Lucas_Werkmeister_WMDE, Aftabuzzaman, Aklapper, Stang, LisafBia6531, 
Astuthiodit_1, Yodas_henchman, NguoiDungKhongDinhDanh, karapayneWMDE, 
Invadibot, Zabe, maantietaja, Juan90264, ItamarWMDE, Akuckartz, CptViraj, 
AKA_MBG, Dibya, 94rain, Nandana, Tks4Fish, Lahi, Gq86, GoranSMilovanovic, 
Jayprakash12345, QZanden, Kizule, LawExplorer, Devwaker, Niklitov, _jensen, 
Urbanecm, rosalieper, JEumerus, Scott_WUaS, Ananthsubray, Superzerocool, 
Stanglavine, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Wikidata-bugs, 
Snowolf, Base, aude, Dcljr, Isarra, Matanya, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323734: Move language-specific logos from Commons.css to logos.php at wikidatawiki

2022-11-24 Thread Stashbot
Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2022-11-24T14:36:56Z] 
 Finished scap: Backport for 
[[gerrit:860117|wikidatawiki: Add language-specific logos (T323734 
)]] (duration: 17m 24s)

TASK DETAIL
  https://phabricator.wikimedia.org/T323734

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stang, Stashbot
Cc: Lucas_Werkmeister_WMDE, Aftabuzzaman, Aklapper, Stang, LisafBia6531, 
Astuthiodit_1, Yodas_henchman, NguoiDungKhongDinhDanh, karapayneWMDE, 
Invadibot, Zabe, maantietaja, Juan90264, ItamarWMDE, Akuckartz, CptViraj, 
AKA_MBG, Dibya, 94rain, Nandana, Tks4Fish, Lahi, Gq86, GoranSMilovanovic, 
Jayprakash12345, QZanden, Kizule, LawExplorer, Devwaker, Niklitov, _jensen, 
Urbanecm, rosalieper, JEumerus, Scott_WUaS, Ananthsubray, Superzerocool, 
Stanglavine, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Wikidata-bugs, 
Snowolf, Base, aude, Dcljr, Isarra, Matanya, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323734: Move language-specific logos from Commons.css to logos.php at wikidatawiki

2022-11-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Note that the patch also reduces the visual size of the main / English logo 
at 100% zoom:
  F35817572: image.png 
  The PNG file now has the same width as most other project logos, 135px; I 
can’t say whether the visual change is good or not. (At 150% and 200%, there’s 
no difference; I don’t know whether the -1.5x and -2x files were inconsistent 
with the main file before or are inconsistent now.) I’ll still deploy this 
change, but it might need a follow-up.

TASK DETAIL
  https://phabricator.wikimedia.org/T323734

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stang, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aftabuzzaman, Aklapper, Stang, LisafBia6531, 
Astuthiodit_1, Yodas_henchman, NguoiDungKhongDinhDanh, karapayneWMDE, 
Invadibot, Zabe, maantietaja, Juan90264, ItamarWMDE, Akuckartz, CptViraj, 
AKA_MBG, Dibya, 94rain, Nandana, Tks4Fish, Lahi, Gq86, GoranSMilovanovic, 
Jayprakash12345, QZanden, Kizule, LawExplorer, Devwaker, Niklitov, _jensen, 
Urbanecm, rosalieper, JEumerus, Scott_WUaS, Ananthsubray, Superzerocool, 
Stanglavine, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Wikidata-bugs, 
Snowolf, Base, aude, Dcljr, Isarra, Matanya, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323734: Move language-specific logos from Commons.css to logos.php at wikidatawiki

2022-11-24 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T323734

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stang, Maintenance_bot
Cc: Aftabuzzaman, Aklapper, Stang, LisafBia6531, Astuthiodit_1, Yodas_henchman, 
NguoiDungKhongDinhDanh, karapayneWMDE, Invadibot, Zabe, maantietaja, Juan90264, 
ItamarWMDE, Akuckartz, CptViraj, AKA_MBG, Dibya, 94rain, Nandana, Tks4Fish, 
Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, Kizule, LawExplorer, 
Devwaker, Niklitov, _jensen, Urbanecm, rosalieper, JEumerus, Scott_WUaS, 
Ananthsubray, Superzerocool, Stanglavine, Tulsi_Bhagat, Wong128hk, Luke081515, 
SimmeD, Wikidata-bugs, Snowolf, Base, aude, Dcljr, Isarra, Matanya, Mbch331, 
Jay8g, Krenair, Adamm71, Jersione, Hellket777, 786, Biggs657, Alter-paule, 
Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, 
Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323734: Move language-specific logos from Commons.css to logos.php at wikidatawiki

2022-11-24 Thread Stashbot
Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2022-11-24T14:20:52Z] 
 lucaswerkmeister-wmde and stang: Backport 
for [[gerrit:860117|wikidatawiki: Add language-specific logos (T323734 
)]] synced to the testservers: 
mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, 
mwdebug1002.eqiad.wmnet

TASK DETAIL
  https://phabricator.wikimedia.org/T323734

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stang, Stashbot
Cc: Aftabuzzaman, Aklapper, Stang, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, Yodas_henchman, 786, NguoiDungKhongDinhDanh, Biggs657, 
karapayneWMDE, Invadibot, Zabe, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, AKA_MBG, Kent7301, Dibya, 
joker88john, 94rain, CucyNoiD, Nandana, Tks4Fish, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, 
QZanden, Kizule, LawExplorer, Lewizho99, Maathavan, Devwaker, Niklitov, 
_jensen, Urbanecm, rosalieper, Neuronton, JEumerus, Scott_WUaS, Ananthsubray, 
Superzerocool, Stanglavine, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, 
Wikidata-bugs, Snowolf, Base, aude, Dcljr, Isarra, Matanya, Mbch331, Jay8g, 
Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323734: Move language-specific logos from Commons.css to logos.php at wikidatawiki

2022-11-24 Thread Stashbot
Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2022-11-24T14:19:32Z] 
 Started scap: Backport for 
[[gerrit:860117|wikidatawiki: Add language-specific logos (T323734 
)]]

TASK DETAIL
  https://phabricator.wikimedia.org/T323734

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stang, Stashbot
Cc: Aftabuzzaman, Aklapper, Stang, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, Yodas_henchman, 786, NguoiDungKhongDinhDanh, Biggs657, 
karapayneWMDE, Invadibot, Zabe, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, AKA_MBG, Kent7301, Dibya, 
joker88john, 94rain, CucyNoiD, Nandana, Tks4Fish, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, 
QZanden, Kizule, LawExplorer, Lewizho99, Maathavan, Devwaker, Niklitov, 
_jensen, Urbanecm, rosalieper, Neuronton, JEumerus, Scott_WUaS, Ananthsubray, 
Superzerocool, Stanglavine, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, 
Wikidata-bugs, Snowolf, Base, aude, Dcljr, Isarra, Matanya, Mbch331, Jay8g, 
Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323734: Move language-specific logos from Commons.css to logos.php at wikidatawiki

2022-11-24 Thread gerritbot
gerritbot added a comment.


  Change 860117 **merged** by jenkins-bot:
  
  [operations/mediawiki-config@master] wikidatawiki: Add language-specific logos
  
  https://gerrit.wikimedia.org/r/860117

TASK DETAIL
  https://phabricator.wikimedia.org/T323734

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stang, gerritbot
Cc: Aftabuzzaman, Aklapper, Stang, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, Yodas_henchman, 786, NguoiDungKhongDinhDanh, Biggs657, 
karapayneWMDE, Invadibot, Zabe, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, AKA_MBG, Kent7301, Dibya, 
joker88john, 94rain, CucyNoiD, Nandana, Tks4Fish, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, 
QZanden, Kizule, LawExplorer, Lewizho99, Maathavan, Devwaker, Niklitov, 
_jensen, Urbanecm, rosalieper, Neuronton, JEumerus, Scott_WUaS, Ananthsubray, 
Superzerocool, Stanglavine, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, 
Wikidata-bugs, Snowolf, Base, aude, Dcljr, Isarra, Matanya, Mbch331, Jay8g, 
Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T321441: Large horizontal scroll bar when editing on Wikidata for RTL interface languages

2022-11-24 Thread Michael
Michael moved this task from Peer Review to Product Verification on the 
Wikidata Dev Team (Sprint-∞) board.
Michael added a comment.


  This should now be verifiable on beta 
https://wikidata.beta.wmflabs.org/wiki/Q112?uselang=ar, and next week after the 
train on www.wikidata.org

TASK DETAIL
  https://phabricator.wikimedia.org/T321441

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6017/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Lydia_Pintscher, Nikki, Aklapper, mrephabricator, Astuthiodit_1, 
Prufkick, karapayneWMDE, Invadibot, Manishagoenka, maantietaja, cristiana023, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
Muhammed4IT, LawExplorer, _jensen, rosalieper, JGirault, Scott_WUaS, Srdjan, 
MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Huji, Amire80, 
Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T321571: Design request for new main page header image:

2022-11-24 Thread MisterSynergy
MisterSynergy added a comment.


  In T321571#8419697 , 
@Sarai-WMDE wrote:
  
  >> - The background image ("hero") seems to scale okay-ish on desktop now, 
but there is some CSS definition in the mobile skin (as much as I am aware) 
which makes it scale down in a poor way on mobile. Not sure how to fix this, to 
be honest.
  >
  > If not sure what the proper fix would be either, but strangely enough, just 
disabling the `auto` height applied to the image (which I guess is enforcing 
the original size and keeping the aspect ratio) seems to do the trick? I'm not 
sure if the level of specificity here might be problematic, but I don't see any 
other images affected by this change.
  >
  > F35817281: Nov-24-2022 12-00-53.gif 

  
  Yeah, I got this far as well, but I do not know how I can overwrite this 
behavior. I can add a height attribute to the image in question, but I cannot 
figure out which value it has to have. The problematic definition `.content a > 
img { height: auto !important; }` seems to come from the Minerva skin which I 
cannot modify.
  
  >> - The light gray background is now `#f8f9fae6` as suggested, but is looks 
pretty pale on my display. I personally would make it a bit darker.
  >
  > It's of course quite light in comparison to the previous version. Do you 
think the legibility of the content is compromised? (e.g. poor contrast, 
overlapping with image elements on the background). I like how we're now using 
the same color applied to the main navigation menu (just with some opacity to 
avoid disrupting the image): makes the page look quite balanced. But this is, 
of course, quite subjective.
  
  Legibility is fine, it's just … a very pale and partially transparent (as 
intended) tone. The contrast to the background is barely there, but it 
shouldn't really contrast the background anyways. Not sure how it looks on 
cheap or poorly calibrated displays.
  
  Anyways, perhaps it's simply the unfamiliar look which bothers me. This was 
really not meant to be a real issue for debate here :-)
  
  >> - The `16px margin` on desktop are defined in `.mw-body-content` as much 
as I am aware. Since this looks like a skin definition, I have left it as is on 
both desktop and mobile.
  >
  > If we fix the height of the image on mobile, this might stop being an 
issue. The main problem at the moment is that the headerbox "touches" the page 
header. There should be some spacing between the elements.
  >
  > Applying a rough margin bottom to the banner-container div in Minerva 
creates the right spacing:
  >
  > F35817332: Screenshot 2022-11-24 at 12.38.42.png 

  
  Okay I begin to really understand the problem. I always used the mobile main 
page while being logged in, with the very unpopular "Welcome, username!" 
message between the search bar and the hero image. Then there is indeed no 
problem.
  
  However, when browsing the main page while not logged in, it does look wrong 
indeed. I have thus added a 16px top margin to the main page hero image 
container for logged-out users of the Minerva skin only.
  
  >> Btw. I am not aware of any design guidelines. Is such a document available 
somewhere?
  >
  > VERY long story short: The Wikimedia design system (Codex) – to some degree 
based on the Wikimedia Design Style Guide 
 – is in the making 
by MWF (I'm a contributor to their team). All new styles (encoded as design 
tokens) are available on the Codex Demo site 
. The 
missing font styles will be published soon and are for now documented in Figma 
.
  
  Thanks, interesting. Will keep an eye on it!

TASK DETAIL
  https://phabricator.wikimedia.org/T321571

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE, MisterSynergy
Cc: Mohammed_Sadat_WMDE, MisterSynergy, Sarai-WMDE, Lydia_Pintscher, 
Arian_Bozorg, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323763: Recreate browser tests for detecting edit conflicts after form resubmission

2022-11-24 Thread gerritbot
gerritbot added a comment.


  Change 813642 **abandoned** by Michael Große:
  
  [mediawiki/extensions/EntitySchema@master] Reenable browser test to check for 
edit conflicts
  
  Reason:
  
  This did not work out. But what was tried here might be useful in the future. 
Further work will be tracked in T323763
  
  https://gerrit.wikimedia.org/r/813642

TASK DETAIL
  https://phabricator.wikimedia.org/T323763

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Michael, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, SCIdude, Akuckartz, Hook696, 
Kent7301, pdehaye, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Andrawaag, GoranSMilovanovic, QZanden, 
YULdigitalpreservation, LawExplorer, Salgo60, Lewizho99, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323763: Recreate browser tests for detecting edit conflicts after form resubmission

2022-11-24 Thread gerritbot
gerritbot added a comment.


  Change 813642 had a related patch set uploaded (by Michael Große; author: 
Michael Große):
  
  [mediawiki/extensions/EntitySchema@master] Reenable browser test to check for 
edit conflicts
  
  https://gerrit.wikimedia.org/r/813642

TASK DETAIL
  https://phabricator.wikimedia.org/T323763

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Michael, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, SCIdude, Akuckartz, Hook696, 
Kent7301, pdehaye, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Andrawaag, GoranSMilovanovic, QZanden, 
YULdigitalpreservation, LawExplorer, Salgo60, Lewizho99, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323763: Recreate browser tests for detecting edit conflicts after form resubmission

2022-11-24 Thread gerritbot
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T323763

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Michael, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, SCIdude, Akuckartz, Hook696, 
Kent7301, pdehaye, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Andrawaag, GoranSMilovanovic, QZanden, 
YULdigitalpreservation, LawExplorer, Salgo60, Lewizho99, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323763: Recreate browser tests for detecting edit conflicts after form resubmission

2022-11-24 Thread gerritbot
gerritbot added a comment.


  Change 859503 had a related patch set uploaded (by Michael Große; author: 
Zfilipin):
  
  [mediawiki/extensions/EntitySchema@master] selenium: Delete tests disabled 
for more than 1 year
  
  https://gerrit.wikimedia.org/r/859503

TASK DETAIL
  https://phabricator.wikimedia.org/T323763

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Michael, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, SCIdude, Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, 
GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, 
_jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323763: Recreate browser tests for detecting edit conflicts after form resubmission

2022-11-24 Thread Michael
Michael created this task.
Michael added projects: Shape Expressions, Wikidata, wmde-wikidata-tech.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  We used to have browser tests that assert that an edit conflict is detected 
if the same form is submitted twice. However, for some reasons they did not 
work in CI, and so they were skipped a long time ago. Quick attempts to fix the 
underlying problem were not successful (see Reenable browser test to check for 
edit conflicts (I4df0ff86) 
).
  
  So, those tests were effectively dead code for a long time and thus deleted: 
selenium: Delete tests disabled for more than 1 year (I9507e539) 

  
  However, we may still wish to verify that behavior.
  
  **Acceptance criteria:**
  
  [ ] there exists a test that asserts that the edit schema form detects an 
edit conflict when re-submitting the same form
  [ ] there exists a test that asserts that the 
SetEntitySchemaLabelDescriptionAliasesPage detects an edit conflict when 
re-submitting the same form

TASK DETAIL
  https://phabricator.wikimedia.org/T323763

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, SCIdude, Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, 
GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, 
_jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T321571: Design request for new main page header image:

2022-11-24 Thread Sarai-WMDE
Sarai-WMDE attached a referenced file: F35817343: Group 16 (1).png.

TASK DETAIL
  https://phabricator.wikimedia.org/T321571

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Mohammed_Sadat_WMDE, MisterSynergy, Sarai-WMDE, Lydia_Pintscher, 
Arian_Bozorg, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T321571: Design request for new main page header image:

2022-11-24 Thread Sarai-WMDE
Sarai-WMDE added a comment.


  Thanks @MisterSynergy for the amazingly fast changes! 
  
  > What's missing:
  >
  > - The background image ("hero") seems to scale okay-ish on desktop now, but 
there is some CSS definition in the mobile skin (as much as I am aware) which 
makes it scale down in a poor way on mobile. Not sure how to fix this, to be 
honest.
  
  If not sure what the proper fix would be either, but strangely enough, just 
disabling the `auto` height applied to the image (which I guess is enforcing 
the original size and keeping the aspect ratio) seems to do the trick? I'm not 
sure if the level of specificity here might be problematic, but I don't see any 
other images affected by this change.
  
  F35817281: Nov-24-2022 12-00-53.gif 

  
  > - The "want to help translate?" stuff is now inside the overlay; changing 
the text is not that simple, since it is defined in a translatable template 
 and all 
translations would need to be updated as well. Let's leave it as is for now.
  
  Thanks again so much for this. Makes complete sense to leave as is.
  
  > - The light gray background is now `#f8f9fae6` as suggested, but is looks 
pretty pale on my display. I personally would make it a bit darker.
  
  It's of course quite light in comparison to the previous version. Do you 
think the legibility of the content is compromised? (e.g. poor contrast, 
overlapping with image elements on the background). I like how we're now using 
the same color applied to the main navigation menu (just with some opacity to 
avoid disrupting the image): makes the page look quite balanced. But this is, 
of course, quite subjective.
  
  > - The `16px margin` on desktop are defined in `.mw-body-content` as much as 
I am aware. Since this looks like a skin definition, I have left it as is on 
both desktop and mobile.
  
  If we fix the height of the image on mobile, this might stop being an issue. 
The main problem at the moment is that the headerbox "touches" the page header. 
There should be some spacing between the elements.
  
  Applying a rough margin bottom to the banner-container div in Minerva creates 
the right spacing:
  
  F35817332: Screenshot 2022-11-24 at 12.38.42.png 

  
  > Btw. I am not aware of any design guidelines. Is such a document available 
somewhere?
  
  VERY long story short: The Wikimedia design system (Codex) – to some degree 
based on the Wikimedia Design Style Guide 
 – is in the making 
by MWF (I'm a contributor to their team). All new styles (encoded as design 
tokens) are available on the Codex Demo site 
. The 
missing font styles will be published soon and are for now documented in Figma 
.

TASK DETAIL
  https://phabricator.wikimedia.org/T321571

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Mohammed_Sadat_WMDE, MisterSynergy, Sarai-WMDE, Lydia_Pintscher, 
Arian_Bozorg, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T273923: Wikidata terms of use not linked in German

2022-11-24 Thread Michael
Michael closed this task as "Resolved".
Michael claimed this task.
Michael added a comment.
Restricted Application added a project: User-Michael.


  Not sure what was going on here, but right now the text on 
https://www.wikidata.org/wiki/Special:NewEntitySchema?uselang=de correctly 
links to https://foundation.wikimedia.org/wiki/Terms_of_Use.
  
  So I assume that this issue has been fixed in the meantime, whatever it was, 
and I am closing this task. Please reopen it if the issue still exists for you.

TASK DETAIL
  https://phabricator.wikimedia.org/T273923

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, CennoxX, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, SCIdude, Akuckartz, pdehaye, Nandana, Lahi, Gq86, 
Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, 
Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323460: WDCM update missing

2022-11-24 Thread GoranSMilovanovic
GoranSMilovanovic added a comment.


  @MisterSynergy @Manuel @WMDE-leszek @ItamarWMDE
  
  I have checked the WDCM dashboards today (November 24, 2022) and the latest 
update timestamp reported was
  
  `Last update: 2022-11-21 11:29:50 UTC`
  
  That means that the previous update (the missing one, reported in this 
ticket) most probably failed for reasons such as high demand of our 
computational (cluster) resources, or something similar. That can happen, and 
it already happened in the past - but it happens quite rarely. The WMF has a 
very nice tech infrastructure but again limited given the number of tasks that 
it has to carry out and systems that rely on it.

TASK DETAIL
  https://phabricator.wikimedia.org/T323460

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: GoranSMilovanovic
Cc: WMDE-leszek, Manuel, ItamarWMDE, GoranSMilovanovic, Aklapper, 
MisterSynergy, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, 
Nandana, Lahi, Gq86, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T321571: Design request for new main page header image:

2022-11-24 Thread Sarai-WMDE
Sarai-WMDE attached a referenced file: F35816213: Group 16.png.

TASK DETAIL
  https://phabricator.wikimedia.org/T321571

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Mohammed_Sadat_WMDE, MisterSynergy, Sarai-WMDE, Lydia_Pintscher, 
Arian_Bozorg, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T247027: Add a « Gregorian mean year » ( Q87193822 ) unit to the Wikidata conversion table to normalize values that uses this unit

2022-11-24 Thread Lydia_Pintscher
Lydia_Pintscher closed this task as "Resolved".
Lydia_Pintscher claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T247027

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lucas_Werkmeister_WMDE, Toni_001, Jc3s5h, Ladsgroup, Aklapper, 
Liuxinyu970226, Lydia_Pintscher, Lea_Lacroix_WMDE, TomT0m, Astuthiodit_1, 
AWesterinen, karapayneWMDE, Invadibot, MPhamWMF, maantietaja, CBogen, 
ItamarWMDE, Akuckartz, Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, 
QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, 
Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T323734: Move language-specific logos from Commons.css to logos.php at wikidatawiki

2022-11-24 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata.org.

TASK DETAIL
  https://phabricator.wikimedia.org/T323734

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stang, Lydia_Pintscher
Cc: Aftabuzzaman, Aklapper, Stang, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, Yodas_henchman, 786, NguoiDungKhongDinhDanh, Biggs657, 
karapayneWMDE, Invadibot, Zabe, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, AKA_MBG, Kent7301, Dibya, 
joker88john, 94rain, CucyNoiD, Nandana, Tks4Fish, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, 
QZanden, Kizule, LawExplorer, Lewizho99, Maathavan, Devwaker, Niklitov, 
_jensen, Urbanecm, rosalieper, Neuronton, JEumerus, Scott_WUaS, Ananthsubray, 
Superzerocool, Stanglavine, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, 
Wikidata-bugs, Snowolf, Base, aude, Dcljr, Isarra, Matanya, Mbch331, Jay8g, 
Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org