[Wikidata-bugs] [Maniphest] [Commented On] T66315: Move "Data item" link outside of sidebar toolbox
Lejonel added a comment. In T66315#5402390 <https://phabricator.wikimedia.org/T66315#5402390>, @Lea_Lacroix_WMDE wrote: > I got an interesting question <https://sv.wikipedia.org/wiki/Wikipedia:Bybrunnen#%E2%80%9CWikidata_item%E2%80%9D_link_to_be_moved_in_the_menu_column>: "will the keyboard shortcut (ALT+SHIFT+G) still work after the move?" -> I didn't know about this shortcut, it's awesome :') Anyway, we should make sure it doesn't break in the process. This is now broken. In T66315#5408950 <https://phabricator.wikimedia.org/T66315#5408950>, @alaa_wmde wrote: > We will most likely add an id to uniquely identify that link. I think you need to add an id to not break the shortcut. And the i18n files <https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/client/i18n/en.json$14> needs to be updated so the message "accesskey-t-wikibase" matches the new id. TASK DETAIL https://phabricator.wikimedia.org/T66315 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Lejonel Cc: Janbery, Znotch190711, Lejonel, Ladsgroup, stjn, alaa_wmde, Lea_Lacroix_WMDE, noarave, Soluvo, Addshore, TerraCodes, Izno, Aklapper, Nemo_bis, Ricordisamoa, MZMcBride, Quiddity, Lydia_Pintscher, darthmon_wmde, Viztor, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, Jonas, Johan, Luke081515, Wikidata-bugs, aude, TheDJ, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T66315: Move "Data item" link outside of sidebar toolbox
Lejonel added a comment. It looks like this change removes id "t-wikibase" without adding any other id. Does that not break the accesskey and tooltip in messages "accesskey-t-wikibase" and "tooltip-t-wikibase" in the i18n files? TASK DETAIL https://phabricator.wikimedia.org/T66315 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Lejonel Cc: Lejonel, Ladsgroup, stjn, alaa_wmde, Lea_Lacroix_WMDE, noarave, Soluvo, Addshore, TerraCodes, Izno, Aklapper, Nemo_bis, Ricordisamoa, MZMcBride, Quiddity, Lydia_Pintscher, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, Viztor, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Jonas, Johan, Luke081515, Wikidata-bugs, aude, TheDJ, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
