[Wikidata-bugs] [Maniphest] [Updated] T179247: Facilitate feedback and editor interaction about corresponding articles in different languages and projects
Mattflaschen-WMF added a project: Epic. TASK DETAILhttps://phabricator.wikimedia.org/T179247EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Trizek-WMF, Pginer-WMF, Petar.petkovic, Ebraminio, jmatazzoni, Nemo_bis, Amire80, Lester, Aklapper, Lahi, Gq86, GoranSMilovanovic, 45Jayjay1969, chapulina, QZanden, EnricoCNC, LawExplorer, Nizil, Ixocactus, SBisson, Wong128hk, Luke081515, Wikidata-bugs, aude, Gryllida, jeblad, Catrope, Jsahleen, Nikerabbit, Arrbee, santhosh, KartikMistry, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T177707: don't dispatch changes to all affected pages for highly used items
Mattflaschen-WMF added a comment. Note that this means there may be a specifically-relevant change to a watched page (if you're not watching the directly-linked page for the entity) that affects that page's rendering, but doesn't show on your Watchlist. This is probably already intended to be temporary, and I understand it's a necessary performance workaround, but I think this should be flagged to be updated later. It's probably fine for Special:RecentChanges.TASK DETAILhttps://phabricator.wikimedia.org/T177707EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, Strainu, TerraCodes, Jay8g, Liuxinyu970226, jcrespo, Bawolff, Aklapper, hoo, daniel, Ladsgroup, Lydia_Pintscher, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T176515: More flexible user experience for monitoring Wikidata changes from client, using new filters
Mattflaschen-WMF added a comment. In T176515#3644935, @eranroz wrote: I think one edit in Wikidata can change both description, label and sitelink (at least the API expose edit entity), so assuming it is one to many connection, I would stick to tag_summary. To solve that, we could evaluate splitting one repository edit (which affected e.g. all of those) into multiple separate client edits (each with only one rc_source, e.g. one for wb.description, one for wb.sitelinks, etc.). However we implement this, we should evaluate the performance implications so it doesn't worsen T171027 .TASK DETAILhttps://phabricator.wikimedia.org/T176515EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Noella94, hoo, Trizek-WMF, Lea_Lacroix_WMDE, Elitre, RP88, Catrope, SBisson, Mattflaschen-WMF, Aklapper, eranroz, GoranSMilovanovic, QZanden, Iniquity, jmatazzoni, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T90436: Improve usage tracking granularity to avoid irrelevant changes showing in the watchlist.
Mattflaschen-WMF added a comment. Yeah, there are 3 aspects: Performance - Avoiding unnecessary RC rows. - This task Sane defaults - If a change doesn't affect the Wikipedia page in any way (neither the rendered output, nor the site links), it shouldn't be displayed to the user. - This task Additional user-controlled filtering (e.g. although site links are always relevant and should be available in Wikipedia RC, people may not always want to see them) - T176515: More flexible user experience for monitoring Wikidata changes from client, using new filters 1 and 2 are separate goals, but very related. 3 is different.TASK DETAILhttps://phabricator.wikimedia.org/T90436EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, jmatazzoni, Raymond, FriedhelmW, AndrewSu, Capankajsmilyo, Fuzheado, Bawolff, Tbayer, jeremyb, Agabi10, RP88, Halfak, Doc_James, hoo, PokestarFan, IKhitron, eranroz, Izno, Oliv0, Ltrlg, Scott_WUaS, Danmichaelo, CennoxX, Liuxinyu970226, aude, Lydia_Pintscher, daniel, Aklapper, GoranSMilovanovic, Rafisamra2016, QZanden, Tal-WMIL, Avner, Tzafrir, Wikidata-bugs, Amire80, Matanya, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T176515: More flexible user experience for monitoring Wikidata changes from client, using new filters
Mattflaschen-WMF added a comment. Perhaps this could be implemented by adding more rc_source possibilities (e.g. 'wb.description', 'wb.sitelinks'). However, this may have implications for T171027: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis. We would need backwards compatibility, but the recentchanges table only lasts 30 days (configurable) anyway, so this is very temporary.TASK DETAILhttps://phabricator.wikimedia.org/T176515EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Catrope, SBisson, Mattflaschen-WMF, Aklapper, eranroz, GoranSMilovanovic, QZanden, Iniquity, jmatazzoni, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T176515: More flexible user experience for monitoring Wikidata changes from client, using new filters
Mattflaschen-WMF renamed this task from "Monitoring Wikidata changes from client using new filters" to "More flexible user experience for monitoring Wikidata changes from client, using new filters". TASK DETAILhttps://phabricator.wikimedia.org/T176515EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Catrope, SBisson, Mattflaschen-WMF, Aklapper, eranroz, GoranSMilovanovic, QZanden, Iniquity, jmatazzoni, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T171027: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis
Mattflaschen-WMF added a comment. In T171027#3628964, @Bawolff wrote: They're not fully redundant, since rc_type for Wikidata is RC_EXTERNAL (from core, thus not Wikidata-specific). Afaict only wikidata uses it. That's true (at least for WMF), but as long as it's RC_EXTERNAL in core (not even documented to be Wikidata-y), not (hypothetically) RC_WIKIBASE_TYPE in Wikibase, we can't rely on that. So AFAICT, it's best to move everything here to use rc_source. The IN would at best be a range condition (although im not sure mariadb would see it that way because it cant tell its a contiguous range). Usually the range has to be the rightmost part of the index we're using, so i dont think that would work, as the idea is to segregate the table by putting the wikidata stuff by putting that at the leftmost part of the index. (It could maybe do index merge or we could manually UNION, but it seems like mariadb doesnt usually choose that path, and im not sure thats really ideal given how many rows the query already has to look at). We could have a (rc_source) index (there is already (rc_timestamp)). Or perhaps both (rc_source) and (rc_source, rc_timestamp). I'm not sure if this is a workable approach (I guess it would require an index merge either way); it's just something to consider.TASK DETAILhttps://phabricator.wikimedia.org/T171027EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: matej_suchanek, Ankry, Ladsgroup, Lsanabria, Josve05a, Bawolff, greg, Dominicbm, Vriullop, Jmabel, Fae, IKhitron, Johan, Herzi.Pinki, jmatazzoni, Trizek-WMF, Mattflaschen-WMF, KTC, Framawiki, zhuyifei1999, Marostegui, aaron, Andrei_Stroe, Turbojet, Rsocol, Strainu, Jwh, Pyb, Darwinius, Arbnos, Jdforrester-WMF, TheDJ, gerritbot, VladXe, Kf8, Liuxinyu970226, Jay8g, TerraCodes, Iniquity, jcrespo, Reedy, Catrope, Vicpeters, Demidenko, MaxBioHazard, Aklapper, Waytogoeducation, GoranSMilovanovic, Abiyoyo, QZanden, Vali.matei, Jack_who_built_the_house, Minhnv-2809, Poyekhali, Volker_E, Izno, Wong128hk, Luke081515, Wikidata-bugs, Base, aude, GWicke, El_Grafo, Gryllida, putnik, Steinsplitter, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T171027: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis
Mattflaschen-WMF added a parent task: T91192: Show new versions of files (and possibly separately description changes) made on WikimediaCommons on the Watchlist. TASK DETAILhttps://phabricator.wikimedia.org/T171027EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: matej_suchanek, Ankry, Ladsgroup, Lsanabria, Josve05a, Bawolff, greg, Dominicbm, Vriullop, Jmabel, Fae, IKhitron, Johan, Herzi.Pinki, jmatazzoni, Trizek-WMF, Mattflaschen-WMF, KTC, Framawiki, zhuyifei1999, Marostegui, aaron, Andrei_Stroe, Turbojet, Rsocol, Strainu, Jwh, Pyb, Darwinius, Arbnos, Jdforrester-WMF, TheDJ, gerritbot, VladXe, Kf8, Liuxinyu970226, Jay8g, TerraCodes, Iniquity, jcrespo, Reedy, Catrope, Vicpeters, Demidenko, MaxBioHazard, Aklapper, Waytogoeducation, GoranSMilovanovic, Abiyoyo, QZanden, Vali.matei, Jack_who_built_the_house, Minhnv-2809, Poyekhali, Volker_E, Izno, Wong128hk, Luke081515, Wikidata-bugs, Base, aude, GWicke, El_Grafo, Gryllida, putnik, Steinsplitter, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T171027: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis
Mattflaschen-WMF added a comment.
Adding rc_type or rc_source (which one? these two fields seem largely redundant with each other) to the start of some indexes, so that queries that don't need to look at Wikidata rows can filter them out efficiently
They're not fully redundant, since rc_type for Wikidata is RC_EXTERNAL (from core, thus not Wikidata-specific).
@Catrope and I discussed, and think any new indexes for this purpose should have rc_source.
We should also look into @Catrope's idea of using IN here (but rc_source IN). If this allows using the index effectively, we'd need to add a hook to know about all the rc_source's. Then PHP can convert "not Wikibase" to rc_source IN ('source1', 'source2', 'source3').
Related question, will having multiple such IN clauses (e.g. rc_source IN ('mw.log', 'mw.edit', 'flow') AND rc_source IN ('mw.log', 'mw.edit', 'mw.new' )) affect performance? The EXPLAIN is the same as if they are combined.TASK DETAILhttps://phabricator.wikimedia.org/T171027EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Ankry, Ladsgroup, Lsanabria, Josve05a, Bawolff, greg, Dominicbm, Vriullop, Jmabel, Fae, IKhitron, Johan, Herzi.Pinki, jmatazzoni, Trizek-WMF, Mattflaschen-WMF, KTC, Framawiki, zhuyifei1999, Marostegui, aaron, Andrei_Stroe, Turbojet, Rsocol, Strainu, Jwh, Pyb, Darwinius, Arbnos, Jdforrester-WMF, TheDJ, gerritbot, VladXe, Kf8, Liuxinyu970226, Jay8g, TerraCodes, Iniquity, jcrespo, Reedy, Catrope, Vicpeters, Demidenko, MaxBioHazard, Aklapper, Waytogoeducation, GoranSMilovanovic, Abiyoyo, QZanden, Vali.matei, Jack_who_built_the_house, Minhnv-2809, Poyekhali, Volker_E, Izno, Wong128hk, Luke081515, Wikidata-bugs, Base, aude, GWicke, El_Grafo, Gryllida, putnik, Steinsplitter, Mbch331, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T90436: Improve usage tracking granularity to avoid irrelevant changes showing in the watchlist.
Mattflaschen-WMF added a subscriber: jmatazzoni.Mattflaschen-WMF added a project: MediaWiki-Watchlist. TASK DETAILhttps://phabricator.wikimedia.org/T90436EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: jmatazzoni, Raymond, FriedhelmW, AndrewSu, Capankajsmilyo, Fuzheado, Bawolff, Tbayer, jeremyb, Agabi10, RP88, Halfak, Doc_James, hoo, PokestarFan, IKhitron, eranroz, Izno, Oliv0, Ltrlg, Scott_WUaS, Danmichaelo, CennoxX, Liuxinyu970226, aude, Lydia_Pintscher, daniel, Aklapper, GoranSMilovanovic, Rafisamra2016, QZanden, Tal-WMIL, Avner, Tzafrir, Wikidata-bugs, Amire80, Matanya, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T172832: Investigate use-cases for delayed job executions
Mattflaschen-WMF added a comment.
In T172832#3559604, @GWicke wrote:
@Mattflaschen-WMF, thank you for the background on echo! Regarding use case #2, can this be fairly summarized as "wait for a limited time before sending out notifications, in order to reduce the volume with batching"?
I was quoting "Batching & rate limiting for Echo notifications" from the notes you posted above. The original Etherpad notes say "Batching & rate limiting for Echo notifications (might actually just have been a patch, not merged)", and I don't know what that was originally referring to.
ProcessEchoEmailBatch implements optional email batching for user experience (i.e. so emails you get from Echo don't feel spammy). This implements the preference at https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-echo ("Send me:"). Choices are:
Individual notifications as they come in
A daily summary of notifications
A weekly summary of notifications
As mentioned, we use a maintenance script and OS cron job, which seems to work fine.TASK DETAILhttps://phabricator.wikimedia.org/T172832EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pchelolo, Mattflaschen-WMFCc: MaxSem, MarkTraceur, ggellerman, dr0ptp4kt, TrevorParscal, phuedx, Fjalapeno, Mattflaschen-WMF, daniel, PokestarFan, hoo, Aklapper, Joe, elukey, Ottomata, Nuria, mobrovac, GWicke, Pchelolo, GoranSMilovanovic, QZanden, Izno, Eevans, JAllemandou, Hardikj, Wikidata-bugs, aude, Mbch331, Jay8g, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T173850: Possible WMF deployed extension PHP 7 issues
Mattflaschen-WMF removed projects: Flow, Collaboration-Team-Triage.Mattflaschen-WMF added a comment.
Thanks for running this check. Flow looks good.
File: /home/reedy/git/mediawiki/core/extensions/Flow/includes/Data/Storage/RevisionStorage.php
> Line 324: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($source as &$row) {
}
I reviewed php7_foreach and the above looks fine.
It is not doing anything edge-casey on either of the arrays being iterated ($cacheResult and $source) (no additions or removals to these arrays, no replacements of the whole array).
File: /home/reedy/git/mediawiki/core/extensions/Flow/includes/Import/LiquidThreadsApi/Source.php
> Line 195: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
Turns out they're not.
File: /home/reedy/git/mediawiki/core/extensions/Flow/includes/Repository/TreeRepository.php
> Line 365: [Warning] Possible array element creation during by-reference assignment
$identityMap[$parent->getAlphadecimal()]['children'][$child] =& $identityMap[$child];
This line is a bit tricky.
However, $identityMap[$child] is certainly created before this line, so there's no way two new keys of $identityMap itself are created in this line (and thus no ordering issue between these two).TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, Liuxinyu970226, WMDE-leszek, Anomie, Aklapper, Jdforrester-WMF, Addshore, Krinkle, MaxSem, Krenair, Reedy, Minilexikon, Timoavax79, GoranSMilovanovic, TheDragonFire, Maosef, QZanden, EBjune, Orienteerix, Litanwei, Avner, Ddproxy, debt, TerraCodes, SundanceRaphael, Reasno, Gehel, Debenben, Jseddon, JGirault, gabriel-wmde, phabyogi, FloNight, DStrine, Dixtosa, GAllegre, Susannaanas, XenoRyet, Thibaut120094, Izno, Matiia, ferdbold, lxbarth, Wong128hk, Luke081515, Nirmos, Planemad, Wikidata-bugs, Snowolf, Prod, Hydriz, aude, fredw, SPQRobin, AndyRussG, Ebe123, Pcoombe, Huji, Physikerwelt, Pkra, Dinoguy1000, jeblad, jayvdb, Ricordisamoa, MrStradivarius, Lydia_Pintscher, Yurik, Darkdadaah, Arrbee, scfc, KartikMistry, Se4598, Jackmcbarn, Mbch331, Jay8g, Ltrlg, Joe, jeremyb, Legoktm, Tgr___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T173850: Possible WMF deployed extension PHP 7 issues
Mattflaschen-WMF added a project: Flow.Herald added a project: Collaboration-Team-Triage. TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, Liuxinyu970226, WMDE-leszek, Anomie, Aklapper, Jdforrester-WMF, Addshore, Krinkle, MaxSem, Krenair, Reedy, Minilexikon, Timoavax79, GoranSMilovanovic, TheDragonFire, Maosef, 45Jayjay1969, QZanden, EBjune, Orienteerix, EnricoCNC, Litanwei, Avner, Ddproxy, debt, TerraCodes, SundanceRaphael, Reasno, Gehel, Debenben, Jseddon, JGirault, gabriel-wmde, phabyogi, FloNight, DStrine, Dixtosa, Trizek-WMF, GAllegre, Susannaanas, XenoRyet, Thibaut120094, Izno, SBisson, Matiia, ferdbold, lxbarth, Wong128hk, Luke081515, Nirmos, Planemad, Wikidata-bugs, Snowolf, Prod, Hydriz, aude, fredw, SPQRobin, AndyRussG, Ebe123, Pcoombe, Huji, Physikerwelt, Pkra, Dinoguy1000, Gryllida, jeblad, jayvdb, Ricordisamoa, MrStradivarius, Catrope, Lydia_Pintscher, Yurik, Darkdadaah, Arrbee, scfc, KartikMistry, Se4598, Jackmcbarn, Mbch331, Jay8g, Ltrlg, Joe, jeremyb, Legoktm, Tgr___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T123213: User i18n@wikidata getting 503 when viewing filtered watchlist
Mattflaschen-WMF added a comment. Do you get a long code inside brackets ([]) (likely next to "Fatal exception of type"? If so, please post that whole line, including the code.TASK DETAILhttps://phabricator.wikimedia.org/T123213EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, TTO, I18n, Aklapper, Reedy, StudiesWorld, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172832: Investigate use-cases for delayed job executions
Mattflaschen-WMF added a comment. There are three considerations relevant to Echo: Delayed notifications (T156808: Back-end infrastructure for timed notifications in Echo) 1a. Article reminder notifications (T2582: Remind me of this article in X days) 1b. User group expiry notifications (T153817: Notify users when their user group membership is about to expire, or has expired) "Batching & rate limiting for Echo notifications". There is a in-progress patch for T156808 (https://gerrit.wikimedia.org/r/#/c/370502/). This is being developed for T2582, but it's general infrastructure meant to work for all use cases, including T153817 (which I specifically considered). The current patch for T156808: Back-end infrastructure for timed notifications in Echo does not use Jobs in the sense of JobQueue (it has a maintenance script, and if this is merged, it will use OS cron). However, the patch for T153817: Notify users when their user group membership is about to expire, or has expired does use getReleaseTimestamp. However, I've asked them to build it on top of our infrastructure instead (I think they're waiting until it's merged). So that leaves #2. I think this is a reference to ProcessEchoEmailBatch. We currently use a OS cron job for that. If there's another use case you're thinking of, please let us know. (I also checked the existing Echo jobs, and they do not use getReleaseTimestamp/jobReleaseTimestamp)TASK DETAILhttps://phabricator.wikimedia.org/T172832EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pchelolo, Mattflaschen-WMFCc: Mattflaschen-WMF, daniel, PokestarFan, hoo, Aklapper, Joe, elukey, Ottomata, Nuria, mobrovac, GWicke, Pchelolo, GoranSMilovanovic, QZanden, Izno, Eevans, JAllemandou, Hardikj, Wikidata-bugs, aude, Mbch331, Jay8g, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T169181: Edits to Flow are marked as Wikidata edits in enhanced RC
Mattflaschen-WMF added a comment. The original task can be reproduced with a new Flow topic with two posts (the topic and all the posts should be on the same day, and can be the same user).TASK DETAILhttps://phabricator.wikimedia.org/T169181EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, Mattflaschen-WMFCc: Lydia_Pintscher, Stashbot, Etonkovidova, Mattflaschen-WMF, Catrope, gerritbot, matej_suchanek, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, 45Jayjay1969, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EnricoCNC, Lewizho99, Maathavan, Trizek-WMF, Izno, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T158025: Support ORES for propagated Wikidata edits
Mattflaschen-WMF updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...However, it could (apparently schema changes are required though). It would be useful for the normal reasons ORES and the propagation feature itself are useful (track vandalism, good-faith, etc. to Wikidata content related to the current wiki)TASK DETAILhttps://phabricator.wikimedia.org/T158025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Catrope, jmatazzoni, Aklapper, Mattflaschen-WMF, bkowshik, GoranSMilovanovic, QZanden, Avner, Iniquity, Izno, SBisson, Wikidata-bugs, aude, He7d3r, Ladsgroup, Mbch331, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T158025: Support ORES for propagated Wikidata edits
Mattflaschen-WMF updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...However, it can (the diff ID is already available on the client-side) and should (it's useful to ould (apparently schema changes are required though). It would be useful for the normal reasons ORES and the propagation feature itself are useful (track vandalism, good-faith, etc.)TASK DETAILhttps://phabricator.wikimedia.org/T158025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Catrope, jmatazzoni, Aklapper, Mattflaschen-WMF, bkowshik, GoranSMilovanovic, QZanden, Avner, Iniquity, Izno, SBisson, Wikidata-bugs, aude, He7d3r, Ladsgroup, Mbch331, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T158025: Support ORES for propagated Wikidata edits
Mattflaschen-WMF added a comment. @jmatazzoni There's nothing inherently blocking it, but if this is (potentially) a priority, we should have an architecture discussion. The best solution is not obvious, though @Catrope's approach is worth considering.TASK DETAILhttps://phabricator.wikimedia.org/T158025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Catrope, jmatazzoni, Aklapper, Mattflaschen-WMF, bkowshik, GoranSMilovanovic, QZanden, Avner, Iniquity, Izno, SBisson, Wikidata-bugs, aude, He7d3r, Ladsgroup, Mbch331, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T169181: Edits to Flow are marked as Wikidata edits in enhanced RC
Mattflaschen-WMF edited projects, added Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017); removed Collaboration-Team-Triage.Mattflaschen-WMF added a comment. In T169181#3406220, @matej_suchanek wrote: Please review ^^. Thank you for the fix.TASK DETAILhttps://phabricator.wikimedia.org/T169181EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, Mattflaschen-WMFCc: Mattflaschen-WMF, Catrope, gerritbot, matej_suchanek, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, 45Jayjay1969, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EnricoCNC, Lewizho99, Maathavan, Trizek-WMF, Izno, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T169598: Beta Cluster Wikidata Build is (a week) older than production
Mattflaschen-WMF created this task.Mattflaschen-WMF added a project: Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTIONThe Wikidata Build on the Beta Cluster is older than on production. It should be newer, so code can be tested there before making it production. Currently: English Wikipedia Beta Cluster - 0.1 (bd064c8) 10:00, 19 June 2017 MediaWiki.org 0.1 (f27abea) 13:49, June 27, 2017 As a result (for example), the Beta Cluster still hides the Wikidata filter when you use enhanced (grouped) recent changes, but production does not.TASK DETAILhttps://phabricator.wikimedia.org/T169598EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Aklapper, Mattflaschen-WMF, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T169108: Wikidata items are always visible in Recent Changes, filtered or not
Mattflaschen-WMF added a comment. In T169108#3395016, @Lea_Lacroix_WMDE wrote: Discussion on fr.wp that could be related to this problem (poke @Trizek-WMF ) https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Le_Bistro/30_juin_2017#Gestion_de_la_liste_de_suivi Per Google Translate, that seems to be unrelated. They apparently were seeing unexpected results on the watchlist, but apparently just had the wrong checkbox checked (there are two in Special:Preferences, one for RC and one for Watchlist).TASK DETAILhttps://phabricator.wikimedia.org/T169108EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: matej_suchanek, Lydia_Pintscher, Lea_Lacroix_WMDE, Mattflaschen-WMF, Trizek-WMF, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T169108: Wikidata items are always visible in Recent Changes, filtered or not
Mattflaschen-WMF added a comment. We discussed this in detail as a team. For the specific issue, I suspect that a setup with "Show Wikidata" (and showing all types of of change) somehow ended up as your default saved filter. If you have no default saved filter, the new UI still respects these preferences. Those preferences are ignored (but still displayed in preferences) if you're using the beta feature and there is a default saved filter; I think this is the current situation. So I recommend: Configure RecentChanges as you want the default to be. To hide Wikidata, check all the boxes in that group you want to see (unchecking Wikidata). Save a filter. Go to Saved filters, ... next to the filter you just saved, Set as default. TASK DETAILhttps://phabricator.wikimedia.org/T169108EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: matej_suchanek, Lydia_Pintscher, Lea_Lacroix_WMDE, Mattflaschen-WMF, Trizek-WMF, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T169108: Wikidata items are always visible in Recent Changes, filtered or not
Mattflaschen-WMF added a comment. It only has that one checkbox in Type of change? That URL ( https://fr.wikipedia.org/wiki/Sp%C3%A9cial:Modifications_r%C3%A9centes?urlversion=2&damaging=verylikelybad&hidepreviousrevisions=1 ) doesn't have any Type of change filters, so by default all types of change are shown. I also see a normal full Type of change group (not just one item).TASK DETAILhttps://phabricator.wikimedia.org/T169108EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, Trizek-WMF, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T168487: ORES: Don't highlight changes propagated from Wikidata
Mattflaschen-WMF updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONIt's unable to show the real score ({T158025}), so shouldn't highlight anything for changes propagated from Wikidata.
This should apply regardless of whether it's using the original ORES highlighting or the newer highlighting done by RC Page itself.TASK DETAILhttps://phabricator.wikimedia.org/T168487EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Aklapper, Mattflaschen-WMF, GoranSMilovanovic, QZanden, Iniquity, jmatazzoni, Izno, SBisson, Wikidata-bugs, aude, Catrope, Alchimista, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T168487: ORES: Don't highlight changes propagated from Wikidata
Mattflaschen-WMF updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONIt's unable to show the real score ({T158025}), so shouldn't highlight anything for changes propagated from Wikidata.
ThisThere should applybe no highlighting for these rows regardless of whether it's using the original ORES highlighting or the newer highlighting done by RC Page itself.TASK DETAILhttps://phabricator.wikimedia.org/T168487EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Aklapper, Mattflaschen-WMF, GoranSMilovanovic, QZanden, Iniquity, jmatazzoni, Izno, SBisson, Wikidata-bugs, aude, Catrope, Alchimista, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T168487: ORES: Don't highlight changes propagated from Wikidata
Mattflaschen-WMF added projects: Collaboration-Team-Triage, Edit-Review-Improvements-RC-Page. TASK DETAILhttps://phabricator.wikimedia.org/T168487EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Aklapper, Mattflaschen-WMF, GoranSMilovanovic, QZanden, Iniquity, jmatazzoni, Izno, SBisson, Wikidata-bugs, aude, Catrope, Alchimista, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T168487: ORES: Don't highlight changes propagated from Wikidata
Mattflaschen-WMF created this task.Mattflaschen-WMF added projects: ORES, Wikidata.Herald added a subscriber: Aklapper.Herald added a project: Scoring-platform-team-Backlog. TASK DESCRIPTIONIt's unable to show the real score (T158025: Support ORES for propagated Wikidata edits), so shouldn't highlight anything for changes propagated from WikidataTASK DETAILhttps://phabricator.wikimedia.org/T168487EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Aklapper, Mattflaschen-WMF, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Alchimista, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T167238: Fatal Error: "Tag hook for noexternallanglinks is not callable" (1.30.0-wmf.4/includes/parser/Parser.php)
Mattflaschen-WMF claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T167238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: TerraCodes, Aklapper, Krinkle, Jay8g, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Assigned] T46874: [Epic] Full support for wikibase edits in enhanced changes format ("Group changes by page in recent changes and watchlist" [usenewrc])
Mattflaschen-WMF assigned this task to matej_suchanek. TASK DETAILhttps://phabricator.wikimedia.org/T46874EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, Mattflaschen-WMFCc: gerritbot, Mattflaschen-WMF, Headbomb, matej_suchanek, Magioladitis, Andrei_Stroe, Strainu, JKatzWMF, Trizek-WMF, H4stings, nyuszika7h, Danmichaelo, Zppix, StudiesWorld, Kipod, Krenair, Soisyc_Croisic, vlsergey, Simon_Villeneuve, Aklapper, MGChecker, CennoxX, mxn, Ricordisamoa, Perhelion, Elitre, MisterSynergy, Conny, Reaper35, liangent, Jdforrester-WMF, Abraham, matmarex, Nemo_bis, Schnark, Tobi_WMDE_SW, He7d3r, aude, Liuxinyu970226, Tgr, Lydia_Pintscher, Ltrlg, Raymond, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T165064: Segmentation fault in mwext-testextension-hhvm-composer-jessie builds
Mattflaschen-WMF added a comment. I'm getting them as well: E.g. https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm-jessie/13126/console is mediawiki-extensions-hhvm-jessie, text is P5426TASK DETAILhttps://phabricator.wikimedia.org/T165064EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, Aklapper, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Jrbranaa, QZanden, Izno, thcipriani, Wikidata-bugs, aude, Mbch331, Jay8g, hashar___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164375: [Task] improve Wikidata Echo notification text
Mattflaschen-WMF added a comment. Or reverse it, and have the primary link go to Wikidata and a secondary link go to the local page. Nothing actually happened to the local page, so there's nothing to see there really.TASK DETAILhttps://phabricator.wikimedia.org/T164375EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, Catrope, matej_suchanek, Ladsgroup, Lea_Lacroix_WMDE, Lydia_Pintscher, thiemowmde, Aklapper, QZanden, MuhammadShuaib, Izno, SBisson, LNDDYL, Psychoslave, Luke081515, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T114474: More flexible and modernized Recent Changes code
Mattflaschen-WMF added a comment. Although the focus of rMWaa063f4c5a19: Back-end of new RecentChanges page, refactoring was the filter system, there was some overlap at the edges, regarding isRowApplicableCallable/applyCssClassIfNeeded (the latter affected the formatters).TASK DETAILhttps://phabricator.wikimedia.org/T114474EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aude, Mattflaschen-WMFCc: Mattflaschen-WMF, Ricordisamoa, RobLa-WMF, Izno, GWicke, Jdforrester-WMF, Krenair, Qgil, hoo, Addshore, daniel, aude, Aklapper, QZanden, Wikidata-bugs, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T58664: [Story] Clean up the code that formats Wikibase entries in recent changes
Mattflaschen-WMF added a comment. rEWBA30552f803ddd: Port Wikidata filter to new RCFilters system updated the structure and tests for this somewhat, in conjunction with rMWaa063f4c5a19: Back-end of new RecentChanges page, refactoringTASK DETAILhttps://phabricator.wikimedia.org/T58664EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, Ricordisamoa, Aklapper, Liuxinyu970226, Wikidata-bugs, Tobi_WMDE_SW, aude, Lydia_Pintscher, QZanden, Izno, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T46874: [Epic] Full support for wikibase edits in enhanced changes format ("Group changes by page in recent changes and watchlist" [usenewrc])
Mattflaschen-WMF added a comment. rMW78f109bfddd0: Generalize recentChangesFlags rollup lays part of the groundwork for this. It makes it easier for extensions to interact with the grouping code (which goes from individual lines to groups).TASK DETAILhttps://phabricator.wikimedia.org/T46874EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, Headbomb, matej_suchanek, Magioladitis, Andrei_Stroe, Strainu, JKatzWMF, Trizek-WMF, H4stings, nyuszika7h, Danmichaelo, Zppix, StudiesWorld, Kipod, Krenair, Soisyc_Croisic, vlsergey, Simon_Villeneuve, Aklapper, MGChecker, CennoxX, mxn, Ricordisamoa, Perhelion, Elitre, MisterSynergy, Conny, Reaper35, liangent, Jdforrester-WMF, Abraham, matmarex, Nemo_bis, Schnark, Tobi_WMDE_SW, He7d3r, aude, Liuxinyu970226, Tgr, Lydia_Pintscher, Ltrlg, Raymond, QZanden, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T46874: [Epic] Full support for wikibase edits in enhanced changes format ("Group changes by page in recent changes and watchlist" [usenewrc])
Mattflaschen-WMF edited the task description. (Show Details)
EDIT DETAILS...This requires a bit of refactoring and cleanup of spaghetti code in core, and then simplify / provide a more fine-grained way for extensions to hook into the core code that generates the recent changes lists in the special pages.
---
This should be easier now that {78f109bfddd0af19c910ad84f03a7b847fd00145} is in.TASK DETAILhttps://phabricator.wikimedia.org/T46874EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Headbomb, matej_suchanek, Magioladitis, Andrei_Stroe, Strainu, JKatzWMF, Trizek-WMF, H4stings, nyuszika7h, Danmichaelo, Zppix, StudiesWorld, Kipod, Krenair, Soisyc_Croisic, vlsergey, Simon_Villeneuve, Aklapper, MGChecker, CennoxX, mxn, Ricordisamoa, Perhelion, Elitre, MisterSynergy, Conny, Reaper35, liangent, Jdforrester-WMF, Abraham, matmarex, Nemo_bis, Schnark, Tobi_WMDE_SW, He7d3r, aude, Liuxinyu970226, Tgr, Lydia_Pintscher, Ltrlg, Raymond, QZanden, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T46874: [Epic] Full support for wikibase edits in enhanced changes format ("Group changes by page in recent changes and watchlist" [usenewrc])
Mattflaschen-WMF edited the task description. (Show Details)
EDIT DETAILS...This requires a bit of refactoring and cleanup of spaghetti code in core, and then simplify / provide a more fine-grained way for extensions to hook into the core code that generates the recent changes lists in the special pages.
This should be easier now that {78f109bfddd0af19c910ad84f03a7b847fd00145} is in.TASK DETAILhttps://phabricator.wikimedia.org/T46874EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Headbomb, matej_suchanek, Magioladitis, Andrei_Stroe, Strainu, JKatzWMF, Trizek-WMF, H4stings, nyuszika7h, Danmichaelo, Zppix, StudiesWorld, Kipod, Krenair, Soisyc_Croisic, vlsergey, Simon_Villeneuve, Aklapper, MGChecker, CennoxX, mxn, Ricordisamoa, Perhelion, Elitre, MisterSynergy, Conny, Reaper35, liangent, Jdforrester-WMF, Abraham, matmarex, Nemo_bis, Schnark, Tobi_WMDE_SW, He7d3r, aude, Liuxinyu970226, Tgr, Lydia_Pintscher, Ltrlg, Raymond, QZanden, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T51315: [Story] record wikibase recent change entries attributed as non-anon
Mattflaschen-WMF added projects: Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-RC-Page. TASK DETAILhttps://phabricator.wikimedia.org/T51315EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: jmatazzoni, Catrope, Etonkovidova, Mattflaschen-WMF, MGChecker, Merl, Ricordisamoa, Aklapper, Liuxinyu970226, Wikidata-bugs, Legoktm, Denny, aude, MZMcBride, Lydia_Pintscher, Raymond, QZanden, Iniquity, Izno, SBisson, Mbch331, tarlocesilion___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T51315: [Story] record wikibase recent change entries attributed as non-anon
Mattflaschen-WMF removed a parent task: T162628: 'Wikidata edits' filter does not recognize registered wikidata users . TASK DETAILhttps://phabricator.wikimedia.org/T51315EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: jmatazzoni, Catrope, Etonkovidova, Mattflaschen-WMF, MGChecker, Merl, Ricordisamoa, Aklapper, Liuxinyu970226, Wikidata-bugs, Legoktm, Denny, aude, MZMcBride, Lydia_Pintscher, Raymond, QZanden, Izno, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T159787: Add Wikidata to new RC Filters UI
Mattflaschen-WMF edited subtasks, added: T51315: [Story] record wikibase recent change entries attributed as non-anon; removed: T162628: 'Wikidata edits' filter does not recognize registered wikidata users . TASK DETAILhttps://phabricator.wikimedia.org/T159787EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Etonkovidova, Liuxinyu970226, Catrope, gerritbot, Aklapper, Mattflaschen-WMF, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Iniquity, jmatazzoni, Izno, SBisson, Wikidata-bugs, aude, Mbch331, tarlocesilion___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T51315: [Story] record wikibase recent change entries attributed as non-anon
Mattflaschen-WMF added a parent task: T159787: Add Wikidata to new RC Filters UI. TASK DETAILhttps://phabricator.wikimedia.org/T51315EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: jmatazzoni, Catrope, Etonkovidova, Mattflaschen-WMF, MGChecker, Merl, Ricordisamoa, Aklapper, Liuxinyu970226, Wikidata-bugs, Legoktm, Denny, aude, MZMcBride, Lydia_Pintscher, Raymond, QZanden, Izno, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T51315: [Story] record wikibase recent change entries attributed as non-anon
Mattflaschen-WMF edited the task description. (Show Details)
EDIT DETAILS...If central auth is not available (e.g. on third-party wikis), then it would be good to have another identifier for rc_id for "external" users, like -1. Or figure out another way to better handle these so they do not show up as "anon".
---
Issue shown via RC Filters (from {T162628}):
1. On wiki that has RC filters enabled, select 'Wikidata edits ' and 'Unregistered'
2. The above filters selection shows **wikidata registered users **; 'Wikidata edits' and 'Registered' will return no results.
The screenshot is from plwiki:
{F7464496}TASK DETAILhttps://phabricator.wikimedia.org/T51315EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: jmatazzoni, Catrope, Etonkovidova, Mattflaschen-WMF, MGChecker, Merl, Ricordisamoa, Aklapper, Liuxinyu970226, Wikidata-bugs, Legoktm, Denny, aude, MZMcBride, Lydia_Pintscher, Raymond, QZanden, Izno, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T51315: [Story] record wikibase recent change entries attributed as non-anon
Mattflaschen-WMF added subscribers: Etonkovidova, Catrope, jmatazzoni.Mattflaschen-WMF merged a task: T162628: 'Wikidata edits' filter does not recognize registered wikidata users . TASK DETAILhttps://phabricator.wikimedia.org/T51315EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: jmatazzoni, Catrope, Etonkovidova, Mattflaschen-WMF, MGChecker, Merl, Ricordisamoa, Aklapper, Liuxinyu970226, Wikidata-bugs, Legoktm, Denny, aude, MZMcBride, Lydia_Pintscher, Raymond, QZanden, Izno, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T51315: [Story] record wikibase recent change entries attributed as non-anon
Mattflaschen-WMF claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T51315EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, MGChecker, Merl, Ricordisamoa, Aklapper, Liuxinyu970226, Wikidata-bugs, Legoktm, Denny, aude, MZMcBride, Lydia_Pintscher, Raymond, QZanden, Izno, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T51315: [Story] record wikibase recent change entries attributed as non-anon
Mattflaschen-WMF added a comment. I started work on T162628: 'Wikidata edits' filter does not recognize registered wikidata users earlier, and saw that matej_suchanek linked it to here this morning. I think this is actually a duplicate. I'm going to keep working on this, but I'll ping in the #wikidata IRC to make sure people are aware and we can discuss if needed. I think the suggestion here of using -1 if CentralAuth is not available (it can also be if particular edge case accounts are not linked for some reason) is better than 0 which I said at T162628: 'Wikidata edits' filter does not recognize registered wikidata users .TASK DETAILhttps://phabricator.wikimedia.org/T51315EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, MGChecker, Merl, Ricordisamoa, Aklapper, Liuxinyu970226, Wikidata-bugs, Legoktm, Denny, aude, MZMcBride, Lydia_Pintscher, Raymond, QZanden, Izno, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T158025: Support ORES for propagated Wikidata edits
Mattflaschen-WMF removed a parent task: T159787: Add Wikidata to new RC Filters UI. TASK DETAILhttps://phabricator.wikimedia.org/T158025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Catrope, jmatazzoni, Aklapper, Mattflaschen-WMF, QZanden, Avner, Iniquity, Izno, SBisson, Wikidata-bugs, aude, He7d3r, Ladsgroup, Mbch331, tarlocesilion, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T159787: Add Wikidata to new RC Filters UI
Mattflaschen-WMF removed a subtask: T158025: Support ORES for propagated Wikidata edits. TASK DETAILhttps://phabricator.wikimedia.org/T159787EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Etonkovidova, Liuxinyu970226, Catrope, gerritbot, Aklapper, Mattflaschen-WMF, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Iniquity, jmatazzoni, Izno, SBisson, Wikidata-bugs, aude, Mbch331, tarlocesilion___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T158025: Support ORES for propagated Wikidata edits
Mattflaschen-WMF added a comment. There are a couple issues with this that make it more complicated than I thought: The Wikidata revision ID is only in rc_params, so it's not joinable. It's also in wb_changes, but that doesn't have the rc_id or anything allowing joining to recentchanges AFAICT. The ORES tables are per-wiki, so we wouldn't be able to join recentchanges from this DB to the wikidatawiki ORES table. We could potentially solve 1 by one of: 1a. Putting the real Wikidata revision ID into rc_this_oldid. Not sure if this is a good idea. 1b. Adding rc_id to wb_changes. We could potentially solve 2 by one of: 2a. Fully centralizing the relevant ORES tables, with a 'wiki' column name. 2b. Mirroring just the Wikidata ones to the client wikis.TASK DETAILhttps://phabricator.wikimedia.org/T158025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Catrope, jmatazzoni, Aklapper, Mattflaschen-WMF, QZanden, Avner, Iniquity, Izno, SBisson, Wikidata-bugs, aude, He7d3r, Ladsgroup, Mbch331, tarlocesilion, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T161359: WikidataBuildResources not installable
Mattflaschen-WMF added a project: MediaWiki-extensions-WikibaseRepository.Mattflaschen-WMF added a comment. Seems to be introduced by rEWBA8cd1dd774996: Update Wikibase DataModel to 7.0.0TASK DETAILhttps://phabricator.wikimedia.org/T161359EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Aklapper, Mattflaschen-WMF, QZanden, Acer, D3r1ck01, Izno, Wikidata-bugs, Base, matthiasmullie, aude, Deskana, Ricordisamoa, Fabrice_Florin, Mbch331, Tgr___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T161359: WikidataBuildResources not installable
Mattflaschen-WMF edited the task description. (Show Details) EDIT DETAILS...``` After remove wikibase/media-info from composer.json, I instead get: ``` Problem 1 - Installation request for wikibase/wikibase dev-master -> satisfiable by wikibase/wikibase[dev-master]. - wikibase/external-validation dev-master requires wikibase/data-model ~4.2|~5.0|~6.0 -> satisfiable by wikibase/data-model[4.2.0, 4.3.0, 4.4.0, 5.0.0, 5.0.1, 5.0.2, 5.1.0, 6.0.0, 6.0.1, 6.1.0, 6.2.0, 6.3.0, 6.3.1]. - Can only install one of: wikibase/data-model[7.0.0, 4.2.0]. - Can only install one of: wikibase/data-model[7.0.0, 4.3.0]. - Can only install one of: wikibase/data-model[7.0.0, 4.4.0]. - Can only install one of: wikibase/data-model[7.0.0, 5.0.0]. - Can only install one of: wikibase/data-model[7.0.0, 5.0.1]. - Can only install one of: wikibase/data-model[7.0.0, 5.0.2]. - Can only install one of: wikibase/data-model[7.0.0, 5.1.0]. - Can only install one of: wikibase/data-model[7.0.0, 6.0.0]. - Can only install one of: wikibase/data-model[7.0.0, 6.0.1]. - Can only install one of: wikibase/data-model[7.0.0, 6.1.0]. - Can only install one of: wikibase/data-model[7.0.0, 6.2.0]. - Can only install one of: wikibase/data-model[7.0.0, 6.3.0]. - Can only install one of: wikibase/data-model[7.0.0, 6.3.1]. - wikibase/wikibase dev-master requires wikibase/data-model ^7.0.0 -> satisfiable by wikibase/data-model[7.0.0]. - Installation request for wikibase/external-validation dev-master -> satisfiable by wikibase/external-validation[dev-master]. ```TASK DETAILhttps://phabricator.wikimedia.org/T161359EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Aklapper, Mattflaschen-WMF, QZanden, Acer, D3r1ck01, Izno, Wikidata-bugs, Base, matthiasmullie, aude, Deskana, Ricordisamoa, Fabrice_Florin, Mbch331, Tgr___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T161359: WikidataBuildResources not installable
Mattflaschen-WMF added a project: MediaWiki-extensions-WikibaseMediaInfo. TASK DETAILhttps://phabricator.wikimedia.org/T161359EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Aklapper, Mattflaschen-WMF, QZanden, D3r1ck01, Izno, Wikidata-bugs, aude, Ricordisamoa, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T161359: WikidataBuildResources not installable
Mattflaschen-WMF added a project: Structured-Multimedia-Data. TASK DETAILhttps://phabricator.wikimedia.org/T161359EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Aklapper, Mattflaschen-WMF, QZanden, Acer, D3r1ck01, Izno, Wikidata-bugs, Base, matthiasmullie, aude, Deskana, Ricordisamoa, Fabrice_Florin, Mbch331, Tgr___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T161359: WikidataBuildResources not installable
Mattflaschen-WMF created this task.Mattflaschen-WMF added a project: Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTIONIt was a few days ago, but is no longer installable due to the following error: vagrant@mediawiki-vagrant:/vagrant/mediawiki/extensions/WikidataBuildResources$ /usr/local/bin/composer install --optimize-autoloader --prefer-source Loading composer repositories with package information Updating dependencies (including require-dev) Your requirements could not be resolved to an installable set of packages. Problem 1 - Installation request for wikibase/wikibase dev-master -> satisfiable by wikibase/wikibase[dev-master]. - wikibase/media-info dev-master requires wikibase/data-model ~6.1 -> satisfiable by wikibase/data-model[6.1.0, 6.2.0, 6.3.0, 6.3.1]. - Can only install one of: wikibase/data-model[7.0.0, 6.1.0]. - Can only install one of: wikibase/data-model[7.0.0, 6.2.0]. - Can only install one of: wikibase/data-model[7.0.0, 6.3.0]. - Can only install one of: wikibase/data-model[7.0.0, 6.3.1]. - wikibase/wikibase dev-master requires wikibase/data-model ^7.0.0 -> satisfiable by wikibase/data-model[7.0.0]. - Installation request for wikibase/media-info dev-master -> satisfiable by wikibase/media-info[dev-master].TASK DETAILhttps://phabricator.wikimedia.org/T161359EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Aklapper, Mattflaschen-WMF, QZanden, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T159787: Add Wikidata to new RC Filters UI
Mattflaschen-WMF edited the task description. (Show Details)
EDIT DETAILSChange it to use the new structure and put "Wikidata edits" in "Type of change".
~~{T158025} is a real blocker/subtask, since otherwise we need an additional conflict state.~~ (we are going to do the conflict state for now)TASK DETAILhttps://phabricator.wikimedia.org/T159787EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Catrope, Mattflaschen-WMFCc: gerritbot, Aklapper, Mattflaschen-WMF, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, JJMC89, Maathavan, jmatazzoni, D3r1ck01, Izno, Wikidata-bugs, aude, Catrope, Mbch331, tarlocesilion___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T159787: Add Wikidata to new RC Filters UI
Mattflaschen-WMF edited projects, added Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017); removed Collaboration-Team-Triage. TASK DETAILhttps://phabricator.wikimedia.org/T159787EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Aklapper, Mattflaschen-WMF, JJMC89, jmatazzoni, D3r1ck01, Izno, Wikidata-bugs, aude, Catrope, Mbch331, tarlocesilion___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T159787: Add Wikidata to new RC Filters UI
Mattflaschen-WMF edited the task description. (Show Details)
EDIT DETAILSChange it to use the new structure and put "Wikidata edits" in "Type of change".
{T158025} is a real blocker/subtask, since otherwise we need an additional conflict state.TASK DETAILhttps://phabricator.wikimedia.org/T159787EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Aklapper, Mattflaschen-WMF, JJMC89, jmatazzoni, D3r1ck01, Izno, Wikidata-bugs, aude, Catrope, Mbch331, tarlocesilion___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T159787: Add Wikidata to new RC Filters UI
Mattflaschen-WMF added subtasks: T152754: Configure filters in a single extensible place, T158025: Support ORES for propagated Wikidata edits. TASK DETAILhttps://phabricator.wikimedia.org/T159787EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Aklapper, Mattflaschen-WMF, JJMC89, jmatazzoni, D3r1ck01, Izno, Wikidata-bugs, aude, Catrope, Mbch331, tarlocesilion___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T158025: Support ORES for propagated Wikidata edits
Mattflaschen-WMF added a parent task: T159787: Add Wikidata to new RC Filters UI. TASK DETAILhttps://phabricator.wikimedia.org/T158025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: jmatazzoni, Aklapper, Mattflaschen-WMF, Avner, JJMC89, D3r1ck01, Izno, Wikidata-bugs, aude, Catrope, He7d3r, Ladsgroup, Mbch331, tarlocesilion, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T159787: Add Wikidata to new RC Filters UI
Mattflaschen-WMF created this task.Mattflaschen-WMF added projects: Wikidata, Edit-Review-Improvements-RC-Page.Herald added a subscriber: Aklapper.Herald added a project: Collaboration-Team-Triage. TASK DESCRIPTIONChange it to use the new structure and put "Wikidata edits" in "Type of change".TASK DETAILhttps://phabricator.wikimedia.org/T159787EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Aklapper, Mattflaschen-WMF, JJMC89, jmatazzoni, D3r1ck01, Izno, Wikidata-bugs, aude, Catrope, Mbch331, tarlocesilion___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T158025: Support ORES for propagated Wikidata edits
Mattflaschen-WMF changed the title from "Support ORES for propogated Wikidata edits" to "Support ORES for propagated Wikidata edits". TASK DETAILhttps://phabricator.wikimedia.org/T158025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: jmatazzoni, Aklapper, Mattflaschen-WMF, JJMC89, D3r1ck01, Izno, Wikidata-bugs, aude, Catrope, Alchimista, Mbch331, tarlocesilion___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T158025: Support ORES for propagated Wikidata edits
Mattflaschen-WMF edited projects, added MediaWiki-extensions-ORES; removed ORES. TASK DETAILhttps://phabricator.wikimedia.org/T158025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: jmatazzoni, Aklapper, Mattflaschen-WMF, JJMC89, D3r1ck01, Izno, Wikidata-bugs, aude, Catrope, Alchimista, Ladsgroup, Mbch331, tarlocesilion, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T158025: Support ORES for propogated Wikidata edits
Mattflaschen-WMF created this task.Mattflaschen-WMF added projects: ORES, Wikidata, Edit-Review-Improvements-RC-Page.Herald added a subscriber: Aklapper.Herald added projects: Collaboration-Team-Triage, Revision-Scoring-As-A-Service-Backlog. TASK DESCRIPTIONORES supports Wikidata. You can enable it on wikidata.org and use it on e.g. Special:RecentChanges. The ORES extension doesn't currently handle these edits on the client-side (e.g. when viewing Wikidata changes relevant to English Wikipedia in Wikipedia RC page). However, it can (the diff ID is already available on the client-side) and should (it's useful to track vandalism, good-faith, etc.)TASK DETAILhttps://phabricator.wikimedia.org/T158025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Aklapper, Mattflaschen-WMF, JJMC89, jmatazzoni, D3r1ck01, Izno, Wikidata-bugs, aude, Catrope, Alchimista, Mbch331, tarlocesilion___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T146499: Revise documentation for "time" data value in Wikibase/DataModel/JSON
Mattflaschen-WMF added a project: Wikidata.Mattflaschen-WMF added a comment. Please tag Phabricator tasks with a project name. If it's Wikidata-related, and you don't know the exact sub-project, you can just use #Wikidata.TASK DETAILhttps://phabricator.wikimedia.org/T146499EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, Aklapper, Jc3s5h, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T143848: Automatically map wikibase-item to the correct namespace on the target wiki
Mattflaschen-WMF added a comment.
In T143848#2597666, @jayvdb wrote:
Are there any other problems to consider?
It still just seems semantically weird to me.
Even with that constraint, assume the dump has a Flow page Talk:Earth (the discussion page about the Earth encyclopedia article).
The target wiki has only User_talk as Flow. We'll assume there is no User_talk:Earth yet ("what if there is?" is another question). It seems confusing to import Talk:Earth to User_talk:Earth. It makes no sense in the new context, even (especially) if there is a User:Earth.TASK DETAILhttps://phabricator.wikimedia.org/T143848EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Lydia_Pintscher, Mattflaschen-WMF, Aklapper, TTO, jayvdb, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T143848: Automatically map wikibase-item to the correct namespace on the target wiki
Mattflaschen-WMF added a comment. In T143848#2581252, @jayvdb wrote: @Mattflaschen-WMF , is it not possible to create a wiki in which only one namespace can contain flow boards? It is possible. However, automatically importing all Flow boards to that namespace (assuming there is indeed only one) regardless of their original namespace seems potentially confusing. Also, you would have to handle collisions (where originally you had e.g. User_talk:Foo and Project_talk:Foo and now they're both mapped to Talk:Foo).TASK DETAILhttps://phabricator.wikimedia.org/T143848EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, Aklapper, TTO, jayvdb, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T143848: Automatically map wikibase-item to the correct namespace on the target wiki
Mattflaschen-WMF added a comment. Only the default 2600 is supported for Flow NS_TOPIC (where the topics themselves live), and hopefully people have no reason to try to override that. As for boards, they can be anywhere (any namespace can be default-Flow, it doesn't even have to be a talk namespace), so there is no way to infer this.TASK DETAILhttps://phabricator.wikimedia.org/T143848EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, Aklapper, TTO, jayvdb, EnricoCNC, D3r1ck01, Izno, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, Catrope, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T143848: Automatically map wikibase-item to the correct namespace on the target wiki
Mattflaschen-WMF removed projects: Flow, Collaboration-Team-Triage. TASK DETAILhttps://phabricator.wikimedia.org/T143848EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, Aklapper, TTO, jayvdb, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T128466: Frontpage of wikidata wiki of the vagrant role wikidata shows error mssage
Mattflaschen-WMF closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T128466EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: gerritbot, Smalyshev, JanZerebecki, Zppix, Mattflaschen-WMF, Jdlrobson, WickieTheViking, Llyrian, bd808, daniel, zeljkofilipin, aude, Aklapper, StudiesWorld, Physikerwelt, Lewizho99, Maathavan, D3r1ck01, Izno, Luke081515, mobrovac, Wikidata-bugs, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T129223: (tracking) Problems with wikidata vagrant role
Mattflaschen-WMF closed subtask T128466: Frontpage of wikidata wiki of the vagrant role wikidata shows error mssage as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T129223EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Addshore, JanZerebecki, Bene, Aklapper, Physikerwelt, D3r1ck01, Izno, Luke081515, mobrovac, Wikidata-bugs, aude, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T128466: Frontpage of wikidata wiki of the vagrant role wikidata shows error mssage
Mattflaschen-WMF added a comment. This task is really about the Vagrant role. I created T142232: When installing Wikidata, handle (pre-existing) wikitext main page in main namespace for the general issue.TASK DETAILhttps://phabricator.wikimedia.org/T128466EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: gerritbot, Smalyshev, JanZerebecki, Zppix, Mattflaschen-WMF, Jdlrobson, WickieTheViking, Llyrian, bd808, daniel, zeljkofilipin, aude, Aklapper, StudiesWorld, Physikerwelt, Lewizho99, Maathavan, D3r1ck01, Izno, Luke081515, mobrovac, Wikidata-bugs, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T142232: When installing Wikidata, handle (pre-existing) wikitext main page in main namespace
Mattflaschen-WMF created this task.Mattflaschen-WMF added a project: MediaWiki-extensions-WikibaseRepository.Herald added a subscriber: Aklapper.Herald added a project: Wikidata. TASK DESCRIPTIONSee prior discussion at T128466: Frontpage of wikidata wiki of the vagrant role wikidata shows error mssage. Some suggestions are to: Prompt in installer for main page location (only affects new installations when installer is run interactively). In update.php, move the main page (perhaps to Project:Current_Title) and update MediaWiki:Mainpage accordingly. TASK DETAILhttps://phabricator.wikimedia.org/T142232EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Aklapper, Mattflaschen-WMF, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T134158: Templates calling Wikidata elements don't display the result in the user language on Flow
Mattflaschen-WMF added a project: Collaboration-Team-Triage. TASK DETAILhttps://phabricator.wikimedia.org/T134158EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: hoo, daniel, VIGNERON, Aklapper, Trizek-WMF, D3r1ck01, Izno, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, Catrope, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T110604: [Story] Notification: Add notification when page is being connected to Wikidata
Mattflaschen-WMF added a comment. In T110604#2459293, @matej_suchanek wrote: Provided this is enabled on Commons and MWNamespace::isContent( $title->getNamespace() ) is true for Commons categories. NS_CATEGORY is not content on Commons, just FYI.TASK DETAILhttps://phabricator.wikimedia.org/T110604EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, Mattflaschen-WMFCc: Trizek-WMF, Scott_WUaS, JanZerebecki, Mattflaschen-WMF, gerritbot, Sjoerddebruin, Quiddity, jmatazzoni, Catrope, hoo, daniel, aude, matej_suchanek, Legoktm, Lydia_Pintscher, Edgars2007, Aklapper, Ainali, Lewizho99, Maathavan, D3r1ck01, Izno, SBisson, Luke081515, Wikidata-bugs, TheDJ, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T110604: [Story] Notification: Add notification when page is being connected to Wikidata
Mattflaschen-WMF added a comment. In T110604#2446655, @Lydia_Pintscher wrote: Hey Echo team :) Can someone fromm your side give this the final ok to get it unstuck? I'd hate to let our volunteers wait longer. Re-reviewed. Very minor feedback, someone from Wikibase can merge after that is updated.TASK DETAILhttps://phabricator.wikimedia.org/T110604EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, Mattflaschen-WMFCc: Trizek-WMF, Scott_WUaS, JanZerebecki, Mattflaschen-WMF, gerritbot, Sjoerddebruin, Quiddity, jmatazzoni, Catrope, hoo, daniel, aude, matej_suchanek, Legoktm, Lydia_Pintscher, Edgars2007, Aklapper, Ainali, Lewizho99, Maathavan, D3r1ck01, Izno, SBisson, Luke081515, Wikidata-bugs, TheDJ, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T128466: Frontpage of wikidata wiki of the vagrant role wikidata shows error mssage
Mattflaschen-WMF added a comment. In T128466#2445269, @daniel wrote: With https://gerrit.wikimedia.org/r/297787 merged, I think we can close this once https://gerrit.wikimedia.org/r/#/c/296059/ is merged. First one was reverted. In T128466#2406960, @daniel wrote: The next step would be to have the database updater migrate the main page... but how should it know where to migrate to? With this approach: You only need to migrate it if it's in the main namespace (not always true, e.g. https://de.wikipedia.org/wiki/Wikipedia:Hauptseite). You can just prepend: MWNamespace::getCanonicalName( NS_PROJECT ) . ':' to get the new name, since that should always exist.TASK DETAILhttps://phabricator.wikimedia.org/T128466EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: gerritbot, Smalyshev, JanZerebecki, Zppix, Mattflaschen-WMF, Jdlrobson, WickieTheViking, Llyrian, bd808, daniel, zeljkofilipin, aude, Aklapper, StudiesWorld, Physikerwelt, Lewizho99, Maathavan, D3r1ck01, Izno, Luke081515, mobrovac, Wikidata-bugs, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T128466: Frontpage of wikidata wiki of the vagrant role wikidata shows error mssage
Mattflaschen-WMF claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T128466EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, Jdlrobson, WickieTheViking, Llyrian, bd808, daniel, zeljkofilipin, aude, Aklapper, StudiesWorld, Physikerwelt, D3r1ck01, Izno, Luke081515, mobrovac, Wikidata-bugs, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T128466: Frontpage of wikidata wiki of the vagrant role wikidata shows error mssage
Mattflaschen-WMF added a comment. For now, I'm just going to repoint it to a different page and create that page. If you visit Main Page, it will still be broken, but we can live with that temporarily.TASK DETAILhttps://phabricator.wikimedia.org/T128466EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, Jdlrobson, WickieTheViking, Llyrian, bd808, daniel, zeljkofilipin, aude, Aklapper, StudiesWorld, Physikerwelt, D3r1ck01, Izno, Luke081515, mobrovac, Wikidata-bugs, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T137743: SPARQL or: How I Learned to Stop Worrying and Love the Triples
Mattflaschen-Personal edited the task description. (Show Details) EDIT DETAILS...Sparql and http://query.wikidata.org/ have been around for some time now, but could be used more. We should do a SPARQL beginners workshop during the Wikimania Hackathon 2016 to get more people started with SPARQL. It would be nice if non-hackathon participants would be allowed in too.It would be nice if non-hackathon participants would be allowed in too. https://etherpad.wikimedia.org/p/SPARQLatWikimania2016TASK DETAILhttps://phabricator.wikimedia.org/T137743EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-PersonalCc: OrenBochman, Ata, Esh77, Jonas, Legoktm, Smalyshev, Kghbln, Base, Lydia_Pintscher, Lucie, Spinster, Aklapper, Multichill, Zppix, Avner, debt, Gehel, D3r1ck01, FloNight, Izno, Psychoslave, jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T89600: Convert Template:Artwork to LUA and use Wikidata
Mattflaschen-Personal claimed this task.Mattflaschen-Personal added a comment. I'm going to take a look, and see what the current status is.TASK DETAILhttps://phabricator.wikimedia.org/T89600EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-PersonalCc: Mattflaschen-Personal, Base, Matanya, Marsupium, Ricordisamoa, Multichill, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Fabrice_Florin, Mbch331, Tgr___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T132897: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages
Mattflaschen added projects: Collaboration-Team-Interested, MediaWiki-extensions-ContentTranslation. Mattflaschen added a comment. Flow does not provide a general-purpose editor for editing normal wikitext pages. So it can't plug into the general-purpose MyEditor. However, it does support using either wikitext and VisualEditor for posting and editing comments. So if there were content-related documentation for Flow (here's how to suggest a reference on a talk page), the same concept could apply (different help pages for VE vs. wikitext). This is stored in a preference (based on the last time you modified a Flow editor area (so just previewing in VE doesn't count alone): This preference is 'flow-editor'. TASK DETAIL https://phabricator.wikimedia.org/T132897 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mattflaschen Cc: Mattflaschen, Danny_B, TerraCodes, Jdforrester-WMF, JAnD, Blahma, Teslaton, Elitre, Aklapper, Dvorapa, Snowwh1th3, AlexMonk-WMF, D3r1ck01, Nizil, Ixocactus, Izno, SBisson, Luke081515, RichardHeigl, Jrf, Husun1297, Wikidata-bugs, Etonkovidova, matthiasmullie, aude, GOIII, Dinoguy1000, Gryllida, jayvdb, Harej, MrStradivarius, XZise, Swainr, fbstj, Catrope, Jsahleen, Anomie, Tpt, Arrbee, KartikMistry, Isarra, AuFCL, Jackmcbarn, Mbch331, Quiddity, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T133774: Echo phpunit tests fail together with other extensions
Mattflaschen added a project: Collaboration-Team-Interested. TASK DETAIL https://phabricator.wikimedia.org/T133774 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mattflaschen Cc: gerritbot, daniel, adrianheine, JanZerebecki, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, SBisson, Luke081515, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Catrope, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T124792: RFC: Service Locator for MediaWiki core
Mattflaschen added a project: MediaWiki-General-or-Unknown. TASK DETAIL https://phabricator.wikimedia.org/T124792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, Mattflaschen Cc: Smalyshev, adrianheine, Bene, gerritbot, JanZerebecki, daniel, AndyRussG, Spage, Aklapper, bd808, JeroenDeDauw, GWicke, phuedx, Tgr, MZMcBride, RobLa-WMF, Ricordisamoa, Glaisher, Izno, Addshore, MMax8338, WebIntegrity, Avner, Lewizho99, D3r1ck01, OrenBochman, Wikidata-bugs, Malyacko, aude, jayvdb, fbstj, Mbch331, Jay8g, Ltrlg, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T110604: [Story] Notification: Add notification when page is being connected to Wikidata
Mattflaschen added a comment. In https://phabricator.wikimedia.org/T110604#2105911, @Edgars2007 wrote: > - And most probably there should be a link to some help or documentation, what Wikidata is about, **why** user should create items themselves (the most important part) and how to do that. OK, this third point is a little bit offtopic. @jmatazzoni What do you think about this? It is basically an optional feature they are looking at to link to a help page in the secondary links. I don't think we do that in any other secondary links. TASK DETAIL https://phabricator.wikimedia.org/T110604 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek, Mattflaschen Cc: Mattflaschen, gerritbot, Sjoerddebruin, Quiddity, jmatazzoni, Catrope, hoo, daniel, aude, matej_suchanek, Legoktm, Lydia_Pintscher, Edgars2007, Aklapper, Ainali, Lewizho99, codynguyen1116, D3r1ck01, Izno, SBisson, Luke081515, Wikidata-bugs, TheDJ, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T110604: [Story] Notification: Add notification when page is being connected to Wikidata
Mattflaschen added subscribers: Catrope, jmatazzoni, Quiddity. TASK DETAIL https://phabricator.wikimedia.org/T110604 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek, Mattflaschen Cc: Quiddity, jmatazzoni, Catrope, hoo, daniel, aude, matej_suchanek, Legoktm, Lydia_Pintscher, Edgars2007, Aklapper, Ainali, codynguyen1116, D3r1ck01, Izno, SBisson, Luke081515, Wikidata-bugs, TheDJ, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T114019: Dumps 2.0 for realz (planning/architecture session)
Mattflaschen added a comment. > Content. We have WikiData which has its own unique content; should we do something special here? Flow now has dumps, though they're not running in production yet (open task). Flow would need to fit into this framework, though. TASK DETAIL https://phabricator.wikimedia.org/T114019 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArielGlenn, Mattflaschen Cc: Mattflaschen, mobrovac, jberkel, NealMcB, jcrespo, Bianjiang, madhuvishy, Milimetric, RobLa-WMF, GWicke, TTO, zhuyifei1999, StudiesWorld, gnosygnu, LA2, Ladsgroup, intracer, Lokal_Profil, Halfak, Legoktm, JanZerebecki, brion, daniel, Hydriz, MZMcBride, hoo, ezachte, wpmirrordev, Nemo_bis, Aklapper, ArielGlenn, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail
Mattflaschen added a subscriber: aude. Mattflaschen added a comment. 5. Fix the Wikidata extension directly on the release branch, without the build process. @Aude okayed this on IRC (unless I misunderstood) on Friday. #2 has the downside that we will not get the CI benefits of this job for the release branches, which we will if we do a one-time fix. TASK DETAIL https://phabricator.wikimedia.org/T126073 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Paladox, Mattflaschen Cc: aude, JanZerebecki, Krinkle, hashar, StudiesWorld, Paladox, Aklapper, gerritbot, Mattflaschen, Izno, Wikidata-bugs, matthiasmullie, Gryllida, Mbch331, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T126082: core QUnit failure on mediawiki.widgets.CategorySelector on branch REL1_26 (causing other extensions to fail)
Mattflaschen edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T126082 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mattflaschen Cc: Legoktm, Mattflaschen, Aklapper, Paladox, StudiesWorld, Izno, Wikidata-bugs, aude, Mbch331, hashar, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T126082: core QUnit failure on mediawiki.widgets.CategorySelector on branch REL1_26 (causing other extensions to fail)
Mattflaschen changed the title from "MediaWiki QUnit + phplint broken on branch REL1_26 causing other extensions to fail" to "core QUnit failure on mediawiki.widgets.CategorySelector on branch REL1_26 (causing other extensions to fail)". Mattflaschen set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T126082 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mattflaschen Cc: Legoktm, Mattflaschen, Aklapper, Paladox, StudiesWorld, Izno, Wikidata-bugs, aude, Mbch331, hashar, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T126082: MediaWiki QUnit + phplint broken on branch REL1_26 causing other extensions to fail
Mattflaschen added a comment.
Yeah, it's just a single QUnit failure on mediawiki.widgets.CategorySelector:
https://gerrit.wikimedia.org/r/#/c/268845/
00:36:34 Running "karma:main" (karma) task
00:36:34 INFO [karma]: Karma v0.12.36 server started at http://localhost:9876/
00:36:34 INFO [launcher]: Starting browser Chrome
00:36:42 WARN [web-server]: 404: /favicon.ico
00:36:42 INFO [Chromium 48.0.2564 (Ubuntu 0.0.0)]: Connected on socket
ipzqa5kYfFvW_dJ_AkjX with id 54394637
00:37:07 Chromium 48.0.2564 (Ubuntu 0.0.0) LOG: 'Exception in module-execute
in module mediawiki.widgets.CategorySelector:'
00:37:07 Chromium 48.0.2564 (Ubuntu 0.0.0) ERROR: 'TypeError: Expecting a
function in instanceof check, but got undefined', TypeError{}
00:37:07 Chromium 48.0.2564 (Ubuntu 0.0.0): Executed 0 of 0 ERROR (0.002 secs
/ 0 secs)
00:37:07 Warning: Task "karma:main" failed. Use --force to continue.
I don't have time to work on this, though.
TASK DETAIL
https://phabricator.wikimedia.org/T126082
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Mattflaschen
Cc: Legoktm, Mattflaschen, Aklapper, Paladox, StudiesWorld, Izno,
Wikidata-bugs, aude, Mbch331, hashar, greg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail
Mattflaschen added a subscriber: Krinkle. Mattflaschen added a comment. In https://phabricator.wikimedia.org/T126073#2004067, @Paladox wrote: > @Mattflaschen ok. Is there any way we could prevent this happening to the > branches in the future. Making sure that you always run the branch with the CI tools (QUnit, etc.) it was tested with. I think that is basically the composer test/npm test approach. @hashar and @Krinkle probably know about this issue. TASK DETAIL https://phabricator.wikimedia.org/T126073 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Paladox, Mattflaschen Cc: Krinkle, hashar, StudiesWorld, Paladox, Aklapper, gerritbot, Mattflaschen, Izno, Wikidata-bugs, matthiasmullie, aude, Gryllida, Mbch331, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T126082: MediaWiki QUnit + phplint broken on branch REL1_26 causing other extensions to fail
Mattflaschen added a comment. I put up https://gerrit.wikimedia.org/r/#/c/268845/ just to see the status quo on REL1_26 with a no-op patch. TASK DETAIL https://phabricator.wikimedia.org/T126082 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mattflaschen Cc: Legoktm, Mattflaschen, Aklapper, Paladox, StudiesWorld, Izno, Wikidata-bugs, aude, Mbch331, hashar, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T126082: MediaWiki QUnit + phplint broken on branch REL1_26 causing other extensions to fail
Mattflaschen added a subscriber: Legoktm. Mattflaschen added a comment. The lint one is just because @legoktm is testing <https://gerrit.wikimedia.org/r/#/c/267827/1> with new-style array syntax ([]), and the job does not support that (it's called php53lint, so that makes sense). That should be tracked separate from QUnit. TASK DETAIL https://phabricator.wikimedia.org/T126082 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mattflaschen Cc: Legoktm, Mattflaschen, Aklapper, Paladox, StudiesWorld, Izno, Wikidata-bugs, aude, Mbch331, hashar, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail
Mattflaschen added a comment. In https://phabricator.wikimedia.org/T126073#2004334, @Paladox wrote: > @Mattflaschen I found a better solution we could cut off unit tests with a > config so I have been going through all of wikidata doing that. Ive name the > config $wmgUseWikidataTest and disabled it by default. that way it isent a > big change and can be done at a later point. I don't really want to disable all QUnit on the release branches just for a missing expect count. Even manually fixing it is better than that, IMHO, if the build bot isn't running anyway. TASK DETAIL https://phabricator.wikimedia.org/T126073 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Paladox, Mattflaschen Cc: hashar, StudiesWorld, Paladox, Aklapper, gerritbot, Mattflaschen, Izno, Wikidata-bugs, matthiasmullie, aude, Gryllida, Mbch331, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail
Mattflaschen added a subscriber: hashar. Mattflaschen added a comment. The other approach is to run whatever version of jshint used to work. But I don't know if it's possible to run multiple versions of it. @hashar? TASK DETAIL https://phabricator.wikimedia.org/T126073 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Paladox, Mattflaschen Cc: hashar, StudiesWorld, Paladox, Aklapper, gerritbot, Mattflaschen, Izno, Wikidata-bugs, matthiasmullie, aude, Gryllida, Mbch331, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail
Mattflaschen added a comment. @Paladox Okay, I tried to figure out what you need to do. I think you need to update Wikibase composer.json <https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikibase.git/REL1_25/composer.json#L36> on REL1_25 to a version with the expect fix . However, the complication is that the version with the fix (7925b64b7256902a2059273de76963d3bc3286a6) is quite different from the version currently there on REL1_25 (0.14.0). You could create a branch based on 0.14.0, then cherry-pick 7925b64b7256902a2059273de76963d3bc3286a6 on top, but that might get complicated. I will ask the Wikidata people whether the build bot runs on release branches like REL1_25 (it doesn't seem so), and about this bug.. If not, we may want to go with your approach of fixing it manually. TASK DETAIL https://phabricator.wikimedia.org/T126073 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Paladox, Mattflaschen Cc: StudiesWorld, Paladox, Aklapper, gerritbot, Mattflaschen, Izno, Wikidata-bugs, matthiasmullie, aude, Gryllida, Mbch331, hashar, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail
Mattflaschen edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T126073 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Paladox, Mattflaschen Cc: StudiesWorld, Paladox, Aklapper, gerritbot, Mattflaschen, Izno, Wikidata-bugs, matthiasmullie, aude, Gryllida, Mbch331, hashar, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail
Mattflaschen added a comment. In https://phabricator.wikimedia.org/T126073#2004134, @Mattflaschen wrote: > You can. I'll try to fix T103346: phpunit hhvm failure: LuaSandbox: > TextLibraryTests[87]: json decode, invalid values (trailing comma) > <https://phabricator.wikimedia.org/T103346> upstream. If you get stuck, ping > me. We should do it properly, though, not just manually change the files. So if don't want to do that, I'll take a shot at it. TASK DETAIL https://phabricator.wikimedia.org/T126073 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Paladox, Mattflaschen Cc: StudiesWorld, Paladox, Aklapper, gerritbot, Mattflaschen, Izno, Wikidata-bugs, matthiasmullie, aude, Gryllida, Mbch331, hashar, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Reassigned] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail
Mattflaschen reassigned this task from Mattflaschen to Paladox. Mattflaschen added a comment. You can. I'll try to fix T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma) <https://phabricator.wikimedia.org/T103346> upstream. If you get stuck, ping me. TASK DETAIL https://phabricator.wikimedia.org/T126073 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Paladox, Mattflaschen Cc: StudiesWorld, Paladox, Aklapper, gerritbot, Mattflaschen, Izno, Wikidata-bugs, matthiasmullie, aude, Gryllida, Mbch331, hashar, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma)
Mattflaschen added a subscriber: Mattflaschen. Mattflaschen claimed this task. Mattflaschen added a comment. Preventing us from merging https://gerrit.wikimedia.org/r/#/c/260869/ . TASK DETAIL https://phabricator.wikimedia.org/T103346 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mattflaschen Cc: Mattflaschen, gerritbot, StudiesWorld, daniel, Anomie, JanZerebecki, Aklapper, Izno, Luke081515, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Jackmcbarn, Mbch331, Krenair, Joe, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma)
Mattflaschen added a project: Collaboration-Team-Current. TASK DETAIL https://phabricator.wikimedia.org/T103346 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mattflaschen Cc: Mattflaschen, gerritbot, StudiesWorld, daniel, Anomie, JanZerebecki, Aklapper, Izno, Luke081515, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Jackmcbarn, Mbch331, Krenair, Joe, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
