[Wikidata-bugs] [Maniphest] [Commented On] T75020: Move JS and PHP view code to separate repo

[adrianlang]

adrianlang added a comment.

https://gerrit.wikimedia.org/r/180450 extracts UserLanguageLookup interface. 
With that, View does not depend on Repo anymore.


TASK DETAIL
  https://phabricator.wikimedia.org/T75020

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
.

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: adrianlang
Cc: adrianlang, Tobi_WMDE_SW, Wikidata-bugs, aude



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T75020: Move JS and PHP view code to separate repo

[adrianlang]

adrianlang added a comment.

https://gerrit.wikimedia.org/r/#/c/180431/ makes EntityIdFormatter an 
interface, so it's not bogus anymore.


TASK DETAIL
  https://phabricator.wikimedia.org/T75020

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
.

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: adrianlang
Cc: adrianlang, Tobi_WMDE_SW, Wikidata-bugs, aude



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T75020: Move JS and PHP view code to separate repo

[adrianlang]

adrianlang added a comment.

I forgot Wikibase\Template and Wikibase\TemplateRegistry. Also, 
Wikibase\Lib\EntityIdFormatter is probably bogus, since it's not an interface.


TASK DETAIL
  https://phabricator.wikimedia.org/T75020

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
.

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: adrianlang
Cc: adrianlang, Tobi_WMDE_SW, Wikidata-bugs, aude



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T75020: Move JS and PHP view code to separate repo

[adrianlang]

adrianlang added a comment.

After all my pending changes are merged in, the PHP part of the (potential) 
repository looks like this:

**Content:**

- Wikibase\Repo\View\*
- wfTemplate
- repo/tests/phpunit/includes/View/*

**Dependencies:**

- wikibase/data-model
  - Wikibase\DataModel\*
- data-values/data-types
  - DataTypes\DataType (PropertyView)
- data-values/data-values
  - DataValues\StringValue
- data-values/interfaces
  - ValueFormatters\FormatterOptions (EntityViewFactory)
  - ValueFormatters\FormattingException (SnakHtmlGenerator)
  - ValueFormatters\ValueFormatter (EntityViewFactory)
- »WikibaseLibInterfaces«
  - Wikibase\Lib\EntityIdFormatter
  - Wikibase\Lib\EntityIdFormatterFactory
  - Wikibase\Lib\SnakFormatter (EntityViewFactory, SnakHtmlGenerator)
  - Wikibase\Lib\Store\EntityLookup (EntityViewFactory, SiteLinksView)
  - Wikibase\Lib\Store\EntityRevisionLookup (EntityViewPlaceholderExpander)
  - Wikibase\Lib\Store\LabelLookup
  - Wikibase\Lib\Store\StorageException (EntityViewPlaceholderExpander)
- Bogus
  - Wikibase\EntityRevision (EntityView, PropertyView, ItemView)
  - Wikibase\LanguageFallbackChain (EntityViewFactory)
  - Wikibase\Lib\OutputFormatSnakFormatterFactory (EntityViewFactory)
  - Wikibase\Lib\Serializers\ClaimSerializer (ClaimHtmlGenerator)
  - Wikibase\UserLanguageLookup (EntityViewPlaceholderExpander)
  - Wikibase\Utils (SiteLinksView, TermBoxView)
- mediawiki/core
  - Html (EntityView)
  - Message (SectionEditLinkGenerator, SiteLinksView, TermBoxView)
  - MessageCache
  - Language (EntityViewFactory, EntityView, TermBoxView, 
EntityViewPlaceholderExpander)
  - MediaWikiLangTestCase
  - MediaWikiSite
  - MediaWikiTestCase
  - MWException (EntityViewPlaceholderExpander)
  - Sanitizer (SiteLinksView)
  - Site (SiteLinksView)
  - SiteList (SiteLinksView)
  - SpecialPageFactory (SectionEditLinkGenerator)
  - Title (TermBoxView, EntityViewPlaceholderExpander)
  - User (EntityViewPlaceholderExpander)
  - wfMessage
  - wfProfileIn
  - wfProfileOut
  - wfWarn
  - wfUrlencode
  - wfRandom


TASK DETAIL
  https://phabricator.wikimedia.org/T75020

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
.

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: adrianlang
Cc: adrianlang, Tobi_WMDE_SW, Wikidata-bugs, aude



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T78271: Does not work with composer used in mw root

[adrianlang]

adrianlang closed this task as "Resolved".
adrianlang claimed this task.
adrianlang added a comment.

Should be fixed since https://github.com/wmde/DataValuesJavascript/pull/54


TASK DETAIL
  https://phabricator.wikimedia.org/T78271

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
.

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: adrianlang
Cc: Aklapper, Lucie, Wikidata-bugs, aude



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T64724: Reuse EntityInfoBuilder arrays when generating html

[adrianlang]

adrianlang added a project: Patch-For-Review.
adrianlang set Security to none.

TASK DETAIL
  https://phabricator.wikimedia.org/T64724

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
.

To: daniel, adrianlang
Cc: wikidata-bugs, thiemowmde, Lydia_Pintscher, Tobi_WMDE_SW, daniel, 
Wikidata-bugs, adrianlang



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T64724: Reuse EntityInfoBuilder arrays when generating html

[adrianlang]

adrianlang added a project: Patch-For-Review.
adrianlang set Security to none.

TASK DETAIL
  https://phabricator.wikimedia.org/T64724

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
.

To: daniel, adrianlang
Cc: wikidata-bugs, thiemowmde, Lydia_Pintscher, Tobi_WMDE_SW, daniel, 
Wikidata-bugs, adrianlang



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Assigned] T64724: Reuse EntityInfoBuilder arrays when generating html

[adrianlang]

adrianlang assigned this task to daniel.
adrianlang added a subscriber: adrianlang.
adrianlang added a comment.

https://gerrit.wikimedia.org/r/#/c/173848/

TASK DETAIL
  https://phabricator.wikimedia.org/T64724

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
.

To: daniel, adrianlang
Cc: wikidata-bugs, thiemowmde, Lydia_Pintscher, Tobi_WMDE_SW, daniel, 
Wikidata-bugs, adrianlang



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Assigned] T64724: Reuse EntityInfoBuilder arrays when generating html

[adrianlang]

adrianlang assigned this task to daniel.
adrianlang added a subscriber: adrianlang.
adrianlang added a comment.

https://gerrit.wikimedia.org/r/#/c/173848/

TASK DETAIL
  https://phabricator.wikimedia.org/T64724

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
.

To: daniel, adrianlang
Cc: wikidata-bugs, thiemowmde, Lydia_Pintscher, Tobi_WMDE_SW, daniel, 
Wikidata-bugs, adrianlang



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unblock] T64724: Reuse EntityInfoBuilder arrays when generating html

[adrianlang]

adrianlang closed blocking task T75264: Refactor EntityView Instantiation as 
"Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T64724

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
.

To: adrianlang
Cc: wikidata-bugs, thiemowmde, Lydia_Pintscher, Tobi_WMDE_SW, daniel, 
Wikidata-bugs



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T75264: Refactor EntityView Instantiation

[adrianlang]

adrianlang closed this task as "Resolved".
adrianlang claimed this task.
adrianlang added a comment.

This is actually done, my comments applied to T64724.

TASK DETAIL
  https://phabricator.wikimedia.org/T75264

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
.

To: adrianlang
Cc: wikidata-bugs, adrianlang, Tobi_WMDE_SW, Wikidata-bugs



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T75264: Refactor EntityView Instantiation

[adrianlang]

adrianlang closed this task as "Resolved".
adrianlang claimed this task.
adrianlang added a comment.

This is actually done, my comments applied to T64724.

TASK DETAIL
  https://phabricator.wikimedia.org/T75264

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
.

To: adrianlang
Cc: wikidata-bugs, adrianlang, Tobi_WMDE_SW, Wikidata-bugs



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unblock] T64724: Reuse EntityInfoBuilder arrays when generating html

[adrianlang]

adrianlang closed blocking task T75264: Refactor EntityView Instantiation as 
"Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T64724

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
.

To: adrianlang
Cc: wikidata-bugs, thiemowmde, Lydia_Pintscher, Tobi_WMDE_SW, daniel, 
Wikidata-bugs



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs