[Wikidata-bugs] [Maniphest] [Commented On] T146692: bzr, cvs should be valid schemes for URL data types on wikidata.org
dachary added a comment. Thanks for a *very* quick resolution :-) IIRC it will be active on wikidata in a week or two.TASK DETAILhttps://phabricator.wikimedia.org/T146692EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dacharyCc: hoo, Mbch331, gerritbot, Lydia_Pintscher, dachary, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T146692: bzr, cvs should be valid schemes for URL data types on wikidata.org
dachary edited the task description. (Show Details) EDIT DETAILS...* cvs://pserver:anonym...@cvs.delorie.com:/cvs/djgpp == :pserver:anonym...@cvs.delorie.com:/cvs/djgpp https://www.wikidata.org/wiki/Q780172 * cvs://pserver:cvsa...@cvs.maptools.org:/cvs/maptools/cvsroot == :pserver:cvsa...@cvs.maptools.org:/cvs/maptools/cvsroot https://www.wikidata.org/wiki/Q1017110 * cvs://pserver:anonym...@steghide.cvs.sourceforge.net:/cvsroot/ == :pserver:anonym...@steghide.cvs.sourceforge.net:/cvsroot/ https://www.wikidata.org/wiki/Q3498040...TASK DETAILhttps://phabricator.wikimedia.org/T146692EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dacharyCc: Mbch331, gerritbot, Lydia_Pintscher, dachary, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146692: bzr, cvs should be valid schemes for URL data types on wikidata.org
dachary added a comment. @Mbch331 right :-) I updated the examples to show the cvs:// form (which is s|^:pserver:|cvs://pserver:|)TASK DETAILhttps://phabricator.wikimedia.org/T146692EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dacharyCc: Mbch331, gerritbot, Lydia_Pintscher, dachary, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T146692: bzr, cvs should be valid schemes for URL data types on wikidata.org
dachary edited the task description. (Show Details) EDIT DETAILS...* bzr://archonproject.bzr.sourceforge.net/bzrroot/archonproject https://www.wikidata.org/wiki/Q4787330 ** cvs://pserver:anonym...@cvs.delorie.com:/cvs/djgpp == :pserver:anonym...@cvs.delorie.com:/cvs/djgpp https://www.wikidata.org/wiki/Q780172 ** cvs://pserver:cvsa...@cvs.maptools.org:/cvs/maptools/cvsroot == :pserver:cvsa...@cvs.maptools.org:/cvs/maptools/cvsroot https://www.wikidata.org/wiki/Q1017110 ** cvs://pserver:anonym...@steghide.cvs.sourceforge.net:/cvsroot/ == :pserver:anonym...@steghide.cvs.sourceforge.net:/cvsroot/steghide https://www.wikidata.org/wiki/Q3498040...TASK DETAILhttps://phabricator.wikimedia.org/T146692EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dacharyCc: Mbch331, gerritbot, Lydia_Pintscher, dachary, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T146692: bzr, cvs should be valid schemes for URL data types on wikidata.org
dachary added a comment. @Lydia_Pintscher I added you to the Subscribers because you participated in https://phabricator.wikimedia.org/T140986. If that is not a good practice, please let me know.TASK DETAILhttps://phabricator.wikimedia.org/T146692EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dacharyCc: gerritbot, Lydia_Pintscher, dachary, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T146692: bzr, cvs should be valid schemes for URL data types on wikidata.org
dachary created this task.dachary added projects: Wikidata.org, Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTIONSimilar to https://phabricator.wikimedia.org/T140986, the bzr and cvs schemes should be valid. bzr://archonproject.bzr.sourceforge.net/bzrroot/archonproject https://www.wikidata.org/wiki/Q4787330 :pserver:anonym...@cvs.delorie.com:/cvs/djgpp https://www.wikidata.org/wiki/Q780172 :pserver:cvsa...@cvs.maptools.org:/cvs/maptools/cvsroot https://www.wikidata.org/wiki/Q1017110 :pserver:anonym...@steghide.cvs.sourceforge.net:/cvsroot/steghide https://www.wikidata.org/wiki/Q3498040 (see more with http://tinyurl.com/z62jae6) The CVS case is interesting because the argument provided to the cvs command is not a URL, which prompted a discussion ( https://www.wikidata.org/wiki/Wikidata_talk:WikiProject_Informatics/FLOSS#CVS_:pserver:_repositories_are_not_URLs ). It turns out there is a cvs scheme described at http://www.iana.org/assignments/uri-schemes/prov/cvs and it could be used instead of the :pserver: notation.TASK DETAILhttps://phabricator.wikimedia.org/T146692EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dacharyCc: Lydia_Pintscher, dachary, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T140986: svn, git, ssh should be valid schemes for URL data types on wikidata.org
dachary edited the task description. (Show Details) EDIT DETAILS...* https://www.wikidata.org/wiki/Q131344 svn://svn.mplayerhq.hu/mplayer/trunkhu/mplayer/trunk * https://www.wikidata.org/wiki/Q377539 git://git.kernel.org/pub/scm/virt/kvm/kvm.gitTASK DETAILhttps://phabricator.wikimedia.org/T140986EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, dacharyCc: Lydia_Pintscher, aude, Mbch331, gerritbot, Bugreporter, Ash_Crow, JeroenDeDauw, dachary, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T140986: svn, git, ssh should be valid schemes for URL data types on wikidata.org
dachary edited the task description. (Show Details) EDIT DETAILS...* https://www.wikidata.org/wiki/Q2447945 git://git.xmms2.org/xmms2/xmms2-devel.gitgit * https://www.wikidata.org/wiki/Q131344 svn://svn.mplayerhq.hu/mplayer/trunkTASK DETAILhttps://phabricator.wikimedia.org/T140986EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, dacharyCc: Lydia_Pintscher, aude, Mbch331, gerritbot, Bugreporter, Ash_Crow, JeroenDeDauw, dachary, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T140986: svn, git, ssh should be valid schemes for URL data types on wikidata.org
dachary edited the task description. (Show Details) EDIT DETAILS...* https://www.wikidata.org/wiki/Q2141006 svn://sylpheed.sraoss.jp/sylpheed/trunkjp/sylpheed/trunk * https://www.wikidata.org/wiki/Q2447945 git://git.xmms2.org/xmms2/xmms2-devel.gitTASK DETAILhttps://phabricator.wikimedia.org/T140986EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dacharyCc: aude, Mbch331, gerritbot, Bugreporter, Ash_Crow, JeroenDeDauw, dachary, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T140986: svn, git, ssh should be valid schemes for URL data types on wikidata.org
dachary edited the task description. (Show Details) EDIT DETAILS...* https://www.wikidata.org/wiki/Q6898824 svn://svn.rforge.net/org/trunk/rosuda/Mondrian/net/org/trunk/rosuda/Mondrian/ * https://www.wikidata.org/wiki/Q2141006 svn://sylpheed.sraoss.jp/sylpheed/trunkTASK DETAILhttps://phabricator.wikimedia.org/T140986EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dacharyCc: aude, Mbch331, gerritbot, Bugreporter, Ash_Crow, JeroenDeDauw, dachary, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T140986: svn, git, ssh should be valid schemes for URL data types on wikidata.org
dachary added a subscriber: aude.dachary added a comment. @aude is there anything else to be done for this patch to benefit wikidata.org ? Or should we just wait ?TASK DETAILhttps://phabricator.wikimedia.org/T140986EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dacharyCc: aude, Mbch331, gerritbot, Bugreporter, Ash_Crow, JeroenDeDauw, dachary, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T140986: svn, git, ssh should be valid schemes for URL data types on wikidata.org
dachary edited the task description. (Show Details) EDIT DETAILS...* https://www.wikidata.org/wiki/Q1857280 git://anongit.kde.org/phononorg/phonon * https://www.wikidata.org/wiki/Q6898824 svn://svn.rforge.net/org/trunk/rosuda/Mondrian/TASK DETAILhttps://phabricator.wikimedia.org/T140986EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dacharyCc: Mbch331, gerritbot, Bugreporter, Ash_Crow, JeroenDeDauw, dachary, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T141259: DuplicateReferences fails when the statement is in edit mode
dachary added a comment. I propose the following patch to Gadget-DuplicateReferences.js to handle statements in edit mode differently. If the statement is in edit mode (i.e. the wb-edit class is present), the reference is added but not saved and the statement remains in edit mode. F4305293: a.patchTASK DETAILhttps://phabricator.wikimedia.org/T141259EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dacharyCc: dachary, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Ricordisamoa, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T141259: DuplicateReferences fails when the statement is in edit mode
dachary created this task.dachary added projects: Wikidata-Gadgets, Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTIONWhen the insert reference link added by Gadget-DuplicateReferences.js is clicked on a statement that is in edit mode, it fails with an error as shown in the screenshot below. F4305571: w4.pngTASK DETAILhttps://phabricator.wikimedia.org/T141259EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dacharyCc: dachary, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Ricordisamoa, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T140125: DuplicateReferences doesn't work without refresh on second statements
dachary added a comment. I propose the following patch to Gadget-DuplicateReferences.js to handle statements in edit mode differently. If the statement is in edit mode (i.e. the wb-edit class is present), the reference is added but not saved and the statement remains in edit mode. F4305293: a.patchTASK DETAILhttps://phabricator.wikimedia.org/T140125EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dacharyCc: dachary, Bene, Nikki, Aklapper, Sjoerddebruin, Zppix, D3r1ck01, Izno, Wikidata-bugs, aude, Ricordisamoa, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T140125: DuplicateReferences doesn't work without refresh on second statements
dachary added a comment.
What about changing
function insertReference( statementview ) {
in Gadget-DuplicateReferences.js so that it does not
claimsChanger.setStatement()
when the statement already is in edit mode ?TASK DETAILhttps://phabricator.wikimedia.org/T140125EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dacharyCc: dachary, Bene, Nikki, Aklapper, Sjoerddebruin, Zppix, D3r1ck01, Izno, Wikidata-bugs, aude, Ricordisamoa, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T140125: DuplicateReferences doesn't work without refresh on second statements
dachary added a comment. I got confused because ClaimsChanger recently changed to StatmentChanger. I wonder how this will impact the gadget ? When will this change be deployed ?TASK DETAILhttps://phabricator.wikimedia.org/T140125EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dacharyCc: dachary, Bene, Nikki, Aklapper, Sjoerddebruin, Zppix, D3r1ck01, Izno, Wikidata-bugs, aude, Ricordisamoa, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T140125: DuplicateReferences doesn't work without refresh on second statements
dachary added a comment. I reproduced the problem by adding to a statement or adding a statement with the same property. In both cases the "insert reference" shows, as displayed in the following screenshot. F4300319: w3.png However, whien clicking "insert reference", it fails with an error message as show in the screenshot below, presumably because the gadget is trying to save a statement that does not exist yet. F4300342: w4.png After saving the new statement, the "insert reference" is not added. And since the "copy reference" is dimmed out, there is no way to ask '''please add the links once more, some are missing". Does this reflect what you experienced, or was your problem about something else entirely ?TASK DETAILhttps://phabricator.wikimedia.org/T140125EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dacharyCc: dachary, Bene, Nikki, Aklapper, Sjoerddebruin, Zppix, D3r1ck01, Izno, Wikidata-bugs, aude, Ricordisamoa, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T140986: svn, git, ssh should be valid schemes for URL data types on wikidata.org
dachary edited the task description. (Show Details) EDIT DETAILS...* https://www.wikidata.org/wiki/Q1891726 svn://pmwiki.org/pmwiki/tags/latest * https://www.wikidata.org/wiki/Q1857280 git://anongit.kde.org/pmwiki/tags/latesthononTASK DETAILhttps://phabricator.wikimedia.org/T140986EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dacharyCc: Mbch331, gerritbot, Bugreporter, Ash_Crow, JeroenDeDauw, dachary, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
