[Wikidata-bugs] [Maniphest] T161517: Allow anonymous users to change interface language on Commons with ULS

2021-09-06 Thread eranroz
eranroz added a comment.


  This also applies to wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T161517

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: eranroz, Tacsipacsi, Danmichaelo, Liuxinyu970226, faidon, tstarling, 
BBlack, ema, gerritbot, Raymond, Jdforrester-WMF, Aklapper, Nemo_bis, Jarekt, 
Perhelion, revi, matmarex, zhuyifei1999, Bawolff, Nikerabbit, KrinkleBot, 
Steinsplitter, Suran38, Biggs657, joanna_borun, Invadibot, Lalamarie69, Zabe, 
Devnull, maantietaja, Y.ssk, lmata, Juan90264, Muchiri124, Alter-paule, 
Beast1978, CBogen, Un1tY, Akuckartz, Hook696, CptViraj, AKA_MBG, Kent7301, 
Dibya, RhinosF1, joker88john, Legado_Shulgin, 94rain, DannyS712, ReaperDawn, 
CucyNoiD, Nandana, Tks4Fish, Gaboe420, Giuliamocci, Davinaclare77, Cpaulf30, 
Techguru.pc, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, Hfbn0, QZanden, Kizule, LawExplorer, Lewizho99, Zppix, 
Maathavan, Devwaker, Niklitov, Poyekhali, _jensen, Urbanecm, rosalieper, 
Taiwania_Justo, JEumerus, Scott_WUaS, Srdjan, Ananthsubray, MuhammadShuaib, 
Superzerocool, Ixocactus, Stanglavine, Tulsi_Bhagat, LNDDYL, Psychoslave, 
Wong128hk, Luke081515, SimmeD, Wikidata-bugs, Snowolf, Base, aude, Dcljr, 
El_Grafo, Dinoguy1000, Gryllida, Shizhao, Arrbee, Addshore, Matanya, Mbch331, 
Jay8g, Krenair, fgiunchedi
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T161517: Allow anonymous users to change interface language on Commons with ULS

2021-09-06 Thread eranroz
eranroz added a project: Wikidata.
Restricted Application added a project: wdwb-tech.

TASK DETAIL
  https://phabricator.wikimedia.org/T161517

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: Tacsipacsi, Danmichaelo, Liuxinyu970226, faidon, tstarling, BBlack, ema, 
gerritbot, Raymond, Jdforrester-WMF, Aklapper, Nemo_bis, Jarekt, Perhelion, 
revi, matmarex, zhuyifei1999, Bawolff, Nikerabbit, KrinkleBot, Steinsplitter, 
Suran38, Biggs657, joanna_borun, Invadibot, Lalamarie69, Zabe, Devnull, 
maantietaja, Y.ssk, lmata, Juan90264, Muchiri124, Alter-paule, Beast1978, 
CBogen, Un1tY, Akuckartz, Hook696, CptViraj, AKA_MBG, Kent7301, Dibya, 
RhinosF1, joker88john, Legado_Shulgin, 94rain, DannyS712, ReaperDawn, CucyNoiD, 
Nandana, Tks4Fish, Gaboe420, Giuliamocci, Davinaclare77, Cpaulf30, Techguru.pc, 
Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, GoranSMilovanovic, Jayprakash12345, 
Hfbn0, QZanden, Kizule, LawExplorer, Lewizho99, Zppix, Maathavan, Devwaker, 
Niklitov, Poyekhali, _jensen, Urbanecm, rosalieper, Taiwania_Justo, JEumerus, 
Scott_WUaS, Srdjan, Ananthsubray, MuhammadShuaib, Superzerocool, Ixocactus, 
Stanglavine, Tulsi_Bhagat, LNDDYL, Psychoslave, Wong128hk, Luke081515, SimmeD, 
Wikidata-bugs, Snowolf, Base, aude, Dcljr, El_Grafo, Dinoguy1000, Gryllida, 
Shizhao, Arrbee, Addshore, Matanya, Mbch331, Jay8g, Krenair, fgiunchedi
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T290466: Wikidata coordinate editor - X button appears on the wrong side for RTL

2021-09-06 Thread eranroz
eranroz created this task.
eranroz added projects: RTL, Wikidata.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: I18n.

TASK DESCRIPTION
  For LTR languages X button in the coordinate editor appears on the right side 
- hence on RTL languages it is expected to appear on the left side.
  However it is actually appears on the right side.
  
  Even worse - the IME widget is placed on same place and it is hard to press 
on the X button.
  
  X button has CSS class ui-icon-close
  
  Screenshot can explain the issue:
  F34635344: image.png <https://phabricator.wikimedia.org/F34635344>

TASK DETAIL
  https://phabricator.wikimedia.org/T290466

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: Aklapper, eranroz, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, Muhammed4IT, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, 
Huji, Amire80, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T172122: Script to fetch coordinate from Google Maps

2021-09-06 Thread eranroz
eranroz added a comment.


  I think there is a risk for copyright violation to copy coordinates from 
google maps.
  Suggesting to reject this ticket or consider the copyright side before going 
to implement that (there are probably other databases for which it is valid)

TASK DETAIL
  https://phabricator.wikimedia.org/T172122

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: eranroz, Liuxinyu970226, Shizhao, Aklapper, Cosine02, PokestarFan, 
Bugreporter, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, dachary, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Ricordisamoa, Tacsipacsi, Sjoerddebruin, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T272816: Geographic coordinates in edit mode display at the righ side of the map instead of below it

2021-09-06 Thread eranroz
eranroz added a comment.


  I am not able to reproduce this issue. Mohammed can you please specify 
specific gadget/script that required to get it reproduce?

TASK DETAIL
  https://phabricator.wikimedia.org/T272816

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: eranroz, Ayack, Lydia_Pintscher, Aklapper, Mohammed_Sadat_WMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T195415: Special:NewItem - fields direction should be defined according to the language

2020-10-27 Thread eranroz
eranroz closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T195415

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: Aklapper, gerritbot, Ladsgroup, Amire80, eranroz, Akuckartz, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, 
Wikidata-bugs, aude, Huji, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T96040: Wikibase special pages (tracking)

2020-10-27 Thread eranroz
eranroz closed subtask T195415: Special:NewItem - fields direction should be 
defined according to the language as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T96040

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: PokestarFan, Luke081515, Liuxinyu970226, aude, Aklapper, Akuckartz, 
Nickleh, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T261543: Wrong formating for duration, doesn't take into account plural

2020-08-29 Thread eranroz
eranroz updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T261543

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: Aklapper, Ladsgroup, Amire80, eranroz, Akuckartz, darthmon_wmde, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T261543: Wrong formating for duration, doesn't take into account plural

2020-08-29 Thread eranroz
eranroz created this task.
eranroz added a project: Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Time duration should take into account language aspects or single/plural.
  
  Example: Duration property (P2047 <https://phabricator.wikimedia.org/P2047>) 
in https://www.wikidata.org/wiki/Q164815
  English: Current value: "3 day", expected value: "3 days"
  Hebrew: Current value: "3 יממה", expected value: "3 ימים"

TASK DETAIL
  https://phabricator.wikimedia.org/T261543

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: Aklapper, Ladsgroup, Amire80, eranroz, Akuckartz, darthmon_wmde, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-21 Thread eranroz
eranroz closed this task as "Declined".
eranroz added a comment.


  it's disappointing that JS API that was just exposing the PHP API (part of 
it) and that is used used by Wikibase itself, isn't available anymore for other 
consumers :-(
  Anyway it seems like  JS consumers of wikibase should not relay on that 
anymore and should use re-implement it themselves or directly access using MW 
API for now.

TASK DETAIL
  https://phabricator.wikimedia.org/T259211

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: daniel, Lydia_Pintscher, 0x010C, vlsergey, Krinkle, Lucas_Werkmeister_WMDE, 
Ladsgroup, Aklapper, eranroz, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-20 Thread eranroz
eranroz added a subscriber: daniel.
eranroz added a comment.


  @Ladsgroup @daniel   I would like to understand what is the approach we would 
like to go for the long run:
  
  - Do we want to have JS api for other extensions (the current and future use 
cases I can think of are Content translation such as  T249458 
<https://phabricator.wikimedia.org/T249458> and Client_editing_input 
<https://www.wikidata.org/wiki/Wikidata:Client_editing_input>) and for gadgets?
  - Do we want to have bare light API without JS wrapping? in which case, when 
do Wikibase plan to adapt to this approach?  (rm RepiApi and change all the 
uses)

TASK DETAIL
  https://phabricator.wikimedia.org/T259211

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: daniel, Lydia_Pintscher, 0x010C, vlsergey, Krinkle, Lucas_Werkmeister_WMDE, 
Ladsgroup, Aklapper, eranroz, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-04 Thread eranroz
eranroz added a comment.


  In T259211#6347466 <https://phabricator.wikimedia.org/T259211#6347466>, 
@Ladsgroup wrote:
  
  > but in the mean time you can still mark `jquery.wikibase.linkitem` as the 
dependency instead and use the global variable but I don't recommend it.
  
  This by itself won't work as the dependencies aren't defined correctly
  
mw.loader.load('jquery.wikibase.linkitem')
Exception in module-execute in module jquery.wikibase.linkitem: 
load.php:2:530
TypeError: "repoConfig is null"
  
  
  
  In T259211#6347466 <https://phabricator.wikimedia.org/T259211#6347466>, 
@Ladsgroup wrote:
  
  > Hey,
  > Technically it's intentional. RepoApi is a bad module. It's confusing 
(which repo? Commons is also a repo) and doesn't bring much value (you can use 
`mw.Api` instead in WMF, as the URL to wikidata.org likely won't change) and 
having an extra module brings its own cost.
  > ...
  > I highly recommend not using this module anymore. Also according to stable 
interface policy 
<https://www.wikidata.org/wiki/Wikidata:Stable_Interface_Policy>, javascript 
code is unstable and prone to change with prior notice
  
  I don't find RepoApi as bad module - it is just convenient JS wrapper for PHP 
api  and aligns with how MW core is doing with mediawiki.api.  From client side 
(client in the meaning of browser, not in the meaning of Wikibase client) it is 
really useful as you can find it in entityChangers or any other client side  
Wikidata code. When there are multiple consumers for API module, it is better 
to split it from the UI module IMO.

TASK DETAIL
  https://phabricator.wikimedia.org/T259211

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: Lydia_Pintscher, 0x010C, vlsergey, Krinkle, Lucas_Werkmeister_WMDE, 
Ladsgroup, Aklapper, eranroz, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-03 Thread eranroz
eranroz added a comment.


  - Wikidata  (wikidata client only) and communities (frwiki, hewiki, ruwiki) 
code is misaligned by removing JS API interface to wikidata that is used by 
gadgets -> functionality broken ->  regression. to get it resolved we need to 
re-align them
- communities code can adapt to new API-less wikidata (develop their own 
wrappers to API)
- wikidata code can return removed code
- (or anything in between)
  
  Amir - the point that I think that is missed here is that API, unlike other 
modules is intended to expose functionality for developers for extending 
capabilities.
  If API is useful for Wikidata itself (entityChangers, edittoolbar, 
formatters, parsers, PageConnector) - it is useful.
  If API is deprecated for Wikidata itself - e.g in the long term we would like 
to get rid of it also in Wikidata repository itself
  
  There could be pros and cons for each direction (less JS code to maintain - 
keeping only mw.Api, more easily to locate code that use API etc - having 
mw.RepoApi, alignment to mw ecosystem with core/resources/src/mediawiki.api 
resources that expose API to JS). and I think a good discussion on this is 
missing, and this is not just "performance" which doesn't seem to be good 
argument in regards to API resource.
  
  Wikidata code that use RepoApi:
  
client/resources/jquery.wikibase/jquery.wikibase.linkitem.js
client/resources/wikibase.client.PageConnector.js
lib/resources/wikibase-api/Gruntfile.js
lib/resources/wikibase-api/README.md
lib/resources/wikibase-api/src/FormatValueCaller.js
lib/resources/wikibase-api/src/ParseValueCaller.js
lib/resources/wikibase-api/src/RepoApiError.js
lib/resources/wikibase-api/src/RepoApi.js
repo/resources/parsers/getApiBasedValueParserConstructor.js
repo/resources/parsers/getStore.js
repo/resources/Resources.php
repo/resources/wikibase.ui.entityViewInit.js
view/resources/jquery/wikibase/jquery.wikibase.entityselector.js
view/resources/jquery/wikibase/snakview/snakview.js
view/resources/jquery/wikibase/toolbar/jquery.wikibase.edittoolbar.js
view/resources.php
view/resources/wikibase/entityChangers/AliasesChanger.js
view/resources/wikibase/entityChangers/DescriptionsChanger.js
view/resources/wikibase/entityChangers/EntityChangersFactory.js
view/resources/wikibase/entityChangers/EntityTermsChanger.js
view/resources/wikibase/entityChangers/LabelsChanger.js
view/resources/wikibase/entityChangers/SiteLinksChanger.js
view/resources/wikibase/entityChangers/SiteLinkSetsChanger.js
view/resources/wikibase/entityChangers/StatementsChanger.js
view/resources/wikibase/store/store.ApiEntityStore.js
view/resources/wikibase/view/ToolbarViewController.js

TASK DETAIL
  https://phabricator.wikimedia.org/T259211

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: Lydia_Pintscher, 0x010C, vlsergey, Krinkle, Lucas_Werkmeister_WMDE, 
Ladsgroup, Aklapper, eranroz, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-02 Thread eranroz
eranroz added a project: Regression.

TASK DETAIL
  https://phabricator.wikimedia.org/T259211

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: Krinkle, Lucas_Werkmeister_WMDE, Ladsgroup, Aklapper, eranroz, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-02 Thread eranroz
eranroz added a comment.


  I don't find RepoApi as bad module - it get in the constructor the repository 
- repository could be Wikidata, or Commons or other Wikibase site.
  
  Also I don't agree with the arguments on heavy load - RepoApi can be lazy 
loaded on user action - upon pressing on linkitem.

TASK DETAIL
  https://phabricator.wikimedia.org/T259211

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: Krinkle, Lucas_Werkmeister_WMDE, Ladsgroup, Aklapper, eranroz, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T247712: Interwiki link problem on various wikis

2020-03-17 Thread eranroz
eranroz updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T247712

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: Robby, Urbanecm, Krinkle, hoo, eranroz, RhinosF1, Ammarpad, Vriullop, SJu, 
Paucabot, Reedy, Satirdan_kahraman, Yagizhan49, TmY_e12, HastaLaVi2, Aklapper, 
darthmon_wmde, Nandana, Lahi, Gq86, Cinemantique, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, 
jberkel, Psychoslave, Wong128hk, Wikidata-bugs, aude, GPHemsley, Shizhao, 
Nemo_bis, Lydia_Pintscher, Darkdadaah, Mbch331, Ltrlg, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T247808: Create sitelink is broken - lookup for current site is wrong

2020-03-16 Thread eranroz
eranroz added subscribers: Krinkle, hoo.
eranroz added a comment.


  @Krinkle  @hoo  -  digging further in wikibase source - the module 
registeration in Wikibase uses packageFiles and callback which I'm not that 
familiar with.
  Anyhow the callback function getSiteConfiguration in ClientHooks.php of 
wikibase uses cache... Do you have any suggestion what could explain it?

TASK DETAIL
  https://phabricator.wikimedia.org/T247808

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: hoo, Krinkle, Aklapper, eranroz, CptViraj, darthmon_wmde, Dibya, 94rain, 
DannyS712, Nandana, Tks4Fish, Jony, Lahi, Gq86, GoranSMilovanovic, 
Jayprakash12345, QZanden, Zoranzoki21, LawExplorer, Vali.matei, DatGuy, 
Devwaker, Niklitov, _jensen, Urbanecm, rosalieper, D3r1ck01, JEumerus, 
Scott_WUaS, Ananthsubray, Superzerocool, Tulsi_Bhagat, Wong128hk, Luke081515, 
Nirmos, SimmeD, Wikidata-bugs, Snowolf, aude, Dcljr, Dinoguy1000, 
Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T247808: Create sitelink is broken - lookup for current site is wrong

2020-03-16 Thread eranroz
eranroz created this task.
eranroz added projects: MediaWiki-extensions-WikibaseClient, 
Wikimedia-Site-requests, MediaWiki-ResourceLoader.
Restricted Application added a subscriber: Aklapper.
Restricted Application added projects: Wikidata, Performance-Team.

TASK DESCRIPTION
  Seems like adding sitelink from Wikibase client (aka Wikipedia) is broken - 
it looks up for wrong current site (for example hewiki thinks it is 
jawiktionary) and it isn't possible to link to other site.
  
  __How to reproduce__
  
  1. Go to page not connected to item such as: 
https://he.wikipedia.org/wiki/יעקב_טולידאנו_(קהלת_יעקב)?uselang=en
  2. Press "add links"
  3. in the site field fill enwiki - note it will suggest enwiktionary (not 
enwiki)
  
  __root cause__
  I couldn't determine the exact root cause, but quick debug point to
  
  > wikibase.client.linkitem.init.js
  
  and specifically this line: config = require( './config.json' ).currentSite
  
  returns wrong site. (maybe not deterministic - but at least once I saw 
jawiktionary instead of hewiki)
  
  I'm not sure what "require" points to - and whether this is just site 
configuration or code issue - so I'm adding all the suspects as tags

TASK DETAIL
  https://phabricator.wikimedia.org/T247808

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: Aklapper, eranroz, CptViraj, darthmon_wmde, Dibya, 94rain, DannyS712, 
Nandana, Tks4Fish, Jony, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, 
QZanden, Zoranzoki21, LawExplorer, Vali.matei, DatGuy, Devwaker, Niklitov, 
_jensen, Urbanecm, rosalieper, D3r1ck01, JEumerus, Scott_WUaS, Ananthsubray, 
Superzerocool, Tulsi_Bhagat, Wong128hk, Luke081515, Nirmos, SimmeD, 
Wikidata-bugs, Snowolf, aude, Dcljr, Dinoguy1000, Jdforrester-WMF, Matanya, 
Mbch331, Rxy, Jay8g, Krenair, MarcoAurelio, RhinosF1
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T233212: Merge wikibase.api.RepoApi and wikibase.api.getLocationAgnosticMwApi

2019-10-18 Thread eranroz
eranroz added a comment.


  Thanks Amir for the explanation. I understand the reason for refactoring the 
Wikibase modules, and this is good direction in general.
  
  I just ask for a stable way to access wikibase so it won't break every few 
weeks, and hooks aren't solution for wikibase clients. I opened a separate task 
T235913 <https://phabricator.wikimedia.org/T235913>  to avoid off topic 
discussion here.

TASK DETAIL
  https://phabricator.wikimedia.org/T233212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, eranroz
Cc: eranroz, Rosalie_WMDE, Aklapper, Ladsgroup, darthmon_wmde, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T235913: Define JS API to use Wikibase client

2019-10-18 Thread eranroz
eranroz created this task.
eranroz added projects: Documentation, MediaWiki-extensions-WikibaseClient.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  I would like to have a formal definition for JS API to access Wikibase from 
client which will be documented somewhere 
(https://www.mediawiki.org/wiki/Extension:Wikibase_Client or subpage) and will 
be stable way to acess API.
  
  Below are some valid options, and it's totally fine if we don't want to 
commit to them to define a new dedicated module ("wikibase.api").
  
// Option 1 (was working few months ago)
mw.loader.using( [ 'wikibase.api.RepoApi', 
'wikibase.client.getMwApiForRepo' ] ).done(function() {
var wikidataApi = new 
wikibase.api.RepoApi(wikibase.client.getMwApiForRepo());
}
// Option 2 (works now)
mw.loader.using( [ 'wikibase.api.RepoApi', 'mw.config.values.wbRepo' ] 
).done(function(){
var repoConfig = mw.config.get( 'wbRepo' );
var repoApi = new wikibase.api.RepoApi( 
wikibase.api.getLocationAgnosticMwApi(repoConfig.url + repoConfig.scriptPath + 
'/api.php') );

TASK DETAIL
  https://phabricator.wikimedia.org/T235913

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: Aklapper, eranroz, Pavithraes, darthmon_wmde, DannyS712, Nandana, Cpaulf30, 
Lahi, Gq86, GoranSMilovanovic, Ivana_Isadora, Jayprakash12345, QZanden, 
LawExplorer, _jensen, rosalieper, srodlund, Wikidata-bugs, aude, Dinoguy1000, 
Mbch331, Jay8g, Quiddity
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T233212: Merge wikibase.api.RepoApi and wikibase.api.getLocationAgnosticMwApi

2019-10-12 Thread eranroz
eranroz added a comment.


  I was using this RL and it just got disappear and broke gadgets that use it. 
  This breaks again wikidata usage, after "wikibase.client.getMwApiForRepo"  
was removed not long ago.
  
  For the next refactor - I suggest to first defined the end goal - so all 
gadgets can adapt to it and properly announce it.

TASK DETAIL
  https://phabricator.wikimedia.org/T233212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, eranroz
Cc: eranroz, Rosalie_WMDE, Aklapper, Ladsgroup, darthmon_wmde, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T131593: Supporting Hebrew calendar model in Wikidata

2019-08-17 Thread eranroz
eranroz added a comment.


  @daniel what do you think would be the best way to add other calenders for 
Wikibase from the model side? 
  (Hebrew calender 101 - it have 12 and in leap years 13 months)
  
  Is DataValues/TimeValue.php should refactored to be used for other calendars 
or subclassed for each calender? 
  (based on a quick look I see we serialize it based on timestamp described as 
"The actual format depends on the calendar model")
  
  And as next step after model is supported, what else aside from model else is 
required? (html formatter, time RDF builder, value parser?)

TASK DETAIL
  https://phabricator.wikimedia.org/T131593

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: Yair_rand, Geagea, PokestarFan, YonaB, IKhitron, daniel, Lydia_Pintscher, 
Aklapper, eranroz, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, 
Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, 
Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unassigned] T192462: mw.wikibase.entityExists returns false for redirected entities

2019-07-31 Thread eranroz
eranroz removed eranroz as the assignee of this task.
eranroz added a comment.


  Removing myself as asignee 
(https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/453148/ by 
Aleksey was merged more than 0.5 year ago and my gerrit item 
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/433952/ 
which use RevisionedUnresolvedRedirectException in 
WikiPageEntityRevisionLookup::getLatestRevisionId seems less relevant)

TASK DETAIL
  https://phabricator.wikimedia.org/T192462

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: eranroz, Ladsgroup, alaa_wmde, gerritbot, Aklapper, Uzume, Ahecht, 
Lydia_Pintscher, hoo, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, darthmon_wmde, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T221295: Wikidata changes doesn't appear in recent changes

2019-04-20 Thread eranroz
eranroz added a comment.


  Thanks for pointing to that issue. Seems it is the like the root cause and 
the current task is report about the symptom. Hence I'm closing it as 
duplicate.  If anyone notice any other similar issues, feel free to open a new 
task.

TASK DETAIL
  https://phabricator.wikimedia.org/T221295

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: mobrovac, Lydia_Pintscher, Nirmos, Aklapper, eranroz, alaa_wmde, Nandana, 
kostajh, Jony, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, 
LawExplorer, _jensen, rosalieper, Taiwania_Justo, Jonas, Wong128hk, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T221295: Wikidata changes doesn't appear in recent changes

2019-04-20 Thread eranroz
eranroz closed this task as a duplicate of T221368: cdnPurge and other jobs 
fail completely to execute.

TASK DETAIL
  https://phabricator.wikimedia.org/T221295

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: mobrovac, Lydia_Pintscher, Nirmos, Aklapper, eranroz, alaa_wmde, Nandana, 
kostajh, Jony, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, 
LawExplorer, _jensen, rosalieper, Taiwania_Justo, Jonas, Wong128hk, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T221295: Wikidata changes doesn't appear in recent changes

2019-04-18 Thread eranroz
eranroz added a comment.


  seems to happen again - no updates from Wikidata in the last 30 minutes in 
enwiki

TASK DETAIL
  https://phabricator.wikimedia.org/T221295

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: Lydia_Pintscher, Nirmos, Aklapper, eranroz, alaa_wmde, Nandana, kostajh, 
Jony, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, 
_jensen, rosalieper, Taiwania_Justo, Jonas, Wong128hk, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T221295: Wikidata changes doesn't appear in recent changes

2019-04-17 Thread eranroz
eranroz created this task.
eranroz added projects: MediaWiki-extensions-WikibaseClient, 
MediaWiki-Recent-changes.
Restricted Application added a subscriber: Aklapper.
Restricted Application added projects: Growth-Team, Wikidata.

TASK DESCRIPTION
  Since ~19:00-19:30 UTC time, 17/04/2019 Wikidata changes doesn't appear in 
recent changes of wikipedias:
  
  
https://en.wikipedia.org/wiki/Special:RecentChanges?hidepageedits=1&hidenewpages=1&hidecategorization=1&hidelog=1&limit=500&days=7&damaging__likelybad_color=c4&damaging__verylikelybad_color=c5&urlversion=2
  
https://he.wikipedia.org/wiki/%D7%9E%D7%99%D7%95%D7%97%D7%93:%D7%A9%D7%99%D7%A0%D7%95%D7%99%D7%99%D7%9D_%D7%90%D7%97%D7%A8%D7%95%D7%A0%D7%99%D7%9D?hidepageedits=1&hidenewpages=1&hidecategorization=1&hidelog=1&limit=1000&days=7&urlversion=2

TASK DETAIL
  https://phabricator.wikimedia.org/T221295

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eranroz
Cc: Aklapper, eranroz, alaa_wmde, Nandana, kostajh, Jony, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Taiwania_Justo, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T178249: Parameter for linking a new page to the Wikidata

2018-10-29 Thread eranroz
eranroz added a comment.
This is very good idea,. However, the task description is slightly too technical, e.g can someone add a kind of "user story" to explain how a regular user is expected to link between the article to be created and Wikidata entity? (I'm missing what, if any, user interface support for it should be made)

I imagine that the following UI components are to be affected:


wikitext editor - some additional field (possibly with autocomplete) to link to entity
#visualeditor - it should be possible in the advanced options to link article to item
#contenttranslation - content translation should be aware to it without explicitly setting the item.


If this is correct, this means 2 implementations in the backend side?


index.php?action="" - e.g for the classic usage
#restbase-api  the new contenttranslation is using REST-base and we need it there too (see also T199310)
TASK DETAILhttps://phabricator.wikimedia.org/T178249EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: eranroz, diego, IKhitron, SerDIDG, putnik, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T136599: [Epic] editing on client

2018-10-25 Thread eranroz
eranroz added a comment.
(This was discussed in WMTC18. See some notes in image 6 in T206085#4696219)TASK DETAILhttps://phabricator.wikimedia.org/T136599EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: eranroz, Lechatjaune, Florian, He7d3r, PokestarFan, Ita140188, Samat, Oliv0, Liuxinyu970226, T.seppelt, H4stings, Agabi10, MGChecker, Aklapper, Charlie_WMDE, Zppix, Lydia_Pintscher, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T155368: Add monolingual language code hbo (Biblical Hebrew)

2018-10-06 Thread eranroz
eranroz added a comment.
After trying to find resources about hbo I got even more confused - I'm not sure if this is even a language.

Assuming the formal definition for hbo is https://iso639-3.sil.org/code/hbo  and the links from there, I don't understand if hbo is a language or a blanket term for varieties of Hebrew used in ancient time.


Script - This may refer to different script of Hebrew (Paleo-Hebrew) as suggested in https://archive.org/details/rosettaproject_hbo_ortho-1 (refereed from http://www.language-archives.org/language/hbo ) but not necessarily (e.g not all ancient Hebrew use this script)
This may refer to Biblical Hebrew or Mishnaic Hebrew


I tried (unsuccessfully) to find usage examples:


https://en.wikipedia.org/wiki/Special:WhatLinksHere/Template:ISO_639_name_hbo - there is no actual usage (compare to https://en.wikipedia.org/wiki/Special:WhatLinksHere/Template:ISO_639_name_he )


However I can barely see some usages for lexams where a word in ancient Hebrew have different meaning then modern Hebrew - however in such cases this there is no option to have the distinction between Biblical Hebrew and Mishnaic Hebrew as they are both hbo?TASK DETAILhttps://phabricator.wikimedia.org/T155368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: eranroz, ArthurPSmith, WMDE-leszek, Lucas_Werkmeister_WMDE, Amire80, gerritbot, Mbch331, PokestarFan, Esc3300, Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter, CucyNoiD, Nandana, NebulousIris, Kieubinhtb, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, tabish.shaikh91, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, merbst, LawExplorer, Lewizho99, Maathavan, TerraCodes, D3r1ck01, MuhammadShuaib, SimmeD, Wikidata-bugs, aude, TheDJ___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T187265: Enable xkill on top wikis that use x aspect

2018-06-15 Thread eranroz
eranroz added a comment.

Seems like Amir fixed it few months ago. Amir, do you think we can close it?
Looking in graphana boards, there is unexpectedly high number of usages in cebwiki(?!)
TASK DETAILhttps://phabricator.wikimedia.org/T187265EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, eranrozCc: eranroz, Stashbot, gerritbot, Aklapper, Lydia_Pintscher, Cosine02, Ladsgroup, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Merged] T195520: Multiple projects reporting Cannot access the database: No working replica DB server

2018-05-25 Thread eranroz
eranroz merged a task: T195642: Lookup by property label for {{#property}} and {{#statements}} is broken (WMF production environment).
TASK DETAILhttps://phabricator.wikimedia.org/T195520EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: eranroz, MichaelSchoenitzer_WMDE, Tractopelle-jaune, Florian, Jeff_G, Vachovec1, Tbayer, Ivanhercaz, Lixxx235, Stashbot, Addshore, MrFulano, daniel, Lydia_Pintscher, Tarawneh, PetrohsW, Sunpriat2, Ladsgroup, Legoktm, gerritbot, Thryduulf, matmarex, Krenair, dgstranz, Cirdan, Amorymeltzer, Yarl, Doc_James, Masti, Wiki-1776, Baloch007, abian, Pigsonthewing, putnik, Classicwiki, Jarekt, Jayprakash12345, 1339861mzb, KTC, Bharel, Daimona, Smartyllama, ToBeFree, Paladox, Urbanecm, Davey2010, alanajjar, Mh-3110, Lucas_Werkmeister_WMDE, JEumerus, Samtar, Lofhi, Marostegui, TerraCodes, Liuxinyu970226, Framawiki, Mainframe98, Stryn, Aklapper, Boshomi, Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Zppix, Maathavan, Wong128hk, Wikidata-bugs, aude, ArielGlenn, faidon, He7d3r, Jdforrester-WMF, Mbch331, Jay8g, fgiunchedi, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T195642: Lookup by property label for {{#property}} and {{#statements}} is broken (WMF production environment)

2018-05-25 Thread eranroz
eranroz closed this task as a duplicate of T195520: Multiple projects reporting Cannot access the database: No working replica DB server.
TASK DETAILhttps://phabricator.wikimedia.org/T195642EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Legoktm, Aklapper, eranroz, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, Wong128hk, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T195642: Lookup by property label for {{#property}} and {{#statements}} is broken (WMF production environment)

2018-05-25 Thread eranroz
eranroz added a comment.
May be related to T195520TASK DETAILhttps://phabricator.wikimedia.org/T195642EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Aklapper, eranroz, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, Wong128hk, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T195642: Lookup by property label for {{#property}} and {{#statements}} is broken (WMF production environment)

2018-05-25 Thread eranroz
eranroz added a project: Operations.
TASK DETAILhttps://phabricator.wikimedia.org/T195642EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Aklapper, eranroz, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, Wong128hk, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T195642: Lookup by property label for {{#property}} and {{#statements}} is broken (WMF production environment)

2018-05-25 Thread eranroz
eranroz created this task.eranroz added projects: Wikidata, MediaWiki-extensions-WikibaseClient.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONHow to reproduce:


Edit: https://en.wikipedia.org/w/index.php?title=Berlin
Enter:


{{#property:coordinate location}}

{{#statements:coordinate location}}

{{#property:P625}}


Press "show preview"


Expected: 3x coordinates of Berlin
Actual:

Failed to render property coordinate location: Property not found for label 'coordinate location' and language 'en'

Failed to render property coordinate location: Property not found for label 'coordinate location' and language 'en'

52°31'N, 13°23'E

On Wikibase latest code, this seem to be OK. (client/tests/phpunit/includes/DataAccess/ParserFunctions/PropertyParserFunctionIntegrationTest.php pass)TASK DETAILhttps://phabricator.wikimedia.org/T195642EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Aklapper, eranroz, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T195440: Special:NewLexeme - confusing "Lexical category"

2018-05-23 Thread eranroz
eranroz created this task.eranroz triaged this task as "Normal" priority.eranroz added projects: Wikidata, Lexicographical data.
TASK DESCRIPTIONFollowing the fix in T164583, there are many confusing options. This should probably have closed options (compatible with constraints?) as it isn't quite clear what to fill there. If you write "noun" it suggest too many non relevant options (such as Noun (Q2445359)). The description is not displayed, which make it even more confusing.

How to reproduce:


https://www.wikidata.org/wiki/Special:NewLexeme
In "Lexical category" enter "Noun"
TASK DETAILhttps://phabricator.wikimedia.org/T195440EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Lydia_Pintscher, Aklapper, Jan_Dittrich, daniel, Ladsgroup, gerritbot, VIGNERON, Micru, Jakob_WMDE, thiemowmde, eranroz, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T195439: Special:NewLexeme - confusing placeholder text

2018-05-23 Thread eranroz
eranroz created this task.eranroz triaged this task as "High" priority.eranroz added projects: Wikidata, Lexicographical data.
TASK DESCRIPTIONSpecial:NewLexeme in Wikidata as of May 2018:  "Language of Lexeme" - the placeholder says "enter item ID e.g Q10" - people don't know IDs. Instead it should be "Enter language" (suggester anyway translated it to ID under the hood)TASK DETAILhttps://phabricator.wikimedia.org/T195439EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Lydia_Pintscher, Aklapper, Jan_Dittrich, daniel, Ladsgroup, gerritbot, VIGNERON, Micru, Jakob_WMDE, thiemowmde, eranroz, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T195439: Special:NewLexeme - confusing placeholder text

2018-05-23 Thread eranroz
eranroz added a project: Easy.
TASK DETAILhttps://phabricator.wikimedia.org/T195439EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Lydia_Pintscher, Aklapper, Jan_Dittrich, daniel, Ladsgroup, gerritbot, VIGNERON, Micru, Jakob_WMDE, thiemowmde, eranroz, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, TerraCodes, MuhammadShuaib, SimmeD, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T195415: Special:NewItem - fields direction should be defined according to the language

2018-05-23 Thread eranroz
eranroz created this task.eranroz added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, RTL.Herald added a subscriber: Aklapper.Herald added a project: I18n.
TASK DESCRIPTIONCurrently fields direction is according to the language (e.g wgLanguageCode), but it should be according to the language user selected in the Language field.

How to reproduce:


Enter to Special:NewItem: https://www.wikidata.org/wiki/Special:NewItem
In Language select Arabic or Hebrew
Expected: Label / Description etc should be RTL direction


Actual: they are LTRTASK DETAILhttps://phabricator.wikimedia.org/T195415EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Ladsgroup, Amire80, Aklapper, eranroz, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Huji, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T157868: Lua functions do not resolve redirects

2018-05-19 Thread eranroz
eranroz added a comment.

In T157868#4142305, @Uzume wrote:
This might get resolved by T112658.


Tested it (for label) with the patchset suggested in T112658 but this will not resolve it - requiring a different fix as part of T142950TASK DETAILhttps://phabricator.wikimedia.org/T157868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: eranroz, Uzume, Salgo60, Larske, hoo, matej_suchanek, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T112658: [Task] WikiPageEntityRevisionLookup::getLatestRevisionId() should throw an UnsersolvedRedirectException when encountering a redirect.

2018-05-19 Thread eranroz
eranroz claimed this task.eranroz added a comment.
I got to this task while debugging a related issue with mw.wikibase.entityExists(REDIRECT-Qid) - T192462TASK DETAILhttps://phabricator.wikimedia.org/T112658EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: eranroz, gerritbot, Aklapper, daniel, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T192462: mw.wikibase.entityExists returns false for redirected entities

2018-05-19 Thread eranroz
eranroz claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T192462EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: gerritbot, Aklapper, Uzume, Ahecht, Lydia_Pintscher, hoo, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T189972: In RTL UI, dragging the Wikidata Query UI splitter left moves it right and vice versa

2018-05-05 Thread eranroz
eranroz closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T189972EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: gerritbot, Jonas, Smalyshev, eranroz, Amire80, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, Srdjan_m, Xmlizer, MuhammadShuaib, LNDDYL, Psychoslave, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Gryllida, Shizhao, Lydia_Pintscher, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unblock] T178057: Wikidata Query UI: RTL Issues

2018-05-05 Thread eranroz
eranroz closed subtask T189972: In RTL UI, dragging the Wikidata Query UI splitter left moves it right and vice versa as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T178057EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Amire80, Liuxinyu970226, gerritbot, eranroz, Smalyshev, Jonas, Aklapper, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Jayprakash12345, QZanden, EBjune, merbst, LawExplorer, Srdjan_m, Xmlizer, MuhammadShuaib, LNDDYL, Psychoslave, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Gryllida, Shizhao, Lydia_Pintscher, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T189972: In RTL UI, dragging the Wikidata Query UI splitter left moves it right and vice versa

2018-04-29 Thread eranroz
eranroz claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T189972EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Jonas, Smalyshev, eranroz, Amire80, Aklapper, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Jayprakash12345, QZanden, EBjune, merbst, LawExplorer, Srdjan_m, Xmlizer, MuhammadShuaib, LNDDYL, Psychoslave, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Gryllida, Shizhao, Lydia_Pintscher, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T192136: Supporting PGN chess notation data

2018-04-19 Thread eranroz
eranroz added a subscriber: Esc3300.eranroz added a comment.
thanks to @Esc3300 for indicating it - a somewhat similar issue related to string length is discussed in T154660 (suggested 4000 => more than 300 moves, which is definitely enough)TASK DETAILhttps://phabricator.wikimedia.org/T192136EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Esc3300, Kipod, eranroz, Aklapper, Yurik, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, debt, Reasno, Wikidata-bugs, Base, aude, jayvdb, zhuyifei1999, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T123857: RTL with LTR in edit summaries breaks

2018-04-16 Thread eranroz
eranroz added a comment.
Notes:


This works based on user language, not sitelang (e.g uselang can workaround it: https://www.wikidata.org/w/index.php?title=Q3013215&curid=2880827&diff=292663898&oldid=250877025&uselang=fa )
Setting the directionality should be to the sitelang without the site prefix e.g [[fa:FATITLE]]
TASK DETAILhttps://phabricator.wikimedia.org/T123857EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: eranroz, samuwmde, Aklapper, Ainali, StudiesWorld, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Huji, Amire80, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T190863: Property deletion notifier bot

2018-04-15 Thread eranroz
eranroz closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T190863EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Lydia_Pintscher, Pasleim, Aklapper, eranroz, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T192198: Wikidata doesn't update recentchanges

2018-04-13 Thread eranroz
eranroz updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...```

(May beLikely related to T184791?): T192085TASK DETAILhttps://phabricator.wikimedia.org/T192198EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Aklapper, Ladsgroup, eranroz, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T192198: Wikidata doesn't update recentchanges

2018-04-13 Thread eranroz
eranroz created this task.eranroz added projects: Wikidata, MediaWiki-extensions-WikibaseClient, MediaWiki-Recent-changes.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONOn hewik/cawiki (and probably many others) Wikidata doesn't update recentchanges, as it appears in the DB query below:

use hewiki_p;
select rc_timestamp, now() from recentchanges where rc_source='wb' order by rc_timestamp desc limit 5;
++-+
| rc_timestamp   | now()   |
++-+
| 20180412143955 | 2018-04-14 05:01:39 |
| 20180412143842 | 2018-04-14 05:01:39 |
| 20180412143811 | 2018-04-14 05:01:39 |
| 20180412143802 | 2018-04-14 05:01:39 |
| 20180412143756 | 2018-04-14 05:01:39 |
++-+

(May be related to T184791?)TASK DETAILhttps://phabricator.wikimedia.org/T192198EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Aklapper, Ladsgroup, eranroz, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T192136: Supporting PGN chess notation data

2018-04-12 Thread eranroz
eranroz created this task.eranroz added projects: Wikidata, Commons-Datasets.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONWe are seeking for option to store chess games (PGN format; without comments) to be shared between wikis.

Example:

1. e4 e5 2. f4 exf4 3. Bc4 Qh4 4. Kf1 b5 5. Bxb5 Nf6 6. Nf3 Qh6 7. d3 Nh5 8. Nh4 Qg5 9. Nf5 c6 10. g4 Nf6 11. Rg1 cxb5 12. h4 Qg6 13. h5 Qg5 14. Qf3 Ng8 15. Bxf4 Qf6 16. Nc3 Bc5 17. Nd5 Qxb2 18. Bd6 Bxg1 19. e5 Qxa1 20. Ke2 Na6 21. Nxg7 Kd8 22. Qf6 Nxf6 23. Be7

See relevant discussion here: Wikidata:Property proposal/Portable Game Notation.

Wikidata


Assuming each move takes 8-12 chars, and a common game takes 30-40 moves, and long game takes 60 moves => a string of 720 chars is probably safe enough for most games.
Current limitation for Wikidata string (hardcoded defined in ValidatorBuilders::getCommonStringValidators)  is 400 =>which supports 33-50 moves


Hence to support it in wikidata, we need to have a new type (medium/long length string) with different validator

Alternatives
If we believe it is (technical) abuse of wikidata to store medium length strings, it might be possible to store it in Commons, and refer it from Wikidata.


This mean Commons support for pgn (maybe somewhat similar to Tabular Data/Map data) and once we have such option, to add a new property type for linking it similar to tabular/map data


(maybe @Yurik can give good comments regarding this alternative)TASK DETAILhttps://phabricator.wikimedia.org/T192136EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Kipod, eranroz, Aklapper, Yurik, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, debt, Reasno, Wikidata-bugs, Base, aude, jayvdb, zhuyifei1999, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Reopened] T35704: GeoData should pull coordinates from Wikidata on sites with the Wikibase Client

2018-04-04 Thread eranroz
eranroz reopened this task as "Open".eranroz added a comment.
@LGoto  , is it fixed?
I don't see @Nemo_bis fix ( https://gerrit.wikimedia.org/r/#/c/165869/3 ) as merged and I don't see any reason for closing itTASK DETAILhttps://phabricator.wikimedia.org/T35704EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MaxSem, eranrozCc: LGoto, TheDJ, Salgo60, PokestarFan, Aschroet, jeremyb, Aklapper, Ricordisamoa, Nastoshka, Amire80, Krenair, Elitre, Nemo_bis, bearND, He7d3r, Tfinc, Dbrant, Deskana, Multichill, wikibugs-l-list, eranroz, MaxSem, Lydia_Pintscher, Nikerabbit, KLans_WMF, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Sharvaniharan, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T190863: Property deletion notifier bot

2018-03-28 Thread eranroz
eranroz claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T190863EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Pasleim, Aklapper, eranroz, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T190863: Property deletion notifier bot

2018-03-28 Thread eranroz
eranroz added a comment.
Here is a simple script to get it (assuming labdb access): 
https://github.com/eranroz/wikidata-property-deletion

This isn't efficient, but works, and assuming property deletions are quite rare it might be enough for now.TASK DETAILhttps://phabricator.wikimedia.org/T190863EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Pasleim, Aklapper, eranroz, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T190863: Property deletion notifier bot

2018-03-27 Thread eranroz
eranroz created this task.eranroz added a project: Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONSometimes there are good reasons to delete Wikidata property (either replaced by a different one, duplicate, etc). Wikidata admins are unable to safely delete the property and be sure all client wikis don't use this property. Without doing it properly, this may result in harmful affects on wide number of wiki pages.

See for example: https://www.wikidata.org/wiki/Wikidata:Properties_for_deletion#Property:P2439

With the recent improvements to usage tracking, it becomes possible (though still somewhat hackish) to locate all usage using wbc_entity_usage, querying on the property to be deleted. However, it does requires to iterate over all client wikis which is quite inefficient - though feasible assuming deletions of properties are rare.

Hence we need either a bot or a web tool or even wb-repo extension to provide a list of usages of a property, and possibly notify relevant communities.TASK DETAILhttps://phabricator.wikimedia.org/T190863EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Pasleim, Aklapper, eranroz, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T182147: more convenience functions for Lua

2018-03-27 Thread eranroz
eranroz added a comment.

In T182147#4083789, @NehalDaveND wrote:
Sanskrit community wants counting in Devanagari digit, but we can't get the support till now. I think by Lua you can add the facility into Sanskrit wikis.

https://sa.wikipedia.org/wiki/%E0%A4%B5%E0%A4%BF%E0%A4%95%E0%A4%BF%E0%A4%AA%E0%A5%80%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4%BE:%E0%A4%B8%E0%A4%AE%E0%A5%81%E0%A4%A6%E0%A4%BE%E0%A4%AF%E0%A4%AA%E0%A5%8D%E0%A4%B0%E0%A4%B5%E0%A5%87%E0%A4%B6%E0%A4%A6%E0%A5%8D%E0%A4%B5%E0%A4%BE%E0%A4%B0%E0%A4%AE%E0%A5%8D#%E0%A4%A6%E0%A5%87%E0%A4%B5%E0%A4%A8%E0%A4%BE%E0%A4%97%E0%A4%B0%E0%A5%80-%E0%A4%85%E0%A4%99%E0%A5%8D%E0%A4%95%E0%A4%AE%E0%A5%8D_%E0%A4%89%E0%A4%A4%E0%A5%8D%E0%A4%B8%E0%A4%B0%E0%A5%8D%E0%A4%97%E0%A4%A4%E0%A5%8D%E0%A4%B5%E0%A5%87%E0%A4%A8_%E0%A4%B8%E0%A5%8D%E0%A4%A5%E0%A4%BE%E0%A4%AA%E0%A4%AF%E0%A4%BF%E0%A4%A4%E0%A5%81%E0%A4%AE%E0%A5%8D


@NehalDaveND Can you please clarify how it relates to Wikidata?TASK DETAILhttps://phabricator.wikimedia.org/T182147EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: NehalDaveND, Lea_Lacroix_WMDE, jberkel, RolandUnger, Agabi10, RexxS, Vriullop, MisterSynergy, Ghuron, Uzume, putnik, Jonas, aude, hoo, Ladsgroup, Tpt, thiemowmde, eranroz, Aklapper, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189506: Evaluate usages of mw.wikibase.getEntity

2018-03-20 Thread eranroz
eranroz added a comment.
Maybe we can start with greping all WMF wikis for it

mwgrep "getEntity"TASK DETAILhttps://phabricator.wikimedia.org/T189506EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, eranrozCc: eranroz, Aklapper, hoo, Lahi, Gq86, GoranSMilovanovic, lisong, QZanden, LawExplorer, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T178057: Wikidata Query UI: RTL Issues

2018-03-18 Thread eranroz
eranroz added a comment.
Thanks Amir. I updated the task description and removed this.TASK DETAILhttps://phabricator.wikimedia.org/T178057EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Amire80, Liuxinyu970226, gerritbot, eranroz, Smalyshev, Jonas, Aklapper, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Jayprakash12345, QZanden, EBjune, merbst, LawExplorer, Srdjan_m, Xmlizer, MuhammadShuaib, LNDDYL, Psychoslave, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Gryllida, Shizhao, Lydia_Pintscher, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T178057: Wikidata Query UI: RTL Issues

2018-03-18 Thread eranroz
eranroz updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- [ ] Dropdown menus show left alignment (it may be valid for "tools", as tools have Latin names, and wrong for "help")
- [ ] It may be more correct to have the arrow icon mirrored in RTL
- [x] [X of the query helper should float left not right](https://gerrit.wikimedia.org/r/386225)...TASK DETAILhttps://phabricator.wikimedia.org/T178057EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Amire80, Liuxinyu970226, gerritbot, eranroz, Smalyshev, Jonas, Aklapper, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Jayprakash12345, QZanden, EBjune, merbst, LawExplorer, Srdjan_m, Xmlizer, MuhammadShuaib, LNDDYL, Psychoslave, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Gryllida, Shizhao, Lydia_Pintscher, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T178114: Many Wikipedia's Wikidata module iterate over all entity claims if a Statement is searched for by property label

2018-03-02 Thread eranroz
eranroz added a comment.
I think this task can be considered as resolved  (mainly thanks to T185693) from engineering POV.
If there are still wikis using such iterations - they should fix it, but it is now on their (community) hands.
I suggest that before moving this task to resolved, we should ask #Community-Liaisons to communicate to wikis to be aware to it.

Anyway, we should keep an open eyes on wikis with abnormal usage tracking - this may be more fruitful and surely more fun to do with ML/outliers detection based on the data (wbc_entity_usage) rather than greping the code :)

BTW  I fixed it in the following diffs for some wikis:

MW template:
https://www.mediawiki.org/w/index.php?title=Module:Wikidata&diff=2728318&oldid=2412211

Wikipedias and other projects (not all projects...):
https://sq.wikipedia.org/w/index.php?title=Moduli:Wikidata&diff=1844990&oldid=1757199
https://ps.wikipedia.org/w/index.php?title=Module:Wikidata&diff=prev&oldid=217026
https://ne.wikipedia.org/w/index.php?title=%E0%A4%AE%E0%A5%8B%E0%A4%A1%E0%A5%8D%E0%A4%AF%E0%A5%81%E0%A4%B2:Wikidata&diff=prev&oldid=633773
https://mn.wikipedia.org/w/index.php?title=Module:Wikidata&diff=prev&oldid=538250
https://mk.wikipedia.org/w/index.php?title=%D0%9C%D0%BE%D0%B4%D1%83%D0%BB:Wikidata&diff=prev&oldid=3689944
https://lv.wikipedia.org/w/index.php?title=Modulis:Wikidata&diff=prev&oldid=2816246
https://lt.wikipedia.org/w/index.php?title=Module:Wikidata&diff=prev&oldid=5336632
https://pt.wikivoyage.org/w/index.php?title=M%C3%B3dulo:Wikidata&diff=prev&oldid=123281
https://hi.wikipedia.org/w/index.php?title=Module:Wikidata&diff=prev&oldid=3728109
https://en.wiktionary.org/w/index.php?title=Module:wikidata&diff=prev&oldid=49084837
https://bs.wikipedia.org/w/index.php?title=Modul:Wikidata&diff=prev&oldid=2914902TASK DETAILhttps://phabricator.wikimedia.org/T178114EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Ladsgroup, Capankajsmilyo, gerritbot, Aklapper, eranroz, daniel, Lydia_Pintscher, hoo, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T186629: Language link changed from X to Y links to wrong URL

2018-02-12 Thread eranroz
eranroz added a comment.

The URL in the recent changes points to wrong URL


I can't reproduce it (looking on Special:Logs/move to find recent moves, and looking for the relevant "Language link changed from $1 to $2" messages - seems like those are correct links. I guess this was due to different versions(?) but anyway this is not reproducible/invalid.


The change shouldn't propagate to the original wiki(?) as it already updated


This can be reproduced by going to Special:Log/move (in some client wiki), select some article that is linked to wikidata, and search for it in the recent changes.TASK DETAILhttps://phabricator.wikimedia.org/T186629EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Lea_Lacroix_WMDE, thiemowmde, IKhitron, Aklapper, eranroz, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T186629: Language link changed from X to Y links to wrong URL

2018-02-06 Thread eranroz
eranroz updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...1. The URL is in the recent changes ispoints to wrong URL
2. The change shouldn't propagate to the original wiki(?) as it already updated TASK DETAILhttps://phabricator.wikimedia.org/T186629EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: IKhitron, Aklapper, eranroz, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T186629: Language link changed from X to Y links to wrong URL

2018-02-06 Thread eranroz
eranroz created this task.eranroz added projects: MediaWiki-extensions-WikibaseClient, Wikidata, MediaWiki-Recent-changes.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONWhen changing a page X to Y that is connected to wikidata, the sitelinks is automatically updated, and the change is propagated correctly to other wikis generating "Language link changed from $1 to $2" message in recent changes. Additionally the change is propagated WRONGLY to the original site where there was a move - and links to invalid URLs for example:


This change: https://www.wikidata.org/w/index.php?title=Special:EntityPage/Q1186451&curid=1131433&diff=627491344&oldid=459038914
Result in link to: https://www.wikidata.org/wiki/%D7%93%D7%95%D7%97_%D7%A2%D7%9C_%D7%94%D7%A9%D7%99%D7%A0%D7%95%D7%99%D7%99%D7%9D_%D7%91%D7%94%D7%95%D7%9F_%D7%94%D7%A2%D7%A6%D7%9E%D7%99 (as appear in recent changes)


So we have here 2 issues:


The URL is in the recent changes is wrong
The change shouldn't propagate to the original wiki(?) as it already updated
TASK DETAILhttps://phabricator.wikimedia.org/T186629EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: IKhitron, Aklapper, eranroz, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T186308: "Your skin is incompatible with VisualEditor" in Wikidata

2018-02-02 Thread eranroz
eranroz added a comment.
The first question would be are wikidata sure they want wgIsArticle to be true on item pages?

I suppose this is correct, usually the main/content namespace is "wgIsArticle" (I dont know of any wiki site for which it is false in the main NS).
Possibly this warning can be shown also based on a check with wgVisualEditorConfig.namespaces?TASK DETAILhttps://phabricator.wikimedia.org/T186308EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Esanders, jhsoby, Aklapper, eranroz, Lahi, Gq86, Necroarcano, Robinma, GoranSMilovanovic, QZanden, merbst, LawExplorer, Wess, Srdjan_m, Jrf, Husun1297, Wikidata-bugs, aude, Deskana, Swainr, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T185693: Implement a (more liberal) usage aspect deduplicater (days: 1)

2018-01-26 Thread eranroz
eranroz added a comment.

In T185693#3923455, @daniel wrote:
I think we need different limits for different aspects. 10 may be sensible for statements, but it's way too low for languages.


Was looking on cawiki_p to see it in the real world:
F12804275: claims_usage.png
Based on cawiki_p.wbc_entity_usage for claims with 3 < C threshold <=25 - we cover ~80% of the usages (80% of the C rows are due to using more than 25 claims from same entity if I did it correctly)
I suggest to revisit T151717 after deploying it.TASK DETAILhttps://phabricator.wikimedia.org/T185693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, eranrozCc: Lucas_Werkmeister_WMDE, gerritbot, eranroz, hoo, daniel, Lydia_Pintscher, aude, Aklapper, Ladsgroup, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T172914: [Tracking] Fine-grained change notifications based on tracking from Lua getters via __index

2018-01-22 Thread eranroz
eranroz added a comment.
After 2 weeks:

use hewiki_p;
select eu_aspect,count(*) from wbc_entity_usage group by eu_aspect ;
+---+--+
| eu_aspect | count(*) |
+---+--+
| D.en  |   17 |
| D.he  |  424 |
| L |1 |
| L.en  |65293 |
| L.he  |   539313 |
| O |   308782 |
| S |   294197 |
| T |   374019 |
| X |   13 |
+---+--+

X is almost eliminated

For recent changes: slightly less wb changes

`
| 20180108 | 2305 | 7906 | 0.2916 |
| 20180109 | 2214 | 7941 | 0.2788 |
| 20180110 | 2220 | 8984 | 0.2471 |
| 20180111 | 2119 | 7696 | 0.2753 |
| 20180112 | 1678 | 6434 | 0.2608 |
| 20180113 | 1479 | 6103 | 0.2423 |
| 20180114 | 1721 | 7928 | 0.2171 |
| 20180115 | 1399 | 7425 | 0.1884 |
| 20180116 | 1712 | 8769 | 0.1952 |
| 20180117 | 2994 |11005 | 0.2721 |
| 20180118 | 1910 | 7166 | 0.2665 |
| 20180119 | 2393 |10985 | 0.2178 |
| 20180120 | 1686 | 6439 | 0.2618 |
| 20180121 | 2189 | 7328 | 0.2987 |
| 20180122 | 4135 | 9622 | 0.4297 |TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: jcrespo, Marostegui, Ladsgroup, Stashbot, Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T166056: Add mw.wikibase.entity:getStatements for convenience

2018-01-16 Thread eranroz
eranroz added a comment.

In T166056#3904924, @Billinghurst wrote:
has the functionality here been added to an FAQ or help pages on Wikidata and/or Meta?


I just updated https://www.mediawiki.org/wiki/Extension:Wikibase_Client/LuaTASK DETAILhttps://phabricator.wikimedia.org/T166056EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Billinghurst, gerritbot, Lydia_Pintscher, Aklapper, TerraCodes, hoo, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, MuhammadShuaib, SimmeD, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T184889: changes of sitelinks of other projects generate RC entry on client wiki

2018-01-14 Thread eranroz
eranroz added a parent task: T90435: [Epic] Wikidata watchlist improvements (client).
TASK DETAILhttps://phabricator.wikimedia.org/T184889EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: IKhitron, Aklapper, eranroz, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T184889: changes of sitelinks of other projects generate RC entry on client wiki

2018-01-14 Thread eranroz
eranroz created this task.eranroz added projects: Wikidata, MediaWiki-extensions-WikibaseClient, MediaWiki-Watchlist.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONScenario:


Suppose a page X in he.wikipedia is linked to Wikidata
Page X exists also on fr.wikibooks
Adding/removing/changing a sitelink of frwikibooks SHOULD NOT result in client wiki having rc entry as: 3.1 this is neither different language in same project 3.2 nor different project in same language


Real world example:
this change https://www.wikidata.org/w/index.php?title=Q3907246&diff=620412971&oldid=620386285
was propogated to hewiki

use hewiki_p;
select * from recentchanges where rc_namespace=4 and rc_title like 'בקשות_ממפעילים' and rc_source='wb' and rc_timestamp>2018011300 limit 5;

rc_id	rc_timestamp	rc_user	rc_user_text	rc_namespace	rc_title	rc_comment	rc_minor	rc_bot	rc_new	rc_cur_id	rc_this_oldid	rc_last_oldid	rc_type	rc_source	rc_patrolled	rc_ip	rc_old_len	rc_new_len	rc_deleted	rc_logid	rc_log_type	rc_log_action	rc_params
39989282	20180114215852	60068	JackPotte	4	בקשות_ממפעילים	קישור השפה שוּנה מ־frwikibooks:Wikilivres:Requêtes aux administrateurs אל frwikibooks:Wikilivres:Requêtes aux administrateurs/2018	1	0	0	191513	22258311	22258311	5	wb	1		3279	3279	0	0			a:1:{s:20:"wikibase-repo-change";a:14:{s:2:"id";i:617157977;s:4:"time";s:14:"20180114215852";s:7:"user_id";s:4:"7431";s:11:"revision_id";s:9:"620386285";s:9:"object_id";s:8:"Q3907246";s:4:"type";s:20:"wikibase-item~update";s:11:"entity_type";s:4:"item";s:7:"page_id";i:3727984;s:9:"parent_id";i:615576452;s:7:"comment";s:152:"/* clientsitelink-update:0|frwikibooks|frwikibooks:Wikilivres:Requêtes aux administrateurs|frwikibooks:Wikilivres:Requêtes aux administrateurs/2018 */";s:6:"rev_id";i:620386285;s:9:"user_text";s:9:"JackPotte";s:15:"central_user_id";i:14889;s:3:"bot";i:0;}}
39989564	20180114232354	310221	NicoScribe	4	בקשות_ממפעילים	קישור השפה שוּנה מ־frwikibooks:Wikilivres:Requêtes aux administrateurs/2018 אל frwikibooks:Wikilivres:Requêtes aux administrateurs	1	0	0	191513	22258403	22258403	5	wb	1		2380	2380	0	0			a:1:{s:20:"wikibase-repo-change";a:14:{s:2:"id";i:617184399;s:4:"time";s:14:"20180114232354";s:7:"user_id";s:7:"2217048";s:11:"revision_id";s:9:"620412971";s:9:"object_id";s:8:"Q3907246";s:4:"type";s:20:"wikibase-item~update";s:11:"entity_type";s:4:"item";s:7:"page_id";i:3727984;s:9:"parent_id";i:620386285;s:7:"comment";s:71:"/* undo:0||620386285|JackPotte */ it is better to keep the generic page";s:6:"rev_id";i:620412971;s:9:"user_text";s:10:"NicoScribe";s:15:"central_user_id";i:43246739;s:3:"bot";i:0;}}
`TASK DETAILhttps://phabricator.wikimedia.org/T184889EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: IKhitron, Aklapper, eranroz, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T90435: [Epic] Wikidata watchlist improvements (client)

2018-01-14 Thread eranroz
eranroz added a subtask: T184889: changes of sitelinks of other projects generate RC entry on client wiki.
TASK DETAILhttps://phabricator.wikimedia.org/T90435EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Zache, Noella94, Elitre, PokestarFan, Tbayer, Aschroet, IKhitron, Esh77, TomT0m, Oliv0, abian, Daniel_Mietchen, Soisyc_Croisic, H4stings, Ricordisamoa, matej_suchanek, MGChecker, Sitic, JanZerebecki, Conny, Snaterlicious, Liuxinyu970226, Quiddity, Rschen7754, Ainali, MisterSynergy, Lydia_Pintscher, Aklapper, daniel, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T178114: Many Wikipedia's Wikidata module iterate over all entity claims if a Statement is searched for by property label

2018-01-10 Thread eranroz
eranroz added a comment.

In T178114#3888964, @Ladsgroup wrote:
This will go live this week, Would be good to measure the impact.


The above patch (383990) doesn't have any impact. wikis have to adopt it, and this is just a convenient method to avoid improper property usageTASK DETAILhttps://phabricator.wikimedia.org/T178114EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Ladsgroup, Capankajsmilyo, gerritbot, Aklapper, eranroz, daniel, Lydia_Pintscher, hoo, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T172914: [Tracking] Fine-grained change notifications based on tracking from Lua getters via __index

2018-01-08 Thread eranroz
eranroz added a comment.
Just after enabling (to be compared in few days)

select eu_aspect,count(*) from wbc_entity_usage group by eu_aspect ;
+---+--+
| eu_aspect | count(*) |
+---+--+
| D.en  |5 |
| D.he  |   46 |
| L |1 |
| L.en  |61589 |
| L.he  |   518217 |
| O |   280012 |
| S |   293351 |
| T |   354842 |
| X |24498 |
+---+--+
select left(rc_timestamp,8), sum(if(rc_source='wb',1,0)) as WB, count(*),sum(if(rc_source='wb',1,0))/count(*) as RATIO from recentchanges group by left(rc_timestamp,8);
+--+--+--++
| left(rc_timestamp,8) | WB   | count(*) | RATIO  |
+--+--+--++
| 20171209 |  441 | 1613 | 0.2734 |
| 20171210 | 4343 |10381 | 0.4184 |
| 20171211 | 3399 | 9134 | 0.3721 |
| 20171212 | 3452 | 8607 | 0.4011 |
| 20171213 | 2775 | 8048 | 0.3448 |
| 20171214 | 3901 |10995 | 0.3548 |
| 20171215 | 3528 | 9773 | 0.3610 |
| 20171216 | 3112 | 7919 | 0.3930 |
| 20171217 | 3394 | 9882 | 0.3435 |
| 20171218 | 2893 |10940 | 0.2644 |
| 20171219 | 3110 |10066 | 0.3090 |
| 20171220 | 5545 |12219 | 0.4538 |
| 20171221 | 4544 |11888 | 0.3822 |
| 20171222 | 4170 |10191 | 0.4092 |
| 20171223 | 3173 | 8475 | 0.3744 |
| 20171224 | 5318 |10429 | 0.5099 |
| 20171225 | 2472 | 8507 | 0.2906 |
| 20171226 | 4209 |10059 | 0.4184 |
| 20171227 | 4341 |11177 | 0.3884 |
| 20171228 | 2860 | 9564 | 0.2990 |
| 20171229 | 4190 |10294 | 0.4070 |
| 20171230 | 3676 |10143 | 0.3624 |
| 20171231 | 6084 |12698 | 0.4791 |
| 20180101 | 3622 |11578 | 0.3128 |
| 20180102 | 4400 |16172 | 0.2721 |
| 20180103 | 6242 |12910 | 0.4835 |
| 20180104 | 5331 |11774 | 0.4528 |
| 20180105 | 5896 |10563 | 0.5582 |
| 20180106 | 5757 |17901 | 0.3216 |
| 20180107 | 2871 | 8944 | 0.3210 |
| 20180108 | 1803 | 6516 | 0.2767 |
+--+--+--++TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: jcrespo, Marostegui, Ladsgroup, Stashbot, Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T184322: Enable fine grained lua tracking gradually in client wikis

2018-01-07 Thread eranroz
eranroz added a comment.
One more point for consideration: fineGrainedUsageTracking can be deployed with or without tracking specific claims (T151717), where we mask C.Px to O in SqlUsageTracker::handleBlacklistedUsages. AFAIK cawiki already tracks specific claims.TASK DETAILhttps://phabricator.wikimedia.org/T184322EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, eranrozCc: Joe, hoo, Doc_James, PokestarFan, eranroz, Izno, Oliv0, Ltrlg, Scott_WUaS, CennoxX, Liuxinyu970226, aude, Lydia_Pintscher, daniel, Aklapper, Halfak, gerritbot, thiemowmde, Bawolff, Stashbot, Marostegui, jcrespo, Ladsgroup, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T184322: Enable fine grained lua tracking gradually in client wikis

2018-01-07 Thread eranroz
eranroz added a comment.
This is likely to have tiny aspects on hewiki, as many modules are already adopted to avoid getEntity() but rather use entity ID and fetch only the specific aspect (this have additional benefit of lower footprint of serializations).
Hence wbc_entity_usage is probably not going to change drastically, nor recentchanges (where rc_source=wb), and hewiki may be a good starting point.  This is mainly to validate this setting works well and doesn't break anything.

As for other wikis:


cawiki could be the next one, where we can evaluate how it affects the wbc_entity_usage table size and recentchanges
for wider deployment, I believe https://phabricator.wikimedia.org/T178114 should be considered as a blocker. (possibly requires something similar to T178079)
TASK DETAILhttps://phabricator.wikimedia.org/T184322EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, eranrozCc: Joe, hoo, Doc_James, PokestarFan, eranroz, Izno, Oliv0, Ltrlg, Scott_WUaS, CennoxX, Liuxinyu970226, aude, Lydia_Pintscher, daniel, Aklapper, Halfak, gerritbot, thiemowmde, Bawolff, Stashbot, Marostegui, jcrespo, Ladsgroup, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T101954: [Bug] Input boxes for time datatype statements always use ltr

2017-12-21 Thread eranroz
eranroz added a project: Wikimedia-Israel-Hackers.
TASK DETAILhttps://phabricator.wikimedia.org/T101954EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: PokestarFan, hoo, aude, Lydia_Pintscher, Yair_rand, Aklapper, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, Rafisamra2016, QZanden, Tal-WMIL, CXuesong, LawExplorer, Avner, Tzafrir, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, IKhitron, Wikidata-bugs, Huji, Amire80, Gryllida, Shizhao, Arrbee, Matanya, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T181340: Wikidata textarea are LTR for RTL labels

2017-12-21 Thread eranroz
eranroz added a comment.
Seems like the issue is solved(?) and I can't reproduce the issue. @IKhitron can you please test it also in your environment?

If it works, we can move this task to Invalid. Thanks!TASK DETAILhttps://phabricator.wikimedia.org/T181340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Ladsgroup, thiemowmde, Lydia_Pintscher, Amire80, IKhitron, Aklapper, eranroz, Lahi, Gq86, Dfil7, Icedevil, GoranSMilovanovic, 45Jayjay1969, Jayprakash12345, Jrbranaa, QZanden, CXuesong, LawExplorer, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Huji, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T172914: [Tracking] Fine-grained change notifications based on tracking from Lua getters via __index

2017-12-21 Thread eranroz
eranroz added subscribers: Ladsgroup, Marostegui.eranroz added a comment.
By the next deployment of Wikidata, the first year of the next week, we will be able to properly track Wikidata usages from Lua (T179923) - so all dev blockers are solved, and it is up to configuration/operation.

Operation implications


wbc_entity_usage - expected to grow (any row with eu_aspect=X may be replaced with few rows), but AFAIK this should be only a slight growth (up to say x4, where All usage (X) is replaced with other (O)/label (L)/sitelink (S)/alias (A), and usually less). This is under assumptions that (T151717) is not deployed - e.g we dont track claims (they are just O usages), but eventually, this task becomes relevant too.
recentchanges - expected to see much less updates from wikidata (non relevant updates)


Suggested deployment plan
I suggest the following timeline for deployment:


T179923 - week of 2018-01-02  - enable it on cawiki, cewiki, elwiki, kowiki, trwiki (@Ladsgroup if this is OK from you and all stack holders, it means we can abandon https://gerrit.wikimedia.org/r/#/c/398823/ )
If everything works well, we can deploy the next week (week of 2018-01-08) to few large wikis for evaluations and if all rocks we can deploy everywhere.
TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Marostegui, Ladsgroup, Stashbot, Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, CXuesong, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T166056: Add mw.wikibase.entity:getStatements for convenience

2017-12-18 Thread eranroz
eranroz added a parent task: T182147: more convenience functions for Lua.
TASK DETAILhttps://phabricator.wikimedia.org/T166056EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: gerritbot, Lydia_Pintscher, Aklapper, TerraCodes, hoo, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, CXuesong, Zoranzoki21, Lewizho99, Maathavan, MuhammadShuaib, SimmeD, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T182147: more convenience functions for Lua

2017-12-18 Thread eranroz
eranroz added a subtask: T166056: Add mw.wikibase.entity:getStatements for convenience.
TASK DETAILhttps://phabricator.wikimedia.org/T182147EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: putnik, Jonas, aude, hoo, Ladsgroup, Tpt, thiemowmde, eranroz, Aklapper, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, QZanden, CXuesong, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T172914: [Tracking] Fine-grained change notifications based on tracking from Lua getters via __index

2017-12-18 Thread eranroz
eranroz updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...[x] Make `AffectedPagesFinder` take statement usage into account (T176413)
[x] https://gerrit.wikimedia.org/r/#/c/371651 got reverted and must be re-submitted (T179923)...TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Stashbot, Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, CXuesong, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T182147: more convenience functions for Lua

2017-12-06 Thread eranroz
eranroz added a subscriber: putnik.eranroz added a comment.
all points raised by @thiemowmde  are very good points. in addition:


get statements with language filter - very common for example to get female label (P2521) in specific lang. (see for example the nice work of @putnik in ru:Модуль:WikidataSelectors and Wikidata/item). Such properties are usually heavy (for example ~30 values in Q36180) but the module is interested in only one of them, so this can make it much easier and may even come with a little performance benefits.


TASK DETAILhttps://phabricator.wikimedia.org/T182147EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: putnik, Jonas, aude, hoo, Ladsgroup, Tpt, thiemowmde, eranroz, Aklapper, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, QZanden, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T176413: Make AffectedPagesFinder take STATEMENT_USAGE into account

2017-12-04 Thread eranroz
eranroz added a comment.
is this task should be moved to closed/solved or are there any other issues not addressed in this above patch?TASK DETAILhttps://phabricator.wikimedia.org/T176413EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, eranrozCc: daniel, DixonD, Aklapper, Bianjiang, aude, jeremyb, liangent, Wikidata-bugs, Abraham, Legoktm, Tobi_WMDE_SW, Daniel_Mietchen, jayvdb, Micru, Ricordisamoa, MZMcBride, Liuxinyu970226, Ainali, Sannita, Lydia_Pintscher, Eloquence, zhuyifei1999, Hall1467, TomT0m, jcrespo, Halfak, gerritbot, Stashbot, Ladsgroup, PokestarFan, Ottomata, eranroz, Bawolff, hoo, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T181340: Wikidata textarea are LTR for RTL labels

2017-11-25 Thread eranroz
eranroz added a subscriber: Amire80.eranroz added a comment.
testing it in both Chrome and FF, this appears to happen only in FF - so it may be a regression in Firefox Quantom and not in wikibase nor mediawiki, and happen due to conflicting definitions of directionality. e.g:
CSS

.sitedir-ltr textarea, .sitedir-ltr input {
direction: ltr;
}

But in the DOM:



I'm not sure what the spec says, but probably this is a browser bug (if someone can confirm it - we can mark it as invalid)TASK DETAILhttps://phabricator.wikimedia.org/T181340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Amire80, IKhitron, Aklapper, eranroz, Lahi, Gq86, Dfil7, Icedevil, GoranSMilovanovic, 45Jayjay1969, Jayprakash12345, Jrbranaa, QZanden, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Huji, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T181340: Wikidata textarea are LTR for RTL labels

2017-11-25 Thread eranroz
eranroz added a project: MediaWiki-extensions-WikibaseRepository.eranroz updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...(this is caused by the CSS rule from resources/src/mediawiki.legacy/shared.css: 
```lang=css
.sitedir-ltr textarea, .sitedir-ltr input {...}
```
which appear there since 2011 - so we must explicitly declare RTL for elements with RTL directionality in LTR site)TASK DETAILhttps://phabricator.wikimedia.org/T181340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: IKhitron, Aklapper, eranroz, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Huji, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T172914: [Tracking] Fine-grained change notifications based on tracking from Lua getters via __index

2017-11-21 Thread eranroz
eranroz added a comment.

In T172914#3778257, @thiemowmde wrote:

The patch https://gerrit.wikimedia.org/r/392041 (a resubmission of the original https://gerrit.wikimedia.org/r/371651) is incomplete. There are two ways forward:
Via a feature flag: The patch could be expanded to (temporarily) understand the disabledUsageAspects setting. This will allow us to merge the patch without having an effect in production. Only if the setting is removed in production, all code (both the parser functions as well as all Lua functions) will start tracking descriptions and statements individually.




IMO, disabledUsageAspects should be aspect of SqlUsageTracker/AffectedPagesFinder and not Lua related issue. (e.g if C is disabled - SqlUsageTracker should replace C to O when registering usage, and AffectedPagesFinder should replace C to O when getting notification)TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Stashbot, Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lahi, Gq86, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T180727: WikibaseClient resources are broken in WMF

2017-11-16 Thread eranroz
eranroz triaged this task as "Unbreak Now!" priority.Herald added subscribers: Liuxinyu970226, Jay8g, TerraCodes.
TASK DETAILhttps://phabricator.wikimedia.org/T180727EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: TerraCodes, Jay8g, Liuxinyu970226, Aklapper, eranroz, Imarlier, Lahi, GoranSMilovanovic, QZanden, Vali.matei, Nirmos, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T180727: WikibaseClient resources are broken in WMF

2017-11-16 Thread eranroz
eranroz updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONCon hewiki for example

Execute on console: mw
```mw.loader.load('wikibase.client.getMwApiForRepo')```

Result:...TASK DETAILhttps://phabricator.wikimedia.org/T180727EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Aklapper, eranroz, Imarlier, Lahi, GoranSMilovanovic, QZanden, Vali.matei, Nirmos, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T180727: WikibaseClient resources are broken in WMF

2017-11-16 Thread eranroz
eranroz created this task.eranroz added projects: MediaWiki-extensions-WikibaseClient, MediaWiki-ResourceLoader.Herald added a subscriber: Aklapper.Herald added projects: Wikidata, Performance-Team.
TASK DESCRIPTIONConsole: mw.loader.load('wikibase.client.getMwApiForRepo')
Result:

columnNumber: 205
fileName: "https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&_only_=scripts&skin=vector&version=1b46sjy"
lineNumber: 159
message: "Unknown dependency: wikibase.api.getLocationAgnosticMwApi"
stack: "sortDependencies@https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&_only_=scripts&skin=vector&version=1b46sjy:159:205\nsortDependencies@https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&_only_=scripts&skin=vector&version=1b46sjy:160:35\nresolveStubbornly@https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&_only_=scripts&skin=vector&version=1b46sjy:160:353\nload@https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&_only_=scripts&skin=vector&version=1b46sjy:170:963\n@debugger eval code:1:1\n"TASK DETAILhttps://phabricator.wikimedia.org/T180727EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Aklapper, eranroz, Imarlier, Lahi, GoranSMilovanovic, QZanden, Vali.matei, Nirmos, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T106287: [Tracking] Track descriptions usages separately (Create a new description usage aspect "D")

2017-11-01 Thread eranroz
eranroz added a comment.
See also: https://en.wikipedia.org/wiki/Wikipedia_talk:Wikidata/2017_State_of_affairsTASK DETAILhttps://phabricator.wikimedia.org/T106287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, eranrozCc: Richard_Nevell_WMUK, thiemowmde, gerritbot, eranroz, PokestarFan, jmadler, hoo, daniel, zhuyifei1999, Eloquence, Lydia_Pintscher, Sannita, Ainali, Liuxinyu970226, MZMcBride, Ricordisamoa, Micru, jayvdb, Daniel_Mietchen, Tobi_WMDE_SW, Legoktm, Abraham, greg, Wikidata-bugs, liangent, jeremyb, aude, Bianjiang, Aklapper, Lahi, GoranSMilovanovic, QZanden, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T173144: Tracking implicit (extensions) usages of Wikidata

2017-10-23 Thread eranroz
eranroz added a comment.

In T173144#3702601, @thiemowmde wrote:
you must consider all descriptions being used by a search feature. Tracking them individually is pointless.


agree


In T173144#3702601, @thiemowmde wrote:
I might miss something, but I have a fundamental question: How is "showing up in a search result" a "usage"?


Usage for recentchanges. E.g: someone vandalize intentionally (or use bot and unintentionly adds wrong description) the description, we would like to have a recentchange list in the client wiki that use this description so the users in that community cna patrol the change.TASK DETAILhttps://phabricator.wikimedia.org/T173144EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: thiemowmde, matej_suchanek, hoo, PokestarFan, Halfak, Aklapper, RP88, eranroz, Doc_James, GoranSMilovanovic, QZanden, Winter, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T113468: [Task] Use compact representation of diffs in EntityChange.

2017-10-15 Thread eranroz
eranroz added a subtask: T176413: Make AffectedPagesFinder take STATEMENT_USAGE into account.
TASK DETAILhttps://phabricator.wikimedia.org/T113468EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, eranrozCc: PokestarFan, hoo, gerritbot, aude, Aklapper, daniel, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T176413: Make AffectedPagesFinder take STATEMENT_USAGE into account

2017-10-15 Thread eranroz
eranroz added a parent task: T113468: [Task] Use compact representation of diffs in EntityChange..
TASK DETAILhttps://phabricator.wikimedia.org/T176413EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: daniel, DixonD, Aklapper, Bianjiang, aude, jeremyb, liangent, Wikidata-bugs, Abraham, Legoktm, Tobi_WMDE_SW, Daniel_Mietchen, jayvdb, Micru, Ricordisamoa, MZMcBride, Liuxinyu970226, Ainali, Sannita, Lydia_Pintscher, Eloquence, zhuyifei1999, Hall1467, TomT0m, jcrespo, Halfak, gerritbot, Stashbot, Ladsgroup, PokestarFan, Ottomata, eranroz, Bawolff, hoo, GoranSMilovanovic, QZanden, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T64005: Using the language link tool in the sidebar when inside VisualEditor loses the edit without warning

2017-10-15 Thread eranroz
eranroz added projects: Wikimedia-Israel-Hackers, Easy.Herald added a subscriber: TerraCodes.
TASK DETAILhttps://phabricator.wikimedia.org/T64005EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: TerraCodes, eranroz, Aklapper, Wikidata-bugs, Jdforrester-WMF, Elitre, Krinkle, Lydia_Pintscher, hoo, Ryasmeen, Necroarcano, Robinma, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, Rafisamra2016, QZanden, Tal-WMIL, Zoranzoki21, merbst, Avner, Wess, Tzafrir, Srdjan_m, MuhammadShuaib, IKhitron, Jrf, Husun1297, aude, Deskana, Amire80, Swainr, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T166056: Add mw.wikibase.entity:getStatements for convenience

2017-10-14 Thread eranroz
eranroz added a comment.
For future reference/answer to the good question of Lydia above: (my) intention is to upstream some code from https://en.wikipedia.org/wiki/Module:Wikidata (used in many other wikis) to the library itself.
This would allow better code sharing and more maintained code and may prevent issues as T178114.TASK DETAILhttps://phabricator.wikimedia.org/T166056EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: gerritbot, Lydia_Pintscher, Aklapper, TerraCodes, hoo, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, Lewizho99, Maathavan, MuhammadShuaib, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T166056: Add mw.wikibase.entity:getStatements for convenience

2017-10-14 Thread eranroz
eranroz triaged this task as "Low" priority.eranroz claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T166056EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: gerritbot, Lydia_Pintscher, Aklapper, TerraCodes, hoo, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, Lewizho99, Maathavan, MuhammadShuaib, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T178153: make disabledUsageAspects coarse graining

2017-10-13 Thread eranroz
eranroz created this task.eranroz added projects: MediaWiki-extensions-WikibaseClient, Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONOnce T172914 we need to make is compatible with disabledUsageAspects.
I suggest to make disabledUsageAspects coarse graining e.g when adding a claim, and C is in disabledUsageAspects, we will fallback to O. (instead of just removing C). So instead of disable it will be rather replacement.

This could be implemented in SqlUsageTracker.TASK DETAILhttps://phabricator.wikimedia.org/T178153EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Lydia_Pintscher, hoo, daniel, Aklapper, eranroz, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T178114: Many Wikipedia's Wikidata module iterate over all entity claims if a Statement is searched for by property label

2017-10-13 Thread eranroz
eranroz added a comment.

Easy/workaround  - When code access pairs of pseudo table (entity.claims as here and  also entity.labels and entity.descriptions once T172914 is getting merged ) we should probably workaround it upstream either from UsageAggregator (T178079) or from Lua (whenever access pairs for entity.claims, count it as C.* instead of many rows).
wbc_entity_usage will not get overloaded with too many rows. This is just workaround to avoid unintentional usage, as it still make the EU not efficient (from rc side)

Medium -  Le Tour de Wikí 2017 go over all wikis and fix them (there is no central fix - T121470 T41610)
TASK DETAILhttps://phabricator.wikimedia.org/T178114EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Aklapper, eranroz, daniel, Lydia_Pintscher, hoo, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T178057: Wikidata Query UI: RTL Issues

2017-10-12 Thread eranroz
eranroz renamed this task from "RTL Issues" to "Wikidata Query UI: RTL Issues".eranroz added a project: RTL.Herald added a project: I18n.
TASK DETAILhttps://phabricator.wikimedia.org/T178057EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Smalyshev, Jonas, Aklapper, Lucas_Werkmeister_WMDE, EBjune, merbst, Srdjan_m, Xmlizer, MuhammadShuaib, LNDDYL, Psychoslave, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Gryllida, Shizhao, Arrbee, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-10-12 Thread eranroz
eranroz added a comment.

In T172914#3679739, @daniel wrote:
Looking at things like https://commons.wikimedia.org/w/index.php?title=File:Vincent_Willem_van_Gogh_110.jpg&action=""> it seems like we really should get this done ASAP.


Nice example,I get your point  :)
Please go over the last patch (adds descriptions + feature flag and its documentation).  Also note that once deployed it should disabled in wmf-config and enabled per wiki as it may increase the wbc_entity_usage row number.TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


  1   2   >