[Wikidata-bugs] [Maniphest] [Commented On] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
mmodell added a comment. After rolling forward with wmf.12 I saw this error showing up again. Apparently the hotfix didn't work?TASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, mmodellCc: Jdforrester-WMF, Lucas_Werkmeister_WMDE, daniel, IKhitron, Paladox, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, gerritbot, aude, Aklapper, mmodell, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
mmodell added a commit: rEWBA11aad9d2dbc8: Hot fix for InjectRCRecordsJob: disable coalescing. TASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, mmodellCc: Jdforrester-WMF, Lucas_Werkmeister_WMDE, daniel, IKhitron, Paladox, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, gerritbot, aude, Aklapper, mmodell, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
mmodell added a comment. Thanks Daniel, hotfix is not necessary.TASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, mmodellCc: daniel, IKhitron, Paladox, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, gerritbot, aude, Aklapper, mmodell, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
mmodell added a commit: rEWBA2987fe5bcf62: Move injection of RC records to a separate job.. TASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Paladox, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, gerritbot, aude, Aklapper, mmodell, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
mmodell added a comment. In T172320#3494790, @Paladox wrote: Caused by https://github.com/wikimedia/mediawiki-extensions-Wikibase/commit/2987fe5bcf6223d03835670f7a6832e6a41a51ef that commit is rEWBA2987fe5bcf62: Move injection of RC records to a separate job.TASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Paladox, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, gerritbot, aude, Aklapper, mmodell, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
mmodell triaged this task as "Unbreak Now!" priority.mmodell added a comment.Herald added subscribers: Liuxinyu970226, Jay8g, TerraCodes. This is blocking the train due to more than doubling the error rate in fatalmonitor.TASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: TerraCodes, Jay8g, Liuxinyu970226, Stashbot, gerritbot, aude, Aklapper, mmodell, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
mmodell created this task.mmodell added projects: Wikimedia-log-errors, wikiba.se, MediaWiki-extensions-WikibaseClient.Herald added subscribers: PokestarFan, Aklapper.Herald added a project: Wikidata. TASK DESCRIPTIONphp-1.30.0-wmf.12/extensions/Wikidata/extensions/Wikibase/client/includes/Changes/InjectRCRecordsJob.phpTASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: aude, Aklapper, mmodell, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
mmodell added a parent task: T168053: 1.30.0-wmf.12 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: aude, Aklapper, mmodell, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope"
mmodell removed a parent task: T168053: 1.30.0-wmf.12 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T171370EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: mmodell, Addshore, demon, thcipriani, daniel, aaron, greg, TerraCodes, Jay8g, Liuxinyu970226, jcrespo, gerritbot, Aklapper, Krinkle, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope"
mmodell added a comment. @daniel: Thanks, removing it from blockingTASK DETAILhttps://phabricator.wikimedia.org/T171370EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: mmodell, Addshore, demon, thcipriani, daniel, aaron, greg, TerraCodes, Jay8g, Liuxinyu970226, jcrespo, gerritbot, Aklapper, Krinkle, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope"
mmodell added a comment. The patch appears to be merged on master but the wmf.10 cherry-pick is still open? I've added this as a blocker to wmf.12 since it's still open and I need to verify that the issue isn't affecting wmf.12 after I cut the branch tomorrow.TASK DETAILhttps://phabricator.wikimedia.org/T171370EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: mmodell, Addshore, demon, thcipriani, daniel, aaron, greg, TerraCodes, Jay8g, Liuxinyu970226, jcrespo, gerritbot, Aklapper, Krinkle, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope"
mmodell added a parent task: T168053: 1.30.0-wmf.12 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T171370EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Addshore, demon, thcipriani, daniel, aaron, greg, TerraCodes, Jay8g, Liuxinyu970226, jcrespo, gerritbot, Aklapper, Krinkle, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T168681: Argument 1 passed to DataValues\UnboundedQuantityValue::newFromArray() must be an instance of array, string given in extensions/Wikidata/vendor/data
mmodell added a comment. What I want to know is why this just started happening. If it's not really related to today's SWAT then perhaps it shouldn't block the train.TASK DETAILhttps://phabricator.wikimedia.org/T168681EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Dereckson, JeroenDeDauw, Lucas_Werkmeister_WMDE, TerraCodes, Jay8g, greg, Addshore, aude, Stashbot, Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T168681: Argument 1 passed to DataValues\UnboundedQuantityValue::newFromArray() must be an instance of array, string given in extensions/Wikidata/vendor/data
mmodell added a comment. That's what I don't understand, the code didn't change... So you think this is just invalid data passed to the API and the timing (which coincided with SWAT) was just a coincidence?TASK DETAILhttps://phabricator.wikimedia.org/T168681EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Dereckson, JeroenDeDauw, Lucas_Werkmeister_WMDE, TerraCodes, Jay8g, greg, Addshore, aude, Stashbot, Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Raised Priority] T168681: Argument 1 passed to DataValues\UnboundedQuantityValue::newFromArray() must be an instance of array, string given in extensions/Wikidata/vendor/d
mmodell raised the priority of this task from "High" to "Unbreak Now!".mmodell added a comment. Spoke too soon, now it's back.TASK DETAILhttps://phabricator.wikimedia.org/T168681EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Lucas_Werkmeister_WMDE, TerraCodes, Jay8g, greg, Addshore, aude, Stashbot, Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Lowered Priority] T168681: Argument 1 passed to DataValues\UnboundedQuantityValue::newFromArray() must be an instance of array, string given in extensions/Wikidata/vendor/
mmodell lowered the priority of this task from "Unbreak Now!" to "High".mmodell added a comment. ok this error seems to have disappeared as mysteriously as it appeared.TASK DETAILhttps://phabricator.wikimedia.org/T168681EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Lucas_Werkmeister_WMDE, TerraCodes, Jay8g, greg, Addshore, aude, Stashbot, Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Raised Priority] T168681: Argument 1 passed to DataValues\UnboundedQuantityValue::newFromArray() must be an instance of array, string given in extensions/Wikidata/vendor/d
mmodell raised the priority of this task from "High" to "Unbreak Now!".Herald added subscribers: Jay8g, TerraCodes. TASK DETAILhttps://phabricator.wikimedia.org/T168681EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: TerraCodes, Jay8g, greg, Addshore, aude, Stashbot, Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T168681: Argument 1 passed to DataValues\UnboundedQuantityValue::newFromArray() must be an instance of array, string given in extensions/Wikidata/vend
mmodell added subscribers: aude, Addshore.mmodell added a comment. @aude or @Addshore: Any clue what might be causing this? I'm not sure how vendor'd code works in the wikidata extension. This error started showing up suddenly after the most recent SWAT even though no code was deployed which should have affected this.TASK DETAILhttps://phabricator.wikimedia.org/T168681EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Addshore, aude, Stashbot, Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T168681: Argument 1 passed to DataValues\UnboundedQuantityValue::newFromArray() must be an instance of array, string given in extensions/Wikidata/vendor/data-valu
mmodell added a parent task: T167535: MW-1.30.0-wmf.6 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T168681EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T168681: Argument 1 passed to DataValues\UnboundedQuantityValue::newFromArray() must be an instance of array, string given in extensions/Wikidata/vendor/data-valu
mmodell triaged this task as "High" priority.mmodell added a project: Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T168681EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T167360: "Warning: in_array() expects parameter 2 to be an array or collection" from Wikibase MwTimeIsoFormatter
mmodell closed this task as "Resolved".mmodell assigned this task to aude. TASK DETAILhttps://phabricator.wikimedia.org/T167360EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aude, mmodellCc: gerritbot, Aklapper, aude, mmodell, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T167360: "Warning: in_array() expects parameter 2 to be an array or collection" from Wikibase MwTimeIsoFormatter
mmodell added a comment. Thanks @audeTASK DETAILhttps://phabricator.wikimedia.org/T167360EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: gerritbot, Aklapper, aude, mmodell, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T167360: Warning: in_array() expects parameter 2 to be an array or collection
mmodell added a parent task: T166829: MW-1.30.0-wmf.4 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T167360EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, aude, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T167360: Warning: in_array() expects parameter 2 to be an array or collection
mmodell created this task.mmodell added projects: Wikidata, Wikimedia-log-errors.Herald added a subscriber: Aklapper. TASK DESCRIPTIONWarning: in_array() expects parameter 2 to be an array or collection in /srv/mediawiki/php-1.30.0-wmf.4/extensions/Wikidata/extensions/Wikibase/lib/includes/Formatters/MwTimeIsoFormatter.php on line 109TASK DETAILhttps://phabricator.wikimedia.org/T167360EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, aude, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T167238: Fatal Error: "Tag hook for noexternallanglinks is not callable" (1.30.0-wmf.4/includes/parser/Parser.php)
mmodell closed this task as "Resolved".mmodell added a comment. I take it this is fixed then.TASK DETAILhttps://phabricator.wikimedia.org/T167238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMF, mmodellCc: mmodell, Stashbot, Lydia_Pintscher, thiemowmde, gerritbot, TerraCodes, Aklapper, Krinkle, Jay8g, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T126597: [Task] Move WikibaseDataModel to Gerrit
mmodell added a comment. Have you considered moving to Phabricator + Differential instead of gerrit? TASK DETAIL https://phabricator.wikimedia.org/T126597 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: Jonas, hoo, Dereckson, Lydia_Pintscher, MZMcBride, aude, JanZerebecki, JeroenDeDauw, Legoktm, GPHemsley, Tobi_WMDE_SW, adrianheine, daniel, thiemowmde, Aklapper, mmodell, chasemp, Ricordisamoa, Liuxinyu970226, Addshore, Bene, Lazowik, Tpt, Krenair, Izno, Luke081515, Wikidata-bugs, Mbch331, QChris, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Block] T118363: widar oauth broken - magical script elves are temporarily ill
mmodell reopened blocking task T118372: OAuth broken as "Open". TASK DETAIL https://phabricator.wikimedia.org/T118363 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: Sjoerddebruin, yuvipanda, Magnus, Harmonia_Amanda, Aklapper, Dzahn, StudiesWorld, Wikidata-bugs, aude, Gryllida, jayvdb, scfc, coren, Mbch331, valhallasw ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T105638: RFC: Streamlining Composer usage
mmodell added a comment. @gwicke: very interesting suggestion. I like it, though I think I need to think it over a bit more before I can say for sure that it would work for mediawiki deployments. TASK DETAIL https://phabricator.wikimedia.org/T105638 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, mmodell Cc: mobrovac, GWicke, Addshore, Qgil, Spage, greg, tstarling, aude, hoo, daniel, zeljkofilipin, thcipriani, mmodell, bd808, csteipp, Legoktm, Krinkle, hashar, JanZerebecki, Aklapper, Lynhg, Wikidata-bugs, Malyacko, Mbch331, Jay8g, Ltrlg, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T110375: [Bug] Catchable fatal error: Argument 1 passed to Wikibase\Repo\Api\EditEntity::getRemoveStatementChangeOps() must be an instance of array, string g
mmodell added a subscriber: mmodell. mmodell added a comment. I'm seeing this in 1.27.0-wmf.5: Catchable fatal error: Argument 1 passed to Wikibase\Repo\Api\EditEntity::getRemoveStatementChangeOps() must be an instance of array, string given in /srv/mediawiki/php-1.27.0-wmf.5/extensions/Wikidata/extensions/Wikibase/r epo/includes/api/EditEntity.php on line 562 TASK DETAIL https://phabricator.wikimedia.org/T110375 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: mmodell, Ricordisamoa, demon, Aklapper, aude, Luke081515, Wikidata-bugs, Mbch331, Jay8g, Krenair, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T113731: [Task] make core wmf branches only use submodule branches that run with it in CI
mmodell added a comment. But I thought that mediawiki core __is__ updated when a patch is merged to an extension. TASK DETAIL https://phabricator.wikimedia.org/T113731 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: hashar, gerritbot, mmodell, aude, hoo, Krinkle, JanZerebecki, Aklapper, Wikidata-bugs, AndyRussG, Pcoombe, atgo, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T113731: make core wmf branches only use submodule branches that run with it in CI
mmodell added a comment. CI should just check out all the submodules by following the submodule sha1 references in the core branch, then it wouldn't matter how the branches are named, ci would do the right thing by simply letting git do the right thing. If CI isn't doing that now then it's a bug in the CI setup. TASK DETAIL https://phabricator.wikimedia.org/T113731 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, mmodell Cc: gerritbot, mmodell, aude, hoo, Krinkle, JanZerebecki, Aklapper, Wikidata-bugs, hashar, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T113731: make core wmf branches only use submodule branches that run with it in CI
mmodell added a comment. I don't quite understand the problem, and I really don't understand how changing the make-wmf-branch config is going to resolve it? This sounds like a bug in the way CI testing is configured. TASK DETAIL https://phabricator.wikimedia.org/T113731 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, mmodell Cc: gerritbot, mmodell, aude, hoo, Krinkle, JanZerebecki, Aklapper, Liudvikas, Wikidata-bugs, hashar, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111304: Fatal error: Call to undefined method OOUI\Element::serializeForApiResult() in /srv/mediawiki/php-1.26wmf21/vendor/oojs/oojs-ui/php/Element.php on l
mmodell added a comment. The patch breaks unit tests. The tests need to be fixed along with this change. TASK DETAIL https://phabricator.wikimedia.org/T111304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, mmodell Cc: Bene, gerritbot, Lydia_Pintscher, ori, greg, Jdlrobson, Anomie, Legoktm, Krenair, Jdforrester-WMF, Aklapper, mmodell, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T109603: Undefined index: descriptions in extensions/Wikidata/extensions/Wikibase/repo/includes/api/ResultBuilder.php on line 483
mmodell created this task. mmodell added a subscriber: mmodell. mmodell added projects: WikibaseDatabase, Wikimedia-log-errors. Herald added a subscriber: Aklapper. Herald added a project: Wikidata. TASK DESCRIPTION Apologies if I tagged the wrong project, is this #WikibaseDatabase or #WikibaseQueryEngine? New logspam appearing as of 1.26wmf19: ``` Undefined index: descriptions in /srv/mediawiki/php-1.26wmf19/extensions/Wikidata/extensions/Wikibase/repo/includes/api/ResultBuilder.php on line 483 ``` TASK DETAIL https://phabricator.wikimedia.org/T109603 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: Aklapper, mmodell, Wikidata-bugs, aude, Krenair, greg, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T109603: Undefined index: descriptions in extensions/Wikidata/extensions/Wikibase/repo/includes/api/ResultBuilder.php on line 483
mmodell closed this task as Resolved. mmodell claimed this task. mmodell added a comment. Hotfix deployed, I can confirm that the error is no longer showing up in production logs. TASK DETAIL https://phabricator.wikimedia.org/T109603 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: JanZerebecki, gerritbot, aude, Aklapper, mmodell, Wikidata-bugs, Krenair, greg, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T105638: RFC: Streamlining Composer usage
mmodell added a comment. what came of this meeting? TASK DETAIL https://phabricator.wikimedia.org/T105638 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, mmodell Cc: greg, tstarling, aude, hoo, daniel, zeljkofilipin, thcipriani, mmodell, bd808, csteipp, Legoktm, Krinkle, hashar, JanZerebecki, Aklapper, Lynhg, Wikidata-bugs, Malyacko, GWicke, Qgil, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T74907: move git repositories that are dependencies of wikidata to gerrit
mmodell added a comment. In https://phabricator.wikimedia.org/T74907#1218316, @mmodell wrote: Last time I checked, arcanist/differential do not have any have explicit support for chains of dependent patches. I was wrong, it does have dependencies now. One differential revision can depend on another revision. TASK DETAIL https://phabricator.wikimedia.org/T74907 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: Addshore, Liuxinyu970226, Ricordisamoa, chasemp, mmodell, Abraham, Aklapper, thiemowmde, Qgil, Snaterlicious, daniel, adrianheine, Tobi_WMDE_SW, GPHemsley, Legoktm, JeroenDeDauw, JanZerebecki, aude, Glaisher, MZMcBride, Lydia_Pintscher, Dereckson, hoo, Wikidata-bugs, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T99998: make-wmf-branch should check if it is up to date
mmodell closed this task as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T8 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: gerritbot, mmodell, aude, hoo, JanZerebecki, Aklapper, Wikidata-bugs, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T99998: make-wmf-branch should check if it is up to date
mmodell claimed this task. mmodell added a comment. I'll implement this TASK DETAIL https://phabricator.wikimedia.org/T8 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: mmodell, aude, hoo, JanZerebecki, Aklapper, Wikidata-bugs, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T99998: make-wmf-branch should check if it is up to date
mmodell triaged this task as High priority. TASK DETAIL https://phabricator.wikimedia.org/T8 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: mmodell, aude, hoo, JanZerebecki, Aklapper, Wikidata-bugs, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T74907: move git repositories that are dependencies of wikidata to gerrit
mmodell added a comment. In https://phabricator.wikimedia.org/T74907#1109504, @thiemowmde wrote: Erm, not what I meant. Will Phabricator support chains of patches and if it does, how? In https://phabricator.wikimedia.org/T74907#1109505, @Qgil wrote: @mmodell, @chasemp, please check the question above. Last time I checked, arcanist/differential do not have any have explicit support for chains of dependent patches. You can submit multiple commits to a single differential changeset ( it takes care of squashing when you submit, but still tracks individual local commits for posterity ) ... But the lack of dependencies between multiple differential changes is a fairly significant limitation. I suspect it will be added some day, it may even worth our time to implement a rudimentary dependency feature, if we could get it accepted upstream. TASK DETAIL https://phabricator.wikimedia.org/T74907 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: Addshore, Liuxinyu970226, Ricordisamoa, chasemp, mmodell, Abraham, Aklapper, thiemowmde, Qgil, Snaterlicious, daniel, adrianheine, Tobi_WMDE_SW, GPHemsley, Legoktm, JeroenDeDauw, JanZerebecki, aude, Glaisher, MZMcBride, Lydia_Pintscher, Dereckson, hoo, Wikidata-bugs, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T84923: Reliable publish / subscribe event bus
mmodell added a subscriber: mmodell. TASK DETAIL https://phabricator.wikimedia.org/T84923 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: mmodell, Eevans, chasemp, brion, Krenair, Halfak, JanZerebecki, bd808, MZMcBride, mobrovac, GWicke, aaron, daniel, Hardikj, yuvipanda, JAllemandou, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, RobH, aude, marcoil, Manybubbles, mark, RobLa-WMF, faidon, fgiunchedi, Dzahn ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed CC] T268: Decide on Priority field values for Maniphest tasks
mmodell added a subscriber: mmodell. mmodell added a comment. I agree with @Gryllida on this one. Having a needs volunteer priority sorta sounds disingenuous. Might as well call a duck a duck and name it priority: none TASK DETAIL https://phabricator.wikimedia.org/T268 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Qgil, mmodell Cc: Qgil, chasemp, scfc, Lydia_Pintscher, Aklapper, hoo, Awjrichards, Gryllida, mmodell, Wikidata-bugs, aude, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
