[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI
nnikkhoui added a comment. Apologies everyone for being the one to merge that in and block CI. It was a big miss on my end. I had needed the fake timestamp (still should definitely not have been in the data provider to begin with). But around the same time another patch was merged that caused me //not// to need the faketimestamp (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/616120) so removing it is definitely the better solution of the two. Thank you very much for catching it and working to merge in the fix, I hadn't seen this until Petr +2ed the fix patch. TASK DETAIL https://phabricator.wikimedia.org/T259785 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: nnikkhoui Cc: nnikkhoui, Lucas_Werkmeister_WMDE, Tarrow, Pablo-WMDE, Addshore, guergana.tzatchkova, Michael, toan, Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension
nnikkhoui edited projects, added Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team Workboards (Contractor Workboard). TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Art-Baltai, nnikkhoui Cc: nnikkhoui, Peter.ovchyn, Umherirrender, thiemowmde, Jdforrester-WMF, Legoktm, Krinkle, Addshore, Daimona, Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY, eprodromou, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, pdehaye, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, Andrawaag, Pablo-WMDE, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Jonas, MGChecker, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension
nnikkhoui added a comment. @Peter.ovchyn ok :) I spent half of yesterday trying to re-produce locally so i could test some fixes and was unable to, even on the correct branches everything was passing. The only thing I did notice was that was another extension is reporting the same error (https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/50811/console) TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Art-Baltai, nnikkhoui Cc: nnikkhoui, Peter.ovchyn, Umherirrender, thiemowmde, Jdforrester-WMF, Legoktm, Krinkle, Addshore, Daimona, Aklapper, Lucas_Werkmeister_WMDE, darthmon_wmde, pdehaye, DannyS712, Nandana, Lahi, Gq86, Andrawaag, Pablo-WMDE, GoranSMilovanovic, Jayprakash12345, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, Jonas, MGChecker, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension
nnikkhoui added a comment. Nice, ok lets see re-check these tests once that gets a +2 ? TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: nnikkhoui Cc: Peter.ovchyn, Umherirrender, thiemowmde, Jdforrester-WMF, Legoktm, Krinkle, Addshore, Daimona, Aklapper, Lucas_Werkmeister_WMDE, darthmon_wmde, pdehaye, DannyS712, Nandana, Lahi, Gq86, Andrawaag, Pablo-WMDE, GoranSMilovanovic, Jayprakash12345, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Jonas, MGChecker, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
