[Wikidata-bugs] [Maniphest] T348999: Add linter and formatter to wmfdata-python (and link check)
nshahquinn-wmf added a project: Movement-Insights. TASK DETAIL https://phabricator.wikimedia.org/T348999 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AndrewTavis_WMDE, nshahquinn-wmf Cc: nshahquinn-wmf, xcollazo, Aklapper, AndrewTavis_WMDE, Danny_Benjafield_WMDE, Mohamed-Awnallah, Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, Invadibot, Ywats0ns, maantietaja, ItamarWMDE, Akuckartz, Mayakp.wiki, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T348999: Add linter and formatter to wmfdata-python (and link check)
nshahquinn-wmf added a comment. @AndrewTavis_WMDE that sounds great to me! I personally have no preference about the package we choose, so I'm on board with the idea of Ruff with the Black ruleset (since that's what Data Engineering uses). Looking forward to it! 😁 TASK DETAIL https://phabricator.wikimedia.org/T348999 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AndrewTavis_WMDE, nshahquinn-wmf Cc: nshahquinn-wmf, xcollazo, Aklapper, AndrewTavis_WMDE, Danny_Benjafield_WMDE, Mohamed-Awnallah, Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, Invadibot, Ywats0ns, maantietaja, ItamarWMDE, Akuckartz, Mayakp.wiki, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T342703: Move generally-useful fields from gdi.country_meta_data to canonical_data.countries
nshahquinn-wmf closed this task as "Resolved". nshahquinn-wmf added a comment. After making some final improvements, I've merged the PR and loaded the new version to the Data Lake! Slack announcement on the way. TASK DETAIL https://phabricator.wikimedia.org/T342703 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AndrewTavis_WMDE, nshahquinn-wmf Cc: gpaumier, Iflorez, Mayakp.wiki, EChetty, CMacholan, JAnstee_WMF, kzimmerman, AndrewTavis_WMDE, nshahquinn-wmf, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T342703: Move generally-useful fields from gdi.country_meta_data to canonical_data.countries
nshahquinn-wmf added a comment. Andrew's current PR addresses also removes the "--" entry. TASK DETAIL https://phabricator.wikimedia.org/T342703 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AndrewTavis_WMDE, nshahquinn-wmf Cc: gpaumier, Iflorez, Mayakp.wiki, EChetty, CMacholan, JAnstee_WMF, kzimmerman, AndrewTavis_WMDE, nshahquinn-wmf, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T342703: Move generally-useful fields from gdi.country_meta_data to canonical_data.countries
nshahquinn-wmf merged a task: T345123: Remove "--" from canonical country data. TASK DETAIL https://phabricator.wikimedia.org/T342703 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AndrewTavis_WMDE, nshahquinn-wmf Cc: gpaumier, Iflorez, Mayakp.wiki, EChetty, CMacholan, JAnstee_WMF, kzimmerman, AndrewTavis_WMDE, nshahquinn-wmf, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T342703: Move generally-useful fields from gdi.country_meta_data to canonical_data.countries
nshahquinn-wmf merged a task: T313270: Add new region definitions to canonical data repository. nshahquinn-wmf added subscribers: kzimmerman, JAnstee_WMF, CMacholan, EChetty, Mayakp.wiki, Iflorez, gpaumier. TASK DETAIL https://phabricator.wikimedia.org/T342703 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AndrewTavis_WMDE, nshahquinn-wmf Cc: gpaumier, Iflorez, Mayakp.wiki, EChetty, CMacholan, JAnstee_WMF, kzimmerman, AndrewTavis_WMDE, nshahquinn-wmf, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T348999: Add linter and formatter to wmfdata-python (and link check)
nshahquinn-wmf added a comment. > The Product Analytics Styleguide suggests PEP 8, but maybe we want to consider black in that it's now Python Software Foundation maintained and can integrate with Ruff. I think it's well worth considering! The only thing I'd want to check first is whether this is significantly different from the MediaWiki Python style and what other Wikimedia Python projects do. TASK DETAIL https://phabricator.wikimedia.org/T348999 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AndrewTavis_WMDE, nshahquinn-wmf Cc: nshahquinn-wmf, xcollazo, Aklapper, AndrewTavis_WMDE, Danny_Benjafield_WMDE, Mohamed-Awnallah, Astuthiodit_1, EChetty, lbowmaker, BTullis, karapayneWMDE, Invadibot, Ywats0ns, maantietaja, ItamarWMDE, Akuckartz, Mayakp.wiki, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, Base, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T341589: Improve df_to_remarkup formatting for wmfdata-python
nshahquinn-wmf added a comment. Just repeating what I shared on Slack for accessibility: I think these changes are absolutely great and ready to merge! Please make a pull request and I or someone else can merge it ASAP 😁 TASK DETAIL https://phabricator.wikimedia.org/T341589 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AndrewTavis_WMDE, nshahquinn-wmf Cc: Aklapper, nshahquinn-wmf, AndrewTavis_WMDE, Danny_Benjafield_WMDE, Mohamed-Awnallah, Astuthiodit_1, EChetty, lbowmaker, BTullis, karapayneWMDE, Invadibot, Ywats0ns, maantietaja, ItamarWMDE, Akuckartz, Mayakp.wiki, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, Base, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org