[Wikidata-bugs] [Maniphest] [Claimed] T242204: Update SpecialNewProperty and SpecialNewItem to use new store conflict detection
sarhan.alaa claimed this task. sarhan.alaa added a subscriber: sarhan. TASK DETAIL https://phabricator.wikimedia.org/T242204 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: sarhan, alaa_wmde, Aklapper, Lucas_Werkmeister_WMDE, Ladsgroup, Addshore, hoo, Lydia_Pintscher, sarhan.alaa, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T242204: Update SpecialNewProperty and SpecialNewItem to use new store conflict detection
sarhan.alaa moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. sarhan.alaa added a comment. I drafted a patch for this, but won't have enough time to clean it up .. it works fine now, but the code is not the prettiest. Specifically, it might require some clean-up around where `TermCollisionDetector` instances come from, as for these two special pages we are getting them directly from WikibaseRepo (where it is determined whether we are using new store or not) but inside `TermsValidatorFactory` it is done using another layer of indirection (with `ByIdFingerprintUniquenessValidator`) and so on.. but probably it is better to do such clean up when migration is done and temporary stuff are removed. TASK DETAIL https://phabricator.wikimedia.org/T242204 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan, sarhan.alaa Cc: alaa_wmde, Aklapper, Lucas_Werkmeister_WMDE, Ladsgroup, Addshore, hoo, Lydia_Pintscher, sarhan.alaa, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T242204: Update SpecialNewProperty and SpecialNewItem to use new store conflict detection
sarhan.alaa created this task. sarhan.alaa added projects: Wikidata, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Addshore. Restricted Application removed a project: Patch-For-Review. TASK DESCRIPTION `SpecialNewProperty` and `SpecialNewItem` directly entities from form data and do their own validation inside `validateFormData`. New store fingure print uniqueness validation was introduced as a validator executed inside `ChangeOpFingerprintResult`, so since the aforementioned two specials do not use `ChangeOp` to create the entities (unlike the other specials such as `SpecialSetAliases` .. etc), they will have to be updated to use the new store conflict detection directly as well. TASK DETAIL https://phabricator.wikimedia.org/T242204 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan, sarhan.alaa Cc: alaa_wmde, Aklapper, Lucas_Werkmeister_WMDE, Ladsgroup, Addshore, hoo, Lydia_Pintscher, sarhan.alaa, Iflorez, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T232040: Add label and description collision detectors for new terms store
sarhan.alaa updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T232040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: Lydia_Pintscher, hoo, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, alaa_wmde, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T232040: Add label and description collision detectors for new terms store
sarhan.alaa added a comment. Oh, apparently `SpecialNewEntity` creates entities without even creating change ops. That would explain it, as then it will by-pass the whole validation of fignreprint uniqueness that is only executed inside `ChangeOpFingerprintResult::validate()`. Guess that needs to change too. TASK DETAIL https://phabricator.wikimedia.org/T232040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: Lydia_Pintscher, hoo, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, alaa_wmde, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T232040: Add label and description collision detectors for new terms store
sarhan.alaa updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T232040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: Lydia_Pintscher, hoo, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, alaa_wmde, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T232040: Add label and description collision detectors for new terms store
sarhan.alaa added a comment. Same goes for items. API calls fail manually as expected, but I can create conflicting items through special pages. I also confirm that `SingleEntitySourceServices::getTermSearchInteractorFactory` and `SingleEntitySourceServices::getPrefetchingTermLookup` need fixing. Will be working on that this evening. note: Seems like that API calls somehow are configure to respect federation, using `PerReopsitoryServiceWiring` that was updated to respect item migration phase too in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/554562, but Special Page would use `SingleEntitySourceServices`. Though conflicting property creation should have failed as `SingleEntitySourceServices` was updated to respect property migration stage. So there could be more buggy code down the call stack. TASK DETAIL https://phabricator.wikimedia.org/T232040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: Lydia_Pintscher, hoo, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, alaa_wmde, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T232040: Add label and description collision detectors for new terms store
sarhan.alaa added a comment. I added two test cases to the integration test editentity fingerprint uniqueness. Those pass in for API calls, which I could also confirm sending API requests manually. But, I can also reproduce it through special pages: I can create conflicting properties (didn't test items). I will next investigate the mentioned `SingleEntitySourceServices::getTermSearchInteractorFactory` and `SingleEntitySourceServices::getPrefetchingTermLookup`. TASK DETAIL https://phabricator.wikimedia.org/T232040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: Lydia_Pintscher, hoo, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, alaa_wmde, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T232040: Add label and description collision detectors for new terms store
sarhan.alaa moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. sarhan.alaa added a comment. In T232040#5774510 <https://phabricator.wikimedia.org/T232040#5774510>, @Addshore wrote: > While reviewing https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/553524/ I noticed that both at least 2 more things need fixing: > > - SingleEntitySourceServices::getTermSearchInteractorFactory > - SingleEntitySourceServices::getPrefetchingTermLookup > > Until that happens its hard to really verify the final patch etc. I will look into this tomorrow TASK DETAIL https://phabricator.wikimedia.org/T232040 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: Lydia_Pintscher, hoo, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, alaa_wmde, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T232040: Add label and description collision detectors for new terms store
sarhan.alaa added a comment. If reviewing the patch in the current state is too much effort or difficult (it can be very much the case), also let me know I can try to split it up further into couple of smaller patches TASK DETAIL https://phabricator.wikimedia.org/T232040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: Lydia_Pintscher, hoo, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, alaa_wmde, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T232040: Add label and description collision detectors for new terms store
sarhan.alaa added a comment. @addshore @ladsgroup We are still on the plan to swit TASK DETAIL https://phabricator.wikimedia.org/T232040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: Lydia_Pintscher, hoo, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, alaa_wmde, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T232040: Add label and description collision detectors for new terms store
sarhan.alaa added a comment. Not sure @Ladsgroup your comments in the review do make sense.. can you please double check them and read through the code again? I may of course have misunderstood them, maybe little more elaboration will help TASK DETAIL https://phabricator.wikimedia.org/T232040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: Lydia_Pintscher, hoo, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, alaa_wmde, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T232040: Add label and description collision detectors for new terms store
sarhan.alaa added a comment. Last patch turning on validation of uniqueness in new store is ready for review now https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/553524 It has 3 little fixes below it too TASK DETAIL https://phabricator.wikimedia.org/T232040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: Lydia_Pintscher, hoo, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, alaa_wmde, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T232040: Add label and description collision detectors for new terms store
sarhan.alaa updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T232040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: Lydia_Pintscher, hoo, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, alaa_wmde, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T232040: Add label and description collision detectors for new terms store
sarhan.alaa claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T232040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: Lydia_Pintscher, hoo, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, alaa_wmde, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section
sarhan.alaa moved this task from Test (Verification) to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. sarhan.alaa added a comment. In T232595#5635743 <https://phabricator.wikimedia.org/T232595#5635743>, @Addshore wrote: > I guess this is still just in beta? Yeap .. We need to patch Wikibase with the latest version of Termbox (or at least up to the version/commit of this change), and bump up the version of Termbox cache version so that older SSR renderings get purged automatically, as this task have caused changes in Termbox markup. Moving to To Do for now, as I might steal half-an-hour to do that patch next week. TASK DETAIL https://phabricator.wikimedia.org/T232595 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde, sarhan.alaa Cc: sarhan.alaa, Addshore, Jan_Dittrich, alaa_wmde, Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, WMDE-leszek, Hanna_Petruschat_WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T230926: Moved Wikidata Item link to Other Projects might break gadgets
sarhan.alaa added a comment. @WMDE-leszek that's great! I remember seeing it differently locally when I tested adding the id back a while back, or maybe I just assed it will land on the `a` tag from the code (that seems to do some magic there). Either way, I should've waited and checked on beta :) We should then be fine.. thanks for patching it up quickly! TASK DETAIL https://phabricator.wikimedia.org/T230926 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: sarhan.alaa, Agusbou2015, Ladsgroup, Lea_Lacroix_WMDE, WMDE-leszek, Liuxinyu970226, Jdforrester-WMF, zeljkofilipin, mmodell, Aklapper, RhinosF1, alaa_wmde, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T230926: Moved Wikidata Item link to Other Projects might break gadgets
sarhan.alaa added a comment. @Ladsgroup yeah probably.. There might still some that might break because the id now is on the `a` tag and not a wrapper element like it used to be. If there's a way to put the id on a wrapper span (might not exist yet) it might avoid those cases too. Not sure if there are more cases, and probably won't have enough time to check for them before tomorrow's train. TASK DETAIL https://phabricator.wikimedia.org/T230926 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: sarhan.alaa, Agusbou2015, Ladsgroup, Lea_Lacroix_WMDE, WMDE-leszek, Liuxinyu970226, Jdforrester-WMF, zeljkofilipin, mmodell, Aklapper, RhinosF1, alaa_wmde, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T215405: Extract Wikibase IdGenerator(s) into a library and use it in WikibaseSchema
sarhan.alaa added a comment. yeah we need some column for such cases. We can call the column Ice Box ? that's a name I'm used to for stuff we wanted to freeze for later for whatever reason.. and then the ones that are to be ignored for real (so not freezing anymore) we would resolve them as invalid eventually (afyer being frozen until next sync meeting?) TASK DETAIL https://phabricator.wikimedia.org/T215405 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: sarhan.alaa, alaa_wmde, Addshore, Aklapper, Lucas_Werkmeister_WMDE, noarave, Tarrow, Michael, darthmon_wmde, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, Jayprakash12345, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Agabi10, Izno, MGChecker, MisterSynergy, abian, Wikidata-bugs, aude, Dinoguy1000, fbstj, Lydia_Pintscher, Mbch331, Jay8g, bd808, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T223856: Improve documentation for WMDE's Wikibase Docker images repository
sarhan.alaa closed this task as "Resolved". sarhan.alaa added a comment. Thanks @waldyrious very much for your contribution on the spot! I'm marking this one resoled for now. When there are more improvements to the documentation we'll follow up on them on github (and possibly Phab tasks). TASK DETAIL https://phabricator.wikimedia.org/T223856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: waldyrious, sarhan.alaa Cc: sarhan.alaa, Aklapper, Ladsgroup, Tarrow, alaa_wmde, waldyrious, darthmon_wmde, Premeditated, Ferenczy, Samuditha24, IM3847, Nandana, kostajh, Cpaulf30, Lahi, Gq86, GoranSMilovanovic, Ivana_Isadora, Jayprakash12345, Chicocvenancio, MichaelSchoenitzer_WMDE, QZanden, LawExplorer, Jogi_don, _jensen, rosalieper, D3r1ck01, srodlund, Wikidata-bugs, Jdlrobson, aude, Dinoguy1000, Addshore, Mbch331, Rxy, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T219499: Item pages should split alias entries containing | character to be consistent with Special:SetAliases
sarhan.alaa removed a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). TASK DETAIL https://phabricator.wikimedia.org/T219499 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: sarhan.alaa, Lydia_Pintscher, alaa_wmde, Lea_Lacroix_WMDE, thiemowmde, Greta_Doci_WMDE, Tarrow, Addshore, Aklapper, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331, Jonas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unassigned] T219499: Item pages should split alias entries containing | character to be consistent with Special:SetAliases
sarhan.alaa removed Greta_Doci_WMDE as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T219499 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: sarhan.alaa, Lydia_Pintscher, alaa_wmde, Lea_Lacroix_WMDE, thiemowmde, Greta_Doci_WMDE, Tarrow, Addshore, Aklapper, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T219499: Item pages should split alias entries containing | character to be consistent with Special:SetAliases
sarhan.alaa moved this task from incoming to ready to go on the Wikidata board. sarhan.alaa added a comment. Moved back to be briefly discussed, estimated and broken down. TASK DETAIL https://phabricator.wikimedia.org/T219499 WORKBOARD https://phabricator.wikimedia.org/project/board/71/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Greta_Doci_WMDE, sarhan.alaa Cc: sarhan.alaa, Lydia_Pintscher, alaa_wmde, Lea_Lacroix_WMDE, thiemowmde, Greta_Doci_WMDE, Tarrow, Addshore, Aklapper, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T219499: Item pages should split alias entries containing | character to be consistent with Special:SetAliases
sarhan.alaa updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T219499 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Greta_Doci_WMDE, sarhan.alaa Cc: sarhan.alaa, Lydia_Pintscher, alaa_wmde, Lea_Lacroix_WMDE, thiemowmde, Greta_Doci_WMDE, Tarrow, Addshore, Aklapper, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T219499: Item pages should split alias entries containing | character to be consistent with Special:SetAliases
sarhan.alaa updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T219499 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Greta_Doci_WMDE, sarhan.alaa Cc: sarhan.alaa, Lydia_Pintscher, alaa_wmde, Lea_Lacroix_WMDE, thiemowmde, Greta_Doci_WMDE, Tarrow, Addshore, Aklapper, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T219499: Item pages should split alias entries containing | character to be consistent with Special:SetAliases
sarhan.alaa added a comment. Wow in minutes .. it took a query on wb_terms >5 minutes to get 50 results only. Same on Query Service. How did you find those? As for the task, this makes the costs of solution 1 we did so far even higher than solution 2 (change SetAliases to support | somehow). Thanks @Addshore for pulling these missing data for us. (I hope we will start to include that from now on before hand when it is a solution task ;) @Lydia_Pintscher I will update the task again with these cases, and take a look at the suggest options by @thiemowmde for solution 2 to see which one we go with and consult with you on Monday. TASK DETAIL https://phabricator.wikimedia.org/T219499 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Greta_Doci_WMDE, sarhan.alaa Cc: sarhan.alaa, Lydia_Pintscher, alaa_wmde, Lea_Lacroix_WMDE, thiemowmde, Greta_Doci_WMDE, Tarrow, Addshore, Aklapper, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T220150: Clean up unused records
sarhan.alaa added a comment. oh yeah sure that won't be running in production like that .. I just was wondering if there are any extra optimization here that I could've missed re using indexes or using the sub-queries. re running in batches, sure it should limit deleting to an acceptable amount.. and as long as we run frequently enough, then it shouldn't be an issue for both retaining deleted data for long nor for performance. thanks @Addshore for the feedback, I'll submit a production-ready batch to get more feedback on a final solution there TASK DETAIL https://phabricator.wikimedia.org/T220150 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sarhan.alaa Cc: sarhan.alaa, Ladsgroup, Addshore, alaa_wmde, Aklapper, JeroenDeDauw, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
