[Wikidata-bugs] [Maniphest] [Changed Project Column] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[dom_walden]

dom_walden moved this task from QA/Testing to Done on the Anti-Harassment (The 
Letter Song) board.
dom_walden added a comment.


  In T207893#5431725 , 
@WMDE-leszek wrote:
  
  > thanks @dom_walden ! So are we fine to conclude this is now resolved?
  
  If everyone else is happy, then I'm happy :)

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4113/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, dom_walden
Cc: alaa_wmde, dom_walden, hoo, Ladsgroup, Tchanders, Niharika, 
Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, 
Aklapper, dbarratt, MGChecker, darthmon_wmde, MattLongCT, DannyS712, Nandana, 
aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, 
JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, 
Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Project Column] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[dbarratt]

dbarratt moved this task from Test (Verification) to Doing on the 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
dbarratt added a comment.


  Oversight on my part, it looks like the creation code (in both patches) is 
using `AbstractBlock::isSitewide()` instead of 
`AbstractBlock::appliesToNamespace()` (as is outlined in the task description). 
Using the former means that someone who is blocked from a namespace **will** be 
allowed to create an item in that namespace, using the latter will ensure they 
are blocked properly from that namespace.

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, dbarratt
Cc: alaa_wmde, dom_walden, hoo, Ladsgroup, Tchanders, Niharika, 
Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, 
Aklapper, dbarratt, MGChecker, darthmon_wmde, MattLongCT, DannyS712, Nandana, 
aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, 
JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, 
Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Project Column] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[dbarratt]

dbarratt moved this task from Review to QA/Testing on the Anti-Harassment (The 
Letter Song) board.
dbarratt added a comment.


  In T207893#5409768 , 
@alaa_wmde wrote:
  
  > @dbarratt @Niharika have you tested this? is it good?
  
  It works beautifully for me! I will allow @dom_walden to take a look if he 
wants too, otherwise I think this is good to enable on production. :)

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4113/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, dbarratt
Cc: alaa_wmde, dom_walden, hoo, Ladsgroup, Tchanders, Niharika, 
Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, 
Aklapper, dbarratt, MGChecker, darthmon_wmde, MattLongCT, DannyS712, Nandana, 
aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, 
JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, 
Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Project Column] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[hoo]

hoo moved this task from Peer Review to Test (Verification) on the 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
hoo added a comment.


  I assume this is done now… feel free to move this back if anything is missing.

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, hoo
Cc: hoo, Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, 
TBolliger, Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, MattLongCT, 
alaa_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, aezell, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Darkminds3113, dmaza, Bsandipan, Lordiis, GoranSMilovanovic, SPoore, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, 
Jonas, Wong128hk, Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Project Column] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[dbarratt]

dbarratt moved this task from Blocked / Waiting / External to Needs Work on the 
Wikidata-Campsite board.
dbarratt added a comment.


  In T207893#5250838 , 
@Addshore wrote:
  
  >
  
  
  > So I guess we use BlockManager to get the blocks of a user?
  
  You can use either `User::getBlock()` or `BlockManager::getUserBlock()`. They 
are //slightly// different, but for your purposes, it should always return the 
same result.
  
  > And then check the blocks to see if they apply to the namespace we are 
creating in?
  
  Yes. :)
  
  > Blockmanager::getUserBlock only returns one block ("the most relevant 
one"), what happens in the situation when a user has 2 block for different 
namespaces?
  
  You will get a `CompositeBlock` object which will extend from `AbstractBlock` 
class and have all of the same methods. MediaWiki has, up until this week, 
always returned a single, most-relevant block anyways. Starting soon, you'll 
get a `CompositeBlock` which can be used the same way.
  
  > Is there a way to get all blocks of a user? Or a way to see if any of a 
users blocks apply to a namespace?
  
  We could probably build that into `CompositeBlock` if you really need them, 
but calling `::appliesToNamespace()` on the `AbstractBlock` returned from 
`User::getBlock()` should be what you want.
  
  > Maybe we need a User::isBlockedFromNamespace, or rather 
PermissionManager::isBlockedFromNamespace() ?
  
  I think the best way would be to determine if the `AbstractBlock` applies to 
the namespace with `AbstractBlock::appliesToNamespace()`.

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3402/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: dbarratt
Cc: Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, 
Addshore, Aklapper, dbarratt, MGChecker, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Project Column] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[Addshore]

Addshore moved this task from Needs Work to Blocked / Waiting / External on the 
Wikidata-Campsite board.
Addshore added a comment.


  Going to move to waiting until the above comment has a response regarding the 
namespace checks.

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3402/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, 
Addshore, Aklapper, dbarratt, MGChecker, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs