[Wikidata-bugs] [Maniphest] [Commented On] T100993: General code-review of WikidataQualityExternalValidation extension
gerritbot added a comment. Change 217809 abandoned by Daniel Kinzler: [DNM] review diff of v1 against blank repo Reason: done https://gerrit.wikimedia.org/r/217809 TASK DETAIL https://phabricator.wikimedia.org/T100993 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, gerritbot Cc: Tamslo, gerritbot, Tobi_WMDE_SW, Lydia_Pintscher, Aklapper, Wikibase-Quality-External-Validation, Ricordisamoa, Liuxinyu970226, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T100993: General code-review of WikidataQualityExternalValidation extension
Tamslo added a subscriber: Tamslo. Tamslo added a comment. The URL of the repository changed, see the description. TASK DETAIL https://phabricator.wikimedia.org/T100993 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, Tamslo Cc: Tamslo, gerritbot, Tobi_WMDE_SW, Lydia_Pintscher, Aklapper, Wikibase-Quality-External-Validation, Ricordisamoa, Liuxinyu970226, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T100993: General code-review of WikidataQualityExternalValidation extension
gerritbot added a comment. Change 218636 merged by Dominic.sauer: Implemented further hints from review from Daniel. https://gerrit.wikimedia.org/r/218636 TASK DETAIL https://phabricator.wikimedia.org/T100993 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, gerritbot Cc: gerritbot, Tobi_WMDE_SW, Lydia_Pintscher, Aklapper, Wikidata-Quality-External-Validation, Ricordisamoa, Liuxinyu970226, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T100993: General code-review of WikidataQualityExternalValidation extension
gerritbot added a comment. Change 218636 had a related patch set uploaded (by Soeren.oldag): Implemented further hints from review from Daniel. Tests for ComparativeValueParsers still to come. https://gerrit.wikimedia.org/r/218636 TASK DETAIL https://phabricator.wikimedia.org/T100993 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, gerritbot Cc: gerritbot, Tobi_WMDE_SW, Lydia_Pintscher, Aklapper, Wikidata-Quality-External-Validation, Ricordisamoa, Liuxinyu970226, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T100993: General code-review of WikidataQualityExternalValidation extension
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 217809 had a related patch set uploaded (by Daniel Kinzler): [DNM] review diff of v1 against blank repo https://gerrit.wikimedia.org/r/217809 TASK DETAIL https://phabricator.wikimedia.org/T100993 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, gerritbot Cc: gerritbot, Tobi_WMDE_SW, Lydia_Pintscher, Aklapper, Wikidata-Quality-External-Validation, Ricordisamoa, Liuxinyu970226, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs