[Wikidata-bugs] [Maniphest] [Commented On] T103626: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs
JanZerebecki added a comment. Maybe on the quality side the workaround needs to be partially removed? TASK DETAIL https://phabricator.wikimedia.org/T103626 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, JanZerebecki Cc: Tobi_WMDE_SW, JanZerebecki, gerritbot, Addshore, Krinkle, Aklapper, hoo, Wikidata-bugs, aude, hashar, greg, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T103626: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs
hoo added a comment. In https://phabricator.wikimedia.org/T103626#1425094, @JanZerebecki wrote: Maybe on the quality side the workaround needs to be partially removed? I talked to Addshore about this on IRC on Tuesday, that lead to the creation of the other ticket. Keeping the workaround is fine, it doesn't hurt. TASK DETAIL https://phabricator.wikimedia.org/T103626 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, hoo Cc: Tobi_WMDE_SW, JanZerebecki, gerritbot, Addshore, Krinkle, Aklapper, hoo, Wikidata-bugs, aude, hashar, greg, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T103626: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs
gerritbot added a comment. Change 221899 merged by jenkins-bot: Run mw-set-env for WikibaseQuality* tests https://gerrit.wikimedia.org/r/221899 TASK DETAIL https://phabricator.wikimedia.org/T103626 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, gerritbot Cc: gerritbot, Addshore, Krinkle, Aklapper, hoo, Wikidata-bugs, aude, hashar, greg, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T103626: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs
Addshore added a comment. Filed a task for adding it back with this as a blocker. Suddenly this task makes more sense ;) TASK DETAIL https://phabricator.wikimedia.org/T103626 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, Krinkle, Aklapper, hoo, Wikidata-bugs, aude, hashar, greg, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T103626: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 221899 had a related patch set uploaded (by Addshore): Run mw-set-env for WikibaseQuality* tests https://gerrit.wikimedia.org/r/221899 TASK DETAIL https://phabricator.wikimedia.org/T103626 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, gerritbot Cc: gerritbot, Addshore, Krinkle, Aklapper, hoo, Wikidata-bugs, aude, hashar, greg, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T103626: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs
JanZerebecki added a comment. https://gerrit.wikimedia.org/r/#/c/220339/ TASK DETAIL https://phabricator.wikimedia.org/T103626 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: Aklapper, hoo, Wikidata-bugs, aude, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T103626: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs
hoo added a comment. In https://phabricator.wikimedia.org/T103626#1396333, @JanZerebecki wrote: https://gerrit.wikimedia.org/r/#/c/220339/ That's a workaround, to make sure we can include `Maintenance.php` if the maintenance script is invoked manually, yet it doesn't break on Jenkins, as we only include `Maintenance.php` if `Maintenance` isn't already loaded. TASK DETAIL https://phabricator.wikimedia.org/T103626 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, hoo Cc: Aklapper, hoo, Wikidata-bugs, aude, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T103626: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs
Krinkle added a subscriber: Krinkle. Krinkle added a comment. This job creates LocalSettings.php (mw-apply-settings.sh), and runs install.php, and update.php (mw-run-update-script.sh) without problems. That means `MW_INSTALL_PATH` is definitely set correctly. The problem is that the mwext-WikibaseQualityConstraints-repo-tests-sqlite-hhvm job then has a separate shell execution step (which gets a new shell environment) and doesn't source the environment first. As such, `MW_INSTALL_PATH` isn't set wrong, but not set at all. Run `mw-set-env.sh` before the phpunit test, then it should work fine. You may also want to use that variable in the `cd` command so that `$WORKSPACE/src` isn't hardcoded (which is subject to change). TASK DETAIL https://phabricator.wikimedia.org/T103626 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, Krinkle Cc: Krinkle, Aklapper, hoo, Wikidata-bugs, aude, hashar, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
