[Wikidata-bugs] [Maniphest] [Commented On] T110436: Heading in banners rendered by WikidataPageBanner has broken section collapsing in mobile view.
gerritbot added a comment. Change 234314 abandoned by Florianschmidtwelzow: Be more restrictive when selecting the tag for the first heading Reason: Ok, that's an argument. https://gerrit.wikimedia.org/r/234314 TASK DETAIL https://phabricator.wikimedia.org/T110436 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Florian, gerritbot Cc: Krenair, gerritbot, Sumit, Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T110436: Heading in banners rendered by WikidataPageBanner has broken section collapsing in mobile view.
gerritbot added a comment. Change 234314 had a related patch set uploaded (by Florianschmidtwelzow): Be more restrictive when selecting the tag for the first heading https://gerrit.wikimedia.org/r/234314 TASK DETAIL https://phabricator.wikimedia.org/T110436 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Florian, gerritbot Cc: gerritbot, Sumit, Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T110436: Heading in banners rendered by WikidataPageBanner has broken section collapsing in mobile view.
Jdlrobson added a comment. @Florian unfortunately it's all related :-/ Maybe the safest thing to try now is @sumit suggestion but make the arrays for first headings configurable - that way we don't risk inadvertently breaking other wikis. TASK DETAIL https://phabricator.wikimedia.org/T110436 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Sumit, Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T110436: Heading in banners rendered by WikidataPageBanner has broken section collapsing in mobile view.
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 234307 had a related patch set uploaded (by Florianschmidtwelzow): Hotfix: Make the list of possible top headings configurable https://gerrit.wikimedia.org/r/234307 TASK DETAIL https://phabricator.wikimedia.org/T110436 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Florian, gerritbot Cc: gerritbot, Sumit, Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T110436: Heading in banners rendered by WikidataPageBanner has broken section collapsing in mobile view.
gerritbot added a comment. Change 234307 merged by jenkins-bot: Make the list of possible top headings configurable https://gerrit.wikimedia.org/r/234307 TASK DETAIL https://phabricator.wikimedia.org/T110436 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Florian, gerritbot Cc: gerritbot, Sumit, Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T110436: Heading in banners rendered by WikidataPageBanner has broken section collapsing in mobile view.
gerritbot added a comment. Change 234331 merged by jenkins-bot: Make the list of possible top headings configurable https://gerrit.wikimedia.org/r/234331 TASK DETAIL https://phabricator.wikimedia.org/T110436 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Florian, gerritbot Cc: gerritbot, Sumit, Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T110436: Heading in banners rendered by WikidataPageBanner has broken section collapsing in mobile view.
Sumit added a subscriber: Sumit. Sumit added a comment. Removing h1 from list of tags defined in MobileFormatter::findTopHeading() would solve the problem. Would that however lead to side effects? TASK DETAIL https://phabricator.wikimedia.org/T110436 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit Cc: Sumit, Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T110436: Heading in banners rendered by WikidataPageBanner has broken section collapsing in mobile view.
gerritbot added a comment. Change 234330 had a related patch set uploaded (by Alex Monk): Disable section collapsing on h1s in Wikivoyage https://gerrit.wikimedia.org/r/234330 TASK DETAIL https://phabricator.wikimedia.org/T110436 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Florian, gerritbot Cc: gerritbot, Sumit, Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T110436: Heading in banners rendered by WikidataPageBanner has broken section collapsing in mobile view.
gerritbot added a comment. Change 234330 merged by jenkins-bot: Disable section collapsing on h1s in Wikivoyage https://gerrit.wikimedia.org/r/234330 TASK DETAIL https://phabricator.wikimedia.org/T110436 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Florian, gerritbot Cc: gerritbot, Sumit, Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T110436: Heading in banners rendered by WikidataPageBanner has broken section collapsing in mobile view.
Jdlrobson added a comment. Easiest thing to do I think is to change (h[1-6]) and (h[2-6]) turn off support for section collapsing in MobileFormatter.php on the h1 level. It's a rare edgecase any how. If someone can fix I'll get this SWAT deployed tomorrow. TASK DETAIL https://phabricator.wikimedia.org/T110436 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
