[Wikidata-bugs] [Maniphest] [Commented On] T114538: Extract/Remove ORM from MediaWiki core and move to Vendor repo

2015-10-06 Thread Reedy 
Reedy added a comment.

In https://phabricator.wikimedia.org/T114538#1705551, @TFlanagan-WMF wrote:

> Jumping in for the education team. We have many programs that are dependent 
> on the education program extension (however flawed it may be) on over a dozen 
> Wikimedia projects, so I would ask that nothing be removed that would cause 
> the extension to fail. It is unclear what is proposed since I don't have a 
> strong technical background. Could someone explain in plain English what is 
> proposed and how it would impact our extension, as well as the urgency for 
> making any changes?
>
> As mentioned in other comments here and elsewhere, there is a hope for 
> something newer and better than the current 
> https://phabricator.wikimedia.org/tag/mediawiki-extensions-educationprogram/, 
> but that is at least a year off AFAIK. We have no engineering resources to 
> even begin building something or adapting the WikiEd Foundation's dashboard 
>  for our 
> global stakeholders.
>
> Copying my colleagues to this thread who may have more context.


We're not going to break anything (not purposely anyway). There will be a few 
minor changes in the Education Program extension, but we will make sure it 
keeps working.

We're just moving an amount of code from core MediaWiki and putting it 
elsewhere.

FYI, we have been doing these sorts of changes to MediaWiki for a while, moving 
out "reuseable" code etc


TASK DETAIL
  https://phabricator.wikimedia.org/T114538

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Reedy
Cc: AKoval_WMF, FloorKoudijs, TFlanagan-WMF, hoo, aude, MZMcBride, 
JeroenDeDauw, Aklapper, Reedy, Wikidata-bugs, AndyRussG, Ragesoss, Legoktm



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T114538: Extract/Remove ORM from MediaWiki core and move to Vendor repo

2015-10-06 Thread Reedy 
Reedy added a comment.

Suggestions for a repo name? :D


TASK DETAIL
  https://phabricator.wikimedia.org/T114538

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Reedy
Cc: Ricordisamoa, gerritbot, AKoval_WMF, FloorKoudijs, TFlanagan-WMF, hoo, 
aude, MZMcBride, JeroenDeDauw, Aklapper, Reedy, Wikidata-bugs, AndyRussG, 
Ragesoss, Legoktm



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T114538: Extract/Remove ORM from MediaWiki core and move to Vendor repo

2015-10-06 Thread gerritbot 
gerritbot added a comment.

Change 243966 merged by jenkins-bot:
Remove ORM use from DBSiteStore

https://gerrit.wikimedia.org/r/243966


TASK DETAIL
  https://phabricator.wikimedia.org/T114538

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Ricordisamoa, gerritbot, AKoval_WMF, FloorKoudijs, TFlanagan-WMF, hoo, 
aude, MZMcBride, JeroenDeDauw, Aklapper, Reedy, Wikidata-bugs, AndyRussG, 
Ragesoss, Legoktm



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T114538: Extract/Remove ORM from MediaWiki core and move to Vendor repo

2015-10-06 Thread aude 
aude added a subscriber: aude.
aude added a comment.

Unless I am forgetting something, I think the only places in Wikibase (and 
core) that use ORM are the sites table and wb_changes table.  imho, sites 
should move away from using a database backend altogether. (the sites 
information is config and should be stored in a config file)

wb_changes should move away from ORM

I don't know about education program, but also thought folks were working on 
something new there.

that said, if someone wants to maintain the ORM code as a library, then fine 
with me


TASK DETAIL
  https://phabricator.wikimedia.org/T114538

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aude
Cc: aude, MZMcBride, JeroenDeDauw, Aklapper, Reedy, AKoval_WMF, Wikidata-bugs, 
TFlanagan-WMF, AndyRussG, Ragesoss, Legoktm



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T114538: Extract/Remove ORM from MediaWiki core and move to Vendor repo

2015-10-06 Thread JeroenDeDauw 
JeroenDeDauw added a comment.

Those are also the 3 places I'm aware of, and I agree they all those move away 
from using this code. If the sites stuff and Wikibase do this, then you could 
move the ORM code to the EP extension.


TASK DETAIL
  https://phabricator.wikimedia.org/T114538

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: JeroenDeDauw
Cc: aude, MZMcBride, JeroenDeDauw, Aklapper, Reedy, AKoval_WMF, Wikidata-bugs, 
TFlanagan-WMF, AndyRussG, Ragesoss, Legoktm



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T114538: Extract/Remove ORM from MediaWiki core and move to Vendor repo

2015-10-06 Thread gerritbot 
gerritbot added a comment.

Change 243966 had a related patch set uploaded (by Anomie):
Remove ORM use from DBSiteStore

https://gerrit.wikimedia.org/r/243966


TASK DETAIL
  https://phabricator.wikimedia.org/T114538

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, AKoval_WMF, FloorKoudijs, TFlanagan-WMF, hoo, aude, MZMcBride, 
JeroenDeDauw, Aklapper, Reedy, Wikidata-bugs, AndyRussG, Ragesoss, Legoktm



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T114538: Extract/Remove ORM from MediaWiki core and move to Vendor repo

2015-10-06 Thread Reedy 
Reedy added a comment.

  16:05:52 Fatal error: Class undefined: ORMTable in 
/mnt/jenkins-workspace/workspace/mediawiki-phpunit-hhvm/src/includes/site/DBSiteStore.php
 on line 346

DAMN IT


TASK DETAIL
  https://phabricator.wikimedia.org/T114538

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Reedy
Cc: gerritbot, AKoval_WMF, FloorKoudijs, TFlanagan-WMF, hoo, aude, MZMcBride, 
JeroenDeDauw, Aklapper, Reedy, Wikidata-bugs, AndyRussG, Ragesoss, Legoktm



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T114538: Extract/Remove ORM from MediaWiki core and move to Vendor repo

2015-10-06 Thread gerritbot 
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.

Change 243945 had a related patch set uploaded (by Reedy):
[WIP] Remove ORM code from core

https://gerrit.wikimedia.org/r/243945


TASK DETAIL
  https://phabricator.wikimedia.org/T114538

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, AKoval_WMF, FloorKoudijs, TFlanagan-WMF, hoo, aude, MZMcBride, 
JeroenDeDauw, Aklapper, Reedy, Wikidata-bugs, AndyRussG, Ragesoss, Legoktm



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T114538: Extract/Remove ORM from MediaWiki core and move to Vendor repo

2015-10-05 Thread Reedy 
Reedy added a comment.

EducationProgram and Wikidata/Wikibase seem to be the only real users of this 
code

So, it wants extracting from core into a separate repo. Adding to the WMF 
vendor repo (for extension purposes), and then said repo wants adding as a 
dependancy via composer to EducationProgram and Wikidata/Wikibase

There's also the API module to go with it too


TASK DETAIL
  https://phabricator.wikimedia.org/T114538

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Reedy
Cc: JeroenDeDauw, Aklapper, Reedy, AKoval_WMF, Wikidata-bugs, aude, 
TFlanagan-WMF, AndyRussG, Ragesoss, Legoktm



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs