[Wikidata-bugs] [Maniphest] [Commented On] T117886: don't fail when running job mediawiki-extensions-qunit with Wikidata

2016-01-27 Thread thiemowmde 
thiemowmde added a comment.

More patches for review:

- https://github.com/wmde/WikibaseSerializationJavaScript/pull/33
- https://github.com/wmde/WikibaseDataModelJavaScript/pull/56
- https://gerrit.wikimedia.org/r/266700

And then, hopefully, https://gerrit.wikimedia.org/r/263353.


TASK DETAIL
  https://phabricator.wikimedia.org/T117886

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: gerritbot, thiemowmde, adrianheine, Aklapper, JanZerebecki, Wikidata-bugs, 
aude, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T117886: don't fail when running job mediawiki-extensions-qunit with Wikidata

2016-01-27 Thread gerritbot 
gerritbot added a comment.

Change 266700 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Added compatibility with DataValues JavaScript 0.8.0

https://gerrit.wikimedia.org/r/266700


TASK DETAIL
  https://phabricator.wikimedia.org/T117886

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, thiemowmde, adrianheine, Aklapper, JanZerebecki, Wikidata-bugs, 
aude, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T117886: don't fail when running job mediawiki-extensions-qunit with Wikidata

2016-01-27 Thread gerritbot 
gerritbot added a comment.

Change 266700 merged by jenkins-bot:
Added compatibility with DataValues JavaScript 0.8.0

https://gerrit.wikimedia.org/r/266700


TASK DETAIL
  https://phabricator.wikimedia.org/T117886

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, thiemowmde, adrianheine, Aklapper, JanZerebecki, Wikidata-bugs, 
aude, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T117886: don't fail when running job mediawiki-extensions-qunit with Wikidata

2016-01-27 Thread gerritbot 
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.

Change 263353 had a related patch set uploaded (by Adrian Lang):
[DNM] Set QUnit.config.requireExpects to true

https://gerrit.wikimedia.org/r/263353


TASK DETAIL
  https://phabricator.wikimedia.org/T117886

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, thiemowmde, adrianheine, Aklapper, JanZerebecki, Wikidata-bugs, 
aude, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T117886: don't fail when running job mediawiki-extensions-qunit with Wikidata

2016-01-27 Thread adrianheine 
adrianheine added a comment.

In https://phabricator.wikimedia.org/T117886#1891371, @JanZerebecki wrote:

> By commenting on a change in Wikidata with: check experimental


If you meant Wikibase, this does not work currently 
. Maybe jobs got re-deployed?


TASK DETAIL
  https://phabricator.wikimedia.org/T117886

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: adrianheine
Cc: thiemowmde, adrianheine, Aklapper, JanZerebecki, Wikidata-bugs, aude, 
Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T117886: don't fail when running job mediawiki-extensions-qunit with Wikidata

2016-01-27 Thread gerritbot 
gerritbot added a comment.

Change 263353 merged by jenkins-bot:
Set QUnit.config.requireExpects to true

https://gerrit.wikimedia.org/r/263353


TASK DETAIL
  https://phabricator.wikimedia.org/T117886

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, thiemowmde, adrianheine, Aklapper, JanZerebecki, Wikidata-bugs, 
aude, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T117886: don't fail when running job mediawiki-extensions-qunit with Wikidata

2016-01-27 Thread gerritbot 
gerritbot added a comment.

Change 266718 merged by jenkins-bot:
Added compatibility with DataValues JavaScript 0.8.0

https://gerrit.wikimedia.org/r/266718


TASK DETAIL
  https://phabricator.wikimedia.org/T117886

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, thiemowmde, adrianheine, Aklapper, JanZerebecki, Wikidata-bugs, 
aude, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T117886: don't fail when running job mediawiki-extensions-qunit with Wikidata

2016-01-27 Thread gerritbot 
gerritbot added a comment.

Change 266718 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Added compatibility with DataValues JavaScript 0.8.0

https://gerrit.wikimedia.org/r/266718


TASK DETAIL
  https://phabricator.wikimedia.org/T117886

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, thiemowmde, adrianheine, Aklapper, JanZerebecki, Wikidata-bugs, 
aude, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T117886: don't fail when running job mediawiki-extensions-qunit with Wikidata

2016-01-07 Thread adrianheine 
adrianheine added a comment.

This won't fix all errors, we need to do the same for all JS repos.


TASK DETAIL
  https://phabricator.wikimedia.org/T117886

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: adrianheine
Cc: thiemowmde, adrianheine, Aklapper, JanZerebecki, Wikidata-bugs, aude, 
Arrbee, KartikMistry, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T117886: don't fail when running job mediawiki-extensions-qunit with Wikidata

2016-01-07 Thread adrianheine 
adrianheine added a comment.

https://gerrit.wikimedia.org/r/#/c/262891/
https://gerrit.wikimedia.org/r/#/c/262890/
https://github.com/wmde/DataValuesJavascript/pull/90


TASK DETAIL
  https://phabricator.wikimedia.org/T117886

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: adrianheine
Cc: thiemowmde, adrianheine, Aklapper, JanZerebecki, Wikidata-bugs, aude, 
Arrbee, KartikMistry, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T117886: don't fail when running job mediawiki-extensions-qunit with Wikidata

2015-12-18 Thread JanZerebecki 
JanZerebecki added a comment.

By commenting on a change in Wikidata with: check experimental


TASK DETAIL
  https://phabricator.wikimedia.org/T117886

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: JanZerebecki
Cc: thiemowmde, adrianheine, Aklapper, JanZerebecki, Wikidata-bugs, aude, 
Arrbee, KartikMistry, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T117886: don't fail when running job mediawiki-extensions-qunit with Wikidata

2015-12-09 Thread adrianheine 
adrianheine added a comment.

https://github.com/wmde/WikibaseDataModelJavaScript/pull/36


TASK DETAIL
  https://phabricator.wikimedia.org/T117886

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: adrianheine
Cc: adrianheine, Aklapper, JanZerebecki, Wikidata-bugs, aude, Arrbee, 
KartikMistry, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T117886: don't fail when running job mediawiki-extensions-qunit with Wikidata

2015-12-09 Thread adrianheine 
adrianheine added a comment.

Ok, this is about something completely different, and if I'd have bothered to 
actually look I'd have seen it. core's QUnit test runner requires all test 
cases to state how many assertions they expect; Wikibase's does not, and so we 
didn't specify it in most of our tests. I'll prepare patches.


TASK DETAIL
  https://phabricator.wikimedia.org/T117886

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: adrianheine
Cc: adrianheine, Aklapper, JanZerebecki, Wikidata-bugs, aude, Arrbee, 
KartikMistry, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T117886: don't fail when running job mediawiki-extensions-qunit with Wikidata

2015-12-08 Thread JanZerebecki 
JanZerebecki added a comment.

Still fails after recent changes: 
https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/22105/console


TASK DETAIL
  https://phabricator.wikimedia.org/T117886

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: JanZerebecki
Cc: adrianheine, Aklapper, JanZerebecki, Wikidata-bugs, aude, Arrbee, 
KartikMistry, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs