[Wikidata-bugs] [Maniphest] [Commented On] T118960: unescape escaped | from example queries

2015-12-08 Thread gerritbot 
gerritbot added a comment.

Change 256198 merged by jenkins-bot:
Query Example Dialog

https://gerrit.wikimedia.org/r/256198


TASK DETAIL
  https://phabricator.wikimedia.org/T118960

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jonas, gerritbot
Cc: gerritbot, Smalyshev, Jheald, Jonas, Aklapper, JanZerebecki, StudiesWorld, 
jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T118960: unescape escaped | from example queries

2015-12-07 Thread gerritbot 
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.

Change 256198 had a related patch set uploaded (by Jonas Kress (WMDE)):
Query Example Dialog

https://gerrit.wikimedia.org/r/256198


TASK DETAIL
  https://phabricator.wikimedia.org/T118960

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jonas, gerritbot
Cc: gerritbot, Smalyshev, Jheald, Jonas, Aklapper, JanZerebecki, StudiesWorld, 
jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T118960: unescape escaped | from example queries

2015-12-05 Thread Smalyshev 
Smalyshev added a comment.

@Jonas I can think of only `{{!}}` for now, I guess if we discover more in the 
future we'll add them.


TASK DETAIL
  https://phabricator.wikimedia.org/T118960

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jonas, Smalyshev
Cc: Smalyshev, Jheald, Jonas, Aklapper, JanZerebecki, StudiesWorld, jkroll, 
Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T118960: unescape escaped | from example queries

2015-12-05 Thread Jonas 
Jonas added a comment.

So simply replace {{!}} with | ? 
Are there more special syntax things I should know about?


TASK DETAIL
  https://phabricator.wikimedia.org/T118960

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jonas
Cc: Smalyshev, Jheald, Jonas, Aklapper, JanZerebecki, StudiesWorld, jkroll, 
Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T118960: unescape escaped | from example queries

2015-12-05 Thread Jheald 
Jheald added a comment.

Sorry, I understand now.

The problem is specifically when the example query is loaded using the 
drop-down menu on the query-editor page, (rather than by following a link on 
the wiki page.)

//That// is when the wikitext un-escaping is being missed.


TASK DETAIL
  https://phabricator.wikimedia.org/T118960

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jonas, Jheald
Cc: Smalyshev, Jheald, Jonas, Aklapper, JanZerebecki, StudiesWorld, jkroll, 
Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T118960: unescape escaped | from example queries

2015-12-05 Thread Jheald 
Jheald added a comment.

Yes I know that.

But if the text displays fine on the page (which it does), and transfers fine 
to the query editor (which it does), then what is the probem with having 
`{{!}}` in the source wikitext ?


TASK DETAIL
  https://phabricator.wikimedia.org/T118960

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jonas, Jheald
Cc: Smalyshev, Jheald, Jonas, Aklapper, JanZerebecki, StudiesWorld, jkroll, 
Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T118960: unescape escaped | from example queries

2015-12-04 Thread Smalyshev 
Smalyshev added a subscriber: Smalyshev.
Smalyshev added a comment.

If you take the example of a query "American universities founded before the 
states they reside in were created" on query.wikidata.org, it is broken, since 
it uses `{{!}}` instead of `|`. This is because `|` is special in wikitext, so 
you have to use `{{!}}` to display `|`. When loading examples from wikitext, 
the translation of `{{!}}` to `|` should be performed.


TASK DETAIL
  https://phabricator.wikimedia.org/T118960

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev
Cc: Smalyshev, Jheald, Jonas, Aklapper, JanZerebecki, StudiesWorld, jkroll, 
Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T118960: unescape escaped | from example queries

2015-12-04 Thread Jheald 
Jheald added a subscriber: Jheald.
Jheald added a comment.

I don't understand the problem.

The query displays correctly on the page, and loads and executes correctly in 
the query editor.


TASK DETAIL
  https://phabricator.wikimedia.org/T118960

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jheald
Cc: Jheald, Jonas, Aklapper, JanZerebecki, StudiesWorld, jkroll, Smalyshev, 
Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs