[Wikidata-bugs] [Maniphest] [Commented On] T129450: Save link does not become active when removing a sitelink

2016-03-10 Thread gerritbot 
gerritbot added a comment.


  Change 276448 had a related patch set uploaded (by Aude):
  Check length of site link list in sitelinklistview::isInitialValue
  
  https://gerrit.wikimedia.org/r/276448

TASK DETAIL
  https://phabricator.wikimedia.org/T129450

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Jonas, thiemowmde, Bene, adrianheine, aude, Nikki, Aklapper, 
D3r1ck01, Izno, Wikidata-bugs, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T129450: Save link does not become active when removing a sitelink

2016-03-10 Thread aude 
aude added a comment.


  git bisect tells me that https://gerrit.wikimedia.org/r/#/c/266727/ is the 
issue

TASK DETAIL
  https://phabricator.wikimedia.org/T129450

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aude
Cc: Jonas, thiemowmde, Bene, adrianheine, aude, Nikki, Aklapper, D3r1ck01, 
Izno, Wikidata-bugs, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T129450: Save link does not become active when removing a sitelink

2016-03-10 Thread aude 
aude added a comment.


  i'm looking at this (though maybe better for Adrian etc. to look)...
  
  in 
https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/view/resources/jquery/wikibase/toolbar/controller/definitions/edittoolbar/sitelinkgroupview.js#L53
  
  sitelinkgroupview.isInitialValue() is true after i click the trash can, 
whereas i think it should be false and then trigger enabling the save button

TASK DETAIL
  https://phabricator.wikimedia.org/T129450

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aude
Cc: aude, Nikki, Aklapper, D3r1ck01, Izno, Wikidata-bugs, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs