[Wikidata-bugs] [Maniphest] [Commented On] T130316: Remove dependency from WikibaseView on StatementRankSerializer in WikibaseRepo
adrianheine added a comment. That would work, too. TASK DETAIL https://phabricator.wikimedia.org/T130316 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: gerritbot, Bene, Aklapper, adrianheine, Lewizho99, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T130316: Remove dependency from WikibaseView on StatementRankSerializer in WikibaseRepo
gerritbot added a comment. Change 278092 merged by jenkins-bot: Remove WikibaseView dependency on StatementRankSerializer https://gerrit.wikimedia.org/r/278092 TASK DETAIL https://phabricator.wikimedia.org/T130316 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Bene, Aklapper, adrianheine, Lewizho99, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T130316: Remove dependency from WikibaseView on StatementRankSerializer in WikibaseRepo
gerritbot added a comment. Change 278092 had a related patch set uploaded (by Adrian Heine): Remove WikibaseView dependency on StatementRankSerializer https://gerrit.wikimedia.org/r/278092 TASK DETAIL https://phabricator.wikimedia.org/T130316 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Bene, Aklapper, adrianheine, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T130316: Remove dependency from WikibaseView on StatementRankSerializer in WikibaseRepo
Bene added a comment. From the class documentation: > @todo this could be moved to DataModelSerialization (in some form) This is exactly what should be done here (+ new methods in the factories). TASK DETAIL https://phabricator.wikimedia.org/T130316 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene Cc: Bene, Aklapper, adrianheine, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs