[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-14 Thread bd808 
bd808 added a comment.


  > Seeing a lot of these in the hhvm.log right now, don't have backtraces 
though.
  
  hhvm.log will never have PHP backtraces. fatal.log will if 
`MWExceptionHandler::handleError` has been notified of the error. One thing 
that should be done is an audit of core and extensions for places where 
`set_error_handler()` is used to change the error handler from 
`MWExceptionHandler::handleError` which knows how to log stacktraces.

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bd808
Cc: bd808, JanZerebecki, aude, Aklapper, hoo, D3r1ck01, Izno, Wikidata-bugs, 
Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-25 Thread bd808 
bd808 added a comment.


  A "Catchable fatal error" getting to the HHVM logs is still a sign that 
`MWExceptionHandler::handleError()` is not the active handler via 
`set_error_handler()` at the time that the exception is raised.
  
  One way you could deal with this at least as a temporary patch is to change 
the signature of 
`Wikibase\Lib\Store\CachingEntityRevisionLookup::getEntityRevision()` so that 
nulls are allowed for `$entityId` and then validate the non-null status inside 
the method. At that point you would be in control of logging the call path.

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bd808
Cc: bd808, JanZerebecki, aude, Aklapper, hoo, D3r1ck01, Izno, Wikidata-bugs, 
Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-25 Thread aude 
aude added a comment.


  this issue happens when trying to view a deleted revision (if you are admin), 
and maybe in other cases.
  
  before, we checked if we got an EntityRevision object and if not, skip 
rendering the term box (return html rendering as empty string):
  
  
https://gerrit.wikimedia.org/r/#/c/21/5/view/src/EntityViewPlaceholderExpander.php
  
  We need to re-introduce such a check in the code, though in a way that keeps 
EntityRevisionLookup out of EntityViewPlaceholderExpander.

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aude
Cc: bd808, JanZerebecki, aude, Aklapper, hoo, D3r1ck01, Izno, Wikidata-bugs, 
Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-25 Thread gerritbot 
gerritbot added a comment.


  Change 285289 had a related patch set uploaded (by Aude):
  Fix fatal error in OutputPageBeforeHTMLHookHandler
  
  https://gerrit.wikimedia.org/r/285289

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, bd808, JanZerebecki, aude, Aklapper, hoo, D3r1ck01, Izno, 
Wikidata-bugs, Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-26 Thread gerritbot 
gerritbot added a comment.


  Change 285405 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
  Fix minor code style issues in OutputPageBeforeHTMLHookHandler
  
  https://gerrit.wikimedia.org/r/285405

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, bd808, JanZerebecki, aude, Aklapper, hoo, Lewizho99, Maathavan, 
D3r1ck01, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-26 Thread gerritbot 
gerritbot added a comment.


  Change 285289 merged by jenkins-bot:
  Fix fatal error in OutputPageBeforeHTMLHookHandler
  
  https://gerrit.wikimedia.org/r/285289

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, bd808, JanZerebecki, aude, Aklapper, hoo, Lewizho99, Maathavan, 
D3r1ck01, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-26 Thread gerritbot 
gerritbot added a comment.


  Change 285405 merged by jenkins-bot:
  Fix minor code style issues in OutputPageBeforeHTMLHookHandler
  
  https://gerrit.wikimedia.org/r/285405

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, bd808, JanZerebecki, aude, Aklapper, hoo, Lewizho99, Maathavan, 
D3r1ck01, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-26 Thread gerritbot 
gerritbot added a comment.


  Change 285417 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
  Add deleted revisions test for OutputPageBeforeHTMLHookHandler
  
  https://gerrit.wikimedia.org/r/285417

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, bd808, JanZerebecki, aude, Aklapper, hoo, Lewizho99, Maathavan, 
D3r1ck01, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-26 Thread gerritbot 
gerritbot added a comment.


  Change 285417 merged by jenkins-bot:
  Add deleted revisions test for OutputPageBeforeHTMLHookHandler
  
  https://gerrit.wikimedia.org/r/285417

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, bd808, JanZerebecki, aude, Aklapper, hoo, Lewizho99, Maathavan, 
D3r1ck01, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-26 Thread JanZerebecki 
JanZerebecki added a comment.


  Result from trying to debug this with things like 
`file_put_contents('/tmp/debug.txt', 'info'."\n", FILE_APPEND);` to find how to 
get full back traces:
  
  handleError gets called 2 times with:
  
$level => 4096,
$message => 'Argument 1 passed to 
Wikibase\\Lib\\Store\\CachingEntityRevisionLookup::getEntityRevision() must be 
an instance of Wikibase\\DataModel\\Entity\\EntityId, null given',
$file => 
'/srv/mediawiki/php-1.27.0-wmf.21/extensions/Wikidata/extensions/Wikibase/lib/includes/store/CachingEntityRevisionLookup.php',
$line => 136,
  
  handleFatalError gets called once after that with:
  
$level => 4096,
$message => 'Argument 1 passed to 
Wikibase\\Lib\\Store\\CachingEntityRevisionLookup::getEntityRevision() must be 
an instance of Wikibase\\DataModel\\Entity\\EntityId, null given',
$file => 
'/srv/mediawiki/php-1.27.0-wmf.21/extensions/Wikidata/extensions/Wikibase/lib/includes/store/CachingEntityRevisionLookup.php',
$line => 136,
$context => NULL,
$trace => NULL,
debug_backtrace() =>   array (
  0 => 
  array (
'function' => 'handleFatalError',
'class' => 'MWExceptionHandler',
'type' => '::',
'args' => 
array (
),
  ),
),
  
  If I try to insert a debug_backtrace() or func_get_args() at the beginning of 
handleError things change in ways I didn't understand.

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: JanZerebecki
Cc: gerritbot, bd808, JanZerebecki, aude, Aklapper, hoo, Lewizho99, Maathavan, 
D3r1ck01, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-26 Thread gerritbot 
gerritbot added a comment.


  Change 285557 had a related patch set uploaded (by Aude):
  Fix fatal error in OutputPageBeforeHTMLHookHandler
  
  https://gerrit.wikimedia.org/r/285557

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, bd808, JanZerebecki, aude, Aklapper, hoo, Lewizho99, Maathavan, 
D3r1ck01, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-27 Thread adrianheine 
adrianheine added a comment.


  Fix is merged. Is it deployed? Did the error disappear?

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: adrianheine
Cc: adrianheine, gerritbot, bd808, JanZerebecki, aude, Aklapper, hoo, 
Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-28 Thread hoo 
hoo added a comment.


  In https://phabricator.wikimedia.org/T132645#2242214, @adrianheine wrote:
  
  > Fix is merged. Is it deployed? Did the error disappear?
  
  
  Hasn't been deployed yet… probably should be if possible (@aude @JanZerebecki 
).

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo
Cc: adrianheine, gerritbot, bd808, JanZerebecki, aude, Aklapper, hoo, 
Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-28 Thread aude 
aude added a comment.


  @hoo @JanZerebecki https://gerrit.wikimedia.org/r/#/c/285557/
  
  The change is non-trivial (couldn't just cherry pick) so would prefer someone 
else +2 it.  I have manually tested it on the branch.

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aude
Cc: adrianheine, gerritbot, bd808, JanZerebecki, aude, Aklapper, hoo, 
Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-28 Thread gerritbot 
gerritbot added a comment.


  Change 285557 merged by jenkins-bot:
  Fix fatal error in OutputPageBeforeHTMLHookHandler
  
  https://gerrit.wikimedia.org/r/285557

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: adrianheine, gerritbot, bd808, JanZerebecki, aude, Aklapper, hoo, 
Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-28 Thread aude 
aude added a comment.


  I'm not enthusiastic about overriding jenkins right now and think it would be 
better to try again tomorrow morning (even if it is a Friday).
  
  Maybe @JanZerebecki knows what to do about Echo here?

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aude
Cc: adrianheine, gerritbot, bd808, JanZerebecki, aude, Aklapper, hoo, 
Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-28 Thread JanZerebecki 
JanZerebecki added a comment.


  I was considering doing it after the train is done so I only need to do it 
for one branch.

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: JanZerebecki
Cc: adrianheine, gerritbot, bd808, JanZerebecki, aude, Aklapper, hoo, 
Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-28 Thread hoo 
hoo added a comment.


  In https://phabricator.wikimedia.org/T132645#2248880, @aude wrote:
  
  > @hoo @JanZerebecki https://gerrit.wikimedia.org/r/#/c/285557/
  >
  > The change is non-trivial (couldn't just cherry pick) so would prefer 
someone else +2 it.  I have manually tested it on the branch.
  
  
  I had a look, seems good to deploy to me.

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo
Cc: adrianheine, gerritbot, bd808, JanZerebecki, aude, Aklapper, hoo, 
Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given

2016-04-29 Thread Stashbot 
Stashbot added a comment.


  Mentioned in SAL [2016-04-29T18:21:10Z]  Synchronized 
php-1.27.0-wmf.22/extensions/Wikidata/extensions/Wikibase/repo/includes/Hooks/OutputPageBeforeHTMLHookHandler.php:
 wmf.22 
https://phabricator.wikimedia.org/rMRELfc20c54f7915b94ec0d15ef17e207c116910623d 
2 of 2 https://phabricator.wikimedia.org/T132645 (duration: 00m 28s)

TASK DETAIL
  https://phabricator.wikimedia.org/T132645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stashbot
Cc: Stashbot, adrianheine, gerritbot, bd808, JanZerebecki, aude, Aklapper, hoo, 
Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs