[Wikidata-bugs] [Maniphest] [Commented On] T136619: [Bug] Grunt build breaks stuff on query.wikidata.org
Jonas added a comment. So unfortunately grunt buid: concat and minify is breaking some features in WDQS. TASK DETAIL https://phabricator.wikimedia.org/T136619 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas Cc: Lydia_Pintscher, Smalyshev, Aklapper, johl, Zppix, Avner, debt, Gehel, D3r1ck01, FloNight, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T136619: [Bug] Grunt build breaks stuff on query.wikidata.org
Smalyshev added a comment. @Jonas could you add some info about what is broken in grunt build? TASK DETAIL https://phabricator.wikimedia.org/T136619 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas, Smalyshev Cc: Lydia_Pintscher, Smalyshev, Aklapper, johl, Zppix, Avner, debt, Gehel, D3r1ck01, FloNight, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T136619: [Bug] Grunt build breaks stuff on query.wikidata.org
Jonas added a comment. It seems like vendor/codemirror/addon/hint/show-hint.css gets broken through cssmin TASK DETAIL https://phabricator.wikimedia.org/T136619 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas Cc: Lydia_Pintscher, Smalyshev, Aklapper, johl, Zppix, Avner, debt, Gehel, D3r1ck01, FloNight, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T136619: [Bug] Grunt build breaks stuff on query.wikidata.org
Jonas added a comment. So I found the reason, but not the solution: ;.CodeMirror-hints { position: absolute; z-index: 10; overflow: hidden; list-style: none; margin: 0; padding: 2px; -webkit-box-shadow: 2px 3px 5px rgba(0,0,0,.2); -moz-box-shadow: 2px 3px 5px rgba(0,0,0,.2); box-shadow: 2px 3px 5px rgba(0,0,0,.2); border-radius: 3px; border: 1px solid silver; background: #fff; font-size: 90%; font-family: monospace; max-height: 20em; overflow-y: auto } TASK DETAIL https://phabricator.wikimedia.org/T136619 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas Cc: Lydia_Pintscher, Smalyshev, Aklapper, johl, Zppix, Avner, debt, Gehel, D3r1ck01, FloNight, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T136619: [Bug] Grunt build breaks stuff on query.wikidata.org
gerritbot added a comment. Change 292107 had a related patch set uploaded (by Jonas Kress (WMDE)): Fix cssmin and concat for grunt build https://gerrit.wikimedia.org/r/292107 TASK DETAIL https://phabricator.wikimedia.org/T136619 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas, gerritbot Cc: gerritbot, Lydia_Pintscher, Smalyshev, Aklapper, johl, Zppix, Avner, debt, Gehel, D3r1ck01, FloNight, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T136619: [Bug] Grunt build breaks stuff on query.wikidata.org
gerritbot added a comment. Change 292107 merged by jenkins-bot: Fix cssmin and concat for grunt build https://gerrit.wikimedia.org/r/292107 TASK DETAIL https://phabricator.wikimedia.org/T136619 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas, gerritbot Cc: gerritbot, Lydia_Pintscher, Smalyshev, Aklapper, johl, Zppix, Avner, Lewizho99, Maathavan, debt, Gehel, D3r1ck01, FloNight, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs