[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-06-27 Thread gerritbot
gerritbot added a comment.
Change 296342 had a related patch set uploaded (by Jhobs):
Refactor wikibase config variables to be less confusing

https://gerrit.wikimedia.org/r/296342TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhobs, gerritbotCc: gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, D3r1ck01, Izno, Wikidata-bugs, aude, fbstj, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-05 Thread phuedx
phuedx added a comment.
^ Fixing a failing unit test case shouldn't block an initial review…TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedxCc: phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-11 Thread gerritbot
gerritbot added a comment.
Change 298262 had a related patch set uploaded (by Phuedx):
Extend MobileContext#shouldShowWikibaseDescriptions

https://gerrit.wikimedia.org/r/298262TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, gerritbotCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-11 Thread gerritbot
gerritbot added a comment.
Change 298261 had a related patch set uploaded (by Phuedx):
Add MobileContext#shouldShowWikibaseDescriptions

https://gerrit.wikimedia.org/r/298261TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, gerritbotCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-11 Thread phuedx
phuedx added a comment.
There are two more changes to add to this sequence: the introduction of $wgMFDisplayWikibaseDescriptions and the extendSearchParams function, both of which I'm extracting currently…TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedxCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-11 Thread gerritbot
gerritbot added a comment.
Change 298263 had a related patch set uploaded (by Phuedx):
Deprecate $wgMFUseWikibaseDescription

https://gerrit.wikimedia.org/r/298263TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, gerritbotCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-12 Thread gerritbot
gerritbot added a comment.
Change 298426 had a related patch set uploaded (by Phuedx):
Deprecate $wgMFDisplayWikibaseDescription

https://gerrit.wikimedia.org/r/298426TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, gerritbotCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-12 Thread gerritbot
gerritbot added a comment.
Change 298430 had a related patch set uploaded (by Phuedx):
Add wgMFDisplayWikibaseDescriptions to RL config

https://gerrit.wikimedia.org/r/298430TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, gerritbotCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-12 Thread gerritbot
gerritbot added a comment.
Change 298432 had a related patch set uploaded (by Phuedx):
Use wgMFDisplayWikibaseDescriptions in client

https://gerrit.wikimedia.org/r/298432TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, gerritbotCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-12 Thread gerritbot
gerritbot added a comment.
Change 298433 had a related patch set uploaded (by Phuedx):
Further split $wgMFDisplayWikibaseDescriptions

https://gerrit.wikimedia.org/r/298433TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, gerritbotCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-12 Thread gerritbot
gerritbot added a comment.
Change 298434 had a related patch set uploaded (by Phuedx):
Add extendSearchParams helper function

https://gerrit.wikimedia.org/r/298434TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, gerritbotCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-12 Thread Jdlrobson
Jdlrobson added a comment.
There are a few open questions on the patchsets (see +1s and -1s) but nothing too major. I hope we can wrap this work up Wednesday - we may want to hangout after standup to do so.TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, JdlrobsonCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-12 Thread gerritbot
gerritbot added a comment.
Change 296342 abandoned by Jdlrobson:
Refactor Wikibase config variables to be less confusing

Reason:
This has now been split up into https://gerrit.wikimedia.org/r/298262 and friends - let's carry conversation over there.

https://gerrit.wikimedia.org/r/296342TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, gerritbotCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-13 Thread gerritbot
gerritbot added a comment.
Change 298261 merged by jenkins-bot:
Add MobileContext#shouldShowWikibaseDescriptions

https://gerrit.wikimedia.org/r/298261TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, gerritbotCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-14 Thread phuedx
phuedx added a comment.
@Jdlrobson: I've responded to your comment. Perhaps we can nip this in the bud immediately before/after standup.TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedxCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-14 Thread gerritbot
gerritbot added a comment.
Change 298262 merged by jenkins-bot:
Extend MobileContext#shouldShowWikibaseDescriptions

https://gerrit.wikimedia.org/r/298262TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, gerritbotCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-14 Thread gerritbot
gerritbot added a comment.
Change 298263 merged by jenkins-bot:
Deprecate $wgMFUseWikibaseDescription

https://gerrit.wikimedia.org/r/298263TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, gerritbotCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-14 Thread gerritbot
gerritbot added a comment.
Change 298426 merged by jenkins-bot:
Deprecate $wgMFDisplayWikibaseDescription

https://gerrit.wikimedia.org/r/298426TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, gerritbotCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-14 Thread gerritbot
gerritbot added a comment.
Change 298430 merged by jenkins-bot:
Add wgMFDisplayWikibaseDescriptions to RL config

https://gerrit.wikimedia.org/r/298430TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, gerritbotCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-14 Thread Jdlrobson
Jdlrobson added a comment.
I'm going to carefully go over the Wikimedia config today to ensure this doesn't interrupt service on any live wikis  given this discussion. Expect subtasks! :)TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, JdlrobsonCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-14 Thread gerritbot
gerritbot added a comment.
Change 298432 merged by jenkins-bot:
Use wgMFDisplayWikibaseDescriptions in client

https://gerrit.wikimedia.org/r/298432TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, gerritbotCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-14 Thread Jdlrobson
Jdlrobson added a comment.
So I had a super close look at this.
We only introduced MFDisplayWikibaseDescriptionsAsTaglines June 27th. Before this change enabling $wgMFUseWikibaseDescription would control the Wikidata description tagline. We've now deprecated this config variable 2 weeks later in favour of $wgMFDisplayWikibaseDescriptions = [ 'tagline' => true ].

The result of this is any site using the sole config variable $wgMFUseWikibaseDescription = true from before June 27th to show taglines who upgrades will now lose their tagline unless they turn on $wgMFDisplayWikibaseDescriptions immediately.

This is all very confusing and I doubt many people are using Wikibase for this purpose so I think we should just accept this is the case.

Another engineer should feel free to sign off knowing the above BUT they should open a new task for next sprint to remove all the deprecated config variables as soon as these changes are live everywhere (from 21st July 2016).TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, JdlrobsonCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-14 Thread jhobs
jhobs added a comment.

In T138788#2463523, @Jdlrobson wrote:
So I had a super close look at this.
 We only introduced MFDisplayWikibaseDescriptionsAsTaglines June 27th. Before this change enabling $wgMFUseWikibaseDescription would control the Wikidata description tagline. We've now deprecated this config variable 2 weeks later in favour of $wgMFDisplayWikibaseDescriptions = [ 'tagline' => true ].


Just for context: This was because it was expected that there would be a slight overhaul on these config variables shortly after introducing $wgMFDisplayWikibaseDescriptionsAsTaglines, but it was not expected that the most appropriate solution would be to use $wgMFDisplayWikibaseDescriptions as an object (although it was known to be a potential solution). It took more investigation to determine that was the path forward. I think the slight confusion here in terms of refactoring a new variable immediately is understandable and permissible given that we're doing it in such a close timeframe (and it was announced in the original task that a follow-up refactoring would be done).TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, jhobsCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-14 Thread jhobs
jhobs added a comment.

In T138788#2463523, @Jdlrobson wrote:
Another engineer should feel free to sign off knowing the above BUT they should open a new task for next sprint to remove all the deprecated config variables as soon as these changes are live everywhere (from 21st July 2016).


As someone who contributed a fair amount to this task, I'd rather leave this to someone with fresher eyes.TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: phuedx, jhobsCc: Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-15 Thread phuedx
phuedx added a comment.
@Jdlrobson: 298434: Add extendSearchParams helper function and its dependency need to re-reviewed as they didn't get merged for one reason or another…TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jhernandez, phuedxCc: Jhernandez, Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-15 Thread gerritbot
gerritbot added a comment.
Change 298433 merged by jenkins-bot:
Further split $wgMFDisplayWikibaseDescriptions

https://gerrit.wikimedia.org/r/298433TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jhernandez, gerritbotCc: Jhernandez, Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138788: Refactor Wikibase config variables used by MobileFrontend

2016-07-15 Thread gerritbot
gerritbot added a comment.
Change 298434 merged by jenkins-bot:
Add extendSearchParams helper function

https://gerrit.wikimedia.org/r/298434TASK DETAILhttps://phabricator.wikimedia.org/T138788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jhernandez, gerritbotCc: Jhernandez, Liuxinyu970226, bmansurov, phuedx, gerritbot, Aklapper, Jdlrobson, jhobs, Zppix, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs