[Wikidata-bugs] [Maniphest] [Commented On] T145757: N3Quoter should generate correct escapes for ASCII control characters

2016-09-22 Thread Smalyshev
Smalyshev added a comment.
I think this one is done, and we have purtle tests. The parent one we need to verify dump is OK, and then we can close it. Maybe add some tests to dump generator tests too just in case...TASK DETAILhttps://phabricator.wikimedia.org/T145757EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: gerritbot, D063520, Aklapper, Smalyshev, daniel, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T145757: N3Quoter should generate correct escapes for ASCII control characters

2016-09-22 Thread daniel
daniel added a comment.
Should we have a test for this in Wikibase itself, so we can verify it works now? Or can we just close this ticket, since the updated component has been released?TASK DETAILhttps://phabricator.wikimedia.org/T145757EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, danielCc: gerritbot, D063520, Aklapper, Smalyshev, daniel, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T145757: N3Quoter should generate correct escapes for ASCII control characters

2016-09-22 Thread daniel
daniel added a comment.
I can confirm that composer update pulls in purtle 1.0.4 now.TASK DETAILhttps://phabricator.wikimedia.org/T145757EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, danielCc: gerritbot, D063520, Aklapper, Smalyshev, daniel, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T145757: N3Quoter should generate correct escapes for ASCII control characters

2016-09-22 Thread daniel
daniel added a comment.
@Smalyshev Done. Packagist now shows 1.0.4 as the current version. I have also added the wikimedia and mediawiki users as maintainers.TASK DETAILhttps://phabricator.wikimedia.org/T145757EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, danielCc: gerritbot, D063520, Aklapper, Smalyshev, daniel, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T145757: N3Quoter should generate correct escapes for ASCII control characters

2016-09-21 Thread Smalyshev
Smalyshev added a comment.
@daniel I've made a tag, could you kick it on packagist to update? You seem to be have the rights there, I don't :)TASK DETAILhttps://phabricator.wikimedia.org/T145757EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: gerritbot, D063520, Aklapper, Smalyshev, daniel, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T145757: N3Quoter should generate correct escapes for ASCII control characters

2016-09-16 Thread daniel
daniel added a comment.
If the right github repo has the right web-hook set up, then it usually does. Unless it doesn't. But I don't think we have it set for the replicated repo.TASK DETAILhttps://phabricator.wikimedia.org/T145757EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, danielCc: gerritbot, D063520, Aklapper, Smalyshev, daniel, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T145757: N3Quoter should generate correct escapes for ASCII control characters

2016-09-16 Thread Smalyshev
Smalyshev added a comment.
I thought packagist auto-updates when you push new tag? May depend on settings though.TASK DETAILhttps://phabricator.wikimedia.org/T145757EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: gerritbot, D063520, Aklapper, Smalyshev, daniel, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T145757: N3Quoter should generate correct escapes for ASCII control characters

2016-09-16 Thread daniel
daniel added a comment.
Note: this still needs a release, so wikibase starts using the new version. We'll probably have to poke packagist to pick up the new tag.TASK DETAILhttps://phabricator.wikimedia.org/T145757EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, danielCc: gerritbot, D063520, Aklapper, Smalyshev, daniel, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T145757: N3Quoter should generate correct escapes for ASCII control characters

2016-09-16 Thread gerritbot
gerritbot added a comment.
Change 310918 merged by jenkins-bot:
Fix escaping \a and \v which should be numeric in n3/turtle

https://gerrit.wikimedia.org/r/310918TASK DETAILhttps://phabricator.wikimedia.org/T145757EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, gerritbotCc: gerritbot, D063520, Aklapper, Smalyshev, daniel, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T145757: N3Quoter should generate correct escapes for ASCII control characters

2016-09-15 Thread gerritbot
gerritbot added a comment.
Change 310918 had a related patch set uploaded (by Smalyshev):
Fix escaping \a and \v which should be numeric in n3/turtle

https://gerrit.wikimedia.org/r/310918TASK DETAILhttps://phabricator.wikimedia.org/T145757EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, D063520, Aklapper, Smalyshev, daniel, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs