[Wikidata-bugs] [Maniphest] [Commented On] T153076: InvalidArgumentException: "Could not load data from the database of repository" in invalid wbgetentities calls

2016-12-13 Thread WMDE-leszek 
WMDE-leszek added a comment.
Silly question, why is it asking for ids=PROPERTY:P120 but not ids=P120.
While working on federation we decided that using a prefix with a colon would be used to state what repository the entity belongs to. So while asking the API for PROPERTY:P120 lookups tries to access repo PROPERTY which is obviously not configured etc.
Did we miss some important usage here and should not be making such assumption?TASK DETAILhttps://phabricator.wikimedia.org/T153076EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Aklapper, thiemowmde, aude, WMDE-leszek, daniel, hoo, D3r1ck01, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T153076: InvalidArgumentException: "Could not load data from the database of repository" in invalid wbgetentities calls

2016-12-13 Thread WMDE-leszek 
WMDE-leszek added a comment.
Agreed. I'll try to fix the code using the lookup so it handles the exception.TASK DETAILhttps://phabricator.wikimedia.org/T153076EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: TerraCodes, Lydia_Pintscher, Aklapper, thiemowmde, aude, WMDE-leszek, daniel, hoo, JakeTheDeveloper, D3r1ck01, MuhammadShuaib, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T153076: InvalidArgumentException: "Could not load data from the database of repository" in invalid wbgetentities calls

2016-12-13 Thread gerritbot 
gerritbot added a comment.
Change 326970 had a related patch set uploaded (by WMDE-leszek):
Make API wbgetentities skip entities from unknown repositories

https://gerrit.wikimedia.org/r/326970TASK DETAILhttps://phabricator.wikimedia.org/T153076EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, gerritbotCc: gerritbot, TerraCodes, Lydia_Pintscher, Aklapper, thiemowmde, aude, WMDE-leszek, daniel, hoo, JakeTheDeveloper, D3r1ck01, MuhammadShuaib, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T153076: InvalidArgumentException: "Could not load data from the database of repository" in invalid wbgetentities calls

2016-12-13 Thread daniel 
daniel added a comment.
@WMDE-leszek regarding Property:P123: that's the page title of P123. Using page titles instead of entity IDs is a common mistake. In the past, IDs could not contain a oclon, so they would just bounce as malformed. Now they look like foreign IDs from an unknown repo, so they hit a different code path, and fail in a different way. We should indeed make sure that this is handled gracefully.

Btw, I hope nobody gets the idea of using "property" as a repo prefix repo prefixes and namespaces should not conflict. But this is really no different from MediaWiki's normal interwiki prefixes. They also compete with wiki namespaces as title prefixes.TASK DETAILhttps://phabricator.wikimedia.org/T153076EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, danielCc: gerritbot, TerraCodes, Lydia_Pintscher, Aklapper, thiemowmde, aude, WMDE-leszek, daniel, hoo, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T153076: InvalidArgumentException: "Could not load data from the database of repository" in invalid wbgetentities calls

2016-12-21 Thread gerritbot 
gerritbot added a comment.
Change 328488 had a related patch set uploaded (by WMDE-leszek):
Skip invalid entity ids in PrefetchingWikiPageEntityMetaDataAccessor

https://gerrit.wikimedia.org/r/328488TASK DETAILhttps://phabricator.wikimedia.org/T153076EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, gerritbotCc: gerritbot, TerraCodes, Lydia_Pintscher, Aklapper, thiemowmde, aude, WMDE-leszek, daniel, hoo, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T153076: InvalidArgumentException: "Could not load data from the database of repository" in invalid wbgetentities calls

2016-12-21 Thread gerritbot 
gerritbot added a comment.
Change 328488 merged by jenkins-bot:
Skip invalid entity ids in PrefetchingWikiPageEntityMetaDataAccessor

https://gerrit.wikimedia.org/r/328488TASK DETAILhttps://phabricator.wikimedia.org/T153076EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, gerritbotCc: gerritbot, TerraCodes, Lydia_Pintscher, Aklapper, thiemowmde, aude, WMDE-leszek, daniel, hoo, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T153076: InvalidArgumentException: "Could not load data from the database of repository" in invalid wbgetentities calls

2016-12-21 Thread gerritbot 
gerritbot added a comment.
Change 326970 merged by jenkins-bot:
Make API wbgetentities skip entities from unknown repositories

https://gerrit.wikimedia.org/r/326970TASK DETAILhttps://phabricator.wikimedia.org/T153076EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, gerritbotCc: gerritbot, TerraCodes, Lydia_Pintscher, Aklapper, thiemowmde, aude, WMDE-leszek, daniel, hoo, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs