[Wikidata-bugs] [Maniphest] [Commented On] T154808: No longer getting Revert notifications
gerritbot added a comment. Change 331466 merged by jenkins-bot: Pass $undidRevId as a parameter to SubmitEntityAction::attemptSave https://gerrit.wikimedia.org/r/331466TASK DETAILhttps://phabricator.wikimedia.org/T154808EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Niedzielski, Trizek-WMF, Lea_Lacroix_WMDE, Scott_WUaS, Lydia_Pintscher, Cenarium, gerritbot, Mholloway, matej_suchanek, Aklapper, Dbrant, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, SBisson, Luke081515, Wikidata-bugs, aude, Catrope, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T154808: No longer getting Revert notifications
gerritbot added a comment. Change 331155 merged by jenkins-bot: Pass undone revision id for further proccessing https://gerrit.wikimedia.org/r/331155TASK DETAILhttps://phabricator.wikimedia.org/T154808EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Niedzielski, Trizek-WMF, Lea_Lacroix_WMDE, Scott_WUaS, Lydia_Pintscher, Cenarium, gerritbot, Mholloway, matej_suchanek, Aklapper, Dbrant, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, SBisson, Luke081515, Wikidata-bugs, aude, Catrope, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T154808: No longer getting Revert notifications
gerritbot added a comment. Change 331466 had a related patch set uploaded (by Thiemo Mättig (WMDE)): This is mostly for readability of the code. Before it was not obvious that the attemptSave() method was only called for undo operations. Now this is much more obvious. https://gerrit.wikimedia.org/r/331466TASK DETAILhttps://phabricator.wikimedia.org/T154808EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Niedzielski, Trizek-WMF, Lea_Lacroix_WMDE, Scott_WUaS, Lydia_Pintscher, Cenarium, gerritbot, Mholloway, matej_suchanek, Aklapper, Dbrant, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, SBisson, Luke081515, Wikidata-bugs, aude, Catrope, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T154808: No longer getting Revert notifications
gerritbot added a comment. Change 331155 had a related patch set uploaded (by Matěj Suchánek): Pass undone revision id for further proccessing https://gerrit.wikimedia.org/r/331155TASK DETAILhttps://phabricator.wikimedia.org/T154808EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Mholloway, matej_suchanek, Aklapper, Dbrant, D3r1ck01, Izno, SBisson, Luke081515, Wikidata-bugs, aude, Catrope, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T154808: No longer getting Revert notifications
Dbrant added a comment. Sure, it seems like it's any revision made after 01/05, including: https://www.wikidata.org/w/index.php?title=Q4115189&oldid=425035510 https://www.wikidata.org/w/index.php?title=Q4115189&oldid=424954913 https://www.wikidata.org/w/index.php?title=Q24037694&oldid=425409940 TASK DETAILhttps://phabricator.wikimedia.org/T154808EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DbrantCc: matej_suchanek, Aklapper, Dbrant, D3r1ck01, Izno, SBisson, Luke081515, Wikidata-bugs, aude, Catrope, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T154808: No longer getting Revert notifications
matej_suchanek added a comment. Do you have an example of revert which didn't create a notification?TASK DETAILhttps://phabricator.wikimedia.org/T154808EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: matej_suchanek, Aklapper, Dbrant, D3r1ck01, Izno, SBisson, Luke081515, Wikidata-bugs, aude, Catrope, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs