[Wikidata-bugs] [Maniphest] [Commented On] T158059: harmonize UI for sitelink boxes’ collapse/expand

2018-01-31 Thread thiemowmde
thiemowmde added a comment.
@Jan_Dittrich, I think this ticket was created based on an actual bug, which caused a misunderstanding. There was a bug that caused the collapse/expand button to be shown as plain text "[Expand]" and "[Collapse]" on diff pages and old revisions. This bug is now fixed via https://gerrit.wikimedia.org/r/400684. The collapse/expand button now always looks like it always was intended to look like:

F12919827: image.png

F12919837: image.png

Is this close enough to what was proposed above? Can this ticket be closed?TASK DETAILhttps://phabricator.wikimedia.org/T158059EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: gerritbot, thiemowmde, Hanna_Petruschat_WMDE, Aklapper, Lea_Lacroix_WMDE, Jonas, Lydia_Pintscher, Jan_Dittrich, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, JGirault, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T158059: harmonize UI for sitelink boxes’ collapse/expand

2018-01-31 Thread gerritbot
gerritbot added a comment.
Change 392628 abandoned by Thiemo Kreuz (WMDE):
Fix flash of unstyled content (FOUC) on sitelinkgroupview

Reason:
Indeed. I don't remember why I resubmitted this as a new patch, instead of improving this existing one.

https://gerrit.wikimedia.org/r/392628TASK DETAILhttps://phabricator.wikimedia.org/T158059EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, thiemowmde, Hanna_Petruschat_WMDE, Aklapper, Lea_Lacroix_WMDE, Jonas, Lydia_Pintscher, Jan_Dittrich, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, JGirault, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T158059: harmonize UI for sitelink boxes’ collapse/expand

2017-11-21 Thread gerritbot
gerritbot added a comment.
Change 392628 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix flash of unstyled content (FOUC) on sitelinkgroupview

https://gerrit.wikimedia.org/r/392628TASK DETAILhttps://phabricator.wikimedia.org/T158059EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, thiemowmde, Hanna_Petruschat_WMDE, Aklapper, Lea_Lacroix_WMDE, Jonas, Lydia_Pintscher, Jan_Dittrich, Lahi, Gq86, GoranSMilovanovic, QZanden, JGirault, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T158059: harmonize UI for sitelink boxes’ collapse/expand

2017-11-21 Thread Hanna_Petruschat_WMDE
Hanna_Petruschat_WMDE added a comment.
Update: It seems that somebody independently took care of this issue. There is some improvement but it is still an issue as the "[collapse]" is visible in the first place and just later gets replaced by an arrow.

@Lydia_Pintscher Do you know who implemented this and/or is there another ticket that we can comment on?TASK DETAILhttps://phabricator.wikimedia.org/T158059EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Hanna_Petruschat_WMDECc: Hanna_Petruschat_WMDE, Aklapper, Lea_Lacroix_WMDE, Jonas, Lydia_Pintscher, Jan_Dittrich, Lahi, Gq86, GoranSMilovanovic, QZanden, JGirault, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs