[Wikidata-bugs] [Maniphest] [Commented On] T160656: Build EntityDiffViewFactory for different entity types and use it in EntityDiffVisualizer

2017-10-06 Thread gerritbot 
gerritbot added a comment.
Change 382739 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Decouple DiffView and RequestContext

https://gerrit.wikimedia.org/r/382739TASK DETAILhttps://phabricator.wikimedia.org/T160656EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, WMDE-leszek, daniel, Aklapper, Ladsgroup, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T160656: Build EntityDiffViewFactory for different entity types and use it in EntityDiffVisualizer

2017-10-09 Thread gerritbot 
gerritbot added a comment.
Change 382739 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Decouple DiffView and RequestContext

https://gerrit.wikimedia.org/r/382739TASK DETAILhttps://phabricator.wikimedia.org/T160656EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, WMDE-leszek, daniel, Aklapper, Ladsgroup, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T160656: Build EntityDiffViewFactory for different entity types and use it in EntityDiffVisualizer

2017-10-13 Thread gerritbot 
gerritbot added a comment.
Change 384051 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Introduce 'entity-diff-visualizer-callback' in entity type definitions

https://gerrit.wikimedia.org/r/384051TASK DETAILhttps://phabricator.wikimedia.org/T160656EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, WMDE-leszek, daniel, Aklapper, Ladsgroup, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T160656: Build EntityDiffViewFactory for different entity types and use it in EntityDiffVisualizer

2017-10-17 Thread gerritbot 
gerritbot added a comment.
Change 384051 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce 'entity-diff-visualizer-callback' in entity type definitions

https://gerrit.wikimedia.org/r/384051TASK DETAILhttps://phabricator.wikimedia.org/T160656EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, WMDE-leszek, daniel, Aklapper, Ladsgroup, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T160656: Build EntityDiffViewFactory for different entity types and use it in EntityDiffVisualizer

2017-10-17 Thread gerritbot 
gerritbot added a comment.
Change 345091 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce DispatchingEntityDiffVisualizer and EntityDiffVisualizerFactory

https://gerrit.wikimedia.org/r/345091TASK DETAILhttps://phabricator.wikimedia.org/T160656EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, WMDE-leszek, daniel, Aklapper, Ladsgroup, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T160656: Build EntityDiffViewFactory for different entity types and use it in EntityDiffVisualizer

2017-03-22 Thread Ladsgroup 
Ladsgroup added a comment.
I started it by doing something very simple: Renaming EntityDiffVisualizer to BasicEntityDiffVisualizer. once this is merged (or in a followup) I make a patch for adding EntityDiffVisualizer as an interface. In a follow-up patch, I make the DispatchingEntityDiffVisualizer then ItemEntityDiffVisualizer.TASK DETAILhttps://phabricator.wikimedia.org/T160656EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: WMDE-leszek, daniel, Aklapper, Ladsgroup, QZanden, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T160656: Build EntityDiffViewFactory for different entity types and use it in EntityDiffVisualizer

2017-03-22 Thread gerritbot 
gerritbot added a comment.
Change 344146 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Rename EntityDiffVisualizer to BasicEntityDiffVisualizer

https://gerrit.wikimedia.org/r/344146TASK DETAILhttps://phabricator.wikimedia.org/T160656EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, WMDE-leszek, daniel, Aklapper, Ladsgroup, QZanden, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T160656: Build EntityDiffViewFactory for different entity types and use it in EntityDiffVisualizer

2017-03-22 Thread Ladsgroup 
Ladsgroup added a comment.
Made https://gerrit.wikimedia.org/r/344175 now to add the interface and use it. Dispatching will be in another patch.TASK DETAILhttps://phabricator.wikimedia.org/T160656EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: gerritbot, WMDE-leszek, daniel, Aklapper, Ladsgroup, QZanden, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T160656: Build EntityDiffViewFactory for different entity types and use it in EntityDiffVisualizer

2017-03-24 Thread gerritbot 
gerritbot added a comment.
Change 344175 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce EntityDiffVisualizer interface and use it in BasicEntityDiffVisualizer

https://gerrit.wikimedia.org/r/344175TASK DETAILhttps://phabricator.wikimedia.org/T160656EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, WMDE-leszek, daniel, Aklapper, Ladsgroup, QZanden, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T160656: Build EntityDiffViewFactory for different entity types and use it in EntityDiffVisualizer

2017-03-27 Thread Ladsgroup 
Ladsgroup added a comment.
Given that gerritbot still doesn't want to add comment when I make a patch:


https://gerrit.wikimedia.org/r/344943 Add $entity attribute to EntityContentDiff
TASK DETAILhttps://phabricator.wikimedia.org/T160656EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: gerritbot, WMDE-leszek, daniel, Aklapper, Ladsgroup, QZanden, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T160656: Build EntityDiffViewFactory for different entity types and use it in EntityDiffVisualizer

2017-03-30 Thread gerritbot 
gerritbot added a comment.
Change 344943 merged by Daniel Kinzler:
[mediawiki/extensions/Wikibase@master] Add $entityType attribute to EntityContentDiff

https://gerrit.wikimedia.org/r/344943TASK DETAILhttps://phabricator.wikimedia.org/T160656EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, WMDE-leszek, daniel, Aklapper, Ladsgroup, QZanden, Salgo60, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T160656: Build EntityDiffViewFactory for different entity types and use it in EntityDiffVisualizer

2017-04-12 Thread Ladsgroup 
Ladsgroup added a comment.
For the record there is a very basic patch: https://gerrit.wikimedia.org/r/#/c/345091/TASK DETAILhttps://phabricator.wikimedia.org/T160656EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: gerritbot, WMDE-leszek, daniel, Aklapper, Ladsgroup, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs